Ticket #17419: 17419.formatted.1.diff

Index: wp-admin/includes/class-wp-media-list-table.php
===================================================================
--- wp-admin/includes/class-wp-media-list-table.php     (revision 18725)
+++ wp-admin/includes/class-wp-media-list-table.php     (working copy)
@@ -163,6 +163,7 @@
                $alt = '';
 
                while ( have_posts() ) : the_post();
+                       $user_can_edit = current_user_can( 'edit_post', $post->ID );
 
                        if ( $this->is_trash && $post->post_status != 'trash'
                        ||  !$this->is_trash && $post->post_status == 'trash' )
@@ -189,7 +190,11 @@
 
        case 'cb':
 ?>
-               <th scope="row" class="check-column"><?php if ( current_user_can( 'edit_post', $post->ID ) ) { ?><input type="checkbox" name="media[]" value="<?php the_ID(); ?>" /><?php } ?></th>
+               <th scope="row" class="check-column">
+                       <?php if ( $user_can_edit ) { ?>
+                               <input type="checkbox" name="media[]" value="<?php the_ID(); ?>" />
+                       <?php } ?>
+               </th>
 <?php
                break;
 
@@ -198,7 +203,7 @@
 ?>
                <td <?php echo $attributes ?>><?php
                        if ( $thumb = wp_get_attachment_image( $post->ID, array( 80, 60 ), true ) ) {
-                               if ( $this->is_trash ) {
+                               if ( $this->is_trash || ! $user_can_edit ) {
                                        echo $thumb;
                                } else {
 ?>
@@ -215,7 +220,15 @@
 
        case 'title':
 ?>
-               <td <?php echo $attributes ?>><strong><?php if ( $this->is_trash ) echo $att_title; else { ?><a href="<?php echo get_edit_post_link( $post->ID, true ); ?>" title="<?php echo esc_attr( sprintf( __( 'Edit &#8220;%s&#8221;' ), $att_title ) ); ?>"><?php echo $att_title; ?></a><?php }; _media_states( $post ); ?></strong>
+               <td <?php echo $attributes ?>><strong>
+                       <?php if ( $this->is_trash || ! $user_can_edit ) {
+                               echo $att_title;
+                       } else { ?>
+                       <a href="<?php echo get_edit_post_link( $post->ID, true ); ?>"
+                               title="<?php echo esc_attr( sprintf( __( 'Edit &#8220;%s&#8221;' ), $att_title ) ); ?>">
+                               <?php echo $att_title; ?></a>
+                       <?php };
+                       _media_states( $post ); ?></strong>
                        <p>
 <?php
                        if ( preg_match( '/^.*?\.(\w+)$/', get_attached_file( $post->ID ), $matches ) )
@@ -287,15 +300,25 @@
                                $title =_draft_or_post_title( $post->post_parent );
                        }
 ?>
-                       <td <?php echo $attributes ?>>
-                               <strong><a href="<?php echo get_edit_post_link( $post->post_parent ); ?>"><?php echo $title ?></a></strong>,
+                       <td <?php echo $attributes ?>><strong>
+                               <?php if( current_user_can( 'edit_post', $post->post_parent ) ) { ?>
+                                       <a href="<?php echo get_edit_post_link( $post->post_parent ); ?>">
+                                               <?php echo $title ?></a>
+                               <?php } else { 
+                                       echo $title; 
+                               } ?></strong>,
                                <?php echo get_the_time( __( 'Y/m/d' ) ); ?>
                        </td>
 <?php
                } else {
 ?>
                        <td <?php echo $attributes ?>><?php _e( '(Unattached)' ); ?><br />
-                       <a class="hide-if-no-js" onclick="findPosts.open( 'media[]','<?php echo $post->ID ?>' );return false;" href="#the-list"><?php _e( 'Attach' ); ?></a></td>
+                       <?php if( $user_can_edit ) {?>
+                               <a class="hide-if-no-js"
+                                       onclick="findPosts.open( 'media[]','<?php echo $post->ID ?>' ); return false;"
+                                       href="#the-list">
+                                       <?php _e( 'Attach' ); ?></a>
+                       <?php } ?></td>
 <?php
                }
                break;