Ticket #51184: 51184.patch

src/wp-includes/comment-template.php

@@ -544 +544 @@
  * @since 1.5.0
  * @since 4.4.0 Added the ability for `$comment_ID` to also accept a WP_Comment object.
  *
- * @param string         $format     Optional. The format of the date. Default user's setting.
+ * @param string|false         $format     Optional. The format of the date. Default user's setting.
  * @param int|WP_Comment $comment_ID WP_Comment or ID of the comment for which to get the date.
  *                                   Default current comment.
  * @return string The comment's date.
@@ -552 +552 @@
 function get_comment_date( $format = '', $comment_ID = 0 ) {
         $comment = get_comment( $comment_ID );
 
-        if ( '' === $format ) {
+        if ( is_string( $format ) && '' !== $format ) {
                 $date = mysql2date( get_option( 'date_format' ), $comment->comment_date );
         } else {
                 $date = mysql2date( $format, $comment->comment_date );
@@ -1035 +1035 @@
  *
  * @since 1.5.0
  *
- * @param string $format    Optional. The format of the time. Default user's settings.
+ * @param string|false $format    Optional. The format of the time. Default user's settings.
  * @param bool   $gmt       Optional. Whether to use the GMT date. Default false.
  * @param bool   $translate Optional. Whether to translate the time (for use in feeds).
  *                          Default true.
@@ -1046 +1046 @@
 
         $comment_date = $gmt ? $comment->comment_date_gmt : $comment->comment_date;
 
-        if ( '' === $format ) {
+        if ( is_string( $format ) && '' !== $format ) {
                 $date = mysql2date( get_option( 'time_format' ), $comment_date, $translate );
         } else {
                 $date = mysql2date( $format, $comment_date, $translate );

src/wp-includes/general-template.php

@@ -2514 +2514 @@
  *
  * @since 3.0.0
  *
- * @param string      $format Optional. PHP date format defaults to the date_format option if not specified.
+ * @param string|false      $format Optional. PHP date format defaults to the date_format option if not specified.
  * @param int|WP_Post $post   Optional. Post ID or WP_Post object. Default current post.
  * @return string|false Date the current post was written. False on failure.
  */
@@ -2525 +2525 @@
                 return false;
         }
 
-        if ( '' === $format ) {
+        if ( is_string( $format ) && '' !== $format ) {
                 $the_date = get_post_time( get_option( 'date_format' ), false, $post, true );
         } else {
                 $the_date = get_post_time( $format, false, $post, true );
@@ -2640 +2640 @@
  *
  * @since 1.5.0
  *
- * @param string      $format Optional. Format to use for retrieving the time the post
+ * @param string|false      $format Optional. Format to use for retrieving the time the post
  *                            was written. Either 'G', 'U', or PHP date format defaults
  *                            to the value specified in the time_format option. Default empty.
  * @param int|WP_Post $post   WP_Post object or ID. Default is global `$post` object.
@@ -2654 +2654 @@
                 return false;
         }
 
-        if ( '' === $format ) {
+        if ( is_string( $format ) && '' !== $format ) {
                 $the_time = get_post_time( get_option( 'time_format' ), false, $post, true );
         } else {
                 $the_time = get_post_time( $format, false, $post, true );