Ticket #5422: 5422.2.patch

wp-admin/includes/update.php

@@ -151 +151 @@
                 return false;
 
         $r = $current->response[ $file ];
-
+        
+        $plugins_allowedtags = array('a' => array('href' => array(),'title' => array()),'abbr' => array('title' => array()),'acronym' => array('title' => array()),'code' => array(),'em' => array(),'strong' => array());
+        $plugin_name = wp_kses( $plugin_data['Name'], $plugins_allowedtags );
+        
         $details_url = admin_url('plugin-install.php?tab=plugin-information&plugin=' . $r->slug . '&TB_iframe=true&width=600&height=800');
 
         echo '<tr><td colspan="5" class="plugin-update">';
         if ( ! current_user_can('update_plugins') )
-                printf( __('There is a new version of %1$s available. <a href="%2$s" class="thickbox" title="%1$s">View version %3$s Details</a>.'), $plugin_data['Name'], $details_url, $r->new_version);
+                printf( __('There is a new version of %1$s available. <a href="%2$s" class="thickbox" title="%4$s">View version %3$s Details</a>.'), $plugin_name, attr($details_url), $r->new_version, attr($plugin_name));
         else if ( empty($r->package) )
-                printf( __('There is a new version of %1$s available. <a href="%2$s" class="thickbox" title="%1$s">View version %3$s Details</a> <em>automatic upgrade unavailable for this plugin</em>.'), $plugin_data['Name'], $details_url, $r->new_version);
+                printf( __('There is a new version of %1$s available. <a href="%2$s" class="thickbox" title="%4$s">View version %3$s Details</a> <em>automatic upgrade unavailable for this plugin</em>.'), $plugin_name, attr($details_url), $r->new_version, attr($plugin_name));
         else
-                printf( __('There is a new version of %1$s available. <a href="%2$s" class="thickbox" title="%1$s">View version %3$s Details</a> or <a href="%4$s">upgrade automatically</a>.'), $plugin_data['Name'], $details_url, $r->new_version, wp_nonce_url('update.php?action=upgrade-plugin&amp;plugin=' . $file, 'upgrade-plugin_' . $file) );
+                printf( __('There is a new version of %1$s available. <a href="%2$s" class="thickbox" title="%4$s">View version %3$s Details</a> or <a href="%5$s">upgrade automatically</a>.'), $plugin_name, attr($details_url), $r->new_version, attr($plugin_name), wp_nonce_url('update.php?action=upgrade-plugin&amp;plugin=' . $file, attr('upgrade-plugin_' . $file)) );
 
         echo '</td></tr>';
 }