Ticket #5599: 5599.diff

streams.php

@@ -26 +26 @@
 
  */
 
+ //------------------------------------ BUGFIX related to WordPress 2.5.x upto 2.6.0 -----------------------------------------------------------
+ // all contained patches have been marked with BUGFIX-HR handling the the issues of "mbstring.func_overload = x" 
+ // where x & 2 != 0 (str* function overloads)
+ // this bug at WordPress forces any translation file to fail with gettext / unpack errors and maximum runtime exceeded fatal stop
+ // Autor: Heiko Rabe  info@code-styling.de
+ //-------------------------------------------------------------------------------------------------------------------------------------------------------------
 
 // Simple class to wrap file streams, string streams, etc.
 // seek is essential, and it should be byte stream
@@ -58 +64 @@
   function StringReader($str='') {
     $this->_str = $str;
     $this->_pos = 0;
+        //BUGFIX-HR: 2008-07-21 we have to detect, if we need mb_str* functions instead of normal functions !
+        $this->is_overloaded = ((ini_get("mbstring.func_overload") & 2) != 0) && function_exists('mb_substr');
   }
 
   function read($bytes) {
+        //BUGFIX-HR: 2008-07-21 if we are overloaded, use the mb_str* functions
+        if ($this->is_overloaded) return $this->mb_read($bytes);
     $data = substr($this->_str, $this->_pos, $bytes);
     $this->_pos += $bytes;
     if (strlen($this->_str)<$this->_pos)
@@ -68 +78 @@
 
     return $data;
   }
+  
+  //BUGFIX-HR: 2008-07-21 corresponding multi byte method
+  function mb_read($bytes) {
+    $data = mb_substr($this->_str, $this->_pos, $bytes, 'ascii');
+    $this->_pos += $bytes;
+    if (mb_strlen($this->_str, 'ascii')<$this->_pos)
+      $this->_pos = mb_strlen($this->_str, 'ascii');
 
+    return $data;
+  }
+
   function seekto($pos) {
+        //BUGFIX-HR: 2008-07-21 if we are overloaded, use the mb_str* functions
+        if ($this->is_overloaded) return $this->mb_seekto($pos);
     $this->_pos = $pos;
     if (strlen($this->_str)<$this->_pos)
       $this->_pos = strlen($this->_str);
     return $this->_pos;
   }
+  
+  //BUGFIX-HR: 2008-07-21 corresponding multi byte method
+  function mb_seekto($pos) {
+    $this->_pos = $pos;
+    if (mb_strlen($this->_str, 'ascii')<$this->_pos)
+      $this->_pos = mb_strlen($this->_str, 'ascii');
+    return $this->_pos;
+  }
 
   function currentpos() {
     return $this->_pos;
   }
-
+  
   function length() {
+        //BUGFIX-HR: 2008-07-21 if we are overloaded, use the mb_str* functions
+        if ($this->is_overloaded) return $this->mb_length();
     return strlen($this->_str);
   }
 
+  //BUGFIX-HR: 2008-07-21 corresponding multi byte method
+  function mb_length() {
+        return mb_strlen($this->str, 'ascii');
+  }
+  
 }
 
 
@@ -149 +186 @@
 // over it (it assumes knowledge of StringReader internals)
 class CachedFileReader extends StringReader {
   function CachedFileReader($filename) {
+        parent::StringReader(); //BUGFIX-HR: 2008-07-21 missing parent constructor call
     if (file_exists($filename)) {
 
       $length=filesize($filename);
       $fd = fopen($filename,'rb');
 
       if (!$fd) {
-        $this->error = 3; // Cannot read file, probably permissions
-        return false;
+                $this->error = 3; // Cannot read file, probably permissions
+                return false;
       }
       $this->_str = fread($fd, $length);
-          $this->_pos = 0;
+//BUGFIX-HR: 2008-07-21 not longer nessessary, cause parent contructor properly called now
+//        $this->_pos = 0;
           fclose($fd);
 
     } else {