Changeset 22747

Timestamp:

11/21/2012 11:50:30 AM (11 years ago)

Author:

nacin

Message:

Stop inserting title attributes for images inserted into the editor by modifying get_image_send_to_editor(), not the generic get_image_tag().

see #18984, [22409].

Location:

trunk

Files:

• wp-admin/includes/media.php (modified) (1 diff)
• wp-includes/media.php (modified) (1 diff)

trunk/wp-admin/includes/media.php

@@ -107 +107 @@
 function get_image_send_to_editor($id, $caption, $title, $align, $url='', $rel = false, $size='medium', $alt = '') {
 
-    $html = get_image_tag($id, $alt, $title, $align, $size);
+    $html = get_image_tag($id, $alt, '', $align, $size);
 
     $rel = $rel ? ' rel="attachment wp-att-' . esc_attr($id).'"' : '';

trunk/wp-includes/media.php

@@ -226 +226 @@
     $hwstring = image_hwstring($width, $height);
 
+    $title = $title ? 'title="' . esc_attr( $title ) . '" ' : '';
+
     $class = 'align' . esc_attr($align) .' size-' . esc_attr($size) . ' wp-image-' . $id;
     $class = apply_filters('get_image_tag_class', $class, $id, $align, $size);
 
-    $html = '<img src="' . esc_attr($img_src) . '" alt="' . esc_attr($alt) . '" '.$hwstring.'class="'.$class.'" />';
+    $html = '<img src="' . esc_attr($img_src) . '" alt="' . esc_attr($alt) . '" ' . $title . $hwstring . 'class="' . $class . '" />';
 
     $html = apply_filters( 'get_image_tag', $html, $id, $alt, $title, $align, $size );