tags is cutting a lot of them out, making it seem to the server like there is no target link in the source URI, and thus returning a pingback fault 17 unnecessarily. And this means a large percentage of genuine pingbacks are failing without the user even knowing about it!
I suspect the function is having trouble with plugins that insert javascript near the header of the page, though it could be otherwise, as I have done a test to see what is left after this line is run, it returns some garbled javascript, no links at all from the post content (where the source links actually were), and then the menu links.
I have included a workaround in my new plugin:
http://wordpress.org/extend/plugins/pingchecker/
Basically it does a regex match for links in your content, then echoes them in a hidden div in the footer, making it much easier for the strip_tags function to actually find them. It works pretty well so I'm not fussed myself, but I thought it worth writing about..
This line really needs to be replaced with the regex match in the actual server code for future WordPress users too. I don't know regex myself, but I used sample code I found here (http://regexadvice.com/forums/thread/48395.aspx) for this regex expression, which seems to work really well.
In any case, strip_tags is not doing a reliable job at this and needs replacing. Hopefully this finds its way to the right person able to fix this. Thanks!" majick777
Needs Milestone 17326 Allow new user registrations to be moderated Users 3.1 normal normal Awaiting Review enhancement new 2011-05-05T04:29:10Z 2011-05-05T16:02:57Z "'''Summary'''
When registration is open, have the option to require manual approval of user accounts before they are granted default role status.
'''Details / Suggested Implementation'''
Create a new user role (""Moderated""?) which for all intents and purposes is the same as ""Subscriber"" (`read` capabilities).
If opted into, user moderation would assign new users this new role. Administrators would be able to see these users listed under the Users list and click an approve link which would change their role to the default user role (as per the General Settings).
This would also make it easier for plugins to implement private blogs while having open user registration.
See also: #12030" Viper007Bond
Needs Milestone 17337 wp_old_slug_redirect() fails with multiple post_type query Canonical 3.1 normal normal Awaiting Review defect (bug) new 2011-05-06T10:36:19Z 2011-05-06T10:36:19Z "If I have a query something like this:
{{{
[query_vars] => Array
(
[name] => panasonic-tv-review
[post_type] => Array
(
[0] => review
[1] => small_review
)
)
}}}
The new post slug is ""panasonic-250-tv-review"", and there is a `_wp_old_slug` meta key with the old slug. One would expect `wp_old_slug_redirect()` to kick in and do the redirect. However, `wp_old_slug_redirect()` will fail with a query with multiple post types, (looking at http://core.trac.wordpress.org/browser/trunk/wp-includes/query.php#L3494). This will knock the `$wpdb->prepare()` ass `$post_type` is now an array.
I can write a patch for this if I can get the go ahead." joehoyle
Needs Milestone 17340 Mark up script-loader.php versions for programmatic updating General normal normal Awaiting Review enhancement new 2011-05-06T18:51:56Z 2011-05-08T14:51:36Z "Whenever we update one of our dev CSS or JS files, we have to use YUI to re-minify them, and bump their version number in script-loader.php. The YUI part can be done programmatically, but it's not quite possible to bump the script-loader.php version numbers without manual intervention. If the number strings (yyyymmdd{optional-abcd suffix}) were marked up with PHP comments in a standardized way, we could automate that step as well.
Since any script would have the file name in hand, I propose the following:
{{{/*#wp-admin/css/wp-admin.dev.css#wp-includes/css/fake.dev.css*/'20110203b'}}}
That is, a PHP comment block that immediately starts with a hash (#) and is followed by one or more dev URLs that the version number applies to (multiple ones separated by another hash), and immediately followed by a version string enclosed in single quotes, in the format:
{{{/'([0-9]{4})([0-9]{2})([0-9]{2})([a-z]?)'/}}}" markjaquith
Needs Milestone 17365 get_terms doesn't return terms with no posts if you specify a parent Taxonomy 3.1.2 normal normal Awaiting Review defect (bug) new 2011-05-10T11:52:19Z 2011-05-10T11:52:19Z "get_terms doesn't return terms with no posts if you specify a parent (see also #15626 for a related bug). Let's imagine the following term structure:
{{{
---parent_term (0 count)
|---child_term (10 count)
}}}
Calling `get_terms('category', array('parent' => 0))` should return both terms according to the documentation, but it doesn't. The documentation says that `hierarchical` defaults to true, which should '''""include terms that have non-empty descendants""'''. It's broken because the following code runs if a parent argument is present (lines 1139-3 of taxonomies.php).
{{{
if ( !$single_taxonomy || !is_taxonomy_hierarchical($taxonomies[0]) ||
'' !== $args['parent'] ) {
$args['child_of'] = 0;
$args['hierarchical'] = false;
$args['pad_counts'] = false;
}}}
But nothing in the parent section of the documentation suggests that adding a parent will change the other defaults. The consequence of the above code comes in lines 1266-7:
{{{
if ( $hide_empty && !$hierarchical )
$where .= ' AND tt.count > 0';
}}}
which means the parent_term is not being returned because it has a count of zero, and I can't walk down the tree to get the other terms.
At the very least, set this paramenter as default in $defaults, before `$args = wp_parse_args( $args, $defaults )` (rather than in `$args` afterwards) which would at least allow us to override this behaviour through explicit `$atts`. But it would be more logical simply to remove the test for `'' !== args['parent']` altogther, inline with the existing documentation." mark8barnes
Needs Milestone 17374 get_pages() with child_of forgets sort General 3.1.2 normal normal Awaiting Review defect (bug) new 2011-05-11T10:06:17Z 2011-05-11T10:06:17Z "If you call {{{get_pages()}}} with both the {{{child_of}}} and {{{sort_column}}}, the sorting is not applied.
{{{child_of}}} makes it select all pages (sorted) and later applies a subselect via {{{get_page_children()}}}. This subselect can mess up the sort order.
An example was reported on http://wordpress.stackexchange.com/questions/16921/get-pages-not-ordering-as-it-should
Related: #12821" janfabry
Needs Milestone 16504 Faster maybe_unserialize General 3.1 normal normal Awaiting Review enhancement new has-patch 2011-02-09T11:11:52Z 2011-05-11T11:46:49Z "In #14429 many have taken care to optimize the is_serialized speed.
The function is of good general value and most often used to ""maybe"" unserialize.
It was [http://core.trac.wordpress.org/ticket/14429#comment:3 originally smabauers] who reminded that it's only about to check what it's about to check.
''Option values'', if serialized are only serialized Array, Objects or Strings. No exceptions. And they are ''always trimmed'' strings.
As is_serialized() is of general use and might be used by plugin authors, maybe_unserialize can get a new playmate." hakre
Needs Milestone 17381 display_name is not updated if javascript is disabled Users 3.2 normal normal Awaiting Review defect (bug) new 2011-05-11T19:29:37Z 2011-05-11T19:29:37Z "If one has javascript disabled the display name is not updated if the users changes his name. Also plugins that provide user credentials and update the users entry in the database can not determine the users display_name setting.
The display_name field should only hold a reference to the style how the name is displayed. That way no javascript would be needed to set the display_name and also plugins can change the users credentials without producing inconsistency or forcing a style for the display name." elmll
Needs Milestone 17387 Issue with wp_theme_update_row() setting $details_url Upgrade/Install 3.1.2 normal normal Awaiting Review defect (bug) new 2011-05-12T09:15:44Z 2011-05-12T09:15:44Z "I'm building my own theme auto update script and everything was working perfectly, until I ran into a weird bug.
When you're running WordPress in Multisite the $details_url for themes with an update available is set differently than when running WordPress in single site mode.
In single site mode the details url is set inside the theme_update_available() function found in this file /wp-admin/includes/theme.php. It uses the returned 'url' like so.
{{{
$details_url = add_query_arg(array('TB_iframe' => 'true', 'width' => 1024, 'height' => 800), $update['url']);
}}}
However, in Multisite the url is built completely different. It uses the wp_theme_update_row() function in the /wp-admin/includes/update.php file like so.
{{{
$details_url = self_admin_url(""theme-install.php?tab=theme-information&theme=$theme_key&TB_iframe=true&width=600&height=400"");
}}}
I'm not exactly sure what the best approach would be to fixing this. I know there is a reason why the url is set like that but without a way to change it for my personal themes (i.e. filter or something) I'm stuck with a broken details screen in Multisite.
I did just add a filter to test it and was successful in fixing the issue, but not sure how to proceed from here.
{{{
$details_url = apply_filters( 'network_details_url', self_admin_url(""theme-install.php?tab=theme-information&theme=$theme_key&TB_iframe=true&width=600&height=400""), $theme_key, $theme );
}}}
Thanks for any help you can give me.
Cheers!
Derek Herman" valendesigns
Needs Milestone 17388 Distraction free writing mode submit button text Editor 3.2 normal normal Awaiting Review enhancement new 2011-05-12T12:11:09Z 2011-05-12T12:11:09Z "The text on the submit button in distraction free writing mode should match that of the submit button on the main editing screen. Currently it always says ""Update"" for published posts, and ""Save"" for other statuses. It should say ""Save Draft"", ""Save as Pending"" etc when relevant (and change when you change the post status dropdown too)." johnbillion
Needs Milestone 17409 Entity & in menu title breaks XHTML 1.0 Strict validation Florian Menus 3.1.2 normal normal Awaiting Review defect (bug) new 2011-05-13T05:44:03Z 2011-05-13T05:44:03Z "If i use & in the menu title and use $my_menu = wp_get_nav_menu_items(""my_menu"") and loop with foreach($my_menu as $menu_item) and connect for building the Menu on $menu_item->title, then an & in the page title or on the menu navigation label is convertet to a simple &, witch returns the validation error ""xmlParseEntityRef: no name""." Florat
Needs Milestone 17442 CSS selector #wpadminbar * overwrites accessibility generic selectors like screen-reader-text General 3.2 normal normal Awaiting Review defect (bug) new 2011-05-15T10:42:59Z 2011-05-15T12:52:23Z "I just was looking to update one of my plugins for 3.1/3.2 making use of the new admin bar.
My plugin makes use of the `.screen-reader-text` CSS class but it is overwritten in the admin-bar by `#wpadminbar *`" hakre
Needs Milestone 17439 Wordpress Database Update reports errors but says it's successfull Upgrade/Install 3.2 normal normal Awaiting Review defect (bug) new 2011-05-15T09:23:30Z 2011-05-15T14:36:43Z "I just updated my database on current HEAD of trunk by pressing the button while WP told be to do so. I got an error reported:
----
'''WordPress database error:''' [Out of range value adjusted for column 'post_parent' at row 4]
`ALTER TABLE wp_posts CHANGE COLUMN post_parent post_parent bigint(20) unsigned NOT NULL default '0'`
----
However right beneath of it, I was greeted with:
----
'''Update Complete'''
Your WordPress database has been successfully updated!
----
First of all I ask myself if I can trust that message as an error has been reported.
Then this looks like that the update is not compatbile with my MySQL server which is 5.0.19 and matching the [wordpress system requirements on the webpage](http://wordpress.org/about/requirements/) (which seems to be out of date for trunk, but, well 5.0 is required according to version.php).
Related: #3112
" hakre
Needs Milestone 17445 Give a speed kick to combined is_serialized() + is_serialized_string() + maybe_unserialize() usage General 3.2 normal normal Awaiting Review defect (bug) new 2011-05-15T14:13:18Z 2011-05-15T21:14:14Z "In #17129 is_serialized_string() has been speed up by 23%. That was for the function itself.
However, that function is used in contexts that make the call to is_serialized() directly or indirectly via maybe_unserialize().
Most often these calls are redundant and must not be done at all.
If preconditions are already met, is_serialized_string() can be replaced with a simple check for the 's' or 'S' format and maybe_unserialize() can be replaced with @unserialize($data) as that's the code executed in maybe_unserialize() when is_serialze() had returned true on $data;" hakre
Needs Milestone 17455 Add $post_type argument to get_lastpostdate/get_lastpostmodified/_get_last_post_time General normal normal Awaiting Review enhancement new has-patch 2011-05-16T15:05:59Z 2011-05-16T16:00:05Z As title says. You can currently use these functions to only get the latest [modification] date of all publicly queryable content types. duck_
Needs Milestone 17460 WP Updates througth SSH Script bugdev Administration 3.2 normal normal Awaiting Review feature request new dev-feedback 2011-05-16T19:57:14Z 2011-05-16T20:45:56Z "The current WP Update engine is very unsecure, because if there is a webserver issue or a connection timeout, memory overflow, connection issue than the wordpress update is corruptes.
More secure the update will be if we can do/execute a php script or ssh script througth the terminal, what also gives advanced informations about update errors ect." bugdev
Needs Milestone 17482 "Formalize a list of ""Object Types""" General normal normal Awaiting Review enhancement new dev-feedback 2011-05-17T23:19:14Z 2011-05-18T00:00:17Z "I'm finding a need to use a defined list of object types for numerous things including for [http://core.trac.wordpress.org/ticket/14513#comment:77 object relationships], term relationships that relate taxonomy terms to something other than a post, data entry forms, and I am sure there are more than just these requirements ''(An ""object"" is anything in WordPress for which we can identify a name and a unique ID form the database, i.e. `$post->ID`, `$user->ID`, `$term->term_id` and so on.)''
While thinking about it this seems to be something that would be valuable to include core so I am proposing and submitting a patch for their potential inclusion. If this is ''not'' something that the team would want to include then I'll simply incorporate them into my own code but I wanted to make sure that the team wouldn't want to include them into WordPress core instead." mikeschinkel
Needs Milestone 17525 There should be a datetime_format option to specify whether the date or the time comes first General normal normal Awaiting Review feature request new 2011-05-20T20:09:11Z 2011-05-20T20:09:11Z "As a theme author it would be very useful to have a global option for formatting a full datetime (and a the_datetime() function too).
Sometimes datetimes are formatted ""$date $time"", sometimes it's ""$time $date"", sometimes it's even ""$date at $time"".
I think there should be an option for this in the general settings alongside the date and time format options." holizz
Needs Milestone 17517 wpLink should show tags and categories as results too Administration 3.2 normal normal Awaiting Review enhancement new 2011-05-19T19:38:36Z 2011-05-21T12:06:36Z "sometimes you make a series of blogpostings about a topic with one unique tag.
wpLink (the link assistant in wp 3.1) is very useful for finding ""old"" content, but when you want to link a tag or category you have to type in the url yourself or paste it
Possible solution:
Tabbed interface:
Tab 1 for Posts/pages
Tab 2 Tags/categories" hebbet
Needs Milestone 17328 In User Profile, Undefined property: WP_User::$rich_editing line 189 user-edit Warnings/Notices 3.2 normal normal Awaiting Review defect (bug) reopened has-patch 2011-05-05T05:00:24Z 2011-05-23T08:29:51Z "Notice: Undefined property: WP_User::$rich_editing in C:\web\wpbeta\wp\wp-admin\user-edit.php on line 189
/>" anmari
Needs Milestone 17542 Remove upload file after deleting custom background Administration normal normal Awaiting Review enhancement new has-patch 2011-05-23T08:49:25Z 2011-05-23T14:40:13Z "I came across a comment on custom-background.php that says
//@todo: uploaded files are not removed here.
So, I thought I will come up with this codes for the upload file deletion if user remove background.
Attached custom-background.diff
I had tested on my localhost.
Hope this contribution is useful.
Thanks." denzel_chia
Needs Milestone 17551 Need a post_id query that works regardless of post_type. Query 3.2 normal normal Awaiting Review enhancement new 2011-05-24T20:25:46Z 2011-05-25T13:27:37Z "The query parameter `p` works for posts and pages but not attachments. When the ID in question refers to an attachment, the result is a 404. Why?
When generating a stats report for a remote blog, the WordPress.com Stats/Jetpack system at first only knows the post_id of a new post. Eventually it learns the correct permalink by querying the blog, but until then its best guess at a working link is `?p=$post_id`.
This problem (and possibly others) would be most easily solved by a core query parameter that can find any post_type by its ID alone. Unless there is a reason to limit `p`, I propose we make `p` work for all post_types. If there is a reason, how about a new public query parameter `post_id`?" andy
Needs Milestone 17635 Themes page should have search subtitle Administration 3.2 normal normal Awaiting Review defect (bug) new 2011-06-01T12:15:05Z 2011-06-01T14:26:16Z "Most admin pages display the term that the user has searched for when displaying search results, but the Themes page (under site admin) doesn't.
[16525] seems to have excluded it in the AJAXified list tables, but gives no reasoning." kawauso
Needs Milestone 17642 hook for category edit needed cardy_web Administration 3.1.2 normal normal Awaiting Review enhancement new dev-feedback 2011-06-01T16:44:50Z 2011-06-01T16:44:50Z "I think is needed an hook inside admin-ajax.php (line 1226) case 'inline-save-tax'
When you use ""quick edit mode"" to edit category no hooks get involved so function hooked into {action}_category are never called.
Instead everything work well using classic edit mode" cardy_web
Needs Milestone 17675 Masked Domain Issue Introduced with New Update Administration 3.1.3 normal normal Awaiting Review defect (bug) new reporter-feedback 2011-06-03T18:09:03Z 2011-06-03T19:59:41Z "Hi,
I'm experiencing an issue accessing my wp-admin login page, only when using a masked domain.
My root setup is configured as so:
http://rootdomain.com/othersite/wordpress/
The domain I'm using to access it is located here:
http://redirect.com
When I use the root domain to access the login page directly, there's no problem. But, when I go to http://redirect.com/wp-admin, or click on any login links while at the redirect.com site, the page doesn't load. The title bar will load, but nothing else.
This is a new issue introduced with the 3.1.3 update. The masked domain was working prior to 3.1.3.
I've tried this both on Safari & Firefox (latest versions), using Mac OS X." ital_dj
Needs Milestone 17714 Comment/pingback handlers don't check whether the post type supports comments Comments 3.1 normal normal Awaiting Review defect (bug) new dev-feedback 2011-06-07T06:09:02Z 2011-06-07T06:17:45Z "wp-comments-post and XML-RPC don't check post type support for comments before accepting them - I think they should. We can't rely solely on `$post->comment_status` because that may not always be set to ""closed"" even if the post type doesn't support comments (see also #13473)
Maybe we could add a check to `comments_open()`?" solarissmoke
Needs Milestone 17723 WP Signon from external resource/php code Users 3.1.3 normal normal Awaiting Review defect (bug) new 2011-06-07T23:30:50Z 2011-06-07T23:30:50Z "Wordpress has a lot of different functions available in the codec, such as the wp_signon.
The code to login a user from within the wordpress folder looks like:
{{{
$creds = array();
$creds['user_login'] = $username;
$creds['user_password'] = $password;
$creds['remember'] = true;
$user = wp_signon( $creds, false );
wp_set_current_user($user->ID);
}}}
If this is done outside of the wordpress user folder, by including the wp-config.php file
{{{
including the wp-config, like the following:
global $wpdb;
define('WP_USE_THEMES', false);
require_once '/path/to/www/blog/wp-config.php';
wp();
}}}
then the cookies aren't created successfully and you can't properly login/logout a user.
There are a log of constants that set this up, yet the cookies aren't set properly, you are missing the wordpress_logged_in_COOKIEHASH essential cookie.
Such flexible function should work properly " TeckniX
Needs Milestone 16944 Add new 'bynetworkuser' CSS class to output from comment-template.php Comments normal normal Awaiting Review enhancement new has-patch 2011-03-23T06:28:46Z 2011-06-08T05:23:43Z "Currently, the comment-template.php file checks to see whether a comment author is in the wp_user table.
If they are, then WordPress will emit a 'byuser' class as part of the comment div markup.
However, this behaviour is not ideal from multisite installations. 'byuser' should be restricted on a per-blog basis.
I propose that the current behaviour be assigned to a new CSS class, 'bynetworkuser'." jacques_chester
Needs Milestone 16805 default 'from' hostname Mail 3.1 normal normal Awaiting Review defect (bug) new close 2011-03-09T15:11:39Z 2011-06-08T15:27:33Z "The logic used to create the hostname portion of default e-mail address when calling wp_mail doesn't make sense.
Lines 384-392 of wp-includes/pluggable.php read:
{{{
if ( !isset( $from_email ) ) {
// Get the site domain and get rid of www.
$sitename = strtolower( $_SERVER['SERVER_NAME'] );
if ( substr( $sitename, 0, 4 ) == 'www.' ) {
$sitename = substr( $sitename, 4 );
}
$from_email = 'wordpress@' . $sitename;
}
}}}
We assume that if www. is in the sitename that it is not part of the e-mail address. I reviewed a few RFCs and have not found where 'www.' is prohibited from the hostname portion of an e-mail address. I concede that john.smith@ www.sitename.com is now common, but it is still a legal name.
Additionally, if the $_SERVER[ 'SERVER_NAME' ] is a sub-domain such as blogs.sitename.com the e-mail is going to send from john.smith@ blogs.sitename.com.
For consistency I suggest we either remove all nth level domain names above the first or remove none. This way it will be more obvious when people need to use the wp_mail_from filter and not just appear to be random." lonnylot
Needs Milestone 16396 Add a hook to the theme editor page when the write is successful Themes 3.1.3 normal normal Awaiting Review enhancement new has-patch 2011-01-28T17:29:35Z 2011-06-20T18:39:59Z Add a filter to the end of theme-editor.php's processing when the write is successful. scottconnerly
Needs Milestone 17857 WP_Embed - Split shortcode() function into two for increased flexibility Media 2.9 normal normal Awaiting Review enhancement new has-patch 2011-06-21T01:52:41Z 2011-06-21T03:33:55Z "Currently, the WP_Embed class is restricted to posts; it takes a post ID as a parameter and checks the post meta table.
What I'd like to propose is to apply a filter to the post ID and split WP_Embed::shortcode() into two functions (at http://core.trac.wordpress.org/browser/trunk/wp-includes/media.php#L1177).
In a nutshell, let the link parsing be one function and if the link is oEmbed-worthy send it to the second function for parsing. The second function could then be easily extended for usage in 3rd-party plugins not using WP posts (like BuddyPress).
Also, the patch checks the URL against each registered WP oEmbed provider's URL scheme if oEmbed discovery is false. This is designed to prevent unnecessary external pinging of an oEmbed provider and avertible meta caching for failed attempts. Andy Peatling primarily wrote this part of the code, which he sent to me awhile ago.
Attached patch is against r18324." r-a-y
Needs Milestone 17725 wp_convert_hr_to_bytes() fails on large numeric values General 2.3 normal normal Awaiting Review defect (bug) new has-patch 2011-06-08T12:24:41Z 2011-06-22T17:17:36Z "The {{{wp_convert_hr_to_bytes()}}} function exists to convert values in form of a memory setting into it's value in bytes.
By doing so, the function modifies the input value in every case. This modification has an issue with integer limits.
Whenever a value of $size is passed to the function that is in it's numerical part larger than [http://php.net/manual/en/reserved.constants.php PHP_INT_MAX], the input value will be capped to {{{PHP_INT_MAX}}}.
This is an integer overflow.
This applies as well when size has a shorthand ending specifier and it's numerical part is greater than PHP_INT_MAX.
To illustrate the problem on a 32 bit system:
{{{
$setting = '2147483648';
echo ""'$setting' are "", wp_convert_hr_to_bytes($setting), "" bytes.\n"";
// '2147483648' are 2147483647 bytes.
}}}
It shows that the last byte is missing. Every other byte on top will be capped as well. The number of bytes given are a value equally to '2G'.
Solution: Input values should not be capped to int but to float which has allows higher values." hakre
Needs Milestone 17890 """Add New Site"" screen reports invalid email addresses as missing" Network Admin 3.1.3 normal normal Awaiting Review defect (bug) new has-patch 2011-06-25T11:32:41Z 2011-06-25T11:40:07Z "The new site user's email is passed through `sanitize_email()` and the screen dies with 'Missing email address.' if it's `empty()`.
`sanitize_email()` returns an empty string (subject to filtering) on invalid email addresses however, so the following `is_email()` check for invalid email addresses is never even reached.
'''Steps to reproduce:'''
1. Add a new site with an email address such as foo@bar" kawauso
Needs Milestone 16934 Commented code in /wp-includes/canonical.php General 3.1 normal normal Awaiting Review defect (bug) new dev-feedback 2011-03-22T14:00:26Z 2011-06-25T18:57:57Z "Timestamp: 10/16/08 19:17:04 (2 years) - Safe to remove this by now?
[9203]" hakre
Needs Milestone 17859 Can't attach media to private posts Media 3.1 normal normal Awaiting Review defect (bug) new has-patch 2011-06-21T11:54:43Z 2011-06-27T14:58:10Z "In the Media -page on the WordPress admin, one can attach unattached media to posts and pages.
However, the search does not show private posts, even with the master account.
Reproduce:
1. Upload media
2. Try to attach to a private post or page" knome
Needs Milestone 17201 dynamic_sidebar performance Widgets 3.1 normal normal Awaiting Review enhancement new dev-feedback 2011-04-21T07:48:22Z 2011-06-29T12:04:49Z "I've got a few dynamic sidebars (say 6 or 7) and the dynamic_sidebar function spends 1/4 of a second only calling sanitize_title.
See the piece of code on wp-includes/widgets.php:
{{{
if ( is_int($index) ) {
$index = ""sidebar-$index"";
} else {
$index = sanitize_title($index);
foreach ( (array) $wp_registered_sidebars as $key => $value ) {
if ( sanitize_title($value['name']) == $index ) {
$index = $key;
break;
}
}
}
}}}
That's occurs evenf if you provide an id, and not the sidebar name.
We could avoid that by checking before trying to use the sidebar name if a sidebar exists with that id.
Like so...
{{{
if ( is_int($index) ) {
$index = ""sidebar-$index"";
} elseif ( empty($wp_registered_sidebars[$index]) || !array_key_exists($index, $sidebars_widgets) || !is_array($sidebars_widgets[$index]) || empty($sidebars_widgets[$index]) ) {
$index = sanitize_title($index);
foreach ( (array) $wp_registered_sidebars as $key => $value ) {
if ( sanitize_title($value['name']) == $index ) {
$index = $key;
break;
}
}
}
}}}" mrubiolvn
Needs Milestone 17296 Link Descriptions Are Truncated Without Notification General 3.1 normal normal Awaiting Review defect (bug) new dev-feedback 2011-05-01T03:04:09Z 2011-07-03T07:48:46Z "When creating new links, or editing existing links, using the WordPress admin interface, link descriptions are truncated to 255 characters. This is because there is a 255 character limit defined in the link_description column in the wp_links database table.
Steps to reproduce:
1) Go to WP dashboard
2) Select Links > Add New from the menu.
3) Create a link with a description longer than 255 characters.
4) Go back to the link in the links interface; the description has been truncated.
Expected behavior:
1) The field should have a larger limit (perhaps 1024 characters?).
2) Even if we keep the limit at 255, the UI should prevent users from entering more than the limit, or notify them that the description they have entered will be truncated to the limit.
Thanks for your time!" achmafooma
Needs Milestone 17778 get_comment_pages_count() returns > 1 when pagination is disabled Comments 3.2 normal normal Awaiting Review defect (bug) new has-patch 2011-06-13T05:01:58Z 2011-07-09T11:10:47Z "If pagination is disabled, get_comment_pages_count() will still return the number of pages possible if pagination was enabled.
As a workaround, themes & TwentyEleven are having to get to see if pagination is enabled first:
{{{
1 && get_option( 'page_comments' ) ) : // are there comments to navigate through ?>
}}}
I'd suggest that if comment pagination is not enabled, this function should return 0 or 1 (0 = no comments, 1 = 1 page).
The addition of an extra block after the [http://core.trac.wordpress.org/browser/trunk/wp-includes/comment.php#L740 empty comments check] would be:
{{{
if ( ! get_option('page_comments') )
return 1;
}}}" dd32
Needs Milestone 17636 Search subtitles are handled inconsistently across admin Administration 3.2 normal normal Awaiting Review defect (bug) new has-patch 2011-06-01T12:15:48Z 2011-07-09T11:44:29Z "Try the following strings in the Comments admin screen and any other:
`\'""\fs""\\\""`
`imareallylongstringlookatmegoandgoandgoandgoandgoandgoandgoandgoandgoandgoandgoandgoandgoandgo`
The Comments screen uses `strip_slashes()` and `wp_html_excerpt()` to limit search strings to 50 characters, while other screens do not." kawauso
Needs Milestone 17235 meta_query fails if you don't pass in an array of arrays Query 3.1 normal normal Awaiting Review defect (bug) new dev-feedback 2011-04-25T20:20:39Z 2011-07-10T20:44:55Z "This tripped me up the first time I used meta_query (see #16563) and I've seen others fall into the same trap. If you don't pass in an array of arrays into meta_query, it generates some funky (but valid) SQL and fails to return anything.
The main instance where people will fall into this is if they only have a single key/value pair to look for. In this case, passing in an array of arrays does not seem intuitive, and meta_query should be smart enough to work with either. Examples below.
This doesn't work:
{{{
$my_query = WP_Query( array
array (
'post_type' => 'post',
'meta_query' => array (
'key' => 'my_key',
'value' => 'my_value',
),
),
);
}}}
But this does:
{{{
$my_query = WP_Query( array
array (
'post_type' => 'post',
'meta_query' => array (
array(
'key' => 'my_key',
'value' => 'my_value',
}
),
),
);
}}}" batmoo
Needs Milestone 18075 """Scan for lost attachments"" should look for orphaned files in the /uploads/ folder" Media 3.2 normal normal Awaiting Review enhancement new 2011-07-11T23:19:25Z 2011-07-11T23:40:52Z "I recently moved my blog over to another host, and just copy and pasted my /wp-content/uploads/ folder into the new destination. I've now got four years worth of media, but none of it is in the media library.
I assumed the button on the Media Library (under Unattached) would add these files to the database, but it didn't.
Extending this use case, this feature could also be used as a bulk ""these files are already on the server, I don't want to upload them"" (which is the only way to add files to the media library, no?) action." shamess
Needs Milestone 16448 Smilies should not be placed inside of pre or code tags Formatting 3.1 normal normal Awaiting Review enhancement new has-patch 2011-02-03T04:00:52Z 2011-07-13T09:46:36Z Smilies should ignore content inside of `` and `` tags. The author likely is posting code and doesn't need smilies messing it up. Viper007Bond
Needs Milestone 18102 IE8 and wp_tiny_mce has broken Link button General 3.2 normal normal Awaiting Review defect (bug) new 2011-07-13T14:07:43Z 2011-07-13T17:57:57Z "With IE8 and custom-generated WYSIWYG editors created with wp_tiny_mce, the link button doesn't work correctly. What happens is quite interesting:
On the first click, the Add/Edit dialog link box appears full sized, but empty.
Dismissing the box and clicking the link button again will give you just the Add/Edit link dialog box's title, but not even a box.
Dismissing that box and clicking on it a third time will finally generate an Add/Edit link form in the dialog box, but it won't be functional.
As far as I can tell, there are no JavaScript errors displayed.
This works correctly in Chrome, FireFox, and IE9. The problem only exists in IE8 as far as I can tell. I tested on 3.2 and 3.2.1
The issue occurs with a default theme, but not with all plugins disabled (because plugins are required to create such a WYSIWYG box). The issue does NOT exist on the default post/page add/edit screens. Examples of plugins affected are WYSIWYG Widgets (http://wordpress.org/extend/plugins/wysiwyg-widgets/) and Rich Text Tags (http://wordpress.org/extend/plugins/rich-text-tags/), although I discovered the issue while developing my own plugin.
I also put together a bare-bones plugin to help verify the issue in case that helps (see the new menu item in Settings):
http://dl.dropbox.com/u/5148765/lems_wysiwyg_test.php (requires WP 3.2+)
While it's possible that the real problem is how we're calling wp_tiny_mce (and I certainly apologize if that's the case), all 3 of us developers have run into this issue independently.
Let me know if you need any more info!" MadtownLems
Needs Milestone 18101 Last theme reported in Feature Search is Duplicated as first theme in page 2 Administration 3.2.1 normal normal Awaiting Review defect (bug) new 2011-07-13T13:59:36Z 2011-07-14T11:53:46Z Search for themes using the features filtering mode. The last theme theme of the first page (if you search for custom background feature the theme is Nona) will be duplicated as the first theme in page 2. Page count in the navigation is correct, and you will get one more theme in the end (e.g. with 121 themes, last page will have two themes instead of just one). lorthirk
Needs Milestone 16866 Multisite registration uses extra redirect spathon General 3.1 normal normal Awaiting Review enhancement reviewing 2011-03-16T15:08:34Z 2011-07-16T22:05:43Z "When you are on a sub-blogg and choose register you are sent to wp-login.php?action=register and because it is a multisite it redirects to wp-signup.php. wp-signup.php then redirects to wp-signup.php on the main site.
if
{{{
wp_redirect( apply_filters( 'wp_signup_location', site_url('wp-signup.php') ) ); // row 488 in wp-login.php
}}}
were set to network_home_url instead of site_url there would be one less redirects and risk for plugins to cause problems.
" spathon
Needs Milestone 16283 post_exists() enhancement - don't include revisions Administration 3.1 normal normal Awaiting Review enhancement new dev-feedback 2011-01-18T13:33:51Z 2011-07-17T02:04:03Z "The current post_exists() function to me has a major downside. By default all it does it search for title, content and/or date in the wp_posts table.
The problem with this is that it includes revisions. So for example if you have a post with title ""ABC"" but then later change it to ""DEF"", post_exists(""ABC"") will still return true with the post ID of the revision.
I would suggest either:
a) Adding post_status not equal ""inherit"" as a default to the function.
b) Adding a 4th parameter which allows you to pass the post_status value in.
I would be happy to code this if anyone has any feedback on what would be the best approach." durin
Needs Milestone 16492 Improvements to the Wordpress Update Process Upgrade/Install 3.0.5 normal normal Awaiting Review enhancement new 2011-02-08T16:45:48Z 2011-07-17T21:54:10Z "I've some suggestions on how to improve the update process (usability). I guess its not enough for separate tickets so I'm filing them together.
* When updating Wordpress, a plugin or a theme, I'm being asked for the password to the FTP server. You should add a note there that the password won't be stored in the database. I guess many/some users are uncomfortable with storing their FTP password in the database and won't use the ""update tool"" for this reason.
* Rename the button ""Update Automatically"" to ""Update Wordpress"". ""Update Automatically"" sound like ""Update now and update automatically in the future when a new Wordpress (and also plugin/theme?) version is available."" This should make the button's function a little bit clearer.
" manski
Needs Milestone 18130 Editing menu items - Cancel button does not work Menus 3.2.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2011-07-15T15:17:40Z 2011-07-20T21:46:21Z "When editing menu items, ""Cancel"" button at the bottom does not work. I can collapse menu item with top right arrow, but ""Cancel"" link worked also for collapsing menu items in the past. Now, after clicking on ""Cancel"" there is no response..." pavelevap
Needs Milestone 18209 Capabilities with misplaced dependencies in edit_theme_options Themes 3.2.1 normal normal Awaiting Review defect (bug) new 2011-07-22T06:33:07Z 2011-07-22T06:33:07Z "When setting capabilities for other groups, the user is unable to add to theme options with just '''edit_theme_options''' if they do not also have '''edit_posts''' capabilities. The user will be able to delete things like menu elements, but may not add them without this flag.
== How to reproduce; ==
Edit capabilities of group removing all '''POSTS''' to hide the Posts Dashboard pages (works by just removing '''edit_posts''' as well).
Give group '''edit_theme_options''' capabilities to edit their own menus.
Users may now access the Theme Options, and may delete objects.
User can add menu items to the preview, but once they Save these, the changes are not committed without the edit_posts permission." Clorith
Needs Milestone 18190 Don't redirect to 404 page on empty post archives General 3.2.1 normal normal Awaiting Review defect (bug) new 2011-07-21T09:05:41Z 2011-07-22T13:55:20Z """../archive/2010/09/29"" redirects to a 404 Error because there are no posts that day.
If there are no posts, it shouldn't redirect to a 404 page. It should let the user perform the loop and show a message like this:
""Sorry, there are no posts for that date""" gazpachu
Needs Milestone 17088 Edit image icon broken in Internet Explorer 9 for referenced images with captions Media 3.1 normal normal Awaiting Review defect (bug) new 2011-04-08T17:14:11Z 2011-07-22T20:12:16Z "The ""Edit Image"" icon fails in IE 9 when trying to edit an image that has been inserted from an external URL with a caption. Instead of bringing up the Edit Image screen nothing happens.
Removing the caption code for an externally referenced image allows it to then be edited normally.
To reproduce:
1. Create a new post in WP 3.1.1
2. Add an image from an external URL with a caption. You could use the following code:
{{{
[caption align=""alignnone"" width=""281"" caption=""Source: Wikipedia (by NASA)""]
}}}
This would allow plugin developers to add additional fields or settings for nav menus and save them on updating or saving the menu.
" linguasite
Needs Milestone 16922 "Add class to ""via"" paragraph in press-this.php" Press This 3.1 normal normal Awaiting Review enhancement new dev-feedback 2011-03-21T22:23:27Z 2011-07-27T20:19:52Z "When using ""Press This,"" a paragraph is added to the bottom of the post with a link to the source, and, if there is a selected block of text being quoted, the word ""via"" prepended.
It would be helpful for themes to be able to style this paragraph, so I suggest adding a class to it such as ""via"".
Also, oughtn't this be wrapped in a tag as well?" topdownjimmy
Needs Milestone 18272 Can not define media upload path/URL in multisite Multisite 3.2.1 normal normal Awaiting Review defect (bug) new 2011-07-27T22:56:44Z 2011-07-27T22:56:44Z "We have a multisite installation with five subdomains. We do not wish to use the default /files/yyyy/mm/filename.ext structure for uploaded media.
In Network Admin > Sites > Edit (under a subdomain) > Settings, you can set:
Upload Path (eg /var/www/pathonserver)
Upload Url Path (eg http://www.domain.com/pathonserver)
Fileupload Url (eg http://www.domain.com/pathonserver)
However WordPress does not recognise these settings and uses the default format.
If you comment out the last line on wp-includes/ms-settings.php (ie ms_upload_constants()), it does recognise the settings. " xtraxtra
Needs Milestone 18275 Can't get perfect thumbnail sizes with image editor Media 3.2.1 normal normal Awaiting Review defect (bug) new 2011-07-28T02:37:16Z 2011-07-29T05:05:07Z "In the media settings, I have the thumbnail set to a fixed size (218x145), and set to crop to these exact dimensions.
Sometimes the automatic thumbnail crops off people's heads, etc, so I use the Image Editor to manually adjust the thumbnail. I select a rectangle, set the aspect ratio to 218x145, click crop, apply to thumbnail only, and save.
However, sometimes that results in an image slightly off in dimensions - for example, 215x145.
I expect this is a rounding error. However, it happens even if I select an area much bigger than this when cropping in the Image Editor - eg 300x200. After I click crop and see the 300x200 image, I would expect the thumbnail to be automatically be created at 218x145 like it does normally based on this adjusted image - however, it appears the checkbox for using exact dimensions doesn't apply here. (In fact, if I select, say 300x300, it will make my thumbnail 145x145).
This feels like a bug to me, and makes it very hard to generate thumbnails at the size I want." smerriman
Needs Milestone 18315 Add an index to the GUID column in the posts table Database 3.2.1 normal normal Awaiting Review enhancement new has-patch 2011-08-02T04:31:01Z 2011-08-02T05:09:12Z "Running queries on the GUID column in the posts table is slow because the column is not indexed. The attached patch adds an index.
Note, this affects ticket #18286 - I will update that ticket with appropriate patches to reflect this request." alexkingorg
Needs Milestone 18324 "after adding new template file, ""Template"" drop-down disappears" Template 3.2.1 normal normal Awaiting Review defect (bug) new 2011-08-04T02:46:38Z 2011-08-04T02:46:38Z "After adding a new page template to my theme, the ""Template"" drop-down on the add/edit page screen disappeared. The ""Parent"" and ""Order"" form inputs still appeared, but there was no reference to the ""Template"" drop-down form element in the ""view source"" HTML of the page.
The new template file had been added to my theme directory via pull from a git repo that my collaborator had pushed the file to. The ""Template"" drop-down worked fine on his exact copy of the theme.
I changed the theme for my site to twentyeleven and then immediately back to my custom theme, and the ""Template"" drop-down began appearing again. I did this at the suggestion of these pages:
http://stackoverflow.com/questions/3987773/
http://wordpress.org/support/topic/template-file-drop-down-not-appearing
Evidently this intermittent bug has appeared since before Wordpress 3." sjscitp
Needs Milestone 17370 Screen options and meta box settings can lose per-blog meta box positions Users 3.1.2 normal normal Awaiting Review defect (bug) new 2011-05-10T21:13:37Z 2011-08-04T21:13:59Z "User preferences for admin interface appearance of the Dashboard and the Edit/Add New pages are stored in per-user options in wp_usermeta: closedpostboxes_$page, metaboxhidden_$page, meta-box-order_$page, and screen_layout_$page, where $page is one of 'post', 'page', or 'dashboard'. Users can customize the order of the Dashboard and editing meta boxes to better suit their workflow using the drag-and-drop AJAX interface to move the meta boxes into ordered columns and the Screen Options tab to show and hide the boxes. Many plugins add custom meta boxes to the Edit/Add New Post page.
In a multisite installation, with different plugins active on different blogs, users who rearrange an Add New Post page on a blog with a custom meta box and then rearrange it on a different blog without that meta box will lose the position of the custom meta box. Blogs can have different features and workflows implemented, and having per user options for the appearance instead of per user, per blog options limits the ability of a user to customize the interface.
The expected behavior for moving things around is that it changes on one blog, not on all blogs." jmdodd
Needs Milestone 17183 previous_comments_link and next_comments_link return wrong url with PATHINFO permalinks Permalinks 3.1.1 normal normal Awaiting Review defect (bug) new 2011-04-19T20:13:15Z 2011-08-04T21:26:32Z "When using PATHINFO permalinks, previous_comments_link() and next_comments_link() return a wrong link, which renders paged comments useless.
Steps to reproduce:
Set permalinks to: /index.php/%post_id%/%postname%/
The functions return URLs similar to: /comments-page-1/#comments
This URL results in a file not found (if no rewrite rules are available, which should not be necessary if the PATHINFO permalink structure is used).
Expected URL: /index.php/comments-page-1/#comments
Manual opening the URL results in the expected/correct paged comments page." FireMotion
Needs Milestone 18171 Media library - Sort on extensions Media 3.2.1 normal normal Awaiting Review feature request new 2011-07-19T11:19:48Z 2011-08-06T07:51:46Z Why is there only an option/function to view the images only? If you are looking for a word document it can be easy when you can see the documents only. This is also for PDF files and such. Maybe a function to sort on file types would be handy. JonezJeA
Needs Milestone 15674 Error when trying to logout General 3.0.2 normal normal Awaiting Review defect (bug) reopened reporter-feedback 2010-12-03T23:46:21Z 2011-08-07T20:51:51Z "I get this error when trying to logout of WordPress 3.0.1 & 3.0.2:
""This webpage is not available. The webpage at http://my.site.com/wp-login.php?action=logout&_wpnonce=12c23f0af8 might be temporarily down or it may have moved permanently to a new web address.""
and
""Error 101 (net::ERR_CONNECTION_RESET): Unknown error.""
in Google Chrome and
""The connection was reset""
in Firefox. Both browsers running on Windows XP SP3. I tested this on another computer running Windows XP SP3 (different ISP) and got the same error in Firefox.
Strangely, I do not get these errors at all on my Mac, in both Chrome and Firefox; they both logout correctly. It also works correctly on my iPhone.
I've tried cleaning cache and cookies in both browsers, reseting my sub-domain in my host's control panel, changing to the default theme; none of which worked at all. Must be some kind of bug, lots of reports about this in the forums.
See thread here: http://wordpress.org/support/topic/error-when-trying-to-logout?replies=9" interconnect
Needs Milestone 17219 Add Existing User - E-mail Notification ( /wp-admin/user-new.php ) Users normal normal Awaiting Review feature request new reporter-feedback 2011-04-22T21:10:17Z 2011-08-07T22:04:12Z "When adding an existing user to a site, we click ""Skip Confirmation Email Add the user without sending them a confirmation email"" to add the user immediately to the site. We've noticed that there is no notification that the user has been added to a new site. Could email notification upon adding existing user be considered? Thanks!" chaos1
Needs Milestone 17557 AtomPub service sends duplicate status headers, breaking FastCGI AtomPub 3.2 normal normal Awaiting Review defect (bug) new has-patch 2011-05-25T20:33:33Z 2011-08-08T01:00:38Z "The AtomPub service (wp-app.php) sends duplicate Status headers when authorization is not provided, which breaks on FastCGI setups. This is seen when you attempt to connect to the service using e.g. [https://github.com/calavera/Ape Ape], resulting in the following error message in the Apache logs:
{{{
[Wed May 25 16:09:21 2011] [error] [client 10.5.62.176] FastCGI: comm with server ""/tmp/webadmin_test"" aborted: error parsing headers: duplicate header 'Status'
}}}
This results in a 500 Internal Server Error from Apache:
{{{
HTTP/1.1 500 Internal Server Error
Date: Wed, 25 May 2011 20:09:21 GMT
Server: Apache
X-Powered-By: PHP/5.2.6RC4-pl0-gentoo
Expires: Wed, 11 Jan 1984 05:00:00 GMT
Last-Modified: Wed, 25 May 2011 20:09:21 GMT
Cache-Control: no-cache, must-revalidate, max-age=0
Pragma: no-cache
WWW-Authenticate: Basic realm=""WordPress Atom Protocol""
Content-Length: 735
Connection: close
Content-Type: text/html; charset=iso-8859-1
401 Credentials required.
Credentials required.
The server encountered an internal error or
misconfiguration and was unable to complete
your request.
Please contact the server administrator,
webmaster@ufl.edu and inform them of the time the error occurred,
and anything you might have done that may have
caused the error.
More information about this error may be available
in the server error log.
Additionally, a 500 Internal Server Error
error was encountered while trying to use an ErrorDocument to handle the request.
Apache Server at test.news.ufl.edu Port 80
}}}
Patch attached to refactor Status headers in wp-app.php to use the {{{status_header}}} function like most of the code uses. There's also a function that handles which I have refactored to use {{{wp_redirect}}}. Affects all versions back to 2.9.2, including trunk.
Examples of this issue (and corresponding fixes) include:
* #2628
* http://trac.symfony-project.org/ticket/3191" dwc
Needs Milestone 14531 Only show custom header preview when an image is set Themes 3.0.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2010-08-04T15:28:41Z 2011-08-11T22:24:22Z "If a custom header is removed the preview shows an empty box. We should remove the Preview section in this case. Could also display a message ""No header image set"" or similar." mtdewvirus
Needs Milestone 18356 get_bookmarks() indefinitely caches randomly ordered results General normal normal Awaiting Review defect (bug) new has-patch 2011-08-08T18:12:45Z 2011-08-12T01:11:20Z The get_bookmarks() function caches the results of all requests to the function in a single cache result so it can clear all the items when a new book mark is added. However, randomly ordered results shouldn't be cached indefinitely. This specifically affects the Links widget as it never refreshes when set to random order. prettyboymp
Needs Milestone 18385 "Canonical redirections not suited for Queries with multiple query vars and ""pretty permalinks"" in general" Canonical 3.2 normal normal Awaiting Review enhancement new dev-feedback 2011-08-12T09:05:03Z 2011-08-12T12:21:47Z "When the Canonical code was originally written, it served it's purpose quite well. However, over the years the number of Query vars which can be used to access content via has increased, and so have the number of archive views. This has lead to increased complexity in the Taxonomy canonical code which has needlessly caused bugs.
What I'm proposing, is that it might be time to lay to rest the current `if.. elseif.. elseif..` style checks, It's not possible for 1 if branch to handle every single access point without duplicating another branch.
As a result, I've put a half-finished together alternate version of Canonical, It's based on tallying up which query vars have been used/accounted for and removing any duplicates.. It's certainly not the best, but it's fairing better with the unit tests so far.
{{{
Unit Testing: http://unit-tests.trac.wordpress.org/browser/wp-testcase/test_includes_canonical.php
Before: FF.......FFFF..FFF.....F......FFFFFF.F....F.....FF....FF...
After: FF...........FFF..................FF..................F....
}}}
It's a work in progress, but it's worth considering IMO.
Attaching a diff, and the full file (since the diff is going to be rather unreadable in some sections)" dd32
Needs Milestone 18395 Non-URL GUIDs are stripped on post update Validation 3.2.1 normal normal Awaiting Review defect (bug) new 2011-08-13T18:31:48Z 2011-08-13T23:12:02Z "The post guid is run through several filters before the post is saved. the esc_url_raw() call will end up setting a GUID to an empty string if the GUID does not begin with a known/accepted protocol.
If a plugin/etc. wants to use the GUID column to store an external ID for an item brought in from another system (say a Flickr photo ID), then updating a post that has the Flickr ID as its GUID through the WP admin will end up setting the GUID for that post to ''.
This would need to be changed if the move was made to UUIDs for GUID values as well. Related: #6492.
A very basic patch for this specific issue is attached, but a larger discussion around how this should work is likely needed. Related: #18315" alexkingorg
Needs Milestone 14401 Unable to locate WordPress Content directory (wp-content). Upgrade/Install 3.0 normal normal Awaiting Review defect (bug) reopened reporter-feedback 2010-07-23T15:56:19Z 2011-08-14T01:58:27Z "Hi, I encounter this message on one server during plugin install: ""Unable to locate WordPress Content directory (wp-content).""
PHP Version 5.2.0-8+etch1
Another info from Core Control plugin:
Direct Not Available
SSH2 Not Available
PHP FTP Extension Available
PHP FTP Sockets Available
ABSPATH: /home/www/domain.eu/subdomains/www/
WP_CONTENT_DIR /home/www/domain.eu/subdomains/www/wp-content
WP_PLUGIN_DIR /home/www/domain.eu/subdomains/www/wp-content/plugins
DOCUMENT_ROOT (from phpinfo) /home/www/domain.eu/subdomains/www
I tried some hacks in wp-config.php, but I was not successfull.
When I tried ftpsockets, following error appears:
Warning: socket_last_error() expects parameter 1 to be resource, null given in /home/www/domain.eu/subdomains/www/wp-admin/includes/class-ftp-sockets.php on line 59
When I tried direct, following error appears:
Downloading install package from http://downloads.wordpress.org/plugin/wp-memory-usage.zip…
Unpacking the package
Could not create directory. /home/www/domain.eu/subdomains/www/wp-content/upgrade/wp-memory-usage.tmp" pavelevap
Needs Milestone 18413 "Ability to Add Custom ""Add User"" Link" Administration normal normal Awaiting Review enhancement new 2011-08-15T14:44:54Z 2011-08-15T14:44:54Z "For the ldap plugin i'd like to be able to utilize the current location of the ""Add New"" and ""Add Existing"" button to override it to show a button to link to the custom page for the ldap add user page.
Currently there are no hooks or filters that would allow me to add something in there - would it be possible to add in an action in there after the existing code to print out the add buttons?" axelseaa
Needs Milestone 18412 """%20"" in an uploaded image file name breaks thumbnails" Media 3.2.1 normal normal Awaiting Review defect (bug) new has-patch 2011-08-15T13:54:48Z 2011-08-17T00:49:37Z When uploading an image file where the name contains %20, it will not show thumbnails. It is still possible to edit the image in the image editor, however. ripperdoc
Needs Milestone 18446 Widget removes fields w/ default HTML on initial save in IE8 and 9 Widgets 3.2.1 normal normal Awaiting Review defect (bug) new dev-feedback 2011-08-16T15:51:02Z 2011-08-17T02:43:18Z "Weird problem, testd in IE8/9, Chrome, and Firefox. If you have a widget, with HTML in the default value, IE8/9 will remove the field entirely. However, if you then paste the HTML back into the field and save, it works fine. This ONLY happens after the initial drag/drop then save of the widget. It even happens if you drag/drop the widget, change the field and click save.
Example Plugin: http://wordpress.org/extend/plugins/ft-calendar/
Widget: Upcoming Events Widget
The Event Template (event_template) is set by default to:
{{{
%TITLE%
}}}
The event_template source for the Available Widget is:
{{{
%TITLE% (%TIME%)
)
OLD INSTANCE:
Array
(
[title] =>
[show_rss_feed] => off
[show_ical_feed] => off
[date] =>
[span] => +1 Month
[number_of] => 1
[date_types] => Month
[calendars] =>
[limit] => 0
[dateformat] => jS
[timeformat] => g:i a
[monthformat] => F Y
[event_template] =>
[date_template] => %DATE%
[month_template] => %MONTH%
[hide_duplicates] =>
)
}}}
Here is a screenr showing the problem not working in IE9 and working in Chrome: http://www.screenr.com/mkhs
" layotte
Needs Milestone 18417 Comment whitelist in discussion settings Comments normal normal Awaiting Review feature request new 2011-08-15T18:48:46Z 2011-08-17T09:49:25Z "Currently, there are methods for automatically flagging comments for moderation or blacklisting comments, but there's no way to auto-approve comments that meet a certain criteria.
In Discussion Settings, it would be nice to have ""Comment Whitelist"" option to automatically approve comments from a specific IP address, using a specific email address, or matching certain keywords.
One use case: a conference or workshop where lots of people are posting comments from the same IP address often invokes the ""Slow down, you're posting too fast"" message. Instead, we should be able to add the IP address to the whitelist (possibly temporarily) so that everyone can comment without hitting the restriction.
The concern I can think of is that this would add another large paragraph box to the Discussion Settings view." danielbachhuber
Needs Milestone 18480 get_sidebar should be able to accept an array of names as parameter. Template 3.2.1 normal normal Awaiting Review enhancement new dev-feedback 2011-08-18T22:29:12Z 2011-08-18T22:47:59Z "get_sidebar uses load_template to do the work of template loading.
load_template will accept an array of template names for loading.
load_template will then load the first existing template from that array.
Seems like get_sidebar should also accept an array of names that can be searched in declining order.
This would allow a theme to specify a first choice, second choice, etc. for the sidebar." gxxaxx
Needs Milestone 18502 Show ID on Custom Post Types Permalinks Rewrite Rules normal normal Awaiting Review enhancement new 2011-08-23T18:43:19Z 2011-08-23T18:50:35Z "Hi...
I have been using now lots of custom post types for different portals, and found that it's something no one ever knew, thought would be a cool feature if possible.
Now i have one custom post type for dvds, when the user publishes, it gets to
/dvd/name-of-dvd
The other settings for permalinks is set to show /%post_id%/ so in the blog it gets
/1/name-of-post
Just on custom post types it's imposible to make that.
For some things, like jobs, dvd, books, maybe there are things with same name, and an ID would be better to identify...
" kaiserlino
Needs Milestone 18325 TinyMce, noscript, and the gallery icon. TinyMCE 3.2.1 normal normal Awaiting Review defect (bug) new 2011-08-04T03:35:59Z 2011-08-23T22:03:10Z "If you include the shortcode for a gallery in an html noscript tag, and switch between visual and html mode, the gallery ""icon"" is replaced by html addressing the icon... which shouldn't be visible in visual edit mode. If you publish the page with the html showing, it will then save the gallery shortcode and discard the noscript tags. I haven't been able to understand this behavior.
I'm trying to use a slideshow shortcode followed by a gallery shortcode in a noscript tag as a backup for those without JS. This works so long as I don't republish the page from the visual mode. Then I get a slideshow and a gallery.
I've tested it on a different site of my multisite install with no plugins on and it still occurs, so I'm relatively confident the problem is in the way tinymce handles the noscript tag." cmdrmatt
Needs Milestone 18474 Misleading error message when theme ZIP exceeds post_max_size Upload 3.2 normal normal Awaiting Review defect (bug) new dev-feedback 2011-08-18T16:16:03Z 2011-08-23T22:46:14Z "''post_max_size'' is 32MB, now try to uploading a 40MB big ZIP.
You will get the ''Are you sure you want to do this? Please try again.'' message. But ''try again'' will not help.
Notice:
''Warning: POST Content-Length of 47774864 bytes exceeds the limit of 33554432 bytes in Unknown on line 0''" ocean90
Needs Milestone 18169 [15491] prevents to plug into the update API Upgrade/Install 3.1 normal normal Awaiting Review defect (bug) new has-patch 2011-07-19T09:13:49Z 2011-08-24T00:21:04Z "I'm a bit late to the party, but I've only noted now that changeset [15491] introduced a subtle change to the WP API, which prevents to readily plug into the update API:
Prior to it, the sequence went something like this:
{{{
$args = array(...); // set using a filter
$api = themes_api('query_themes', $args);
if ( is_wp_error($api) )
wp_die($api);
display_themes($api->themes, $api->info['page'], $api->info['pages']);
}}}
It now goes like this:
{{{
switch ($tab) {
case ...: // valid case
$args = array(...); // relevant args
break;
$args = false; // this is new. a filter should be present here...
}
if (!$args) return; // the 'query_themes' hook is no longer useful
$api = themes_api('query_themes', $args);
if ( is_wp_error($api) )
wp_die($api);
display_themes($api->themes, $api->info['page'], $api->info['pages']);
}}}
I used to use a hook in there to add a tab in the installer. The stab is still around, and is as far as I can tell part of it is still working, but it no longer seems possible to display the results using the normal API." Denis-de-Bernardy
Needs Milestone 18505 http 404 sent for the RSS feed when there are no posts - should be 200 Feeds 3.2.1 normal normal Awaiting Review defect (bug) new has-patch 2011-08-24T03:33:52Z 2011-08-25T00:13:02Z "for sites with no posts, the HTTP status code returned for the RSS feed is 404, but since the address was a valid address and it just happens that the content is empty, a 200 status should be sent.
(It annoys link checkers which then report that there are broken link at the site because by default for most themes there is a link to the RSS feed in the header) " mark-k
Needs Milestone 17594 Add pre_get_home_url hook for plugins General 3.2 normal normal Awaiting Review enhancement new reporter-feedback 2011-05-27T20:07:46Z 2011-08-26T02:46:22Z "We need to allow plugins to ""do stuff"" in pre_get_home_url. In profiling today, we wrote some code that, if we have this hook, would allow a reduction of computations from x (in our case, 4000) down to 1 using a pseudo-cache technique.
While that code isn't core-worthy, having a hook to allow plugin modification would incredibly enhance the ability to make WP more efficient on scale." technosailor
Needs Milestone 18550 Add args to signup_finished action General 3.2.1 normal normal Awaiting Review enhancement new 2011-08-31T00:07:01Z 2011-08-31T00:31:40Z "In wp-signup.php there are 2 calls to do_action( 'signup_finished' );
1) When an user sings up.
2) When a new user sing up and a new site (in Multisite) is created.
It'd be good to have a way to diferenciare this differente scenarios. Also, it'd be good to have the registered user info passed to this action.
" rabino
Needs Milestone 18574 Add class_name support to wpdb General normal normal Awaiting Review enhancement new dev-feedback 2011-09-02T20:03:58Z 2011-09-02T20:03:58Z "As of PHP 5.0.0, the second parameter to mysql_fetch_object takes a class name which will be instantiated instead of stdClass. This will be handy as we upgrade core objects (see #12267 and #15458). I am using the attached patch on WordPress.com to simplify a lazy process. The effect is similar to what does with WP_User but the code is much simpler.
The attached patch is fully backward-compatible unless you have defined classes named OBJECT, OBJECT_K, ARRAY_A, or ARRAY_N.
It could be improved by supporting the third parameter to mysql_fetch_object, an array of parameters to pass to the constructor. (For instance, you might want to pass $blog_id when constructing a WP_User). Adding this parameter would be perfectly simple if get_row did not already have a third parameter, $y, which is not used in core and should be removed because it invites wasteful queries." andy
Needs Milestone 18577 Updates and downloads should be signed or delivered securely Upgrade/Install normal normal Awaiting Review enhancement new dev-feedback 2011-09-03T01:23:16Z 2011-09-03T12:05:36Z "All channels for downloading Wordpress installations and plugins (e.g. from downloads.wordpress.org) should either be signed or delivered securely (e.g. via SSL) to mitigate man-in-the-middle attacks. Such attacks can lead to arbitrary code execution.
It appears that currently, downloads and automatic updates are neither signed nor delivered securely." wplid
Needs Milestone 18527 Duplicate Menu Option or Add a Hook for Plugins Menus 3.3 normal normal Awaiting Review enhancement new has-patch 2011-08-26T21:09:21Z 2011-09-04T10:25:22Z "It would be great to add a hook for plugins to be able to add options, etc, to Appearance > Menus. One thing would be to have the option to duplicate a menu.
I have worked up a patch that accomplishes this, which would serve as a good starting point for adding duplication functionality." wpsmith
Needs Milestone 18532 resized image dimensions incorrectly floored instead of rounded Media 2.5 normal normal Awaiting Review defect (bug) new has-patch 2011-08-27T16:14:29Z 2011-09-04T17:43:03Z "Image dimensions are incorrectly floored instead of rounded to a proper number. Some attempt at ""fixup"" is done later in some processes to move them by a pixel, but still the way it's initially calculated is wrong.
'''For example:
A typical photo has a 3:2 (3/2 = 1.5) ratio.
If it's resized to 600px width, WP will make the height 399px - this is wrong.'''
It happens because of ''function wp_constrain_dimensions'' in ''media.php'' (~line 304) which floors the float using intval, which is wrong.
{{{
$w = intval( $current_width * $ratio );
$h = intval( $current_height * $ratio );
}}}
'''I propose'''
{{{
$w = round( $current_width * $ratio );
$h = round( $current_height * $ratio );
}}}
Earlier in the function, both $ratio and $current_width are already handled as numbers, so they have to be valid numbers, no need to use intval for that reason, it's just being used to floor, which is bad in this case.
Using round is not a performance issue because this function is not used in realtime output for templates but typically in admin area.
Optionally while you are at it, put a filter on wp_constrain_dimensions and pass the filter all the values passed to the function before the array is returned at the end.
" _ck_
Needs Milestone 18617 Renaming menus orphans children when using global terms Menus 3.2.1 normal normal Awaiting Review defect (bug) new 2011-09-07T21:36:15Z 2011-09-07T21:36:15Z Renaming a menu when global terms is enabled will cause the menu to be disassociated from its children. This is caused by the reliance on `wp_get_nav_menu_object()` in `wp_update_nav_menu_item()` and elsewhere, where the calling function attempts to get the menu object using the old global term id rather than the new global term id. The menu items appear to be invalid because the menu term id has changed. adambackstrom
Needs Milestone 18625 term_exists() doesn't make a difference between z and ẓ Taxonomy 3.2.1 normal normal Awaiting Review defect (bug) new 2011-09-09T12:23:25Z 2011-09-09T15:31:21Z "I spent hours before discouvering why wp_insert_term doesn't want to create some of my categories list;
{{{
$alphabet = array (
array( 's', 'sth' ),
array( 'ṣ', 'sth' ),
array( 'h', 'sth' ),
array( 'ḥ', 'sth' ),
array( 'd', 'sth' ),
array( 'ḍ', 'sth' )
);
foreach ($categories as $category )
{
if( term_exists( mb_strtolower($category[0]), 'category' ))
continue;
else
wp_insert_term( $category[0], 'category', array( 'slug' => $category[0] ) );
}
}}}
term_exists() doesn't make a difference between ""normal characters"" and diacritic characters.
" abdessamad idrissi
Needs Milestone 18627 Google Chrome handles bulleted lists differently in Visual Editor than other browsers Editor 3.2.1 normal normal Awaiting Review defect (bug) new 2011-09-09T16:10:51Z 2011-09-09T16:10:51Z "In Firefox (working functionality):
1. create brand new post or page
2. in the visual editor, click Bulleted List icon
3. In Format menu choose H1
4. Type some text (it's inside a ul >> li >> h1)
5. Press Enter
Result: a new bullet, and we've lost the H1 style (just inside a ul >> li now)
Try this with Chrome 13.x
1. create a brand new post or page
2. in the visual editor hit the Bulleted List icon
3. in the Format menu choose H1
4. Type some text (it's inside a ul >> li >> h1)
5. Press enter
Result: no new bullet. We're inside a ul >> li >> div
Also tested in IE 7 and 8 (works fine). haven't tried other WebKit browsers." tomauger
Needs Milestone 16822 FORCE_SSL_LOGIN causes wp-login.php to have an incorrect https link jakub.tyrcha* Security 3.1 normal normal Awaiting Review defect (bug) accepted 2011-03-10T16:21:25Z 2011-09-10T01:20:12Z "In this bug, the WordPress logo on the login screen incorrectly links to an https URL. It is easy to reproduce.
First, define('FORCE_SSL_LOGIN', true) in wp-config.php. Then make sure you are logged out of WordPress. (Note: I am running multisite - I don't know if this matters or not.)
1. Visit /wp-login.php. Fill in WRONG credentials (misspell your password) and click the Submit button.
2. wp-login.php redisplays as expected, this time with an https URL.
3. The WordPress logo on the form now links to https://your.site.com. If you click it, you are visiting your site over SSL.
This should not happen. The WordPress logo (and any other links on the login page) should render http URLs." dbvista
Needs Milestone 17834 Quick Edit of Hierarchal Terms General normal normal Awaiting Review feature request new 2011-06-18T12:47:23Z 2011-09-10T01:41:21Z Would be nice if the Quick Edit function for hierarchal terms included the ability to change the parent. In fact, you could pretty much eliminate the Edit function altogether by doing this. DragonFlyEye
Needs Milestone 18558 Handling of dormant shortcodes is inelegant Shortcodes normal normal Awaiting Review enhancement new has-patch 2011-08-31T20:25:06Z 2011-09-10T02:43:21Z "Our handling of dormant shortcodes is inelegant. They spit out the raw shortcode. Better, would be for use to keep track of a historical record of which shortcodes have been registered, and if it's one of those ""dormant"" shortcodes (used to be registered, but no longer is), have it gracefully degrade, not show the shortcode, and return its contents if it's a wrapper shortcode.
This would require an option to track the shortcodes that have been used. Whenever a new one comes around, we add it to the array.
Eventually, we could deprecate the use of non-registered shortcodes, get rid of this solution, and simplify our regex to be generic (which would scale better)." markjaquith
Needs Milestone 17254 Contributors should be able to upload Role/Capability 3.1 normal normal Awaiting Review feature request new 2011-04-27T11:42:24Z 2011-09-10T03:10:26Z "Workflows and typical post content have evolved since the roles were defined. Posts frequently contain images, video, etc. As it is now, for someone to be able to put an uploaded image or video in a post, they have to be an Author, because contributors have no upload rights. This means that if a post contains any media, the person writing it has the ability to publish. There's a big gap now for use cases where a site owner wants to curate/edit contributor submissions before publication but wants those contributor posts to not be limited to text-only creations.
Proposal: allow contributors to upload media files (kept as draft, not published until approved by higher role). " jane
Needs Milestone 17516 Add Favorite Actions to Admin Bar Administration 3.2 normal normal Awaiting Review defect (bug) new 2011-05-19T18:37:03Z 2011-09-10T03:25:31Z "With the new UI upgrade, the favorite_actions() method was removed from the main UI. After a brief discussion with Westi, it made sense to put the functionality back in as part of the adminbar.
The attached patch does that using the favorite_actions() method (which can now return the filtered list of favorite_actions as an array). We should eat our own dog food." technosailor
Needs Milestone 16908 Normalize remove_accents() data General 3.1 normal normal Awaiting Review enhancement new has-patch 2011-03-20T22:54:24Z 2011-09-10T22:25:30Z "The remove_accents() functions contains the translitaration data in diverse formats. To normalize the code, a format of arrays containing key=>value replacements where the string value of key transposes into the string value of value.
That's already common for a large part of the function." hakre
Needs Milestone 18641 Date and post status are the wrong way around in post lists Administration 3.3 normal normal Awaiting Review enhancement new has-patch 2011-09-11T20:31:41Z 2011-09-11T20:35:13Z "On a post listing screen, a draft post that has been modified within the last 24 hours will show the following in the 'Date' column:
{{{
X hours ago
Last Modified
}}}
This doesn't make a lot of sense. Better would be:
{{{
Last Modified
X hours ago
}}}
Ideally the table cell should be treated as a whole to aid l10n and to improve the English presentation." johnbillion
Needs Milestone 18050 Label Most used taxonomies is impossible to customize on a new taxonomy Taxonomy 3.2 normal normal Awaiting Review enhancement new 2011-07-09T13:37:01Z 2011-09-13T03:01:09Z "The label in wp-admin/includes/meta-boxes.php doesn't allow to translate it in different languages when you create a new taxonomy. The attached patch resolve it adding the new label 'most_used'
" SGr33n
Needs Milestone 18653 Enhancement: Filter Taxonomy Show UI in post editor (edit-form-advanced.php) General 3.3 normal normal Awaiting Review enhancement new has-patch 2011-09-13T16:03:49Z 2011-09-13T17:48:45Z "I am working on a project that maintains a ""hidden"" taxonomy. I want to expose the taxonomy selectively on various custom post types.
The attached patch filters a taxonomy's show_ui value before deciding to create a meta_box. The filter also passes the taxonomy object as well as the current post type." transom
Needs Milestone 17964 Underlined text is gone when copied. TinyMCE 3.2.1 normal normal Awaiting Review defect (bug) new 2011-07-02T08:30:41Z 2011-09-14T10:10:23Z "If you underline a piece of text and you select it to copy/paste it on another spot at the page or post the line under the text is gone.
This bug doesn't appear with bold or italic text." JonezJeA
Needs Milestone 18661 Include IDs for users and sites on their respective views in the network admin danielbachhuber* Network Admin normal normal Awaiting Review enhancement accepted has-patch 2011-09-14T16:03:45Z 2011-09-15T18:58:20Z It would be nice if the IDs for Users and Sites were displayed in columns on their respective views in the network admin (with the option to hide in screen options of course) danielbachhuber
Needs Milestone 17848 "Not possible to add a file field to the ""add term"" form" Taxonomy normal normal Awaiting Review enhancement new dev-feedback 2011-06-19T23:35:22Z 2011-09-19T13:51:45Z "The ""add term"" form now uses ajax. The downside is that it is not anymore possible to add an additional file field using a plug-in as it won't be sent over ajax.
The easy way to fix this is to use the already included jquery.form script for that form. That plugin will make the form submit into a hidden iframe if a file field is found inside the form." DreadLox
Needs Milestone 17078 is_active_sidebar() doesn't work with Numeric sidebar ID's General 2.8 normal normal Awaiting Review defect (bug) new 2011-04-07T10:06:54Z 2011-09-19T15:07:09Z "This needs a small fix:
Function is_active_sidebar( $index) converts $index to a string
then uses wp_get_sidebars_widgets() to see if the sidebar is active
..but keys in the array wp_get_sidebars_widgets() generates can be integers if the ID's of the registered sidebars are integers" lanceo
Needs Milestone 18746 Make is_tag() accept a term name or term id General 3.3 normal normal Awaiting Review enhancement new has-patch 2011-09-22T13:05:15Z 2011-09-22T13:52:36Z "The ''is_category()'' function recieves as a parameter Category ID, Category Name or Category Slug.
So is the ''is_tax()'' function, it recieves as a parameter Term ID, Term Name or Term Slug.
But the ''is_tag()'' function can recieve only Tag Slug." ramiy
Needs Milestone 18748 Generalize 'tag_id' Query 3.2 normal normal Awaiting Review enhancement new has-patch 2011-09-22T15:29:19Z 2011-09-22T15:56:38Z "Currently, there's special handling for the 'tag_id' query var.
It would be nice to be able to define an equivalent query var for custom taxonomies. Example use case: #18747" scribu
Needs Milestone 18754 Add taxonomy argument to get_terms_orderby filter Taxonomy 3.3 normal normal Awaiting Review enhancement new has-patch 2011-09-23T12:04:05Z 2011-09-23T12:04:46Z "The `get_terms_orderby` filter in `get_terms()` doesn't get passed the taxonomies parameter.
If a plugin wants to use the taxonomies parameter when filtering the terms order, it must also filter `get_terms_args` and add the taxonomies argument to the $args array, so it can subsequently use it in the `get_terms_orderby` filter." johnbillion
Needs Milestone 18777 Add new site valid domain filter Network Admin normal normal Awaiting Review enhancement new has-patch 2011-09-26T11:41:32Z 2011-09-26T12:02:50Z "I've a client who wanted to add subdirectory sites in a multisite install e.g.:
example.com/department1/johnjoe
example.com/department2/fredbloggs
etc. But to do this, they had to add the site without the slash, then go back, and edit the sites URL.
So to allow support for this, ( coupled with the obligatory custom sunrise.php ) and to allow error checking ( e.g. not allowing depoortment1, and only allowing a preset number of subfolders ), I added a filter.
You'll find attached a small patch to site-new.php adding this filter" TJNowell
Needs Milestone 18680 Make SSL login-only possible (while leaving admin unencrypted) General 3.2.1 normal normal Awaiting Review enhancement new reporter-feedback 2011-09-16T05:54:33Z 2011-09-27T17:19:50Z "There are two options to be set in wp-config.php to enforce secure connections.
With the following configuration, the login AND the backend will be done via SSL:
{{{
define( 'FORCE_SSL_ADMIN', false ); // or true
define( 'FORCE_SSL_LOGIN', true ); // or false
}}}
As those are 'FORCE' parameters, one might consider it correct that, even though one is set to 'false', both will be via HTTPS.
However, WordPress is currently missing an option to have ONLY the login data sent encrypted and go on to the admin interface via a normal (non-encrypted) connection. That scenario requires additional redirections on the webserver." multimule
Needs Milestone 18791 Add custom post type support for Author Template functions Template 3.2.1 normal normal Awaiting Review enhancement new dev-feedback 2011-09-27T12:32:48Z 2011-09-27T19:58:40Z "Functions defined in `wp-includes/author-template.php` assumes that post type == post. It will be good to enhance them so they will be able to work with specified post type.
At first sight following functions will need update:
{{{
get_the_author_link()
the_author_link()
get_the_author_posts()
the_author_posts()
the_author_posts_link()
get_author_posts_url()
wp_list_authors()
}}}
I suspect there will be other updates needed, to support new `post_type` argument added to author's url." sirzooro
Needs Milestone 18729 No HTML Classes/IDs Associated With get_the_password_form() Output General 3.2.1 normal normal Awaiting Review feature request new has-patch 2011-09-21T10:11:35Z 2011-09-28T06:08:31Z "Currently get_the_password_form() outputs a password form that offers no HTML classes or IDs for proper styling:
{{{
/**
* Retrieve protected post password form content.
*
* @since 1.0.0
* @uses apply_filters() Calls 'the_password_form' filter on output.
*
* @return string HTML content for password form for password protected post.
*/
function get_the_password_form() {
global $post;
$label = 'pwbox-'.(empty($post->ID) ? rand() : $post->ID);
$output = '
';
return apply_filters('the_password_form', $output);
}
}}}
It would be quite useful to add classes to the form and input elements in this output so that we can properly style the password form without having to filter the output in, for example, a theme's functions.php file.
" philiparthurmoore
Needs Milestone 18816 Add 'offset' parameter and 'ancestral' boolean to wp_nav_menu General normal normal Awaiting Review enhancement new 2011-09-29T16:13:42Z 2011-09-29T16:13:42Z Since we can now call wp_nav_menu multiple times and there is the very useful 'depth' parameter, I believe adding an 'offset' parameter would be very beneficial in many situations. This would allow you to start at the children of the main pages for example and combined with depth it becomes very powerful. An 'ancestral' => 'true' option could output only menu items that the current page is a descendant of. Currently if you want to display a main menu in the header and then a submenu on page.php you either need a tricky custom walker or terrible CSS 'visibility:hidden' or 'display:none' situations. signyourbikeout
Needs Milestone 16832 Trouble if the slug of a custom taxonomy is the same as the url of page/post Rewrite Rules 3.1 normal normal Awaiting Review defect (bug) new 2011-03-11T11:50:43Z 2011-09-29T23:26:24Z "I got some troubles with the 3.1 version of WordPress concerning the slug of custom taxonomy.
'''An example that work in 3.0.5'''[[BR]]
www.example.com/agency (url of a page)[[BR]]
www.example.com/agency/john-smith (url of a custom type's detail)
Apparently having the same ""folder"" 'agency' only works for one or the other url but not both.
Hope I made myself clear." LucasHantz
Needs Milestone 18826 wp_maintenance() expiration time needs to be filterable Upgrade/Install 3.3 normal normal Awaiting Review enhancement new dev-feedback 2011-09-30T15:09:16Z 2011-10-01T01:23:22Z ".maintenance files expire after 10 minutes if something goes wrong. 10 minutes is a long time, when most upgrading operations are attempted and fail within 20-60 seconds.
I propose three things:
1. changing the default expiration to 5 minutes (300 seconds)
2. Adding a filter to allow plugins and themes to filter this time to increase/decrease it
3. Also, while I was in there, it seems prudent to attempt to delete the file if it has expired. The only argument I could see against this is that possibly it might be expensive if the file can not be deleted and wp attempts to delete the file on every page load. So I can take or leave 3 (and 2), but #2 I think is really important." jaredh123
Needs Milestone 18833 Pass raw data into save_post/wp_insert_post rmccue Administration normal normal Awaiting Review enhancement new has-patch 2011-10-01T09:15:14Z 2011-10-02T02:24:01Z "Almost all tutorials about custom metaboxes (in addition to post meta) use `$_POST` to get the data that was submitted. Unfortunately, this breaks if a plugin uses anything that calls `wp_insert_post()` in the same request.
The patch attached here includes the `$postarr` array, which is the raw data passed in, and which is `$_POST` from `wp-admin/post.php`. This allows one to use the third parameter to the callback to set meta data instead of having to use `$_POST` directly." rmccue
Needs Milestone 18258 Users should not edit upstream themes Themes normal normal Awaiting Review enhancement new 2011-07-26T12:11:06Z 2011-10-02T10:50:10Z "Currently, when users are entering the theme editor from the administration UI, they get the ability to edit the theme with very basic knowledge required. The downside with that that their tweaks will lost as soon as they update the theme or if this is WordPress default theme if they update the WordPress core.
I purpose the following change – Users will be prompted with a message if they try to edit a message with an upstream link and presumably won't be able to edit the theme styles. Instead, they will get the opportunity to automatically create a child theme of the upstream theme with a default template which might contain theme metadata, and @include rule to add the stylesheet of the other theme.
Making this will help promote the usage of child themes and will make it easier to novice bloggers to hack their themes. It is also better from the current implementation by extensions as it doesn't require runtime database queries to fetch the additional author stylesheet." Tomer
Needs Milestone 18771 Reset Password link generation Users 3.2.1 normal normal Awaiting Review defect (bug) new close 2011-09-25T16:30:42Z 2011-10-02T16:20:23Z "I have been having problems with the login following a reset password.
A user click the ""forgotten password"" link and then after receiving the email clicks the link in the email to reset their password submits their new password gets a message that says ""You have successfully reset your passoword. Log in"" The link for login is not being generated correctly which is causing them to get a ""Invalid Key"" error.
Here is what I have dont to temporarily resolve the issue:
in wp-login.php I modified the following lines of code:
changed Line 207:
{{{
if ( empty($key) ) {
}}}
to this:
{{{
if ( empty($key) || preg_match('/[^a-z0-9]/i',$key) != 0) {
}}}
Removing special characters from the key that gets emailed to the users when they click the ""forgotten password"" link on the login page.
Commented out Line 444:
{{{
login_header(__('Password Reset'), '' . __('Your password has been reset.') . ' ' . __('Log in') . '
');
}}}
then slightly modified it removing the login link from the message
{{{
login_header(__('Password Reset'), '' . __('Your password has been reset.') . '
');
}}}
This change forces the user to return to the homepage before logging in again and then they dont get the ""invalid key"" error.
It would be nice if there were a more permenant fix for this issue that wouldn't get lost when we update the next time." binaryweb
Needs Milestone 18814 wp_redirect wont allow arrays to be sent in query string General 3.2.1 normal normal Awaiting Review enhancement new 2011-09-29T14:27:38Z 2011-10-03T17:04:52Z "
The pluggable function wp-redirect will not allow arrays to be sent in a query string.
ie: http://www.example.com/?array[]=first&array[]=second&array[]=last
The brackets are stripped out when the URL is sanitized and it becomes:
http://www.example.com/?array=first&array=second&array=last
This removes the ability to pass the array." jacksplay
Needs Milestone 18848 Filter post listing screen by post parent johnbillion Administration 3.3 normal normal Awaiting Review feature request assigned 2011-10-03T16:19:10Z 2011-10-03T18:56:58Z "It's not possible to filter a post listing screen by post_parent. This would be super handy for hierarchical post types (eg. Pages) where you may have several levels of hierarchy and want to view only the descendants of a particular page. I'm not sure that we need a UI (eg. dropdown menu) for it, but a working URL query var would be great.
I made an attempt at patching this a while ago using the child_of parameter but it got complicated quite quickly, so I'm putting it out there as a feature request in case anyone feels like tackling it." johnbillion
Needs Milestone 18596 Not possible to filter comment screen by post type Administration 3.3 normal normal Awaiting Review enhancement new has-patch 2011-09-05T16:50:33Z 2011-10-03T20:41:20Z "The `post_type` query var has no effect on the Comments screen so it's not possible to filter this screen by post type.
I'll work on a patch." johnbillion
Needs Milestone 16509 Offer remote install-script as installer option General normal normal Awaiting Review feature request new 2011-02-09T22:01:35Z 2011-10-03T23:03:55Z "I've just tried this script
http://instantinstall.org/
and I wondered if it weren't a useful addition to have an officially supported remote install script for WP. So people could download the script instead of the entire package, upload it to their servers and let them do the heavy lifting. This would be particularly useful for people who regularly set up WP for clients.
Having a wp.org supported script would be great for people who are weary of using third party code." youngmicroserf
Needs Milestone 18778 Add filters to transform_query() to allow caching of queries created by this function. Taxonomy normal normal Awaiting Review enhancement new dev-feedback 2011-09-26T12:02:08Z 2011-10-05T09:20:40Z [https://core.trac.wordpress.org/browser/trunk/wp-includes/taxonomy.php#L749 transform_query()] works great on regular datasets, but if you run this on a large set of data it can get very expensive. adding some filters in here that could allow these queries to be cached would be benefitial. tott
Needs Milestone 18860 Chromeless metaboxes Administration normal normal Awaiting Review enhancement new has-patch 2011-10-05T14:28:14Z 2011-10-06T13:39:07Z "On the post editing screen, the title and editor portions are just conditionally echoed based on post_type_supports().
Because of this, you can't add anything between them or above them, without using JavaScript.
The proposal:
- wrap them in callbacks and inject them through add_meta_box()
- add a $show_handle parameter to add_meta_box()
{{{$show_handle == false}}} would mean that the handle around the box would be invisible. This would mean that you wouldn't be able to drag the title and editor boxes around, which is ok, but you would be able to re-order them in PHP." scribu
Needs Milestone 18685 GET Requests with hostname in them causes wrong redirect General 3.2.1 normal normal Awaiting Review defect (bug) new dev-feedback 2011-09-16T14:34:54Z 2011-10-07T08:49:01Z "Hi!
I have noticed that my Android phone when using Cyanogenmod with default browser does some ""special"" things when on 3G. (It does not happend via WiFi)
It appears that the hostname is sent with every GET-request. Its common to only send the path in a GET-request but the HTTP secification also allows for the use of hostname within a GET-request.
My test page ( http://h3x.no/dump/test.php ) shows the hostname in the REQUEST_URI via 3G, and skips the hostname when on WiFi.
This causes Wordpress(i suspect) to redirect me to the wrong page.
Example:
I want the page:
http://h3x.no/2011/09/12/getting-windows-2008-server-uptime-via-the-command-line
My phone sends me to:
http://h3x.no/2011/09/12/getting-windows-2008-server-uptime-via-the-command-line/http/h3x.no/2011/09/12/getting-windows-2008-server-uptime-via-the-command-line" Ueland
Needs Milestone 18448 wp_insert_category() is Not Properly Abstracted Taxonomy 3.0 normal normal Awaiting Review defect (bug) new has-patch 2011-08-16T17:43:09Z 2011-10-08T16:47:53Z "If you look in http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/taxonomy.php there is still a note that says ""The 'taxonomy' key was added in 3.0.0.""
However, this function calls category_exists() and cat_is_ancestor_of(), which never recognized the taxonomy argument." miqrogroove
Needs Milestone 18254 Preserve image aspect ratio when editing dimensions manually in post editor Editor 3.2.1 normal normal Awaiting Review enhancement new dev-feedback 2011-07-26T01:57:16Z 2011-10-09T14:09:17Z "The dialog box that pops up when the user clicks the ""edit image"" icon that appears on hovering over an image in the visual editor has an ""Advanced settings"" tab with input fields for the pixel dimensions of the image.
When one is updated, the other does not change. A popular feature of image management software is to ""link"" the values and preserve the aspect ratio of the image.
I propose that WordPress have the option (a checkbox by the inputs?) to do this.
Sorry if this is terse; I'm about to be kicked off this library machine and I can't come back until tomorrow. Comment with anything I need to add and I'll update when I can." voyagerfan5761
Needs Milestone 12350 Check folder permissions before uploading file Administration normal normal Awaiting Review enhancement reopened 2010-02-23T18:41:57Z 2011-10-09T14:54:04Z "It would be nice if wordpress - or especially the media-upload module would check if its able or has the necessary file permissions to create the upload directory.
" not2bug
Needs Milestone 18968 Remove some term cache misses Performance 3.3 normal normal Awaiting Review enhancement new has-patch 2011-10-17T01:44:42Z 2011-10-17T15:47:43Z "On post listing screens a database query is performed for each taxonomy on each post. We can hit the term cache instead by using `get_the_terms()` in place of `wp_get_object_terms()` and `wp_get_post_terms()`.
By default, this change won't impact performance because the term cache isn't primed at this point, but on a site using a persistent object cache it'll hit the term cache each time instead of performing a database query. This saves `{numberofposts} × {numberoftaxonomies}` queries which can be quite a few on custom post type screens which display several taxonomy columns." johnbillion
Needs Milestone 18165 Admin tables empty when installed on *nix with Apache 2.x, PHP 5.3 running as CGI with wrapper script Administration 3.2.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2011-07-18T21:01:37Z 2011-10-18T20:27:46Z "* Wordpress 3.2.1
* Apache 2.2.3
* PHP 5.3.5
When running with suexec through a wrapper script such as set up by Webmin, the PHP_SELF variable is ""fixed"" by PHP to point to the wrapper instead of the actual script. This in turn kills some of the admin lists (posts are empty) along with problems setting theme (Thematic) options.
To recreate, adjust '''httpd.conf''' vhost to:
{{{
SuexecUserGroup ""#1111"" ""#2222""
ServerName example.com
DocumentRoot /home/example.com/www
ErrorLog /home/example.com/logs/error_log
CustomLog /home/example.com/logs/access_log combined
ScriptAlias /cgi-bin/ /home/example.com/cgi-bin/
Options Indexes IncludesNOEXEC FollowSymLinks
allow from all
AllowOverride All
Action application/x-httpd-php5 /cgi-bin/php5.cgi
AddType application/x-httpd-php5 .php5
AddType application/x-httpd-php5 .php
allow from all
RemoveHandler .php
RemoveHandler .php5
}}}
Add the following shell script '''/cgi-bin/php5.cgi'''
{{{
#!/bin/bash
PHPRC=$DOCUMENT_ROOT/../etc/php.ini
export PHPRC
umask 022
SCRIPT_FILENAME=$PATH_TRANSLATED
export SCRIPT_FILENAME
exec /usr/bin/php-cgi
}}}
Copy the '''php.ini''' file to '''/home/example.com/etc/'''
The problem is temporarily solved by setting the following PHP option in '''php.ini''':
{{{
cgi.fix_pathinfo = 0
}}}
Which tell PHP not to do a path gawk. I think what should be done is Wordpress should not use PHP_SELF or at least prefer using ORIG_PHP_SELF if it exists, possibly resetting PHP_SELF for downstream functions.
" magdude
Needs Milestone 16754 PHP5-port - srand() General 3.1 normal normal Awaiting Review enhancement new has-patch 2011-03-05T10:42:18Z 2011-10-19T01:16:20Z "No need to seed the random number generator.
See [http://www.php.net/manual/en/function.srand.php srand()] for details.
Related: #16753" hakre
Needs Milestone 16883 "Add check for ""Template Version"" on theme activation" Themes 3.1 normal normal Awaiting Review enhancement new dev-feedback 2011-03-18T03:28:36Z 2011-10-19T18:15:47Z "Related: #16395
In addition to adding Template Version to the standard meta information extracted from style.css in `get_theme_data()`, I think that for this information to be useful, a child theme shouldn't be able to be activated unless the template template the child theme uses (parent theme) meets the minimum version requirement identified in ""Template Version"".
A polite and graceful failure, with an error notice, would be preferable :-)
Reason: many times child themes utilize functionality that only exists in the latest version of a parent theme. They're stuck either writing backward compatibility into into their code, or risking whitescreens.
This not only prevents that, but it could be used to gently encourage the user to update the parent theme.
Certainly not a candidate for 3.1.1, but perhaps 3.2?" nathanrice
Needs Milestone 16576 comment_form() fields being displayed only for non logged in users Comments 3.0.5 normal normal Awaiting Review enhancement new 2011-02-16T18:15:44Z 2011-10-19T23:28:16Z "I've just noticed this - When using the '''comment_form()''' function and adding some comment meta fields,using the fields array in the $args, these fields are being showed in the front-end only for non logged in users.
In this case, the registered users can never use these comment fields.
Look at wp-includes/comment-template, lines 1561-1573 (WP 3.0.5), it parse the $args['fields'] in the else block -
{{{
$field ) {
echo apply_filters( ""comment_form_field_{$name}"", $field ) . ""\n"";
}
do_action( 'comment_form_after_fields' );
?>
}}}
I think it is better that added meta fields should be displayable for all users (logged in and not logged in), or even to add a parameter to let the developer decide which extra fields are shown to logged or not logged users.
" maorb
Needs Milestone 16264 Add function get_pages_by_template() Post Types 3.1 normal normal Awaiting Review feature request new has-patch 2011-01-16T19:38:15Z 2011-10-22T03:14:18Z "This patch adds a function `get_pages_by_template()` to `/wp-includes/post.php`. It accepts a page template string and returns an array of post objects keyed by the pages that use the template:
{{{
$pages = get_pages_by_template( 'page-about.php' );
}}}
Using WordPress for CMS I've been finding a need to provide links to specific pages in a more robust way than hardcoding their `post_id` or even referencing their `post_name`/`URL slug` and the way I've identified that works well is to locate a page by it's page template. Here a function that a theme might write that would use the function I'm proposing be added:
{{{
function get_about_page_link() {
$pages = get_pages_by_template( 'page-about.php' );
if ( count( $pages ) )
return get_page_link( get_post( $pages[0] )->ID);
return false;
}
}}}
Unfortunately WordPress does not have efficient functionality in core that would allow a themer to lookup a page or a list of pages by their templates thus requiring the theme developer to resort to SQL which is ideally avoided.
Thus I'm providing this patch to enable a themer to do this lookup without having to resort to SQL.
The patch also fixes a typo that affects phpdoc in the same file: @parem => @param.
" mikeschinkel
Needs Milestone 18877 DRY up rewrite rule matching Rewrite Rules normal normal Awaiting Review enhancement new has-patch 2011-10-06T22:24:34Z 2011-10-24T13:42:44Z "Currently, the whole rewrite matching loop is duplicated: once in WP::parse_request() and once in url_to_postid().
Re-posting the patch from #16687 for consideration." scribu
Needs Milestone 16203 Modifications of media doesn't generate alternatives added by add_image_size() Media 3.0.4 normal normal Awaiting Review defect (bug) new 2011-01-12T16:03:51Z 2011-10-25T16:39:55Z "Upload an image, then select ""Edit Image"".
Crop the image and Save.
Images with sizes added eith add_image_size() doesn't get alternatives generated as the standard sizes does." andreaswedberg
Needs Milestone 17413 Code added by WP_List_Table::_js_vars is duplicated sorich87 Administration 3.2 normal normal Awaiting Review defect (bug) new dev-feedback 2011-05-13T09:45:49Z 2011-10-27T17:58:16Z When a list table is 'ajax enabled' (e.g. comments list table on edit-comments.php), javascript code is added by WP_List_Table::_js_vars to the footer. If you look at the source code in your browser, you will see that code is duplicated. sorich87
Needs Milestone 19055 Post type check on top of wp-admin/edit.php enhancement Post Types normal normal Awaiting Review enhancement new dev-feedback 2011-10-26T10:04:48Z 2011-10-27T21:12:06Z "I was looking into edit.php and I noticed that when you unregister post type 'post' on a hacky way it never would return as an invalid post type. I do know that this is just a little step to make unregistering a post type easy.
I would say that:
{{{
if ( !isset($_GET['post_type']) )
$post_type = 'post';
elseif ( in_array( $_GET['post_type'], get_post_types( array('show_ui' => true ) ) ) )
$post_type = $_GET['post_type'];
else
wp_die( __('Invalid post type') );
}}}
should be:
{{{
if ( !isset($_GET['post_type']) )
$_GET['post_type'] = 'post';
if ( in_array( $_GET['post_type'], get_post_types( array('show_ui' => true ) ) ) )
$post_type = $_GET['post_type'];
else
wp_die( __('Invalid post type') );
}}}
related: unregister_post_type() #14761" markoheijnen
Needs Milestone 19044 $depth in start_el Walker_Category has null value Taxonomy normal normal Awaiting Review defect (bug) new reporter-feedback 2011-10-25T10:17:55Z 2011-10-28T08:46:10Z "{{{
File wp-includes/category-template.php
Line: 829
}}}
Issue:
{{{
The variable $depth is not returning value.
start_el() - $depth not showing. (Always return zero)
start_lvl() - $depth works fine.
end_lvl() - $depth works fine.
}}}
{{{
/**
* @see Walker::start_el()
* @since 2.1.0
*
* @param string $output Passed by reference. Used to append additional content.
* @param object $category Category data object.
* @param int $depth Depth of category in reference to parents.
* @param array $args
*/
function start_el(&$output, $category, $depth, $args) {
.....
}}}
" nukecpower
Needs Milestone 19068 admin comment search never resets URL, grows infinitely Administration 3.2.1 normal normal Awaiting Review defect (bug) new 2011-10-27T15:23:48Z 2011-10-28T11:53:53Z "When searching from {{{ /wp-admin/edit-comments.php }}}
the URL will grow infinitely and never reset to it's base.
To reproduce this bug, simply search comments several times and then examine the resulting URL )by copying it to an editor). It will be over 1000 characters easily, because it's simply appending the previous searches and previous nonces for no useful reason.
Instead the form should just use {{{ /wp-admin/edit-comments.php }}} as it's submit base.
But that form should not be using GET in the first place.
Allowing overly long URLs is also a security problem as it can give a window for XSS attacks.
I wouldn't be surprised if this design flaw exists in other parts of WP admin but I'll leave that up to someone else who has more patience.
" _ck_
Needs Milestone 18910 get_blog_details query alteration for root-relative url plugin support... Multisite 3.2.1 normal normal Awaiting Review enhancement new has-patch 2011-10-11T23:39:05Z 2011-10-28T22:28:13Z "After reading through this ticket http://core.trac.wordpress.org/ticket/17048 and all of its referenced links / discussions I decided to write my own plugin to do root-relative urls.
However there is a core issue that prevents such a plugin from working when using path-based MU installs (versus subdomain installations where as it stands cannot support root relative urls... yet.)
Looks like the logic for path-based site detection was copied wholesale from the subdomain-based detection logic in the if-block just below it.
I don't see a need to query both the path and the domain if the domain isn't going to change for a MU path-based install. This fix proposes checking explicitly for is_subdomain_install == false and then only querying the database on the path column.
If this patch doesn't account for some scenario in which path-based installs could actually have multiple domain addresses in the database then please add a filter to the $fields variable so that a plugin can handle the variance there.
I'm not here to start a root-relative vs absolute uri debate (I'm saving that for another day ;) But basically the recommendation from the WP Core team is to do this in a plugin, yet we can't until this is fixed.
Thanks!
-Marcus
(ps - if you'd like to have the absolute uri / relative root debate I'm totally game! just email me :D)" MarcusPope
Needs Milestone 19109 Want display fullscreen button only html editor mode. Editor 3.2.1 normal normal Awaiting Review feature request new 2011-11-02T03:18:48Z 2011-11-02T03:37:55Z "v3.2.1 writing fullscreen mode is display button both visual mode and html mode or visual mode only.
I want to display html mode only button. Want the following specification.
1. visual mode and html mode
2. visual mode only
3. html mode only <- new
Regards." tatsuya
Needs Milestone 19135 wp_get_archives() needs a hook/filter General normal normal Awaiting Review enhancement new dev-feedback 2011-11-03T22:12:19Z 2011-11-05T20:20:01Z "I would expect that it would have one. It was proposed at one point: #2329
Consider the case where I want to add `rel=""nofollow""` to links in my archive:
{{{
function nofollow($string) {
$dom = DOMDocument::loadXML($string);
$list = $dom->getElementsByTagName('a');
foreach($list as $a) {
if (!$a->hasAttribute('rel')) {
$a->setAttribute('rel', 'nofollow');
}
}
return $dom->saveHTML();
}
ob_start();
wp_get_archives('type=monthly&limit=12');
echo nofollow(ob_get_clean());
}}}
That seems really ugly, especially since I already use the nofollow function in other places using `apply_filter`;
A more elegant way:
{{{
function wrap($string, $tag) {
return ""<$tag>$string"";
}
function nofollow($string) {
$dom = DOMDocument::loadXML($string);
$list = $dom->getElementsByTagName('a');
foreach($list as $a) {
if (!$a->hasAttribute('rel')) {
$a->setAttribute('rel', 'nofollow');
}
}
return $dom->saveHTML();
}
add_filter('wp_get_archives', 'wrap', 'ul');
add_filter('wp_get_archives', 'nofollow');
wp_get_archives('type=monthly&limit=12');
}}}" LeviMorrison
Needs Milestone 19110 Media File Url Media normal normal Awaiting Review enhancement new 2011-11-02T05:58:42Z 2011-11-07T10:41:44Z "The media file URL includes the site URL this makes running two identical copies of the same site problematic since it would require doing a search and replace through a dumped database for each synchronization.
The following is stored in the guid column:
http://braydon.com/wp-content/uploads/2011/10/BGF028_500x606.jpg
My recommendation is to store in the guid column:
/wp-content/uploads/2011/10/BGF028_500x606.jpg
Which then could become:
http://braydon.com/wp-content/uploads/2011/10/BGF028_500x606.jpg
http://mirror1-of-braydon.com/wp-content/uploads/2011/10/BGF028_500x606.jpg
http://mirron2-of-braydon.com/wp-content/uploads/2011/10/BGF028_500x606.jpg
http://braydon.localhost/wp-content/uploads/2011/10/BGF028_500x606.jpg
Although this could cause a problem to how the guid field is to be handled, and a new column would need to be made." braydonf
Needs Milestone 19188 Only one dashboard widget can't be moved into second column unless Screen Options is expanded General 2.9 normal normal Awaiting Review defect (bug) new 2011-11-06T22:02:54Z 2011-11-07T21:01:20Z "A crazy weird issue. Since 2.9, a single dashboard widget can't be dragged (easily) into the second column unless the Screen Options are expanded.
Screencast: http://cl.ly/3y0j1o2f3A2f3l06120R" ryanimel
Needs Milestone 17478 Disable Comments for Pages / Disable Comments for Pages Site-Wide General 3.1.2 normal normal Awaiting Review feature request new 2011-05-17T19:04:25Z 2011-11-08T16:23:44Z "Ladies and gentlemen,
it's been suggested on the Forum that I start a new ticket here. I think it's a good idea.
Here's a couple of suggestions that I believe if implemented would greatly improve WordPress functionality and popularity:
1) Make the Display Widget for pages visible by default, the way it was before the WordPress 3.0. Many non-blog WordPress website owners, and many bloggers, want the comments for pages disabled, but have no idea how to do that, because the Discussion checkbox in the Screen Options panel for Pages is deselected by default. As a result, most people new to WP 3 have no idea that Discussion Widget even exists, and have trouble disabling comments on pages.
Disabling such comments is very necessary in many situations. For example, a page that includes only a contact form, shouldn't have comments. Most WordPress users do not need their portfolios, or their ""About"" pages commented – and so on.
2) Create the checkbox that would allow to toggle all comments (old and new) comments for all pages with one click – and a separate checkbox that would allow to toggle all comments (old and new) for all posts – site-wide.
Many WordPress based business websites have hundreds of pages, and it would save a lot of time if the owner or designer could just disable the comments by deselecting one checkbox. I do realize it can be easily done by commenting out the comments in the code, but wouldn't it be nicer to have it as a checkbox option?
Some of the owners of such sites want to have a blog on their site, too - and want to have comments as a traditional part of blog functionality. That's what comments for pages and posts should be toggle-able site-wide independently from each other.
For best experience, the post comments should also have a toggle checkbox. Some owners may want to disable comments for all posts site-wide, too.
To see where this request is coming from, please Google ""disable comments for pages wordpress"" and you will see that the issue does cause quite a bit of confusion.
Also please see this thread of the WordPress support forum about: http://wordpress.org/support/topic/disable-comments-for-page-option/
I hope this suggestion helps to improve WordPress – already the greatest open source CMS platform.
Best regards,
Dimitri Vorontzov
" Dimitri Vorontzov
Needs Milestone 19211 WordPress should be properly capitalized in the HTML title General normal normal Awaiting Review enhancement new has-patch 2011-11-08T23:49:59Z 2011-11-09T04:59:43Z "The HTML title element doesn't get properly capitalized P's, only the post title does.
For example: http://gigaom.com/2011/11/08/wordpress-founder-matt-mullenweg-to-speak-at-roadmap/" evansolomon
Needs Milestone 19197 phplinter error reports against wordpress core. General normal normal Awaiting Review defect (bug) new close 2011-11-07T17:34:14Z 2011-11-09T14:42:40Z "One of our developer has been developing phplinter which can be found here [1] which gives wordpress core rather poor grade many of which are simply due to you guys having spaces mixed with tabs and whitespace after final close tag and others generally considered bad practices and few probably more serious.
Instead of me filing indvidual bugs for all of those I think it's best that you just git pull the phplinter and run it against wordpress then point your web browser against the report and flag/fix those that are relevant and those that are not.
An simple cli example is as follow...
#phplinter -wFIH wordpress/ -o lintreport/
380 files, Average score: -2.86
Worst: wp-includes/class-simplepie.php with -303.39
[1] https://github.com/robotis/PHPLinter" vikingnr1
Needs Milestone 18824 Password protected pages don't work if site address is different from wordpress address General 3.2.1 normal normal Awaiting Review defect (bug) new has-patch 2011-09-30T13:15:08Z 2011-11-09T21:44:28Z "Hi,
On a 3.2.1 wordpress site, we notices that password protected pages didn't work.
Site address is in another domain (x.com) than wordpress address (y.com).
If we set the same domain for both of them, protected pages work again.
I think I understood what was going on:
1. the browser gets the form for the password via siteurl.
2. however the forms posts data to wordpress address (wp-pass.php), and the browser gets the cookie within this domain (and not siteurl domain)
3. the browser is redirected to siteurl, but the cookie doesn't work (domain mismatch).
I corrected wp-pass.php, by replacing get_option('siteurl') by get_option('home'), and it worked." 3singes
Needs Milestone 19227 clicking the pinkynail/title in the media-upload.php library tab does not show the full media info. Upload 3.3 normal normal Awaiting Review enhancement new 2011-11-10T20:30:35Z 2011-11-10T20:31:40Z "I am using the latest nightly build.
I am not sure if this is supposed to work this way, but it does have the 'toggle' class and UX wise it should I think.
Steps to reproduce:
1: Open a post/create a new post
2: Click the Upload/insert media button.
3: in the media iframe click 'Media Library'
4: Click on an 'pinkynail' or title in the list
Nothing happens. I would expect clicking the 'pinkynail' or title to activate the same 'toggle' as the 'show' link does as we read left to right, our eyes are drawn to the image and we are generally choosing an image here, so our instinct is to click that. Plus this is how it works in the 'full' (i.e. non-iframe) version. It could also do with css to make the cursor 'pointer'.
Tested in latest versions of Chrome and Firefox in Windows 7" davidosullivan
Needs Milestone 19238 New approach for content navigation section in themes Themes 3.3 normal normal Awaiting Review feature request new dev-feedback 2011-11-12T16:06:01Z 2011-11-12T16:06:01Z "At this moment the only way to replace default content navigation in theme (previous/next posts links) is to manually edit theme files. Ticket #18585 allows to replace this section, but its scope is limited to Twentyeleven and its child themes.
Therefore I propose to introduce generic mechanism, which could be used by theme and plugin autors - e.g. add new `content_navigation_template()` theme tag. By default it should look for `navigation.php` file in theme directory and include it. There should be also a new filter, which could be used by child theme and plugin authors to provide alternate navigation section." sirzooro
Needs Milestone 19192 Wrong term count for private posts General normal normal Awaiting Review defect (bug) new close 2011-11-07T09:00:15Z 2011-11-14T21:22:33Z "The term manager page (wp-admin/edit-tags.php) shows wrong counts when the terms contain private posts.
Steps to reproduce:
- Create a private post and assign it to a category or a tag.
- Visit the wp-admin/edit-tags.php
The term count does not change. However, when you click on the posts column, the edit posts screen will correctly show the private post." xknown
Needs Milestone 18048 Ctrl+S draft save causes prompt on exit Administration normal normal Awaiting Review defect (bug) new close 2011-07-09T12:25:25Z 2011-11-15T03:45:49Z "When you use the ""save draft"" button and leave the edit page, the ""unsaved changes"" prompt doesn't show up. However, when you save using Ctrl+S and leave - the prompt appears." jakub.tyrcha
Needs Milestone 18988 "On install, IIS web.config missing setting for ""index.php"" as default page type" IIS 3.2.1 normal normal Awaiting Review defect (bug) new 2011-10-18T17:50:05Z 2011-11-15T08:51:42Z "If WordPress is installed in the root directory (e.g., www.example.com) on a server not pre-configured for PHP, ""index.php"" will not be a default page name on the server. This leads to 404 errors when requesting the homepage (e.g., www.example.com).
A simple fix is to update the web.config for the WordPress install to add this:
" scdetailer
Needs Milestone 18851 search form in edit.php should keep parameters it does not understand Administration normal normal Awaiting Review enhancement new 2011-10-03T21:48:17Z 2011-11-15T11:29:40Z "the component is class-wp-list-table.php.
if you carry along some kind of status in the url in the post list (e.g. url=https://example.com/wp-admin/edit.php?post_type=post&my_status=""abcdefg"") the search field should not remove the parameter." ibotty
Needs Milestone 18575 wptexturize modifies code inside tag attributes Formatting 3.2 normal normal Awaiting Review defect (bug) new has-patch 2011-09-02T22:36:25Z 2011-11-16T00:10:37Z "In certain circumstances, wptexturize() will try to smart quote things inside attributes, screwing up the markup. For example:
{{{
[hello world
}}}
The tokenizer that generates $textarr will split the text like this:
{{{
0: [hello world
2:
}}}
and so element 1 gets treated like non-tag text even though it's from an attribute. the easy fix is to not allow starting braces inside a brace set:
old:
{{{
$textarr = preg_split('/(<.*>|\[.*\])/Us', $text, -1, PREG_SPLIT_DELIM_CAPTURE);
}}}
new:
{{{
$textarr = preg_split('/(<[^<]*>|\[[^\[]*\])/Us', $text, -1, PREG_SPLIT_DELIM_CAPTURE);
}}}
this happens on trunk. code is in wp-includes/formatting.php. after the patch, the tokenizer works as intended:
{{{
0: [hello
1:
2: world
3:
}}}
" iamcal
Needs Milestone 18701 """hierarchical"" argument for get_pages() does nothing" General 3.0 normal normal Awaiting Review defect (bug) new 2011-09-19T06:48:32Z 2011-11-16T00:17:33Z "The `hierarchical` argument for `get_pages()` is never actually used. It is in an `if` statement, but one that requires `child_of` to also be set:
{{{
if ( $child_of || $hierarchical )
$pages = & get_page_children($child_of, $pages);
}}}
Props Vynce Montgomery for pointing this out to me." Viper007Bond
Needs Milestone 18632 wp_get_shortlink() Should Always Return a URL Template 3.1 normal normal Awaiting Review defect (bug) new has-patch 2011-09-10T03:27:51Z 2011-11-16T00:18:51Z "Currently the code used in the link-template.php file causes the `wp_get_shortcode` function to return an empty result if the WordPress installation is using the default permalink structure. This causes at least issues with `the_shortcode` function and can be expected to cause issues any place that `wp_get_shortcode` is called when the default permalink structure is being used.
An alternative is to simply make the inline documentation state an empty result will be returned when the default permalink structure is used." cais
Needs Milestone 18613 get_adjacent_post() doesn't find private posts General normal normal Awaiting Review enhancement new has-patch 2011-09-07T15:52:25Z 2011-11-16T00:49:50Z The status is always 'publish'. scribu
Needs Milestone 18518 suggest.js: don't store the URL in the options object General normal normal Awaiting Review enhancement new has-patch 2011-08-25T20:35:21Z 2011-11-16T00:51:03Z "...because it prevents re-using the same instance for different URLs:
{{{
var suggest_args = {
multiple : true,
delimiter : ',',
resultsClass : 'qc-suggest-results',
selectClass : 'qc-suggest-over',
matchClass : 'qc-suggest-match',
};
$( '#ticket-assign input' ).suggest( QC_L10N.ajaxurl + '?action=qc-user-search', suggest_args );
$( '#ticket-tags input' ).suggest( QC_L10N.ajaxurl + '?action=ajax-tag-search&tax=post_tag', suggest_args );
}}}
With the above code, both inputs will look for items in the same URL: the second one.
Attached patch fixes this." scribu
Needs Milestone 16612 WordPress should return nocache headers for requests with comment cookies General normal normal Awaiting Review enhancement new 2011-02-21T22:45:21Z 2011-11-16T00:51:57Z "Most themes, when displaying the comment form, change the HTML to pre-fill username, email address, and website when comment cookies are received in the HTTP request. Since the response does not have explicit nocache headers, per RFC2616 (http://www.ietf.org/rfc/rfc2616.txt) intermediate caches can use heuristics to determine the cache TTL for the response. Since there is 0 freshness data in the response, it is not really possible to perform good heuristics, but in practice, caches will assign a default TTL to this type of response. The result is that private information input by user A when submitting a comment can be returned to user B when making a request for the same URL.
To protect ourselves against this, we should call nocache_headers() when comment cookies are sent and the comment form is being displayed. Alternatively, we can send nocache headers for all requests with comment cookies regardless of the comment form being displayed or not (probably easier and maybe safer).
http://humboldtherald.wordpress.com/2011/01/27/gremlins/ is a story likely caused by an aggressive cache and the lack of nocache headers." barry
Needs Milestone 18117 get_blog_details is sensitive to path's trailing slash Multisite 3.0 normal normal Awaiting Review defect (bug) new dev-feedback 2011-07-14T20:20:39Z 2011-11-16T01:32:02Z "STR:
1. Create a site, then edit it so that the domain is the main domain and the path is /sub. Note that the admin doesn't turn this into /sub/, nor give an error.
2. Go to /sub/wp-admin. You'll notice it doesn't redirect, but it just gives you the main site's wp-admin. Going to /sub also just gets interpreted as a URL for the main site.
Potential solutions:
1. Make the admin automatically turn the path of /sub into /sub/.
2. Make get_blog_details match modulo trailing slash.
3. (Document carefully in Codex and hope people read it.)" mitchoyoshitaka
Needs Milestone 19069 Admin menu generation doesn't check whether default post types have 'show_ui' as true Administration normal normal Awaiting Review defect (bug) new has-patch 2011-10-27T19:47:06Z 2011-11-16T05:00:27Z While patching #19055, I found wp-admin/menu.php doesn't check whether default post types have 'show_ui' set to true. The Comments menu is also displayed regardless of whether available post types support comments or not. kawauso
Needs Milestone 17261 Ctrl(+shift)+tab don't work when tinyMCE has focus TinyMCE 3.2.1 normal normal Awaiting Review defect (bug) new has-patch 2011-04-27T16:28:14Z 2011-11-16T08:19:40Z "At first I thought this was a DFW bug, but it seems to be tinyMCE related as it affects the regular editor.
If you are focused in tinyMCE ctrl+tab and ctrl+shift+tab don't work as expected (switching you to the next/previous tab).
* In Firefox 4 on Ubuntu:
* ctrl+tab does nothing
* ctrl+shift+tab moves focus to the title box
* In Firefox 4 on Windows 7
* ctrl+tab does nothing
* ctrl+shift+tab moves focus to the title box
* tab and shift+tab do nothing as well (rather than switch focus)
* In IE 9
* Everything works as expected
* In Opera 11.10 on Windows
* The first ctrl+tab or ctrl+shift+tab moves focus and the second switches tabs
* In Safari 5.0.5 on Windws
* ctrl+tab works as expected
* ctrl+shift+tab does nothing
* In Chrome on both Windows and Ubuntu
* Everything works as expected
" aaroncampbell
Needs Milestone 19112 Minor fix in category-template.php Taxonomy 3.2.1 normal normal Awaiting Review defect (bug) new has-patch 2011-11-02T09:26:15Z 2011-11-16T09:36:43Z "In ''wp-includes/category-template.php'' file, WordPress uses the ""'''View all posts in %s'''"" text to show posts under some category (we can see this text in line 59, 174 177, 184, 197, 200 and in line 207).
But in line 837 WordPress uses a different text - '''View all posts filed under %s'''.
This patch is changing that.
" ramiy
Needs Milestone 19256 Ability to mark a comment as spam from the trash Comments 2.9 normal normal Awaiting Review enhancement new 2011-11-16T03:07:48Z 2011-11-16T09:42:58Z "Say you're scrolling through comments in the trash and you realize a comment should have ended up in spam instead.
There's no easy way to untrash then re-spam the comment — you'd lose it and it'd get restored to its previous status. You can't edit it and modify its status from there, either.
I think there should probably be a way to spam a comment from the trash. (For that matter, I don't think there's an issue with being able to edit a trashed comment, too. Perhaps you want to modify it then untrash/approve it.)" nacin
Needs Milestone 19264 Add get_nav_menu_item_children() Menus normal normal Awaiting Review enhancement new has-patch 2011-11-16T19:09:23Z 2011-11-16T19:09:23Z Just as get_page_children() exists, it would be good to have get_nav_menu_item_children(). Since the object is different the code get_page_children() needs to be slightly modified. wpsmith
Needs Milestone 17227 wp should work around bug in move_uploaded_file for tighter security Security 3.2.1 normal normal Awaiting Review feature request new 2011-04-24T00:28:50Z 2011-11-17T18:52:45Z "Andrew Nacin said I should put this in a new ticket so others can weigh in. Here's the email with the description:
Hey guys, so I'm trying to harden up (!) my wordpress installation, and the whole world-writable wp-content/uploads thing is avoidable by creating a group that includes me and apache (call it ""checkersites""), and making wp-content/uploads et al group writable, group checkersites, and the directories group sticky. So, any new directories and files created are group checkersites so I can toast them, even though apache is the owner.
However, there's a bug in php's move_uploaded_file that it doesn't obey the directory group sticky bit, so any files uploaded and run through move_uploaded_file are apache:apache, which then breaks everything with this scheme (meaning, the files still work, but now I can't modify the them without su'ing, etc.). This has been recorded on the php docs for move_uploaded_files since 2008 ([http://www.php.net/manual/en/function.move-uploaded-file.php#85149 note here]), so it looks like they just don't care. I was thinking about patching wordpress to work around this by checking if the destination directory's group sticky bit is set and changing the group to that if so. Would you guys be interested in the patch?
As far as I can tell, this is the only thing that forces non-root users to make directories world writable (or even readable, assuming the admin will set up the shared group for them). Seems like it's worth fixing." chrishecker
Needs Milestone 17847 wp_kses_hair is too stringent Formatting 1.5 normal normal Awaiting Review defect (bug) new has-patch 2011-06-19T21:29:46Z 2011-11-17T20:38:47Z attributes from custom xml name spaces may use colons, but the regex used inside wp_kses_hair doesn't allow them through. jorbin
Needs Milestone 18937 Add admin bar to press this bookmarklet Press This 3.3 normal normal Awaiting Review enhancement new 2011-10-13T22:41:35Z 2011-11-20T16:24:25Z With the admin bar now a permanent addition to the admin backend, I was thinking we should replace the old style header that's currently in the Press This bookmarklet to be the new admin bar. Since the width for the PT window is smaller, we could probably also just reduce the number of items added to it. andrewryno
Needs Milestone 19306 remove_all_filters() should set to array(), not unset Plugins normal normal Awaiting Review enhancement new has-patch 2011-11-20T19:11:49Z 2011-11-21T10:01:56Z "Consider this use case: You want to hook into priority 0 of an action and run remove_all_actions() for all other callbacks.
Since we use current() and next() to iterate, rather than making a copy of $wp_filter to loop through it, this should work.
Unfortunately, current() and next() expect an array, and only stop when next() returns === false. remove_all_filters() does an unset() on $wp_filter[$tag], which means next() returns A) a warning, and B) null. The null causes an indefinite loop.
Test code:
{{{
add_filter( 'test_filter', function() { remove_all_filters( 'test_filter' ); return 0; }, 0 );
add_filter( 'test_filter', function() { return 1; }, 1 );
add_filter( 'test_filter', function() { return 2; }, 2 );
var_dump( apply_filters( 'test_filter', -1 ) );
}}}" nacin
Needs Milestone 18829 Cleanup of postbox_classes Template 3.2.1 normal normal Awaiting Review defect (bug) new has-patch 2011-09-30T19:39:50Z 2011-11-22T15:07:29Z "When using add_meta_box, this patch fixes the extra spaces in the meta box CSS class attribute.
This patch cleans up the '''postbox_classes''' function." logikal16
Needs Milestone 19368 UTF-8 characters truncated mid-byte sequence in excerpt in RSS2 feed Feeds normal normal Awaiting Review defect (bug) new 2011-11-27T05:54:33Z 2011-11-27T15:08:14Z "I received [https://code.google.com/p/feedparser/issues/detail?id=306 a bug report at a project I maintain] and discovered what appears to be a bug in Wordpress 3.2.1.
The trouble is that the `description` element is being truncated in the middle of a UTF-8 multibyte character, which is producing garbage binary data. An example can be found at:
http://www.arnaudmontebourg.fr/?feed=rss2
I downloaded [http://themocracy.com/2009/07/alibi3col-free-wordpress-theme/ the site's theme] but found nothing that would affect `post_excerpt` or `the_excerpt_rss`. I then downloaded Wordpress trunk and attempted to figure out where the problem might be, but I'm unfamiliar with the Wordpress source and couldn't find anything after tracing through multiple files using grep.
I did discover that `trackback_url_list()` in `wp-includes/post.php` appears to be using a simple `substr()` call that might cause problems with multibyte characters. However, I'm more concerned with the potential for malformed feeds.
I've included a copy of the feed XML in question for longevity." kurtmckee
Needs Milestone 18396 "Custom post type of ""tab"" creates query conflict with media uploader." Media 3.0 normal normal Awaiting Review defect (bug) new 2011-08-13T20:12:11Z 2011-11-28T23:00:38Z "1. Create a custom post type with name ""tab""
2. Upload media in (either attached to a post, or not)
3. Return to media uploader and click on ""Library"" tab, no images are pulled
The query being called will check for a post_type of tab with the post_name library, looks like it's due to ""tab=library"" being in the query string. Change the post type or remove the its registration and the problem disappears.
Details: WP 3.0+ (trunk, too), no plugins, TwentyEleven child theme only having a functions.php with the register_post_type function called on init.
I'd love to submit a patch to account for this or it could be listed as a reserved word for custom post types. Looking for direction for next steps. " theandystratton
Needs Milestone 19383 Hide post formats next to post titles if the active blog theme does not support post formats General 3.1 normal normal Awaiting Review defect (bug) new 2011-11-28T18:16:12Z 2011-11-29T18:47:55Z "If I'm using a theme that supports post formats—e.g. Twenty Eleven—then next to each title on `wp-admin/edit.php` I'm able to see not only the title name but also the post format that corresponds to its respective post.
If I switch to a theme that does not support post formats at all I am still able to see post formats associated with their respective posts.
This is not good for a few reasons:
* Showing a post format next to a title while a theme that doesn't support post formats is active is confusing. ""Why does my post have the word Image/Link/Status/Quote by it? What does that mean?""
* There is no way to edit or remove a post format associated with a post when a theme that does not support post formats is active, so the labels are useless.
When a theme that does not support post formats is active those format labels should be hidden. The posts can of course still retain their formats in case a user switches back to a theme that supports theme, but otherwise they should be hidden." philiparthurmoore
Needs Milestone 19392 Add auto-suggest support for all flat taxonomies in Bulk Edit. Quick/Bulk Edit 3.0 normal normal Awaiting Review enhancement new early 2011-11-29T18:37:18Z 2011-11-29T18:58:48Z "Auto-suggest in the Bulk Edit area for post_tag's was fixed in 3.3. Let's add support for all other non-hierarchy tax's in 3.4.
See [http://core.trac.wordpress.org/ticket/19176#comment:11 #19176] for more info." scottbasgaard
Needs Milestone 19308 "C-style hexadecimal is incorrectly ""fixed"" to change the 'x' into a mathematical '×'" Formatting 2.1 normal normal Awaiting Review enhancement new needs-unit-tests 2011-11-21T00:39:00Z 2011-11-30T16:49:55Z "Pretty much what the title says. I'm running trunk. ""0x07"" gets converted to ""0×07"".
I've attached a patch which fixes this issue by not performing the conversion if the first number starts with a zero -- this is not perfect, and I might have a go at something better when it's not 0030, if you guys decide this should be changed.
My $0.02 - since it's a bit odd to multiply zero by something, I don't think that very many people will expect/want this conversion to happen -- and the lack of conversion is unlikely to confuse those that do.
On the other hand, this conversion is confusing for any blog post using this hex notation, and does make those posts actually wrong.
" harrym
Needs Milestone 19286 Users without access to Comments screen can see links to it Post Types 3.0 normal normal Awaiting Review defect (bug) new has-patch 2011-11-18T11:09:17Z 2011-12-02T04:42:09Z "The comments bubble that shows on up next to each post on post listing screens doesn't check for the `edit_posts` capability. This means on post type screens where a user has the `edit_{post_type}` capability but not the `edit_posts` capability, the comment bubble links to the Comments screen which they do not have access to.
We should still show the comment bubble in this case but not link it to the Comments screen.
" johnbillion
Needs Milestone 19443 We can't use WordPress' editor inside a Thickbox erayalakese TinyMCE 3.2.1 normal normal Awaiting Review enhancement new has-patch 2011-12-04T16:45:36Z 2011-12-05T00:09:24Z "At my plugin's admin page, a have a EDIT link like this :
{{{
edit.php?id="">EDIT
}}}
When user click it, it'll open href in a thickbox . Thickbox should contain '''/plugin-name/edit.php?id=1''''s content, for example.
It's working very well. But i want to add WordPress' rich text editor to edit.php . I'll explain my problem with a short video.
http://screenr.com/eoEs
" erayalakese
Needs Milestone 19444 Widgets page stale when pressing the Back button Widgets normal normal Awaiting Review defect (bug) new 2011-12-04T18:14:26Z 2011-12-05T16:54:31Z "For several versions of Wordpress (maybe all of them), I've noticed that the Widgets page can be loaded from cache:
[[Image(http://img51.imageshack.us/img51/725/pictureen.png)]]
I'm not sure why this is happening, when the page is first loaded headers are sent including `no-cache, must revalidate, max-age=0`, all of which seems to be done correctly:
[[Image(http://img703.imageshack.us/img703/4526/screenshotwithshadow.png)]]
However, if I load the widgets page, make a change to the order of the widgets, then navigate to another page, and then use the back arrow to go back to the widgets page, a cached version of the widgets page (pre-change) is loaded. This can be especially troublesome if you spend a lot of time making changes and adding and removing widgets, or widget content, then go back to the page and make another change before you realize that the cached page is loaded, because it will overwrite all the changes that you had just previously spent so much effort on.
One possible solution would be to load all the widgets with AJAX if javascript is available, or possibly re-check that the correct widgets are in place with AJAX after the page loads (and use Javascript to reload the page again if they are not). The latter method would also enable the page to be loaded using standard methods if Javascript was not enabled." willshouse
Needs Milestone 19449 Fix Farbtastic to make it work with empty input fields, too External Libraries 3.3 normal normal Awaiting Review enhancement new dev-feedback 2011-12-05T17:38:08Z 2011-12-05T17:38:08Z "Farbtastic requires that the color input field has either a color value or at least a '#' character. If it's empty it won't work. This seems like an artificial limitation and requires workarounds if the integrated Farbtastic is used for input fields that may be empty, i.e. for theme or plugin options where the color is optional. If the color fields has a default value there's no issue but having empty color fields is a useful and valid use case.
This could be fixed in /wp-admin/js/farbtastic.js, line 192
Old:
if (this.value && this.value != fb.color) {
New:
if (this.value != fb.color) {
Looks like WP is working around this for the 'custom background' for themes (which is empty by default) by adding a hardcoded '#' and saving the background-color without '#'
/wp-includes/theme.php, line 1772:
$style = $color ? ""background-color: #$color;"" : '';
/wp-admin/custom-background.php, line 303:
tags) nohalfpixels Menus 3.2.1 normal normal Awaiting Review enhancement new reporter-feedback 2011-12-10T12:15:35Z 2011-12-10T17:44:37Z "every now and again i find im in the need of the wp_nav_menu function where i only want a list if links, not the outer ul, or the li tags.
there is already scope to remove the outer ul.
but no support for removing the tags from the returned results.
at present i have to do this:
{{{
$foot_nav = wp_nav_menu( array( 'container' => '', 'echo' => '0', 'theme_location' => 'footer_menu' ) );
$foot_nav2 = preg_replace( array( '#^]*>#', '#$#' ), '', $foot_nav );
$foot_nav2 = preg_replace( array( '#]*>#', '# $#' ), '', $foot_nav2 );
echo $foot_nav2;
}}}
this isnt very clean, it would be nice to just be able to pass a parameter the wp_nav_menu function which just returns the links.
i propose something like:
{{{
'return_links' => true,
}}}
the main reason for this is styling centered links in the footer.
its much easier to just center links than it is to center a and results in much cleaner html with less dom elements." nohalfpixels
Needs Milestone 19514 Add Per Page Filter for Nav Menu Post Type Meta Box General normal normal Awaiting Review enhancement new has-patch 2011-12-12T15:40:53Z 2011-12-12T15:40:53Z Currently, there is a default (50) for paginating Post Type Entries on the wp_nav_menu_item_post_type_meta_box(). While there are other ways to filter this, it would be great for larger sites or larger number of post objects to be able to increase this for UX reasons. wpsmith
Needs Milestone 19525 Meta Query failing to build a proper SQL Query Query 3.1 normal normal Awaiting Review enhancement reopened dev-feedback 2011-12-13T01:23:23Z 2011-12-13T03:27:59Z "
I was tryin' to get meta working and i was wondering why no results were returned until i found that the query is actually invalid:
{{{
SELECT SQL_CALC_FOUND_ROWS *
FROM posts INNER JOIN term_relationships ON (ID = term_relationships.object_id) INNER JOIN postmeta ON (ID = postmeta.post_id)
WHERE 1=1 AND ( term_relationships.term_taxonomy_id IN (1) ) AND post_type = 'post' AND (post_status = 'publish') AND ( (postmeta.meta_key = 'time' AND ) GROUP BY ID ORDER BY post_date DESC LIMIT 0, 10
}}}
As you can see the meta query only inputs the meta_key and not the meta value/compare operator and as such the query ends up invalid.
This is how the query is getting called:
{{{
$args = array(
'category_name' => 'customcat',
'post_status' => 'publish',
'meta_key' => 'time',
'meta_value' => '135784684',
'meta_type' => 'numeric',
'meta_compare' => 'NOT BETWEEN'
);
$posts = new WP_Query($args);
}}}
" peshkohacka
Needs Milestone 19556 Make wp_term_checklist() available as a template tag Template normal normal Awaiting Review enhancement new 2011-12-14T22:58:07Z 2011-12-14T23:13:05Z "Currently, wp_term_checklist() is defined in wp-admin/includes/template.php, which means it's not available as a template tag for themes.
Note that {{{wp_dropdown_categories()}}} is defined in {{{wp-includes/category-template.php}}}. We should move wp_term_checklist() there too." scribu
Needs Milestone 19561 Allow a background colour to be set for custom headers Themes 3.3 normal normal Awaiting Review feature request new 2011-12-15T09:11:04Z 2011-12-15T09:11:04Z "Currently WordPress allows you to set a custom image background for the header and a custom text color but doesn't give the users a way to set a custom ''background color'' for the header.
Adding a simple color picker for the header background would give users a lot more flexibility in what they can do with the header without using external software to create graphics etc. Perhaps needs a way to activate it from the themes functions.php (suggest ''add_custom_header_color''?)" hellweaver666
Needs Milestone 19564 Helper function for getting/setting cache data Cache 3.3 normal normal Awaiting Review enhancement new has-patch 2011-12-15T15:02:09Z 2011-12-15T16:00:55Z "Most of the time when we want something from the object cache we go through a routine of: wp_cache_get(); checking a result; setting a default; setting the cache with wp_cache_set(); returning. Core should offer a neat way to do this all in one fell-swoop.
Attached patch is a proposed solution." johnjamesjacoby
Needs Milestone 15838 get_home_path() mixes PHP and server paths General 3.0.3 normal normal Awaiting Review defect (bug) new has-patch 2010-12-15T23:40:27Z 2011-12-16T03:15:52Z "FYI: I've looked through the other get_home_path() tickets and believe this to be a different issue.
If the home and site urls are the same then you get a '''PHP relative''' path returned. i.e. it uses {{{ ABSPATH }}}, which is calculated using the PHP constant {{{__FILE__}}}
.
If the home and site urls are different you get a '''server relative''' path returned. i.e. one calculated via
{{{$_SERVER[""SCRIPT_FILENAME""] }}}.
With web hosts who have the server and PHP paths configured consistently this is no problem.
But on 1and1 it could be if you are comparing the return value of this function against another path. If the function can either return a PHP or a server path then your code may not always work.
The server path (Apache) on 1and1 has an extra '/kunden' at the start. This means that PHP and Apache retrieve paths slightly differently.
Example.
Blog with same home and site urls
{{{
get_home_path = /homepages/xx/dxxxxxxxx/htdocs/site1
}}}
Blog with different home and site urls
{{{
get_home_path = /kunden/homepages/xx/dxxxxxxxx/htdocs/site1
}}}
I'd suggest that as this is PHP the right thing to do is to always calculate the path using PHP relative paths - i.e. using
{{{ __FILE__ }}} / {{{ ABSPATH }}} . Don't use the server relative paths at all as you can't rely on them being the same as the PHP ones.
Certainly having a function returning a path that can be calculated from two different base paths is a bad idea.
For reference here's the current function:
{{{
function get_home_path() {
$home = get_option( 'home' );
$siteurl = get_option( 'siteurl' );
if ( $home != '' && $home != $siteurl ) {
$wp_path_rel_to_home = str_replace($home, '', $siteurl); /* $siteurl - $home */
$pos = strpos($_SERVER[""SCRIPT_FILENAME""], $wp_path_rel_to_home);
$home_path = substr($_SERVER[""SCRIPT_FILENAME""], 0, $pos);
$home_path = trailingslashit( $home_path );
} else {
$home_path = ABSPATH;
}
return $home_path;
}
}}}
" reviewmylife
Needs Milestone 19581 wp_list_comments_args hook Template 3.3 normal normal Awaiting Review enhancement new has-patch 2011-12-16T21:11:12Z 2011-12-17T06:15:12Z "`wp_list_comments` needs a hook on its arguments. This will make it easier to change with child themes as opposed to overwriting the entire `comments.php` template.
Attached patch adds a new hook: `wp_list_comments_args`." greenshady
Needs Milestone 16914 Updated List of HTTP status codes for wp_header_to_desc (2) General 3.1 normal normal Awaiting Review enhancement new has-patch 2011-03-21T12:54:46Z 2011-12-18T20:03:45Z "http://www.iana.org/assignments/http-status-codes
Hypertext Transfer Protocol (HTTP) Status Code Registry
(last updated 2010-11-05)
Related: #9297" hakre
Needs Milestone 16477 """View post"" link should not change when sample permalink changes" Editor 3.0 normal normal Awaiting Review defect (bug) new dev-feedback 2011-02-07T08:15:26Z 2011-12-18T23:54:38Z "To reproduce:
- Go to edit a post
- Change the permalink
- Click on ""View post"" and you get a 404 because the href has been changed to the new sample permalink but the post hasn't been updated yet
The ""View post"" link should always point to the permalink of the currently saved post." solarissmoke
Needs Milestone 16935 Wrap selected text in in press-this.php Press This 3.1 normal normal Awaiting Review feature request new dev-feedback 2011-03-22T16:27:37Z 2011-12-19T00:50:04Z "When using the ""Press This"" bookmarklet, any text selected on the current page is inserted into the post body textarea. This should be wrapped in a tag with some appropriate class name." topdownjimmy
Needs Milestone 11950 Sticky Posts are too aggressive Query 2.9.1 normal normal Awaiting Review enhancement reopened dev-feedback 2010-01-19T15:43:50Z 2011-12-19T03:19:07Z "I don't think the default behavior should be to have sticky posts included every time a query_posts() is used. I realize you can set the 'caller_get_posts' argument to avoid sticky posts from being added, however having to do this everywhere becomes a burden.
What are your thoughts on having the WP class add 'include_sticky' var to the_query if it isn't already set and then not include the sticky posts by default?" prettyboymp
Needs Milestone 19374 Uploader uses wrong path when inserting images Upload normal normal Awaiting Review defect (bug) new has-patch 2011-11-27T23:09:36Z 2011-12-19T19:55:20Z "== Issue: ==
I recently had someone whose WordPress install I take care of tell me that when they went to upload images, they weren't being shown. At the time, she was using a svn copy that hadn't been svn up'd in a few weeks. I noticed that the uploads were being stored in the right location, but the uploader was using the default `wp-content/uploads` location when it inserted it into the post, causing the images to not show up.
I just confirmed that this still exists in r19456. It happens with all plugins deactivated and on the default theme.
== To replicate: ==
1. On the options-media.php, change the upload path to something of your choosing. For mine, I chose `/usr/home/user/domains/my-domain.com/public_html/wp-content/my-uploads/`
2. If needed, created the folder and adjust permissions.
3. Create a new page/post, upload an image, and insert it into the post. Take note of the address, it should be wrong according to the newly set upload path.
4. On the server, check the new location, as well as wp-content/uploads. The file will be in the new location (as expected), and not in wp-content/uploads." ryanmurphy
Needs Milestone 19615 Deprecate get_currentuserinfo() Users normal normal Awaiting Review enhancement new has-patch 2011-12-19T20:23:28Z 2011-12-20T18:49:45Z "{{{get_currentuserinfo()}}} is a pluggable function that encourages an ugly pattern in theme files:
{{{
global $userdata;
get_currentuserinfo();
}}}
It can easily be replaced with this:
{{{
$current_user = wp_get_current_user();
}}}" scribu
Needs Milestone 18953 "String index handling mistake in TinyMCE's JSON.php causes a PHP ""Notice"" message" azaozz TinyMCE 3.2.1 normal normal Awaiting Review defect (bug) reviewing has-patch 2011-10-14T21:42:55Z 2011-12-20T20:20:22Z "In the SpellChecker plugin for TinyMCE with a PHP backend, in file JSON.php, in lines 332 (""read"" function) and 350 (""peek"" function), the $this->_data string index ($this->_pos) is compared with $this->_data string length ($this->_len). These allow errors in lines 339 and 351 of their respective functions, when the $this->_pos index gets to be equal to the length of the string. This situation generates the following messages to show up in PHP servers configured to show notice-level debug information:
Notice: Uninitialized string offset: in /wp-includes/js/tinymce/plugins/spellchecker/classes/utils/JSON.php on line 351
Notice: Uninitialized string offset: in /wp-includes/js/tinymce/plugins/spellchecker/classes/utils/JSON.php on line 339
I will attach a patch file to illustrate how I solved this situation." carlosman
Needs Milestone 19512 wp_read_image_metadata includes bitmap in description Media 3.3 normal normal Awaiting Review defect (bug) new has-patch 2011-12-12T13:47:40Z 2011-12-20T20:51:17Z "After uploading a photo that includes (photoshop) bitmaps in the image data, the bitmap data is copied into the image description.
" macbrink
Needs Milestone 19641 Some problems with updating plugins by uploading zip archive Plugins 3.2.1 normal normal Awaiting Review enhancement new 2011-12-21T20:55:20Z 2011-12-21T22:06:07Z "I found several UX problems with updating (re-installing) plugins by uploading zip archive.
1) I installed small plugin (outside official WordPress plugins directory) foo.php (zipped in foo.zip) by uploading zip archive. Then I wanted to install updated version (also foo.php in foo.zip). But new folder foo1 with file foo.php was created, so my plugin is duplicated in WP plugins directory. It is not expected behaviour for users, I guess...
2) When foo.php is in foo folder and together zipped (foo/foo.php in foo.zip), then it is not possible to update (re-install) this plugin (directory already exists) by uploading zip archive. So, for plugins outside WordPress plugins directory (or with nonfunctioning automatic updates) it is problem, because there is no way to update plugins by uploading zip file (only manually through FTP). Another possibility is deactivate and delete plugin first, but some plugins use hooks to delete all plugins data when they are deleted through administration.
3) I automatically installed plugin (inside WordPress plugins directory) which is in folder foo. I changed several files and wanted to re-install plugin with the same (original) version from plugins repository. I did not find a way to do it from admin (I did not want to run FTP manager). When there is possibility for re-installing core, then it could be possible also for plugins, I guess...
4) Another problem was with installing plugins beta versions, but there is Plugin Beta Tester plugin available (but old).
http://wordpress.org/extend/plugins/plugin-beta-tester/" pavelevap
Needs Milestone 19639 "Enhancement: request: filter support before shortcodes are parsed or convert " into """ Shortcodes 3.3 normal normal Awaiting Review defect (bug) new 2011-12-21T17:01:41Z 2011-12-22T00:39:34Z "My team uses Windows Live Writer to do all posting, but we constantly have trouble using shortcodes because WLW, being as awesome as it is in other aspects, keeps converting the double quotes in shortcodes to
{{{
"
}}}
This breaks shortcode attributes, and while we're working around it using single quotes, we can't use shortcode attribute data that contains single quotes then.
So, is there a good fix for this?
One workaround would be to have a filter that runs before shortcodes are parsed that converts " back to "". However, in the shortcode API, I found no filters in use at all, so that's out without modifying WP source.
Alternatively, the API could just pre-process the data and take care of this case, which should be solved in WP core yet again.
Is there some way to resolve this without the above modifications to core?
Thanks." archon810
Needs Milestone 19455 "The ""magic_quotes_sybase"" Problem" 夏天 General 3.2.1 normal normal Awaiting Review defect (bug) new has-patch 2011-12-06T10:13:21Z 2011-12-22T19:47:01Z "
Post A Post, titled (in the double quote) : `""Charlie's little cat""`
It will become (in the double quote) : `""Charlie''s little cat""`
Notice that, single quote become double quotes!!
YES , My 'magic_quotes_gpc' and 'magic_quotes_sybase' are enabled!
Here is The PHP.NET links: http://php.net/manual/en/security.magicquotes.disabling.php" summerblue
Needs Milestone 19419 wp-admin/media.php: allow to add a default src External Libraries 3.2.1 normal normal Awaiting Review enhancement new 2011-12-02T21:15:34Z 2011-12-22T23:01:36Z "something like
in file wp-admin/media.php :
function type_url_form_image($image_url) {
.
.
.
'`
`'after_sidebar' => '
'`
or
`'before_sidebar' => ''`
`'after_sidebar' => '
'`
If this feature is considered then I'm not sure whether 'before_sidebar' or 'before_widget_area' is a better choice for the attribute name." dgwyer
Needs Milestone 18166 Be able to amend the parent dropdown on the edit taxonomy term page Taxonomy 3.2.1 normal normal Awaiting Review enhancement new has-patch 2011-07-18T22:15:56Z 2012-01-02T22:23:23Z "It would be useful to filter the parent dropdown on the edit taxonomy term page (/wp-admin/edit-tags.php?taxonomy=foo&post_type=bar).
See attached patch (The filter probably needs a better name, but you get the point)." leewillis77
Needs Milestone 19719 PHPMailer allows invalid characters in display-name westi External Libraries normal normal Awaiting Review enhancement new has-patch 2012-01-03T16:06:27Z 2012-01-03T16:06:27Z "[http://tools.ietf.org/html/rfc5322 RFC5322] defines the display name portion of an email address as follows:
{{{
display-name => phrase
phrase => word / obs-phrase
obs-phrase => word / whitespace / dot
word => atom / quoted strings
atom => whitespace / atext
atext =>
ALPHA / DIGIT / ; Printable US-ASCII
""!"" / ""#"" / ; characters not including
""$"" / ""%"" / ; specials. Used for atoms.
""&"" / ""'"" /
""*"" / ""+"" /
""-"" / ""/"" /
""="" / ""?"" /
""^"" / ""_"" /
""`"" / ""{"" /
""|"" / ""}"" /
""~""
}}}
So, the display-name can contain the list of characters defined as atext plus dots plus whitespace plus quoted stringss.
Notable exclusions include things like >, <, ( and ). At present, PHPMailer does no validation of the display-name field. The attached patch adds validation that does the following:
* Make sure we decode any utf8 characters
* Compare the original value against a value with invalid characters stripped out
* Fail validation if the original and the stripped version do not match (ie, we stripped something invalid, so the string must have been invalid)
The patch does not handle assuring proper pairing of quoted strings (it doesn't validate that quotes nest properly or occur only in pairs).
The following code works for testing the patch:
{{{
AddAddress( $to_address, $to_name );
$phpmailer->SetFrom( $from_address, $from_name );
$phpmailer->Subject = $subject;
$phpmailer->Body = $body;
$phpmailer->Send();
} catch ( phpmailerException $e ) {
print_r( $e->getMessage() );
}
}}}
To provoke an error, add a disallowed character such as > or ) to one of the _name variables. The code will bail with an invalid_display_name exception." dllh
Needs Milestone 19686 404 - File or directory not found Multisite 3.3 normal normal Awaiting Review defect (bug) new dev-feedback 2011-12-29T19:47:45Z 2012-01-03T21:38:51Z "We are running Wordpress using multiuser with Buddypress. Users are getting the 404 error after they click the save button in their settings.
I'm opening this ticket to report the source of the problem.
Wordpress 3.x
Buddypress 1.5
Windows 2008 R2 (IIS 7.5)
Themes installed are all Buddypress compatible and all themes seem to be affected.
All option pages are affected.
Settings are updated when the user returns to the page - despite the error. A screen shot of the error can be seen at http://blogs.cnc.bc.ca/gagel/?attachment_id=38
The source of the problem appears to be in the wp_get_referer() function on line 164 in options.php. With the variables passed to the function it should redirect the user to the page they just submitted when they updated options. Instead they get the 404 error.
The page they're redirected to appears to be the absolute path of the submitted page appended to the absolute path again (minus the domain). So it looks like this:
userblog/wp-admin/userblog/wp-admin/options-general.php?settings-updated=true
When I switch out the wp_get_referrer() function with the variable $parent_page then the redirect worked as expected.
I'm uncertain about leaving it like this as my change may have introduced issues elsewhere...
This issue is discussed at http://wordpress.org/support/topic/recuring-404-file-or-directory-not-found-error?replies=8#post-2527566" kwgagel
Needs Milestone 19705 better taxonomy query URL syntax Query 3.3 normal normal Awaiting Review enhancement new has-patch 2012-01-01T00:30:36Z 2012-01-04T00:45:56Z "Problem: WP's native taxonomy URL syntax supports logical OR/IN and AND operations, but not NOT IN. Blog post with more rambling: http://maisonbisson.com/blog/post/16074/better-taxonomy-query-syntax/ .
Solution: the attached patch extends the URL syntax to support these logical operators.
- Taxonomy terms are separated by commas (it preserves support for the old +separated syntax).
- Terms prepended with a + are required (AND)
- Terms prepended with a - are excluded (NOT IN)
- All other terms are simply IN
Examples:
- http://site.org/tag/term-one,term-two/ : posts containing one or more of the named terms
- http://site.org/tag/+term-one,+term-two/ : posts containing both of the named terms
- http://site.org/tag/term-one,-term-two/ : posts containing term-one, but excluding term-two
Working examples (at least until I revert my site):
- http://maisonbisson.com/blog/post/tag/wordpress,+mysql/ : IN and AND syntax (it's an accident of how the query is handled internally that it doesn't require a + to be AND'd in this case)
- http://maisonbisson.com/blog/post/tag/wordpress+mysql/ : old-style AND syntax
- http://maisonbisson.com/blog/post/tag/wordpress,mysql/ : IN syntax
- http://maisonbisson.com/blog/post/tag/wordpress,-mysql/ : NOT IN syntax for the second term
- http://maisonbisson.com/blog/post/tag/-wordpress,+mysql/ : NOT IN the first term, AND the second term
About the patch:
The patch disables the special handling of tags. This is just to narrow the scope of work necessary to demonstrate a working patch." misterbisson
Needs Milestone 12538 WP should cache menus ryan Menus 3.0 normal normal Awaiting Review defect (bug) reopened 2010-03-07T02:10:10Z 2012-01-04T17:34:26Z "There's a prime example of how to do this in the menu ticket (i.e. the plugin I attached in #11817).
Shouldn't we be doing this in WP as well?
It basically goes:
- if it's a page, then try a post meta
- if it's search/404 request, then try a transient
- if it's anything else, then try a transient
The plugin also handles conditional flushing of the cache based on whether or not the permalink and/or the label changed." Denis-de-Bernardy
Needs Milestone 18998 date/time handling in xml-rpc assumes GMT value XML-RPC 3.2.1 normal normal Awaiting Review defect (bug) new 2011-10-19T08:09:16Z 2012-01-04T17:43:57Z "When trying to set post publication times via XML-RPC I noticed that the dateCreated value was assumed to be GMT.
one section of code:
{{{
// Do some timestamp voodoo
if ( !empty( $content_struct['date_created_gmt'] ) )
$dateCreated = str_replace( 'Z', '', $content_struct['date_created_gmt']->getIso() ) . 'Z'; // We know this is supposed to be GMT, so we're going to slap that Z on there by force
elseif ( !empty( $content_struct['dateCreated']) )
$dateCreated = $content_struct['dateCreated']->getIso();
if ( !empty( $dateCreated ) ) {
$post_date = get_date_from_gmt(iso8601_to_datetime($dateCreated));
$post_date_gmt = iso8601_to_datetime($dateCreated, 'GMT');
} else {
$post_date = current_time('mysql');
$post_date_gmt = current_time('mysql', 1);
}
}}}
in the following part:
{{{
if ( !empty( $dateCreated ) ) {
$post_date = get_date_from_gmt(iso8601_to_datetime($dateCreated));
$post_date_gmt = iso8601_to_datetime($dateCreated, 'GMT');
} else {
}}}
$post_date is set to GMT (get_date_from_gmt()) value of $dateCreated (assuming it's GMT)
and then $post_date_gmt is set to GMT ...
this forces both values to be identical and assumed to be GMT. this also breaks the ability to set the timezone in the value of dateCreated even though the ISO8061 spec allows it.
I've attached a patch to class-wp-xmlrpc-server.php which appears to fix this problem and allows future published posts to publish properly at the expected date/time.
to duplicate, use an XML-RPC client (I'm using a Perl script) to add a new post and set the dateCreated to a dateTime.iso8061 entity with the value of '20111019T19:05:00+0900' (or something equivlent for your timezone which would be easy to identify as an incorrect value if so.) the publish date of the new post will be the GMT value.
A workaround would be to do all the GMT conversion in the client prior to sending via XML-RPC, but that would make it seem that dateCreated and date_created_gmt will always be duplicate. I've included a patch in case this wasn't an intentional design decision.
" alien8
Needs Milestone 18798 Sanitizing post in get_attachment_fields_to_edit() can cause double encoding under certain circumstances Media 2.5 normal normal Awaiting Review defect (bug) new has-patch 2011-09-27T23:33:09Z 2012-01-05T14:27:44Z "In get_attachment_fields_to_edit, the $post object is sanitized using the 'edit' flag, which converts HTML entities. Under some circumstances this can cause entities to be double-encoded (as in, "), because the html entities are already
To fix this, sanitize the post using the 'raw' flag." wpdavis
Needs Milestone 19739 Filter to override exit for comments on drafts (comment_on_draft) Comments 3.3 normal normal Awaiting Review enhancement new dev-feedback 2012-01-04T19:01:18Z 2012-01-05T18:45:37Z "I'd like to use comments on draft posts as part of an editorial workflow. Will this be as easy as adding a filter to fire before the current comment_on_draft action that can be checked before exiting? I'll try that and add a patch if it looks good.
Related #13276. Not relevant to #18630, I think." cyberhobo
Needs Milestone 18947 get_intermediate_image_sizes() should also contain width/height/crop values as sub array Media 3.2.1 normal normal Awaiting Review enhancement assigned dev-feedback 2011-10-14T14:48:05Z 2012-01-06T16:22:03Z "Currently the function [http://core.trac.wordpress.org/browser/branches/3.2/wp-includes/media.php#L580 get_intermediate_image_sizes()] only displays a combined list of built-in/default & (via {{{add_image_size()}}}) registered image size ''names''. In lot's of cases it would be pretty handy to also have the height, width & crop values attached as sub array as you can see it in {{{$GLOBALS['_wp_additional_image_sizes']}}}.
''I currently do not have a working dev version of wp installed, so I put it here as plain code:''
Change for [http://core.trac.wordpress.org/browser/branches/3.2/wp-includes/media.php#L580 get_intermediate_image_sizes()]:
{{{
function get_intermediate_image_sizes() {
global $_wp_additional_image_sizes;
$image_sizes = array('thumbnail', 'medium', 'large'); // Standard sizes
foreach ( $image_sizes as $size ) {
$image_sizes[ $size ]['width'] = intval( get_option( ""{$size}_size_w"") );
$image_sizes[ $size ]['height'] = intval( get_option( ""{$size}_size_h"") );
// Crop false per default if not set
$image_sizes[ $size ]['crop'] = get_option( ""{$size}_crop"" ) ? get_option( ""{$size}_crop"" ) : false;
}
if ( isset( $_wp_additional_image_sizes ) && count( $_wp_additional_image_sizes ) )
$image_sizes = array_merge( $image_sizes, $_wp_additional_image_sizes );
return apply_filters( 'intermediate_image_sizes', $image_sizes );
}
}}}
The only two other affected lines in core are pretty a simple fix: Use the {{{array_keys()}}} only:
[http://core.trac.wordpress.org/browser/branches/3.2/wp-admin/includes/image.php#L106 wp_generate_attachment_metadata()]
and
[http://core.trac.wordpress.org/browser/branches/3.2/wp-includes/post.php#L3824 wp_delete_attachment()]:
{{{
foreach ( array_keys( get_intermediate_image_sizes() ) as $s ) {
}}}
I'm not really shure how the {{{crop}}} works, so this could maybe add additional DB calls if the option wasn't set - currently I only see {{{thumbnail_crop}}} added to the autoloaded options.
''The links are to the 3.2 branch of the repo.''" F J Kaiser
Needs Milestone 19688 Using pathinfo permalinks in a subdirectory causes some 404's Permalinks 3.3 normal normal Awaiting Review defect (bug) new 2011-12-29T20:09:10Z 2012-01-06T21:45:59Z "Due to circumstances beyond my control, I have a Wordpress site that must be installed to a subfolder named ""s"". I also must use pathinfo type permalinks - thus a page with a slug of store-locator would have the url /s/index.php/store-locator. Unfortunately this results in a 404, but other pages on the site work properly.
I tracked this down, and what I found is that code in class_wp->parse_request is causing this - particularly the code starting around line 166ish in version 3.3. The lines in particular that mess things up are these three:
{{{
$pathinfo = trim($pathinfo, '/');
$pathinfo = preg_replace(""|^$home_path|"", '', $pathinfo);
$pathinfo = trim($pathinfo, '/');
}}}
Coming into these lines of code, $pathinfo is /store-locator/, but after those three lines of code $pathinfo is tore-locator (the leading s is missing). This is because $home_path comes from home_url() which strips trailing slashes. The code right before this block further strips $home_path down to just the subdirectory portion, which in my case is just ""s"". Then the preg_replace fires and the leading s on the path is lost.
Temporarily, I added the following line before the three lines above and my problems went away:
{{{
$home_path .= ""/"";
}}}
Obviously this only works in my particular situation, and I'd like to be able to run vanilla Wordpress, but I can't find any combination of settings that will preserve my required permalink structure and still work. If there's a configuration combination that I'm missing, I'd be very happy, otherwise, feel free to contact me if you would like more info or if I can help in any way." mose9634
Needs Milestone 19765 site-users.php in network admin doesn't display users with custom roles Network Admin normal normal Awaiting Review defect (bug) new has-patch 2012-01-06T18:04:20Z 2012-01-07T14:03:30Z In the network admin when looking at the users of a specific site, if the site has a custom role the users with that role will not show up. The patch attached ensures that switch_to_blog() is used at the correct places so that data is being gathered from the correct site, not from the main site. wpdavis
Needs Milestone 19728 WP_Query should constrict 'paged' to be within bounds of found_posts Query normal normal Awaiting Review enhancement new 2012-01-03T20:16:45Z 2012-01-07T23:12:37Z "I apologize in advanced if this has been reported before. My Trac search did not find anything pressingly relevant.
WP_Query allows the user to pass in a discrete value to use for the 'paged' parameter; however, often times this value will be dynamic rather than static (as in the programmer will have paged be the value of $_GET[ 'paged' ] or something similar).
The problem is, if you enter an absurdly large or small value for the paged parameter and it's out of bounds, it will just throw a 404 (or otherwise show that there are no posts matching the parameters). I propose that WP_Query automatically changes the paged value to be within the bounds of the returned number of pages.
For example, constrict paged to the following rules:
1 <= $paged <= $wp_query->max_num_pages (where $wp_query is whatever custom query is being used). If the user types in a page larger than the max, it uses the max instead. Conversely, if they type a page less than 1, it uses 1.
The only potential problem I see with this is if a user actually (for whatever reason) wanted a 404 to display when an invalid page was visisted. In this case, perhaps we can introduce a new option to WP_Query such as 'limit_to_bounds' => true?" Master Jake
Needs Milestone 19776 wp_dropdown_categories (using with taxonomy) defaults if no terms Template normal normal Awaiting Review defect (bug) new has-patch 2012-01-08T04:02:14Z 2012-01-08T21:47:30Z "the default args for wp_dropdown_categories produce an empty select box when using wp_dropdown_categories for a taxonomy for which there are no terms. I produced this both w/ the filters on the edit.php screen (restrict_manage_posts) and on the front end in my theme. I presume this case never occurs with post categories as there is always Uncategorized.
{{{
$args = array(
'show_option_none' => ,
'taxonomy' => 'featured',
'hide_if_empty' => false );
}}}
lines 340-343 in wp-includes/category-template.php are
{{{
if ( ! $r['hide_if_empty'] || ! empty($categories) )
$output = ""\n"";
else
$output = '';
}}}
so in a taxonomy that has no terms, the $categories variable is indeed empty, but the default arg is false, so the ! $r['hide_if_empty'] condition is satisfied and you get the opening of the select input, but you don't get any options therein (since they don't exist. and by default, you don't get any notice of such. " helgatheviking
Needs Milestone 19783 "Add a ""Processing..."" overlay to update iframes" Upgrade/Install normal normal Awaiting Review enhancement new 2012-01-09T04:42:06Z 2012-01-09T04:47:46Z "On the back of #19781, i thought i'd raise this:
> We should also investigate a iframe overlay that contains a ""Working.. please wait"" graphic that clears once the content of the iframe starts loading, This should help ease the pain of not being sure if the update process has started on servers that force gzip (and as a result, provide no user feedback until the process is complete) - See #18525 and #18239 for examlples of that
Fast partial build updates don't experience this problem, but branch-to-branch updates can take awhile on some hosts, it'd be a nicer user experience for those users affected by the above." dd32
Needs Milestone 19802 Allow DECIMAL Precision in WP_Query Meta Queries Query 3.3.1 normal normal Awaiting Review enhancement new dev-feedback 2012-01-11T06:50:05Z 2012-01-11T11:42:34Z "As of now, if we specify a precision for the DECIMAL type in WP_Query meta queries [e.g. DECIMAL(4,2)], the type is changed to CHAR. This transformation seems to happen here:
http://core.trac.wordpress.org/browser/tags/3.3.1/wp-includes/meta.php#L716
As a work around, we can add a filter to the `get_meta_sql` hook and manually change DECIMAL to DECIMAL(X,X) with a `str_replace`, but that seems pretty clumsy and it forces us to pick one level of precision for all meta queries.
As a solution, right above the line I have linked above, we could add a conditional that checks if the type starts with DECIMAL, and then uses a regex to check if the format for the precision is correct. Of course, another option would be to add a precision key to the meta query array like so:
{{{
array(
'key' => 'meta_key',
'value' => $value,
'type' => 'DECIMAL',
'compare' => '>',
'precision' => array( 4, 2 )
),
}}}
I apologize if this question has already been asked, or if I'm missing something obvious. But, to me it seems like the current system is a bit limiting. Thanks." dominicp
Needs Milestone 19805 Pingback not sent to https sites Pings/Trackbacks 3.3.1 normal normal Awaiting Review defect (bug) new has-patch 2012-01-11T16:02:45Z 2012-01-11T16:20:42Z "Wordpress does not attempt to send pingbacks to https sites. I have tracked this problem to the regular expression used to find links to ping inside a post that is being published. The regular expression currently will only filter out links to http sites and not https sites. I have modified the regular expression to include https sites and included a patch with this ticket.
how to reproduce the problem:
* enable sending and receiving of pings/trackbacks on your site
* create a post with with a link to an https site
* publish the post
* no ping will be sent to the https site" norocketsurgeon
Needs Milestone 19806 do_allowed_shortcodes to allow processing of limited list of shortcodes beezeee General normal normal Awaiting Review enhancement new has-patch 2012-01-11T16:09:56Z 2012-01-11T22:22:52Z "We have a front facing content editor and want to enable our users to use a specific set of shortcodes, without exposing all of the sites shortcodes to them.
Here's the function we use for this. It is passed an array of allowed shortcodes, and any other shortcodes are stripped from the content.
{{{
function do_allowed_shortcodes($content, $shortcodes=array())
{
//if no allowed shortcodes are provided, strip all shortcodes and return content
if (empty($shortcodes))
{
return(strip_shortcodes($content));
}
//foreach allowed shortcode provided, build the necessary regex to temporarily change [shortcode] to {shortcode} and then back
foreach ($shortcodes as $shortcode)
{
$allowed_matches[] = '/\[('.$shortcode.'[^\]]*)\]/';
$restore_allowed_matches[] = '/\{('.$shortcode.'[^\}]*)\}/';
}
//change safe shortcodes from [shortcode] to {shortcode}
$safe_content = preg_replace($allowed_matches, '{$1}', $content);
//strip remaining [shortcodes]
strip_shortcodes($safe_content);
//change {shortcodes} back to [shortcodes] and return result of do_shortcode() on that content
$trimmed_content = preg_replace($restore_allowed_matches, '[$1]', $safe_content);
return do_shortcode($trimmed_content);
}
}}}
Seems like this would be a nice addition to core functionality." beezeee
Needs Milestone 16734 Allowing multiple selection when using wp_dropdown_categories General 3.1 normal normal Awaiting Review enhancement new dev-feedback 2011-03-02T22:58:25Z 2012-01-11T23:40:00Z "I would like to be able to pass an argument to wp_dropdown_categories() to allow the user to select more than one category using a CTRL-CLICK. I can use a preg_replace to add the multiple tag to the html select tag, but I cannot pass multiple selections in the ""selected"" argument.
I modified two files (wp-includes/category-template.php and wp-admin/css/wp-admin.css) to add this option and will include patches for these files. It adds a boolean argument for ""multiple"" to wp_dropdown_categories and uses in_array to check if terms are listed in an array in the ""selected"" argument, casting it as an array if it is not. I have tested this patch to work in the latest trunk (3.1).
The change in the w-admin.css is so the multiple selection box is tall enough to show the slider and more than one category." grandslambert
Needs Milestone 19813 Keyboard shortcuts for editing posted date Date/Time 3.3.1 normal normal Awaiting Review enhancement new 2012-01-12T09:28:13Z 2012-01-12T17:39:31Z "In short, I thought it would be a nice feature to be able to use the Up/Down arrow keys to increment or decrement the values within the post published date/time input boxes. I found this stackoverflow post with the basics of how to retrieve keystrokes and alter the value based on which one was pressed.
http://stackoverflow.com/questions/7742364/incrementing-value-integer-in-an-input-type-field.
I then altered the code to prevent negative numbers and stay within the limits of each field type.
Days get 1-31
Year gets 1900+
Hours get 0-23
Minutes get 0-59
JS could probably be cleaned up a bit and condensed, but I wasn't quite sure how to separate them all out. Maybe someone with more js-fu can help out with that" tw2113
Needs Milestone 19588 "Move to Trash results in a page with a ""0""" General 3.3 normal normal Awaiting Review defect (bug) new reporter-feedback 2011-12-17T15:41:04Z 2012-01-13T06:24:36Z In the latest wordpress, if I delete a draft either the bulk delete , or individual move to trash, it loads a page with a zero. If I publish the draft, then move to trash, it works. I searched open tickets and could not find anything specific on this flow. astriker
Needs Milestone 19397 Missing hide-if-js class on gallery items Media normal normal Awaiting Review enhancement new 2011-11-29T22:48:30Z 2012-01-15T22:26:14Z "When you open the gallery tab in the media thickbox, next to each attachment item you have an input in which you can enter an order.
The thing is that thse attachments can be ordered via drag-and-drop, so there's no need to show the inputs to users that have JavaScript enabled.
Not to mention that the order column header is way off." scribu
Needs Milestone 19825 Bugs and modifications to localize script General normal normal Awaiting Review enhancement new 2012-01-13T16:47:55Z 2012-01-18T20:00:08Z "After working in trunk, I noted that I get a fatal error when trying to localize some objects with wp_localize_script informing me that I cannot use an object of that type as an array. For tests, I've done this with $wp, $wp_query, $wpdb, and $wp_scripts on a clean install with no plugins.
I also have been working on sites that would like to compress all of their JS calls into a single request where possible, but in the past I was not able to keep localizations that certain scripts required, and had to leave them out.
With the changes I've made in this patch file, the issues regarding pushing arbitrary objects for localization are addressed. It also stores those objects, rather than a string of JS with $wp_scripts. This allows me to pull the localizations used for some files, and attach them instead to another file using wp_localize_script.
As a side benefit, by not processing the object into JS until output, we are able to preserve the data cleanly, and reduce process on any script that may be dequeued later that has such dependencies.
I would like to submit this patch as a core patch for a future release. Its design is fully compatible with existing functionality in 3.3, with the exception of any code modifying the underlying data key in an enqueued script directly." ssmathias
Needs Milestone 17249 thickbox modal window dimensions are fixed in wp-admin Administration 3.1 normal normal Awaiting Review defect (bug) new 2011-04-27T05:01:38Z 2012-01-19T00:03:35Z "Hello,
When invoking a thickbox modal in wordpress wp-admin, the dimensions of the modal window can't be customized. Because of media-upload.js is replacing the tb_position() function.
This is not needed that way, and media upload modal window size can be set when calling it.
The workaround is rather complicated, please read: http://binarybonsai.com/2010/02/27/using-thickbox-in-the-wordpress-admin/ down to ""The Media Manager Horror""" DreadLox
Needs Milestone 19872 Add Hook/Filter to image_resize_dimensions in media.php Media 3.3.1 normal normal Awaiting Review enhancement reopened dev-feedback 2012-01-21T19:38:18Z 2012-01-21T22:23:46Z "It would be great if a hook, a filter, a global, an option, or something somewhere were created to allow the image_resize_dimensions() function in media.php to resize images to be larger than the original. In a typical scenario I can understand why you would not want to allow this, however there are rare circumstances where this would be helpful (generating a background image). Currently lines 349 and 350 of media.php read:
{{{
$new_w = min($dest_w, $orig_w);
$new_h = min($dest_h, $orig_h);
}}}
and lines 378 to 380 read:
{{{
// if the resulting image would be the same size or larger we don't want to resize it
if ( $new_w >= $orig_w && $new_h >= $orig_h )
return false;
}}}
It would be great if we were provided a boolean to alter these two blocks, for example:
{{{
if($allow_resize){
$new_w = $dest_w;
$new_h = $dest_h;
}else{
$new_w = min($dest_w, $orig_w);
$new_h = min($dest_h, $orig_h);
}
}}}
...
{{{
// if the resulting image would be the same size or larger we don't want to resize it
if ( $new_w >= $orig_w && $new_h >= $orig_h && !$allow_resize)
return false;
}}}" webbtj
Needs Milestone 19572 switch_to_post() stack implementation (similar to switch_to_blog()) General 3.3 normal normal Awaiting Review enhancement new has-patch 2011-12-15T21:54:57Z 2012-01-23T20:21:14Z "One of the challenges themes and plugins have is the balance between utilizing the core APIs that rely on global variables, while leaving things in a ""clean"" state for the next worker in the chain.
For example, I might have a shortcode that pulls content from another post, outputs a title or some other data, then needs to restore the previous post environment. The attached patch provides APIs for doing just this - using the same stack approach that switch_to_blog() takes in a multi-site instance.
To set up a post context, call: switch_to_post($post_id);
This can be called multiple times, diving deeper into the stack. Then each process is responsible for restoring the $post context by calling: restore_post();
This goes back to the stack, bumps out the current post and restores the previous post's context.
There is some test code for demonstration here:
https://gist.github.com/1309915" alexkingorg
Needs Milestone 19879 Better caching for get_dirsize Multisite 3.3.1 normal normal Awaiting Review enhancement new 2012-01-23T15:42:59Z 2012-01-24T23:54:25Z "In a multisite install, when trying to determine whether a site has exceeded its storage quota, WordPress will scan through a blog's upload directory and sum up the file sizes, by running {{{filesize}}} against each one. With a large number of files, this can significantly slow down the upload process or certain portions of the Dashboard.
{{{get_dirsize}}} has transient caching in place but this is a single cache entry for all folders. It might be better if WordPress has a separate cache entry for each folder and was invalidated based on context so that get_dirsize does not need to be run constantly on older, unchanged directories as frequently." batmoo
Needs Milestone 19892 wp_fix_server_vars() mangles REQUEST_URI on some servers General 3.3.1 normal normal Awaiting Review defect (bug) new has-patch 2012-01-25T00:58:47Z 2012-01-25T06:53:04Z "== Bug manifestation: ==
On some server setups, saving settings on any settings page which uses options.php - including the twentyeleven theme options pages - results in a ''You do not have sufficient permissions to access this page.''-error page, even if you are the (super-)admin of the website.[[BR]]
The changed settings *are* however saved, but the bug obviously causes a usability issue.[[BR]]
[[BR]]
== The cause of the issue: ==
The issue is ultimately caused by (shared-)hosting companies which - for security reasons - set the {{{$_SERVER['SERVER_SOFTWARE']}}} variable to MS IIS when in reality the server runs on a Linux variant.[[BR]]
[[BR]]
The {{{$_SERVER['SERVER_SOFTWARE']}}} variable being MS IIS causes ''wp_fix_server_vars()'' to double the query vars resulting in a mangled {{{$_SERVER['REQUEST_URI']}}}.[[BR]]
I.e.: ''""/wp-admin/themes.php?page=theme_options""'' becomes ''""/wp-admin/themes.php?page=theme_options?page=theme_options""''[[BR]]
[[BR]]
As the {{{$_SERVER['REQUEST_URI']}}} variable is used by the ''settings_fields()'' function to generate the hidden form fields for the option pages, this then in turn results in a mangled ''_wp_http_referer'' form value.[[BR]]
I.e.: {{{}}} tags inside CDATA or with Unicode directionality characters (for e.g., RLE and PDF, or and , or U+202B and U+202C.) for excerpts or titles.
While we currently have pretty good support for RTL languages, there is no support for RTL in feeds - all is left up up to the feed reader.
I suggest adding a mechanism to automatically insert these tags/characters for blogs that have text_direction set to RTL - much in the same way RTL css style sheets are loaded for these blogs.
I have attached a patch that modifies the feed templates to insert these tags/characters. Note that there is no checking of blog directionality here - this is just an example of how to enforce RTL in feeds, not how to enforce it conditionally.
This relate to a previous ticket I submitted (#5517), regarding adding an option to set the feed language - which currently just defaults to EN. Certain feed readers know to display RTL text in proper directionality according to feed language (for e.g., feeds that have their feed language set to HE (Hebrew), will get displayed from Right to Left). While setting feed language is not a comprehensive solution, it is a step in the right direction." RanYanivHartstein
Needs Milestone 19995 Slow down of access to Multi-Site Admin area when Upgrading to 3.3.1 Multisite 3.3.1 normal normal Awaiting Review defect (bug) new 2012-02-08T22:57:26Z 2012-02-09T00:14:42Z I've done a search and didn't see a trouble ticket for this so I wanted to post it and see what the feedback looked like. With the upgrade to WordPress 3.3.1 I've seen a very big slow down of access to the Admin area for both the Network sites as well as the Network Admin. I thought it was my server lagging at first or maybe an issue with me having to clean up my MySQL server but I've heard from others whom I know that also run Multi-Site installs having the same problem as well. One gentlemen's client thought his site had even been hacked because of the amount of time it was taking to get to the admin area but after running the necessary security tools it was realized that the server was secure but the lag did exhist. Any thoughts? bastosmichael
Needs Milestone 18594 Permalinks should be saved twice on post_type slug change Permalinks 3.2.1 normal normal Awaiting Review defect (bug) new close 2011-09-05T09:46:33Z 2012-02-10T11:40:58Z "Hello,
In a plugin I allow my users to set the slug of a custom post type from a sttings page. I flush the rules on every load of that settings page (only that page)
When they change the slug, they have to save and then reload the settings page for the permlink to be correctly chnaged.... A single flush_rules call shouldn't be enought?" Gecka
Needs Milestone 20011 Filtering posts for plugins that do not call posts to be filtered Query 3.3.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-02-10T15:35:02Z 2012-02-10T15:43:59Z "In Query.php Line: 2745
Multisite Installation (3.3.1) While using Google XML Sitemaps Version 4.0beta4
Change:
{{{
// Always sanitize
foreach ( $this->posts as $i => $post ) {
$this->posts[$i] = sanitize_post( $post, 'raw' );
}
}}}
To:
{{{
// Always sanitize
if ($this->post_count > 0) {
foreach ( $this->posts as $i => $post ) {
$this->posts[$i] = sanitize_post( $post, 'raw' );
}
}}}
" jroakes
Needs Milestone 19921 "always use require_once for wp-load.php (fixes ""ABSPATH defined multiple times"")" General 3.3.1 normal normal Awaiting Review defect (bug) new 2012-01-29T18:09:46Z 2012-02-10T17:53:45Z "The `wp-load.php` file should always be included via `require_once`. This allows developers to include files when necessary with having to run into the ""ABSPATH defined multiple times"" notice (let alone waste time processing the file).
In trunk, require_once is already used in the majority of cases for `wp-load.php`:
* 24 require_once
* 8 require
* 1 include
This has come up because of a situation in a plugin where it is necessary to manually include the `wp-login.php`. But then `wp-login.php` calls `require wp-load.php` and the constant re-declaration notice arises.
In two cases, the patch changes relative paths (eg `./` to `dirname(__FILE__)`) to avoid safe mode problems and improve the ability to run files from anywhere(1), which is helpful for testing from the command line.
(1) Paths in PHP are relative to the present working directory, not the directory the file is in." convissor
Needs Milestone 20016 Spellchecker returns suggestions with wrong encoding Editor normal normal Awaiting Review defect (bug) new has-patch 2012-02-10T17:59:00Z 2012-02-10T20:34:01Z "Steps to reproduce:
* Create new post
* Type 'canamo'
* Set spellcheck language to Spanish
* Click on 'canamo' for suggestions
" koke
Needs Milestone 20025 Add a filter for post types when viewing list of comments in the backend Comments 3.3.1 normal normal Awaiting Review feature request new 2012-02-12T14:03:49Z 2012-02-12T14:38:23Z Filtering comments based on post type nprasath002
Needs Milestone 20020 Odd Visual Editor Behavior Pertaining to Images TinyMCE 3.3.1 normal normal Awaiting Review defect (bug) new 2012-02-11T00:12:06Z 2012-02-12T17:24:25Z "Hi I usually use the HTML editor. But I'm making a tutorial about using the visual editor and I ran into this problem or ""bug"".
When one adds an image to the editor and then some text, but then deletes that text using backspace, it kicks the image down a line (this happens whether the image is left or right aligned).
Then if one wishes to delete the new line that has been created, the image disappears.
Best Regards,
Drew" xroox
Needs Milestone 19862 """My Sites"" menu should include ""Create a new site"" if enabled in Network settings" Network Admin 3.3.1 normal normal Awaiting Review enhancement new has-patch 2012-01-20T16:58:14Z 2012-02-13T04:22:49Z "The ""My Sites"" menu should include ""Create a new site"" if blog registration is enabled in Network settings." ebellempire
Needs Milestone 20048 Allow mt.getRecentPostTitles to return the sticky flag General 3.3.1 normal normal Awaiting Review enhancement new 2012-02-15T14:02:03Z 2012-02-15T14:02:03Z "Would be nice to return the value of the sticky flag in the mt.getRecentPostTitles response. This XML-RPC call is mostly used on mobile clients, and we need to show a visual indicator on ""sticky"" posts. Obviously, we can call metaWeblog.getRecentPosts, but it is a ""more expensive"" XML-RPC call." daniloercoli
Needs Milestone 20050 Proper Cap check in edit_comments.php Comments 3.3.1 normal normal Awaiting Review defect (bug) new has-patch 2012-02-15T17:36:51Z 2012-02-15T17:56:25Z "See #20025.
As in edit.php?post_type=custom_post_type
and edit-tags.php?taxonomy=custom_taxonomy
When filtering comments for a specific post type
The fix in cap is more appropriate" nprasath002
Needs Milestone 20009 Escape later when getting post and body classes Themes normal normal Awaiting Review defect (bug) new dev-feedback 2012-02-10T08:11:37Z 2012-02-15T21:24:17Z "Both get_body_class() and get_post_class() provide filters that allow plugins and themes to add custom values to the list. These filters are applied after the values in the $classes array have been filtered through esc_attr(). I think that it would be best to move the escaping after the filter has fired.
esc_attr() was first added to get_body_class() and get_post_class() in [11838]" mfields
Needs Milestone 20075 Add action hooks to wp-activate.php in WP network Multisite 3.3.1 normal normal Awaiting Review enhancement new 2012-02-19T11:55:26Z 2012-02-19T11:55:26Z "Similar to the hooks in wp-signup.php:
do_action( 'before_signup_form' );
do_action( 'after_signup_form' );
these hooks should be added to wp-activate.php:
do_action( 'before_activate_form' )
do_action( 'after_activate_form' )
Purpose : allow signup and activate pages to be built/styled in a similar way.
" gdvwp
Needs Milestone 20077 shortcode_parse_atts should not force arguments to be lowercase General normal normal Awaiting Review defect (bug) new close 2012-02-19T19:21:33Z 2012-02-20T17:42:42Z "Inside wp-includes/shortcodes.php, the shortcode_parse_atts() function forces shortcode arguments to be lowercase. So if your shotcode had something like [my_shortcode MyVar=123], then your code that uses something like ""print $MyVar;"" fails... you have to use ""$myvar"" instead. This is counter-intuitive. I understand that there needs to be some restrictions on what is a valid parameter name (see http://core.trac.wordpress.org/ticket/9405), but I think it makes the most sense that the parameter names can correspond to any valid PHP variable name; PHP variables ARE case-sensitive, so this arbitrary restriction of forcing lower-case parameters seems like the incorrect approach." fireproofsocks
Needs Milestone 20092 Add Exclude by Tag to Queries Query normal normal Awaiting Review enhancement new 2012-02-21T23:36:35Z 2012-02-22T06:28:52Z "Per scribu's instruction:
Category exclusion is already possible for feeds using a query string, tags should be the same.
'''Example:'''
http://domain.com?cat=news&tag=-featured&feed=rss2
Would equate to a feed of posts in the ""news"" category, not tagged ""featured"" and outputted via the RSS2 template." iridox
Needs Milestone 20094 The wpEditImage TinyMCE plugin is broken when TinyMCE is served from another domain TinyMCE 2.6 normal normal Awaiting Review defect (bug) new has-patch 2012-02-22T00:48:46Z 2012-02-22T09:05:26Z "If TinyMCE is served from another domain (for example a CDN), the wpEditImage plugin tries to open the image editing iframe from that other domain. This breaks inter-iframe communication due to a violation in the same-origin policy.
The code is the same all the way back to 2.6, but I didn't verify the problem occurs there (TinyMCE's API may have changed since then).
Attached:
* Ensures the iframe is always served from the same origin as the parent page.
* Fixes the iframe cache busting." mdawaffe
Needs Milestone 20095 get_users() doesn't allow hyphens in meta_key parameter Users 3.3.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-02-22T02:29:04Z 2012-02-22T20:01:27Z "When retrieving users with the get_users() function, the meta_key parameter does not work if the key contains a hyphen (dash).
For example:
{{{
$members = get_users(array(
'meta_key' => 'job-seeking',
'meta_value' => 1,
)
);
}}}
That will result in no members being found, even though at least one user with a meta_key of ""job-seeking"" with a value of 1 does exist.
This, however, will work:
{{{
$members = get_users(array(
'meta_key' => 'job_seeking',
'meta_value' => 1,
)
);
}}}" mordauk
Needs Milestone 19902 blog_url() and get_blog_url() template tags Template 3.3.1 normal normal Awaiting Review feature request new dev-feedback 2012-01-26T21:44:13Z 2012-02-23T22:00:03Z "With usage of WordPress as a CMS increasing, the blog is not always the focal point. It would be great if there were template tags available to get the blog url, basically a wrapper for getting the options if it's set to a WordPress page, and defaulting to home_url( '/' ) if not.
Patched against r19759 (trunk)" johnjamesjacoby
Needs Milestone 20107 Add Filter for user_name length in ms user signup Multisite normal normal Awaiting Review enhancement new dev-feedback 2012-02-23T17:46:45Z 2012-02-23T22:44:26Z It is difficult for us to explain our clients why they cannot have usernames with 3 chars and left. For that issue I'd like to recommend a filter for that, so we can change this with a plugin. hughwillfayle
Needs Milestone 20115 Filter For media_upload_gallery_form Media 3.3.1 normal normal Awaiting Review feature request new 2012-02-24T21:37:53Z 2012-02-24T21:37:53Z "I recently ran into a project where we wanted to modify a gallery and interject some new gallery options. As such the most simple user interface was to add a new setting to the gallery form on the media upload page under galleris. We would modify the shortcode creation and then override the gallery shortcode function with our own code. The only problem is you can't overload the media_upload_gallery_form function in /wp-admin/includes/media.php
Not sure if a filter option or action is the right one here but I think that would give this area that overriding ability as well.
Having the ability to do this would be not only beneficial for my specific problem but woud give people the ability to really take the gallery to another level without messing up a familiar interface that people are using." greenspeakmedia
Needs Milestone 15551 Custom post type pagination redirect Query 3.1 normal normal Awaiting Review defect (bug) reopened reporter-feedback 2010-11-23T21:50:06Z 2012-02-25T11:23:57Z "We seem to be having a problem with a redirect on a custom post page (e.g., http://www.example.com/show/slug/).
Everything on the page shows correctly. The template pulls in posts with the following query:
{{{
'show', 'meta_value' => $show->ID, 'paged' => get_query_var('paged'), 'caller_get_posts' => true)); ?>
}}}
After the posts we display pagination links (e.g., http://www.example.com/show/slug/page/2/). In our rewrite rules, we include the following rule which should handle these URLs:
{{{
'show/([^/]+)/page/([0-9]{1,})/?$' => 'index.php?show=$matches[1]&paged=$matches[2]',
}}}
Instead of the page displaying and allowing us to pull in the second page of posts, the browser is being redirected back to the original page (http://www.example.com/show/slug/) with a 301. I see that this is happening inside the redirect_canonical function. The following code in wp-includes/canonical.php replaces /page/2/ with / causing the redirect:
{{{
// paging and feeds
if ( get_query_var('paged') || is_feed() || get_query_var('cpage') ) {
if ( !$redirect_url )
$redirect_url = $requested_url;
$paged_redirect = @parse_url($redirect_url);
while ( preg_match( ""#/$wp_rewrite->pagination_base/?[0-9]+?(/+)?$#"", $paged_redirect['path'] ) || preg_match( '#/(comments/?)?(feed|rss|rdf|atom|rss2)(/+)?$#', $paged_redirect['path'] ) || preg_match( '#/comment-page-[0-9]+(/+)?$#', $paged_redirect['path'] ) ) {
// Strip off paging and feed
$paged_redirect['path'] = preg_replace(""#/$wp_rewrite->pagination_base/?[0-9]+?(/+)?$#"", '/', $paged_redirect['path']); // strip off any existing paging
$paged_redirect['path'] = preg_replace('#/(comments/?)?(feed|rss2?|rdf|atom)(/+|$)#', '/', $paged_redirect['path']); // strip off feed endings
$paged_redirect['path'] = preg_replace('#/comment-page-[0-9]+?(/+)?$#', '/', $paged_redirect['path']); // strip off any existing comment paging
}
}}}" cbsad
Needs Milestone 20124 Smilies Fail Combinations Formatting 3.3.1 normal normal Awaiting Review defect (bug) new has-patch 2012-02-25T22:34:25Z 2012-02-26T12:37:54Z "I have found that certain combinations of smilies break the monster of a regular expression that parses them.
{{{
8-O :-(]
8-) 8-O
8-) 8O[
8-) :-(
8-) :twisted:
8O :twisted: :( 8-( :(
}}}
...are some examples where the regular expression appears to be failing to match. Any smilie after a smilie with an 8 in it appears to be skipped. Will try to pinpoint the flaw in the regexp soon." soulseekah
Needs Milestone 20127 Add filter in dynamic_sidebar() to modify sidebar index andrewryno Widgets 3.3.1 normal normal Awaiting Review enhancement new has-patch 2012-02-27T00:06:06Z 2012-02-27T00:06:06Z Use case: changing sidebars depending on the page/post/etc loaded through a plugin. Nothing too complex, just no way to do it. There is a filter dynamic_sidebar_params but that isn't called until later on in the function after the widgets have been collected for that sidebar. andrewryno
Needs Milestone 20060 wp_redirect() doesn't exit Security normal normal Awaiting Review enhancement new dev-feedback 2012-02-17T15:35:11Z 2012-02-27T05:46:35Z "As discussed in #15518, not exit()'ing after a redirect can be a security vulnerability and also lead to unexpected behavior. I think that most developers assume that the API would take care of that for them, since that would be the best practice, so they don't do it in their own code.
There are some cases where features need to redirect without exiting, though, so the API needs to support both cases. Ideally wp_redirect() should exit() by default, but that would cause too many backwards-compatibility issues. So, I'd propose making these changes:
* Add a new boolean parameter to wp_redirect() that determines if it should exit() or not. It's false by default. If it's passed in as true, then exit() is called at the end of the function. Having it set to false by default avoids the backwards-compatibility issues.
* Add the new boolean parameter to wp_safe_redirect() also.
* Create new wp_redirect_exit() function that is a wrapper for a wp_redirect() and passes in a true value for the new parameter. Then, promote this new function on the Codex and other places to inform developers that they should be using it unless they actually need to execute code after the redirect.
* Also create wp_safe_redirect_exit() in the same way." iandunn
Needs Milestone 20125 Escape output in settings_errors General 3.0 normal normal Awaiting Review enhancement new close 2012-02-26T17:26:26Z 2012-02-27T06:37:53Z "'''The Problem'''
The ""settings_errors"" function does not escape data when outputting it from the $settings_errors variable, which either comes from the $wp_settings_errors global variable or the ""settings_errors"" transient. This data is not escaped at any point during retrieval or output. Additionally, the data is not sanitized or validated when adding it via ""add_settings_error"".
'''Test Case'''
In the validation callback function for a setting, adding a settings error with HTML can badly break output:
{{{
add_settings_error( 'zdt-setting', '1023', 'An error occurred
' );
}}}
'''Solution'''
Escape the $type, $code, and $message variables on output.
'''Possible Issues'''
The $message variable is output wrapped in a 'p' and 'strong' tag. My patch tries to allow common, reasonable tags to be output. I use ""wp_kses_data"", which will only allow tags defined in the $allowedtags variable. Should a plugin or theme author need another element printed out, it will be stripped; however, there still is the potential that it could cause issues for plugins that were previously able to place anything in the $message variable. With that said, most other tags would lead to invalid HTML and probably shouldn't be allowed in this context anyway." tollmanz
Needs Milestone 19100 Introduce esc_color() General normal normal Awaiting Review enhancement new dev-feedback 2011-11-01T12:16:14Z 2012-02-28T03:15:42Z Currently there is no way to escape a color in hexadecimal notation before printing it to a block of css or saving to the database. Many themes like to introduce functionality, whether it be core-supported or completely custom, to change the color of various parts of the templates. I believe that a function such as `esc_color()` would promote best practices while ensuring that unintended values do not get stored as colors and thus echoed in css blocks potentially breaking display. mfields
Needs Milestone 20133 Tags with diacritical marks issue General 3.3.1 normal normal Awaiting Review defect (bug) new 2012-02-28T18:06:15Z 2012-02-28T18:06:15Z "I can't add tags to post with diacritical marks (for example polish word ""bąk"") and then the same word without diacritical marks ""bak"" from edit post panel, because function term_exists() in wp-includes\taxonomy.php returns true when checking if this tag already exists. I can do this from tag edit panel, but this is more time concuming." partyzant
Needs Milestone 20144 make posts without title or without main text more comfortable General normal normal Awaiting Review enhancement new 2012-02-29T17:55:15Z 2012-02-29T17:55:15Z "make posts without title or without main text more comfortable. as i know posts without main text is even not possible. if user creates post without title, it is hard to find in dashboard post list!
this enhancement would allow to use wordpress as microblog." qdinar
Needs Milestone 19140 Save Menu Forces Sub-Menus (Child Menus) Back To Parent Menus in IE 9.0 Menus 3.2.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2011-11-03T22:50:29Z 2012-02-29T20:32:43Z "The following issue appears in Internet Explorer 9.0.8112.16421 (current version).
In Appearance->Menus for both primary and secondary menus, when you try to define a sub-menu by drag-n-dropping to the right in the menu definition box, it shows indented properly. However, when you click Save Menu, all sub-menus return to being parent menus.
The only way to get the sub-menus to work was to edit them in another browser. In this case, I used Internet Explorer 7.0.5730.11 and it worked properly." webby 2
Needs Milestone 19828 allowing to insert help tab in specific position Administration 3.3.1 normal normal Awaiting Review enhancement new has-patch 2012-01-13T21:50:15Z 2012-03-01T17:22:32Z "this enhancement of add_help_tab() would allow plugin developers to insert help tabs on existing screens at an arbitrary position, e.g. place it on the ""Writing Settings"" screen's help tab between the ""Overview"" and ""Press This"" tabs
the patch attached includes the bugfix from #19827, but this enhancement can be rewritten to work independently" tfnab
Needs Milestone 20151 Add parameter for wp_embed_defaults() Media normal normal Awaiting Review enhancement new has-patch 2012-03-01T20:08:17Z 2012-03-02T06:07:04Z "If we can add a parameter (like $url) to wp_embed_defaults(), then people can filter more intelligently as WordPress extends to allow more and more oEmbed.
" wpsmith
Needs Milestone 20166 Function url_shorten() enhancement Formatting normal normal Awaiting Review enhancement new has-patch 2012-03-03T23:03:47Z 2012-03-04T03:37:59Z "The function url_open is included in the wp_admin/includes/misc.php and is not usable unless loaded. This is not loaded by default so not available site wide. Also, the function is very static as of right now in its use with no defined options. Options to set length of the shortened url and the ability to turn on off the cutting of the leading ""http://www"" and the trailing slashes are included in this patch." mulvane
Needs Milestone 20171 Categories/Tags links are broken in WP 3.3.1, with multisite/subfolder install Multisite 3.1 normal normal Awaiting Review defect (bug) new 2012-03-04T07:10:35Z 2012-03-04T13:21:39Z "All the default categories/tags links are not working, showing error..
""This is somewhat embarrassing, isn’t it?""
Steps to reproduce:
-------------------
1. Install WP 3.3.1 on domain, e.g. http://blog.example.com
2. Enable multi-site features, using subfolder instead of subdomain
3. Create a site, e.g. http://blog.example.com/test1
4. Create a post, e.g. http://blog.example.com/test1/2012/03/04/test1/
5. Enter the default category link, e.g. http://blog.example.com/test1/category/uncategorized/
Now you will see the message: ""This is somewhat embarrassing, isn’t it?""
Fix:
----
1. Enter this link: http://blog.example.com/test1/wp-admin/options-permalink.php
2. Change nothing, press ""Save Changes""
3. Now you can view the link correctly: http://blog.example.com/test1/category/uncategorized/
The above issue also apply to tags" tszming
Needs Milestone 20178 wpdb class : provide a disconnect / connect to db functions arena General 3.4 normal normal Awaiting Review enhancement new dev-feedback 2012-03-05T13:16:21Z 2012-03-05T16:28:46Z "some hosts automatically disconnect mysql after a short while.
I think it could be interesting to have in wpdb a disconnect and connect functions." arena
Needs Milestone 20167 Add wp_pages_checklist for creating checklist of pages on site Template normal normal Awaiting Review enhancement new has-patch 2012-03-04T04:57:00Z 2012-03-06T01:56:51Z "Per conclusion of [http://core.trac.wordpress.org/ticket/20156#comment:15 ticket #20156]
""If someone does write a patch that implements wp_posts_checklist() and
uses it in nav-menus.php, please open a new ticket.""
The attached patch:
- extends Walker with Walker_Page_Checklist
- adds wp_pages_checklist() and wp_pages_checklist() functions
functionality structure was modeled after wp_category_checklist and wp_dropdown_pages to keep with WP standards.
If this patch is accepted my intention is to finish the request and implement it into nav-menus.php." jackreichert
Needs Milestone 20180 Should wrap all links in a div Widgets normal normal Awaiting Review enhancement new 2012-03-05T19:43:51Z 2012-03-06T02:28:10Z "The links widget creates a separate div for every category. This does not allow to style all categories at once.
Please wrap all links into one more level of div." porton
Needs Milestone 20037 Introduce 'noindex' filter for robots meta tag Template 3.4 normal normal Awaiting Review enhancement new has-patch 2012-02-14T05:01:38Z 2012-03-08T07:56:07Z "As things are right now, themes and plugins add robots meta tag lines by just adding an action to wp_head, with no way of knowing who has added what. Because it is not done as a filter, there is no way to prioritize or alter things.
As far as I can see there are two functions that are hooked to wp_head to add the meta tag for robots, the noindex() and wp_no_robots() function in '/wp-includes/general-template.php'. All noindex() does is look to see if a blog is marked private, then calls wp_no_robots(). In other places, like the signup and login pages, wp_no_robots is manually added.
To help clear up the confusion, we could just call wp_no_robots whenever we need to add a robots meta tag, use wp_no_robots to do some default logic, then allow plugins to filter it depending on where we are.
Working on a quick patch now and will add." MartyThornley
Needs Milestone 17981 XML-RPC wp.getComments should work for non-admins XML-RPC 3.2 normal normal Awaiting Review defect (bug) new commit 2011-07-04T22:23:03Z 2012-03-08T13:35:11Z "Right now, if the caller doesn't have the moderate_comments permission, the XML-RPC call returns a 401 error.
A more graceful alternative would be to return the approved comments. The user may not be able to moderate, but still should be able to read/reply" koke
Needs Milestone 20206 WXR unnecessarily includes all post authors Export 3.3 normal normal Awaiting Review enhancement new has-patch 2012-03-09T01:06:58Z 2012-03-09T02:26:14Z "If you're exporting just one post type (from Tools -> Export), the resulting WXR file still includes all authors from the posts table, regardless if they are the author of a post of the post type being exported. This can be particularly noticable for Pages (which are often only authored by a small number of different users on the site) and for custom post types.
This means when you subsequently import the file you'll be asked to map a complete list of all authors from the exported site, even if they have no posts in the WXR file being imported." johnbillion
Needs Milestone 20213 Pagination fails silently when mysql.trace_mode is on Warnings/Notices 3.4 normal normal Awaiting Review enhancement new 2012-03-10T16:06:15Z 2012-03-10T16:06:15Z "A sysadmin left enabled '''mysql.trace_mode''' on php.ini without me knowing about it, and I spent hours trying to find out why the '''next_posts_link''' wasn't showing up.
This is very hard to debug, because
* it fails silently, with no error to look for
* it's hard to repro on a dev server, which may not have the same php.ini settings as in staging/prod (ideally should, but rare for 99% of devs)
Other people had this same issue:
* ""[http://wordpress.org/support/topic/page-navi-not-working-with-mysql-5134-amp-php-529 No error, it's just not working]""
* ""[http://wordpress.org/support/topic/archives-not-showing-nextprev-windows-only-crazy Am I going crazy]""?
* Trace_mode defaulted to ""on"" in [http://stackoverflow.com/a/869957/128329 this guy's] install (!).
I've read through #18536, #10469 and related issues, hoping that usage of SQL_CALC_FOUND_ROWS would be removed, but it seems to be still there, in trunk.
So I guess a ""fix"" for this would be to check for trace_mode and, if enabled, notify admin users on the wp-admin dashboard.
Meanwhile, I've added a note about this on the [http://codex.wordpress.org/Function_Reference/next_posts_link next_posts_link] page.
" ManuelRazzari
Needs Milestone 20224 WordPress should always add a / at the end of URLs Canonical 3.4 normal normal Awaiting Review enhancement reopened close 2012-03-13T09:54:17Z 2012-03-14T12:36:36Z "Users can change permalinks. They can add whatever they whant at the end of each url. For example :[[BR]]
- mydomain.com/myurl
- mydomain.com/myurl/
- mydomain.com/myurl.php
- mydomain.com/myurl.html
- mydomain.com/myurl.htm
- ...
There is a bug with search engines and empty URLs (mydomain.com/myurl). Google, Yahoo or Bing consider that it's not the same URl as mydomain.com/myurl/. They always try to add a / at the end of those URLs : it creates duplicate content for search engines that harms website visibility. For example, if a WordPress Blog uses /%postname% as permalink, Google is going to index both url:
- mydomain.com/myurl
- mydomain.com/myurl/
In order to correct this issue, WordPress should always add a / at the end of empty URLs (for example, without a / or without extension like .php, .asp, .html, ...)." Confridin
Needs Milestone 20251 get_preferred_from_update_core can return false General normal normal Awaiting Review defect (bug) new 2012-03-17T14:51:41Z 2012-03-17T14:51:41Z "I just had a case in my network installation where get_site_transient( 'update_core' ) returned false.
In this case it gave an error message at core_update_footer();
When I went back to Network admin updates page and press 'check_again' the error went away.
The error can be caused because of running the recent nightly build (3.4-alpha-20205).
What was weird that in the site wp-admin there still was the balloon that there was an update when I had the error. When I pressed the button the balloon went away what is the correct." markoheijnen
Needs Milestone 20257 Url of navigation menu item of alternative type removed Menus 3.3.1 normal normal Awaiting Review defect (bug) new 2012-03-18T19:49:26Z 2012-03-18T20:15:25Z "When creating a new navigation menu item with `wp_update_nav_menu_item` the url is removed if the type of the item is not 'custom'. If the type of the item is 'taxonomy' or 'post_type', the url is then set appropriately. However, if the item has a type other than 'custom','taxonomy', or 'post_type' the menu item is saved without an url.
`wp-includes/nav-menu.php L314`
{{{
if ( 'custom' != $args['menu-item-type'] ) {
/* if non-custom menu item, then:
* use original object's URL
* blank default title to sync with original object's
*/
$args['menu-item-url'] = '';
}}}" stephenh1988
Needs Milestone 20260 Post by email posting same message multiple times General 3.3.1 normal normal Awaiting Review defect (bug) new 2012-03-19T15:40:57Z 2012-03-20T08:45:04Z "I am using the Post by email feature for a Wordpress.org blog. I post by mail once a day and daily to the blog, usually around midnight. There are usually between 2 and 6 messages posting on any given day (sent as individual emails).
I have set up a secret POP email address to which I send emails, and these emails are picked up by Wordpress as Posts on my blog.
However, I am seeing the messages post multiple times; sometimes twice, sometimes up to 10 times in a row on the blog.
It usually happens for all messages on certain days, but some days this does not happen at all. I have not been able to identify a pattern of which days have this problem or if it is related to the number of messages posting on a particular day.
This issue began happening around October 2011; previously, I didn't notice this problem.
Environment:
Wordpress.org 3.3.1
Thunderbird 7.1 email client; publish messages sent in text mode, with word wrap off
Google Apps account used as secret email. Account set to POP. All forwarding, etc. is turned off.
Steps: 1) wp-mail.php modified to post regardless of author, per bug 18923 which keeps messages stuck in Pending status 2) User from which posts sent is registered as Editor or Admin in Wordpress site. 3) Theme footer modified to include automatic checking for incoming messages 4) Email account is setup in mail client that matches the Admin/Editor email in Wordpress 5) Message to post is sent to the secret address by user
Result: 1) Wordpress on certain days posts the messages with no problem; other days, it posts multiple copies of the message. Usually, either all messages post multiple times or all post one time for a given day; I have not noticed that if one message on a particular day posts multiple times that another will post only once. 2) There can be anywhere from 2 to 10 copies of the same message posted. 3) I have tried to modify my POP account settings so that messages get Archived when read, rather than staying in the Inbox; however, this did not fix the problem.
Note: I use Google Apps as the email server for both the From: mail and the secret address mail.
I have not been able to find other discussions on this topic, nor track down any possible root cause of it.
Message of one of the posts that posted multiple times is attached." bloggertype
Needs Milestone 20252 "Default img url when adding media includes ""http://etc"" causing insecure content in https pages" Media 3.3.1 normal normal Awaiting Review defect (bug) new close 2012-03-18T04:03:19Z 2012-03-21T04:49:20Z "New post, insert media, select an image and have a look at the
}}}
see also: http://wordpress.org/support/topic/admin-menu-wont-dis-collapse-anymore" digitaldonkey
Needs Milestone 19689 Context for Dismiss I18N 3.3 normal normal Awaiting Review defect (bug) reopened has-patch 2011-12-29T20:37:46Z 2012-05-02T16:32:18Z "In WP 3.3 there are some new occurences for ""Dismiss"". But in some languages there is not one ideal translation for this verb.
1) Dismiss - meaning Close (suitable for Welcome screen, Browser window and Pointers).
2) Dismiss - meaning Cancel or Stop (suitable for uploading media).
I created basic patch to better explain this idea.
I also could not find occurences for Dismiss in async-upload.php and script-loader.php anywhere in administration during upload, but maybe it is related to some special conditions? In which circumstances can users see string Dismiss during uploading media?" pavelevap
Needs Milestone 18762 Pagination does not work correctly on walker in reverse order. Comments 3.2.1 normal normal Awaiting Review defect (bug) new has-patch 2011-09-23T21:08:42Z 2012-05-02T17:26:33Z "Steps to reproduce:
1. Go to Discussion and change Comments should be displayed with the comments at the top of each page to ""newer"" (that is, set comment_order='desc').
2. Make sure your theme is paginating comments. Make sure you have more than the page limit of comments.
3. Note that the first page does not actually contain the newest comments (they're off by a page, or perhaps they're just sorted in one way for the pagination and a different way for the inner page sort).
If you check out the $start, $oldstart and $end variables, the way it was written before the patch, $start gets set to 11 (page limit + 1) on page = 1, the way it is written after the patch, start is 0, as it should be.
All I've done is swapped the order of $start and $end being updated. This fixes the starting point. This needs to be tested in more detail before actually deploying it, but there is definitely a pretty serious bug here." gburtini
Needs Milestone 19930 Add tabindex to Comment Submit button Comments 3.3.1 normal normal Awaiting Review defect (bug) new 2012-01-30T14:54:21Z 2012-05-03T15:40:22Z For accessibility reasons, it would be nice to be able to add tabindex to the comment form submit area. wpsmith
Needs Milestone 20446 Add comment form submit button class attribute Comments 3.3.1 normal normal Awaiting Review enhancement new has-patch 2012-04-15T07:34:55Z 2012-05-03T15:59:12Z "The comment_form() is packed with filters all over the place to customize the from just the way you need, but one thing i find missing is a class on the submit input tag and if there was a class attribute then it should be filterable.
I know you can set the input ID and simply style based on the ID selector but when designing themes usually you have some kind of class defined for buttons, especially when using any of the html5/responsive theme frameworks and if the comment submit input had a class which was filterable then it would make our lives much easier.
" bainternet
Needs Milestone 18792 Wrong FROM email when using wp_mail and built in mail() function westi* External Libraries 3.2.1 normal normal Awaiting Review defect (bug) accepted has-patch 2011-09-27T16:35:28Z 2012-05-04T14:43:56Z "When using wp_mail in combination with mail() function, then From: envelope passed through -f parameter to sendmail is not set correctly.
Here is simple patch, that fixes the problem:
{{{
--- pluggable.php 2011-09-26 20:54:02.219330702 +0200
+++ pluggable.fixed.php 2011-09-27 18:19:21.283454810 +0200
@@ -394,8 +394,7 @@
}
// Plugin authors can override the potentially troublesome default
- $phpmailer->From = apply_filters( 'wp_mail_from' , $from_email );
- $phpmailer->FromName = apply_filters( 'wp_mail_from_name', $from_name );
+ $phpmailer->SetFrom(apply_filters('wp_mail_from', $from_email),apply_filters('wp_mail_from_name', $from_name));
// Set destination addresses
if ( !is_array( $to ) )
}}}
" pigster
Needs Milestone 20609 tags in Editor not working on editing with wp_editor, wenn disabling media_buttons or quicktags Editor normal normal Awaiting Review defect (bug) new 2012-05-03T16:36:01Z 2012-05-05T01:01:57Z "When disabling the media_buttons or quicktags via the third argument in wp_editor via a settings array,
tags are not displayed any more, so there are no line breaks any more in the editor. Only "" "" is in the source code. The Problem also occurs, when changing 'quicktags' or 'media_buttons' in class-wp-editor.php in the core to false. wpautop is still true.
" julian42
Needs Milestone 20620 create redirect_media_location filter in media.php Media normal normal Awaiting Review enhancement new 2012-05-06T07:54:09Z 2012-05-06T07:54:09Z Similar to the post.php redirect_post_location filter, media.php could use a redirect_media_location filter. This is useful for plugins that want to edit an attachement and redirect back to a specific place. Sjeiti
Needs Milestone 20630 XML-RPC Extending documentation for methods called with a single param XML-RPC normal normal Awaiting Review defect (bug) new needs-docs 2012-05-07T18:47:46Z 2012-05-07T19:06:01Z "When an XML-RPC method is called with a single parameter, the method will receive the value directly instead of receiving an array with a single value. This seems to be intended, though unexpected, behavior. The documentation should be updated to mention this.
The related code is inside IXR_Server->call()." scott.gonzalez
Needs Milestone 20631 Add ability to add Contextual Help to the Theme Customizer Themes 3.4 normal normal Awaiting Review enhancement new 2012-05-07T20:11:39Z 2012-05-07T20:55:18Z While this is probably more complicated than I realize, it would be good to add the ability for contextual help in the admin side of the Theme Customizer. This would enable explanations of the various core features as well as any additional custom features by theme developers. wpsmith
Needs Milestone 17157 Cannot preview changes to published multi-page posts General 3.0.4 normal normal Awaiting Review defect (bug) new has-patch 2011-04-17T17:41:50Z 2012-05-09T17:10:23Z "Use Case: After publishing a post, an editor needs to make changes/update the post. Editor would like to preview changes before publishing. (Permalinks are turned on in this case)
To Reproduce:
1. Write a post. Make it paged by putting somewhere in the post.
2. Publish the post
3. Make changes to the post, somewhere on page 2
4. Click ""Preview Changes"" button
Browser will open a new page for the post: http://[domain]/yyyy/mm/dd/[post title]/?preview=true&preview_id=126507&preview_nonce=f0a2ecd9ae
5. Next page link will point to http://[domain]/yyyy/mm/dd/[post title]/ (Note: that preview, preview_id and preview_nonce are missing from the url)
Suggested fix is attached.
" akoyfman
Needs Milestone 20651 Inconsistent MS API: delete_site_option action hook is only called AFTER deletion, unlike delete_option Multisite 3.3.2 normal normal Awaiting Review enhancement new dev-feedback 2012-05-10T09:54:37Z 2012-05-11T16:30:39Z "Unlike the delete_option action hook, the delete_site_option action hook is only called AFTER deletion of the row from the sitemeta table - making it difficult to capture the expiring value (for instance), unless you know its precise option key name ( and hook it using pre_delete_site_option_{$option} ).
Suggest introducing a pre-deletion, non-specific action hook call named ""pre_delete_option"" for options and ""pre_delete_site_option"" for site options, for consistency." danielnashnz
Needs Milestone 20661 Add help text for search usage in Multisite User browsing Help/About normal normal Awaiting Review enhancement new has-patch 2012-05-11T18:32:34Z 2012-05-12T04:40:21Z "Search on the Network Users page defaults to wildcards disabled by default. This may not be expected functionality by a lot of end users, so I think some notes on how to use search should help.
Related: #20135" ericlewis
Needs Milestone 17382 XMLRPC wp_getUsersBlogs Scalability XML-RPC 3.0.1 normal normal Awaiting Review defect (bug) new 2011-05-11T20:32:15Z 2012-05-13T16:16:46Z "If there is a root blog with many sub blogs on it and a user that is an admin on each sub blog, then when the when the XML RPC method wp_getUsersBlogs() is called it does not scale very well. My PHP memory_limit setting was 128MB, and the XML RPC request died when a user was a member of 230+ blogs. I noticed that the number of queries made to the database for a single user that has many blogs that they are an admin is very high.
Affected line: http://core.trac.wordpress.org/browser/tags/3.0.1/xmlrpc.php#L443
I don't know exactly how the code would have to change so I am not providing a patch." bmorneau
Needs Milestone 20672 Mime-Type Matching Error With Certain Added Mime-Types Media 3.0 normal normal Awaiting Review defect (bug) new has-patch 2012-05-14T09:50:10Z 2012-05-14T11:11:54Z "I think I've found a bug in the handling of post_mime_types with certain legitimate file MIMEs. My suspicion is that the problem is related or similar to that reported in [http://core.trac.wordpress.org/ticket/17855 #Ticket #17855], and apparently fixed in Wordpress v3.2.
The particular problem I've been experiencing only becomes apparent when adding MIME-types to the $post_mime_types array via the ''post_mime_types'' filter hook. For example, the following is a legitimate MIME-type:
''application/vnd.google-earth.kml+xml''
However, if I add the MIME to post_mime_types array with:
{{{
function kml_modify_post_mime_types( $post_mime_types ) {
$post_mime_types['application/vnd.google-earth.kml+xml'] = array(__('KML'), __('Manage KML'), _n_noop('KML (%s) ', 'KML (%s) '));
return $post_mime_types;
}
add_filter( 'post_mime_types', 'kml_modify_post_mime_types' );
}}}
in my plugin, I don't see a filter link at the top of the Media list (like the ones for Video, Audio etc.), as I should do. I may be wrong, but I think this is because the '+' character in the attachment MIME-type is not handled correctly.
To test this, I tried faking a new MIME, minus the '+'. I changed the MIME-type my plugin add to the post_mime_types array to
{{{
$post_mime_types['application/vnd.google-earth.kmlxml'] = array(__('KML'), __('Manage KML'), _n_noop('KML (%s) ', 'KML (%s) '));
}}}
then changed the value in the MIME field of a previously-uploaded KML file to the same (''application/vnd.google-earth.kmlxml''). Now I DO see the filter link, and clicking on the link reveals the KML file as the only item in the filtered list, as it should.
I'm not sure if the problem manifests itself anywhere else. I've not found any evidence it does, but it may well do. From doing some multi-file searches on the WP system files, my suspicion is that the problem is with one or both of the following functions in post.php:
* wp_match_mime_types()
* wp_post_mime_type_where()
but I'm really not sure.
I'd be grateful if a more skilled coder than me could confirm if this is actually a bug. I'm afraid my regular-expression understanding is minimal, but I suspect this might be an easy fix for someone who knows their stuff.
I'm more than happy to run any tests anyone might suggest to help pin down the source of the problem and/or help fix it.
Thanks guys.
a|x" toneburst
Needs Milestone 18450 New safe action to add rewrite rules on Rewrite Rules 3.2.1 normal normal Awaiting Review enhancement new dev-feedback 2011-08-16T19:56:10Z 2012-05-14T19:44:58Z "Currently I don't believe it's possible to meet the following two criteria:
* Not flush rewrite rules on every page load
* Ensure that you always have your rewrite rules available
The problem arises when Plugin A has not yet added it's rewrite rules, but Plugin B calls ```flush_rewrite_rules```. Plugin A is a good citizen, and doesn't call ```flush_rewrite_rules``` unless it needs to and so now it's rewrite rules are no longer present. (See http://wordpress.stackexchange.com/questions/26029/when-to-call-add-rewrite-rule-for-safety for more.)
Westi suggested that hooks on delete_option and get_option of 'rewrite_rules' might work. This covers almost all situations, except the one where permalinks are off and then get turned on again when neither the delete_option or get_option actions/filters are fired.
Devs could hook the new action for their ```add_rewrite_rule``` calls, and use their own methodology to determine when to call ```flush_rewrite_rules```.
Two attachments:
* Example plugin, showing (hopefully) the problem with the existing situation
* Diff showing where the hook might be added
" simonwheatley
Needs Milestone 20214 Pingback discovery doesn't strip fragment identifiers from URL Pings/Trackbacks 3.3 normal normal Awaiting Review defect (bug) new has-patch 2012-03-11T08:34:46Z 2012-05-14T20:44:41Z "To reproduce:
1. Insert a link containing a fragment identifier into a post, e.g., `http://localhost/wp/helloworld/#comments`.
2. Save post.
3. Observe the URL which !WordPress attempts to retrieve in `discover_pingback_server_uri()` - the requested path contains the `#fragment_identifier`, which it shouldn't, and in most cases will result in a 404, thus the pingback fails." solarissmoke
Needs Milestone 20606 orderby rand param does not work with either WP_User_Query or get_users Users 3.2.1 normal normal Awaiting Review feature request new 2012-05-02T22:12:34Z 2012-05-15T19:20:21Z "Using WordPress 3.2.1
{{{
$contributors = get_users(array('role' => 'contributor', 'orderby' => 'rand', 'number' => 3));
}}}
{{{
$wp_user_search = new WP_User_Query(array('role' => 'contributor', 'orderby' => 'rand', 'number' => 3));
$contributors = $wp_user_search->get_results();
}}}" kjmeath
Needs Milestone 20523 Disable autoloader when using class_exists() General 3.3.1 normal normal Awaiting Review feature request new 2012-04-23T10:08:32Z 2012-05-16T01:07:04Z "A couple of files inside the /wp-includes/pomo directory use class_exists() the wrong way, for example in /wp-includes/pomo/entry.php :
{{{
if ( !class_exists( 'Translation_Entry') ):
}}}
It should be:
{{{
if ( !class_exists( 'Translation_Entry', false) ):
}}}
The second parameter 'false' disables autoloading. This is important because I'm integrating some WP functions into another existing website which already comes with an Autoloader for some classes = confusion.
This should be easy to fix. Thanks :)
" michael.heuberger
Needs Milestone 20688 Forward slash in custom taxonomy rewrite causes 404s because of (unnecessary?) attachment rule Rewrite Rules 3.3.2 normal normal Awaiting Review defect (bug) new 2012-05-16T09:07:57Z 2012-05-16T11:54:34Z "I implement a custom taxonomy with a rewrite that is designed to create urls like:
""/apps/about/sometag""
{{{
$name = 'apps';
register_taxonomy($name.'-tag', $name.'-post', array(
'label' => ucfirst($name) . ' Tags',
'public' => true,
'has_archive' => true,
'hierarchical' => false,
'update_count_callback' => '_update_post_term_count',
'rewrite' => array('slug' => ""$name/about"", with_front=>true)
));
}}}
However I was getting a 404 (yes I was flushing the rules) unless I changed the '/' to say a '-'. Upon inspection of the rules, I found this one whose precedence was causing the problem:
{{{
'apps/[^/]+/([^/]+)/?$' => 'index.php?attachment=$matches[1]'
}}}
Upon removing it inside the ""rewrite_rules_array"" hook, the problem was solved.
It seems odd to me that this generic rule exists and rewrites to an attachment of all things..." harikaram
Needs Milestone 20690 add_post_meta/update_post_meta and cache General 3.3.2 normal normal Awaiting Review defect (bug) new 2012-05-16T14:33:30Z 2012-05-16T14:33:30Z "I have a custom post type with 2 fields for price, second one has 5% discount and I want to populate it automatically by hooking to 'save_post'.
I have a working logic that calls update_post_meta() (or add_post_meta() ) for the second field but it doesn't get executed even with several post updates. However, if I end my function call with a var_dump that outputs the values from the function, everything goes smooth.
It looks like some caching issue to me that gets flushed per var_dump call, anyone able to reproduce?" nofearinc
Needs Milestone 20223 simulate mysql_real_escape_string when not yet connected to DB Database 3.3.1 normal normal Awaiting Review enhancement new has-patch 2012-03-13T09:16:53Z 2012-05-16T19:49:33Z "Currently wpdb::_real_escape() falls back to addslashes() when you're not yet connected to the database
Instead, have it fall back to a closer mimic of mysql_real_escape_string():
Use this to make patch:
http://pastebin.com/5vMaBhQe
Reference:
http://dev.mysql.com/doc/refman/5.0/en/mysql-real-escape-string.html
http://www.php.net/manual/en/function.mysql-real-escape-string.php" scottconnerly
Needs Milestone 19864 Abstract export_wp() for use by CLI scripts Export 3.3.1 normal normal Awaiting Review enhancement reopened 2012-01-20T18:16:17Z 2012-05-20T04:15:19Z "Need to be able to execute an export from the PHP CLI for the purpose of running cron / maintenance scripts that write out exports.
This would include writing additional hooks that allow the arguments to be pulled from the cli as well as hooks that allow the output to redirected from the output buffer to a file.
Related ticket: #19863, extra hooks for manipulating content and arguments of an export" scottconnerly
Needs Milestone 20663 add_image_size needs a $label Media 3.3.2 normal normal Awaiting Review enhancement new 2012-05-12T20:47:31Z 2012-05-21T00:05:59Z "add_image_size() does not have a $label parameter, this effects both localization but more importantly limits the `image_size_names_choose` filter.
The is when you try to add an image to a post and you can select sizes via the radio buttons.
Default sizes have labels like: `'large' => __('Large')`
the `image_size_names_choose` filter is a great new filter that allows you to alter those radio buttons, but requires you to hardcore the array values for add_image_size() since it does not have a label (unless I'm missing something).
Reference code: https://gist.github.com/2668630
Related: #19990" wycks
Needs Milestone 20716 Control how and when request_filesystem_credentials outputs creds form Filesystem 3.4 normal normal Awaiting Review enhancement new reporter-feedback 2012-05-21T02:02:08Z 2012-05-21T02:05:10Z "When using WP_Filesystem in a plugin or other external app, you can initialize it this way:
{{{
if ( false == ( $creds = request_filesystem_credentials( $url, $method, false, false, $form_fields ) ) ) {
return true;
}
}}}
Makes sense. If the method isn't direct or we don't have the credentials we need, `request_filesystem_credentials` outputs a form and returns false. Then we check again to make sure the credentials can be verified, and it not, we continue to output the form until the credentials are good.
{{{
if ( ! WP_Filesystem( $creds ) ) {
request_filesystem_credentials( $url, $method, true, false, $form_fields );
return true;
}
}}}
`request_filesystem_credentials` arbitrarily outputs the form whether you want it to or not, unless you explicitly filter the `request_filesystem_credentials` function itself. Using this in conjunction with Ajax, you have to use output buffering to catch the output and return it to the Ajax script for processing or else you get errors. This definitely isn't ideal.
I'd suggest storing the form in a variable and possibly pass a parameter that determines whether or not we want to actually output the form or not. Or, if there is another (better) way, that's cool too. Just some way to help `request_filesystem_credentials` determine how we want to interact with credentials should we need them.
" griffinjt
Needs Milestone 20720 attachment_fields_to_save filter is called twice after initial image upload in post Media 3.3 normal normal Awaiting Review defect (bug) new has-patch 2012-05-21T16:18:41Z 2012-05-22T00:12:20Z "I believe I found a bug in WordPress with the attachment_fields_to_save filter. For some reason attachment_fields_to_save is called twice per image, but only if you ""Save all changes"" after uploading a new image to a post.
How to reproduce:
1. Add the below code to a plugin:
{{{
add_filter( 'attachment_fields_to_save', 'test_attachment_fields_to_save', 10, 2 );
function test_attachment_fields_to_save( $post, $attachment ) {
echo 'Hi! ';
return $post;
}
}}}
2. Create a new post
3. Upload a single image and click ""Save all changes""
You'll see ""Hi!"" displayed twice. Now visit the Gallery tab and save the same image and you'll see ""Hi!"" is only displayed once. This only happens when you save a new image uploaded to a post. If you save an image under the Gallery tab, or via the Media Library, the filter is only called once as expected.
I confirmed this is happening in 3.3.1 and trunk" williamsba1
Needs Milestone 20725 Media library inconsistency General 3.3.2 normal normal Awaiting Review enhancement new 2012-05-22T10:26:45Z 2012-05-22T10:26:45Z "I need to put extra filters using restrict_manage_posts to Media library and i have noticed, that my filters did not appear on Media library iframe, opened when adding new media in post. It is handled with wp-admin/includes/media.php via media_upload_library_form function, which seems to be very old comparing to media library in class-wp-media-list-table
e.g. it does not use $this->months_dropdown( 'attachment' ); but wrotes 25 rows of code which do the same.
IMO it could be migrated to the new code
also it misses the
do_action( 'restrict_manage_posts' );
line, which is important for my desired functionality (when i hardcode it there, it works)" thomask
Needs Milestone 20659 Document available shortcodes in eg. new post page Shortcodes normal normal Awaiting Review feature request new 2012-05-11T14:40:28Z 2012-05-22T12:40:35Z "It would be useful if a plugin defining shortcodes also could describe the usecase for the shortcode and the available attributes and the usecases for those attributes in a way that could be exposed in the interface on eg. the new post page.
One could take inspiration from eg. the Drupal Token module which has a token_list() hook that a Drupal module uses to describe every token it describes so that they can be presented to the user in the interface.
Something like:
{{{
add_shortcode_description('shortcodename')
}}}
That returns something like this would be nice:
{{{
array(
'description' => 'This is used to do foo',
'attr' => array(
'bar' => 'A text that will be presented as bar'
),
);
}}}" voxpelli
Needs Milestone 20730 make function wp_list_categories rewritable for templates (File: category-template.php) Template normal normal Awaiting Review feature request new 2012-05-22T17:34:02Z 2012-05-22T17:36:35Z "Inserting
{{{
$list_categories_template = locate_template(array('listcategories.php'));
if ( '' != $list_categories_template ) {
require($list_categories_template);
return;
}
}}}
under
{{{
function wp_list_categories( $args = '' ) {
}}}
" wpuser12584
Needs Milestone 20735 Adding tags to form element of categories. Taxonomy 3.3.2 normal normal Awaiting Review feature request new 2012-05-23T13:15:59Z 2012-05-23T13:15:59Z "Just like the post form in posts you can use the hook of ""post_edit_form_tag"" to add new tags to the form element of creating or editing new post.
but there is no hook for categories form to do that I think adding new element will be helpful feature.
Note: after some debugging I found that the hook can be add in:
#File: your wordpress directory/wp-admin/edit-tag-form.php
#Line: 33
# Find :
}}}
In wordpress 3.4.1 field 'action' changes to 'update', because $_REQUEST['action']. In wordpress 3.3.2, field 'action' is 'mysettings_save'.
I have to redo all my work with my plugin with this change in Wordpress 3.4.1. " vdvtt
Needs Milestone 21268 _wp_page_template is getting 'stuck' to a page General 3.4.1 normal normal Awaiting Review defect (bug) new 2012-07-13T22:21:42Z 2012-07-13T22:21:42Z "Unmodified WP 3.4.1 / Ummodified TwentyEleven theme
Create a page (id=2). Manually add a postmeta entry for
{{{
post_id=2,
meta_key = _wp_page_template,
meta_value = pagefull.php
}}}
The page now opens with margin: 0 7.6%; (correct!)
Now try to change it back to default, either by removing the _wp_page_template postmeta record or by editing the page -> Page Attribute / Template. The page will not revert back to Default. It continually displays as Full Width, and a postmeta item telling post_id 2 to use _wp_page_template = pagefull.php is added.
http://wp34.roveridx.com/?page_id=2
This behavior does not happen in 3.3.2." shawmutsteve
Needs Milestone 17142 Prettier gallery display and navigation through core Gallery 3.3 normal normal Awaiting Review feature request reopened 2011-04-15T16:14:13Z 2012-07-13T22:44:10Z "WordPress gallery display and navigation typically feels rather crude from the user point of view. With digital cameras dumping images as IMG_XXXX or long numeric strings, the default image titles are usually prominent and ugly in most of the themes I've tested (see attachments for examples). Some themes use thumbnail navigation instead, but those implementations also feel dated in many (most?) cases.
I realize that the theory is display/navigation is determined by the themes, and that display/navigation can be greatly altered via various plugins... but the reality of how this plays out results in a default user experience that simply feels outdated.
Many (most?) themes seem pretty unimaginative in their gallery output and IMHO a more elegant out-of-the-box display and navigation experience seems like it would really be useful for all WordPress users. I would think most users expect something like a Lightbox experience at minimum, but I am not ideologically tied to any particular solution.
Is there something we could do on the core side to strongly encourage (or even gently enforce) a prettier default construct?
" hew
Needs Milestone 21266 Enhancements for page numbers links API Permalinks 3.4.1 normal normal Awaiting Review enhancement new has-patch 2012-07-13T20:59:17Z 2012-07-14T21:47:23Z "Currently WordPress provides few functions to create links with page numbers embedded. Unfortunately they have some limitations:[[BR]]
- `get_pagenum_link()` - works on `$_SERVER['REQUEST_URI']` only;[[BR]]
- `get_comments_pagenum_link()` - works on current post only;[[BR]]
- `_wp_link_page()` - works on current post only, returns HTML code and is private.
Because of these limitations in the past I have reimplemented these functions in my SEO plugin. Now I decided that it will be better if WP core will provide needed functionality.
Attached path introduces following changes for functions:[[BR]]
- `get_pagenum_link()` - added new `$url` param, which can be used to pass any URL to function;[[BR]]
- `get_comments_pagenum_link()` - added two new params: `$post` and `$add_anchor`. The former one allows to pass any post object to function, the latter one tells function if it should append `#comments` at the end of URL;
- `get_post_page_link()` - new function. I moved code from `_wp_link_page()` here and modified it so it can work on any post. Additionally it calls new filter `get_post_page_link` before returning value.[[BR]]
Additionally these functions passes new argument(s) to filter at the end, so it will be easier for plugins to generate different pagination URLs.
I also modified `_wp_link_page()` function (now it calls `get_post_page_link()`) and removed `@access private` from `wp_link_pages()` (as I checked, it is called from themes code only)." sirzooro
Needs Milestone 21243 move password hint text to a function General normal normal Awaiting Review enhancement new has-patch 2012-07-12T16:56:24Z 2012-07-16T02:52:21Z "The password hint text, noted below, is hard coded in four places:
{{{
wp-admin/install.php
wp-admin/user-edit.php
wp-admin/user-new.php
wp-login.php
}}}
{{{
Hint: The password should be at least seven characters long. To make it stronger, use upper and lower case letters, numbers and symbols like ! "" ? $ % ^ & ).
}}}
This approach is prone to mistakes when changes are made. In addition, plugins that want to override the text need to use the resource intensive and clumsy gettext filter.
Per nacin and westi, the attached patch moves the text to a function ({{{wp_password_hint()}}}) in {{{wp-includes/user.php}}} and adds a filter ({{{password_hint}}})." convissor
Needs Milestone 21207 Link-template pagination link for page 1 missing query string args Template 3.4 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-07-09T20:28:25Z 2012-07-16T14:38:37Z "In paginated pages, when on a page that is greater than page 1, the link for page 1 and the 'previousposts' link do not include any query arguments. This is fine if not including the first page argument, but not for other arguments in the query string.
For example pages that show results for form searches. The search criteria are stored with the GET method as query strings in the URL and need to be maintained from page to page as the user pages through their results.
This is in /wp-includes/link-template.php on line 1421.
A probable fix is the 'if' clause from if( $pagenum > 1 ) changed to if( $pagenum > 0 ).
I was wondering if you can apply this fix to future updates?
Thanks" alexk45
Needs Milestone 21304 Create unique file for rotated images Media normal normal Awaiting Review enhancement new 2012-07-18T16:31:06Z 2012-07-18T16:31:06Z When images are cropped in WordPress, the resulting file is given a unique filename, which helps in two ways — the original is preserved, and it also busts any caching. Preserving the original isn't such a major concern when we're talking about rotating the image, but caching still can be an issue. I propose that when images are rotated they're given a unique filename to bust through any caching or CDN that the image has already gone to. wpdavis
Needs Milestone 21306 "Archived blogs should return HTTP ""404 Not Found"", not ""410 Gone""" Multisite normal normal Awaiting Review defect (bug) new has-patch 2012-07-18T19:39:51Z 2012-07-18T19:39:51Z "In a multisite network, if a site is archived, ms_site_check() currently serves up a HTTP 410 status code. Here's what the [http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html HTTP spec] has to say about 410:
The requested resource is no longer available at the server and no forwarding address is known. This condition is expected to be considered permanent. Clients with link editing capabilities SHOULD delete references to the Request-URI after user approval. If the server does not know, or has no facility to determine, whether or not the condition is permanent, the status code 404 (Not Found) SHOULD be used instead. This response is cacheable unless indicated otherwise.
It's acceptable to serve a 410 if the site is marked as deleted or spam, but I don't think that archiving the site is an indication that the site is permanently and irrevocably gone. Although a case can be made for changing it to 404, my contention is that a 403 is more appropriate for semantics and for bots. From the same HTTP spec:
403 Forbidden: The server understood the request, but is refusing to fulfill it.
vs
404 Not Found: The server has not found anything matching the Request-URI." amattie
Needs Milestone 20592 Add hooks to New Site form in Dashboard Multisite normal normal Awaiting Review enhancement new 2012-05-01T18:53:16Z 2012-07-20T19:03:02Z "WordPress provides hooks for altering the wp-signup.php form that users use to create new sites on a MultiSite network. Using these, we developed a plugin that adds fields there for people to indicate some other information about their site. (specifically, to choose a topic)
However, there are no such hooks available on the New Site form available to network admins via the dashboard for some reason. This means that I am not able to append the extra form fields here that I can on the wp-signup.php page.
There should be similar (or identical) hooks used here so the New Site form can be modified in a similar way and be consistent with the wp-signup.php form." MadtownLems
Needs Milestone 18658 Allow apostrophe in email validation Users 3.2.1 normal normal Awaiting Review defect (bug) reopened has-patch 2011-09-14T09:23:38Z 2012-07-20T23:54:05Z "When the is_email function checks the format of a supplied email, it errors when it finds an apostrophe in the local part of the email address.
Many valid emails use apostrophe's, and as such this should be accomodated in the validation." swinhoe
Needs Milestone 21364 Pass post type to count_user_posts() General 3.0 normal normal Awaiting Review enhancement new has-patch 2012-07-24T08:22:14Z 2012-07-25T12:26:04Z Add $post_type argument to count_user_posts(). Defaults to 'post', as it is hard-coded now. Caspie
Needs Milestone 20717 Filter For Requiring Post Password Template normal normal Awaiting Review enhancement new has-patch 2012-05-21T03:37:43Z 2012-07-26T17:24:39Z "I've had the need to conditionally disable the password on a post based on criteria that I define in a plugin. In order to do this, I added a filter in the post_password_required() function in wp-includes/post-template.php. This is helpful to allow search engines to crawl password protected pages or allow certain users to view the page without typing in the password.
It would be great if this could get included in the core.
Thanks for your time." BrandonGodwin
Needs Milestone 21396 Categories widget reports categories without posts when they have custom posts Widgets 3.4.1 normal normal Awaiting Review defect (bug) new 2012-07-27T02:36:46Z 2012-07-27T04:27:26Z "This problem may be related to #14084, but this report is specific to the behaviour of the Categories Widget.
- Create a custom post type eg. ""Products""
- Create a category eg. ""Photographs""
- Add some posts of type Products, assign them to category Photographs
- go to the blog page and the Categories widget lists Photographs as a category
- click on Photographs
- the ""Nothing Found"" post is shown.
There are no normal posts of category Photographs, but the widget lists a category that returns nothing. I would have expected the widget not to list a category that has no normal posts.
" pkwooster
Needs Milestone 21403 Introduce wp_scandir, remove opendir / closedir code Filesystem 3.0 normal normal Awaiting Review enhancement new has-patch 2012-07-28T08:57:20Z 2012-07-29T18:29:23Z "There is {{{@opendir}}} code all over the place that is not standardized. On top of that, there is plenty of code that is duplicated and could be condensed into one handy function. Plus, in all of the places we are using {{{opendir()}}}, we really want to be using {{{scandir()}}}.
I have created a master function in {{{load.php}}} called {{{wp_scandir()}}} that does the basics:
* scans a directory for files / subdirectories
* filters list by extension(s)
* optionally returns ONLY files
This cleans up code in many places." wonderboymusic
Needs Milestone 21407 Allow filtering of upload resize dimensions Media 3.4.1 normal normal Awaiting Review enhancement new dev-feedback 2012-07-28T18:00:19Z 2012-07-29T19:29:25Z "Background:
Plupload ships with a client-side upload resizer that was included with Core in 3.3 but had the action removed because of [http://core.trac.wordpress.org/ticket/19174 browser inconsistencies] so I implemented it as [http://wordpress.org/extend/plugins/enable-image-scaling-option-on-upload/ a plugin] at the time. Everything works just fine and dandy with zero problems except that the `resize_height` and `resize_width` vars are defaulted to the Large image sizes defined in media settings. It would be nice to be able to filter one or both of the dimensions outside the scope of the 'Large' size (when 'Original' becomes the same size as 'Large', you effectively lose an image size).
Patch attached.
You'll have to re-add this action to test:
`add_action( 'post-upload-ui', 'media_upload_max_image_resize' );`
Related: #19174, #19770" DrewAPicture
Needs Milestone 18850 hidden admin page Administration normal normal Awaiting Review enhancement new 2011-10-03T21:43:12Z 2012-07-30T16:22:40Z "it should be possible to create a hidden admin page.
this is useful for pages, that require parameters which are better inserted in other pages (e. g. using the post_row_actions filter).
if this is already possible, it should be documented somewhere where it might be found.
(btw: i'm not sure, what the difference between feature request and enhancement is. please redeclare as fit)" ibotty
Needs Milestone 21412 Hookable dropins Cache normal normal Awaiting Review enhancement new dev-feedback 2012-07-29T03:59:34Z 2012-07-30T22:12:02Z "This ticket is the result of a discussion on the wp-hackers list where I proposed the idea in [http://lists.automattic.com/pipermail/wp-hackers/2012-July/043772.html this message].
Currently for dropins there can be only one[1] per install which means that, especially for `advanced-cache.php` where multiple plugins cannot easily:
- Cache different mime types with different plugins
- Provide basic functionality and leave the complexity to other plugins because hooks are not available ''(this is likely needed for a good page caching API to ever emerge from the work of plugins.)''
For caching this results in plugins like WP Super Cache and WP Total Cache that significantly violate a sancrosact WordPress philosophy of ''""[http://wordpress.org/about/philosophy/#decisions Decisions, not Options]''"". To see what I mean, just visit the settings page for either of these plugins. ''(Note: I'm not criticizing the plugins or their developers, instead saying that WordPress doesn't give them much of a choice.)''
It turns out however that fixing this is really lightweight and easy, at least for `advanced-cache.php`. I will attach the following files but here is the short list of changes to core required:
- Move the hooks-related function out of `/wp-includes/plugin.php` into another file which I called `/wp-includes/hooks.php` and include `/wp-includes/hooks.php` in `/wp-settings.php` close to the top after `/wp-includes/versions.php` is included.
- Include another new file `/wp-includes/dropsin.php` in `/wp-settings.php` after `/wp-includes/hooks.php` which contains a `wp_load_dropins()` function that `include()`s all `.php` files found in `/wp-includes/dropins/`.
- Lastly add the following two (2) lines before `advanced-cache.php` is included:
{{{
// Load any potential dropins found /wp-content/dropins/
wp_load_dropins();
// Run the hook-based page cache.
do_action( 'page_cache' );
}}}
With this future caching plugins can implement the page_cache hook by dropping a file into `/wp-content/cache/` instead of adding an `/wp-content/advanced-cache.php`.
If this idea is blessed then we could add a deprecation notice for `/wp-content/advanced-cache.php` and also potentially replace (some of) the other dropins with `do_actions( ""{$dropin_hook}"" )`.
[1] [http://www.urbandictionary.com/define.php?term=%22there%20can%20only%20be%20one%22%20 Gratuitous Highlander reference]." mikeschinkel
Needs Milestone 20854 functions.php on line 155 ? Nikolaos Raftopoulos Multisite 3.3.2 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-06-06T12:45:29Z 2012-07-31T02:42:37Z "In my network dashboard I get the following error message :
Warning: number_format() expects parameter 1 to be double, string given in /home/tklighth/public_html/wp-includes/functions.php on line 155" leondari
Needs Milestone 21452 When uploading media wp_unique_filename() treats capitalisation as being different. Filesystem 3.4.1 normal normal Awaiting Review defect (bug) new 2012-08-02T13:24:11Z 2012-08-02T13:24:11Z "On most web servers ""Photo.jpg"" and ""photo.jpg"" can be treated as different files.
The problem is when backing up a local copy (to my Mac) it will not let both these files exist at the same time - it wants to replace one with the other as it treats lowercase and uppercase as the same.
I suggest that we should do the same with uploads so that if ""Photo.jpg"" exisits and you upload ""photo.jpg"" is is renamed to a unique name.
I guess this would require a fix in the wp_unique_filename() function." husobj
Needs Milestone 21453 Appending hyphen before numbers when creating a create unique filename in wp_unique_filename() Filesystem 3.4.1 normal normal Awaiting Review enhancement new 2012-08-02T13:32:00Z 2012-08-02T13:32:00Z "When WordPress appends a number to a file to create a unique filename, it just adds a number to the file.
ie If ""photo.jpg"" exists then ""photo1.jpg"" is created
I suggest that it should include a hyphen so the file would be called ""photo-1.jpg""
The main reason is that if you upload files ending in numbers then then the new filename is less easy to read.
ie If ""photo234.jpg"" exists then ""photo2341.jpg"" is created
Would be nicer if it produced ""photo234-1.jpg""
It's only cosmetic but it does make it easier to search for images in the uploads folder if you need to for any reason, especially if you have uploaded a load of images from a camera DSC123.jpg, DSC124.jpg etc" husobj
Needs Milestone 21448 unfiltered HTML comments from a frame js fix breaks js in windowed comments Comments 3.4.1 normal normal Awaiting Review defect (bug) new has-patch 2012-08-01T21:58:53Z 2012-08-02T17:56:36Z "Noticed this today.
We have comments loading up in a jquery colorbox on a site being developed and it loads the comment form via ajax. When it's loaded, the fix in #20812 breaks javascript because the property ""name"" is null.
Attaching a patch after posting this for only executing when `document.getElementById(""_wp_unfiltered_html_comment_disabled"")` != null." nerrad
Needs Milestone 21460 The accesskeys in Quicktags don't work in all browsers Editor normal normal Awaiting Review defect (bug) new 2012-08-03T19:21:56Z 2012-08-03T22:01:43Z "IE (Alt+letter) works properly. Firefox (Alt+Shift+letter) only focuses the corresponding Quicktags button sometimes. Doesn't perform the action. If the button is hidden, performs the action (this shouldn't happen in Quicktags). Chrome doesn't seem to do anything. Opera works differently: Shift+Esc brings a list of all defined access keys on that page. The Quicktags access keys are not listed there.
" azaozz
Needs Milestone 21470 Wrong menu when no menu is set Menus 3.4.1 normal normal Awaiting Review defect (bug) new 2012-08-05T13:27:13Z 2012-08-05T13:59:30Z In the case if the admin hasn't created any menu in the dashboard (and so the default menu is shown), some parameters of wp_nav_menu() don't work. I verified that 'container'=>false does not work. Other parameters may no work as well. porton
Needs Milestone 17812 "media_upload_form_handler runs twice when editing attachment from ""From Computer"" media upload tab (browser uploader)" Upload 3.1.3 normal normal Awaiting Review defect (bug) new has-patch 2011-06-15T18:48:58Z 2012-08-05T22:14:25Z "After uploading a new media item ""From Computer"" using the browser uploader, you are presented with a form to edit its fields.
Clicking ""Save all changes"" from this form causes {{{media_upload_form_handler}}} to run, then {{{media_upload_gallery}}} (presumably to redirect to the gallery tab), which then causes {{{media_upload_form_handler}}} to run again.
This can cause problems for {{{edit_attachment}}} actions that only run once and alter the posts table row for that attachment (since the subsequent {{{media_upload_form_handler}}} could overwrite whatever changes were made in the action if they don't match whats in {{{$_POST}}}).
If the only reason {{{media_upload_gallery}}} is being called from the other type upload handler is to redirect to the gallery tab.. perhaps this patch is a better approach." jeffstieler
Needs Milestone 18995 Superfluous check in WP_Users_List_Table::display_rows() Users 3.2.1 normal normal Awaiting Review defect (bug) new has-patch 2011-10-19T01:21:11Z 2012-08-05T22:25:26Z "Specifically, this one:
{{{
if ( is_multisite() && empty( $role ) )
continue;
}}}
It seems to have been a misguided attempt to fix something that should have been (and currently is) handled at the SQL level: #12711" scribu
Needs Milestone 21168 Add ability to remove a parent theme's page templates General normal normal Awaiting Review enhancement new 2012-07-05T19:32:31Z 2012-08-05T23:54:15Z "When building a website using a child theme, I'll often want to remove page templates that the parent theme provides but aren't useful/relevant to the specific site I'm building.
You can create a page template with the same name to override the parent theme's, but you can't simply remove it.
This could be a use case of #13265, or we could add function that leverages #13265" billerickson
Needs Milestone 20157 "Gallery: define a ""Cover image"" that will appear in archive pages or a blog home page" Themes normal normal Awaiting Review enhancement new has-patch 2012-03-02T18:04:09Z 2012-08-06T00:00:27Z "Today, if you create a gallery with X images, you cannot define one specific image to appear as cover image for the whole gallery.
Couldn't we use {{{the_post_thumbnail}}}, and say that the cover of the album is the Featured image when there is one defined?
That's something that can be defined in the theme (see file attached), but I think it would be nice to have an option in core to define a cover image for each gallery.
What do you think?" hd-J
Needs Milestone 21442 Themes: change allowed term taxonomy from Width to Layout and add responsive-layout term Themes normal normal Awaiting Review enhancement new has-patch 2012-08-01T17:48:53Z 2012-08-06T00:18:10Z "See #21065 and discussion with WPTRT on http://make.wordpress.org/themes/2012/07/18/id-love-your-thoughts-on-adding-two-new/.
""Width"" is not accurate since themes can have fluid, fixed, or responsive height as well as width.
""Layout"" makes this more abstract." lancewillett
Needs Milestone 21492 Theme customizer > Static front page: missing error message when front page and posts pages are similar Appearance normal normal Awaiting Review defect (bug) new 2012-08-06T00:15:25Z 2012-08-06T01:11:40Z "Steps to reproduce:
1. Activate Twenty Eleven
2. Open the Customizer
3. In ""Static Front page"", choose the same page as your front page and Posts page:
* You do not receive any warning
* http://i.wpne.ws/IYAO
* In Reading Settings, you do actually receive a warning: http://i.wpne.ws/IY2S (see http://core.trac.wordpress.org/browser/trunk/wp-admin/options-reading.php#L99 )
Would it be possible to display the same warning in the Customizer, to avoid any confusion for the users?
Related: #19627 and #16379" hd-J
Needs Milestone 21428 Bad mail subject encoding on new blog notification Multisite 3.4.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-07-31T14:02:59Z 2012-08-07T11:43:45Z "Email subject is in Russian language. When trying to add new blog using page http://mysite.com/wp-admin/network/site-new.php, user gets email where subject is like - '''=??B??='''. So I was trying to find where this bug appears. And I think, I found it.
Script tries to send notification using function '''wpmu_welcome_notification''' on line http://core.trac.wordpress.org/browser/tags/3.4.1/wp-includes/ms-functions.php#L1250. But '''get_option('blog_charset')''' returns empty string, so header is bad-generated and encoded..." TheSteelRat
Needs Milestone 21510 Use get_background_color() in _custom_background_cb() Themes 3.4.1 normal normal Awaiting Review defect (bug) new has-patch 2012-08-07T17:57:52Z 2012-08-07T21:53:35Z "When themes add a default background color via the `custom-background` feature, it isn't shown until the user saves it in the admin. The issue is that the `_custom_background_cb()` uses `get_theme_mod( 'background_color' )` instead of `get_background_color()`, which will handle the default.
The attached patch should correct this." greenshady
Needs Milestone 21446 plugins using curl with IPV6 enabled servers HTTP 3.4.1 normal normal Awaiting Review enhancement new close 2012-08-01T21:46:28Z 2012-08-09T10:41:24Z "
plugins using curl give problems on servers having both IPV4 and IPV6 network interfaces running. Basically the performance is poor because curl is timing out on the IPv6 address.. The workaround is:
add line:
curl_setopt( $handle, CURLOPT_IPRESOLVE, CURL_IPRESOLVE_V4);
in ../wp-includes/class-http.php
Why not have this set as default?
" mippie32
Needs Milestone 21526 get_post_type_capabilities() assumes $args->capabilities is an array Role/Capability normal normal Awaiting Review defect (bug) new dev-feedback 2012-08-09T12:29:01Z 2012-08-09T12:46:39Z "get_post_type_capabilities() assumes $args->capabilities is an array and should check and confirm it. Otherwise a warning appears: Warning: array_merge() [function.array-merge]: Argument # 2 is not an array in /home/username/public_html/wp-includes/post.php on line 1183. I discovered this when I accidentally set this to null instead of array().
Type setting it seems to clear the warning, if we want to clear the warning.
{{{
$capabilities = array_merge( $default_capabilities, (array)$args->capabilities );
}}}
" wpsmith
Needs Milestone 18944 wrong url in sortable column headers when behind a reverse proxy General 3.2.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2011-10-14T11:50:57Z 2012-08-09T18:33:29Z "Hi, I have a wordpress site behind a reverse proxy. All works fine but for the urls used in the headers of sortable columns.
For instance, the links of ""Title"", ""Author"", etc. of the table of posts in wp-admin/edit.php --> Posts report something like ""http://backend/backend-dir/..."" while they should be ""http://frontend/frontend-dir/..."".
I don't think this is a proxy configuration problem because, AFAICS, the rest of the site is working: I can make posts, pages, media, install themes and plugins.
I tried to play with $current_url al line 649 of
wp-admin/includes/class-wp-list-table.php
but with no luck.
I suppose that pagination may have the same problem.
" gamboz
Needs Milestone 16858 Usage of HTTP_HOST in the administration Administration 3.1 normal normal Awaiting Review defect (bug) reopened reporter-feedback 2011-03-15T13:33:47Z 2012-08-09T18:46:29Z "In some files like wp-admin/includes/class-wp-list-table.php (there are more files I think), some links are created by using the HTTP_HOST variable.
It's better to use the defined wordpress URL to create those links.
In our case, we have a wordpress running behind a Squid cache. When you check for HTTP_HOST you get the *real* HOST and not the one with the Squid server.
To bypass the problem, I added in the main config.php a line like this :
{{{
$_SERVER['HTTP_HOST'] = 'www.my-visible-http-host.com';
}}}
Without this setting and in our case, some links in the admin (next, previous page, re-ordering...) where pointing to the wrong server.
" amirhabibi
Needs Milestone 17168 redirect loop when accessing wp-admin/network/ Multisite 3.1.1 normal normal Awaiting Review defect (bug) reopened has-patch 2011-04-18T17:59:55Z 2012-08-10T06:31:44Z "As of 3.1.1 administrators are getting redirect loops when accessing wp-admin/network/. I run a multi-site multi-domain network and we've noticed that this bug is effecting new and old sites. One super admin reported clicking Update Network put's it in a redirect loop as well.
For new sites if this bug occurs the quick solution is to delete / recreate. I checked _options siteurl, _blogs blog_id domain, and _sitemeta siteurl. Nothing out of the ordinary in the db." chaos1
Needs Milestone 17236 Make it easier to subclass custom header and background Themes normal normal Awaiting Review feature request new 2011-04-25T20:50:13Z 2012-08-10T12:55:06Z "The functions that add the custom header and background contain code like this:
{{{
require_once( ABSPATH . 'wp-admin/custom-header.php' );
$custom_image_header = new Custom_Image_Header( $admin_header_callback, $admin_image_div_callback );
add_action( 'admin_menu', array( &$custom_image_header, 'init' ) );
}}}
This makes it difficult to extend those classes, since they're referenced here directly. Replacing them with subclasses involves not only modifying the global after the fact, but removing and re-adding the action hook to the newly created sub-class item.
The fact that this base class is only included at this point also makes it difficult to load your own subclass at the right time, since you have to add the custom image header first, then load, then remove the action hook, then replace the class, then do the action hook yourself...
It would be nice if it was possible to more easily replace these globals (both header and background) with a different class at the time of definition here. I'm not sure of the best way to do this. Perhaps with a hook allowing the user to replace the class before the add_action? Or by having the new itself use a class of the users own defining.
" Otto42
Needs Milestone 21485 Exclude current post from Recent Posts widget Widgets normal normal Awaiting Review enhancement new has-patch 2012-08-05T23:16:56Z 2012-08-11T21:13:08Z "Checking demo site - http://twentytwelvedemo.wordpress.com/
If you visit any recent post like this one - http://twentytwelvedemo.wordpress.com/2012/03/28/road-trips/
The recent post widget on right sidebar include this post in recent 5 post. We could just exclude present post from the loop using code like this
{{{
5,
""orderby""=>""post_date"",
""post__not_in""=>array($post->ID)
);
$posts = get_posts($args);
foreach($posts as $post) {
setup_postdata($post);
?>
}}}
Most theme has it. If you are already in a post which is among recent 5, no point of showing it in the loop.
" Asif2BD
Needs Milestone 21547 Enable 'delocalization' of scripts General normal normal Awaiting Review enhancement new has-patch 2012-08-11T04:04:27Z 2012-08-12T20:19:51Z "I created a patch to enable developers to 'delocalize' a script they added. Currently if somebody localizes a script with wp_localize_script() there's no going back.
Can someone look at it and offer feedback? I'm not a regular WordPress contributor, so there may be stylistic issues." gkb6891
Needs Milestone 20006 get_comments (and WP_Comment_Query) does not accept multiple post_type Comments 3.3.1 normal normal Awaiting Review defect (bug) new has-patch 2012-02-10T05:46:52Z 2012-08-14T08:34:53Z "Although get_comments was recently improved to support post_types, it does not seem to properly handle MULTIPLE post_types.
Suppose you need to get the most recent comments for posts, pages, and attachments (attachments don't seem to be included by default). The following doesn't work, as it only returns comments on attachments (or whichever status is listed first):
{{{
get_comments(array('number'=>20, 'status'=>'approve', 'post_type'=>array('attachment','post','page')));
}}}
The following doesn't work either, only returning the default post/page comments (taken from the example for multiple category handling at http://codex.wordpress.org/Class_Reference/WP_Query):
{{{
get_comments(array('number'=>20, 'status'=>'approve', 'post_type__in'=>array('attachment','post','page')));
}}}
A quick look at wp-includes/comment.php, line 327 (WP v3.3.1) shows that the 2nd option will be array_filter'ed away. Immediately below, all of the WHERE clauses are hardcoded as ""="", which is why there's no way to specify more than one. As a result, it seems like the only way to get recent comments on posts,pages,and attachments (or any other subset of >1 post_type) is to do multiple calls to get_comments (i.e. one with default params and one for attachments) then merge the results together...effectively requiring twice the work." Justin_K
Needs Milestone 19623 Use Comment API in comments_template, rather than hardcoded SQL Comments 3.3 normal normal Awaiting Review enhancement new has-patch 2011-12-20T18:07:44Z 2012-08-14T08:36:00Z "Currently the function {{{comments_template}}} uses hard-coded SQL queries, rather than {{{WP_Comment_Query}}} or {{{get_comments}}}. There's a note above the queries saying [http://core.trac.wordpress.org/browser/tags/3.3/wp-includes/comment-template.php#L888 /** @todo Use API instead of SELECTs. */].
To replace the queries using the API, the {{{WP_Comment_Query}}} class will need to be extended to allow querying for comments which are '''either''' approved '''or''' unapproved ({{{hold}}} status) but by a particular comment author email and comment author name ''or'' by a particular {{{user_id}}} to replace these two queries:
* {{{SELECT * FROM $wpdb->comments WHERE comment_post_ID = %d AND (comment_approved = '1' OR ( user_id = %d AND comment_approved = '0' ) ) ORDER BY comment_date_gmt}}}
* {{{SELECT * FROM $wpdb->comments WHERE comment_post_ID = %d AND ( comment_approved = '1' OR ( comment_author = %s AND comment_author_email = %s AND comment_approved = '0' ) ) ORDER BY comment_date_gmt}}}
If we change to use the API, there's also an opportunity to add a filter for the args, which would be lovely for plugin developers. :)" simonwheatley
Needs Milestone 21581 Add orderby meta_value to WP_User_Query General normal normal Awaiting Review defect (bug) new dev-feedback 2012-08-14T21:24:05Z 2012-08-14T21:40:10Z "For some reason, we cannot easily order the WP_User_Query() by last_name without directly editing the SQL statements. However, there is an easy way to add this that would work parallel to WP_Query().
{{{
// prepare arguments
$args = array(
'orderby' => 'meta_value',
'meta_key' => 'last_name',
);
$user_query = new WP_User_Query( $args );
}}}" wpsmith
Needs Milestone 21603 Add a delete button to individual menu items Menus 3.4.1 normal normal Awaiting Review enhancement new 2012-08-15T21:45:29Z 2012-08-15T21:45:29Z "When working with a menu in the Admin, if you need to delete a lot of entries it's really slow because you have to expand each entry, then click delete, then wait for the refresh to do it all over again. If we had an X next to the down arrow for each menu item, it would be much faster/easier to delete them.
Thanks!" wphound
Needs Milestone 18399 Password Strength Meter should usually mark passwords that contain password as weak Users normal normal Awaiting Review enhancement new close 2011-08-13T23:41:11Z 2012-08-15T23:22:51Z "Password (in human and l337 form) is a horrible password. Unless a password is really long, we should mark passwords that contain 'password' as weak.
Test Case : password123 returns Strong" jorbin
Needs Milestone 20810 Add disable arg or attributes arg to wp_dropdown_categories() & wp_dropdown_pages() Template normal normal Awaiting Review enhancement new 2012-06-01T19:27:07Z 2012-08-17T13:27:36Z "It would be beneficial to be able to add disabled=""disabled"" attribute to the select tag or add multiple attributes to the select tag.
Related: #20156, #20167" wpsmith
Needs Milestone 21237 "Terminology for ""Front"" and ""Home""" General normal normal Awaiting Review defect (bug) new 2012-07-12T13:59:40Z 2012-08-17T19:25:29Z "The following related tickets all have discussions concerning the Terminology for ""Front Page"" and ""Home Page"" is some way.
#16379 - Better UI for doing ""Page on Front"" [[BR]]
(UI effected by the terminology)
#10158 - Deprecate is_home() and is_single(), in favor of is_blog() and is_post() [[BR]]
(Conditional Tags effected by the terminology)
#18705 - home_url() and is_home() with a static front page [[BR]]
(URL function effected by the terminology)
Additionally, Template files are effected by the terminology (home.php and front-page.php)
This ticket is intended to discuss the best options that address the above terminology concerns for the sake of consistency and usability. If a determination is made here, hopefully we can use the terminology to inform the above tickets." WraithKenny
Needs Milestone 18790 add_theme_support with post type doesn't add theme support but overwrites it Themes 3.2.1 normal normal Awaiting Review defect (bug) new has-patch 2011-09-27T12:17:13Z 2012-08-18T01:48:57Z "The function add_theme_support has an optional second parameter, which allows you to add support for post thumbnails for certain post types.
You would expect this function to add the theme support for that post type, but instead it overwrites the theme support for that feature, which results in the theme support being set for just the post type(s) that were passed.
Reproduce:
{{{
function add_thumbnails_support()
{
add_theme_support('post-thumbnails', array('my_post_type'));
print_r(get_theme_support('post-thumbnails'));
add_theme_support('post-thumbnails', array('another_post_type'));
print_r(get_theme_support('post-thumbnails'));
}
add_action('after_setup_theme', 'add_thumbnails_support');
}}}
" Jesper800
Needs Milestone 21631 HTML encoded characters in the custom menu's URL html are decoded after first save and removed after second save Menus 3.4.1 normal normal Awaiting Review defect (bug) new 2012-08-19T15:27:20Z 2012-08-19T15:49:04Z "Special characters in the custom menu's URL get double html encoded after second save.
Having an array in the URL that is using square brackets (site.com/key[value]), the links break after the second save of that menu item because the & in the & gets double html encoded." rocketwood
Needs Milestone 9775 Duplicate comment check is too strict Comments 2.7.1 normal normal Awaiting Review enhancement reopened 2009-05-09T21:27:38Z 2012-08-19T23:33:35Z "The duplicate comment detection mechanism doesn't allow duplicate comments on the same post, even from the post author. That's not good.
The duplicate comment check should only block the new comment if there is no other comment posted between the new comment and the old comment." scribu
Needs Milestone 21546 Site Settings page is a hot mess Multisite 3.0 normal normal Awaiting Review enhancement new has-patch 2012-08-10T21:44:07Z 2012-08-20T16:50:59Z "I found out just how bad this page is when debugging an issue related to {{{WPLANG}}}. {{{WPLANG}}} is an option for a blog in your network (overrides {{{WPLANG}}} in {{{wp-config.php}}}), but if you delete the option on purpose or accidentally, there is no way of restoring it in the admin.
Site Settings just loads your options table and POSTs back to itself. The only reference to the original options map (the defaults) is in schema, which WP has zero access to outside of upgrade.
I have abstracted the default options and the default ""fat"" options into functions in {{{ms.php}}}. Also, when loading your Site Settings options - if a default option is missing, I display it in the admin so you can save it (it is populated with its default value).
I have also streamlined and condensed some code that was happening in and around {{{populate_options()}}}" wonderboymusic
Needs Milestone 21641 Filter on pending/draft array in wp_insert_post() General normal normal Awaiting Review enhancement new 2012-08-20T16:53:56Z 2012-08-20T16:53:56Z "Hi
In wp_insert_post() function, there is no possibility to add a status to the list of status for which postname can be set to empty (no filter). Thus, to have the 'pending' like behaviour for a custom status it seems you have to update the postname to '' and the gmt to 000-00 after the insert, as you have to hack the permalink construction too.
In the same way, it would be nice to add the $post parameter to the filter 'display_post_states' in the '_post_states($post)' function (wp-admin/includes/template.php), in order to add easily a post state according to a custom status of the post (seems better as retrieving the global $post of the admin loop).
Hope these are real issues. Sorry if not.
Regards
" villagora
Needs Milestone 21642 language_attributes() print WP lang instead content lang. General 2.1 normal normal Awaiting Review enhancement new dev-feedback 2012-08-20T18:15:37Z 2012-08-20T20:46:33Z "If you have WordPress in a language does not mean that the content has to be in that language. It would be good if there was an option to select it.
Another detail is for example: If we have the translation ""'''Spanish - Spain'''"", ""'''es-ES'''"", WordPress print ""'''es-e'''s"" instead of ""'''es'''"" simply.
This would be good because it is the only translation into Spanish." shadowhck
Needs Milestone 21645 Rewrite API logic and flush_rules Rewrite Rules 3.4.1 normal normal Awaiting Review defect (bug) new 2012-08-21T00:24:05Z 2012-08-21T08:24:19Z "
It is not clear if or how visiting the Settings -> Permalinks calls flush_rules. It is referenced occasionally as an apparent alternative to $wp_rewrite->flush_rules() in Documentation. This should be explicitly confirmed in the admin interface and/or a button based action.
Documentation for the Rewrite API functions do not point at $wp_rewrite->flush_rules() effectively. (Updated some codex links, but seems worth including a pointer inline in function definitions.)
I was confused while editing an existing theme why duplicating existing add_feed() structures in functions.php did not produce duplicated behaviour in the permalinks. ?feed=atom1 worked , but /feed/atom1/ didn't, until calling flush_rules()
Logic seems broken between these functions. Why call Rewrite API add_feed() every init, but still require a flush_rules reset to activate? They should be more explicitly linked / combined / triggered. See prior conversation in #21335
http://codex.wordpress.org/Rewrite_API" here
Needs Milestone 21649 _WP_Editor class is currently marked as final Editor normal normal Awaiting Review enhancement new 2012-08-21T13:13:08Z 2012-08-21T17:16:30Z "Revision [19420] turned
{{{
class _WP_Editors{}
}}}
from wp-includes/class-wp-editor.php into
{{{
final class _WP_Editors{}
}}}
I'm aware that editor API is currently under large changes but it would be great if plugins could extend _WP_Editors class by removing ""final"" keyword." Marko-M
Needs Milestone 21658 Meaningless adjacent post links for pages General 3.4.1 normal normal Awaiting Review defect (bug) new 2012-08-22T12:34:26Z 2012-08-22T12:34:26Z "In WP 3.3 we removed a number of obsolete ,
?=@example.com
}}}
I think that it is somehow related to wp_mail() function, because I also tried to use SMTP plugin and it worked well:
{{{
Reply-To: =?UTF-8?Q?""=C5=BDlut=C3=BD_k=C5=AF=C5=88""_?=
}}}
Also when I use simply mail() instead of wp_mail() then everything works well. Problem can be seen only for Reply-To header, all others work well (for example From).
I am using WP 3.4.1." pavelevap
Needs Milestone 18730 media_sideload_image() doesn't handle dynamic image url's well Warnings/Notices 2.9 normal normal Awaiting Review defect (bug) new has-patch 2011-09-21T10:49:11Z 2012-08-23T20:17:02Z "Example URL: http://www.tumblr.com/photo/1280/10464566223/1/tumblr_lrum2xzkpC1r3z8e3
As a result, the preg_match() for the file extension fails and issues a notice (no file extension in that url, although the redirection location does have).
The handling of a download failure also seems hairy, upon failure, it still attempts further importing before loading - I haven't looked into that too far." dd32
Needs Milestone 21055 Interface for wpdb compatibility Database normal normal Awaiting Review feature request new 2012-06-23T17:30:13Z 2012-08-24T01:40:01Z "==Summary==
From the wp-includes/wp-db.php file:
{{{
It is possible to replace this class with your own
by setting the $wpdb global variable in wp-content/db.php
file to your class. The wpdb class will still be included,
so you can extend it or simply use your own.
}}}
When one implements a db class that does not extend wpdb, it would be safer that the new class implements an interface. This interface may be called wpdb_compat and would assure that the class has all necessary methods/properties. Of course, wpdb_compat should be supported by wpdb too.
== Design Strategies ==
My patch adds:
* wp-includes/interfaces/wpdb-compat.php
Very small edits to:
* wp-includes/wp-db.php
* wp-includes/load.php
* wp-admin/install.php
At the moment, WordPress does not include any interface; this means that there is not a directory for interfaces.[[BR]]
In my first draft, I put it in wp-includes/interfaces so that - if more interfaces will be added in the future - they will have a logical place.
" santec
Needs Milestone 20905 Allow rewrite endpoints to specify a different query variable name Permalinks normal normal Awaiting Review enhancement new has-patch 2012-06-11T13:53:40Z 2012-08-24T07:02:34Z "Using `add_rewrite_endpoint()` we can add an endpoint such as `/foo/bar/` which maps to `foo=bar`. I'd like to be able to map an endpoint to a query variable of a different name. Currently the query variable name always matches the endpoint name.
Example: I'd like to use `/p/{number}` as a nice short endpoint for some custom functionality, but the 'p' query variable is used by core. I'd like to be able to map `/p/3/` to `my_query_var=3`." johnbillion
Needs Milestone 21679 media_handle_upload does not provide a way to change the file's name Media 2.5 normal normal Awaiting Review defect (bug) new dev-feedback 2012-08-24T04:00:30Z 2012-08-24T10:33:06Z "`wp-admin/includes/media.php` has two operations that I believe should be reversed. Basically, `$name` is set based on the name of the raw uploaded file ( `$_FILES[$file_id]['name']`), however in the `wp_handle_upload` function you are able to use `wp_handle_upload_prefilter` to adjust the file's name - but when after the `wp_handle_upload` returns the changes will not show up in the title of the media dialog field even though the file has been renamed properly:
{{{
$name = $_FILES[$file_id]['name'];
$file = wp_handle_upload($_FILES[$file_id], $overrides, $time);
if ( isset($file['error']) )
return new WP_Error( 'upload_error', $file['error'] );
$name_parts = pathinfo($name);
$name = trim( substr( $name, 0, -(1 + strlen($name_parts['extension'])) ) );
}}}
In short, uploading a file named Picture.png and changing the name to test3.png using the `wp_handle_upload_prefilter` filter does in fact allow the file's name to be changed before it is saved, but the ""title"" is then incorrectly displayed in the media uploader dialog box.
[[Image(http://img24.imageshack.us/img24/3679/pictureyp.png)]]
This would be relatively easy to fix using this patch:
{{{
--- media.php 2012-08-23 23:57:02.000000000 -0400
+++ media-patch.php 2012-06-06 12:00:08.000000000 -0400
@@ -209,8 +209,8 @@
$time = $post->post_date;
}
+ $name = $_FILES[$file_id]['name'];
$file = wp_handle_upload($_FILES[$file_id], $overrides, $time);
- $name = $file['name'];
if ( isset($file['error']) )
return new WP_Error( 'upload_error', $file['error'] );
}}}" Willshouse
Needs Milestone 21674 "Please add ""plugins"" link under ""my sites > network admin"" in toolbar" Multisite 3.4.1 normal normal Awaiting Review feature request new has-patch 2012-08-23T19:13:46Z 2012-08-24T15:43:16Z This would remove a click and I think a lot of people would enjoy the addition. I know I go to the plugins page more than users or sites combined. archonic
Needs Milestone 21571 Add support multiple comment types in get_comments Comments normal normal Awaiting Review enhancement new 2012-08-14T00:49:42Z 2012-08-24T19:54:42Z "Custom comment types are a nice way to categorize comments, however, if you wish to retrieve multiple comment types you cannot use ''get_comments''. This enhancement request (patch attached) adds support for multiple comment types a la:
{{{
$comments = get_comments( array(
'post_id' => $post->ID,
'type' => array(
'a-sweet-comment-type',
'some-other-comment-type',
),
));
}}}" borkweb
Needs Milestone 21652 wp_update_nav_menu_items returns false instead of WP_Error for non-existent menu items Menus 3.4.1 normal normal Awaiting Review defect (bug) new has-patch 2012-08-21T16:57:45Z 2012-08-25T14:49:33Z "'''Use case:'''
Calling wp_update_nav_menu_items with a non-existent menu_item_id as the first parameter
'''Expected return value:''' WP_Error object (as per the method's documentation)
'''Actual return value:''' Boolean false
'''Fix:''' wp-includes/nav-menu.php#L279 - This line should check for a false value first, and if `$menu == false`, set it equal to a `new WP_Error` object - then check `is_wp_error($menu)`" mltsy
Needs Milestone 21687 Need to be able to float sticky posts to top in custom queries Query 3.4 normal normal Awaiting Review enhancement new 2012-08-25T16:12:08Z 2012-08-25T16:12:08Z "Currently sticky posts are only floated to the top of the loop when on an index page (blog/home). When making a new WP_Query for posts as a secondary loop on a ""page"" page (whilst developing shortcode) sticky posts only appear in the natural date order because my query does not have the is_home flag.
My proposal would be to add a new parameter/argument to the WP_Query class, either connected to 'orderby' or 'ignore_sticky' parameters, stating whether sticky posts should have order 'float', 'natural', 'exclude' (it seems that the mechanism for excluding sticky posts from the loop is a bit clunky, although well documented; this would simplify it). Default behaviour can be retained, the query on the index page can use the 'float' option and themes/plugins can call it in custom queries if required.
Alternatively, the sticky sorting could be moved to a separate function and called via an action, so developers can use the same function (or build their own) in their custom queries. This is how I have my current workaround, running a filter on 'posts_results' having copied code for floating stickies from core. It seems a shame to be be duplicating code though, especially when it should be an option available in custom queries." ChemicalSailor
Needs Milestone 20140 Ask old password to change user password tman4506* Security normal normal Awaiting Review feature request accepted dev-feedback 2012-02-29T12:55:38Z 2012-08-26T16:14:53Z "I have experienced this in various sites and i think
it adds extra security.
We must ask for the old password when the user tries to change the password" nprasath002
Needs Milestone 21699 Losing post status Post Types 3.4.1 normal normal Awaiting Review defect (bug) new dev-feedback 2012-08-27T05:19:40Z 2012-08-27T07:00:09Z I created custom post type and custom post status for it. Then I programmatically set custom status for new post and then edit it using admin panel. When I save post status is set to 'published' and I can't select my status from statuses list. barmin.alexander@…
Needs Milestone 21683 Choose the relationship between the meta_query and what it's pulled into (AND/OR) Query 3.4.1 normal normal Awaiting Review enhancement new dev-feedback 2012-08-24T19:00:11Z 2012-08-27T14:13:06Z "The use case for this is that I'd like to be able to, much like meta_query's ""relation"" option, be able to choose whether or not 'meta_query' itself should be treated like AND or OR in it's WHERE inclusion.
meta_query's ""relation"" option is already helpful, letting you treat any of the meta_query's arrays as OR instead of the default AND.
Adding this new option would provide the ability to treat meta_query as AND / OR based on the need of the WP_Query lookup." sc0ttkclark
Needs Milestone 21554 Problem with determining e-mail charset in wp-mail.php lizhenry Blog by Email 3.4.1 normal normal Awaiting Review defect (bug) assigned dev-feedback 2012-08-12T11:06:52Z 2012-08-29T13:58:26Z "In wp-mail.php the charset of the incoming e-mail message is determined on line 77 by taking the string between the second ""="" in the line and the end of line/second "";"" respectively.
'''The problem'''
If the header line in question looks like any of the following that method is perfectly fine:
{{{
Content-Type: text/plain; charset=UTF-8; format=flowed; delsp=yes
Content-Type: multipart/alternative;
}}}
However in messages sent from e.g. Gmail or Goolge Reader this header line usually looks like this:
{{{
Content-Type: multipart/alternative; boundary=f46d044516dd9cd71f04c70e55e8
}}}
I this case ""f46d044516dd9cd71f04c70e55e8"" is determined as the charset and the iconv function further down on line 187 returns false which causes the post content to be emptied.
'''Suggested solution'''
I personally think that it is better to have the post published with an ""incorrect"" charset than with no content at all.
Therefore I suggest that on line 76 in wp-mail.php...
{{{
if ( ! empty( $content_type[1] ) ) {
}}}
...is replaced by...
{{{
if ( ! empty( $content_type[1] ) && stripos( $content_type[1], 'charset' ) !== FALSE ) {
}}}
...in order to check if there is actually a charset definded.
Alternatively/additionally the return value of the iconv function on line 187 should be checked and the $content variable only modified if the return value doesn't equal FALSE." mighty_mt
Needs Milestone 21730 More modular and reusable email validation functions Users normal normal Awaiting Review enhancement new dev-feedback 2012-08-29T16:04:04Z 2012-08-29T19:56:12Z "Email validation, especially as it's handled in Multisite (most of which is verbatim from MU), is pretty messy. We have some functions like `is_email_address_unsafe()` for checking banned domains, but we don't have a parallel function for checking against limited_email_domains. There are no filters outside of `wpmu_validate_user_signup`, which means that if you want to use email validation outside of the normal MS registration workflow and want to tweak the way that it works (see eg #15706, #20459), you pretty much have to roll your own. And there's no single function that a plugin like BuddyPress can use to do all relevant email checks in one fell swoop.
The attached patch suggests the following changes:
- Put the limited_email_domains check into a function, `is_email_address_allowed()`.
- Put filters on the output of this new function as well as `is_email_address_unsafe()`.
- Introduce function wp_validate_email_address(), which wraps the following four checks: is_email(), email_exists(), is_email_address_allowed(), is_email_address_unsafe().
- Rearranges `wpmu_validate_user_signup()` a bit so that all email checks (as opposed to username checks) happen together.
I'm not married to anything in this particular implementation (the way that wp_validate_email_address() sends back error messages is not particularly beautiful, but I didn't want to introduce a ton of overhead), but I would really like to see some sort of treatment along these lines, to make things more modular and reusable.
If something like this gets approved by the devs, I would like to further suggest the following:
- Give a similar treatment to username validation
- Move the generic validation functions out of ms-functions.php (with function_exists() checks on the MS-specific stuff)
I'm happy to work more on this kind of patch, but didn't want to go too far in case it's a non-starter for some reason." boonebgorges
Needs Milestone 16762 wpdb::$base_prefix is not documented Database normal normal Awaiting Review defect (bug) new has-patch 2011-03-05T16:17:01Z 2012-08-29T19:59:25Z "Probably wpdb::$base_prefix has been merged into from MU and not further specified then.
It ''genereally'' can be replaced with {{{wpdb::get_blog_prefix(0)}}} when the MULTISITE constant is defined. That is are after wp-settings.php has been included (wp-config.php, wp-load.php), even on SHORTINIT.
It ''might'' be that this function call does not cover all cases needed because if MULTISITE is not defined when called, it will not return the {{{wpdb::$base_prefix}}}.
More insight into MU is needed, feedback appreceated. Some places look like that they are not aware of the wpdb::get_blog_prefix() function. Probably legacy MU code.
Related: #16756" hakre
Needs Milestone 13365 WP_Query, author_name, and sticky posts ryan Query 2.9.2 normal normal Awaiting Review defect (bug) new dev-feedback 2010-05-12T06:09:42Z 2012-08-30T00:17:35Z "I have a template which is being used as my front page on WP 2.9.2. In this template I setup my loop with the following code:
{{{
$postresults = new WP_Query();
$postresults->query(""author_name=frontpage&post_types=post&post_status=publish"");
while($postresults->have_posts()) { $postresults->the_post(); ?>
// etc...
}}}
I am not using the ""caller_get_posts=1"" option, but my sticky posts are still showing up in order with other posts rather than at the beginning. If I remove the ""author_name=frontpage"" the sticky posts will move back to the first items, however I am stuck with posts by authors I do not want. Using ""author=2"" results in the same behavior as using ""author_name""." eryanv
Needs Milestone 14370 Custom Taxonomies tagging Attachments Taxonomy 3.0 normal normal Awaiting Review defect (bug) reopened dev-feedback 2010-07-21T02:28:52Z 2012-08-30T08:56:17Z "There appears to be an issue where if the custom taxonomy has only attachment:image, attachment:audio, and attachment:video The attachments return nothing found. Only 'post' post types are returned.
adding to a query 'post_status' => publish, allows it to display the images but does not allow pagination.
WordPress should return all post_types that the Taxonomy is defined for. Somehow ma.tt found a way around this issue. refer to:
http://osdir.com/ml/wp-testers/2010-06/msg00317.html
http://wordpress.org/support/topic/383096?replies=29
Does not affect pre 3.0
" thee17
Needs Milestone 21753 Feed excerpts are missing important filter formatting Feeds 3.4.1 normal normal Awaiting Review defect (bug) new 2012-08-31T14:20:56Z 2012-08-31T14:20:56Z "Excerpts included in feeds are missing important formatting because the relevant filters are not applied (e.g. wpautop).
In file wp-includes/feed.php, function the_excerpt_rss() does not apply the same filters as the_excerpt() whilst results in lost formatting instructions. By comparison, function the_content_feed() ensures that the same filters declared for the_content() are applied.
A suggested patch is attached. Note that for symmetry between the_excerpt_rss() and the_content_feed() this patch also removes the (unnecessary?) filter ent2ncr() from the_excerpt_rss() and retains the (controversial?) escaping for CDATA blocks (see #3670).
A few related issues are worth mentioning. Firstly, shortcodes are still not applied to excerpts (see #7093). Also, the (obsolete?) RDF feed does not make use of a CDATA block unlike those for RSS, RSS2 and Atom (see #20888). Finally, a similar problem occurs with comment text in feeds (see #16466)." mdgl
Needs Milestone 19770 Implement browser-side resizing with Plupload Upload 3.3 normal normal Awaiting Review feature request new 2012-01-07T16:07:51Z 2012-09-01T06:10:23Z "#19174 removed the browser-side image resizing due to browser inconsistencies. We should fix it and reintroduce the feature.
A little related: #14459" johnbillion
Needs Milestone 21713 Extend login body class to support custom background Template normal normal Awaiting Review enhancement new has-patch 2012-08-28T14:46:00Z 2012-09-01T07:19:36Z "It would be useful to have a class `custom-background` on the `body` element for `wp-login.php`. Then we could just write:
{{{
add_action( 'login_head', '_custom_background_cb' );
}}}
Currently we have to copy the whole function with a very tiny difference: replace `body.custom-background` with `body.login`. Not very elegant." toscho
Needs Milestone 21758 Do not require a file in comments_template() Comments 3.4.1 normal normal Awaiting Review enhancement new has-patch 2012-08-31T20:22:16Z 2012-09-01T11:23:07Z "comments_template() is a very useful and reliable way to set up comments for a page, but it has a major downfall: it forces a file to be included when, in reality, one does not need to be.
Numerous times it has been the case that I needed comments to be setup in the wp_query object, but did not want to output anything at that time. The hack I have used is simply to include an empty comments.php file. This method is less than desirable for obvious reasons.
So, I propose that we simply add a parameter I'm calling $require that will control whether or not a file is included at all." mattonomics
Needs Milestone 21765 Redirect to canonical URL if URL has 'preview' parameter with any nonempty value and user not log in Canonical 3.4.1 normal normal Awaiting Review enhancement new 2012-09-01T13:18:44Z 2012-09-01T15:15:07Z "if any URL has nonempty GET-parameter 'preview' that there is noredirection to canonical URL.
If we have http://example.com?p={post_id}&post_type={post_slug}&preview=true there is no redirection to correct URL like http://example.com?{post_type}={post_slug} or like http://example.com/{post_type}/{post_slug} (if site has permalinks). This is bad for SEO and bad user experience. If user not log in there must be redirecttion." egorpromo
Needs Milestone 21762 Storing a multidimensional array using register_setting double-serializes subarrays identified with a string sekatsim Database 3.4.1 normal normal Awaiting Review defect (bug) new 2012-08-31T22:43:16Z 2012-09-01T16:36:41Z "Storing a multidimensional array, such as `$options['my-option'][$id] = ""value""`, into the database using register_setting results in the ""my-option"" string getting double serialized. The option_value is stored as:
`s:9:""'my-option'"";a:1:{s:9:""option-id"";s:5:""value"";}`
The my-option array is encased in both single and double quotes, so that `isset($options['option-id']` evaluates false, but `isset($options[""'option-id'""]` evaluates true." sekatsim
Needs Milestone 18488 set_transient crashes when value parameter is a SimpleXMLElement object Cache 3.2.1 normal normal Awaiting Review enhancement reopened 2011-08-19T18:58:02Z 2012-09-01T18:03:16Z "I have been developing a plugin that obtains information about high and low tides in the UK. The data is obtained from another site as a SimpleXMLElement. I found that when I passed a value to set_transient that had been assigned directly from the SimpleXMLObject then it was being received as an object and somewhere in the innards of the function the routine crashed. My workaround was to cast the assignment.
e.g. this failed
{{{
$title = $channel->item->title;
$store = '1';
$secs = bw_time_of_day_secs();
$secs = 86400 - $secs;
$set_transient( ""bw_tides_title_"" . $store, $title, $secs);
}}}
but change line 1 as below and it works
$title = '''(string)''' $channel->item->title;
Two questions therefore.
1. Am I misinterpreting the documentation that says I don't need to serialise the value? What does mixed actually mean.
2. Does set_transient have to crash when the parameters are wrong?
The problem is completely reproducable. I now have a working solution so I don't need a fix right now. I just want to understand.
Herb
" bobbingwide
Needs Milestone 21219 get_post_type_archive_link in multisite context: struct issue Post Types normal normal Awaiting Review defect (bug) new 2012-07-11T17:48:27Z 2012-09-03T12:11:03Z "Context : multisite and a site aaa ( http://localhost/wpmu_svn_34/aaa/ ) trying to display the '''post_type_archive_link''' of cpt 'book' of the blog bbb
{{{
switch_to_blog( $b );
$link = get_post_type_archive_link( 'book' ) ;
/*/ http://localhost/wpmu_svn_34/bbb/book/ and not http://localhost/wpmu_svn_34/bbb/livre/ */
restore_current_blog();
}}}
when name, slug and query_var of the post_type are the same: no problem because $struct to find the '/book/' is kept from the caller site BUT
if in the called site, the CPT have the same type name ('book') but with different slug and query_var, the home_url is correctly changed but the $struct is not good... 'book' instead 'livre' as declared in cpt in site bob.
The issue came from global $wp_rewrite; which is not this of the target after the switch_to_blog !
Instead of a non elegant filter ''post_type_archive_link'', is there a way to ""find"" the $wp_rewrite of $b ?
Best regards !
" michelwppi
Needs Milestone 21792 Add link to settings.general from appearance.header Appearance normal normal Awaiting Review enhancement new 2012-09-04T19:38:50Z 2012-09-04T19:40:36Z "Multiple users that we've tested have ended up on appearance->header when asked to change their ""site title"". It seems logical. Should we add a link there?" lessbloat
Needs Milestone 21790 When set a static front page WP main query isn't set correctly Query 3.4.1 normal normal Awaiting Review defect (bug) new dev-feedback 2012-09-04T13:50:26Z 2012-09-05T16:00:06Z "In my project I use on several places pre_get_posts filter. When setting a static frontpage and blog page I get several notices on my screen. When I var_dump the main query the only value that is set it the page_id.
Even the post_type isn't set." markoheijnen
Needs Milestone 20262 "When ""Automatically close comments on articles older than X days"" is enabled, comments appear closed on draft posts" Comments 3.3 normal normal Awaiting Review defect (bug) new dev-feedback 2012-03-20T15:14:21Z 2012-09-05T17:12:08Z "If the setting to ""Automatically close comments on articles older than X days"" is enabled via Settings -> Discussion, comments automatically appear as closed on draft posts until the post is published. This is regardless of the Discussion settings configured on the Post Edit page for the draft post.
To replicate:
1. Via Settings -> Discussion, click on ""Automatically close comments on articles older than X days.""
2. Create a new post and save it as a draft. Make sure comments are enabled in your Discussion module.
3. When previewing the draft post, it will say ""Comments closed"" regardless of the Discussion settings.
The post will show comments as being allowed once it's published, they only show up as closed when in the draft format. " evarlese
Needs Milestone 21538 wp_get_attachment_image_src() is misnamed Media 2.5 normal normal Awaiting Review enhancement new 2012-08-10T11:58:20Z 2012-09-06T06:25:45Z "The function wp_get_attachment_image_src is misnamed. The name suggests that the function returns the URL for the src attribute of img tag, and this suggestion is so strong that it is practically impossible to remember that it in fact returns an array. I've just now been bitten by this for perhaps 50th time, and I have lost what amounts to days of debugging on finding out again and again that a function named ...get...src doesn't get src.
I suggest renaming to wp_get_attachment_image_attributes and forwarding+deprecating the old function." rulatir
Needs Milestone 21834 Comment History Comments normal normal Awaiting Review enhancement new has-patch 2012-09-07T20:30:47Z 2012-09-08T03:37:40Z "This ticket provides a simple patch for comment history in core.
''The Problem'':
In at least a few places: ([comment:ticket:9117:10], [comment:ticket:15534:4], [comment:ticket:9495:3]) Nacin has mused about the desirability of introducing comment history to core, citing Akismet’s implementation as a model for how this might be done.
There are good reasons for wanting this, as comment history could serve as a solid underpinning for a variety of other features such as more informative moderation emails, some indication of why a message was marked as spam, and even comment versioning.
The idea is that to implement any of that, we really should have basic comment versioning in core, a la Akisment.
''The Solution'':
Our goal was to expand the API so as to reproduce and streamline the basic history functionality provided by Akismet, port and tweak Akismet’s nice history UI, and keep the change set minimal.
Comment history API:
* added simple functions to /wp-includes/comment.php to get and update comment history. These in turn use existing comment_meta functions.
UI:
* there’s now a comment history meta box on the comment edit screen. It looks just like Akismet’s. This was implemented as a real meta box. A sorting function is also included.
History Events:
* this patch supports the following history events, each of which has a nice, plain-english (internationalizable) history message, which always includes the user responsible for the action and a timesince.
* edit_comment (“edited by user”)
* trashed_comment (“trashed by user”)
* untrashed_comment (“un-trashed by user”)
* comment_unapproved_to_approved (“user approved this comment”)
* comment_approved_to_unapproved (“user unapproved this comment”)
* spammed_comment (“user marked this comment as spam”)
* unspammed_comment (“user marked this comment as ham”)
''Next steps'':
Here’s what we’d think of doing next if this were to be introduced into core:
* support more history events and provide more detail. In particular, support events where the comment is spammed as a result of a blacklist word or other reason.
* include some of this detail in moderation emails
''Note'':
* the Akismet plugin should be updated to use this new API instead of its own history functions
* meta boxes on edit comment did not work properly until this: http://core.trac.wordpress.org/ticket/21499 (in 3.5)
''Who we are'':
This patch comes from [http://profiles.wordpress.org/bbrooks Ben Brooks], [http://profiles.wordpress.org/mattoperry Matt Perry] and [http://profiles.wordpress.org/natebot Nathan Letsinger]. Enjoy" mattoperry
Needs Milestone 21840 Add filter for taxonomies shown in quick edit Quick/Bulk Edit normal normal Awaiting Review enhancement new 2012-09-08T02:02:36Z 2012-09-08T17:08:36Z "I'd like to propose that there be more options to adjust the default quick edits. For instance, my Radio Buttons for Taxonomies plugin removes the default metabox for taxonomies and replaces it with one that uses radio inputs, which limits the user to a single term choice.
However in the quick edit, this is easily circumvented, because I have no way to remove the taxonomy inputs from being displayed in their default ways.
At the minimum, just adding a filter to the taxonomies would let me disable the default taxonomy inputs and then add my own. More hooks/filters would be ideal, but I think this is the minimum I can get away with.
Sorry it isn't a patch or diff... I'll try to get WordPress set up as a repo on my computer. But in the mean time I'm proposing a change to :
/wp-admin/includes/class-wp-posts-list-table.php file
in the '''inline_edit()''' method, for instance, i'd like to change
{{{
$taxonomy_names = get_object_taxonomies( $screen->post_type );
}}}
to:
{{{
$taxonomy_names = apply_filters( 'inline_edit_taxonomies', get_object_taxonomies( $screen->post_type ), $screen->post_type );
}}}
" helgatheviking
Needs Milestone 20842 Buttons are not on the same line when saving a post as pending (RTL) I18N 3.4 normal normal Awaiting Review defect (bug) new 2012-06-04T23:58:11Z 2012-09-08T22:55:52Z Please check attachment. rasheed
Needs Milestone 21848 A single space in the image caption breaks alignment Media 3.4.2 normal normal Awaiting Review defect (bug) new 2012-09-08T15:07:42Z 2012-09-09T08:53:24Z "If you add just a single space in the caption field of an image using the media uploader, it ignores any alignment settings.
The expected behaviour would mean that regardless of what is entered into the caption box, the image alignment should be honoured." luffer
Needs Milestone 18134 "TinyMCE messes up text when its ""caption"" contains only a space" TinyMCE 3.2.1 normal normal Awaiting Review defect (bug) new 2011-07-15T19:58:23Z 2012-09-09T16:32:03Z "1.) Have a long text [[BR]]
2.) Insert an image inside there with no link pointing anywhere and a caption that contains only a space [[BR]]
3.) Make some -s, numbered lists etc after that [[BR]]
4.) Insert a new image with full size also, and a caption with only a space. [[BR]]
After this everything is messed up. The whole text before the second image becomes the caption of the first image and the second image disappears." szotsaki
Needs Milestone 21862 Don't display show_option_none in wp_dropdown_categories when categories exist Taxonomy normal normal Awaiting Review enhancement new 2012-09-10T15:14:04Z 2012-09-10T15:16:48Z "I can't find an application of having an extra entry for '''show_option_none''' select option if we have category listing. Is there any reason to keep it there, like for external filters? If so, that still conflicts with the second example below.
First off, it is invalid since there are some categories available. Second, having both '''show_option_none''' and '''show_option_all''' displays both entries.
Related to #21856 trying to list only visible terms." nofearinc
Needs Milestone 21610 ssh2/sftp doesn't work with chrooted/openssh sftp-internal user accounts (no shell) albert@… Filesystem 3.4.1 normal normal Awaiting Review feature request new 2012-08-16T16:06:35Z 2012-09-10T18:20:52Z "The current wordpress 3.4.1 wp-admin/includes/class-wp-filesystem-ssh2.php code will crash php or spin in an endless loop when someone supplies ssh/sftp credentials (username/password) to an (open)ssh server where users don't have a shell and are chrooted to their home directory e.g. by using openssh's sftp-internal server and ChrootDirectory functionality.
There is no neat fix for the code in the WP_Filesystem_SSH2 class. I've implemented a new WP_Filesystem_SFTP class making use of the portable phpseclib library.
At this moment it is necessary to change a line in wp-admin/includes/file.php to be able to use WP_Filesystem_SFTP.
Attached is the code for this new class up for review or for anyone with the same problem." albert@…
Needs Milestone 21864 PHPDoc incorrect with the return value of add_*_meta functions Inline Docs 3.4.2 normal normal Awaiting Review defect (bug) new has-patch 2012-09-10T20:54:14Z 2012-09-10T23:37:28Z "The PHPDocs for `add_comment_meta`, `add_post_meta` and `add_user_meta` all say that they return `true` on success. In fact, each calls `add_metadata`, which returns the metadata_id on success.
In addition, `update_metadata` currently returns the metadata_id on success if the metadata did not already exist, but true on success if the metadata did already exist (the PHPDoc says simply that it is true on success).
The patch corrects the documentation, and additionally ensures consistency with the return value for `update_metadata`." mark8barnes
Needs Milestone 21300 Implement autoloader compatible with PSR-0 for plugins and themes General normal normal Awaiting Review feature request new 2012-07-17T21:15:45Z 2012-09-11T02:20:09Z "To provide more compatibility with other frameworks, it would be great if WordPress implemented an autoloader compatible with PSR-0. Plugins and themes could then register namespaces or prefixes with the autoloader.
I believe this could be implemented without any BC breaks.
Details of the PSR-0 standard:
https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-0.md" dave1010
Needs Milestone 21872 RSS Widget, and all of fetch_feed() I believe, forces its own feed order of Post Date DESC General normal normal Awaiting Review defect (bug) new 2012-09-11T15:25:32Z 2012-09-11T15:58:00Z "My events management plugin wanted to provide Upcoming Events via RSS. I wrote a pre_get_posts filter to modify the order and orderby of the event's feed to be Ascending based on a the event's start date, and it was good.
Good, however, for only as long as you don't subscribe to the feed using WordPress (whether it be the event site or one on a totally different network). WordPress, upon fetching the feed, always re-sorts the posts according to the post date. Subscribing with something like iGoogle, will show me my upcoming events in the order that I've coded.
Is this an intentional design decision? It feels to me that the generating site should be responsible for the order of the feed, and WordPress should respect the generating site's wishes and present the feeds in the order it is given." madtownlems
Needs Milestone 21879 wp_count_posts() cache is not destroyed after post inserts and deletions Cache 3.4.2 normal normal Awaiting Review defect (bug) new has-patch 2012-09-13T01:23:38Z 2012-09-13T02:11:19Z "`wp_count_posts()` caches its results, but that cache is not destroyed when posts are inserted, deleted, or transitioned. This can lead to incorrect counts.
The attached patch fixes that (although it doesn't destroy the cache set when `$perm='readable'` in `wp_count_posts()`, which would be more complex as we wouldn't know the name of the key(s), though it could be done with `preg_match`).
" mark8barnes
Needs Milestone 20788 Add widget instance argument to widget_links_args filter Widgets 3.3.2 normal normal Awaiting Review enhancement new dev-feedback 2012-05-30T09:07:13Z 2012-09-13T09:25:07Z "Using the `widget_links_args` filter (used in the default Links Widget class) as it is right now is a bit useless because one does not have access to the widget instance that applies the filter.
Widget instance may contain custom variables set by custom fields that may have been added to the widget form by plugins or themes using other filters.
Being able to access widget instance from within the filter function gives developers lots of possibilities to customize the widget.
My suggestion is simple: add `$instance` argument to the `widget_links_args` filter, like this (wp-includes/default-widget.php line 113):
{{{
wp_list_bookmarks(apply_filters('widget_links_args', array(
'title_before' => $before_title, 'title_after' => $after_title,
'category_before' => $before_widget, 'category_after' => $after_widget,
'show_images' => $show_images, 'show_description' => $show_description,
'show_name' => $show_name, 'show_rating' => $show_rating,
'category' => $category, 'class' => 'linkcat widget'
), $instance ));
}}}" ragulka
Needs Milestone 16863 get_terms hierarchical/hide_empty incompatible with include/exclude args General 3.1 normal normal Awaiting Review defect (bug) new has-patch 2011-03-16T12:37:06Z 2012-09-13T09:36:55Z "{{{
$terms = get_terms('taxName', array(
'hierarchical' => true,
'hide_empty' => true,
'include' => array(1, 2, 3)
));
}}}
$terms will not contain a meaningful result set. In order for get_terms to process 'hierarchical' correctly it must recieve in 'include' a full list of term ids for all child terms that may have count > 0, this obviously negates the point of 'include' here.
'include/exclude' is processed at query level, 'hierarchical' is processed post query and expects the results of the query to be unfiltered.
The following patch seems to fix the issue in my application, I think this approach would need to take in 'child_of' also, which I haven't done here.
{{{
diff --git a/wp-includes/taxonomy.php b/wp-includes/taxonomy.php
index 89532dc..2f51bea 100644
--- a/wp-includes/taxonomy.php
+++ b/wp-includes/taxonomy.php
@@ -1337,9 +1337,13 @@ function &get_terms($taxonomies, $args = '') {
// Make sure we show empty categories that have children.
if ( $hierarchical && $hide_empty && is_array($terms) ) {
+
+ $taxTerms = !(empty($include) && empty($exclude) && empty($exclude_tree)) ?
+ get_terms($taxonomies) : $terms;
+
foreach ( $terms as $k => $term ) {
if ( ! $term->count ) {
- $children = _get_term_children($term->term_id, $terms, $taxonomies[0]);
+ $children = _get_term_children($term->term_id, $taxTerms, $taxonomies[0]);
if ( is_array($children) )
foreach ( $children as $child )
if ( $child->count )
}}}
" martinshopland
Needs Milestone 21881 wp_list_categories show_option_all does not work for custom taxonomy Taxonomy normal normal Awaiting Review defect (bug) new 2012-09-13T12:46:59Z 2012-09-13T13:41:09Z I am using wp_list_categories on a custom post type page to list the taxonomy values (categories). However if I include an All link it links by default to /blog/ and not /taxonomy/. arkinex
Needs Milestone 17993 the_content vs get_the_content Formatting 3.2 normal normal Awaiting Review feature request new close 2011-07-05T14:00:01Z 2012-09-14T17:28:19Z "Wordpress lacks of a main function: obtain full formatted ""content"" without echo! Maybe good to add a param to the_content() like echo(bool)?
I wrote it:
{{{
function the_content_noecho($more_link_text = null, $stripteaser = 0) {
$content = get_the_content($more_link_text, $stripteaser);
$content = apply_filters('the_content', $content);
$content = str_replace(']]>', ']]>', $content);
return $content;
}
}}}
" merlinox
Needs Milestone 18037 inconsistency in filters for the_content and the_excerpt Plugins 3.2 normal normal Awaiting Review enhancement new 2011-07-08T15:59:23Z 2012-09-14T17:28:44Z "My plugin replaces a keytext by a div tag using a filter:
add_filter('the_content', 'my_proc');
This filter appears also to be run in an excerpt, while my div is stripped in the excerpt.
When my div is stripped i want - instead of that div - to print a notification like - Here belongs my div -.
So, either i need a boolean variable or function that tells me that my filter is currently run by a call to the_excerpt(), OR the filter should not be run on the excerpt if it is not added to the excerpts filter list.
I tried a workaround by adding a new filter to the_excerpt and setting my own global to indicate i am in an excerpt, but unfortunately this filter is run after the the_content filter, despite fiddling with filter priorities. So, in a list (archive) the first excerpt is still in error.
The documentation says about filters:
the_content
applied to the post content retrieved from the database, prior to printing on the screen (also used in some other operations, such as trackbacks).
and
the_excerpt
applied to the post excerpt (or post content, if there is no excerpt) retrieved from the database, prior to printing on the screen (also used in some other operations, such as trackbacks).
It appears that not only the_excerpt filters are run on the content if there is no excerpt, what is fine, but it works '''also the other way around:''' the the_content filters are run on the excerpt. This is an inconsistency, and basically my problem." opajaap
Needs Milestone 21791 Enhancement: locate_template() support for multiple file types (not just .php) Template normal normal Awaiting Review enhancement new 2012-09-04T14:59:29Z 2012-09-15T08:10:10Z "I have modified locate_template() to allow location of file types other than .php. The core currently only searches for .php extensions for template file names (search.php, 404.php, etc). I have a HAML parser, and this mod allows the core to locate .haml files (search.haml, 404.haml). Then I can use the 'template_include' filter to handle that file type.
Do you think this is the best way to accomplish it? I also made the function a little more DRY.
{{{
function locate_template($template_names, $load = false, $require_once = true ) {
$located = '';
$template_paths = array(
STYLESHEETPATH,
TEMPLATEPATH
);
$template_file_types = apply_filters('template_file_types', array('php'));
foreach ( (array) $template_names as $template_name ) {
if ( !$template_name )
continue;
foreach($template_file_types as $template_file_type)
{
$template_name_try = str_replace('.php', '.'.$template_file_type, $template_name);
foreach($template_paths as $template_path)
{
$template_name_try = $template_path . '/' . $template_name_try;
if ( file_exists($template_name_try)) {
$located = $template_name_try;
break 3;
}
}
}
}
if ( $load && '' != $located )
load_template( $located, $require_once );
return $located;
}
}}}
you think this modification would be a good core enhancement?" benallfree
Needs Milestone 21899 Missing class identifier for password protected posts Template 3.4.2 normal normal Awaiting Review enhancement new 2012-09-15T17:00:40Z 2012-09-15T17:00:40Z "Password protected posts are insufficiently identified for good CSS styling.
Presently, the class name ""post-password-required"" is added to protected posts if a valid password cannot be found in the cookie. On the other hand, no special class name is added to protected posts if a valid password *can* be found, even though this is just a temporary condition until the cookie expires.
I suggest that both cases are interesting from a CSS styling perspective. Note that the title of protected posts is prefixed by the string ""Protected:"" in both situations.
This behaviour occurs because get_post_class() just checks post_password_required() [which validates the cookie] but get_the_title() just checks if the $post->post_password field is not empty.
I suggest an additional class name should be added by get_post_class() for the case when the post->post_password field is not empty. Current usage of class names here is not very consistent with the admin tool, so options might be ""visibility-protected"", ""status-protected"" [similar to ""status-private"" which is added for those with visibility ""Private"" and reflecting the underlying implementation] or perhaps just simply ""protected"".
Protected posts would thus be identified as follows:
Protected, with correct password: class=""protected""[[BR]]
Protected, missing or invalid password: class=""protected post-password-required""
See also #13860 and #18729. I can do a patch if needed but this is literally just a couple of lines of code (three if you include a comment)." mdgl
Needs Milestone 21826 There should be more filters when displaying a theme in the list table Administration 3.4 normal normal Awaiting Review enhancement new has-patch 2012-09-06T22:54:43Z 2012-09-15T22:27:50Z "In `WP_Themes_List_Table::display_rows()`, there is a filter for the theme actions, but no filters for the theme information itself: screenshot, title, author, version, and description. Why not fix that?
The attached patch introduces `theme_list_*` filters within the `display_rows()` method. Suppressing one of the pieces of information is simply a matter of returning an empty value through the filter." ethitter
Needs Milestone 18671 Allow themes to set default widgets Widgets 3.3 normal normal Awaiting Review enhancement new 2011-09-15T06:52:41Z 2012-09-16T13:24:25Z "Rather than having to use a hard-coded fallback HTML sidebar, it'd be cool if a theme could set up default widgets.
#17979 will somewhat remove the need for this but it could still be useful." Viper007Bond
Needs Milestone 21788 Relocate revoke_super_admin() and grant_super_admin() to capabilities.php Role/Capability normal normal Awaiting Review defect (bug) new 2012-09-04T11:09:57Z 2012-09-16T21:32:38Z "Would be nice to move revoke_super_admin() and grant_super_admin() out of /wp-admin/includes/ms.php and into to /wp-includes/capabilities.php, where the rest of the _super_admin() functions are.
This allows theme-side user profile plugins (see: the bb's) to use these functions without needing to pull in a wp-admin file directly." johnjamesjacoby
Needs Milestone 19915 Add unit tests for AtomPub API rmccue AtomPub normal normal Awaiting Review enhancement new 2012-01-28T16:25:15Z 2012-09-17T05:52:57Z "Apologies if this is a duplicate, I couldn't find any.
The AtomPub API is hideously under-tested. Since it's a part of WordPress that doesn't get touched often, it's also one of the most crucial components that needs testing.
I'm working on [https://github.com/rmccue/Gorilla a test runner called Gorilla], which is designed as a replacement for the APE (Atom Protocol Exerciser). This will have a port of all the APE unit tests to PHP, and I'm also going to start writing some new ones for all the new APIs that are being added in #18430, #18431, #18432 and #18433.
These are specifically designed to be able to be independent of Gorilla, so that it will be easy to bring into a normal PHPUnit test suite, and hopefully will be able to run as part of the normal WordPress unit test suite. (Although they'll still need some components of Gorilla to work)
(This is filed under Unit Tests, but AtomPub might be a better component)" rmccue
Needs Milestone 21330 Allow filtering of expiration in set_transient() Cache normal normal Awaiting Review enhancement new dev-feedback 2012-07-20T20:51:23Z 2012-09-17T18:32:01Z I recently needed to change an expiration of a transient and expected pre_set_site_transient_* filter to be able to do that. However, the filter only affects the value. I recommend adjusting this to affect both. wpsmith
Needs Milestone 19203 Fixed a couple of function descriptions in wp-includes/plugin.php Inline Docs 1.5 normal normal Awaiting Review enhancement new has-patch 2011-11-08T05:53:54Z 2012-09-17T21:28:25Z "There were a couple of errors I found in the function docblocks while tinkering in the plugins.php file as well as a confusing example, so here's what I fixed:
'''add_filter()''':
It mentioned filters were for modifying ""strings"", which isn't correct since you can also use filters to modify arrays, etc., so I changed the docblock to reflect this.
I also changed the example code to {{{ var_dump($example); }}} instead of {{{ echo $example; }}} since echoing arrays/objects etc. will cause an error.
'''apply_filters()''':
The example code block was confusing since it specified a filter function, but didn't show it being added and then just called apply_filters(), which I didn't notice the relation at first.
I added the {{{add_filter()}}} function in the code example for a clearer example so the reader will better understand the usage of this function.
'''_wp_call_all_hook()''':
A mysterious '''$hook''' parameter was defined in the docblock, however the parameter simply doesn't exist. Not sure if this was a passing thought or someone falling asleep while writing it, but I've removed it from the docblock.
Thanks!" amereservant
Needs Milestone 21845 Losing comment reply by accidentally clicking on another comment Comments 3.4.2 normal normal Awaiting Review defect (bug) new 2012-09-08T13:17:20Z 2012-09-17T22:31:50Z "This is a usability bug.
When replying to a comment in the Edit Comments (wp-admin/edit-comments.php) page, double-clicking on another comment will open that comment for editing and wipe away the reply you were writing.
If you want to highlight a word to copy from the comment that you are replying to this can be done by double-clicking the word. So completely by accident your reply is wiped out. This occurred on wordpress.com so I'm guessing their using the latest 3.4.2 version." icc97
Needs Milestone 19023 Images in Edit Comments break SSL nacin Administration 3.2.1 high normal Awaiting Review enhancement reviewing dev-feedback 2011-10-21T11:19:43Z 2012-09-17T22:52:02Z "In trunk, when I'm on my edit comments page, the SSL get's broken because of an attachment image that isn't served over SSL:
[http://uploads.yoast.nl/Comments-20111021-131843.png]" joostdevalk
Needs Milestone 21918 WP_Customize_Control() doesn't work with add_setting() default theme_mod type Themes 3.4.2 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-09-18T11:29:03Z 2012-09-18T13:54:58Z "Consider the following code:
{{{
$wp_customize->add_setting($color,array(
'default' => '#000000',
'sanitize_callback' => 'sanitize_hex_color',
'capability' => 'edit_theme_options',
'transport' => 'postMessage'
)
);
$wp_customize->add_control(new WP_Customize_Color_Control($wp_customize,$color,array(
'label' => 'somelabel',
'section' => 'colors'
)
)
);
}}}
The default 'type' used for add_setting() is 'theme_mod' as defined in http://codex.wordpress.org/Class_Reference%5CWP_Customize_Manager%5Cadd_setting
The WP_Customize_Color_Control '''does not''' accept the 'default' setting when there is no 'type' specified.
The WP_Customize_Color_Control '''does accept''' the 'default' setting when 'type' is either set to 'option' or 'theme_mods'.
Setting it to 'option' makes no sense because that would imply that one would be using a custom option database field with get_option() instead of the default database field used by get_theme_mod().
Because setting it to 'theme_mods' works and 'theme_mod' does not i suggest checking code for typos.
Expected behavior would be for it to work with theme_mod/get_theme_mod stored values when the default 'type' is used." sebstyle
Needs Milestone 21919 Theme Customizer: loading preview with FORCE_SSL_ADMIN does not work Multisite 3.4.2 normal normal Awaiting Review defect (bug) new 2012-09-18T14:17:28Z 2012-09-18T14:17:28Z "When FORCE_SSL_ADMIN is configured theme customizer JQuery will try and load the theme preview over ssl and get a 302 redirect error.
The path is
https://site.com/?customize_messenger_channel=preview...
redirects to
http://site.com/?customize_messenger_channel=preview...
since site is non-SSL." Jasonheffner
Needs Milestone 21374 Add core support for letting custom permalink structure for different post types Rewrite Rules 3.4.1 normal normal Awaiting Review enhancement new 2012-07-25T14:42:15Z 2012-09-19T09:56:07Z "By default, custom post types uses only the'' %postname%'' permalink structure (if using pretty links and not default query variables).
Currently there is no native way to easily have different permastructs for different CPT.
This features should be added to the '''register_post_type()''' function, letting different permalink structure be defined to each post_type being registered.
I sugget adding another new key to the '''rewrite''' array that can be passed to the '''register_post_type()''' function.
i.e. -
{{{
register_post_type('event',array(
......
'rewrite' => array('slug' => 'events',
'permastruct' => '%year%/%monthnum%/%event%'
),
.....
));
}}}
The register_post_type function should be changed, a suggestion for such a change may be that instead of this line in the function - (post.php line#1075)
{{{
add_permastruct( $post_type, ""{$args->rewrite['slug']}/%$post_type%"", $args->rewrite );
}}}
This example could be used -
{{{
if ( $args->rewrite['permastruct'] ) {
$perma_structure = $args->rewrite['permastruct'];
$wp_rewrite->add_rewrite_tag(""%{$post_type}%"", '([^/]+)', ""{$post_type}="");
$wp_rewrite->add_permastruct($post_type, $archive_slug.'/'.$perma_structure, false);
}
else {
add_permastruct( $post_type, ""{$args->rewrite['slug']}/%$post_type%"", $args->rewrite );
}
}}}
In order that the structure can interpret the permastruct tags, I added also this function to filter post_type_link, it is adapted from '''get_permalink''' function in ''wp-includes/link-template.php'' -
{{{
add_filter('post_type_link', 'tc_permalink', 10, 3);
function tc_permalink($permalink, $post_id, $leavename) {
$post = get_post($post_id);
$rewritecode = array(
'%year%',
'%monthnum%',
'%day%',
'%hour%',
'%minute%',
'%second%',
$leavename? '' : '%postname%',
'%post_id%',
'%category%',
'%author%',
$leavename? '' : '%pagename%',
);
if ( '' != $permalink && !in_array($post->post_status, array('draft', 'pending', 'auto-draft')) ) {
$unixtime = strtotime($post->post_date);
$category = '';
if ( strpos($permalink, '%category%') !== false ) {
$cats = get_the_category($post->ID);
if ( $cats ) {
usort($cats, '_usort_terms_by_ID'); // order by ID
$category = $cats[0]->slug;
if ( $parent = $cats[0]->parent )
$category = get_category_parents($parent, false, '/', true) . $category;
}
// show default category in permalinks, without
// having to assign it explicitly
if ( empty($category) ) {
$default_category = get_category( get_option( 'default_category' ) );
$category = is_wp_error( $default_category ) ? '' : $default_category->slug;
}
}
$author = '';
if ( strpos($permalink, '%author%') !== false ) {
$authordata = get_userdata($post->post_author);
$author = $authordata->user_nicename;
}
$date = explode("" "",date('Y m d H i s', $unixtime));
$rewritereplace =
array(
$date[0],
$date[1],
$date[2],
$date[3],
$date[4],
$date[5],
$post->post_name,
$post->ID,
$category,
$author,
$post->post_name,
);
$permalink = str_replace($rewritecode, $rewritereplace, $permalink);
} else { // if they're not using the fancy permalink option
}
return $permalink;
}
}}}
On a basic check this seems to be working, but ofcourse needed to be more deubgged.. I will be happy to here if you think such a feature should be added to core." maorb
Needs Milestone 21924 add action / filter to wp-login.php so we can replace WordPress login and force using 3rd party login Security normal normal Awaiting Review feature request new 2012-09-19T11:59:58Z 2012-09-19T11:59:58Z "I want to turn off WordPress login because I don't have an SSL certificate. I want to replace (not just hide with CSS or something) the WordPress wp-login.php login form so that a plugin can hook into that and be called within themes that use the hook to display the WordPress login form. Then, if the plugin is disabled, the generic WordPress login will display by default/fallback.
Worst concern about this is the plugin failing, especially upon an update or theme change or something and this can be fixed by logging in and disabling the plugin via FTP or via database or something.
(Of course, applies to both ""login"" and ""register"", not just ""login"".)
What I tried before posting here:
http://premium.wpmudev.org/forums/topic/is-there-a-plugin-to-disable-wordpress-default-login?replies=9#post-276574
and
http://www.wpquestions.com/question/show/id/7065
Might be related to:
http://core.trac.wordpress.org/ticket/19097
Thank you very much." cliffpaulick
Needs Milestone 14539 Cache-Control / Expires headers not applied to files in Multisite files location Multisite 3.0.1 normal normal Awaiting Review defect (bug) new dev-feedback 2010-08-05T04:21:33Z 2012-09-19T16:02:17Z "First reported in Multisite forum and detailed there:
[http://wordpress.org/support/topic/cache-control-headers-and-uploaded-files-not?replies=5]
These file type accesses should return 304s according to the rules in .htaccess but consistently return 200, showing an incorrect Cache-Control header specification, instead of no specification at all--which is still undesired.
This occurs in two 3.0.1 Multisite installs on all blogs, domain mapped or not, but does not occur on any other domains on the server or in any other file locations in the WP tree (themes, etc.).
Initially, it was image files that I had identified this on but a subsequent check of a CSS file in the files/ location returned the same header that is set for (.php|.pl|.cgi) files; same as the image files do.
Apache 2.2.15, PHP 5.2.13, FreeBSD 7.2-STABLE, MySQL 5.0.90
" spherical
Needs Milestone 21945 wp_list_categories feed links unaware of custom type Post Types 3.4.1 normal normal Awaiting Review defect (bug) new 2012-09-20T19:40:27Z 2012-09-20T20:35:47Z "wp_list_categories accepts a taxonomy argument to specify a custom taxonomy, and correctly lists item of said taxonomy. However the feed links produced lack the necessary ?post_type= for the corresponding custom post types that may be used with a category.
Ideally the function could auto-detect stuff and do the right thing automatically. Less ideally it might accept another argument to define the post types used in the category. At a minimum, this should be documented, and a work-around such as the following included:
{{{
function wp_list_cat_custom_feed($txt){
return preg_replace('/\/feed\/?/', '/feed/?post_type=foo', $txt);
}
add_filter('wp_list_categories','wp_list_cat_custom_feed');
}}}
" belg4mit
Needs Milestone 21934 Title field on Insert/edit link form shouldn't allow autosuggest Editor 3.4.2 normal normal Awaiting Review defect (bug) new dev-feedback 2012-09-19T21:10:18Z 2012-09-20T22:37:44Z "When entering a link through the ""Insert/edit link"" thickbox form, Firefox displays autosuggest dropdowns for both the URL field and the title field.
This would be helpful, except that the javascript keyboard handlers bound on keydown/keyup prevent the browser UI from being accessible.
What happens is:
1. User tries to add link to text through the editor (Visual or HTML).
1. User enters the correct URL into the URL field, and exits that field by hitting ""tab"".
1. User begins typing the link title. Firefox browser UI helpfully suggests some similar titles.
1. User sees a title they'd like to use, and hit the keyboard down arrow, thinking that this will select the correct title for them.
1. What actually happens is that the first link listed below in the link to existing content gets selected. This overwrites what's been entered in the URL and title field.
1. User says, WTF just happened.
Solutions:
- Adding `autocomplete=""off""` to these two form fields would prevent Firefox from displaying its autosuggestions. This might fix the problem, but feels kind of like a bandaid.
- A keydown/keyup handler could be attached to each of the text input fields with event.stopPropagation could stop the ui keyboard behavior when typing into those fields." goldenapples
Needs Milestone 18943 Scroll back to previous editor position after post save/update Editor 3.2.1 normal normal Awaiting Review enhancement new 2011-10-14T10:23:05Z 2012-09-21T14:38:47Z "I work exclusively in html mode in the WordPress editor, but this probably applies to the visual mode too.
When editing long(ish) posts it is really frustrating that the cursor position defaults to the beginning of the post after saving/updating.
Constantly having to manually scroll back down to the previous cursor position after updating, soon gets really tedious.
Focus always seems to be returned to the post title text box after saving/updating a post. It would be more intuitive to return focus to the main editor instead and automatically jump to the previous cursor position." dgwyer
Needs Milestone 21931 White screen of death if theme can't be found Themes normal normal Awaiting Review enhancement reopened dev-feedback 2012-09-19T16:55:39Z 2012-09-21T15:31:41Z "If the current theme can't be found or is renamed, the front-end of the site will white screen. This is developer error, as when WP_USE_THEMES is true, the template loader should always have a template to load (as far as I understand).
It's rare, but I come across it every once in a while in developing. It might be nice to have a wp_die() if a proper template can't be found in template-loader.
Proof of concept:
{{{
if ( $template = apply_filters( 'template_include', $template ) )
include( $template );
else
wp_die(""Whoops! Looks like you're missing a theme."");
}}}" ericlewis
Needs Milestone 21959 No way to override the name of an image when that is being resized Media 3.4.2 normal normal Awaiting Review enhancement new needs-docs 2012-09-21T16:34:23Z 2012-09-22T20:42:44Z "The most obvious solution is to add a hook to allow the destination file name to be modified.
The solution attached gives pretty much all the information you could possibly want to modify the filename as you might need to." jkmassel
Needs Milestone 18684 XMLRPC metaWeblog.newMediaObject doesn't have possibility for setting excerpt/content XML-RPC 3.2.1 normal normal Awaiting Review enhancement new has-patch 2011-09-16T12:10:20Z 2012-09-23T19:30:22Z XMLRPC metaWeblog.newMediaObject method only sets empty content for attachment and doesn't have possibility for setting excerpt and/or content for attachments. skithund
Needs Milestone 21982 check wp_authenticate_cookie Users 3.4.2 normal normal Awaiting Review enhancement new has-patch 2012-09-24T06:45:56Z 2012-09-24T06:45:56Z "I am analyzing the authentication system wordpress, caught my atension the function logic `wp_authenticate_cookie` in (`wp-includes/user.php`) and decided to make a very small change.
>I made a file of changes:
> https://gist.github.com/3774628" fitorec
Needs Milestone 21988 Filter get_media_item output Media 3.4 normal normal Awaiting Review enhancement new dev-feedback 2012-09-25T03:56:27Z 2012-09-25T09:38:43Z "L1027-1028 of media.php looks like this:
{{{
if ( $item = get_media_item( $id, array( 'errors' => isset($errors[$id]) ? $errors[$id] : null) ) )
$output .= ""\n"";
}}}
The biggest issue I see with this is that because you can only attach images to one post, this will unnecessarily display images that cannot be attached to the current post type in instances where the Media Library tab is forced to send items even though no editor support has been added for the post type.
In that light, it would be nice to have a filter to remove the output of these unnecessary items in order to improve UI and UX when navigating through images to attach to the post type. Currently I am having to create an error-like overlay on each item that is already attached in order to prevent users from trying to attach an item that is already attached elsewhere.
Where would it make the most sense to have this filter? At the end of get_media_item? " griffinjt
Needs Milestone 21999 Passing cookie arguments to the HTTP API should be easier HTTP 3.4.2 normal normal Awaiting Review enhancement new 2012-09-26T06:24:38Z 2012-09-26T06:24:38Z "If you want to set cookies during a remote HTTP request in WordPress, it's currently a rather pain in the ass to do.
Rather than having to deal with `WP_HTTP_Cookie`, it'd be nice if you could just pass a `name => value` array and have the rest taken care for you behind the scenes." Viper007Bond
Needs Milestone 21282 Introduce wp_header() pluggable function General 3.4.1 normal normal Awaiting Review enhancement new dev-feedback 2012-07-15T12:47:22Z 2012-09-26T15:46:20Z "I will be nice to have pluggable function wrapper for PHP `header()` function - this will allow to unit test HTTP headers sent by WordPress. Attached patch adds it, and replaces all existing calls to `header()` with it.
Question: some of exiting calls had errors silenced using `@`, some not. In my code I added `@`. Should I keep it, remove it or maybe add extra param to function to conditionally silence errors?" sirzooro
Needs Milestone 22003 Saving custom fields goes to post-new.php rather than post.php Administration 2.5 normal normal Awaiting Review defect (bug) reopened 2012-09-26T15:57:01Z 2012-09-26T19:19:54Z "Create a new post or page.
Add a title and message.
Add a custom field (click ""Add Custom Field"")
The post is saved, but as you are taken to post-new.php rather than post.php, it looks as if your post has disappeared! All is well - it is actually saved - but it's confusing.
Tested on 3.5-alpha-21989" curiousdannii
Needs Milestone 22009 Menu Builder URL structure Menus 3.4.2 normal normal Awaiting Review enhancement new 2012-09-26T21:16:12Z 2012-09-26T21:16:12Z "Menu builder is a great functionality, but I can't figured it out why URL structure is based on page builder rather than menu builder?[[BR]]
In my point of view, it would make more sense if we could define a simple ""identifier"" for each page (ie : ""my-page"" for a page named ""My page"") and build architecture in menu builder (or make it optional) --> the URL structure will be generate base on the menu builder hierarchy.[[BR]]
Actually, when moving an element, we have to define a new parent in the page builder to follow the menu logic?" will83
Needs Milestone 22010 RSS Widget with hardcoded icon and style Widgets normal normal Awaiting Review defect (bug) new 2012-09-26T22:13:58Z 2012-09-26T22:13:58Z "Standard RSS Widget outputs hardcoded icon and oldschool inline style=""border:0"" e.g.
{{{
before the .
I expected wpautop would find no newlines and return the original string.
The same string placed inside a HTML5 or XHTML 1 Strict document is parsed as valid by W3C Validator.
Plugins acting on the_content with a priority less than 10 may have their single-line markup reinterpreted by wpautop." niallkennedy
Needs Milestone 22110 Check for current conditional General 3.4 normal normal Awaiting Review enhancement new 2012-10-05T17:12:18Z 2012-10-11T00:37:05Z "More than once I've needed a programmatic way to determine what page is being displayed, for example when implementing event tracking recently:
{{{
add_action( 'wp_enqueue_scripts', function() {
wp_enqueue_script( 'my-site', get_template_directory_uri() . '/js/mysite.js', array( 'jquery' ), '1', true );
// Figure out what type of page we're on
$is = '';
foreach ( $GLOBALS['wp_query'] as $key => $value ) {
if ( true === $value && 'is_' === substr( $key, 0, 3 ) ) {
$is = substr( $key, 3, strlen($key) );
break;
}
}
wp_localize_script( 'my-site', 'event_tracking', array(
'category' => $is,
) );
} );
}}}
And then used like:
{{{
Action
}}}
Now granted the above way to determine the current page is a little janky, and has at least one flaw (on custom post type archives because both ""is_archive"" and ""is_post_type_archive"" are set, and it will find ""is_archive"" first, every time). TBH this was me with a bowl of chili in one hand trying to avoid typing out ""if ( is_* ) { } elseif ( is_* ) { } elseif ( is_* ) {} ..."".
A saner function would probably explicitly check each conditional, which would make it a little more tedious but also more maintainable:
{{{
function where_am_i( $return = 'simple' ) {
global $wp_query;
if ( ! isset( $wp_query ) ) {
_doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the query is run. Before then, they always return false.' ), '3.5' );
return false;
}
$primary = null;
$secondary = null;
$tertiary = null;
// Tried to maintain the hierarchy from query.php
if ( true === $wp_query->is_robots ) {
$primary = 'robots';
} elseif ( true === $wp_query->is_attachment ) {
$primary = 'attachment';
$secondary = 'single';
$tertiary = 'singular';
} elseif ( true === $wp_query->is_page ) {
$primary = 'page';
$tertiary = 'singular';
} elseif ( true === $wp_query->is_single ) {
$primary = 'single';
$secondary = 'singular';
} elseif ( true === $wp_query->is_search ) {
$primary = 'search';
} elseif ( true === $wp_query->is_time ) {
$primary = 'time';
$secondary = 'date';
$tertiary = 'archive';
} elseif ( true === $wp_query->is_day ) {
$primary = 'day';
$secondary = 'date';
$tertiary = 'archive';
} elseif ( true === $wp_query->is_month ) {
$primary = 'month';
$secondary = 'date';
$tertiary = 'archive';
} elseif ( true === $wp_query->is_year ) {
$primary = 'year';
$secondary = 'date';
$tertiary = 'archive';
} elseif ( true === $wp_query->is_date ) {
$primary = 'date';
$secondary = 'archive';
} elseif ( true === $wp_query->is_category ) {
$primary = 'category';
$secondary = 'archive';
} elseif ( true === $wp_query->is_tag ) {
$primary = 'tag';
$secondary = 'archive';
} elseif ( true === $wp_query->is_tax ) {
$primary = 'custom_taxonomy';
$secondary = 'archive';
} elseif ( true === $wp_query->is_author ) {
$primary = 'author';
$secondary = 'archive';
} elseif ( true === $wp_query->is_post_type_archive ) {
$primary = 'post_type';
$secondary = 'archive';
} elseif ( true === $wp_query->is_feed ) {
$primary = 'feed';
} elseif ( true === $wp_query->is_trackback ) {
$primary = 'trackback';
} elseif ( true === $wp_query->is_comments_popup ) {
$primary = 'comments_popup';
$secondary = 'comments';
} elseif ( true === $wp_query->is_preview ) {
$primary = 'preview';
$secondary = 'singular';
} elseif ( true === $wp_query->is_admin ) {
$primary = 'admin';
} elseif ( true === $wp_query->is_comment_feed ) {
$primary = 'comment_feed';
$secondary = 'comments';
$tertiary = 'feed';
} elseif ( true === $wp_query->is_404 ) {
$primary = '404';
$secondary = 'singular';
} elseif ( true === $wp_query->is_home ) {
$primary = 'home';
if ( true === $wp_query->is_posts_page ) {
$secondary = 'posts_page';
$tertiary = 'page';
} else {
$secondary = 'static_page';
}
}
if ( 'detailed' === $return ) {
$details = compact( $primary, $secondary, $tertiary );
$details = array_filter( $details ); // Remove empty
return $details;
}
// 'simple' === $return
return $primary;
}
}}}
Should it use $wp_the_query so that it always acts on the main query? " mintindeed
Needs Milestone 22135 Special characters in caption lead to failure of inserting images Media 3.4.2 normal normal Awaiting Review defect (bug) new dev-feedback 2012-10-08T21:25:46Z 2012-10-11T16:26:47Z "Found this when double-checking #22132:
1. Go to add a new post.
2. Click ""Upload/Insert"" (the ""old"" media upload).
3. Upload an image, or go to choose one from the media library.
4. Insert {{{Title""}}} in the ""Caption"" field.
5. Click ""Insert into Post"".
Instead of the image (or Shortcode) being added to the editor (with a somehow escaped caption field), the media upload iframe just gets a new content:
{{{
[/caption]'); /* ]]> */
}}}
Reproduced in 3.4.2 and trunk." TobiasBg
Needs Milestone 18692 wp_insert_post() enhancements General 3.2.1 normal normal Awaiting Review enhancement new dev-feedback 2011-09-17T21:33:12Z 2012-10-12T08:41:53Z "I have created enhancement for `wp_insert_post()` function. There re two changes:[[BR]]
- allows to return WP_Error from `wp_insert_post_data` - in this case function returns that value (or 0 if param `$wp_error == false`) and do not continue;[[BR]]
- filter categories, tags and other taxonomies through new filters: `wp_insert_post_category`, `wp_insert_post_tags` and `wp_insert_post_tax`. New code also checks if these filters returned WP_Error;
These changes will allow me to implement following features in my [http://wordpress.org/extend/plugins/wypiekacz/ WyPiekacz] plugin:[[BR]]
- do not create new post when it does not satisfy appropriate rules. Although WP code will not display that error by itself (#10480, #18266), I will be able to display appropriate error from plugin code (at least when normal editor was used). This will also help me to stop flood of automated post spam;[[BR]]
- allow to review tags attached to post submitted for review - this way tags will be actually created when post will be published; before this they will be stored as post metadata. In order to do this I need to modify tags - unfortunately `wp_insert_post_data` filter does not allow to modify them (it allows read-only access to them only)." sirzooro
Needs Milestone 21691 WPLANG not settable in multisite if there are no language files Multisite normal normal Awaiting Review defect (bug) new close 2012-08-26T11:16:24Z 2012-10-12T13:26:56Z "I got a plugin running on a multisite and there is definitely something up with the translation.
I tracked the problem down to the WPLANG option in `http://localhost//wp-admin/options.php` being empty. I tried to update it, but it keeps reverting to blank. So down the line the issue with get_locale() looking for the WPLANG value in the site_options and then defaulting back to en_US because it's not picking it up from the wp-config.php defined WPLANG.
I'm assuming that the defined WPLANG in the wp-config.php does not apply in multisite instances. The plugin is only enabled on the separate blog instance, and I changed the translation in wp-config.php after the install if that has anything to do with it.
Simple filter to force the locale in the plugin for the moment:
{{{
function modify_locale(){
return 'de_DE';
}
add_filter('locale','modify_locale');
}}}
I hope someone can reproduce this issue." foxinni
Needs Milestone 22172 Localized strings not applied in notification email I18N 3.4 normal normal Awaiting Review defect (bug) new 2012-10-12T12:02:28Z 2012-10-12T16:51:59Z "After user registration and activation (multisite), administrator receive email (function wpmu_signup_user_notification() in wp-includes/ms-functions.php). But content of this email is not translated even if localization file contains translated strings.
{{{
New User: %1s\n
Remote IP: %2s\n
\n
Disable these notifications: %3s
}}}
Email subject is localized, but content not. I am not sure about the cause of this problem..." pavelevap
Needs Milestone 19543 Broken formatting when using HTML5 element Formatting 3.3 normal normal Awaiting Review defect (bug) new needs-unit-tests 2011-12-14T10:32:07Z 2012-10-12T18:25:51Z "When using HTML5 element, the resulting markup is invalid because some paragraphs isn't closed properly.
Reproduced with WP 3.3, TwentyEleven theme and no plugins.
Example markup attached to this ticket. Paste into html view of the WYSIWYG editor and publish. Resulting markup also attached. " exz
Needs Milestone 19877 wp_kses_stripslashes() should account for single quotes too Formatting 3.3.1 normal normal Awaiting Review defect (bug) new close 2012-01-23T14:17:48Z 2012-10-12T20:36:43Z "Right now, wp_kses_stripslashes() only removes slashes before double quotes, but should do the same for single quotes.
For example, if wp_kses() is applied to the following string (assuming
If the single quotes are switched to double quotes, the attributes are properly sanitized against the list of allowed tags passed to wp_kses(). Updating wp_kses_stripslashes() to account for both types of quotes eliminates the need to strip slashes before applying wp_kses()." ethitter
Needs Milestone 21900 update_post_meta() returns FALSE when meta_value to be updated is the same General 3.4.2 normal normal Awaiting Review defect (bug) new 2012-09-15T17:15:17Z 2012-10-13T00:52:12Z "Since [14564] update_metadata() (wp-includes/meta.php [20435]) in lines 129-136 checks to see if the meta_value to be updated is the same as the value that already exists in the database. The point of this check, presumably, is to prevent running a needless UPDATE query. That's fine and good.
Currently, if the values are the same the function returns FALSE. I think it should return TRUE in this case. While I understand that from one point of view it should be false, since nothing was actually updated, if I'm trying to update my metadata to a certain value, and the end result is that the value in the database matches the value I submitted, isn't that a win? In other words, even though no UPDATE query was actually executed, the postmeta was ""updated"" to have the value that was specified in update_post_meta().
Here's an example of when this could be an issue:
{{{
function my_plugin_ajax_save_metadata() {
// create a success flag
$success = true;
// $postid passed in via post variables
$postid = $_POST[ 'postid' ];
// data fields from post passed in from a serialized array
parse_str( $_POST[ 'data' ], $fields );
// my custom post meta fields all have names that begin with _mymeta
foreach( $fields as $key => $val ) {
// if a field is one of my meta fields, attempt to update it
if ( false !== strpos( $key, '_mymeta' ) ) {
// if $val is the same as what's already in the db, $success will be false
$success = update_post_meta( $postid, $key, $val );
}
if ( false === $success ) {
// uh-oh, update_post_meta failed, need to handle it
// but updating a meta value to the same value is not really a fail
$message = ""Error updating metadata: $key = $val"";
break;
}
}
echo ( $success ) ? 'Success.' : $message;
exit;
}
add_action( 'wp_ajax_save_meta', 'my_plugin_ajax_save_metadata' );
}}}
Of course, I could use get_post_meta() to find out if values have changed before calling update_post_meta(), but since update_metadata() already does this (line 131), it seems wasteful for me to have to do it.
I guess another alternative would be to return something besides TRUE or FALSE when the values are the same, but I'm not sure what that would be.
" mcbenton
Needs Milestone 21414 "Use the ""Keyboard Shortcuts"" checkbox in the user profile to turn on/off all custom shortcuts" Accessibility normal normal Awaiting Review enhancement new 2012-07-29T20:24:36Z 2012-10-14T11:42:23Z "Custom keyboard shortcuts can be very handy not only for better accessibility but for faster access to many actions that usually require ""mousing"". For example we could potentially add shortcuts to access the top menu items or the more commonly used toolbar items.
However many of the available keystrokes (modifier [+ modifier] + letter) are already in use. Even worse, different shortcuts are in use in different browsers and different OS.
It would be good to let the users decide whether to enable them. As we already have a checkbox for the comment moderation shortcuts, best would be to make it ""global"". For now that would only affect TinyMCE." azaozz
Needs Milestone 18471 Add action hook after cron processed it's jobs Cron 3.2.1 normal normal Awaiting Review enhancement new has-patch 2011-08-18T12:30:19Z 2012-10-15T01:26:35Z Sometimes it's hard to debug cron jobs or validate the results. A simple action fired after the wp-cron.php did his magic could help improve this experience. tott
Needs Milestone 21672 Custom menu memory problem Menus 3.4.1 normal normal Awaiting Review defect (bug) new 2012-08-23T18:53:46Z 2012-10-15T08:38:03Z "I found some strange memory problem related to updating custom menu. One website is using about 22 MB from 128 available (memory_limit). But when trying to update custom menu, there is error related to unsufficient memory.
This custom menu has about 100 items, I also tried to export it to my PC and testing memory uasge. There are some strange results...
In file wp-admin/nav-menus.php there is following line:
{{{
$menu_item_db_id = wp_update_nav_menu_item( $nav_menu_selected_id, ( $_POST['menu-item-db-id'][$_key] != $_key ? 0 : $_key ), $args );
}}}
When I set memory checks before and after this line, then there are following results on my testing environment, for example:
{{{
Before: 25.28 MB
After: 25.29 MB
}}}
I added also some checks directly into wp_update_nav_menu_item() function and there are some small peaks (about 1 MB). But in the end (after this function) everything is somehow reset and memory usage is as low as in the beginning.
But when I test it with affected hosting, there are following results:
{{{
Before: 26.59 MB
After: 27.77 MB
}}}
So everytime wp_update_nav_menu_item() is running, 1 MB more is needed on this server and there is no reset. And because it is foreach cycle and menu has more than 100 items, then more then 128 MB is needed.
Same conditions, but one server needs more than 128 MB memory_limit and my local environment works well with 32 MB. There is no other problem with this hosting, everything works, no special server settings. Any ideas?" pavelevap
Needs Milestone 20712 "Wrong data type returned from get_option for ""page_on_front"" after update_option" General 3.3.2 normal normal Awaiting Review defect (bug) new has-patch 2012-05-20T08:29:35Z 2012-10-15T10:22:59Z "
{{{
echo gettype(get_option(""page_on_front"")); // return string
update_option(""page_on_front"", ""123"");
echo gettype(get_option(""page_on_front"")); // return integer
}}}
You can repeat the steps and it give consistent result, so `get_option` return the wrong data type ONLY when it is after `update_option`" tszming
Needs Milestone 22196 add $wpdb->upsert function Database 3.4.2 normal normal Awaiting Review enhancement new 2012-10-15T12:48:33Z 2012-10-15T14:53:24Z "If i read http://codex.wordpress.org/Class_Reference/wpdb right, we have only insert and update functions, but for many occations, if would be lovely, if we would have upsert function as well (using INSERT ... ON DUPLICATE KEY UPDATE http://dev.mysql.com/doc/refman/5.1/en/insert-on-duplicate.html).
So when i am inserting e.g. posts using database function, i do not have to check if post with that id exist (good for some migration / importing tools etc.)" thomask
Needs Milestone 17718 Don't redirect if user is already on port 80 Canonical 3.1.3 normal normal Awaiting Review defect (bug) new has-patch 2011-06-07T11:31:40Z 2012-10-16T16:36:46Z "If user is already using port 80 but {{{$original['port']}}} is set to 80 anyway, do not send a needless redirect.
wp-includes/canonical.php line 324
change from
{{{ if ( !empty( $original['port'] ) )}}}
change to
{{{ if ( !empty( $original['port'] ) && $original['port'] != 80 )}}}
Fixes, for example, Nagios's check_http getting sent a redirect rather than the page content.
-davidc" davidcx
Needs Milestone 20395 Chrome does not showing anchors at images in administration TinyMCE 3.4 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-04-08T16:20:04Z 2012-10-17T00:36:57Z "Hello,
For a long time I seeing bug in Wordpress administration. This bug is showing only at Chrome. When I creating new post and insert images from Media library, I do not see anchors at image.
Screenshot: http://postimage.org/image/co0400t0h/
Thanks." neteyescz
Needs Milestone 22209 Simplify logic to generate home path when parsing request Query normal normal Awaiting Review enhancement new has-patch 2012-10-17T03:37:24Z 2012-10-17T04:25:45Z In `WP::parse_request()` we go through a few steps to generate the `$home_path` variable. Since we now require PHP 5.2, we can use `parse_url()`'s second argument to get the path directly. evansolomon
Needs Milestone 19358 Add action to add content after the h2 of a post type screens Post Types normal normal Awaiting Review enhancement reopened 2011-11-25T13:20:07Z 2012-10-17T21:01:07Z "For creating aditional content to post type screens there isn't really a good way.
The way you can do it now is with javascript or absolute positionering. This is not really a good way.
In my case I added extra content to the edit view and created tabs at the new/edit screens.
This is probably a case that would not be used a lot but it gives plugin developers create power to make the new/edit overview clean when they can used tabs. To much meta boxes are killing" markoheijnen
Needs Milestone 22214 Inconsistency in the show_ui parameter for register_post_type Administration 3.4.2 normal normal Awaiting Review defect (bug) new dev-feedback 2012-10-17T20:58:42Z 2012-10-18T00:58:36Z There is an inconsistency with the `show_ui` argument to `register_post_type`. When set to false, the post type listing page is open, while the 'Add new' page is not accessible. nofearinc
Needs Milestone 22239 wp_ob_end_flush_all() tries to destroy non-destroyable output buffers Warnings/Notices normal normal Awaiting Review defect (bug) new 2012-10-21T03:20:47Z 2012-10-21T03:28:19Z "`wp_ob_end_flush_all()` currently tries to flush & destroy every PHP Output buffer that is enabled on the current installation.
However, not every type of PHP Output buffer can be destroyed, which will cause a PHP Notice when attempts to do so are made.
An example of this is PHP extensions such as New Relic, or PHP output buffers created with the `$erase` flag set to false in `ob_start()`
An example is when New Relic is installed on a host, also [https://newrelic.com/docs/php/php-agent-faq#rum-obclean see New Relics FAQ entry] on the issue.
{{{
( ! ) Notice: ob_end_flush(): failed to send buffer of New Relic auto-RUM (1) in ../trunk/wp-includes/functions.php on line 2641
Call Stack
# Time Memory Function Location
1 0.8510 4328360 shutdown_action_hook( ) ../load.php:0
2 0.8510 4328440 do_action( ) ../load.php:556
3 0.8510 4329856 call_user_func_array ( ) ../plugin.php:406
4 0.8510 4329888 wp_ob_end_flush_all( ) ../plugin.php:406
5 0.8511 4330064 ob_end_flush ( ) ../functions.php:2641
}}}
Somewhat similar to #18239
I'm not sure of what the ideal solution for this would be for !WordPress, but wanted to record the issue being known." dd32
Needs Milestone 21605 Fix TinyMCE statusbar styling TinyMCE normal normal Awaiting Review defect (bug) reopened 2012-08-16T04:09:21Z 2012-10-21T17:36:07Z When the breadcrumb links in the TinyMCE statusbar (at the bottom) are too long (many nested elements with long class names), the statusbar pushes the width of the editor and breaks the layout. azaozz
Needs Milestone 22253 Keep widget areas (and widgets) expanded upon page refresh in admin Widgets 3.4.2 normal normal Awaiting Review defect (bug) new 2012-10-22T11:02:10Z 2012-10-22T11:02:10Z "This is a minor annoyance but noticeable one.
Every time you reload the Appearance -> Widgets admin page, the widget areas (and widgets) currently expanded become closed when the page is refreshed." dgwyer
Needs Milestone 19721 WordPress should support multiple or nested plugin directories scottnath Plugins 3.3 normal normal Awaiting Review feature request new 2012-01-03T16:33:34Z 2012-10-22T11:12:11Z "WordPress currently only looks one directory deep for the plugin files. This is a limitation in get_plugins. It should look at least two (or more).
Our setup: We have many sites on WordPress and would like to share a set of plugins across them. However, we also have a requirement where each site should have its own unique set of plugins as well. (I realize this seems like an easy job for Multisite or mu=plugins, but they're not something we can adopt currently for various reasons).
Ideally, we can create a symlink (or external/submodule) to our shared plugins folder from inside the core plugins folder and have WordPress recognize plugins within that folder:
* plugins Folder
* hello-dolly.php
* akismet
* akismet.php
* shared-plugins (symlink)
* shared-plugins folder
* hello-dolly-enhanced
* hello-dolly-enhanced.php
* akismet-enhanced
* akismet-enhanced.php
Currently, WordPress will ignore both hello-dolly-enhanced and akismet-enhanced.
Themes already support nested folder; plugins should too please!
Thanks,
Scott Nath" scottnath
Needs Milestone 16819 Accessibility: Internal Linking behaviour in Editor / TinyMCE Editor 3.1 normal normal Awaiting Review enhancement reopened 2011-03-10T10:52:26Z 2012-10-22T15:58:33Z "'''Issue'''
The default behaviour of the new 'Internal Linking' feature is to auto-insert the title attribute as a duplicate of the link text.
This is not best-practise and, contrary to some beliefs, doesn't actually aid accessibility.
'''Solution'''
The title field should be blank by default and only included if the uses enters data.
'''Why?'''
Title text is only useful when it is *different* to the actual link text AND provides additional information. Duplicating the link text in this fashion just adds fuzz to the page.
" stencil
Needs Milestone 11282 Bizarre Behavior When wp-content Missing westi Themes 2.8.4 normal normal Awaiting Review defect (bug) reopened has-patch 2009-11-29T02:19:13Z 2012-10-23T00:15:18Z "Steps to reproduce:
1. Begin and complete a normal installation, but skip or remove the wp-content directory.
2. Try to view the Dashboard and the Visit Site link.
Expected Result: WP did not install, wp-content is missing.
Actual Result: Dashboard is visible, site's front page is not. In /wp-admin/error_log
PHP Warning: array_keys() [function.array-keys ]: The first argument should be an array in /wp-includes/theme.php on line 481" miqrogroove
Needs Milestone 22256 Hook namespacing Plugins normal normal Awaiting Review enhancement new 2012-10-22T18:56:25Z 2012-10-23T13:01:21Z "Currently, callbacks passed to add_action() and add_filter() are already sort of namespaced by the hook name, by priority and by the callback itself. You need to know all of them in order to use `remove_action()` successfully.
Acquiring the callback is especially problematic when it's:
* an instance method, and you don't have access to the instance
* a PHP 5.3 closure
Introducing namespaces for hooks, similar to jQuery's [http://docs.jquery.com/Namespaced_Events namespaced events], would not only take care of that problem, but also enable things like removing all callbacks added by plugin X, regardless of hook name or anything else.
Proposed syntax:
{{{
add_action( 'after_setup_theme:twentytwelve', function() {
// do stuff
}
add_action( 'after_setup_theme:twentytwelve', function() {
// do more stuff
}
add_filter( 'posts_clauses:p2p', function( $clauses ) {
// do stuff
}
}}}
Later:
{{{
// remove specific callbacks added by the Twentytwelve theme
remove_action( 'after_setup_theme:twentytwelve' );
// remove all callbacks added by the P2P plugin
remove_action( '*:p2p' );
}}}
Source: http://core.trac.wordpress.org/ticket/22250#comment:14" scribu
Needs Milestone 21773 Scheduled pages/posts should not appear in custom menus Menus 3.0 normal normal Awaiting Review defect (bug) new 2012-09-02T14:30:48Z 2012-10-23T22:03:31Z "When I add a '''scheduled page/post''' in a custom menu the page/post immediately appears in the front-end menu.
I think these scheduled pages/posts should only be visible in the front-end navigation when their scheduled time is reached (as it is the case with automatic menus). Otherwise the ""Schedule"" functionality makes no sense with custom menus, especially for pages.
Here is another forum post regarding this issue: http://wordpress.org/support/topic/custom-menu-support-for-scheduled-pagesposts" Lorangeo
Needs Milestone 22237 Add a keyboard shortcut for collapse/expand in the customizer Appearance normal normal Awaiting Review enhancement new close 2012-10-21T02:59:31Z 2012-10-24T17:33:30Z Can we add a keyboard shortcut to the customizer for collapsing/expanding the left panel? designsimply
Needs Milestone 22272 shortcode_unautop() Doesn't Account for Opening/Closing Shortcode tags each Being on Their Own Line Shortcodes 3.4.2 normal normal Awaiting Review defect (bug) new 2012-10-24T17:54:22Z 2012-10-24T17:54:22Z "The shortcode_unautop function does not appear to account for when the opening and closing shortcode tags are put on separate lines from the paragraph they are surrounding.
For example: the following is after wpautop() adds the paragraph tags.
{{{
[cool_shortcode]
A paragraph about something you should know.
[/cool_shortcode]
}}}
I would expect that shortcode_unautop would remove the paragraph tags from around both the opening and the closing shortcode tags. Instead it treats it all as if the entire thing were in one paragraph. Resulting in the following code being output.
{{{
[cool_shortcode]
A paragraph about something you should know.
[/cool_shortcode]
}}}
" bonnerl
Needs Milestone 20783 Add filter to wp_unique_term_slug() Taxonomy 3.3.2 normal normal Awaiting Review enhancement new dev-feedback 2012-05-30T02:24:04Z 2012-10-26T21:36:39Z "I can't modify the result of wp_unique_term_slug(), but if using the following code:
{{{
function wp_unique_term_slug($slug, $term) {
global $wpdb;
if ( ! term_exists( $slug ) )
return $slug;
// If the taxonomy supports hierarchy and the term has a parent, make the slug unique
// by incorporating parent slugs.
if ( is_taxonomy_hierarchical($term->taxonomy) && !empty($term->parent) ) {
$the_parent = $term->parent;
while ( ! empty($the_parent) ) {
$parent_term = get_term($the_parent, $term->taxonomy);
if ( is_wp_error($parent_term) || empty($parent_term) )
break;
$slug .= '-' . $parent_term->slug;
if ( ! term_exists( $slug ) )
return $slug;
if ( empty($parent_term->parent) )
break;
$the_parent = $parent_term->parent;
}
}
// If we didn't get a unique slug, try appending a number to make it unique.
if ( !empty($args['term_id']) )
$query = $wpdb->prepare( ""SELECT slug FROM $wpdb->terms WHERE slug = %s AND term_id != %d"", $slug, $args['term_id'] );
else
$query = $wpdb->prepare( ""SELECT slug FROM $wpdb->terms WHERE slug = %s"", $slug );
if ( $wpdb->get_var( $query ) ) {
$num = 2;
do {
$alt_slug = $slug . ""-$num"";
$num++;
$slug_check = $wpdb->get_var( $wpdb->prepare( ""SELECT slug FROM $wpdb->terms WHERE slug = %s"", $alt_slug ) );
} while ( $slug_check );
$slug = $alt_slug;
}
return apply_filters('unique_term_slug', $slug);
}
}}}
" bolo1988
Needs Milestone 22293 New Filter for wp_update_term General normal normal Awaiting Review enhancement new 2012-10-26T22:26:54Z 2012-10-26T22:46:31Z "I need a filter for $slug in this function. I want to check if there is a page with the same slug, because i don't use the category base.
Thanks very much." baernty
Needs Milestone 22101 "Gallery shortcode with link=""file"" is not linking the file in the RSS feed" Feeds 3.4.2 normal normal Awaiting Review defect (bug) new 2012-10-04T16:14:16Z 2012-10-27T15:58:55Z "Hi,
In a WordPress site I'm currently developing I want to use the stock gallery shortcode. I use [gallery link=""file""] to link directly the image URL which, should fix Flipboard, Currents et al. showing just a little thumbnail.
In the page the code is displayed properly and the a tag links the image file, but, on the RSS feed, it links to the attachment page.
I've tested this in the latest nightly version 3.5-beta1-22104 and on the stable 3.4.2. I attach the output of the page and the feed. " ifrins
Needs Milestone 22303 "Please parse a ""vendor"" file" General normal normal Awaiting Review enhancement new close 2012-10-29T15:31:54Z 2012-10-30T10:06:14Z "Hi,
I'm working on improving Wordpress packaging in fedora.
One of our need is to allow the use of system libraries instead of bundled copy (forbidden by Guidelines).
I would like to propose, as various projects already, to include a ""vendor"" file.
Goals:
- without this file: no change
- with this file: use constant from it
- allow to define patch for each library (rather than a global WPINC)
Note: this is not the same as wp-settings, which are user configurable settings, while ""vendor"" are system configuration (not to be altered by users)
Work proposal.
(probably) in default-constants.php
if (file_exists('vendor.php')) include_once('vendor.php');
For PHPMailer (for exemple)
if (!defined('WP_PHPMAILER_INC')) define('WP_PHPMAILER_INC', ABSPATH . WPINC);
And of course,
require_once WP_PHPMAILER_INC . '/class-smtp.php';
Using this, we could package wordpress in a simpler way, without altering provided sources, just adding this vendor file.
For example, see what have be done in GLPI
https://forge.indepnet.net/projects/glpi/wiki/GlpiPackaging
If you accept this feature, I will work on it and submit the patches (probably various, one per library, as I will progress on this work).
" remicollet
Needs Milestone 22310 wp_insert_user bit ilogical with rich_editing Users normal normal Awaiting Review enhancement new 2012-10-30T09:08:56Z 2012-10-30T12:21:17Z "when you do wp_insert_user with rich_editing = TRUE it actually set rich_editing to ""1"" what is then interpreted as FALSE. I know (after searching why it does not work for me), that for actually setting true you need to set rich_editing to empty value, but anyway i think it is not optimal" thomask
Needs Milestone 22311 "Cannot login when my loginname contains an ""|"" character" Users normal normal Awaiting Review defect (bug) new close 2012-10-30T13:06:13Z 2012-10-31T01:09:24Z "Hello,
Cannot login when my loginname contains an ""|"" character, for example:
Sent|el
or
P|ng|n
Can you fix his ? Other systems like phpBB3 have no problems with such usernames !
" radek2212
Needs Milestone 17199 Unintuitive tax query 'operator' values Query normal normal Awaiting Review enhancement new 2011-04-20T21:52:00Z 2012-10-31T01:24:43Z "Currently, the accepted values for the tax_query 'operator' arg are:
{{{AND}}}, {{{IN}}} and {{{NOT IN}}}.
It would be better if they were instead:
{{{AND}}}, {{{OR}}} and {{{NOT}}}.
which would be more intuitive and consistent with wp_list_filter().
Obviously, we would still have to keep backwards compatibility with the old values." scribu
Needs Milestone 17856 magic_quotes_gpc future-proof enhancements General normal normal Awaiting Review enhancement new has-patch 2011-06-21T01:13:44Z 2012-10-31T03:23:05Z "As is well documented across the Internet, the magic_quotes_gpc feature is going away in future versions of PHP. WordPress has historically automatically escaped _GET, _POST, _REQUEST and _COOKIE input from users, even if the server doesn't have magic_quotes_gpc turned on. Regardless of the reasons for this, having a way to move forward seems absolutely necessary.
Current issues related to this include (among others):
* maintaining backwards compatibility for those plugin developers who depend on WordPress handling this escaping for them
* giving plugin developers a way to help put magic_quotes_gpc in the past
* giving developers access to the original super globals
* making these super global values read-only so that poorly written plugins/themes don't cause conflicts and problems for other plugins/themes
----
Attached is a patch which I believe handles this effectively without causing any backwards compatibility issues.
This patch introduces 5 new getter functions for wordpress:
* wp_input_get()
* wp_input_post()
* wp_input_get_post()
* wp_input_cookie()
* wp_input_server()
When WordPress first loads, these 5 functions grab the original copies of their respective super globals, undo magic_quotes if it's turned on and then makes the values accessible in a read-only way.
Moving forward, plugin developers can be encouraged to use, for example, wp_input_get('name') rather than $_GET['name'] . In addition to giving developers a migration path away from the forced magic_quotes_gpc behavior, additional security filters could be done on the given values for further protection." troydavisson
Needs Milestone 22328 Pass reset password URI to retrieve_password_message filter Users 2.8 normal normal Awaiting Review enhancement new has-patch 2012-10-30T23:34:17Z 2012-10-31T11:24:10Z "The arguments for the retrieve_password_message filter are the message itself and the reset key. However the URI requires the user login as well in order to be valid, thus we cannot regenerate the password reset link without it.
Proposed solution - pass the reset URI instead of just the key." ejdanderson
Needs Milestone 22251 Helper function to simplify checking for constants General normal normal Awaiting Review enhancement new has-patch 2012-10-22T00:32:27Z 2012-10-31T21:33:33Z "Love 'em or hate 'em, WordPress uses lots of constants. As a result, this pattern is all over core and plugins, and occasionally themes:
`if ( defined( 'CONSTANT_NAME' ) && CONSTANT_NAME )`
Right now on trunk, it's used 57 times (excluding 2 in Akismet).
{{{
~/code/wptrunk $ ack ""defined\( ?('|\"")([^'\""]+)\1 ?\) \&\& \2"" -h --ignore-dir=wp-content/plugins/ | wc -l
57
}}}
How about a new function to make that verbose logic a little bit less repetitive.
{{{
function wp_constant( $constant ) {
return defined( $constant ) && constant( $constant );
}
}}}" evansolomon
Needs Milestone 20323 update_post_caches causes time-out on large queries if cache_results flag not set Query 3.3.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-03-29T12:25:56Z 2012-10-31T23:18:05Z "I ran into this problem when debugging why the Advanced Custom Fields plugin's option screen was timing out on my site. I have over 8000 items in my wp_posts table, and the plugin pulls back every post to populate a dropdown (I plan on bringing up this issue with the plugin author)
I was relieved to find out that it wasn't actually the query that was choking, (for a moment I thought mysql was horribly misconfigured) but actually the update_post_caches function.
I realize that the cache_results flag was added to avoid this issue, but it occurs to me that many plugin developers will not foresee sites with as much content as mine.
My suggestion is this: Place a ""cache_threshold"" option in the Wordpress settings... make the default something reasonable like 20 (or maybe even ignore this option all together and grab the value from the posts_per_page option, as set on the admin screen.. it's important it come from the admin screen and not the query options because in the case I encountered it, the posts per page option in the query was set to -1). If the cache_results flag is not set, check after the initial database query is completed to grab the number of returned posts... if it's more than the cache_threshold, then don't call update_post_caches.
This will increase the stability of the core, and prevent plugins from accidentally breaking things with unreasonable queries on large sites.
Sorry if anything in this ticket doesn't make sense... it's early and I haven't had my coffee yet.
" bytesmasher
Needs Milestone 20902 redirect_canonical() on using permalink: Not all $_GET being redirected Canonical 3.4 normal normal Awaiting Review defect (bug) new dev-feedback 2012-06-11T09:30:08Z 2012-11-01T04:54:03Z "Using permalink, I suppose that all query_var entered manually on URL or using $_GET will be redirected to proper permalink. Apparently not all being redirected at all. AFAIC:
1. /?post_format=image : should be redirected to /type/image/
2. /?pagename=blog : should be redirected to /blog/
3. /?author_name=admin : should be redirected to /author/admin/
Unfortunately, they are not.
It can be done by filtering redirect_canonical() but it will be better if it's being done by default as we can see that /?category_name=cat will be redirected to /category/cat/" arieputranto
Needs Milestone 14749 Scrollbar position jumping in the Appearance->Editor newcontent textarea Editor 3.0.1 normal normal Awaiting Review defect (bug) new 2010-09-01T01:32:10Z 2012-11-01T05:14:52Z "As I am editing code in the Appearance Editor main textarea called newcontent, the scrollbar slider will jump upward to a new position moving the current line being edited down.
On a vista machine using ie8 with wp3.0.1 and the 2010 theme, a single character stroke will move the scrollbar up 3 lines.
On an xp machine using ie8 with wp3.0.1 and a custom theme, a single character stroke will move the scrollbar up 8 lines. Ocasionally the scrollbar will only move 1 line and every keystroke will bring the down. Pasting text can and often does bring the line being edited below the visible area of the textarea.
It is very frustrating when it jumps around like this." Giant Slayer
Needs Milestone 17209 Category list table breaks when custom post type label is too long Administration 3.1 normal normal Awaiting Review defect (bug) new 2011-04-21T21:14:11Z 2012-11-01T06:22:13Z "Registered a post type which has a longer label than ""posts"" (called ""resources""). List table listing the categories for that post type breaks slightly when a name is over a certain length. Picture attached.
Offending CSS is setting a 10% width to that column.
I can provide a patch. Though since the number of posts is centered, the heading is left aligned. If that column is widened, should the title be centered as well (since left-aligned may look weird at one point)?" andrewryno
Needs Milestone 22043 Undocumented default of post_type parameter to WP_Query with taxonomy queries Query normal normal Awaiting Review defect (bug) new 2012-09-28T19:24:35Z 2012-11-01T11:53:41Z "post_type parameter default depends on the is_tax attribute. This is not documented here: http://codex.wordpress.org/Class_Reference/WP_Query#Type_.26_Status_Parameters
If is_tax is true, and post_type is not provided, the default of 'any' kicks in, and if is_tax is not set, the default of 'post' kicks in.
Either it is a bug, or perhaps just the documentation needs to be updated.
Please let me know what you think.
Thank you for sharing your software." dbernar1
Needs Milestone 21660 'p' arg should work with custom post types Query normal normal Awaiting Review enhancement reopened 2012-08-22T15:27:49Z 2012-11-01T18:20:10Z "Doing a query like following, where 42 is a custom post_type, will fail:
{{{
$query = new WP_Query( array( 'p' => 42 ) );
}}}
The resulting query looks like:
{{{
SELECT wp_posts.* FROM wp_posts WHERE 1=1 AND wp_posts.ID = 42 AND wp_posts.post_type = 'post' ORDER BY wp_posts.post_date DESC
}}}
This is because WP_Query forces the {{{post_type}}} arg to 'post' when it's not set. We should not force it when the {{{p}}} arg is set." batmoo
Needs Milestone 22341 Future-dated top-level pages are not automatically added to custom menus Menus 3.4.2 normal normal Awaiting Review defect (bug) new 2012-11-01T18:30:40Z 2012-11-01T18:30:40Z "I've found that future-dated top-level pages are not automatically added to custom menus, despite my setting to do so.
When a future-dated page is published, the new menu item ''is'' added to the 'posts' table (a new row with 'post_type' = 'nav_menu_item'). However, the new menu item ''is not'' added to the 'wp_term_relationships' table. In short, the menu item is not saved correctly, and hence does not show up in the custom menu.
Steps to reproduce this bug:
* Activate a theme with support for custom menus.
* Under ""Appearance"" > ""Menus"", enable the option ""Automatically add new top-level pages""
* Create a new top-level page, and schedule it to be published in the future.
* Wait for the page to be automatically published." jamocreations
Needs Milestone 22348 Add support for custom background default images Appearance 3.4.2 normal normal Awaiting Review enhancement new 2012-11-02T19:25:12Z 2012-11-02T19:25:12Z "When specifying custom header default images for a theme, I always forget that you can't do the same for custom backgrounds.
It would be highly desirable to be able to set default background images, just as you can with custom headers." dgwyer
Needs Milestone 20825 User activation in multisite should happen in the main blog.. Multisite normal normal Awaiting Review defect (bug) new has-patch 2012-06-04T11:00:41Z 2012-11-02T22:52:08Z "In multisite mode ( subdomain ) , when a user activates his account, it should happen in the main blog ( or not ? ) .
In ms-settings.php ( line 118 ) , we assume that the main blog is always blog=1 ( which may be wrong ) .
The attached patch uses the constant BLOG_ID_CURRENT_SITE if defined instead." rahal.aboulfeth
Needs Milestone 20846 Multisite: Network Users can post comments without being members of the site Multisite 3.0 normal normal Awaiting Review defect (bug) new has-patch 2012-06-05T14:35:41Z 2012-11-02T23:02:52Z "This is probably an 'ever since inception' issue and I can replicate it on 3.4
Setup:
Have a user added to your network but '''not''' to a site (domain.com/test).
Set up domain.com/test to only allow registered users to comment. Remember, we've not added this new user to the site, just the network.
Log in as that user and go to domain.com/test
Oh look! You can comment as a 'registered' user.
This should be check for 'Is this a user ''and'', if multisite, is this user a member of the site?'
It's that or the wording needs to be clearer that anyone registered on the network can comment." Ipstenu
Needs Milestone 18079 WP has dropped support of the path field in the site table Multisite 3.0 normal normal Awaiting Review feature request new has-patch 2011-07-12T05:06:31Z 2012-11-03T14:25:50Z "I've had inquiries about sites that used to work in WordPress Mu that no longer work in WordPress 3.1.
The idea is to have a path based network for each state/province and sites for each city under that, all networks hosted under the same domain.
Like so
{{{
Network 1:
Network domain: example.com Network path: /ohio/
site domain: example.com path: /ohio/akron
site domain: example.com path: /ohio/canton
site domain: example.com path: /ohio/uniontown
Network 2:
Network domain: example.com Network path: /pa/
site domain: example.com path: /pa/pittsburgh
site domain: example.com path: /pa/greensburg
site domain: example.com path: /pa/erie
Network 3:
Network domain: example.com Network path: /indiana/
site domain: example.com path: /indiana/indianapolis
}}}
There are two things that are preventing this. First, in new_site, instead of including the path from the sites table for the current network, it uses the global $base variable which is always / in this scenario. Using $current_site->path resolves that.
The second issue is that the .htaccess code is too restrictive. It will the paths on two levels. /network/site/wp-admin/ doesn't work but /site/wp-admin/ does.
Adjusting lines similar to
{{{
RewriteRule ^[_0-9a-zA-Z-]+/(wp-(content|admin|includes).*) $1
}}}
over to
{{{
RewriteRule ^[_0-9a-zA-Z/-]+/(wp-(content|admin|includes).*) $1
}}}
resolves that.
The attached patch addresses both of these requirements.
" brianlayman
Needs Milestone 22346 Add Videojug.com to internal whitelist Embeds 3.4.2 normal normal Awaiting Review feature request new has-patch 2012-11-02T15:30:50Z 2012-11-05T10:48:00Z "Dear Wordpress,
I am writing on behalf of Videojug. We create and distribute hiqh quality ""How-To"" online content, and have been producing professional, instructional, short-form video content since 2006. We receive many requests monthly from our Contributors and Users asking for assistance in embedding our videos in their Wordpress sites. Currently it is a convoluted process involving plugins adding complexities.
Other video providers in our sector are already whitelisted. We would like to be added please to your internal whitelist, allowing any Wordpress blogger to embed our videos by copying the URL just like they would when embedding a Youtube video. Our own embed code has been stable for a long time.
We have our oembeds working in the following wordpress account:
[http://chloeluper.co.uk/index.php/embed-test-page/]
This is the add oembed provider code:
{{{
wp_oembed_add_provider( '#http://(www\.)?videojug.com/(film|interview)/.*#i', 'http://www.videojug.com/oembed.{format}', true );
}}}
I have attached the modified default theme.
Thank you
Imad Salhi
" Videojug
Needs Milestone 22362 Titles of RSS feeds lacks spacing - words are run together Feeds 3.4.2 normal normal Awaiting Review defect (bug) new 2012-11-05T15:30:23Z 2012-11-05T16:40:58Z "Line 24 of wp-includes/feed-rss2.php has:
<?php bloginfo_rss('name'); wp_title_rss(); ?>
There's no space between those two parts. In my (development) site, for the feed for a category ""News"" (which is the main one I'm offering up), that results in:
SitenameNews " DavidAnderson
Needs Milestone 22364 Add Theme Location Arg to Custom Menu Widget Menus normal normal Awaiting Review defect (bug) new 2012-11-05T19:43:21Z 2012-11-05T19:43:21Z Currently, there is no way to differentiate between a custom menu placed in two different widget areas with wp_nav_menu_args. Since there is no real effect on themes or the use of wp_nav_menu, I propose that WP_Nav_Menu_Widget applies the widget ID as the theme location. wpsmith
Needs Milestone 22271 get_post_class() does not always apply filter to output Template 3.4 normal normal Awaiting Review enhancement new has-patch 2012-10-24T12:52:51Z 2012-11-05T21:07:31Z "Currently the post class function/template tag simply returns an empty array for 404 requests. The reason is simple: The output gets generated based on the return values of {{{get_post()}}}.
This avoids using it to style parts of the 404 template using the {{{post_class}}} filter.
Use case: In one theme I'm currently developing, I use the {{{post_class}}} filter to override the parent themes classes with some grid classes from a CSS framework. This avoids duplicating the templates and handle the positions, etc. of the template parts with a simple callback for the {{{post_class}}} filter. The attached patch makes sure that classes get added, instead of just returning an empty array if no {{{$post->ID}}} is present. It doesn't harm any other callback (or interfere with it).
The attached patch is tested in current 3.4.2 and 3.5 Beta. It is built against the v3.5 nightly build - revision 606806.
Sidenote: The somehow wired phpDocBlock comment was also ""fixed""." F J Kaiser
Needs Milestone 22370 dynamic_sidebar does not consider switch_to_blog Multisite 3.4.2 normal normal Awaiting Review defect (bug) new 2012-11-06T04:33:23Z 2012-11-06T04:33:23Z "On the main site of my WordPress network, I have a header that I would like to show on all other sites of the network. The main site uses the parent theme and all of the other sites use child themes. In header.php of the parent theme, I'm using ''switch_to_blog'' function to load Navigation Menus from the main site in the header of the other sites. This is working perfectly.
'''The Problem'''
I also have a sidebar in the header that I would like to manage on the main site as I do with the navigation menu. Unfortunately, this doesn't work at all because dynamic_sidebar function does not take into consideration switch_to_blog. I get no output instead of showing sidebar from main site.
'''Others with same problem'''
Boone Gorges did a good job of explaining this problem on WordPress Stackexchange on the question titled: [http://wordpress.stackexchange.com/questions/48123/sharing-dynamic-sidebars-across-multisite-blogs Sharing Dynamic Sidebars across Multiple Blogs]. " tarasm
Needs Milestone 21164 wp_customize_support_script support for XHTML themes Validation 3.4 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-07-05T13:31:15Z 2012-11-07T08:53:41Z The script just needs wrapping in a CDATA section for XHTML themes. needle
Needs Milestone 20883 Translating all plugin headers? I18N 2.6 normal normal Awaiting Review defect (bug) new 2012-06-07T20:20:34Z 2012-11-07T13:40:32Z "I am really not sure if translators should be able to localize Author, Author URI or Plugin name? Description is very helpfull, but why translating strings like ""Matt Mullenweg"" or ""http://ma.tt/"" which are in current admin localization file?
Related: #19597" pavelevap
Needs Milestone 21112 Add pre_wp_unique_post_slug to override post slug handling Permalinks 3.4 normal normal Awaiting Review enhancement new has-patch 2012-06-29T14:38:32Z 2012-11-08T02:00:49Z "As originally [http://core.trac.wordpress.org/ticket/20480#comment:4 proposed] in the comments of #20480 (and in fact further back in a [http://core.trac.wordpress.org/ticket/14111#comment:4 comment] for #14111), a `pre_wp_unique_post_slug` filter early in `wp_unique_post_slug()`could be useful and justified for some use cases rather than relying on the existing and late-firing `wp_unique_post_slug` filter for a couple reasons:
* `wp_unique_post_slug()` (and thus this new filter) is not high use, so won't impact performance
* `wp_unique_post_slug()` performs database queries (perhaps repeatedly until a unique slug is found), fires other filters, etc, all of which may be rendered moot if a hooking function's intent is to fully implement its own slug generation/handling logic. The pre slug could short-circuit that unnecessary effort.
The attached patch introduces the new filter in addition to adding related phpDocs." coffee2code
Needs Milestone 22392 save_state() in postbox.js should look at the hidden checkboxes instead of :hidden Editor normal normal Awaiting Review defect (bug) new dev-feedback 2012-11-08T16:05:28Z 2012-11-08T18:11:13Z "At this moment save_state() looks at all the metaboxes that are really hidden with filter(':hidden'). With can lead to weird behavior when a plugin starts to hide a metabox in some cases since it can be showed/hidden by default.
I was wondering if it is possible to look at the checkboxes and mapped them as a string and pass it to the AJAX action closed-postboxes." markoheijnen
Needs Milestone 22401 Add information about old theme to 'theme_switched' action Themes normal normal Awaiting Review enhancement new 2012-11-10T02:14:48Z 2012-11-10T07:05:37Z "Currently the 'theme_switch' action passes data about the theme you're switching to, but not the theme you're switching from. Adding it there would make it easier to juggle functionality that needs to know about new and old themes. Right now some of this happens by [http://core.trac.wordpress.org/browser/trunk/wp-includes/theme.php?rev=22516#L696 setting an option] ('theme_switched') and [http://core.trac.wordpress.org/browser/trunk/wp-includes/theme.php?rev=22516#L1598 checking for it] on [http://core.trac.wordpress.org/browser/trunk/wp-includes/default-filters.php?rev=22516#L214 init], then deleting the option. That could be simplified by just passing the old theme's data in theme_switched.
There's an added benefit that we avoid checking for an option on every single request that usually won't be there." evansolomon
Needs Milestone 22314 Add singular.php to template hierarchy Template 3.4.2 normal normal Awaiting Review enhancement new has-patch 2012-10-30T15:04:24Z 2012-11-10T07:33:20Z "Currently, the template hierarchy includes a fallback template (archive.php) for all archive-index type pages (date, tag, category, taxonomy, author, blog posts index, custom post type index), but does not include an analogous fallback template for single-post type pages (blog post, page, attachment, custom post type). This patch adds `singular.php` to act as such fallback.
This change also ensures that all template context conditionals have associated template files. AFAIK, `is_singular()` is currently the only template context conditional that does not have such a corresponding template file." chipbennett
Needs Milestone 22369 get_transient() do not call delete_transient() when deleting one General 2.8 normal normal Awaiting Review defect (bug) new close 2012-11-06T01:27:01Z 2012-11-10T10:33:00Z "Hello
i was wondering why get_transient() is not calling delete_transient when deleting a timeouted transient.
Piece of code from get_transient()
{{{
$transient_option = '_transient_' . $transient;
$transient_timeout = '_transient_timeout_' . $transient;
if ( get_option( $transient_timeout ) < time() ) {
delete_option( $transient_option );
delete_option( $transient_timeout );
return false;
}
}}}
but i need to trigger the ""deleted_transient"" hook.
Can we do that:
{{{
$transient_option = '_transient_' . $transient;
$transient_timeout = '_transient_timeout_' . $transient;
if ( get_option( $transient_timeout ) < time() ) {
delete_transient( $transient_option );
return false;
}
}}}
" juliobox
Needs Milestone 22406 adjacent_posts_rel_link ignores $excluded_categories argument Template 2.8 normal normal Awaiting Review defect (bug) new has-patch 2012-11-10T13:16:31Z 2012-11-10T14:57:34Z "The ticket subject is pretty obvious, I think, just by looking at the source in link-template.php:
{{{
function adjacent_posts_rel_link($title = '%title', $in_same_cat = false, $excluded_categories = '') {
echo get_adjacent_post_rel_link($title, $in_same_cat, $excluded_categories = '', true);
echo get_adjacent_post_rel_link($title, $in_same_cat, $excluded_categories = '', false);
}
}}}
The $excluded_categories should be passed to get_adjacent_post_rel_link just as they come, not as an empty string.
Possible use cases of having the bug fixed:
- want to exclude a category from almost everywhere (because it has a single place in the blog), but it keeps appearing in the rel links.
- don't want to help robots discover posts from those categories through the rel links (robots.txt is not enforceable). " adelval
Needs Milestone 22148 Customizer Uploader doesn't handle large files properly Appearance 3.4 normal normal Awaiting Review defect (bug) new 2012-10-10T05:07:34Z 2012-11-11T18:14:45Z "Both of these tests were with image files larger than the max file size - 3MB images with a 2MB max file size:
Dragging the file onto the upload area, the browser window redirects to the location of the local file, the same as if the file were dragged to a non-dropzone area.
When using the file browser to select the file, the upload fails silently.
In both cases, an error similar the Media Uploader would be preferable.
" pento
Needs Milestone 22412 Save posts via Ajax Editor 3.4.2 normal normal Awaiting Review enhancement new 2012-11-11T12:18:09Z 2012-11-12T09:39:16Z "When editing a post/page (as with any other type of document) one of the primary benefits is the undo/redo feature.
However, as soon as you update your changes you lose access to undo your previous keystrokes before the update. If you could save posts via Ajax then you would still be able to undo/redo post edits seamlessly.
Perhaps there could be a toggle in general settings for this option, and have it enabled by default?" dgwyer
Needs Milestone 22378 Add ability to hijack plugin install/upgrade downloads Upgrade/Install 3.4 normal normal Awaiting Review enhancement new has-patch 2012-11-07T13:00:18Z 2012-11-13T01:09:22Z "'''Problem'''
Many plugins have their own updating system. For paid plugins, this can involve
sending authentication/authorization headers. At the moment, to implement this,
certain parts of the plugin upgrader system have to be duplicated to replace
parts of the system, such as the downloading method. In addition, the package
download URL has to be a valid URL. Some systems may wish to use alternate URLs
apart from HTTP/FTP-based URLs.
The code for this is shared between the single plugin upgrader and the bulk
plugin upgrader. While the upgrader class can be replaced fairly easily with
existing filters for single plugins, it's not possible to do this for the bulk
upgrader (especially when multiple systems want to do this), requiring falling
back to a low-level filter like `http_request_args`, ensuring that one only
hooks in after the `admin_action_update-selected` action has failed.
'''Solution'''
Add a filter to hijack the download system before it can act at all. This allows
replacing the entire downloading system, with the only requirement being to
return a valid package filename. This filter will work across both the single
and bulk upgraders, ensuring consistency in the approach.
Patch attached. Related: #22377, #22129" rmccue
Needs Milestone 22205 Plugin updater - Optimize API Request Upgrade/Install 3.4 normal normal Awaiting Review enhancement new has-patch 2012-10-16T15:45:27Z 2012-11-13T01:24:42Z "When checking for plugin updates, the POST to api.wordpress.org includes ALL information about each plugin (e.g. Description, Name, Title, Author, etc). This is unnecessary.
This patch strips out non-essential data from the array returned by get_plugins().
wp-includes/update.php:146" logikal16
Needs Milestone 22180 "Add attachments to ""existing content"" area in link dialog" Editor 3.4 normal normal Awaiting Review feature request new 2012-10-12T20:59:26Z 2012-11-13T01:30:57Z "At the moment, the process for linking to attachments within the editor is rather cumbersome. Each time someone wants to link to a PDF document or other item they've uploaded through the media interface, they have to take the following steps:
1. Upload the file through the media uploader
2. Press the File URL button in the media modal
3. Copy the URL from the ""Link URL"" box
4. Close the media modal
5. Highlight the text they want to link
6. Press the ""Insert/edit link"" button in the editor toolbar
7. Paste the URL from their clipboard into the URL input
It would be nice if attachments could be included in the ""Link to existing content"" area within the link dialog.
I can see two possible ways of implementing this. Either simply include attachments in line with the pages, posts and custom post types that already display in that area; or, use a tabbed interface to switch back and forth between the normal ""existing content"" list and a list of existing attachments.
When I discussed this with Nacin and a few others at WordCamp Baltimore, we proposed adding a preference (possibly based on the information that's stored when the user uploads the media) determining whether the permalink leads to the attachment page or the actual file.
Based on my preliminary research, it looks like implementing this will essentially take two steps:
1. Add 'attachment' to the `$pts` array at the beginning of the `_WP_Editors::wp_link_query()` method.
2. If the preference has been set to link to the actual file, the code will need to adjust the `permalink` value in the `$results` array for anything that comes up as an attachment.
I'll look at starting a patch for this over the next few days, unless someone else gets to it first. Thanks." cgrymala
Needs Milestone 22247 "Ensure post ID evaluates to true before adding ""Edit post"" tab in admin bar" Toolbar 3.1 normal normal Awaiting Review defect (bug) new has-patch 2012-10-21T20:45:27Z 2012-11-13T01:37:13Z "This patch checks that a post has an ID set before adding an ""Edit post"" link in the admin bar on the front-end for individual post pages and static pages.
This can be helpful for plugins that choose to create a ""fake"" page that does not exist in the database, and set their ID to ""0.""
An example of such a fake page can be seen on my [http://wordpress.org/extend/plugins/on-the-fly-youtube-embeds/ On The Fly YouTube Embeds] plugin which borrows a lot of code from Scott Sherrill-Mix's blog post: [http://scott.sherrillmix.com/blog/blogger/creating-a-better-fake-post-with-a-wordpress-plugin/ Creating a (Better) Fake Post with a WordPress Plugin]" Joe Anzalone
Needs Milestone 22333 Add IDs to .misc-pub-section divs in meta-boxes.php Administration 3.4 normal normal Awaiting Review enhancement new 2012-10-31T16:25:40Z 2012-11-13T01:39:40Z "In `wp-admin/includes/meta-boxes.php` the `post_submit_meta_box` has several sections with class .misc-pub-section. Should you have to style/alter any of them, it's not consistent as:
1. first div has only `class=""misc-pub-section""`
2. second div has `class=""misc-pub-section"" id=""visibility""`
3. third div has `class=""misc-pub-section curtime""`
Since this is a unique box on the screen, I've added two more IDs to div blocks 1 and 3 to allow for easier styling changes. " nofearinc
Needs Milestone 22287 Plugin in another plugin folder causes Activate link to be wrong on Download Upgrade/Install 3.4 normal normal Awaiting Review defect (bug) new 2012-10-26T15:30:52Z 2012-11-13T01:41:05Z "I am not sure if shipping a plugin within another plugin is officially supported, but there is an inconsistency between the activate links in the Manage Plugins page, and the Activate Plugin on the Plugin Downloaded success page.
This is because on the Manage Plugins page, the `get_plugins()` is going to scan the plugins dir and all dirs within it, however, on the Upgrade page, it calls `get_plugins()` specifying the plugin dir as the base (see https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/class-wp-upgrader.php#L579)
That will cause the ""embedded"" plugin to be picked up, and if it's alphabetically above the main plugin file (presumably) see code comment "" //Assume the requested plugin is the first in the list""" joehoyle
Needs Milestone 18525 "zlib.output_compression ""on"" in server conflicts with autoupdate" General 3.2.1 normal normal Awaiting Review defect (bug) new dev-feedback 2011-08-26T20:11:45Z 2012-11-13T05:12:06Z "If zlib.output_compression is ""on"" in server (my vps server), then auto-update works, but without verbose output or any indication that install has succeeded.
This error is consistent for all auto-updates WordPress Application and all plugins.
It is NOT a plugin conflict. Occurs on different servers.
Testing has confirmed that when zlib.output_compression is returned to ""off"", then updates work as expected.
In my opinion this is a minor bug and probably a note in the readme file will suffice.
Thank You,
Neil Miller
zx@avidre.net" avidre
Needs Milestone 21856 Hide category selection when no posts are available Administration 3.1 normal normal Awaiting Review enhancement new has-patch 2012-09-09T14:38:10Z 2012-11-13T20:18:02Z "Just an idea that popped up while testing #21015. The months dropdown gets hidden when there are no posts available, so why not hide the category dropdown list too?
Might be a bit confusing though, when certain elements are not showing when you first start using the screens that these elements are used. But showing something that does not do what it looks like is even more confusing, I think." CoenJacobs
Needs Milestone 18136 WordPress Adding Spurious Formatting normal normal Awaiting Review defect (bug) reopened 2011-07-15T22:03:38Z 2012-11-14T02:06:32Z If you look at this page: https://singpolyma.net/2011/06/dystoparx-part-12/ WordPress seems to be adding extra tags before the s This causes major well-formedness problems on the page. singpolyma
Needs Milestone 22436 escape recent posts widget post titles Widgets normal normal Awaiting Review enhancement new has-patch 2012-11-14T02:45:27Z 2012-11-14T09:08:13Z "The recent posts widget escapes the title attribute but does not escape element text. Add an esc_html wrapper to post title values to escape before output.
Example post title: Post about < stuff >" niallkennedy
Needs Milestone 22037 Customizer: Live preview fetches page but does not display Appearance 3.4.2 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-09-28T15:14:54Z 2012-11-14T17:29:37Z "I just set-up a plain installation of 3.4.2. Configured it for multisite use. Set-up two sites, both working fine.
When going into a sites Appearance settings to customize the theme (TwentyEleven), the Customizer shows the control panel on the left, but the preview remains blank.
Firebug shows no Javascript errors.
'''It also shows, that a POST request is sent to fetch the front page and that the page is actually returned in the response. It appears the response is just not added to the right-hand preview area.'''" marcoliverteschke
Needs Milestone 22458 Image captions and block level elements Media 3.4 normal normal Awaiting Review defect (bug) new 2012-11-15T03:16:18Z 2012-11-15T03:38:05Z "After accidentally putting a captioned image inside another image's caption (yo dawg), I found that block level elements in general seem to not play well.
{{{
[caption id=""attachment_809"" width=""150"" align=""alignnone""]block level in caption
[/caption]
}}}
With `` tag: Toggling about 3 times completely removes the tag, contents remain
{{{
[caption id=""attachment_809"" width=""150"" align=""alignnone""]
block level in caption
[/caption]
}}}
With `` tag: Toggling about 2 times causes the entire caption to be removed, after first adding some unbalanced `
` and `` after the first toggle
{{{
[caption id=""attachment_809"" width=""150"" align=""alignnone""]` tags: First toggle will 'organize' your list tags, each toggle after that adds 2 `` around the list." trepmal
Needs Milestone 17115 Publishing an empty post results in success Administration 3.1 normal normal Awaiting Review defect (bug) new 2011-04-12T11:32:50Z 2012-11-17T00:15:31Z "'''Steps to reproduce:'''
1. Go to Add New post screen
1. Publish post
1. Success message is displayed with link to initial auto-draft of post
The issue can be traced back to the `editpost` switch case in `post.php` (line 204), which calls `edit_post()` and `redirect_post()`.
`edit_post()` saves any meta values passed with the post to the auto-draft, which isn't necessarily desirable, and returns the auto-draft post ID.
`redirect_post()` then defaults to status message code 6 which incorrectly reports success in publishing." kawauso
Needs Milestone 18025 WPMU New Blog Default User Role Multisite 3.2 normal normal Awaiting Review feature request new 2011-07-07T12:26:50Z 2012-11-17T15:53:53Z "When I using WP Multisite as Network Admin and creating a new blog, The new user to the blog will get role: Administator for the new blog.
I want to add in wp-admin/network/settings.php a setting for ""New Blog Default User Role"". Where the Network Admin can set the default role for users to new blogs.
So you can set that if you creating a new blog and enter one e-mail address the user will get the role you have in your settings, so you can set users to new blogs to be example subscribers instead of Administrators like today.
Exactly as the plugin http://wordpress.org/extend/plugins/new-blog-default-user-role/ but this one is not so good." jontelm
Needs Milestone 20746 Accessing non-existing theme folder in Network install gives 500 error Multisite 3.3.2 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-05-25T10:28:39Z 2012-11-17T16:17:46Z Accessing non-existing theme folder in Network install gives 500 error and following error in error log: ''Request exceeded the limit of 10 internal redirects due to probable configuration error.'' arkimedia
Needs Milestone 22498 Disabling Header Text should not reset Header Text Color to default Appearance 3.4.2 normal normal Awaiting Review defect (bug) new 2012-11-18T22:31:17Z 2012-11-18T22:31:17Z "In Appearance > Header, if you uncheck the 'Show header text with your image' option and Save, the Text Color option is reset to whatever the default is.
With JS enabled, the Text Color option is hidden when the checkbox is unchecked, but in no-js both options are displayed all the time. It's odd to set a header text color and uncheck the option only to have it reset your choice to the default.
Related: #22461" DrewAPicture
Needs Milestone 22466 Want to View Pending Comments From Dashboard Administration normal normal Awaiting Review enhancement new 2012-11-15T18:49:39Z 2012-11-19T16:25:06Z "This is a very awkward aspect of WordPress that I'm just attempting to articulate for the first time: In the Recent Comments dashboard widget, there is no way to view fully the pending comments.
What it should link to:
* View Comment
* View Post
* Approve Comment
* Edit Comment
* Spam Comment
* Trash Comment
What it does instead:
* Visitor's site or e-mail address
* Edit Related Post
* View Related Post
* Reply to Comment
* Approve Comment
* Edit Comment
* Spam Comment
* Trash Comment
So there are several obvious points of confusion here.
Why would I want to reply to a comment that is pending approval, still hidden, and not even fully displayed to me?
Why can't I see the whole comment? It only shows me an excerpt here, and in order to actually read the comment I have to click over to Comments on the admin menu and find what I'm looking for manually.
Why does the most prominent link for the comment take me to the post editing screen? When is this ever useful?
Why is the post link displayed as a tiny little ""#""?" miqrogroove
Needs Milestone 22511 Taxonomy manage screen checks for manage_terms and edit_terms, instead of just manage_terms. Taxonomy 3.0 normal normal Awaiting Review defect (bug) new dev-feedback 2012-11-19T23:13:56Z 2012-11-20T03:14:40Z "I'm trying to set up permissions so the Contributor role can add terms but not edit or delete terms. I setup my taxonomy so it looks like this:
{{{
register_taxonomy( 'custom_taxonomy', array( 'post' ), array(
...
'capabilities' => array (
'manage_terms' => 'edit_posts',
'edit_terms' => 'manage_options',
'delete_terms' => 'manage_options',
'assign_terms' => 'edit_posts'
)
) );
}}}
However, when logged in as a contributor I get the error ""You are not allowed to edit this item."" In edit-tags.php there are two checks for caps, one is for manage_terms and one is for edit_terms. I don't believe the second one should be there, because looking at the other code it should be like this:
* User with manage_terms can access the main taxonomy page
* They can also add terms
* There are checks in WP_Terms_List_Table to restrict showing the Edit/Quick Edit/Delete links for users without those capabilities (edit_terms/delete_terms).
* There is even plenty of other checks on edit_terms in edit-tags.php to include/change the content shown to the user.. if the entire page is restricted for users without edit_terms, why are any of those necessary?
Even if I'm wrong on the fact that roles with edit_terms can't add new terms (it's not completely clear anywhere, it seems like manage_terms should be enough), I still think that this page should be viewable at the very least considering the other code in that page and the list table.
Recommended solution: move the edit_terms check back into case 'edit' (line 121 of edit-tags.php in trunk, currently) as it was before [15491].
This was introduced in: [15441] and [15491]. Related: #14343." andrewryno
Needs Milestone 22497 Post type should be able to show on mobile apps XML-RPC normal normal Awaiting Review enhancement new has-patch 2012-11-18T18:48:58Z 2012-11-20T11:40:24Z "Currently the mobile apps only show Post and Pages. Part of the reason is that the apps can't know if the post type is worth showing in the apps since it's heavily based on several meta-boxes. I think this is a nice add-on for developers to make that decision.
The patch is really simple and is just adding a extra parameter to register post type." markoheijnen
Needs Milestone 20544 WordPress MultiSite/Network SiteURL error Network Admin 3.3.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-04-25T14:24:07Z 2012-11-20T11:49:45Z "In the Network Admin -> Sites -> Edit Sites -> Info
Domain is set to: swordstudios.net
Path is set to: /helpdawson/
I am using Domain Mapping to mask this site with http://helpdawson.com however I wanted the admin and location of files to be http://helpdawson.com/wp-admin and /files... not http://swordstudios.net/helpdawson/wp-admin
I changed the Domain to helpdawson.com and removed everything from the path and checked off ""Update siteurl and home as well.""
When I hit submit the Domain field in the Info tab was correctly set to helpdawson.com but the site was redirecting to comhelpdawson. which obviously returned an error. When I went to Edit Site -> Settings I saw that the siteurul and home were set to http://comhelpdawson/
I changed everything back to the swordstudios.net/helpdawson and did the whole process over again and was able to duplicate the problem.
[[Image(http://swordstudios.net/wp-content/uploads/2012/04/siteurl-bug.png)]][[Image(http://swordstudios.net/wp-content/uploads/2012/04/siteurl-bug2.png)]][[Image(http://swordstudios.net/wp-content/uploads/2012/04/siteurl-bug3.png)]][[Image(http://swordstudios.net/wp-content/uploads/2012/04/siteurl-bug4.png)]]" professor44
Needs Milestone 20286 Allow direct use of top level domains in multisites Multisite 3.3.1 normal normal Awaiting Review feature request new 2012-03-23T05:46:00Z 2012-11-20T12:00:28Z "Most people installing the multisite would need top level domains and not the subdomains. The domain mapping plugin doesn't really fit in cause it depends on creating aliases and mappings and works on redirects. Separation is important which i guess is the main purpose of multisiting.
I see default WP setup allows you to rename the site URL once its created. So I did, renamed the subdomain into main domain and got into redirect loop problem. After some searching, it turned out the problem was caused by DOMAIN_CURRENT_SITE in wp-config being static. So I changed it to $_SERVER['SERVER_NAME']. This though solved the looping problem but got one more issue. Now going into child site's dashboard requires you to re-login cause of cookie not being set for all child top level domains.
Let's be it - not all people need the subodmain mutisites as you may notice on the forums. Meanwhile, if there's a workaround for setting up cookies for all of the top level sites when logging into network, please advise!
The multisite codex wiki itself tells the same - as a matter of fact it shows a screenshot having a top level domain as a wp site and that was the main reason why I went on choosing mutisite." mickylmartin
Needs Milestone 22104 High contrast admin colour scheme Accessibility normal normal Awaiting Review feature request new 2012-10-04T17:35:54Z 2012-11-20T16:57:21Z "We should consider bundling a high contrast admin colour scheme with WordPress to aid accessibility for the visually impaired.
Some discussion on this has taken place previously on IRC but nothing much beyond that.
Some potential points of discussion:
* Is anyone in the [http://make.wordpress.org/accessibility/ WordPress accessibility group] an expert on accessibility for the visually impaired? Can we get someone on board for some expert guidance?
* Is an admin colour scheme sufficient? Would any JavaScript need altering too? If so, would an admin colour scheme suffice as a starting point?
Related:
* [http://www.timobrienphotos.com/2009/03/hich-contrast-admin-color-scheme-for-wordpress/ A high contrast admin theme plugin]
* [http://wordpress.org/support/topic/admin-color-scheme Support forum discussing admin theme for visually impaired user]
* [http://wordpress.org/extend/plugins/easy-admin-color-schemes/ Easy Admin Colour Schemes plugin]" johnbillion
Needs Milestone 19714 plugins which use the 'authenticate' hook unable to return errors General 3.3 normal normal Awaiting Review defect (bug) new has-patch 2012-01-03T00:31:35Z 2012-11-20T17:37:34Z "The 'authenticate' hook is designed to allow functions to return either an authenticated `WP_User` object (which will cause the user to be logged in), or a `WP_Error` object, which will cause the errors to be displayed to the user.
In practice, most plugins that use this hook don't rely on the username and password at all, but instead on other means entirely. So what is happening with these plugins (the OpenID plugin chief among them), is that they are returning a `WP_Error` object that describes the error, but then the `wp_authenticate_username_password` function is ignoring that and returning its own `WP_Error` object which rightfully shows that the username and password fields were left empty. Unfortunately, this error object (containing both an empty username AND password) is explicitly checked for and removed in the `wp_signon` method. This is normally the right behavior and handles the case of a user who simply clicks ""Log In"" without entering anything... we don't show them an error, we just redraw the login form. However, in the case described above, an actual error did occur with an authentication plugin, but the user simply sees the normal login form with no error displayed.
(patch forthcoming)" willnorris
Needs Milestone 20438 Custom Post Types with Post Format support aren't registered against post_format taxonomy General normal normal Awaiting Review defect (bug) new close 2012-04-13T16:56:40Z 2012-11-20T18:15:16Z "When a custom post type adds support for {{{post-formats}}}, this doesn't actually register the {{{post_format}}} taxonomy for the post_type.
Here's a quick test:
{{{
add_action( 'init', function() {
register_post_type( 'not-post', array( 'supports' => 'post-formats' ) );
global $wp_taxonomies;
var_dump( 'post supports post_format:', in_array( 'post', $wp_taxonomies[ 'post_format' ]->object_type ) );
var_dump( 'not-post supports post_format:', in_array( 'not-post', $wp_taxonomies[ 'post_format' ]->object_type ) );
} );
}}}
The {{{post_format}}} taxonomy doesn't get returned when {{{get_object_taxonomies}}} is called for the custom post type and one side-effect of this is that the {{{post_format_relationships}}} cache does not get flushed by {{{clean_object_term_cache}}} leading to stale values when a post format is changed.
(The {{{post}}} post_type is immune to this because core registers the {{{post_format}}} taxonomy with it.)
When a post_type adds support for post-formats, an explicit association should be made between the post_type and the {{{post_format}}} taxonomy." batmoo
Needs Milestone 19653 Order by meta field forces ignore of null records Query normal normal Awaiting Review enhancement new 2011-12-23T15:11:45Z 2012-11-20T19:06:53Z "When doing a sort on posts with a meta value, the way the SQL is currently generated in meta.php creates a condition where records that DO NOT have the queried meta value are excluded from the results. This may or may not be the desired behaviour, but we don't give developers the choice without resorting to custom queries or manual rewrites of large swathes of the $clauses array.
The issue: the way WP_Meta_Query->get_sql() creates the join on the meta key is by setting an inner join on wp_postmeta and then adding the key test to the where clause.
I would suggest writing an outer (left) join on wp_postmeta, with the key condition in the join. This would also eliminate any potential future ambiguity if, for example, you are sorting on one meta key but filtering on another, since the key condition would be within the join clause, not the where clause:
{{{
LEFT JOIN wp_postmeta ON wp_posts.ID = wp_postmeta.post_id AND wp_postmeta.meta_key = 'my_custom_field_name'
}}}
Related to ticket 18158 [http://core.trac.wordpress.org/ticket/18158] is the question of how we expose this to the developer in the query API.
{{{
'meta_key' => self::get_meta_key( 'my_custom_field_name' ),
'orderby' => 'meta_value',
'exclude_empty_meta' => false
}}}
If this gets any traction I would be happy to submit a patch." tomauger
Needs Milestone 22526 Changing category doesn't invalidate cache Cache 3.4.2 normal normal Awaiting Review defect (bug) new 2012-11-21T11:55:37Z 2012-11-21T11:55:37Z "Hi,
I am using object-cache.php Memcached v2.0.2 (Dropins) with the current WordPress version, but I don't think this has anything to do with the dropin.
I noticed that category changes don't invalidate/update the cache.
For example:
1. Create a category ""Foo"".
2. Assign some postings to ""Foo"".
3. View your postings in backend and frontend, so that results get cached.
4. Rename ""Foo"" category to ""Bar"".
5. Reload some postings, which are in that category. But they still display the old ""Foo"" category instead the new ""Bar"" category name.
Flushing memcached would ""solve"" this problem, that's why I think renaming categories don't invalidate/update the cache." Whissi
Needs Milestone 19471 Automatically support custom post types in category and tag archives Query 3.0 normal normal Awaiting Review defect (bug) new reporter-feedback 2011-12-07T20:56:03Z 2012-11-22T03:12:48Z "I dealt with a plugin recently that had the following code in it:
{{{
#!php
set('post_type',$post_type);
return $query;
}
}
?>
}}}
The goal was simply to allow their custom post type that was connected to category and tag taxonomies to have its entries rendered on category and tag archive pages. Digging around, it seems that [http://wordpress.org/support/topic/custom-post-type-tagscategories-archive-page/ many people] are using a solution like this.
Of course, the code has problems in that it misses home pages and will mess with all other queries on the affected page (such as menus). Looking further in the thread, it seems people tried fixing up these limitations with code such as the following:
{{{
#!php
query_vars['suppress_filters'] ) ) {
$post_type = get_query_var('post_type');
if($post_type)
$post_type = $post_type;
else
$post_type = array('post','articles','nav_menu_item');
$query->set('post_type',$post_type);
return $query;
}
}
?>
}}}
While this may address the known issues, I don't see it as a solid solution in any way. Here are just couple of the primary issues I see with such a solution:
* Things are very likely to change in the future (such as the possibility of adding additional core taxonomies or query modifications), causing the ever-increasing number of plugins that use custom post types to constantly have bugs.
* Since the WP_Query->set function replaces values rather than merging them, even the ""fixed"" version of the code will cause plugin conflicts as multiple instances of this solution will systematically undo the modification done by each previous instance. Sure, the code could be improved to cover this, but the odds of getting everyone to fix their code are not good.
To me, this is something that was an oversight in the development of custom post types. I can think of no reason why this should not be automatically handled. The dashboard properly shows post counts for categories and tags that include the custom post types, but the query simply fails to handle this. It needs to be fixed.
Testing things out, I noticed that custom taxonomies did not have this problem at all. Looking at wp-includes/query.php, I saw the following:
{{{
#!php
is_tax ) {
if ( empty($post_type) ) {
$post_type = 'any';
$post_status_join = true;
} elseif ( in_array('attachment', (array) $post_type) ) {
$post_status_join = true;
}
}
?>
}}}
This is what allows custom taxonomy archives to work properly without having to filter the query. I've always felt that is_tax should cover categories and tags as well, but what is done is done. So, I propose that this section is modified to include a check for is_category and is_tag. Example:
{{{
#!php
is_tax || $this->is_category || $this->is_tag ) {
if ( empty($post_type) ) {
$post_type = 'any';
$post_status_join = true;
} elseif ( in_array('attachment', (array) $post_type) ) {
$post_status_join = true;
}
}
?>
}}}
This allows for things to ""just work"" as people would expect. Of course, plugins would have to remove their filter in order to avoid plugin conflicts as the post_type query arg would still be set and will not be changed automatically to ""any"". This is as it should be though, so people will just have to be convinced over time to remove the modification from their plugins.
Attached is the proposed patch." chrisbliss18
Needs Milestone 22402 Stripping non-alphanumeric multi-byte characters from slugs Formatting normal normal Awaiting Review enhancement new 2012-11-10T05:07:10Z 2012-11-22T03:13:41Z "`sanitize_title_with_dashes()` strips non-alphanumeric characters from a title to create a slug. Unfortunately it only strips ASCII non-alphanumeric characters. Apart from a few exceptions, all multi-byte characters are preserved. This means all non-Western (and plenty of Western) non-alphanumeric characters end up in the slug as they're treated just like any other multi-byte character.
As an example, here are some common non-alphanumeric Chinese characters which would ideally be stripped from slugs, but are not:
* 。 (U+3002, Ideographic Full Stop, %E3%80%82)
* ， (U+FF0C, Fullwidth Comma, %EF%BC%8C)
* ！ (U+FF01, Fullwidth Exclamation Mark, %EF%BC%81)
* ： (U+FF1A, Fullwidth Colon, %EF%BC%9A)
* 《 (U+300A, Left Double Angle Bracket, %E3%80%8A)
* 》 (U+300B, Right Double Angle Bracket, %E3%80%8B)
Obviously it would be impractical to make a list of ''all'' the non-ASCII characters we want to strip from slugs. The list would be gigantic.
So the question is, would it be possible to use Unicode ranges to blacklist (or whitelist) whole ranges of characters to be stripped from (or preserved in) slugs? Is this practical or even desirable?
Or would it make more sense to continue using a list of just the most common multi-byte characters to be stripped?
The latter makes a whole lot more sense, but the former is a more complete solution.
Thoughts?" johnbillion
Needs Milestone 22273 Parent/child page template inheritance should be more consistent Themes normal normal Awaiting Review enhancement new 2012-10-24T18:39:48Z 2012-11-22T03:26:17Z "When page templates in sub-directories was introduced in 3.4, we also inadvertantly introduced some scenarios where page template inheritance from parent to child themes gets wonky.
After some testing on trunk (r22290), I came up with some interesting findings in what I like to call ''Battle of the page template inheritance'':
Relationship: Parent:Child
Same filename, same Template Name:
* root:root = Child wins
* root:sub = Parent wins
* sub:sub = Child wins
* sub:root = Parent wins
Different filename, same Template Name:
* root:root = Parent wins
* root:sub = Parent wins
* sub:sub = Parent wins
* sub:root = Parent wins
Same filename, different Template Name:
* root:root = Child wins
* root:sub = Both available
* sub:sub = Child wins
* sub:root = Both available
In [http://core.trac.wordpress.org/ticket/22269#comment:1 #22269], @duck_ made light of `get_page_templates()` making use of `array_flip()` which effectively gives preference to Parent templates in some situations. I think it's worth looking at whether we can't allow `get_page_templates()` to properly respect inheritance, regardless of sub or root path.
The other interesting tidbit of course is that in the third set, we see the Child can override the parent file of the same filename, even if the Template Name is different, which I take is expected, but odd in terms of inheritance." DrewAPicture
Needs Milestone 20007 Add option for new user registration notifications Administration 3.4 normal normal Awaiting Review enhancement new has-patch 2012-02-10T06:15:35Z 2012-11-22T03:36:08Z "This patch adds an single checkbox option to WordPress's Settings > Discussion page, allowing users to quickly toggle new user registration notifications/emails on or off.
While the notification function is currently pluggable, allowing non-technical users to easily toggle this feature themselves is both intuitively simple, and should prove generally advantageous to the community." Veraxus
Needs Milestone 19760 Allow localization of language names in multisite I18N 3.3.1 normal normal Awaiting Review enhancement new 2012-01-06T13:17:13Z 2012-11-22T03:45:37Z "There is Site Language settings in multisite (General Options). But all available languages are in English, so there is English, Czech, etc. But when I switch to Czech language, there is still only Czech and not ""Čeština"". I am not sure if there is need to translate all languages, but there should be localized at least selected language (or all available languages).
It is caused by function format_code_lang() in ms.php (line 463) where are all language names hardcoded in English." pavelevap
Needs Milestone 21729 Better logic for comments email notification General normal normal Awaiting Review defect (bug) new 2012-08-29T15:26:37Z 2012-11-22T03:49:45Z "Please see attached patch.
- If comment_author_email is known, it can be used in ""From"" email header.
- Also in ""Reply-To"" header we can use comment_author.
I am not sure if there is any reason for current logic, but my friend noticed it and he thought that this way it would be better..." pavelevap
Needs Milestone 20221 Skip Confirmation Email option only visible to Super Admins Users 3.4 normal normal Awaiting Review enhancement new dev-feedback 2012-03-12T20:08:13Z 2012-11-22T03:52:17Z "When adding a new user in WordPress Multisite, the ""Skip Confirmation Email"" option is only available to Super Admins.
If you enable the ""Add New Users"" featured for site admins, they'll have the ability to create new users under Users > Add New. However the ""Skip Confirmation Email"" option is hidden because they are not a Super Admin.
Super Admins and Admins should have the ability to enable this option when adding new users. " williamsba1
Needs Milestone 22542 wp_insert_term and wp_update_term should include taxonomy as the second parameter when invoking actions edit_terms and edited_terms Taxonomy 2.9 normal normal Awaiting Review defect (bug) new has-patch 2012-11-22T19:04:06Z 2012-11-22T20:03:46Z "wp_insert_term and wp_update_term only send term id when invoking edit_terms and edited_terms. This makes it hard for plugins hooking into those to retrieve the actual term, since get_term and get_term_by require taxonomy in addition to the id.
Other actions on these functions do add the taxonomy to the parameters. For example edit_term and edited_term. So it is hard to understand why the hooks in question do not." akibjorklund
Needs Milestone 22548 Better behaviour when embedding oEmbed supported URLs Media 3.5 normal normal Awaiting Review enhancement new 2012-11-23T00:11:57Z 2012-11-23T00:11:57Z "If a user isn't aware that they can just paste the URL of a video from YouTube/Vimeo/etc into a post in order to embed it, then the user experience for embedding such content could do with some improvement.
In [http://make.wordpress.org/ui/2012/11/14/to-change-things-up-i-tested-a-different/ this recent user interaction test by lessbloat], the user was given a URL to a Vimeo video and asked to embed it into their post. The user clicked 'Add Media', switched to the 'Embed From URL' tab and pasted the URL there. All that happened was the URL to the video was inserted into the post as a formatted link (`{title} `). This meant oEmbed didn't do its thing when the post was displayed and the user just ended up with a link to the Vimeo URL.
== What Should Happen ==
URLs inserted via the 'Embed From URL' tab in the media modal should be handled according to whether or not there's oEmbed support for the URL. To do this an AJAX request should be fired off to a new AJAX handler which reports whether there's oEmbed support for the URL. If there is, then a UI element (message/icon/something) should be shown indicating that the media will be embedded. As a bonus we could even grab the oEmbed data immediately and display the title/thumbnail/etc if it's relevant.
Note that if you paste a URL to an image file (gif/png/jpeg) you're immediately shown an interface for entering a caption and selecting the alignment and the link. This is nice behaviour and improves on the UI we had in 3.4.
----
This isn't specific to the new media modal because this has always been the behaviour, but marking as an improvement to trunk anyway (I'd call this a bug, but I'll leave it as an enhancement)." johnbillion
Needs Milestone 19487 Remove useless calls to set_time_limit() westi General 1.5 normal normal Awaiting Review defect (bug) new has-patch 2011-12-09T14:53:08Z 2012-11-23T10:13:52Z "Calls to set_time_limit() were introduced in http://core.trac.wordpress.org/changeset/1812 and have remained in core ever since. The call occurs in code that makes network connections and is designed to allow time for the network calls to complete before the script execution stops.
But set_time_limit() won't take network time into account, so it actually will not do what it seems designed to do. From php docs:
The set_time_limit() function and the configuration directive max_execution_time only affect the execution time of the script itself. Any time spent on activity that happens outside the execution of the script such as system calls using system(), stream operations, database queries, etc. is not included when determining the maximum time that the script has been running.
Further, calls to set_time_limit() can cause unexpected results in code that relies on any functions that call set_time_limit(). For example, if some code (in a cron job, say) sets the time limit to 0 (unlimited) because it knows it needs some time complete, then a subsequent call to a function that resets the time limit will halt the long-running execution once the new limit has been reached. Also from php docs:
When called, set_time_limit() restarts the timeout counter from zero. In other words, if the timeout is the default 30 seconds, and 25 seconds into script execution a call such as set_time_limit(20) is made, the script will run for a total of 45 seconds before timing out.
Since the call to set_time_limit() does not here do anything useful, it should be removed." dllh
Needs Milestone 19834 More Robust Capabilities for Attachments Media normal normal Awaiting Review feature request new 2012-01-15T00:43:40Z 2012-11-24T15:08:50Z "Attachments/files should have their own set of capabilities mirroring those of posts, in addition to upload_files. Specifically:
- read_attachments
- edit_attachments
- edit_others_attachments
- delete_attachments
- delete_others_attachments
Currently, attachments rely on the edit_posts capability, which can create complications if you don't want your users to see the ""Posts"" sidebar item, or don't want them to be able to delete the attachments they upload. " walkinonwat3r
Needs Milestone 22283 Load login page over HTTPS if FORCE_SSL_LOGIN is set General normal normal Awaiting Review enhancement new 2012-10-26T03:08:52Z 2012-11-24T15:09:34Z "Currently, if FORCE_SSL_LOGIN is set, we will make the HTTP POST request containing the username and password over SSL when logging in, but not the GET request for the login page. Users shouldn't have to examine HTML to figure out if their password is being sent in plain text. To ensure user confidence that they are logging in via an encrypted connection, we should redirect requests for the login page to https:// if FORCE_SSL_LOGIN, not only if FORCE_SSL_ADMIN is set. Troy Hunt explains the issue well in his post here - http://www.troyhunt.com/2011/01/ssl-is-not-about-encryption.html
While FORCE_SSL_ADMIN is obviously ""best"" it is not always possible or practical, but this at least makes the login experience consistent.
" barry
Needs Milestone 22573 esc_sql() works with arrays too Inline Docs low normal Awaiting Review defect (bug) new has-patch 2012-11-24T14:31:21Z 2012-11-24T17:50:11Z ... but the doc block only says string. scribu
Needs Milestone 19992 Auto-fill URL field on Insert/edit link popup Editor 3.3.1 normal normal Awaiting Review enhancement new has-patch 2012-02-08T22:38:14Z 2012-11-26T00:14:21Z "I'd like to see the following behavior: When I select a plain URL or email address in the editor and click on ""Insert/edit link"" the URL field is already populated with either the URL or with a ""mailto:"". Any thoughts? I'd more than happy to write a patch." tillkruess
Needs Milestone 22589 Network Admin + Ajax requests Administration normal normal Awaiting Review enhancement new 2012-11-26T09:12:18Z 2012-11-26T14:40:53Z "Currently there is no Network admin based ajax handler, forcing plugins which exist solely within the Network Admin to either use `wp-admin/admin-ajax.php` or using the `load-{$page_hook}` hook to perform any actions.
This is primarily a problem when the plugin only includes code on a conditional such as `is_network_admin()`, which would be false for a `/wp-admin/admin-ajax.php` request, as a result, only the `load-{$page_hook}` option above is viable for those.[[BR]]
As a work around, plugins can include code on `is_network_admin() || DOING_AJAX` to allow the usage of admin-ajax.php.
Of course, the User Admin also suffers the same issue.
I didn't see any previous tickets, and kind of want to say the existing 'workaround' is appropriate, but recording it here so we can at least close it as wontfix if appropriate." dd32
Needs Milestone 22587 Cast image sizes to array before looping Warnings/Notices 3.3 normal normal Awaiting Review defect (bug) new has-patch 2012-11-25T22:02:49Z 2012-11-27T05:11:01Z "If someone doesn't filter the `image_size_names_choose` filter correctly, or uses some helper function like `__return_false` if they don't want to display any image sizes, a warning is thrown.
The `$sizes` var should be cast to an array before looping to avoid this warning." griffinjt
Needs Milestone 22624 New current_user_has_role function to work for roles like current_user_can does for caps Users normal normal Awaiting Review feature request new 2012-11-28T22:11:49Z 2012-11-28T23:14:31Z "current_user_can( 'capability' ) is great, but it would save some code and be more reliable if we had something like this for roles as a global function that's easy to get at:
current_user_role( 'editor' ) would return true if the user has the editor role, false if they weren't.
I'll work on a patch for this when I get a moment, this is just here to remind me and let others know what I'm thinking." sc0ttkclark
Needs Milestone 20824 current_user_can() bug with Super Admin Users 3.3.2 normal normal Awaiting Review defect (bug) reopened 2012-06-04T10:55:53Z 2012-11-28T23:15:06Z "If the logged in user is a super admin this returns true;
{{{
if (current_user_can('contributor')) echo 'current user is a contributor';
}}}
Normally it should return false as it does for administrator, author, editor and subscriber account types.
I spotted this while working in my localhost Multisite install then figured it doesn't work in the live standalone version! " abdessamad idrissi
Needs Milestone 22633 Update Icon Inconsistency Administration normal normal Awaiting Review enhancement new 2012-11-29T11:37:57Z 2012-11-29T14:44:27Z "The update icon at the moment is 2 arrows in a circle in the admin bar ( aka the refresh icon ). In Network Admin it's a pair of tools.
I'd suggest we change these to the same icon rather than have 2 inconsistent icons. I'd also suggest we use a single arrow as the new icon, a refresh/recycle icon isn't as clearcut as it could be ( and what if a caching plugin implements a refresh button to the admin bar? ).
We could follow Google by using an arrow pointing upwards, or we could follow Apples convention with a downwards pointing arrow in a circle" TJNowell
Needs Milestone 22631 Allow change of dropins folder General 3.5 normal normal Awaiting Review enhancement new 2012-11-29T07:02:44Z 2012-11-29T15:44:06Z "Dropins are stored in the `wp-content` directory. Currently there is no way to alter this (short of editing core code).
The `get_dropins()` function does not utilize filters or predefined constants in any way.
Probably the best method here would be to define `WP_DROPINS_DIR` constant in `/wp-includes/default-constants.php` that can be overridden in wp-config.php." bungeshea
Needs Milestone 22612 Filterable default for wp_safe_redirect/wp_validate_redirect General normal normal Awaiting Review enhancement new 2012-11-27T21:00:22Z 2012-11-29T18:06:41Z The default/fallback for {{{wp_safe_redirect}}} is {{{admin_url()}}}. It would be nice to have a filter to be able to modify this (e.g. redirect to {{{home_url()}}} instead, which is probably a better default anyway). batmoo
Needs Milestone 22650 Filter the Gravatars on credits.php Administration normal normal Awaiting Review enhancement new has-patch 2012-11-30T08:39:58Z 2012-11-30T08:51:59Z "All Gravatars should be generated by get_avatar() or at least run through apply_filters('get_avatar', $avatar) for the sake of extensibility.
Related: #22329" miqrogroove
Needs Milestone 22505 Toolbar dropdowns don't hide on front end on tap away Toolbar 3.4.2 normal normal Awaiting Review defect (bug) new 2012-11-19T14:46:03Z 2012-12-01T21:12:52Z "In the wp-admin pages I can open the Howdy or New menus and tap away to close them.
In the front end admin bar, the menu stays open until navigating to a new page.
Found on 3.5-beta3-22637 using iPad3 iOS 6.0.1." miqrogroove
Needs Milestone 18705 home_url() and is_home() with a static front page General normal normal Awaiting Review enhancement new 2011-09-19T16:16:25Z 2012-12-02T00:05:20Z "When you have a static front page, home_url() points to the front page while is_home() detects the posts page.
This is confusing and counter intuitive (especially because in the dashboard the page set as home is referred to as the posts page. The word ""Home"" is never used on the client side).
Rename
is_home() => is_posts_page()
home_url() => front_page_url()
Add
posts_page_url()" crrobi01
Needs Milestone 22671 "Attachment pages 404 for media attached to an ""Auto Draft""" Media 3.4.2 normal normal Awaiting Review defect (bug) new close 2012-12-01T02:50:25Z 2012-12-02T01:17:42Z "Any image uploaded to a new post through the post editor or QuickPress has a broken View link in the Media Library. To reproduce:
1. Go to Dashboard.
1. Upload an image in QuickPress.
1. Go to Media Library.
1. Click the View link for the image.
Expected result:
I thought it was going to show me the image or the image's attachment page.
Actual result:
""This is somewhat embarrassing, isn't it?"" - 404 message from URL like /?attachment_id=112
This won't happen if the image is uploaded via the Upload New Media page." miqrogroove
Needs Milestone 22669 iPad: Can't Scroll Plugins Modal Administration 3.4.2 normal normal Awaiting Review defect (bug) new 2012-12-01T02:31:23Z 2012-12-02T01:43:48Z "Steps to reproduce:
1. Tap Plugins
1. Tap Add New
1. Tap Featured
1. On any item, tap Details.
1. Tap Changelog
1. Swipe to scroll
Expected result:
See more Changelog.
Actual result:
The page is scrolling around behind the modal. Modal not scrolling.
Related: #22064" miqrogroove
Needs Milestone 22679 Ensure that unattached images inserted from media library get pretty url directly Media 3.5 normal normal Awaiting Review enhancement new has-patch 2012-12-02T11:24:19Z 2012-12-02T22:13:17Z "When inserting an unattached image (with no parent) from the media library and setting the ""Link To"" option to ""Attachment page"", the URL at first gets the default query string format (with a '?'). Though after updating the post it gets the final ""pretty"" format (which seems to happen in the function _fix_attachment_links() in wp-admin/includes/post.php).
The provided patch, gives the URL the final pretty format directly.
See also #22085." jond3r
Needs Milestone 17800 Custom Header bug with deleted images Appearance 3.2 normal normal Awaiting Review enhancement new 2011-06-14T12:43:15Z 2012-12-03T12:08:03Z "I'm not a tech.
I've added images to Twenty Eleven header.
I wrong and I've deleted few images directly using ftp now you can see in the image that the header has the markers of the images without the images.
" pivari
Needs Milestone 22694 Uploading File with Apostrophe in filename Media 3.4.2 normal normal Awaiting Review defect (bug) new 2012-12-03T11:33:20Z 2012-12-03T14:40:31Z "When uploading a file with an apostrophe in the filename wordpress returns a 'HTTP Error' message.
I have replicated this on two separate installs of wordpress, on different LAMP hosting environments.
The filename used for testing was Trend_Forecaster's_Handbook_1.jpg" ianatkins
Needs Milestone 21295 Retrospectively generate new images sizes if requested Media normal normal Awaiting Review feature request new 2012-07-17T10:12:01Z 2012-12-03T17:45:36Z "At present the image variations are created at the moment the image is uploaded to the server. If a new image size is later added, or the default ones changed after an image is uploaded then the existing images are not adjusted.
Whilst there are plugins that provide - regenerate thumbnail functionality it might be neater if an image size is requested that doesn't exist that the system generates it at the time it is requested. This only need happen once per image as once it is created it doesn't need to be created again." TwoThirdsWater
Needs Milestone 22683 Don't load advanced-cache.php when running via CLI Cache normal normal Awaiting Review defect (bug) new has-patch 2012-12-02T18:46:48Z 2012-12-03T20:05:29Z "When you're loading WP via a command-line program, it doesn't make much sense for a plugin like WP Super Cache to take over. It's not like you have thousands of CLI users hammering the install.
Example issue in wp-cli: https://github.com/wp-cli/wp-cli/issues/164" scribu
Needs Milestone 22701 Allow the use of SITEURL and HOME constants for Multisite Installations Multisite normal normal Awaiting Review enhancement reopened 2012-12-03T21:21:26Z 2012-12-03T22:02:13Z "This is a proposal to allow the use of the SITEURL and HOME constants, as we do with single site installations.
My proposal would be to follow the naming conventions put forward by the database schema for multisite installations.
Example for a constant override of the siteurl and home option for blog_id 3.
{{{
#!php
define('WP_3_SITEURL', 'http://example.com');
define('WP_3_HOME', 'http://example.com/wp');
}}}
" jondavidjohn
Needs Milestone 19466 Last-Modified HTTP header not just for feeds sergey.s.betke@… General 3.3 normal normal Awaiting Review enhancement new dev-feedback 2011-12-07T15:44:05Z 2012-12-04T21:36:22Z "Wordpress write HTTP **Last-Modified**, **ETag** headers just for feeds (**class-wp.php**, **send_headers**). And support **If-Modified** HTTP request header just for feeds. Wordpress 3.3 doesn't support HTTP 1.1 **Cache-Control** header.
The best solution - support HTTP cache-control headers and for html output (full blog). But **If-Modified** HTTP request header (304 responces) for site support optionally (some not-ajaxed widgets and plugins will show wrong information without page reloading).
= WordPress version =
Latest WordPress files - 3.3-RC2-19567
" sergey.s.betke@…
Needs Milestone 22742 Fix feed inefficiencies - Possibly Extend Etag/Last-Modified/Conditional Get functionality Performance 3.4.2 normal normal Awaiting Review enhancement new 2012-12-04T21:25:20Z 2012-12-04T21:36:32Z "'''First the story.'''
Attempting to generate what are effectively feeds on our WP site, we've been using the WP rewrite functions in a page/template context for some time, but recently it's made more sense to use the feed context for this. It seems as if there is some liability to using pages--requires a page to be created and not changed by non-dev users and requires a coordinated database and code solution to create. And it introduces some complexity/mess with creating template files for feed logic/display, and again, these dummy pages have to exist. Finally--assigning this feed to a page required the WP URL canonical functionality to occur, so I couldn't use ""feed.json"", I had to use ""feed.json/"" which is just not cool. An entirely code-based solution that effectively rewrites a URL pattern to a function is perfect--which is effectively what the feed context is.
As an aside--for my purposes could I use actual Apache rewrites? Well sure, but I am using WP functions to retrieve the data for my feed--in which case I would have to separately bootstrap my function, and I would assume incur fairly similar performance implications. Also, adding a feed still feels like something that should be code-addressable to me and rolling rewrites to all of our production web servers isn't necessarily fun. I'll be benchmarking this and get back to you though.
In my page->feed conversion, I was curious what the performance implications were. I figured with less files and functions (related to the theme layer) involved, it could only be better using a feed. Not so, it was worse at about 5x to run the same feed creating logic. I sat down with xdebug and query logging to figure out what was going on and found that there were a few extra queries being run on the feed side:
{{{
SELECT post_modified_gmt FROM wp_posts WHERE post_status = 'publish' AND post_type IN ('post', 'page', 'attachment', 'story') ORDER BY post_modified_gmt DESC LIMIT 1;
SELECT post_date_gmt FROM wp_posts WHERE post_status = 'publish' AND post_type IN ('post', 'page', 'attachment', 'story') ORDER BY post_date_gmt DESC LIMIT 1;
SELECT SQL_CALC_FOUND_ROWS wp_posts.ID FROM wp_posts WHERE 1=1 AND wp_posts.post_type = 'post' AND (wp_posts.post_status = 'publish' OR wp_posts.post_status = 'private') ORDER BY wp_posts.post_date DESC LIMIT 0, 50;
SELECT FOUND_ROWS();
}}}
These are coming from a branch in /wp-includes/class-wp.php WP::send_headers(). It's doing very basic logic to determine via the query string if we expect this request to be a feed, then it uses either ''get_lastcommentmodified()'' or ''get_lastpostmodified()'' and uses the result of that to set and send some headers for last modified and etag, and evaluate request values for conditional get (304) responses.
'''The problem:'''
For my application--creating arbitrary feeds actually based on WP options--the last time any post or comment was updated/added has no correlation to my feed. It may not be updated at the point a post is updated, but it would show as being updated--more dangerously, it would show as not being updated and return a 304 if a post hasn't been updated. Also, it's incurring overhead doing this lookup that has absolutely no value.
How about the most common WP core uses? I'm thinking it's still going to result in a lot of false positives (saying it's updated more recently than it really is) that certainly is going to depend on number of post types, but even with say a default install with pages and posts, any time a page is updated (which is not in any default feed), it will be affecting the default posts feed.
There is no hook to allow for the disabling or changing of this logic. And, there is no way to apply some form of this logic to heavier page generations that might be kind of nice.
'''The options:'''
1. Add a hook to this send headers function that would allow it to be fully disabled for certain feeds.
2. Move the functionality to a discrete function that can be passed the actual page/feed updated time and it can then send the proper headers. Then the default feed generation functions can call back to this functionality when they know the actual updated dates.
I actually favor the latter--this is kinda nice functionality that is trapped inside a less useful branch and is ""stuck on"" even when it's not helpful. I would be happy to help write a patch for some of this if some core people can jump on here and provide some direction and blessing.
'''I've noticed a little discussion on this issue elsewhere:'''
#19466 - This person is attempting to apply the existing logic--page/comment last modified across every request which would be a massive mistake. Assuming that's why there has been no response.
#15499 - This person is suggesting an index to get the results quicker--that could be beneficial additionally, but perhaps my modifications could reduce the need for such an index." brokentone
Needs Milestone 18672 "Implement rel=""prev"" and rel=""next"" for archives" joostdevalk Permalinks 3.3 normal normal Awaiting Review enhancement new dev-feedback 2011-09-15T12:37:23Z 2012-12-04T22:34:58Z "As can be seen here:
http://googlewebmastercentral.blogspot.com/2011/09/pagination-with-relnext-and-relprev.html
Google now uses rel=""prev"" and rel=""next"" to navigate paginated archives. As we already do a lot of these types of links (rel=""index"", rel=""start"" etc.) I think we should add these. I'll come up with a first version of a patch." joostdevalk
Needs Milestone 22746 The metadata_exists() function should return the correct value if the get_$meta_type_metadata filter returns a non null value General normal normal Awaiting Review defect (bug) new 2012-12-05T00:04:20Z 2012-12-05T00:04:20Z "The line [http://core.trac.wordpress.org/browser/trunk/wp-includes/meta.php?rev=23043#L324 324] should return $check instead of true, otherwise the filter doesn't normally work when someone wants to always return false for a given meta key.
Here's a quick way to reproduce it
{{{
> add_filter('get_user_metadata', '__return_false'); return metadata_exists('user', 1, 1)
TRUE
}}}" xknown
Needs Milestone 22567 Preview button triggers popup blocker in some browsers if no title is set Editor normal normal Awaiting Review defect (bug) new has-patch 2012-11-23T21:41:35Z 2012-12-05T21:31:33Z "Steps to reproduce:
1. Click on Add New (for a post)
2. DO NOT enter a title.
2. Start typing in the post body.
3. Click Preview
Expected result:
New tab opens with preview.
Actual result:
If popup blocking is disabled, a new window opens with the preview. On subsequent clicks of the Preview button, it reverts to opening a new tab as it should.
Found in WordPress 3.5-RC1." miqrogroove
Needs Milestone 22792 Cannot change name attribute of comment submit button Comments 3.4.2 normal normal Awaiting Review defect (bug) new 2012-12-06T17:03:01Z 2012-12-06T17:20:24Z "This prevents developers from using client-side validation, as the name attribute being set to ""submit"" interferes with the .submit() method. I can change the id and the label of the submit button, but that is all.
The default WordPress server-side validation is unacceptable from a user-experience standpoint.
This would be the solution for me, which I find cumbersome (http://wordpress.stackexchange.com/questions/65001/error-when-posting-comment-form-the-error-is-typeerror-eh-is-not-a-function).
The developer should be allowed to set the name attribute of the submit button (maybe through the use of comment_form())." willi828
Needs Milestone 22795 TinyMCE does not recognize finger selections in WIndows 8 / MSIE 10 TinyMCE normal normal Awaiting Review defect (bug) new 2012-12-06T19:24:16Z 2012-12-06T20:07:14Z "MSIE 10 (and/or Windows 8) seems to treat finger selection and mouse/keyboard selections differently. A symptom of this can been seen in the attached screenshots, when selecting text in visual mode with one's fingers vs a keyboard or standard mouse.
When selected via iOS style gestures, TinyMCE does not recognize the text as selected, and therefore does not let the user insert a link (note how the link tool is disabled). When selected via the mouse or kb, all is well. Everything also works fine with touch, mouse and kb when in text mode, pointing to an issue in TinyMCE.
Screenshots were taken while running core trunk, r23108
This might be affecting more versions of MSIE, or different contexts.
We've recently seen similar reports from users on WordPress.com.
" stephdau
Needs Milestone 22726 New Media: 'From URL' tab should move Media 3.5 normal normal Awaiting Review enhancement new 2012-12-04T11:36:57Z 2012-12-07T00:15:18Z "Should the 'From URL' tab on the left hand side of the new media modal should be moved into the same tab group as 'Upload Files' and 'Media Library' across the top?
It makes no sense in the context of the other tabs on the left, 'Insert Media', 'Create Gallery' and 'Featured Image'." johnbillion
Needs Milestone 22798 "Invalid URLs not giving 404 with ""Default"" permalink settings" Rewrite Rules 3.4.2 normal normal Awaiting Review enhancement new 2012-12-06T23:39:35Z 2012-12-07T03:25:50Z "'''Steps to reproduce:'''
- Set up Wordpress with the default .htaccess
- Select the ""Default"" option under Permalink Settings
- Enter an invalid URL eg 'http://blogroot.com/garlbeflax.abc'
'''Expected Behaviour:'''
- 404 page is displayed
'''Observed Behaviour:'''
- No 404 page is ever shown, no matter what the request string is
- Instead, Wordpress behaves as if no path was requested, eg displaying the homepage/posts lists.
- If requested url has any of the standard params in it, those params ARE executed, eg http://blogroot.com/foo?paged=2 would properly show the 2nd page of the posts.
'''Suspected cause:'''
In line 620 of wp-includes/class-wp.php (in WP->parse_request), there is a conditional which means the only time the request can be marked as a 404 error is if the array of rewrite rules is NOT empty:
{{{
$rewrite = $wp_rewrite->wp_rewrite_rules();
if ( ! empty($rewrite) ) {
...
}}}
If the ""Default"" permalink is selected, and no other rewrite rules are set up elsewhere (for reasons I didn't investigate, adding a add_rewrite_rule to the theme didn't affect anything), then the $rewrite array IS empty and the request can not be checked to see if it's a 404. Therefore, execution of the request continues as if no path info were submitted.
This prevents the showing of the theme's 404 page, and can get a website flagged as spam/exploitative in Google's index.
'''Workaround:'''
Define a permalink redirect (eg pick one of the options other than Default).
Server info:
{{{
Apache/2.2.16 (Debian) (w/ mod_rewrite)
PHP Version 5.3.3-7+squeeze3 (mod_php5)
}}}
.htaccess contents:
{{{
RewriteEngine On
RewriteBase /
RewriteRule ^index\.php$ - [L]
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule . /index.php [L]
}}}" vanchuck
Needs Milestone 22801 Update documentation on wp_insert_term to state that it will return an error if inserting an existing term. Inline Docs normal normal Awaiting Review defect (bug) new 2012-12-07T04:51:53Z 2012-12-07T04:51:53Z "phpdoc for wp_insert_term() states:
If both the term id and taxonomy exist previously, then an array will be returned that contains the term id and the contents of what is returned.
However it returns an error object instead. That may have changed with #13481. Anyway, returning an error seems to be an acceptable solution. Although, #16567 might change that a bit.
Should we just adjust the docs to fit the current behavior?" lgedeon
Needs Milestone 22807 Updating a non-expiring transient with a new expiry date does not make it expire General 3.4.2 normal normal Awaiting Review defect (bug) new 2012-12-07T11:38:18Z 2012-12-07T11:38:18Z "Consider this:
set_transient( 'Bug', 'v1');
set_transient( 'Bug', 'v2', 10 );
The second line will update 'Bug' with 'v2', but will not set autoload to 'no'. Hence, 'Bug' does never expire, and you can get its value 'v2' infinitely using
echo get_transient( 'Bug' );" bersbers
Needs Milestone 21004 add_image_size hard crop messes up image editor rendering Media 3.4 normal normal Awaiting Review defect (bug) new has-patch 2012-06-17T23:48:51Z 2012-12-07T13:51:58Z "When I add an image size with hard crop set to true ( ex: add_image_size('index-thumbnail', 420, 550, true); ) it makes it so that you cannot edit the full size of an image in the image editor - only a cropped version.
http://i47.tinypic.com/20h2dfr.png
(link to screenshot)
The left image in the screenshot is the editor when I removed 'true' from my add_image_size arguments. The right image is with 'true' added back in.
I also see that others had the same problem in this thread: http://wordpress.org/support/topic/help-add_image_size-and-image-cropping?replies=6
...but it was closed without any resolution." geniepop
Needs Milestone 21036 DB Repair on Multisite looks for wp_1_.... Multisite 3.0 normal normal Awaiting Review defect (bug) new 2012-06-21T12:37:40Z 2012-12-10T00:26:59Z "Log in to your site and need to repair. WP nicely prompts you, so you click the repair button and get this:
{{{
wp_1_posts: Table 'wordpress.wp_1_posts' doesn't exist
wp_1_comments: Table 'wordpress.wp_1_comments' doesn't exist
wp_1_links: Table 'wordpress.wp_1_links' doesn't exist
wp_1_options: Table 'wordpress.wp_1_options' doesn't exist
wp_1_postmeta: Table 'wordpress.wp_1_postmeta' doesn't exist
wp_1_terms: Table 'wordpress.wp_1_terms' doesn't exist
wp_1_term_taxonomy: Table 'wordpress.wp_1_term_taxonomy' doesn't exist
wp_1_term_relationships: Table 'wordpress.wp_1_term_relationships' doesn't exist
wp_1_commentmeta: Table 'wordpress.wp_1_commentmeta' doesn't exist
}}}
I've seen this over and over again, and generally I tell people to go into phpMyAdmin and repair there, which works. But clearly looking for wp_1_ is going to be problematic for non-WPMU upgraded sites. Which are quickly becoming the majority." Ipstenu
Needs Milestone 22840 Uploading an existing plugin saves the zip in media library Upgrade/Install 3.4.2 normal normal Awaiting Review defect (bug) new 2012-12-09T19:35:25Z 2012-12-10T14:01:45Z "Action: Install the same plugin twice.
Expected behavior: Second time, plugin should fail and not install.
Actual Behavior: Install fails, but the plugin's .zip shows in the Media Library. (Shows in Site #1 on Multisite)
This ''is not'' a 3.5 regression, same things happens in 3.4.2" Ipstenu
Needs Milestone 21211 Alter how settings_errors are output in options.php Administration 3.4.1 normal normal Awaiting Review defect (bug) new dev-feedback 2012-07-10T23:44:37Z 2012-12-10T18:43:09Z "The `*_settings_error(s)` and `settings_error` functions are used mainly as part of the Settings API, but with the way that options.php currently handles the settings errors, it assumes that people will use this functionality exclusively with the Settings API. Notice options.php, starting at line 153:
{{{
/**
* Handle settings errors and return to options page
*/
// If no settings errors were registered add a general 'updated' message.
if ( !count( get_settings_errors() ) )
add_settings_error('general', 'settings_updated', __('Settings saved.'), 'updated');
set_transient('settings_errors', get_settings_errors(), 30);
}}}
This simply assumes that no other outside source has registered any sort of setting error other than the current options page. TwentyEleven does this, and so if any other source has registered any notices via these functions, the ""Settings saved."" message will not be output because the first bit of logic will fail. I don't think this assumption can (nor should) be warranted, so there needs to be another way to handle this so that themes like TwentyEleven who only call `settings_errors` at the top of their options page don't get unknowingly hijacked by other sources.
I always suggest registering your own errors at the end of the sanitization callback for your setting, and then output those specific errors within settings_errors to avoid any internal conflicts like this.
Just looking for some ways to approach this. :-)
" griffinjt
Needs Milestone 18590 "Swap out ""return false"" JS calls for preventDefault" Administration 3.3 normal normal Awaiting Review enhancement new has-patch 2011-09-05T03:43:16Z 2012-12-10T23:12:00Z "While trying to hook into someone clicking the expand/collapse arrow in the nav menu UI, I realized that the existing Javascript is using `return false;` to abort the hyperlink click from going through.
[http://fuelyourcoding.com/jquery-events-stop-misusing-return-false/ This is bad and incorrect.]
We should be using `object.preventDefault()` instead so that other bound functions aren't aborted." Viper007Bond
Needs Milestone 18360 One of the links in the Password Reset Mail is wrong lizhenry Users 3.2.1 normal normal Awaiting Review defect (bug) assigned has-patch 2011-08-09T15:55:04Z 2012-12-11T00:27:19Z "Hi,
just a quick note: if {{{FORCE_SSL_ADMIN}}} has been set to true, a password reset-mail could include the wrong protocol for the site-url while the password-reset-link is correct. - I didn't test it with a blog-network, though.
In other words I have both, ''WordPress address (URL)'' and ''Site address (URL)'' set to use the http protocol and in the mail the site-link points to https.
greetz,
Berny" neoxx
Needs Milestone 21271 Make admin backend unit-tests friendly Administration 3.4.1 normal normal Awaiting Review enhancement new dev-feedback 2012-07-14T14:19:20Z 2012-12-11T13:12:31Z "Recently I started writing unit tests for my plugins. Beside tests focused on functionality (where I directly call my plugin functions) I write some basic integrations tests, which should test that WordPress will call my function, pass data in expected format and recognize data returned from it. For frontend it is quite easy - theme API is well-defined, so I can write something like this:
{{{
public function test_something() {
// add new post
$post_id = wp_insert_post( array( ... ) );
$this->assertGreaterThan( 0, $post_id );
// go to post page
$this->go_to( get_permalink( $post_id ) );
// main loop
$checked_post = false;
while ( have_posts() ) {
the_post();
if ( $post_id == get_the_ID() ) {
$checked_post = true;
// test that content is modified
ob_start();
the_content();
$result = ob_get_clean();
$this->assertEquals( '...', $result );
}
}
// make sure test above was executed
$this->assertTrue( $checked_post );
}
}}}
Unfortunately this is not true for admin backend - there most of code is written directly at file level (not in functions and classes), so I would need to either duplicate this code in my tests (bad approach, because would have to monitor original code for changes), or test using whole file (either load it directly or use Selenium) - in this case test would be more complicated.
Therefore I logged this ticket, to start discussion how we can perform refactoring of admin backend to make it more tests-friendly, and how to test it more thoroughly. Most probably we would also need to modify the testing framework (e.g. introduce new `admin_go_to()` method)." sirzooro
Needs Milestone 22670 Konami Code Easter Egg to trigger new Media model Media low normal Awaiting Review enhancement new 2012-12-01T02:41:23Z 2012-12-11T17:31:43Z "Just a harmless easter egg that will trigger 3.5's media uploader via the post editor page. It'd be a fun touch, imho.
To trigger, just use your keyboard and press, in order, up up down down left right left right B A" tw2113
Needs Milestone 22860 Site list in Network Admin shows Master Site where each network site should Multisite 3.5 normal normal Awaiting Review defect (bug) new 2012-12-11T19:27:54Z 2012-12-11T19:56:49Z When in the Network Admin area, hovering on My Sites should present a list of all the active sites on the network, however, while it shows the correct number of sites, the name and links all point to the master site, and not the network sites. This behaviour is not reflected when on the child sites and acts correctly. It is only when in Network Admin. thewanderingbrit
Needs Milestone 22625 Lone less than (<) characters foul up balanceTags() General normal normal Awaiting Review defect (bug) new has-patch 2012-11-28T22:47:23Z 2012-12-11T20:34:57Z "1. Turn on tag balancing.
2. Try this text:
{{{
This is < That.
foo
Text link . Post-link text.
}}}
3. On save, the ending blockquote tag is stripped, and the subsequent text is blockquoted.
We should recognize lone {{{<}}} characters and entity encode them like we do for {{{<3}}}." markjaquith
Needs Milestone 22857 'Header Image' state isn't removed from images previously used as header image Appearance 3.4.2 normal normal Awaiting Review defect (bug) new 2012-12-11T18:54:08Z 2012-12-11T23:04:31Z "Steps to reproduce:
1. Set your site's header image from Appearance -> Header by uploading an image or choosing one from your media library.
2. Repeat step 1.
3. Visit the Media Library and note that your previous header image still says 'Header Image' next to it.
Not a 3.5 regression as it happens in 3.4.2 too.
" johnbillion
Needs Milestone 18707 "Meta Query printing ""array"" in query whwn compara type is LIKE" Query 3.2.1 normal normal Awaiting Review enhancement new dev-feedback 2011-09-19T17:17:48Z 2012-12-11T23:09:48Z "Always a try to filter post by meta_query using a array value and compare equals to ""LIKE"" the returned SQL query is buged. WordPress return something like this:
{{{
(wp_postmeta.meta_key = 'passed_key_value' AND CAST(wp_postmeta.meta_value AS CHAR) LIKE '%Array%'))
}}}
The array values are not serialized, and ""Array"" are outputed to in SQL Query.
Serializing the values the problem still the same and WordPress output in query somethinhg like this
{{{
(wp_postmeta.meta_key = 'passed_key_value' AND CAST(wp_postmeta.meta_value AS CHAR) LIKE '%Array[0], Array[1], Array[2]%'))
}}}
According the [http://codex.wordpress.org/Class_Reference/WP_Query WP_Query documentation], array is supported in field ""value"" for meta_query filters." tplayer
Needs Milestone 19742 WP_Styles should pass more info to the filter General normal normal Awaiting Review enhancement new has-patch 2012-01-04T21:49:30Z 2012-12-11T23:44:10Z "Currently, if your working with wp_enqueue_style(), it's not easy to customize the output of the link element.
The current filter passes the full html along with the style handle. This isn't enough information if you're trying to rebuild the link element.
I'm currently changing rel=""stylesheet"" to rel=""stylesheet/less"" for lesscss suport. I'm currently able to achieve this, but I have to know the style handle.
This patch adds a third param which contains all of the style data available for that style." ptahdunbar
Needs Milestone 22870 Add New Media Page doesn't fail out on large images Media 3.5 normal normal Awaiting Review defect (bug) new 2012-12-12T05:20:15Z 2012-12-12T05:20:15Z "Discovered while debugging #22869 (which is why your steps to repro are similar)
To Reproduce: Upload https://objects.dreamhost.com/ipstenu-images/sunset_2_22_11_by_kenshinkyo-d3a6slk.jpeg to your WP install in the media-new.php page
Note: Image is 12600x9450 and 4.9MB
Expected Outcomes:
VPS/Dedicated with tons of memory: Success
Shared hosted without a lot of memory: Failure, not enough memory
Actual outcomes:
VPS as expected.
Shared
* On 3.4.2: ""Fatal error: Allowed memory size of 268435456 bytes exhausted (tried to allocate 50400 bytes) in /home/blah/site.com/wp-includes/media.php on line 258"" (good)
* 3.5 new uploader correctly errors out with (good)
* 3.5 media-new.php hangs on 'Crunching' (bad)
Obviously media-new.php hanging on crunching isn't desirable. That should error out." Ipstenu
Needs Milestone 22844 random_seed transient is autoloaded with no reason Performance 3.4.2 normal normal Awaiting Review defect (bug) new 2012-12-10T08:55:36Z 2012-12-12T09:00:37Z "As the only use is in password/secret generation which never happens on front end this should not be auto loaded.
IMO Either set an expiry time to avoid auto loading it, or make it an not auto loading option instead of transient." mark-k
Needs Milestone 22881 upgrade fails when disk space is exhausted due to quotas Upgrade/Install 3.4.2 normal normal Awaiting Review defect (bug) new 2012-12-12T11:38:41Z 2012-12-12T11:38:41Z "The upgrade from wordpress 3.4.2 to 3.5 failed due to a disk space limitation:
{{{
Downloading update from http://wordpress.org/wordpress-3.5-new-bundled.zip…
Unpacking the update…
The package could not be installed.: PCLZIP_ERR_BAD_FORMAT (-10) : Unable to find End of Central Dir Record signature
Installation Failed
}}}
A similar bug occurs if the space for the files themselves is exhausted. On the same installation, functions.php was truncated at 112k, leaving the installation in a non-functional state.
This kind of behaviour can be avoided with an upgrade function of the form:
{{{
# test for 64k free disk space ...
dd if=/dev/zero of=biggish-test-file bs=1024 count=64 &&
rm biggish-test-file &&
wget -O - http://wordpress.org/latest.tar.gz | tar -zvx --strip-components=1
}}}
Streaming the download imposes no additional disk space requirements for the intermediate .zip file, but does require a change in the extraction code. Streaming an update cannot be done with zip files, since the index is at the end. ZIP files have to be complete, since the tag is at the end. 'tar' files are more suitable for streaming." list2010@…
Needs Milestone 22880 Customize Themes without activation Appearance normal normal Awaiting Review enhancement new 2012-12-12T11:34:51Z 2012-12-12T11:38:58Z "Add a posibility to customize deactivated themes with the Theme-Customizer without activating them by default.
Useful for Blogs running multiple Themes between which the frontend user can switch." kkkrys
Needs Milestone 22887 "JavaScript inserted using ""attachment_fields_to_edit"" executes too early" Media 3.5 normal normal Awaiting Review defect (bug) new 2012-12-12T13:14:43Z 2012-12-12T16:04:47Z "If I add JavaScript using
',
'value' => 0
);
return $form_fields;
}
}}}
This should always pop a message box containing ""1"" (i.e. the number of elements found with the ""bug_test_div"" id), but it doesn't in the following situation:
Access the admin panel, add a new post and click on the ""Add Media"" button. Upload an image and you will get a message box saying ""1"". Good. Now upload another image and select it. Now you'll get ""0"" instead of ""1"". Select the previous image or any other image and you will still get ""0"" instead of ""1"".
Note that this works without a problem (i.e. always outputs ""1"") in the ""Admin panel -> Media -> Edit Media"" pages.
" liviumirea
Needs Milestone 19780 Named category functions/docs need cleaning up Taxonomy normal normal Awaiting Review enhancement new has-patch 2012-01-08T22:22:20Z 2012-12-12T16:54:09Z "Spawning from a small discussion in #19776, I think it's about time something is done to deal with the older named category functions such as `wp_category_dropdown` and `wp_list_categories` in category-template.php
These functions aren't technically category-only as they accept a set $taxonomy. And because they are actually taxonomy-agnostic, I think we have a few different routes we can take to clean up after ourselves a bit:
A) Lock down these functions to 'categories'-only in favor of new, taxonomy-agnostic ones.
B) Leave the functions alone but let the inline-docs and hard-coded strings such as 'No Categories' reflect their versatility. e.g. 'No Terms' vs 'No Categories'.
C) Deprecate these older functions in deference to newer, taxonomy-agnostic ones." DrewAPicture
Needs Milestone 22845 On 32-bit systems, with post IDs higher than PHP_INT_MAX (2147483647) wordpress does not run fine General 3.4.2 normal normal Awaiting Review enhancement new 2012-12-10T09:13:01Z 2012-12-12T17:42:54Z "Logging all the MySQL queries I discovered that the queries that should pick my posts were all doing something like this:
SELECT post_id, meta_key, meta_value FROM wp_postmeta WHERE post_id IN (2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647)
This 2147483647 number clearly has something in it: it's the PHP_INT_MAX value on 32-bit operating systems, while on 64-bit machines it's 9223372036854775807 http://php.net/manual/en/language.types.integer.php
So, the problem is divided in 2 parts: I run on a 32 bit system, and I have my IDs a bit too high.
I know that 2147483647 is a bit high for a post ID, but I discovered this the hard way.
Now, I would have preferred an error message in the administrator interface. Do you think it's a good idea?" copesc
Needs Milestone 16841 manually created user roles not showing in author dropdown irregardless of assigned capabilities Role/Capability 3.1 normal normal Awaiting Review defect (bug) new 2011-03-12T23:39:39Z 2012-12-12T20:32:08Z "I posted the below on wp-testers hoping to verify or gain experiences from others in order to confirm this prior to reporting it as a bug, but, haven't received any further input, and it's just becoming more evident to me that perhaps it should be posted here, so, I hope I'm not creating a false report here. Please excuse me if I am.
I'm posting this as a link so that it will translate more clearly rather than just cluttering up this message with more text than necessary.
http://lists.automattic.com/pipermail/wp-testers/2011-March/014130.html
Upon further investigation I have also come across the following:
http://core.trac.wordpress.org/ticket/16451
I'm not an expert at debugging this sort of thing, but, I have attempted all within my knowledge thus far, and in looking at all of the returned objects and entries, the only difference I can spot between how the default user roles ( which show up properly in the dropdown ) and the custom created roles ( which do not ) are being returned is that the default user roles, editor for instance, correctly show the deprecated level_7 entry, and the custom user role ( with more assigned privileges than the editor ) does not show user levels in the capabilities array at all, and shows level_0 in the object.
This is leading me to think that perhaps there is something happening with those user levels in creating the author dropdown on the post editor that is blocking the custom user roles from showing up as expected.
When running the following code:
{{{
echo 'Roles ';
foreach ( $wp_roles->role_names as $role => $name ) :
echo ' Role displayed in Admin as ' . $name ;
echo ' Database entry: ' . $role . ' ';
echo ' Capabilities assigned to the role of ' . $name. ' ';
// print_r( $caps);
echo '';
$rolename = get_role($role);
$caps = $rolename->capabilities;
foreach ($caps as $capability => $value):
echo $capability . ' '. $value . ""\n"" ;
endforeach;
echo ' ';
endforeach;
}}}
the default wp roles return the following capability value pairings
{{{
delete_published_posts 1
}}}
roles created with Justin Tadlock's members plugin return the following
{{{
delete_published_posts delete_published_posts
}}}
roles created manually in functions.php utilizing
{{{
add_role( 'test_role', 'Test Role' );
//saved and then removed before running the code below ...
$role = get_role('test_role');
$role->add_cap('read');
$role->add_cap('edit_posts);
$role->add_cap('edit_others_posts');
$role->add_cap('publish_posts');
$role->add_cap('read_private_posts');
$role->add_cap('delete_posts');
$role->add_cap('delete_private_posts');
$role->add_cap('delete_published_posts');
$role->add_cap('delete_others_posts');
$role->add_cap('edit_private_posts');
$role->add_cap('edit_published_posts');
}}}
return the following ...
{{{
delete_published_posts 1
}}}
but lack the user levels as mentioned above.
Let me know if there is any further info I can provide to help sort this out~
" 10sexyapples
Needs Milestone 19747 Roles add_cap should call update_user_level_from_caps() Role/Capability 3.3.1 normal normal Awaiting Review defect (bug) new 2012-01-05T11:17:32Z 2012-12-12T20:39:22Z "Hey guys,
I've created a new user role, which didn't appear in the Author drop down list due to #16841. The workaround is to add a level_1 capability to that user, but because wordpress doesn't call update_user_level_from_caps() function when you add_cap, that isn't actually applied to existing users on the role, and you have to move them to a different role and back again if you want to apply the changed user role.
I'd suggest adding a call to update_user_level_from_caps() to add_cap (and remove_cap) to fix this in wp-includes/capabilities.php" lgladdy
Needs Milestone 22884 What if I delete wp_posts table from database. Database 3.5 normal normal Awaiting Review enhancement new dev-feedback 2012-12-12T12:48:24Z 2012-12-13T11:51:20Z "I am not a experienced or mature programmer but I have seen it While I was playing with database of WordPress.
I have deleted wp_posts table in database in WordPress - 3.5(beta).
It looks normal on other pages at admin side but when i open single post it shows post-new.php and when hit save, it shows ""wp_error"" with this message ""You are not allowed to edit this post.""
That's OK. I was expecting error but not this type of error.
It seems WordPress doesn't know that its most important table has gone away and that's why admin may not know( well for a while). I think its not good. well I don't know its issue or it is way it behaves with database and its normal but I think WordPress should know what exactly happened.
when I have updated WordPress with stable 3.5 it has updated but database is still same which is normal.
Should we( can we )track tables( some of tables which are important ) by PHP ?" mukkundthanki
Needs Milestone 22834 Live Preview should map sidebars as done on activation Appearance 3.4 normal normal Awaiting Review enhancement new 2012-12-09T12:51:00Z 2012-12-13T12:07:31Z "'''Problem:'''
Sidebar disappears in the live preview after theme deactivated.
'''Reproduce:'''
Fresh install of the WordPress trac:
1. Activate Twenty Ten theme
2. Click the Live Preview of Twenty Twelve
3. No sidebar in the preview
Bug 100%" alexvorn2
Needs Milestone 21287 Fix Widgets Helper position on start event - sortable Widgets 3.4.1 normal normal Awaiting Review defect (bug) new 2012-07-16T09:33:24Z 2012-12-13T12:31:33Z "the widget helper moves (jumpes) to the left, to the parent left position...
in Firefox this is not a bug but in chrome it does.
please take a look in the screenshot, the helper jumped to the left....
http://wpimpact.com/wp-content/uploads/2012/07/Untitled-2.png
I tried to use the :
{{{
ui.helper.css('left', ui.placeholder.position().left)
}}}
code but chrome does not set a placeholder position, I don't know why, maybe a chrome bug or in jQuery.
" alexvorn2
Needs Milestone 22926 attachment_fields_to_edit doesn't show on edit image screen Media 3.5 normal normal Awaiting Review defect (bug) new 2012-12-13T23:11:33Z 2012-12-13T23:11:33Z """attachment_fields_to_edit"" works normal when inserting an image with the new media manager, but it doesn't work when editing an image that's already been inserted into the post.
It looks like it's just displaying editimage.html without ever using the filter. " vvu
Needs Milestone 22889 Reconsider no-JS ?replytocom= links Comments normal normal Awaiting Review enhancement new 2012-12-12T15:13:20Z 2012-12-14T13:05:31Z "We have a no-JS fallback for comment replies. Normally JS moves the comment form around. For people with JavaScript disabled, they follow the `?replytocom={123}` link. This results in a lot of extra crawling by search engines (potentially an additional crawl per reply-able comment!) in exchange for enabling an awkwardly executed, likely underused, and non-essential feature for non-JS users.
I'd like to consider making comment reply JS-only." markjaquith
Needs Milestone 22937 Bulk Actions > Edit could allow batch-assignment of taxonomies to Media following the WP 3.5 media changes Media normal normal Awaiting Review feature request new 2012-12-14T13:59:37Z 2012-12-14T13:59:37Z "[First and foremost the media improvements in WP 3.5 are wonderful, thanks to all involved.]
Now that you can assign taxonomies to media easily, it would be extremely useful if you could also use Bulk Actions > Edit (as you can with posts / pages / custom post) to assign them to multiple images more quickly.
Real world case: we added a taxonomy to media yesterday for a client, so they could categorise their ~500 images into sitewide categories, and they immediately replied to ask if there was a way of doing it in batches..." yeswework
Needs Milestone 22940 Adding term checklist to Media modal has undesired results Media 3.5 normal normal Awaiting Review defect (bug) new 2012-12-14T14:59:27Z 2012-12-14T14:59:27Z If you use '''attachment_fields_to_edit''' to add a term checklist to the media modal, there is no way to know when a term is unchecked. I propose that when a checkbox is clicked in the compat section, all the checked boxes of the same name are passed in the POST request. jfarthing84
Needs Milestone 22785 Gallery placeholder buttons sometimes appear overlaid on the wrong editor Media 3.4.2 normal normal Awaiting Review defect (bug) new 2012-12-06T08:24:12Z 2012-12-14T23:32:53Z "If you have multiple visual editors on a screen, the edit/remove buttons that overlay on the gallery placeholder can appear in the right position, but in the wrong editor. If you click the edit button that appeared in the wrong place, the new-to-3.5 media modal shows the image set for the previously clicked placeholder. To reproduce:
* Enable a second editor. Code (`edit_form_after_editor` is new to 3.5):
{{{
add_action( 'edit_form_after_editor', 'hhs_edit_form_after_editor' );
function hhs_edit_form_after_editor() {
wp_editor( '', 'hhs_test_editor' );
}
}}}
* Insert a gallery or two into one of the editors.
* Click inside the editor without the galleries.
* Single click a gallery placeholder in the other. Note that the buttons appear overlaid on the gallery-less editor.
Double clicking a placeholder will bring the buttons to the right place. Clicking within the same editor instance keeps the buttons in the right place. It seems specific to clicking a placeholder in an editor that did not previously have focus, including on page load. On page load, clicking a placeholder in the first (top) editor seems to show the buttons in the lower editor, whereas clicking a placeholder in the lower editor works just fine.
Reproduced in 3.4.2. Probably goes back farther. It probably wouldn't have been noticed in 3.4.2 since the old modal wouldn't have displayed much of anything differently." helen
Needs Milestone 22599 Show reviews in the plugin installer Plugins normal normal Awaiting Review enhancement new 2012-11-27T03:48:50Z 2012-12-14T23:51:19Z Pretty much as it says. Add reviews to the API endpoint, and then allow them to be shown as a tab in the modal. Seems like users should be able to vet via reviews from the comfort of the admin, now that they exist. helen
Needs Milestone 22600 Editor sizing JS puts the resize handle in the wrong place Administration normal normal Awaiting Review defect (bug) new 2012-11-27T03:58:09Z 2012-12-14T23:51:29Z "If you do the following, say to deal with the post content editor in a different way, the resize handle ends up in the wrong place because there is no status bar:
{{{
wp_editor( $post->post_content, 'content', array( 'tinymce' => false ) );
}}}
The JS that deals with the editor size/height should probably be checking for the status bar before moving the resize handle. Discovered while working on #22491." helen
Needs Milestone 22601 Make post content autosave work more generically Autosave normal normal Awaiting Review enhancement new 2012-11-27T04:00:31Z 2012-12-14T23:51:36Z "The JS for autosave/AYS looks for the contents of `#post #content`. While we should fix the other JS issue related to targeting `#content` in #22600, it seems that autosave/AYS should be looking for the textarea (or whatever type of input) with the name of content instead, since having that data in the form will save to the post content. That way, if somebody does choose to use a different ID but the right input name, the autosave benefits will kick in.
Discovered while working on #22491." helen
Needs Milestone 22735 A given pointer should only show once on a screen Administration normal normal Awaiting Review defect (bug) new 2012-12-04T18:10:44Z 2012-12-14T23:51:42Z If you have, say, multiple media buttons on a screen, you'll get multiple pointers, each pointing to an instance of that button. This shouldn't happen. In the case of the media button, it should probably only show up for the one associated with the main editor. In terms of the pointers in general, it should only show up once, not for each match in the DOM. helen
Needs Milestone 22925 media_upload_tabs filter not functioning Media 3.5 normal normal Awaiting Review defect (bug) new 2012-12-13T22:21:28Z 2012-12-15T04:32:25Z When using the media_upload_tabs filter, the array passed through contains a 'library' item that usually can be unset, therefore removing the Media Library tab from the front-end uploader. This no longer works. I cannot even rename the labels using this method, however the array of tabs is still coming through, and modifying it does nothing. The filter is still active, but appears to do nothing. kegster
Needs Milestone 22898 No validation of update_plugins site transient Plugins 2.3 normal normal Awaiting Review defect (bug) new close 2012-12-12T20:50:13Z 2012-12-15T05:55:34Z "When retreiving available plugin updates, no checks are done on update_plugins site transient. Adding a filter on pre_set_site_transient_update_plugins means any developer can modify the update_plugins transient for a plugin to contain incorrect data.
The attached diff has code which is 'reactive', but performs the minimal checks.
This has been tested on trunk." warrenholmes
Needs Milestone 22950 get_boundary_post Does not return single post object General normal normal Awaiting Review defect (bug) new 2012-12-15T00:56:48Z 2012-12-15T11:49:01Z "`get_boundary_post` Seems not to return a single `post` object, the way `get_adjacent_post` does.
It seems that `get_boundary_post` should call `array_shift` or `get_post` on the results, in a similar way to `get_adjacent_post`.
It's just odd that the behavior is different." pathawks
Needs Milestone 20978 Upload a theme like an image Themes 3.5 normal normal Awaiting Review feature request new dev-feedback 2012-06-15T18:26:31Z 2012-12-15T16:45:15Z add option to drag zip files like images on 'theme-install' page, enable multiupload. alexvorn2
Needs Milestone 20791 Add tolerance: 'pointer' option to widgets Widgets 3.3.2 normal normal Awaiting Review feature request reopened dev-feedback 2012-05-30T11:26:20Z 2012-12-15T16:48:03Z "I made a conclusion that it's more easy to sort the widgets in a sidebar if is with tolerance: 'pointer' option enabled...
please consider adding this to sortable function of the widgets. " alexvorn2
Needs Milestone 22909 Special characters are not displayed properly on the menus Menus 3.5 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-12-13T08:09:46Z 2012-12-15T18:52:14Z The previous version of Wordpress 3.4 did handle special characters like ★ and ✄ pretty well. Wordpress 3.4 displays such special characters and they can be used on the Wordpress menus, however in version 3.5, these characters are displayed as empty squares, which does mean that 3.5 can't recognize them properly. varna_city
Needs Milestone 17164 More elegant handling of site 'archive' options for MultiSite Multisite 3.1 normal normal Awaiting Review enhancement new 2011-04-18T15:08:50Z 2012-12-16T06:14:58Z "Right now you have a few options with MultiSite blogs
1) Spam
2) Deactivate
3) Archive
4) Delete
Spam is easy to understand, and should be marking the admin and site as spam. Delete ditto, hi.
Deactivate and Archive are weird though and almost seem backwards. Deactivate means to turn OFF (like deactivating a plugin). Archive implies that you're making a site read-only.
Right now, if you change a site to 'deactivated' it actually shows up as DELETED and the front end has the message ""This user has elected to delete their account and the content is no longer available."" Clearly the verbage on the network/sites.php page needs to be updated (and perhaps the front end to 'This site has been deactivated.' to be consistant).
If you 'Archive' a site it kicks it to a paler pink in the sites.php page (though the 'Archived' text is white and nigh impossible for me to read) and the front end says ""This site has been archived or suspended.""
It's rather illogical there. Archive SOUNDS like it should be making things read-only (and turning off commenting and posting if possible). Otherwise it should just be 'Suspend', and at that point, why have two options that pretty much do the same thing from the front-end perspective?" Ipstenu
Needs Milestone 22534 Make bundled JavaScript LibreJS compatible General normal normal Awaiting Review enhancement new 2012-11-22T01:27:21Z 2012-12-16T06:45:43Z "Many free software advocates don't want to run proprietary JavaScript code in their browsers. The Free Software Foundation has releases a Firefox extension called LibreJS that blocks non-free JavaScript from running: https://www.gnu.org/software/librejs/
WordPress is released under the GPLv2 license, but LibreJS still blocks WordPress JavaScript files because they don't have the appropriate license blocks.
To fix this, we can either add comments to the top of each .js file with the license, or we can use JavaScript web labels to define the license for each js file in HTML.
Here are instructions for marking your JavaScript as free so that LibreJS users will execute it:
https://www.gnu.org/software/librejs/free-your-javascript.html" micahflee
Needs Milestone 17320 has_post_format() should accept an array Taxonomy 3.2 normal normal Awaiting Review enhancement new dev-feedback 2011-05-04T13:06:32Z 2012-12-16T18:13:14Z "{{{has_category()}}}, {{{has_tag()}}}, and {{{has_term()}}} accept an array as the first argument and return {{{true}}} if the post has any of the given terms. {{{has_post_format()}}} also uses {{{has_term()}}} in the background, but it calls {{{sanitize_key()}}} and adds {{{'post-format-'}}} to the passed format, which will fail when you pass an array.
For consistency, it would be better if {{{has_post_format()}}} would also accept an array." janfabry
Needs Milestone 20948 Unnecessary post type check in wp_get_attachment_url Media 3.4 normal normal Awaiting Review defect (bug) new dev-feedback 2012-06-14T02:38:16Z 2012-12-16T23:21:48Z Not sure why this needs to be done. You wouldn't be calling this function on a post if it wasn't an attachment. If you are, then you must have a good reason to be doing so, like I do. jfarthing84
Needs Milestone 22961 """Allow link notifications from other blogs (pingbacks and trackbacks.)"" description is misleading" Text Changes normal normal Awaiting Review defect (bug) new 2012-12-16T14:39:50Z 2012-12-17T11:34:24Z "The description for enabling pingbacks and trackback is ""Allow link notifications from other blogs (pingbacks and trackbacks.)"". Which is not correct a more appropriate description should be ""By default new posts can recieve notification (pingbacks and trackbacks) from other blogs"".
The current description is broken in particular when the option is not set which leads to the assumption that the pingbacks and trackbacks are block while they are not as they are still enabled for posts which were create before the option was disabled." mark-k
Needs Milestone 22967 Null value in meta query changes the type of comparison Query 3.5 normal normal Awaiting Review defect (bug) new has-patch 2012-12-17T00:05:35Z 2012-12-17T14:36:42Z "If a null value is set in a meta query, it effectively returns the same results as setting the 'compare' arg to 'EXISTS', even if it's explicitly set to the default '='.
For example:
{{{
$value_var = null;
...
meta_query => array(
array(
'key' => '_my_meta_key',
'value' => $value_var,
'compare' => '='
)
)
...
}}}
That returns all rows where '_my_meta_key' exists and ignores 'value' instead of treating it like an empty string. This can be troublesome where the value is passed in dynamically like the example, so validation would have to be done prior to every meta query to ensure the value isn't null.
I've attached a patch for review that checks for the existence of the 'value' key rather than using `isset` and casts it to a string if it's null." bradyvercher
Needs Milestone 20461 View All Gallerys Jesse Techno Gallery 3.4 normal normal Awaiting Review feature request new close 2012-04-16T22:55:56Z 2012-12-17T15:39:20Z If you could it would be SO nice to have it so you can see every gallery you have ever posted on your site and then add one gallery to to more then one page/post. jessetechno
Needs Milestone 19531 Wrong error message after correcting an error in username Administration normal normal Awaiting Review defect (bug) reopened dev-feedback 2011-12-13T10:07:56Z 2012-12-17T16:11:17Z "After entering an illegal username (fe. ""Wim (wim@go2people.nl)""), WordPress gives an error message saying:
""ERROR: This username is invalid because it uses illegal characters. Please enter a valid username.""
So far so good.
Now, when I correct the issue and click ""Add new user"" again, the above error message remains in the screen, while the illegal characters are no longer there and the actual error I am facing is that I forgot my password. Which is confusing for me.
The same occurs, when I enter an e-mail which has already been registered. I get the error message:
""ERROR: This email is already registered, please choose another one.""
When I correct, the error message remains, while this particular problem has been solved.
WP v: 3.3
Browser: Google Chrome 14.0 on Ubuntu 11.10
" wimfeijen
Needs Milestone 22980 Get Shortlink button should be appended using the get_sample_permalink_html filter Editor 3.5 normal normal Awaiting Review enhancement new has-patch 2012-12-17T18:39:43Z 2012-12-17T18:49:00Z "Currently the Get Shortlink button is appended directly to the output of get_sample_permalink_html(), which makes it impossible (without CSS/JS) to append items to the HTML.
The get_sample_permalink_html filter should be used inside of
[source:/trunk/wp-admin/edit-form-advanced.php?rev=23180#L334 edit-form-advanced.php] so the user has complete control over the generated output." coreygilmore
Needs Milestone 22949 More Accurate and Extensible MIME Type Handling Media 3.5 normal normal Awaiting Review enhancement new has-patch 2012-12-14T22:08:16Z 2012-12-17T21:42:22Z "In the general case, a file extension may represent more than one MIME type. Currently, file extensions are married to a single MIME.
Specifically, let's look at the case of the ""ico"" file extension. Officially, the MIME type for this file should be ""image/vnd.microsoft.icon"". Unofficially, ""image/x-icon"" along with many others are usable.
The solution to this problem is extremely simple.
First, allow key => value pairs in the exhaustive MIME list located in wp_get_mime_types to be arrays so we can account for cases such as ico.
Second, add the proper handling for this change in wp_check_filetype. The way I have written it should not interfere with existing uses of this function (as they were all passing strings and now can pass a string or array)." mattonomics
Needs Milestone 22968 No way to view_others_posts without being forced to have edit_others_posts enabled Role/Capability 3.5 normal normal Awaiting Review enhancement new 2012-12-17T02:02:42Z 2012-12-18T06:48:22Z "I'm using the Roles plugin to tweak default roles, and I'm looking to add the capability for Authors to read unpublished posts (drafts by other users, so that they can give feedback before they're published).
Unfortunately, it seems that while there's an edit_others_posts perm, there's no equivalent read_others_posts, so doing this is impossible unless you enable editing as well (that's not something I want to do). Read_private_posts doesn't do the trick either, in case you were going to suggest trying it.
The right solution, IMO, is to introduce read_others_posts (and same for pages).
Thank you." archon810
Needs Milestone 22986 WP uses header image's GUID as URL Themes normal normal Awaiting Review defect (bug) new has-patch 2012-12-18T01:28:18Z 2012-12-18T11:57:53Z "See summary. If I move my site (old domain becoming inaccessible), I cannot use my header images any more since
a) I am not allowed to change GUIDs.
b) GUIDs are used as URLs for header images:
http://core.trac.wordpress.org/browser/trunk/wp-includes/theme.php
{{{
1008 foreach ( (array) $headers as $header ) {
1009 $url = esc_url_raw( $header->guid );
}}}" bersbers
Needs Milestone 22976 Remove reference to category to tag converter from the tools page Text Changes normal normal Awaiting Review enhancement new 2012-12-17T16:02:00Z 2012-12-18T16:41:02Z It has been such a long time since version 2.3, does anybody really need a reminder for the existence of this tool on that relatively high profile page? mark-k
Needs Milestone 22992 get_the_author() not working outside the post query Template 3.5 normal normal Awaiting Review defect (bug) new close 2012-12-18T16:16:04Z 2012-12-18T19:55:33Z "get_the_author() function return empty value if is used outside the :
have_posts() ( the_post() .. function...
the function should return the author name on the author page even if the function is not called inside the query...
" alexvorn2
Needs Milestone 20308 Filtering of password protected posts Query 3.4 normal normal Awaiting Review enhancement new dev-feedback 2012-03-27T13:00:19Z 2012-12-18T20:02:00Z "Goal:
to query for password protected posts only or to remove all password protected posts from a query.
Current solution:
Modify the query SQL by using the 'posts_where' filter as suggested here: http://stackoverflow.com/questions/7538959/how-to-exclude-password-protected-posts-in-wordpress-loop
Suggested solution:
Make it possible to modify a parameter via 'pre_get_posts' or 'request' - filter, i.e. $query->set( 'post_password', TRUE )." paddelboot
Needs Milestone 22994 Remove 'blogroll' from the import options Import 3.5 normal normal Awaiting Review enhancement new has-patch 2012-12-18T17:53:16Z 2012-12-18T20:52:24Z "Now that we've dropped links (#21307), we shouldn't encourage importing them. It'll just confuse the newbies.
This will require a change to http://api.wordpress.org/core/importers/1.0/, so while we can clean up /wp-admin/includes/import.php (attached) it won't matter till that's scrubbed. Maybe upgrade that to 1.1 so people who are on older WP are left alone?" Ipstenu
Needs Milestone 22999 The position of the cursor is ignored when inserting media in DFW and Text mode (IE) Media 3.5 normal normal Awaiting Review defect (bug) new 2012-12-19T00:58:22Z 2012-12-19T01:07:36Z "When editing a post in IE8/IE9 in either full screen mode or in text mode, media is always inserted at the top of the post when regardless of where the cursor is positioned prior to opening the ""Add Media"" modal. I suspect that IE7 is also affected, but I have not tested it." gcorne
Needs Milestone 22918 Allow to include ajax url javascript argument in the template header Template 3.5 normal normal Awaiting Review enhancement new close 2012-12-13T15:04:36Z 2012-12-19T02:52:58Z "in the admin-header.php we have a hardcoded javascript code for showing the ajax url in the header. I think this should be included in a function and enqueue when needed, allowing to include it in the template header too using only: wp_enqueue_script('load-ajax-url');
" alexvorn2
Needs Milestone 22557 """Trash"" should be a name" I18N 3.4.2 normal normal Awaiting Review enhancement new close 2012-11-23T15:56:48Z 2012-12-19T04:39:57Z "Hi there,
Not sure if this happens to other languages than pt_BR, but the string ''trash'' sometimes works bad when not as a name.
I would like to suggest to keep the word as a name and avoinding to flex it such ''Trash it, transhing'' etc, there is no need to singular and plural for it, I find silly ""Trashes"" in content tables since there is a counter next to the label.
That's all!" Dianakc
Needs Milestone 23005 wp_update_user breaks if ID not set Users 3.5 normal normal Awaiting Review defect (bug) new 2012-12-19T15:18:42Z 2012-12-19T15:47:58Z "Passing an array of userdata to wp_update_user (first_name, last_name, user_email, user_login).
If ID is not in the array, then a PHP Fatal Error is triggered:
[19-Dec-2012 15:03:16 UTC] PHP Fatal error: Call to a member function to_array() on a non-object in [..]/web/content/wp-includes/user.php on line 1456
The codex for wp_update_user (http://codex.wordpress.org/Function_Reference/wp_update_user) does state ""If $userdata does not contain an 'ID' key, then a new user will be created and the new user's ID will be returned."", which makes me think this might be a new bug." actionnerd
Needs Milestone 23003 Long filename breaks styling in media modal Media 3.5 normal normal Awaiting Review defect (bug) reopened 2012-12-19T12:11:17Z 2012-12-19T16:48:47Z "Long filename in media modal breaks styling of right sidebar. Long filename is displayed bellow thumbnail and longer labels bellow are moved to separate line.
See attached picture." pavelevap
Needs Milestone 21986 Roll sticky posts into MySQL query Query 3.4.2 normal normal Awaiting Review enhancement new has-patch 2012-09-24T19:10:09Z 2012-12-19T19:53:55Z "The way that WP currently queries for sticky posts is quite long winded and prone to error. Sticky posts output behaviour is erratic when using pagination or ordering. I suggest that the sticky posts feature would be better served by being rolled into the MySQL query rather than trying to reconstruct the result set after the main query has run.
I have tested the attached patch against 3.4.2 and it works as expected. The query additions are performed on every page of home, rather than just the first, so that page boundaries behave as expected and that the sticky posts don't appear on subsequent pages. ignore-sticky-posts is honoured." martinshopland
Needs Milestone 22509 No-JS fallback for default color in color picker Administration normal normal Awaiting Review defect (bug) new has-patch 2012-11-19T19:42:19Z 2012-12-19T20:48:22Z "The no-JS fallback for the color picker is just a plain input. Since the color picker implementation now includes the ability to reset to a specified default, it seems to make sense to include a no-JS fallback for the default, even just as a little bit of hidden descriptive text.
See #22461 for discussion stemming from the custom header screen." helen
Needs Milestone 22995 WP_Query Category stuff blank page Query 3.5 normal normal Awaiting Review defect (bug) new 2012-12-18T18:59:18Z 2012-12-19T23:48:54Z "hey there,
maybe I have found a bug. Sending following parameter to the WP Query (with my theme via ''?s=test%cat=1234'') you should get a blank page. At first I thought it was a bug of mine, but deleting following line in /wp-includes/query.php:1746 fixes the problem.
{{{
$q['category__in'][] = $cat;
}}}
So I think there's a bug in the query function...
Thanks,
Ninos" Ninos Ego
Needs Milestone 22993 Admin - users without a role are difficult to find Users 3.5 normal normal Awaiting Review defect (bug) new 2012-12-18T17:32:21Z 2012-12-20T06:21:38Z "There doesn't appear to be a filter to display users *without* a role (see the screenshot). The ideal solution would be to add a filter for ""None"".
[http://i.imgur.com/3S5pH.png]" logikal16
Needs Milestone 16651 Warnings on dashboard: Notice: Trying to get property of non-object in wp-includes/capabilities.php Warnings/Notices 3.0 normal normal Awaiting Review defect (bug) reopened 2011-02-24T19:27:46Z 2012-12-20T08:59:34Z "I just upgraded a local install to 3.1 and have the debug mode on. Now, on the dashboard the ""Recent Comments"" box is filled with notices. I will attach a screen-shot of the notices. Though this doesn't show when debug mode is off, I have to assume that something isn't working with all of these warnings." grandslambert
Needs Milestone 22957 get_boundary_post Only works from a single page Template 2.8 normal normal Awaiting Review defect (bug) new has-patch 2012-12-16T00:36:35Z 2012-12-20T23:29:33Z "I was trying to use `get_boundary_post` in my theme to display a link to the first and last posts, but it does not work from the homepage. Unless called from a single post, `get_boundary_post` will return NULL.
I can't see any reason for this behavior, or any good way around it." pathawks
Needs Milestone 22660 "Admin bar in multisite: mobile tap on ""My Sites"" dropdown in back-end doesn't work" Toolbar 3.4.2 normal normal Awaiting Review defect (bug) new 2012-11-30T20:40:17Z 2012-12-21T00:33:39Z "Quick steps here to reproduce an issue where the ""My Sites"" dropdown (multisite networks) will drop down and show the ""Network Admin"" link and the list of your sites. But, clicking on a site (to expand and see ""Dashboard"", ""New Post"", etc.) does not happen. Tapping the blog name just closes the dropdown.
I'm not sure what's different but I can consistently reproduce this when in the admin back-end (but works OK on front-end admin bar when viewing a site):
From /wp-admin/ on a mobile device (tested on iOS 6, iPhone 5, iPad) with a multisite network:
1. Tap ""My Sites"" in admin bar
2. See ""Network Admin"" and list of sites below
3. Tap one one of the site names
Expected: Site name expands to show ""Dashboard"", ""New Post"", etc. (same behavior as front-end when viewing site). Screenshot: http://d.pr/i/reOi
Actual: Tapping site name simply closes the ""My Sites"" dropdown, does not browse anywhere nor expand menu" devinreams
Needs Milestone 23040 Expand __get() method of WP_Theme object Themes normal normal Awaiting Review enhancement new dev-feedback 2012-12-21T20:11:54Z 2012-12-21T22:28:31Z "Currently, a user can do the following:
{{{
$theme = wp_get_theme();
$version = $theme->Version;
$name = $theme->Name;
$author = $theme->Author;
$version = $theme->Version;
}}}
So, when I tried to get the other data in the same method, I was getting nothing. However, to get the other data, one must do this:
{{{
$theme->{'Author URI'}; // per Codex;
$theme->get( 'AuthorURI' ); // $theme->AuthorURI doesn't work
$theme->get( 'ThemeURI' ); // $theme->ThemeURI & $theme->{'Theme URI'}; doesn't work
$theme->get( 'TextDomain' ); // $theme->TextDomain & $theme->{'Text Domain'}; doesn't work
}}}
get() is a great method to get the other data; however, shouldn't we make this consistent for developers?" wpsmith
Needs Milestone 21744 WP_User_Query does not support post type Users 3.4.1 normal normal Awaiting Review enhancement new has-patch 2012-08-31T00:13:59Z 2012-12-22T07:46:03Z "unfortunately WP_User_Query only support 'post' right now.
i've attached my modified user.php" AliMH
Needs Milestone 22946 Default filter erroneously turns FTP hostnames into HTTP links Formatting 2.0.4 normal normal Awaiting Review defect (bug) new 2012-12-14T20:01:51Z 2012-12-22T19:40:55Z "The function _make_web_ftp_clickable_cb in wp-includes/formatting.php is invoked upon any hostname matching ""www."" or ""ftp."" at the beginning. It pre-pends 'http://' and makes the link clickable (i.e. wraps it in ).
As a default that makes sense for things beginning www. - but not for everything beginning ftp.
In my case, I was using the plugin WP Better Emails, and sent out an email with this line (approx):
`Here is the FTP server: ftp.example.com`
WP, by default, ""helpfully"" totally mangles this into:
`Here is the FTP server: http://ftp.example.com `
The recipient of my email now believes that I was sending him an HTTP link, and is confused that it does not work. But in fact I never sent such a link - that was WordPress mangling what I did send.
Sure, some FTP servers will also have HTTP listening. But by default WordPress assumes that they all do, which is crazy.
Proposed solution: on line 1471 of wp-includes/formatting.php (as found in 3.4.2), change:
{{{
$ret = preg_replace_callback( '#([\s>])((www|ftp)\.[\w\\x80-\\xff\#$%&~/.\-;:=,?@\[\]+]+)#is', '_make_web_ftp_clickable_cb', $ret );
}}}
by removing the ""ftp"" case, hence:
{{{
$ret = preg_replace_callback( '#([\s>])((www)\.[\w\\x80-\\xff\#$%&~/.\-;:=,?@\[\]+]+)#is', '_make_web_ftp_clickable_cb', $ret );
}}}
The function _make_web_ftp_clickable_cb should then be renamed by removing ftp_, since the case of turning FTP hostnames into clickable HTTP links would have been removed." DavidAnderson
Needs Milestone 23049 Template hirarchy for 404 Template normal normal Awaiting Review enhancement new 2012-12-22T17:19:05Z 2012-12-22T19:43:02Z "load 404-{post-type}.php when url structure matches post permalink structure but there is no post at that address.
load 404-{taxonomy}.php when url structure matches taxonomy permalink structure but doesn't match any specific taxonomy tag URL.
And so on....
The idea is to have different 404 pages based on the context to which the URL refers. For example if a site has a blog and a shop it might be better to show a blog specific 404 page when the URL might be interpreted as a post and a shop specific 404 page when the URL might be interpreted as a product." mark-k
Needs Milestone 23050 make_clickable incorrectly formats anchors with URL's and spaces in them in comments Formatting 3.4.2 normal normal Awaiting Review defect (bug) new 2012-12-23T00:32:30Z 2012-12-23T16:27:36Z "When posting a comment, if an anchor tag contains both a URL and some words, make_clickable formats the output incorrectly.
To duplicate, post the following content in a comment:
{{{
Hey! http://wordpress.org is awesome in case you didn't know!
}}}
When viewing the comment, you'll get:
{{{
Hey!
http://wordpress.org is awesome in case you didn't know.
}}}" johnjamesjacoby
Needs Milestone 23047 Gallery sort options Media 3.5 normal normal Awaiting Review defect (bug) new close 2012-12-22T16:58:41Z 2012-12-23T22:54:46Z "Hi,
as stated in this ticket (#22637) I would question wether this is the (complete) solution to the mentioned behaviour:
""...missing gallery sort options. There were a bunch of them in core, in a number of forms:
— Sort the queue ascending and descending (these seemed to invert the queue)
— Order by: Menu order, title, Date/time, and Random
— Order: ascending and descending sort for the ""Order by"" properties
It looks like we need some of this back. These should all be ""on-the-fly"" sorting, as in, they sort the images in the view, then save it to the ""ids"" attribute of the gallery shortcode.
We should support a way to immediately sort the entire gallery by title, date/time, random, and then the ability to inverse the gallery.""" th23
Needs Milestone 19114 Optimise admin css colors Administration 3.3 normal normal Awaiting Review enhancement new 2011-11-02T11:16:11Z 2012-12-24T11:26:56Z "It is really pain to create own admin color pallete, as the current ones are too complex. E.g. in current colors-fresh.css you are using circa 90 colors, many of them almost identical so noone can see the difference (especially when they are on different pages, places) and you are also using different naming conventions
6hexa #666666
3hexa #666
color name black
and also different case in hexa e.g. #FFFBCC vs. #f1f1f1
IMO the default number of different colors could be decreased to about half without visible concerns and also standardising naming convention would help for creating own themes" thomask
Needs Milestone 22225 WordPress does not localize ordinal suffixes in dates I18N 3.4.2 normal normal Awaiting Review enhancement new dev-feedback 2012-10-19T08:39:08Z 2012-12-26T01:48:11Z "In wp-includes/functions.php function date_i18n(), elements like month, month abbreviation, weekday etc.. are localized but not the ordinal suffixes (e.g. st, nd, rt, th)
effect: when using the ordinal suffixes for dates
e.g.
{{{
}}}
on translated/localized page page, the month name is translated (F) but the ordinal suffix no.
Not browser/OS/environment dependent." mihaimihai
Needs Milestone 23056 date_i18n() does not localize dateformat 'r' I18N 1.5 normal normal Awaiting Review defect (bug) new 2012-12-26T02:47:11Z 2012-12-26T04:32:58Z "The weekday and month strings in a date being formatted with the 'r' format character are not being localized.
I've looked at the [http://core.trac.wordpress.org/browser/trunk/wp-includes/functions.php trunk code] and it looks like the 'r' case is not being considered at all in the [http://codex.wordpress.org/Function_Reference/date_i18n date_i18n()] function.
This bug is very easy to reproduce:
{{{
print ( date_i18n( 'r', 972144067 ) );
}}}
Expected output for language Dutch:[[BR]]
''za, 21 okt 2000 16:01:07 +0200''
Received output:[[BR]]
''Sat, 21 Oct 2000 16:01:07 +0000''
== Potential patch: ==
A bit of a hacky patch would go along the lines of:
{{{
if( !function_exists( 'patch_date_i18n' ) ) :
add_filter( 'date_i18n', 'patch_date_i18n', 10, 4 );
function patch_date_i18n( $formatted_date, $req_format, $timestamp, $gmt ) {
if( $req_format !== 'r' )
return $formatted_date;
global $wp_locale;
$datefunc = $gmt? 'gmdate' : 'date';
$find = array (
$datefunc( 'M', $timestamp ),
$datefunc( 'D', $timestamp ),
);
$replace = array(
$wp_locale->get_month_abbrev( $wp_locale->get_month( $datefunc( 'm', $timestamp ) ) ),
$wp_locale->get_weekday_abbrev( $wp_locale->get_weekday( $datefunc( 'w', $timestamp ) ) ),
);
return str_replace( $find, $replace, $formatted_date );
}
endif;
}}}
Hope this helps. Would be great if this could be fixed.
Smile,
Juliette
" jrf
Needs Milestone 23057 Pass $reassign in the delete_user hook Users 3.5 normal normal Awaiting Review enhancement new has-patch 2012-12-26T05:42:00Z 2012-12-26T06:21:14Z "File: wp-admin\includes\user.php
In the wp_delete_user function, there are 2 do_action hooks
- do_action('delete_user', $id);
- do_action('deleted_user', $id);
The $reassign variable should also be passed along. We can then decide what to do when the admin delete a user by ""Delete all posts"" or ""Attribute all posts to: XYZ""." genkisan
Needs Milestone 23060 Throw 404 if URL Rewriting is Used With Default Permalinks Permalinks 3.5 normal normal Awaiting Review enhancement reopened dev-feedback 2012-12-26T20:54:55Z 2012-12-26T21:34:04Z "Suddenly I discovered that my blog is not returning error 404 page. My blog permalink is set as default style http://test.onetarek.com/?p=123
Now I am trying to create 404 error by using this url http://test.onetarek.com/adsfjkasjdd , it showing home page. Then I tested http://test.onetarek.com/?p=123654 now it shows 404 page.
Then I tried to load a not existing image http://test.onetarek.com/wp-content/themes/twentyeleven/images/headers/not-image.jpg it shows my home page instead of 404 page.
I changed my permalink settings to ""Day and name"" then it show 404 page.
I tested this problem in my another blog, this blog is return 404 page but that is not generated by wordpress. Wordpress 404 theme page is not being loaded. A blank page is being loaded with a message by Apache Server ""Additionally, a 404 Not Found error was encountered while trying to use an ErrorDocument to handle the request....""
So what is the problem with permalink settings and 404 page." onetarek
Needs Milestone 23061 get_post_meta() on post with large amount of meta keys uses too much memory Database normal normal Awaiting Review enhancement new 2012-12-27T13:40:17Z 2012-12-27T14:54:48Z "I think it's likely there has been a ticket on this in the past, but I couldn't find one so here goes!
If I have a post that have say 25k post meta entries, and I call `get_post_meta( $id, 'foo', true )` then `update_meta_cache` is going to cause all post metas to be loaded into memory.
In most cases I can see this makes sense, however I recently had an issue where I was storing contest votes as meta keys, a post had 30k votes, and would take about 70MB of memory to get any meta key of that post (even if I didn't want votes). This is fairly edgecase, but the idea that all meta for a post is always loaded even if you don't want it is perhaps over presumptuous as a dev may be storing a large amount of data in meta.
With persistant object caching this is somewhat worse, as the object cache store gets very large.
I am not proposing this functionality is removed, maybe just a filter or something in http://core.trac.wordpress.org/browser/trunk/wp-includes/meta.php#L524 so one could either adjust the query or perhaps pass an array of meta keys to exclude from the sql query" joehoyle
Needs Milestone 21062 Add a 'template_file' hook to load_template() Template 3.4 normal normal Awaiting Review enhancement new dev-feedback 2012-06-24T21:04:50Z 2012-12-28T01:34:51Z "Please consider adding a `'template_file'` hook in `load_template()` to enable the capture of the template filename. I have built a panel for the Debug Bar to be able to show template files loaded but I need this `'template_file'` hook to capture the template file names. This would be super useful for developers who are building sites with the complex template loading logic found in various theme frameworks et. al.
With the hook added the code for `load_template()` might look like this:
{{{
function load_template( $_template_file, $require_once = true ) {
global $posts, $post, $wp_did_header, $wp_did_template_redirect, $wp_query, $wp_rewrite, $wpdb, $wp_version, $wp, $id, $comment, $user_ID;
if ( is_array( $wp_query->query_vars ) )
extract( $wp_query->query_vars, EXTR_SKIP );
$_template_file = apply_filters( 'template_file', $_template_file, $require_once );
if ( $require_once )
require_once( $_template_file );
else
require( $_template_file );
}
}}}
Here's a screenshot showing the Theme Template Files panel I implemented so you can see the use-case. This plugin requires the hook I'm proposing in order to work and I have attached the plugin for other's review.
{{{
#!html
tags that link the two.
Example: Field One Field One
}}}" rulatir
Needs Milestone 20175 """Trash"" should not be a bulk action when user can't delete a post at all" Trash 3.3.1 normal normal Awaiting Review defect (bug) new has-patch 2012-03-04T15:20:19Z 2013-01-09T03:55:37Z "When a user can't delete posts at all for a certain post type the bulk action to delete posts is useless.
Not sure if the following check is correct:
{{{
if ( current_user_can( $post_type_object->cap->delete_post ) ) {
if ( $this->is_trash || !EMPTY_TRASH_DAYS )
$actions['delete'] = __( 'Delete Permanently' );
else
$actions['trash'] = __( 'Move to Trash' );
}
}}}
Maybe the edit/restore functionality should have some similar check" markoheijnen
Needs Milestone 23162 Allow to call parent_dropdown() for an arbitrary post Administration normal normal Awaiting Review enhancement new 2013-01-09T22:48:08Z 2013-01-09T23:24:26Z "parent_dropdown() can no longer be used outside of the loop, such as within the wp-admin, because an E_NOTICE will be emitted in template.php:683 since $post is null.
A simple fix is to change the function argument declarations from
{{{
function parent_dropdown( $default = 0, $parent = 0, $level = 0 ) {
}}}
to:
{{{
function parent_dropdown( $default = 0, $parent = 0, $level = 0, $post = array() ) {
}}}
and then also change:
{{{
$post = get_post();
}}}
to
{{{
if ( empty( $post )) {
$post = get_post();
}
}}}
which would allow a WP post object to be passed into the function.
Sorry I am unable to provide an SVN patch.
" charliespider
Needs Milestone 22661 Allow object caches to degrade gracefully Cache normal normal Awaiting Review defect (bug) new 2012-11-30T20:53:57Z 2013-01-10T00:08:36Z "Because of the way object caches are loaded, if a custom object cache can't run (say, Memcached or APC is not actually installed), it cannot gracefully degrade to the built-in object cache.
Witness this code in {{{wp_start_object_cache()}}}:
{{{
if ( ! function_exists( 'wp_cache_init' ) ) {
if ( file_exists( WP_CONTENT_DIR . '/object-cache.php' ) ) {
require_once ( WP_CONTENT_DIR . '/object-cache.php' );
$_wp_using_ext_object_cache = true;
} else {
require_once ( ABSPATH . WPINC . '/cache.php' );
$_wp_using_ext_object_cache = false;
}
$first_init = true;
} else if ( !$_wp_using_ext_object_cache && file_exists( WP_CONTENT_DIR . '/object-cache.php' ) ) {
// Sometimes advanced-cache.php can load object-cache.php before it is loaded here.
// This breaks the function_exists check above and can result in $_wp_using_ext_object_cache
// being set incorrectly. Double check if an external cache exists.
$_wp_using_ext_object_cache = true;
}
}}}
So a custom object cache is loaded. If it wants to bail and defer to the built in object caching, it can do that by doing the include itself. But then WordPress sets {{{$_wp_using_ext_object_cache = true;}}} '''after''' that require. So WordPress thinks it is using an external object cache when it's actually not. This leads to oddness.
This can sometimes be hacked around by adding a callback to the very first WP action available that sets {{{$_wp_using_ext_object_cache = false;}}}, but that has issues: calls to the object cache might be made before that code can run, and {{{add_action()}}} is not always available at that point (because some {{{advanced-cache.php}}} drop-ins load the object cache really early. See Batcache.
Proposed solution: change the order of the {{{require_once()}}} and the setting of {{{$_wp_using_ext_object_cache}}}. That way, the external object cache can override the variable." markjaquith
Needs Milestone 22185 Distraction Free Writing mode lacks any controls on touch devices Editor 3.2 normal normal Awaiting Review defect (bug) new 2012-10-13T22:39:05Z 2013-01-10T00:30:44Z "Distraction Free Writing mode on touch devices is pretty disastrous. All the controls disappear, meaning you can't apply any formatting and - more importantly - you can't save your content or exit fullscreen mode.
Not sure what would be best:
1. Don't autohide the controls at all on touch devices.
2. Autohide the controls but add a toggle button which shows up on touch devices to toggle the controls on again.
" johnbillion
Needs Milestone 22367 "Usernames with ""@"" char are assumed email addresses, causing incorrect look-up in several places" Users normal normal Awaiting Review defect (bug) new has-patch 2012-11-06T00:45:19Z 2013-01-10T10:57:23Z "'''Problem'''
Usernames containing the ""@"" character are mistakenly assumed to be email addresses when:
* wp-login.php - Resetting passwords
* /wp-admin/user-new.php - Adding an existing user to a site, in multisite
* /wp-includes/user.php - Searching for a user
----
'''Duplicate'''
* Create a user with the login ""@testing""
* Verify the account, etc...
'''Bug in Search'''
* Visit: wp-admin/network/users.php - attempt to search for: ""@testing""
* Result: no users found
* What should happen: find the user
'''Bug in Add New'''
* Visit: wp-admin/wp-admin/user-new.php - attempt to add: ""@testing""
* Result: no users found
* What should happen: add the user
'''Bug in Reset Password'''
* Visit: wp-login.php - attempt to reset password for: ""@testing""
* Result: retrieve_password() accidentally succeeds, because strpos() check returns 0, which is the correct position of the ""@"" character. If the username was ""testing@"" this test would fail
----
'''Solution'''
The attached patch fixes these bugs by using is_email() instead of an strpos() for an @ character." johnjamesjacoby
Needs Milestone 22022 Can’t properly add pages of type edit.php?post_type=xxx as submenu items to arbitrary parent menus Administration 3.0 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-09-27T20:22:43Z 2013-01-11T11:22:48Z "The following code illustrates the problem.
{{{
add_menu_page('My Pages', 'My Pages', 'edit_posts', 'parentslug', array(class, func));
add_submenu_page('parentslug', 'Settings', 'Settings', 'edit_posts', 'mysettings', array(class, func));
add_submenu_page('parentslug', 'Custom Post Type', 'Custom Post Type', 'edit_posts', 'edit.php?post_type=xxx');
}}}
When you click on the first submenu item, the menu stays open, displaying the submenu items as it should. When you click on the item for the custom post type, the parent menu is closed and submenu pages are not displayed.
The root of the problem is how $parent_page is handled for pages of type edit.php?post_type=xxx. In get_admin_page_parent(), $parent_file is always set to $submenu[$parent], which may cause the submenu slug to be different from $parent_file. But in _wp_menu_output, if the submenu slug and parent slug are not equal, the 'wp-has-current-submenu wp-menu-open' classes do not get added which means the menu gets displayed as being closed.
Since there are no actions called between get_admin_parent_page() and the output of the menu, the only workaround I can see is some ugly JS that fixes up the classes.
It seems like the least intrusive fix would be to just move the call to apply_filters(""parent_file) in menu-header.php to after the call to get_admin_page_parent() so that $parent_file can truly be overridden. This also seems inline with the intent of the filter.
" jjharr
Needs Milestone 23159 Add Words Counter In The Excerpt Metabox Editor 3.5 normal normal Awaiting Review enhancement new 2013-01-09T19:46:57Z 2013-01-11T17:26:24Z "Hi WordPress Lovers :) , WordPress 3.6 fouces on ""Content Editing"" a small good idea is to add a words counter in the bottom of excerpt meta-box , and a small tip of the current theme max words count .." alex-ye
Needs Milestone 23183 Single Page Application/OData API General normal normal Awaiting Review enhancement new 2013-01-11T18:15:34Z 2013-01-11T22:45:13Z I am interested in helping out. Are there any plans to move to a Single Page Application model. I know this would take a lot of work as we would have to code a secure Web API into the core (I would go with standard OData service API) but as mobile devices become more critical to web success WordPress needs to find a way to minimize requests and allow for occasionally connected solutions. I know this would be for major release 4 or possibly even 5 depending on the impact to plugin developers but it make a noticeable difference on the scalability of wordpress. cportwood
Needs Milestone 17999 Failure to Update Notification Persists After Manual Upgrade Upgrade/Install 3.2 normal normal Awaiting Review defect (bug) new 2011-07-05T20:30:08Z 2013-01-13T16:42:27Z "This has been around for a few versions. When an update fails, if the user updates or upgrades manually and WordPress lists the updated version in the Administration Panels, the failure to update notification persists.
I've sat through four or five updates with the failure notice on every panel, including WordPress 3.2, on several sites." Lorelle
Needs Milestone 19296 add/apend templates 'transparently' via plugin to currently active theme or child theme. Themes normal normal Awaiting Review enhancement new close 2011-11-19T02:00:27Z 2013-01-13T17:35:39Z "In building a custom 'theme plugin' for bbpress I was just made aware that it is impossible for a plugin to 'transparently' add/append template files to the currently active theme or child theme.
I'd like to request the enhancement where when a theme is looking for a custom template such as single-forum.php to search a plugin folder if it is not found in the child theme or parent theme.
I'm thinking of some type of action where my plugin can say 'add me' to the list of places you are looking for templates.
If my understanding is correct, when WordPress is looking for a template it starts in the child, then the parent theme but ends there.
Why?
If I have a user manually add all of the custom templates needed to their current theme, and they update their theme, they will loose all the templates they manually added.
This means I have no way of giving a user custom theme templates that won't be lost when upgrading, thus requiring them to manually add the templates back in every time they upgrade their theme.
What it really means for me is that there is no real path for me to create custom bbpress templates for users where I don't have to worry about them loosing them.
I can go the route that bbpress currently uses in this situation which is that bbpress uses the themes page.php template and replaces the_content(). The problem is I am stuck with whatever is included in the active themes page.php file.
*for instance twentyten has the title hardcoded in and the call to the sidebar, which I can't remove
I can't go the child theme route, because I have to assume that they are already using a child theme.
Another dev told me today that this issue came up about 2 years ago. I am praying that there was proof of concept code somewhere that I can try to utilize. Does anyone happen to know if concept code exists anywhere?" anointed
Needs Milestone 21891 Need ability to filter page templates Template 3.4.2 normal normal Awaiting Review enhancement new close 2012-09-14T17:38:50Z 2013-01-13T18:33:14Z "The old way of removing a parent theme's templates (as documented [http://wordpress.org/support/topic/removing-page-template-from-child-theme?replies=3 here], [http://wordpress.stackexchange.com/questions/54054/how-to-remove-a-parent-theme-template-from-quick-edit here], and [http://stackoverflow.com/questions/9411612/wordpress-hiding-or-removing-parent-themes-templates here]) broke with the big theme-handling rewrite in 3.4.
The primary use case of a new filter would be to allow a child theme to remove or rename a parent theme page template in the Dashboard. It's possible that part of the `get_page_templates()` function might have to be tweaked to allow for the scenario where one or more pages is using a template that no longer ""exists,"" but I'm not sure.
Hopefully this is as simple as adding `apply_filters( 'page_templates', $page_templates );` somewhere in [http://core.trac.wordpress.org/browser/trunk/wp-includes/class-wp-theme.php#L920 class-wp-theme.php]." mrwweb
Needs Milestone 16957 wpuntexturize - problem with numbers and non-breaking spaces Formatting 3.1 normal normal Awaiting Review defect (bug) new 2011-03-24T10:21:33Z 2013-01-14T01:37:56Z "1) Insert following code into HTML editor and publish.
{{{
New Year ""2011"" will be fantastic.
}}}
Then look at website:
{{{
New Year ”2011″ will be fantastic.
}}}
You can see wrong html quotes.
2) I also worked with TinyMCE editor (only writing simple text, paragraphs, strong, moving some parts of text by CTRL+C and CTRL+V). But after publishing, there were hidden non-breaking spaces in text. There were on different places, for example before ""("" and after characters ""."", ""í"", ""é"", etc. But they were random. I am not sure how it can be caused? Non-breaking strings were not visible and also not transformed into HTML entity on website. I noticed them only in HEX editor, when examining HTML source code (C2 A0).
Of course, when these non-breaking spaces were before (or after) quotes, then quotes were not recognized regurarly by wpuntexturize, example:
{{{
Nemám žádné ""úžasné"" schopnosti.
}}}
Is transformed by wpuntexturize into:
{{{
Nemám žádné ”úžasné” schopnosti
.
}}}
You can see wrong open quote:
{{{
instead of “ there is ”
}}}
But only when hidden non-breaking space (C2 A0) is between žádné a ""úžasné""." pavelevap
Needs Milestone 23185 Hyphens surrounded by non-breaking spaces are not texturized Formatting 2.8 normal normal Awaiting Review defect (bug) new has-patch 2013-01-11T20:13:11Z 2013-01-14T01:45:52Z "Thanks to Ticket #8161, a single hyphen or double hyphen surounded by space is converted to an en-dash or em-dash, respectively.
The problem is this conversion doesn't take place as expected when the space immediately before or after the affected hypehns is a non-breaking space.
Example paste the following into a post as HTML and view it in a browser after texturization:
{{{
Line 1 - Non-breaking spaces around the hyphen.
$add_below, 'depth' => $depth, 'max_depth' => $args['max_depth']))) ?>
}}}
This can simply be enhanced to this:
{{{
$add_below, 'depth' => $depth, 'max_depth' => $args['max_depth']))) ?>
}}}
I just added a quick check to make sure our current comment depth did not meet (or somehow exceed?) our set max depth." TheGremlyn
Needs Milestone 23212 wp_signup.php always get 404 status header Multisite 3.5 normal normal Awaiting Review defect (bug) new reporter-feedback 2013-01-16T02:04:14Z 2013-01-16T04:20:54Z "I get 404 in status header for wp_signup.php in few server,
I think it was caused by class WP->handle_404();
" apineraka
Needs Milestone 23022 Always set posts to draft status when untrashing Trash 2.9 normal normal Awaiting Review enhancement new dev-feedback 2012-12-20T15:00:43Z 2013-01-16T05:51:21Z "In some situations it is bad when trashed posts immediately go live after being untrashed. Such as:
* A published post is found to have libellous/wrong/other_bad content in it
* Admin trashes the post
* Admin wants to edit the post and republish it without the bad things
* Admin cannot do this without republishing the bad things, which they cannot do.
I appreciate that the user should have unpublished the post rather than trashing it but people don't always think clearly in these situations, and once you're in it, you can't get out -- your options are to republish, permanently delete, or leave the post in limbo.
I did wonder if it would be better to make trashed posts viewable/editable in the admin but that felt like a pretty big move, and one that would make the status of a trashed post much less clear and rather ambiguous.
So, the attached patch sets all untrashed posts to draft status, rather than restoring their original status, which was the only other thing I could think of.
(Definitely happy to debate alternative solutions)" harrym
Needs Milestone 22862 Consider a CSS preprocessor Administration normal normal Awaiting Review feature request new 2012-12-11T22:01:36Z 2013-01-16T10:33:34Z "The WordPress admin UI CSS is woefully doomed to a life of inadequacy unless we can amenably agree to use technology already available to build a better future for us and our children.
I propose the introduction of SASS for the WordPress admin styling. SASS is a CSS pre-processor that allows us to write DRY, structured, lightweight CSS. In terms of licensing, SASS is GPL-compatible, licensed under the MIT license.
'''Why use SASS over LESS?'''
The answer is simple. SASS is easier to learn and easier to use because it follows the conventions of CSS at its core. In addition, for developers itching to contribute, there are some extremely useful and easy-to-follow reference docs for SASS, making it easy to set up your local development environment and build websites.
'''What are the advantages?'''
The biggest advantage is that we can write less CSS and offer advanced features for theming the WordPress Admin UI. Developers can more easily reskin the WordPress admin.
Another major benefit is that SASS offers the use of variables within our stylesheets. For our purposes, these variables can be used to calculate layout widths, generate color schemes, font sizes, etc.
Another simple advantage is the fact that we can combine all our CSS styles into a single stylesheet, saving precious HTTP requests. In addition, we can easily minify generated CSS files in bundled versions of WordPress, saving file size and killing unnecessary white space, thus decreasing load times of the admin even further.
'''What are the disadvantages?'''
Developers will need to install Ruby and SASS in order to modify styles for the WordPress Admin. For plugin authors, we should write admin UI CSS in such a way that it is easily overridden with a custom CSS file.
In addition, developers would need to learn SASS if they are going to work directly on the styles for the WordPress admin. For the most part, once you've got the idea of variables, mix-ins, and the structure - you're ready to rock.
Last, but not least, when SASS files are modified, they would need to be compiled and committed to Core every time they change. So instead of pushing a single CSS file, you would be pushing potentially many SCSS files and a generated CSS file.
'''In Summary'''
SASS is a great way to reduce code overhead by adhering to DRY principles and will improve performance and modularity in the WordPress admin, which is a top priority." chriswallace
Needs Milestone 23203 Scheduling Posts assumes GMT but UI uses local timezone (creating undesired scheduled posts) Date/Time 3.5 normal normal Awaiting Review defect (bug) new dev-feedback 2013-01-15T15:32:09Z 2013-01-16T13:16:59Z "I experienced an odd behavior when going to edit a page on a newly created site in a multisite environment. The site uses the New York timezone (GMT-5).
When quick-editing the page, I changed the title and slug, but pressing ""Update"" set the page as ""Scheduled"" rather than leaving it ""Published"". This was very confusing, and took a while to figure out and then explain to the end user. It seems that although the date/time is shown in the UI in the current time zone, once submitted the form interprets the time as if it were in GMT. To the end user, it looks like the page should be published since the time shows what we thought was a 5 minutes ago. In reality, the time in the date field is not recognized as 5 minute ago but 4 hours and 55 minutes in the future.
This is a problem in the full edit form for pages in this newly created site as well. When I go to edit the published time/date, the posted time in my timezone is shown. However, ''even if I hit 'Cancel' the ""Update"" button changes to ""Schedule""''." bananastalktome
Needs Milestone 21540 Add support for responsive video embeds Viper007Bond Embeds normal normal Awaiting Review enhancement assigned 2012-08-10T17:15:50Z 2013-01-17T17:27:31Z "By wrapping the html content of a video embed with a container (incl. class name), we could provide a simplified way for Theme authors to make video embeds truly responsive, through basic CSS.
See #21480" obenland
Needs Milestone 21584 Allow to create more networks Multisite 3.4.1 normal normal Awaiting Review feature request new dev-feedback 2012-08-15T00:34:24Z 2013-01-17T23:38:47Z "After creating a multisite installation allow users to create their own network of blogs.
" alexvorn2
Needs Milestone 22805 Add a hook for the live theme preview event Themes 3.4.2 normal normal Awaiting Review enhancement new 2012-12-07T11:19:52Z 2013-01-17T23:42:52Z "We have a hook for theme activation and deactivation, but for the theme live preview - not...
" alexvorn2
Needs Milestone 21002 Feature request: wp_link_pages() needs support for formatting the current page General normal normal Awaiting Review feature request reopened 2012-06-17T19:09:51Z 2013-01-18T02:27:18Z "To follow up my previous feature request #21001, it would be super to see a way to style/format the current page, because it could look different compared to links to other pages (for example "">> Page % <<""). An option called currentpagelink seems fitting." archon810
Needs Milestone 18548 Add a better option for tags joostdevalk Template 3.3 normal normal Awaiting Review enhancement new dev-feedback 2011-08-30T20:32:15Z 2013-01-18T04:17:40Z "Right now, title tags in themes are created by using wp_title and than adding on custom code, usually bloginfo('name'), sometimes other code. Because there's basically no way for a plugin to control the entire content of a title tag, all major SEO plugins resort to output buffering.
A better way would be to output the <title> tag during the run of wp_head, based on whether the current theme has added theme_support. See attached patch for the proposed implementation. This patch also fixes the requested array filter in #17877." joostdevalk
Needs Milestone 18362 Post timestamp creation should use whitelisted post statuses instead of blacklisted danielbachhuber General 3.0 normal normal Awaiting Review enhancement assigned has-patch 2011-08-09T16:51:55Z 2013-01-18T23:58:43Z "post_date and post_date_gmt timestamps are created when a post is published. The method should create timestamps based on whitelisted post statuses, instead of ""not in a blacklist"" as it exists currently.
Backstory: We have a plugin that allows users to create custom statuses. It uses the partially completed custom status API and additional code we've written. In the WordPress.org forum, a [http://wordpress.org/support/topic/plugin-edit-flow-custom-statuses-create-timestamp-problem bug was reported] where if they use a custom status with a post, the post time is set. Currently, they have to manually edit the timestamp of the post before publishing in order for it to be set to the proper publication date (instead of 5 days ago when they originally created it).
The origin of the problem is [http://core.trac.wordpress.org/browser/tags/3.2.1/wp-includes/post.php#L2506 line #2506 in wp-includes/post.php]. The post statuses to receive timestamps should be whitelisted instead of blacklisted. Because the custom statuses aren't a part of the blacklist, they receive a GMT timesteamp." danielbachhuber
Needs Milestone 22350 Restored Drafts Shouldn't Have a Publication Date Trash 3.4.2 normal normal Awaiting Review defect (bug) new 2012-11-03T00:07:39Z 2013-01-19T00:00:40Z "After creating a draft, trashing it, and then restoring it, the post editor shows a ""Publish on"" date as though it were a scheduled post, and the Date value in the list of all posts will be wrong after further editing (e.g. ""3 hours ago, Last Modified"")." miqrogroove
Needs Milestone 23228 get_users() cannot include AND exclude Users 3.5 normal normal Awaiting Review defect (bug) new reporter-feedback 2013-01-17T22:45:51Z 2013-01-19T03:56:22Z "The codex describes the parameters for get_users() as an array of options, so it seems like you can set an array of includes and an array of excludes. But the code looks like it can only do one or the other. It would be a simple fix.
Lines 521-527 in wp-includes/user.php
{{{
if ( !empty( $qv['include'] ) ) {
$ids = implode( ',', wp_parse_id_list( $qv['include'] ) );
$this->query_where .= "" AND $wpdb->users.ID IN ($ids)"";
} elseif ( !empty($qv['exclude']) ) {
$ids = implode( ',', wp_parse_id_list( $qv['exclude'] ) );
$this->query_where .= "" AND $wpdb->users.ID NOT IN ($ids)"";
}
}}}
To fix, change the elseif to its own if:
{{{
if ( !empty( $qv['include'] ) ) {
$ids = implode( ',', wp_parse_id_list( $qv['include'] ) );
$this->query_where .= "" AND $wpdb->users.ID IN ($ids)"";
}
if ( !empty($qv['exclude']) ) {
$ids = implode( ',', wp_parse_id_list( $qv['exclude'] ) );
$this->query_where .= "" AND $wpdb->users.ID NOT IN ($ids)"";
}
}}}
Thanks for the consideration." dlim_vernier
Needs Milestone 23229 Pagination Links Broken Permalinks normal normal Awaiting Review defect (bug) new has-patch 2013-01-17T23:11:04Z 2013-01-19T04:47:55Z "Currently, if the request URL ends with ""page/[\d]+/?"" it will always assume that it is the pretty version of the paged parameter, and rewrite that section of the URL.
This breaks in any condition where a numeric value follows that string at the end of a URL. An example that can be easily reproduced is as follows:
1) Set theme to TwentyEleven
2) Modify the theme to output the results of get_pagenum_link(2) anywhere.
3) Change permalink structure to ""/daily-page/%year%/%monthnum%/%post_id%/""
4) Go to a year archive for the permalink structure above.
5) The result of the get_pagenum_link will look like this: ""/daily-/page/2/"", breaking pagination within this context.
I've attached a patch against current trunk code that addresses this, providing the following features:
1) Pagination links functional in the scenario above, along with custom rewrite rules.
2) Updated to allow numeric post names for hierarchical post types (currently always rewritten with ""-2"")
3) Updated get_pagenum_link filter to include pagenum parameter as it was passed in.
" ssmathias
Needs Milestone 23179 New avatar related option - use gravatar only for registered users Comments normal normal Awaiting Review enhancement new 2013-01-11T15:40:59Z 2013-01-21T04:42:39Z "The use of gravater is problematic because there is no attempt to verify that a comment with which an email was used was actually left by the owner of the email (AFAICT gravatar doesn't even have an API for authentication).
This makes impersonating to someone else that have a gravatar in a wordpress site comments much too easy.
IMO non autogenerated gravatars should be displayed by default only for users for which it is known that they actually own the email address, which are usually only the registered users." mark-k
Needs Milestone 16613 Extend Widget API to allow sidebar/widget manipulation Widgets 3.1 low normal Awaiting Review enhancement new dev-feedback 2011-02-21T22:55:17Z 2013-01-21T17:27:26Z "There is currently no easy way to add a widget to a sidebar using code. We should add methods of doing this.
A good example usage of such an API could be when a new theme is activated, it could add it's custom widgets to it's sidebar.
API should provide support for adding widget X to sidebar Y (or even just the first sidebar) along with setting some options for the widget and where in the sidebar to add it (top vs. bottom)." Viper007Bond
Needs Milestone 23253 Lack of a do_settings_section (singular) function Plugins normal normal Awaiting Review enhancement new 2013-01-21T19:20:06Z 2013-01-21T19:20:06Z "After considerable research I have found that plugin authors, including myself, have to go to great lengths to put options into tabs on a plugin settings page. The majority use JavaScript to modify the DOM in order to achieve this, others have broken their options into several settings arrays instead of the recommended single array to facilitate the creation of tabs using the traditional WordPress nav-tab-wrapper class approach.
To get my own options into tabs in a fully scoped css jquery ui theme I ended up adding my own hacky function to my plugin: myplugin_do_settings_section( $page, $sectionid ) - which is just a copy of the core function do_settings_sections( $page ) with an additional parameter for the section id and an added conditional to only output the section with the requested id.
This allows me to wrap each section in the appropriately classed tags for either jquery ui tabs or traditional WordPress nav-tabs. This however, is not an acceptable long-term solution as the core code will undoubtedly change, I already see tickets and revisions relating to the removal of those nasty tables...
This functionality should be in the core code. A settings section is a ''section'' and it should be possible to output them one at a time to allow for styling.
Thanks for considering my proposal.
(Also, the Iris color picker does not play nice with jquery-ui - it needs its own css scope or something - that will be a separate ticket once I have a better understanding of what is wrong with it and have searched for existing tickets on the subject.)
" auniquename
Needs Milestone 17951 Move or duplicate comment actions at top of each comment row Comments normal normal Awaiting Review enhancement new close 2011-06-30T17:29:35Z 2013-01-21T23:31:29Z "When I attempt to take an action on a comment and the comment is EXTREMELY long, it takes a while to get to the SPAM link since it's at the bottom of the comment.
This ticket is to simply propose moving the actions to the top, rather than the bottom of the comment. Or perhaps duplicate the actions there, since they are only visible on hover anyway." chriswallace
Needs Milestone 22984 "Media Modal - Auto-save for compat-items doesn't trigger the UI to show the spinner or ""Saved"" indicators." Media 3.5 normal normal Awaiting Review enhancement new 2012-12-18T00:10:53Z 2013-01-22T00:22:10Z "When the auto-save kicks in for the standard attachment editor fields, it triggers the spinner icon in the top right corner. This is followed by ""Saved"" which then disappears on its own. None of these UI indicators are triggered for custom input items added via the 'attachment_fields_to_edit hook.
Not sure if its was an oversight or simply not seen as important." eddiemoya
Needs Milestone 18530 Browser update dismiss setting ignored with JavaScript disabled Administration 3.2.1 normal normal Awaiting Review defect (bug) new dev-feedback 2011-08-27T15:41:24Z 2013-01-22T01:14:57Z "When working on a corporate desktop you can not update your browser. When freely deciding about when to upgrade you might not even want to upgrade.
Therefore a user setting has been introduced to remove the nag warning. E.g. my linux distro is perfectly ok with it's firefox and it's taken care of by the pacakager. For my OS, I have the latest version.
I needed to press dismiss (with JS enabled, the related report is #17766).
What has been missed is to not display that nag if javascript is disabled. The setting gets ignored.
How to Reproducde
* Setup a WP 3.2.1 Blog.
* Log into admin with a Firefox 3 browser.
* Enable Javascript.
* Dismiss the Nag.
* Logout and close the Browser.
* Restart the Browser.
* Disable Javascript (if you need to).
* Log into Dashboard.
Result: Browser Update Nag is displayed.
Expected Result: Browser Update Nag is not displayed as specified by the user." hakre
Needs Milestone 18556 Toolbar dropdowns when dragging items drecodeam* Toolbar 3.2.1 normal normal Awaiting Review defect (bug) accepted has-patch 2011-08-31T19:15:17Z 2013-01-22T01:17:35Z "When dragging metaboxes, widgets, menu items, etc to the top of the window in order to scroll to drop the item on a portion of the UI that's above the viewing window, the toolbar interferes and produces dropdowns, etc.
If dragging an item, can we disable toolbar actions?
" chexee
Needs Milestone 19737 """What's New"" screen confusing for minor updates" Help/About 3.3 normal normal Awaiting Review defect (bug) new 2012-01-04T17:49:14Z 2013-01-22T01:34:46Z "As [http://www.wptavern.com/wordpress-3-3-1-fixes-security-exploit reported on WPTavern], when you ugprade to 3.3.1, the ""What's New"" screen makes it seem like all the new features were introduced in 3.3.1 and not 3.3.
We should add a header below the short summary to the effect of ""New features introduced in 3.3""." scribu
Needs Milestone 22822 New media: 'Create a new gallery' button should indicate that it's the first of two steps Media 3.5 normal normal Awaiting Review enhancement new has-patch 2012-12-08T00:35:34Z 2013-01-22T01:57:11Z "When creating a gallery, the primary action button at the bottom of the screen says 'Create a new gallery'. This button is actually the first of two steps, but this button doesn't make that clear.
It should either have an ellipsis appended, which is a standard UI convention for a non-immediate action, or it should say something like 'Next »'" johnbillion
Needs Milestone 13227 Add filters above forms in wp-login.php Administration 3.0 normal normal Awaiting Review enhancement new has-patch 2010-05-03T13:25:58Z 2013-01-22T02:00:35Z "Sometimes I need more descriptive text to have above forms on wp-login.php (login, register, lost password).
This patch add filters above those forms.
Example usage:
{{{
function above_login_form_filter() {
return '<p class=""message"">Tip: If you forgot your password, go to <a href=""wp-login.php?action=lostpassword"">Lost Password</a> page</p>';
}
add_filter('above_login_form','above_login_form_filter');
}}}
" dimadin
Needs Milestone 22198 Realigning the Discussions Settings page Administration 3.4.2 normal normal Awaiting Review enhancement new 2012-10-15T14:50:34Z 2013-01-22T03:01:36Z "[I looked for some tikets for this but didn't find any directly related, so hopefully I haven't missed a big one out there floating around.]
The Discussions Settings page (options-discussion.php) always trips me up when setting up a new site. There's a lot of options, descriptions, directions, etc on that page — much of which is probably unavoidable. When I visit it, I always think that the hierarchy isn't quite right.
To help with this, I thought of two half-measures.
1. A very simple solution:
Put the ""Allow people to post comments on new posts"" at the top of the options list, with a little space below it. That would make that option the most prominent on the page, without making it stand out too much.
Like this:
[[Image(http://f.cl.ly/items/3e0c062W0N1l3J2D0q0Y/Screen%20shot%202012-10-15%20at%2011.56.02%20AM.png)]]
2. A more involved solution:
I really like the new click-to-reveal-the-options at work in the ""Page on Front"" (#16379) workflow and thought it might work well here.
*Something* in this direction:
[[Image(http://f.cl.ly/items/022A1G3k0O3q0g1u380L/Screen%20shot%202012-10-15%20at%2012.12.09%20PM.png)]]
The first could be accomplished for 3.5, but the second re-working could be a further down the line item.
" saltcod
Needs Milestone 21770 Multiple New Feature Pop-ups mess UI Administration 3.4.1 normal normal Awaiting Review defect (bug) new dev-feedback 2012-09-02T11:09:51Z 2013-01-22T03:06:39Z "WordPress admin and plugins [[Image(http://dl.dropbox.com/u/184353/wordpress-admin-pop-ups.png)]] New Feature Pop-up messages appear on the admin simultaneously, blocking each other messages and functionality. The UI gets seriously messed up.
User attention focuses on how to get rid the overlaping pop-ups rather than reading the messages and understand and start using the new features." titanas
Needs Milestone 22119 Rename 'QuickPress' to 'Quick Post' or something similar. Text Changes normal normal Awaiting Review enhancement new has-patch 2012-10-07T04:11:02Z 2013-01-22T03:21:21Z I think 'QuickPress' should be renamed to 'Quick Post' to be a little more user friendly. As it stands, Quick press gives no indication whether it will be a post or page, or what QuickPress even does. I think renaming it Quick Press gives more direction, and is a little easier to understand. bradparbs
Needs Milestone 21665 "Allow non-editable pages to be classified & organized as ""System Pages""" Administration normal normal Awaiting Review feature request new dev-feedback 2012-08-23T01:08:34Z 2013-01-22T03:21:44Z "We currently have no means of distinguishing regular “content” pages (pages that users can edit) and pages that are used as placeholders for custom templates / dynamic content.
As alexking mentions in #17470, users are often confused when they attempt to edit these ""placeholder"" or ""dummy"" pages only to find that the pages appear empty from within the page editor.
While his ticket concerned the ""page_for_posts"" page specifically, this issue is equally relevant to custom page templates that do not make use of user-generated content via the page editor.
isaackeyet proposed a solution [http://core.trac.wordpress.org/ticket/17470#comment:4 in that ticket] which introduces the idea of classifying such pages as ""System Pages"", which would offer a more limited set of options for how they can be changed:
>Idea to solve this permanently as brought up in the UI chat July 10 2012:
>
>* Pages have a new, hidden meta field to indicate ""System Page"" or >something that better describes it. Pages are marked System Page when >WP is using it as a placeholder for a custom blog set up, or a plugin >can use it to indicate a page is used for a contact form (for >example).
>* Pages are highlighted with a meta description in the pages list, >indicating why it's there (created by? reason?)
>* Most importantly, these System Pages are grouped in the pages >filter to be excluded from the regular list, so the list may read >""All | Published | System Pages"", which should be a better long term >solution for this ticket specifically (user confusion).
" bootsz
Needs Milestone 20956 Navigation changes: Posts/Pages Administration 3.4 normal normal Awaiting Review enhancement new has-patch 2012-06-14T14:42:25Z 2013-01-22T03:30:06Z "1. Explaining the difference between Posts and Pages to new users is time consuming and often frustrating. We've all done it, have our best/fastest version of the talk down pat, but it still takes longer than it should to get many new users to the point of understanding the difference.
2. Back in 2.7, when we set up the left navigation we put Pages at the bottom of the content nav section because in testing 2.5/2.6 so many people complained about accidentally clicking Posts/Pages by accident because they were close together in the old UI and both started with P (blame it on capital_p). Because of this, Pages falls below the less-frequently accessed areas of Media and Links, and people don't necessarily see it right away because they expect it to be higher up.
I've been testing out two changes to the left navigation aimed at reducing these two issues on my test blog for some time now, and have been using it during demos with both new and existing users to great success, so I think it's time to propose it for core.
Change 1: Change the Posts label to Blog. All Posts can remain as is, or could be reduced to just Posts, since the reason we added the All in the first place was that Matt thought it looked weird to have the same word shown twice.
This change reduces the amount of time it takes me to get a new user really understanding the difference between posts and pages by about 75% (very informal testing, have kept track with about 30 new users by just keeping an eye on the computer clock to see how long it is before we move on). The dynamic blog/static site difference is much easier to grasp when they see that familiar word Blog instead of Posts because ""posting"" is an action that applies even to static content, and even posts are displayed in web pages (vs Pages).
Change 2: move Pages up the menu to sit below Blog, so the two most important content types are at the top. Since they wouldn't look similar (ha ha capital_p) there would be much less risk of accidental misclick based on letter shape (poor manual dexterity would not be affected, but in that case those people are already clicking the wrong things, right?)
I've attached a screenshot showing what the navigation would look like with these changes. " jane
Needs Milestone 20288 "Missing bottom border for bulk-actions checkbox th in wp-posts-list-table if current user can't ""edit_post""." Administration 3.3.1 normal normal Awaiting Review enhancement new reporter-feedback 2012-03-23T10:04:20Z 2013-01-22T03:36:59Z "If current user can't ""edit_post"" the bulk-actions checkbox isn't present but also the bottom border for th in wp-posts-list-table.
I think it can be fixed by modifying line 495 in class-wp-posts-list-table.php like so:
`<th scope=""row"" class=""check-column""><?php if ( $can_edit_post ) { ?><input type=""checkbox"" name=""post[]"" value=""<?php the_ID(); ?>"" /><?php } else { ?> <?php } ?></th>`" szaqal21
Needs Milestone 23261 Add include to orderby options for get_terms() Taxonomy normal normal Awaiting Review enhancement new has-patch 2013-01-22T05:10:43Z 2013-01-22T05:10:43Z "In light of WordPress 3.5 allowing WP_Query to orderby `post__in` (#21776, #13729), it would be awesome to have the same functionality for `get_terms()` and the `include` argument.
Likewise (#13729), term queries can specify the posts to retrieve by passing an array of term IDs to the `include` parameter. There is no built in method for sorting those posts by the order specified. " wpsmith
Needs Milestone 13416 media for install.css missing (patch) Administration 3.0 normal normal Awaiting Review defect (bug) new has-patch 2010-05-16T18:48:17Z 2013-01-22T07:40:13Z In /core-root/wp-includes/general_template.php the function wp_admin_css is missing the @media definition. See patch. F J Kaiser
Needs Milestone 21537 Email address sanitisation mangles valid email addresses General 3.4.1 normal normal Awaiting Review defect (bug) new dev-feedback 2012-08-10T11:24:50Z 2013-01-22T09:00:07Z "If you change your email address to one including an ampersand then we mangle the address with html entities.
For example:
* This - peter&paul@sitting.in.a.tree.com
* Becomes - peter&paul@sitting.in.a.tree.com
This is due to the call to {{{wp_filter_kses}}} on {{{pre_user_email'}}} in {{{default-filters.php}}}.
The was added in [5906] for #4546.
I'm not sure if we need kses filtering for emails - if we do which should probably revert this conversion of the & => & afterwards." westi
Needs Milestone 19711 Posts edit list window display no information about filtering Administration normal normal Awaiting Review enhancement new 2012-01-02T16:39:30Z 2013-01-22T15:09:32Z "The ""All Posts"" page lists the available posts.
It can filtered by authors or terms, for example by clicking on a category name or the author name next to a post.
The URL will change to apply the filtering, but there's no other visual indication of the filtering, nor a link to quickly disable filtering.
This can lead to confusion when users are accessing filtered lists directly or via links in other part of the dashboard.
" yoavf
Needs Milestone 19784 Plugin Information dialogue should list Contributors Plugins normal normal Awaiting Review enhancement new 2012-01-09T04:46:09Z 2013-01-22T15:19:24Z "Following from #19775 I noticed that the list of contributors to a plugin are not displayed on the plugin info dialogue.
It would be nice to display the contributors in the plugin dialogue somehow rather than just the primary author." dd32
Needs Milestone 20271 Un-marked up text in the Add Users admin section for multi-site Users 3.3.1 normal normal Awaiting Review defect (bug) new has-patch 2012-03-21T15:17:35Z 2013-01-22T15:21:36Z "When looking at the page for adding a new user on a multi-site setup, the top option is to add an existing user.
This text: ""Enter the email address or username of an existing user on this network to invite them to this site. That person will be sent an email asking them to confirm the invite.""
has no html markup around it. Immediately above it is an h3 tag. The text should have a <p> around it at the very least.
My goal here is actually hide the whole section with css for some roles, but I have no way to refer to it." topher1kenobe
Needs Milestone 23269 .maintenance location issue on symlinked install Upgrade/Install 3.5 normal normal Awaiting Review enhancement new 2013-01-22T21:57:11Z 2013-01-22T21:57:11Z "I've started to symlink some of our WordPress installs using a folder structure as follows:
.htaccess
index.php
wp -> /var/www/wordpress/WordPress-latest
wp-config.php
wp-content
The wp folder is a symlink to either the latest version of WordPress, trunk or a specific version and the WordPress core files are all read only by the web server (WordPress core file installs are taken care of by Chef)
I thought creating a .maintenance file in the root or the wp-content folder would trigger maintenance mode but it looks like the .maintenance file is only detected if it lives in the same folder as the WordPress core files ($wp_filesystem->abspath()) which is read only so it's never going to be created there.
Having a shared core codebase even if I did override the write only permissions and set a .maintenance file in the WordPress directory that would mean every single site using that codebase would go into maintenance mode. (which sometimes might be useful since wordpress-latest might need updating)
What about having WordPress look for the .maintenance file in the directory above similar to what we can do with the wp-config.php file? This would then mean with a symlinked install and shared codebase you could trigger .maintenance mode for a single install or all installs using the codebase.
Or relocating the .maintenance file into the wp-content folder. This is after all where most web servers usually have write permission and where created files are meant to go." WPsites
Needs Milestone 22139 Hooks for wp-login customization Administration 3.4 normal normal Awaiting Review enhancement new has-patch 2012-10-09T14:18:07Z 2013-01-22T22:18:57Z "I have an application that leverages wp-login.php as the login page (of course), however, the HTML on the wp-login.php doesn't have a way for my application to insert its navigational elements, branding, etc.
I propose the addition of two new action hooks: ''login_before_container'' and ''login_after_container'' which would come before and after the login div, respectively. " borkweb
Needs Milestone 21285 Don't ping yourself, especially on localhost Pings/Trackbacks 1.2 normal normal Awaiting Review defect (bug) new has-patch 2012-07-16T03:33:32Z 2013-01-22T22:53:19Z "This may just be a conversation starter, but I know these things to be true:
1) there is duplicated code spread between pingback( ) and do_enclose( )[[BR]]
2) If your post contains a bunch of links to your own site, and you save your post in the admin, you will ended up with memory leaks all over the place / seg faults / etc when you get hammered by HEAD requests triggered by the immediate cron that is spawned by the post being saved[[BR]]
3) you probably don't need to trackback yourself anyways
I moved some dupe code into functions and added some checks so we don't ping ourself when saving" wonderboymusic
Needs Milestone 23260 Enhancement for paginate_links(); to include in wordpress core Template 3.5 normal normal Awaiting Review enhancement new 2013-01-22T04:24:12Z 2013-01-24T00:45:02Z "Hello all,
I asked a question over at theme-reviewers [1] and one of the answers
(and a helpful one) was that any improvement/s that I find could be
push back into the core.
The first thing that I would like to see is a ""Page x of x"" and make
it a link to that people can click on it and enter the page munber
that they want to go to then they can go stright to that page.
Now I did find some code to do it but for some reasons I don't feel
that it the right way of doing it[2].
The next thing that I'm looking at is if we can have it so that we can
set our own style class or even replace tags altogether. Right now the
only way that I can do this (as far as I know) is by editing core code
or copy and paste code from care into my function.php file and rename
things.
I see that with the sidebar callback, I can set before and after tags
for title and other things and that to the theme author gives us alot
of control over layout and how we can style things.
The reasons why the above improvements should be included in core:
A: No need to create custom functions [[BR]]
B: Don't need to install extra plugin just to get the ""Page x of x""
function or to create a hacked paginate_links function. [[BR]]
C: It gives theme developers more control over style without alot of
extra coding and if they don't want something they can disable it
(example ""Page x of x"") [[BR]]
D: It means that if wordpress devs change the paginate_links function
theme authors don't need to update their custom functions [see A]
Regards,
Daniel Fenn
[1] http://lists.wordpress.org/pipermail/theme-reviewers/2013-January/011488.html [[BR]]
[2] http://design.sparklette.net/teaches/how-to-add-wordpress-pagination-without-a-plugin/" Danielx64
Needs Milestone 21082 The Gallery shortcode relies on #gallery-instance to hook the CSS, but the id sometimes isn't specific enough Gallery normal normal Awaiting Review defect (bug) new has-patch 2012-06-26T18:43:28Z 2013-01-24T09:14:02Z "The Gallery CSS selector uses the id attribute, which is of the form #gallery-{instance}. On some scenarios (like infinite scroll) a follow up gallery on a another post can have the same #gallery-x selector, thus over-writing the previous gallery style.
Proposed solution: make the #id more unique by including the postid number. (Attached patch.)
(It could potentially impact some themes that used #gallery-1 to style galleries, but theme's shouldn't be using that in the first place, I believe.)
Furthermore, it may be good to change the whole style block to use classes instead of the id so that it's easier for themes to deal with CSS specificity—and helps them not fall back to the #id." matveb
Needs Milestone 23278 Spin PressThis off into a plugin Press This 3.5 normal normal Awaiting Review enhancement new dev-feedback 2013-01-23T21:43:23Z 2013-01-24T12:25:15Z "PressThis has really been the ignored stepchild of WordPress for quite a while now. I'd like to propose that we spin it out of core and into a plugin (either installable via the plugin repo or bundled with wp, whatever)
Several things to consider:
* Backwards Compatability: What happens when someone upgrades then uses an old bookmarklet? I'd suggest either autoinstalling, or prompting them immediately to install the plugin through a special catch in core.
* Press This doesn't have an includes file in wp-admin/includes that other plugins could pull in, so extracting it is very unlikely to break plugins that could be manually pulling that in.
* This will make it easier to upgrade in plugin form, and let other people have an easier time hijacking it to use their own implementations.
In today's IRC chat, as sabreuse pointed out, everyone seemed to either favor spinning it out into a plugin, or didn't have much of an opinion. If you really want it in core, please speak up! I'd love to hear your reasons.
I'm willing to throw a massive chunk of time at this to make it work, if that's the decision that we decide to move forward with." georgestephanis
Needs Milestone 21551 Press This Structural Rewrite Press This 3.4.1 normal normal Awaiting Review enhancement new has-patch 2012-08-11T19:59:54Z 2013-01-24T12:25:37Z "This is a ticket to tidy up and abstract some of the Press This code into wp-admin/includes/press-this.php to make it simpler to work with and use functionality in plugins and such.
Once this structural change is done, I've got a couple enhancements coming down the pipes including reading OG/Twitter/Meta tags from the source page, simpler upgrades to the JS (jorbin's suggestion) better image pulling, etc.
This patch below, however, is merely structural, not adding in any new functionality, merely tidying up what we've got so far." georgestephanis
Needs Milestone 23287 Press This enhancement - enclose included content in a div to allow styling Press This 3.5 normal normal Awaiting Review enhancement new 2013-01-24T19:24:14Z 2013-01-24T19:24:14Z "The Press This functionality is effective and simple, but the content it drops into a blog post has no enclosing <div>, and as a result cannot be styled using the theme's CSS file to differentiate it from the blogger's comments.
I've posted on my own blog [http://aldred.org/blog/blog/2013/01/24/improving-press-this-in-wordpress/ this post] describing how I've made a fairly simple change to insert div tags round the quoted content.
Ideally the div would also wrap the image, but that was beyond me!
Can this be looked at as an enhancement?" daldred
Needs Milestone 23280 TinyMCE issue with table wrapped with shortcode TinyMCE 3.5 normal normal Awaiting Review defect (bug) new 2013-01-24T01:07:43Z 2013-01-25T03:02:55Z "TinyMCE will generate unbalanced <p> tags when a table is included as the content of a wrapping style shortcode. In this example, assume a shortcode called `[div] ... [/div]` that simply brackets the content with a `<div> ... </div>`.
This is an example as it would be in the editor's Text view (and it works if you switch back and forth to Visual.):
-----------------
{{{
There will be a table following.
[div]
<table>
<tbody>
<tr>
<td>Simple table</td>
</tr>
</tbody>
</table>
[/div]
Next line is here.
}}}
------------------------
The HTML output generated is this:
{{{
<p>There will be a table following.</p>
<div></p>
<table>
<tbody>
<tr>
<td>Simple table</td>
</tr>
</tbody>
</table>
<p></div>
<p>Next line is here.</p>
}}}
------------
The shortcode is very simple - just a demo. It returns simply:
{{{
return '<div>' . do_shortcode($text) . '</div>';
}}}
Doesn't seem to matter with or without the do_shortcode() call.
--------
So note the excess </p> after the added starting <div>, and the extra <p> before the </div> from the shortcode. Seems to happen only with a wrapping style shortcode, and I think only with tables.
" wpweaver
Needs Milestone 23285 Implement an AMD JavaScript loader in WordPress General normal normal Awaiting Review feature request new 2013-01-24T14:28:47Z 2013-01-25T07:04:55Z "AMD = Asynchronous Module Definition
See comment: http://core.trac.wordpress.org/ticket/22896#comment:29
I think this is a must for the future viability of WordPress and plugins written for it.
Multiple versions of JavaScript libraries are a fact of life and we have to deal with it somehow.
If WordPress provides the framework for the use of multiple versions of JavaScript libraries then a lot of the problems we see with WordPress now will be a thing of the past.
This represents a major re-think of the current WordPress JavaScript loading paradigm, but I think it is necessary and would be well worth it.
I'm not a terribly advanced developer, and there might be better solutions out there or others to come, but for now, I think this is the way to go.
Example:
http://requirejs.org/docs/why.html
http://requirejs.org/docs/whyamd.html
https://github.com/amdjs/amdjs-api/wiki/AMD
It does not have to be RequireJS, but it seems the most mature and popular of the implementations.
From the unminified jQuery source:
{{{
// Expose jQuery as an AMD module, but only for AMD loaders that
// understand the issues with loading multiple versions of jQuery
// in a page that all might call define(). The loader will indicate
// they have special allowances for multiple jQuery versions by
// specifying define.amd.jQuery = true. Register as a named module,
// since jQuery can be concatenated with other files that may use define,
// but not use a proper concatenation script that understands anonymous
// AMD modules. A named AMD is safest and most robust way to register.
// Lowercase jquery is used because AMD module names are derived from
// file names, and jQuery is normally delivered in a lowercase file name.
// Do this after creating the global so that if an AMD module wants to call
// noConflict to hide this version of jQuery, it will work.
if ( typeof define === ""function"" && define.amd && define.amd.jQuery ) {
define( ""jquery"", [], function () { return jQuery; } );
}
}}}
Note: '''multiple versions of jQuery'''" auniquename
Needs Milestone 23292 Media uploader loads full size image and slows down, please change to thumbnails. Media 3.5 normal normal Awaiting Review defect (bug) new has-patch 2013-01-25T09:31:11Z 2013-01-25T12:31:37Z "The media uploader is really slow if you upload 1024 x 768 images, the reason for this is that the preview shows full size images.
Underneath here is a quick fix to speed up the media uploader to thumbnails.
Please change line 1333 in ""wp-includes/media.php"" from:
{{{
$attachment_url = wp_get_attachment_url( $attachment->ID );
}}}
to:
{{{
$attachment_url = wp_get_attachment_thumb_url($attachment->ID );
}}}" mnrtjeR
Needs Milestone 23279 Add templates to style registration, signup, activation, login and password reset pages Themes normal normal Awaiting Review enhancement new 2013-01-23T22:20:58Z 2013-01-25T15:29:55Z "As [https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2013-01-23&sort=asc#m539267 discussed in IRC], the ability to override the various user-related pages would be a great ability for themes to have. At the moment, it's pretty tedious to style these and there's very little control over the content of the page (some for good reason, others not so much).
Related: #1155, #3123, #22139" rmccue
Needs Milestone 23096 Provide callback before setting state of the editor media manager Media 3.5 normal normal Awaiting Review enhancement new dev-feedback 2012-12-31T18:33:52Z 2013-01-25T16:54:03Z "In the current setup, there is no way to modify the current state or views when the media manager is opened from the ""Add Media"" button. By the time you can modify anything, all the default views have been rendered and all of the events have been fired.
It would be helpful to check for the existence of a callback, and if it exists, run that before returning the workflow.
My patch does this, which you could invoke in this way:
{{{
wp.media.editor.extend = function(workflow){
// Manipulate the workflow here
}
}}}
Thoughts? This is only for the default media manager that is invoked by clicking the Add Media button." griffinjt
Needs Milestone 23230 "Change hyphen in front of ""Draft"" to em dash" Administration 3.5 normal normal Awaiting Review enhancement new 2013-01-18T09:08:47Z 2013-01-25T20:08:00Z "When a post/page/etc. is saved as a draft there is a ""- Draft"" appended after the title in the overview list in the dashboard.
Rather than using an hyphen (-) it should be an em dash (—) and ideally it should be translatable as the typographic rules for dashes varies with languages.
Rather than ""- Draft"" it should say ""— Draft""" kkalvaa
Needs Milestone 23296 3.6 - Edit Post, Invalid implode after Core-Update Warnings/Notices normal normal Awaiting Review defect (bug) new reporter-feedback 2013-01-25T23:48:51Z 2013-01-26T11:51:16Z "'''Error:''' implode(): Invalid arguments passed
The implode function have invalid Arguments.
'''URL:''' /wp-admin/edit.php
[[BR]]'''HTTP referrer:''' http://adrean-test.eatserver.nl/wp-admin/update-core.php
'''FIX (wp-includes/compat.php - Line 32):'''
{{{
return ($chars ? implode( '', $chars ) : array());
}}}
'''Stacktrace:'''
{{{
in implode called at /www/htdocs-test/wp-includes/compat.php (32)
in _mb_substr called at /www/htdocs-test/wp-includes/compat.php (18)
in mb_substr called at /www/htdocs-test/wp-includes/formatting.php (3096)
in wp_html_excerpt called at /www/htdocs-test/wp-includes/admin-bar.php (230)
in wp_admin_bar_site_menu called at ? (?)
in call_user_func_array called at /www/htdocs-test/wp-includes/plugin.php (487)
in do_action_ref_array called at /www/htdocs-test/wp-includes/admin-bar.php (58)
in wp_admin_bar_render called at ? (?)
in call_user_func_array called at /www/htdocs-test/wp-includes/plugin.php (406)
in do_action called at /www/htdocs-test/wp-admin/admin-header.php (113)
in require_once called at /www/htdocs-test/wp-admin/edit.php (220)
}}}" hovida
Needs Milestone 22200 Require users to set a site title Administration normal normal Awaiting Review defect (bug) new has-patch 2012-10-15T18:52:14Z 2013-01-26T20:43:26Z "Currently, users can get away with setting a blank site title under Settings -> General.
As a consequence, meta and title tags in both the front-end site and wp-admin may be empty, or contain extraneous spaces and separators.
A common reason why users leave site titles blank is due to the misperception that the site title is necessarily displayed in the header on the front-end site.
I suggest that we display an alert when users attempt to set a blank site title, and possibly suggest that if they don't want it to appear in their header, they can edit their CSS or hide header text under Appearance -> Header." chrisrudzki
Needs Milestone 23281 Enhancement for comment_form(); allow styling the submit button Template 3.5 normal normal Awaiting Review enhancement new has-patch 2013-01-24T01:08:14Z 2013-01-26T23:43:17Z "Hi there,
I'm looking at adding a feature where we can define the class for the submit button. I'm happy to create a patch for this if required. The reason for this is because right now we can change say the email field so much but we get little to no concrol over the submit button.
I'm looking at
A: Convert the entire submit button into somehing like how the text areas are done (author and email) then we get full control over the styling and other things related or;
B Add something like class_submit so that we can set the style of the submit button.
Kind regards,
Daniel Fenn" Danielx64
Needs Milestone 23302 Feeds or Feed - add_permastruct missunderstanding. Post Types 3.5.1 normal normal Awaiting Review defect (bug) new has-patch 2013-01-27T16:00:59Z 2013-01-27T16:19:00Z "In case of register_post_type you ""can"" specify to add feeds to permalink structure or not. You actualy [http://codex.wordpress.org/Function_Reference/register_post_type can do that] by specifing a 'feeds' element to '''false''' in rewrite array.
But add_permastruct doesn't accept feeds element of rewrite argument. Its accept 'feed' element which default is true. So in this case its not posible to disable feeds for any post type via register_post_type API." butuzov
Needs Milestone 23308 "make_clickable problem with multiple ""Punctuation URL character""" Formatting 3.5.1 normal normal Awaiting Review defect (bug) new 2013-01-28T15:09:59Z 2013-01-28T15:09:59Z "make_clickable problem with multiple ""Punctuation URL character""
E.g.
{{{
http://www.wordpress.org/some-(parentheses).html
}}}
Results in this html code:
{{{
<a href=""http://www.wordpress.org/some-(parentheses)"" rel=""nofollow"">http://www.wordpress.org/some-(parentheses)</a>.html
}}}
But obvious should be:
{{{
<a href=""http://www.wordpress.org/some-(parentheses)"" rel=""nofollow"">http://www.wordpress.org/some-(parentheses).html</a>
}}}
I suggest to replace:
wp-includes/formatting.php:1603
{{{
[\'.,;:!?)] # Punctuation URL character
}}}
with
{{{
[\'.,;:!?)]{1,} # Punctuation URL character
}}}" DrPepper75
Needs Milestone 23309 Not all WP_Query::query_vars get updated during WP_Query::get_posts() Query normal normal Awaiting Review defect (bug) new 2013-01-28T15:40:56Z 2013-01-28T19:51:54Z "There is a lot of logic within the WP_Query::get_posts() method that fills in missing query vars with defaults and manipulates others based on the rest of the query. However, some of the final states for many of the variables aren't updated in the WP_Query::query_vars array. For example, the post type is lost as a local variable and post_status is used for building compiling mysql expressions, but never directly updated.
The result is that any plugins that want to recreate the query for another system, (ie, an external search provider) must directly copy much of the business logic that WP_Query::get_posts() has embedded in it in order to fill in for the incomplete query_var array.
" prettyboymp
Needs Milestone 21329 Consolidate filters and functions in wp-admin/includes/media.php Media normal normal Awaiting Review enhancement new close 2012-07-20T20:28:59Z 2013-01-28T23:50:11Z in wp-admin/media.php, there are several functions that do similar things and could be combined, simplifying how they get used. martythornley
Needs Milestone 22970 No Set Featured Image Option in existing Media Gallery Media 3.5 normal normal Awaiting Review enhancement new 2012-12-17T05:57:12Z 2013-01-29T02:24:00Z "There is a Set Featured Image link when you add new gallery but in already existing gallery, you can't set Featured Image (in case you want to add more photos and set a new featured image). You have to do it from Set Featured Image link on the post which means more clicks.
Plus, I wanted to add, wouldn't it be easier if we have Set Featured Image link on the right side where all image meta exists, instead of having to click on a separate link on the left? Similar to what we had with 3.4. That would really lessen the number of clicks you have to do to set a featured image. You could do the same with existing galleries/posts too. For example, if you upload one image, its selected by default and on the right side, you can just click a Set Featured Image link." nhuja
Needs Milestone 17379 Filtered exports drop attachments and featured images Export 3.0 normal normal Awaiting Review feature request new has-patch 2011-05-11T18:37:31Z 2013-01-29T06:46:59Z "When using Tools>Export, targeting a specific author, the resulting XML file does not contain a reference/link to any Featured Image (thumbnail) associated with these posts.
On the other hand, Tools>Export ""all content"" (including all authors) produces an XML file that does contain reference/link to Featured Image.
Request: Have Tools>Export ""specific author"" generate the same metadata as the ""all content"" export, so that Export ""specific author"" will also include metadata reference to the Featured Image.
Many people (including myself) use ""specific author"" as a way to export some, but not all, posts. Full metadata would really help. Thanks." billseymour
Needs Milestone 21644 Should contributors be allowed to edit their posts once scheduled? General 3.4.1 normal normal Awaiting Review feature request new 2012-08-20T21:36:55Z 2013-01-29T19:42:14Z "
This may not be a ""bug"" per-se,but seems to have a lot of negative consequences so I'll give it a shot.
According to the rules: A contributor can edit their own Posts - irrespective of who scheduled it.
http://codex.wordpress.org/Roles_and_Capabilities#Contributor
This creates problems for large publications where there is an editor who makes changes to posts and then schedules them, sometimes a couple days in advance.
As it stands now, a contributor can still log in after that process is done which means unexpected changes and shenanigans might take place.
Wouldn't it make more sense for a contributor to lose editing privileges as soon as something is no longer in draft modea?
Just my two cents.
" nickaster
Needs Milestone 23083 Tag balancing for text widgets Widgets normal normal Awaiting Review enhancement new has-patch 2012-12-30T09:11:18Z 2013-01-29T20:58:48Z "Based on inspecting the code it looks like tag balancing is not applied to th content of the text widget.
IMO people are more likely to produce broken HTML when adding HTML in a text widget then when writing post, but tag balancing is done only for posts and comments (in which HTML is rarely used)." mark-k
Needs Milestone 23091 Need to remove deprecated get_bloginfo('url') from _fix_attachment_links() function Administration 3.5 normal normal Awaiting Review enhancement new close 2012-12-31T01:57:33Z 2013-01-29T21:51:19Z "get_bloginfo('url'); is deprecated.
Should be home_url();" hexalys
Needs Milestone 23323 img quicktag is so inferior to add media, should be merged or removed Editor 3.5 normal normal Awaiting Review enhancement new close 2013-01-30T09:55:50Z 2013-01-30T20:16:31Z "Right now, in the text editor there are two ways to add an image, with the ""img"" button or the ""add media"" button. ""Add media"" contains all the functionality of ""img"" and adds much more, while ""img"" is ugly and feels like an historical artifact.
IMO ""img"" should be deleted or be an alias to ""add media""" mark-k
Needs Milestone 22230 WP adds <br /> before <select even where there is no line break in source code Formatting 3.4.2 normal normal Awaiting Review defect (bug) new 2012-10-19T21:49:26Z 2013-01-31T11:24:25Z "My source code in the WP HTML editor:
{{{
<label for=""sellby"">How soon do you need to sell?</label><select id=""sellby"" name=""sellby"" required=""1"">
}}}
Note how there is *no line break* between </label> and <select
HTML generated by WP, however:
{{{
<label for=""sellby"">How soon do you need to sell?</label><br />
<select id=""sellby"" name=""sellby"" required=""1"">
}}}
Um, how (and why?) did that extra <br /> get in there?
This also happened when I was using the Visual editor; switched to the HTML editor to see if it was an error on my part but nope - there is no line break whatsoever in my HTML source code, so I have no idea why WP insists on adding one.
It's particularly vexing because I would like my text label to be next to (on the same line as) my select boxes, but WP is forcing it to be on the next line, which is making my form look awful.
AFAIK it's only happening with select boxes, but it's pretty consistent for me.
Since it's happening with the HTML editor as well as the Visual editor I left the Component as General so better minds than mine can categorize it appropriately." chirael
Needs Milestone 22938 Presentation of hierarchical taxonomy in Media modal should be checkboxes rather than comma-separated tag list Media normal normal Awaiting Review enhancement new 2012-12-14T14:10:16Z 2013-01-31T18:24:24Z Since 3.5, using register_taxonomy_for_object_type on attachments, if the taxonomy used is hierarchical, whereas in the edit attachment UI you see the normal list of checkboxes, in the corresponding modal it is presented as a comma-separated list of slugs, as if it were a non-hierarchical taxonomy (tags rather than categories). I'm sure this is not a bug / mistake / oversight, but at best it's a little unintuitive (you need to have memorised the category slugs to add new ones) and worst a bit dangerous (risk of adding unwanted categories), and it would be great if in future it was presented here too as a list of checkboxes. yeswework
Needs Milestone 23349 Be able to suppress registration redirect for multisite in wp-login.php Multisite 3.5.1 normal normal Awaiting Review enhancement new 2013-02-01T01:29:35Z 2013-02-01T02:06:55Z "Currently I commented out the following lines in wp-login.php. But I should be able to use a filter. Maybe test the result 'wp_signup_location' filter if false do not exit. Easy, and seems to annoy many people.
{{{
case 'register' :
/* AJB Comment out
if ( is_multisite() ) {
// Multisite uses wp-signup.php
wp_redirect( apply_filters( 'wp_signup_location', network_site_url('wp-signup.php') ) );
exit;
}
*/
}}}" aberglas
Needs Milestone 22305 Credits Page Should Include more than 'just' people who commit a patch Help/About normal normal Awaiting Review enhancement new 2012-10-29T16:28:32Z 2013-02-01T02:09:12Z "If you want to find how contributes to core, it's easy, but everyone else is unlisted.
Right now, unless the person who commits a patch remembers to 'props', the person who submits a ticket, or leads to a great discussion that drives the code to a solution in the comments, are never mentioned. This drives a wedge between coders and non-coders, as some people can help but they just may not be super coders.
Proposals:
1) When pulling a list of 'everyone who helped' for the credits page, also pull a list of all IDs who commented in the tickets that were commited and list as 'Also Contributed...'
2) In 'Recent Rockstars' (which is a manually culled list anyway), pull in the active awesome people in support, documentation, codex, manuals, training, and WordCamps (for example). Include people in UI who contribute screenshots/design/wireframes that drive changes.
People who contributed to this ticket:
* ryanimel
* saracannon
* brandondove
* theandystratton
* tomwillmot
* SiobhanP (aka raggedrobins)
* ryan duff
* Lisa Sabin-Wilson
* js_zao
* vegageek
* andrea_r
* ipstenu
If I got your logins wrong, sorry." Ipstenu
Needs Milestone 4137 Pingback Denial of Service possibility Security 1.5 low normal Awaiting Review defect (bug) reviewing 2007-04-11T19:41:51Z 2013-02-01T02:37:17Z "The pingback feature of Wordpress (2.1.3) allows DDOS attacks either against the server hosting wordpress or against a third one.
When a client sends a pingback, wordpress calls ""wp_remote_fopen"" to download the referring URL. On servers having ""allow_url_fopen"" activated, this function will try to download the /whole/ URL without any timeout or size limit. (except those set in php.ini, which will usually lead to a ~8MB download)
So if you post ~100 xmlrpc requests referring to a /huge/ file, every server meeting those prerequisites should effectively be down (for a while). You should at least be able to generate lots of traffic.
On the other hand, if you google for blogs and post the same URL to each of 'em, the target server should be DDOSed.
I suggest allowing pingbacks only if the connection was opened from the host mentioned in the source URL.
I'll attach a demo exploit (I didn't test it for the entered URL; it worked for a local installation.)" foobarwp12
Needs Milestone 23350 Pingback Denial of Service Fix - filter_var based IP validation Pings/Trackbacks 3.5.1 normal normal Awaiting Review defect (bug) new has-patch 2013-02-01T02:24:57Z 2013-02-01T02:44:04Z "Just a small improvement upon review of [23330] (some points were not clear to me, especially colons in hostnames and trimming of the hostnames for dots; left them as-is).
Also used {{{strcasecmp}}}.
BTW, what about #4137, can it be closed now?
" hakre
Needs Milestone 23343 tinymce supports sevaral spellchecker but there is no option to configure it in wordpress TinyMCE normal normal Awaiting Review enhancement new close 2013-01-31T14:15:25Z 2013-02-01T11:38:45Z "tinymce configuration is in wp-includes\js\tinymce\plugins\spellchecker\config.php, at seems to support pspell, pspellshell, google spellchecker and rpc.
Will be nice if it will be possible to configure it. A use case is create a network installation for a company which want to have its own vocabulary shared among all its writers." mark-k
Needs Milestone 23355 "There should be away to select ""no color""/""theme color"" at the editor's text color selection" TinyMCE normal normal Awaiting Review enhancement new 2013-02-01T08:42:51Z 2013-02-01T11:38:48Z "If I changed the color of a selected text the only way to revert the change is by using the ""delete styling"" button which is totally not obvious" mark-k
Needs Milestone 23358 Switch to a usermeta key for email confirmation in Multisite Multisite 3.0 normal normal Awaiting Review enhancement new 2013-02-01T13:54:05Z 2013-02-01T13:54:53Z "Background: #23146
In `send_confirmation_on_profile_email()`, an option is used to store the new email: [[BR]]
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/includes/ms.php#L238
A usermeta key should be used instead." SergeyBiryukov
Needs Milestone 23356 Editor's text color button indicated different text color then the one use in several cases TinyMCE 3.4 normal normal Awaiting Review defect (bug) new 2013-02-01T08:50:53Z 2013-02-01T15:12:22Z "1. Select a text color - the underline in the button will be displayed in that color
2. write some text with this color
3. start a new paragraph
4. button color remain the same but the text is in the theme's default color
Same when moving to different section of the document, the button do not pick the right color used in the text and stays in its last setting." mark-k
Needs Milestone 23339 DFW in HTML mode should have switch text direction button for RTL languages Editor normal normal Awaiting Review enhancement new 2013-01-31T12:22:55Z 2013-02-01T19:14:02Z It is hard to edit HTML when the flow of the text is right to left. The normal HTML editor has this button when used in RTL environment. mark-k
Needs Milestone 23361 "Deleting a user in Network Admin still defaults to ""Delete all posts""" Network Admin 3.5 normal normal Awaiting Review defect (bug) new 2013-02-01T19:02:55Z 2013-02-01T19:21:46Z "Background: #20045, #23224
We should either do what those tickets suggested in Network Admin as well for consistency, or redo/remove the form, since the attribution only works for the main site, as noted in [comment:ticket:20045:14]." SergeyBiryukov
Needs Milestone 23172 "Media Library - Rename the default ""Images"" in dropdown to something more clear" Media 3.5 normal normal Awaiting Review enhancement new has-patch 2013-01-10T17:05:32Z 2013-02-01T21:40:13Z "I have a group of about 6 people on my team and after the upgrade to 3.5 not one of them could figure out how to filter down to only the images attached to a post. I'm assuming that other people out there are having similar trouble..
The label ""Images"" makes it seem like that is where you could switch to other media types like ""Audio"" instead of filtering search results. I think ""All Images"" would be much more clear as to what the dropdown changes.." jacopo.vip
Needs Milestone 23364 Unstable sorting with jQuery UI 1.9.1 and above External Libraries 3.5 normal normal Awaiting Review defect (bug) new dev-feedback 2013-02-02T03:07:18Z 2013-02-02T03:09:35Z "There seems to be an issue with jQuery UI (sortable) 1.9.1 and above that affects (rather severely) sorting of elements inside sortable source and target containers. I haven't seen this affect core, but since WP has been shipping with one of the affected versions (1.9.2) since 3.5, I'm worried about potential repercussions on WP theemes, plugins or projects relying on this script. For instance, Ultimate Tinymce, by Josh Lobe and myself (recently), has been affected by this.[[BR]]
[http://elblawg.com/jqueryui-test/ Here] is a testing platform I created on my server about the problem. Choosing any version of UI newer than 1.9.0 will result in said behavior.[[BR]]
[http://bugs.jqueryui.com/ticket/9041 Here] is the ticket I submitted to jquery UI Trac and [https://github.com/MarventusWP/jquery-ui/commits/master here] the Commits to their github project.[[BR]]
Finally, as recommended by Andrew Nacin on the wp-forums list, [http://jsfiddle.net/Marventus/THwqS/1/ here] is a JSFiddle that reproduces the problem.[[BR]]
I am not really sure what to do about this, but I thought I should leave it on record just in case.
Thanks!" Marventus
Needs Milestone 23363 When uploading batches of photos oversized photos fail silently Upload 3.5.1 normal normal Awaiting Review defect (bug) new 2013-02-02T01:52:42Z 2013-02-02T03:28:47Z "Summary:
When uploading a batch of photos as part of a gallery, some of which are larger than the maximum allowable, the photos under the maximum size upload successfully while the photos that are too large fail silently.
Steps to Reproduce:
1. On a post or page, click ""Add Media"" button
2. Click ""Create Gallery"" and ""Upload Files""
3. Click ""Select Files"" and select several files, some of which are larger than the maximum allowable file size, and some which are smaller
4. Press select
Expected Results:
Either no files upload (as some are to large to upload) or the files small enough to upload upload successfully (as is the current case) ''and'' an error is displayed stating which photos cannot be uploaded and why.
Actual Results:
Only the photos that are small enough to be uploaded upload successfully while the photos that are too large fail to upload with no explanation, before, during, or after the upload process.
Browser:
Safari 6.0.2 on Mac OS" davidwillmore
Needs Milestone 22869 Large Image Uploads Don't Error Well Media 3.4 normal normal Awaiting Review defect (bug) new 2012-12-12T05:10:10Z 2013-02-02T03:29:06Z "Related to #22849 but not restricted to the new uploader. Happens on 3.4 and 3.5 in different ways.
To Reproduce: Upload https://objects.dreamhost.com/ipstenu-images/sunset_2_22_11_by_kenshinkyo-d3a6slk.jpeg to your WP install in the media-new.php page
Note: Image is 12600x9450 and 4.9MB
Expected Outcomes:
* Shared hosted without a lot of memory: Failure, not enough memory, no image uploaded.
* VPS/Dedicated with tons of memory: Success
Actual outcomes:
* VPS as expected.
* Shared not so much. You get the errors as expected however the failure is not correct. The image actually does upload, contrary to the errors, however no thumbnails are made, which then causes a memory problem as the full size image shows when you go to any media library view (in lieu of actual thumbnails). This crashed Chrome (as @markjaquith saw when we were testing Monday night) until I deleted the large images.
The actual issue is on thumbnail creation, so the best 'fix' I can think of is if on failed thumbnail gen, it nukes the master image, but I don't know if that would make sense since some of the thumbnail gen might be on extra image sizes set by themes/plugins. Then again, do you want those if all fail? " Ipstenu
Needs Milestone 23127 Media Upload hangs on Crunching on too big image sizes. Media 3.5 normal normal Awaiting Review defect (bug) new 2013-01-05T22:56:14Z 2013-02-02T03:29:32Z "If the uploaded file is too big for the Max Memory Limit Setting, then the upload is executed, but the image isn't resized to the set image sizes and the frontend gets stuck on ""Crunching"". I tracked the error down into the core and found out, that the main problem is in the GD library class ( wp-includes/class-wp-image-editor-gd.php ) in the load() function.
Everything works fine before line 91:
{{{
$this->image = @imagecreatefromstring( file_get_contents( $this->file ) );
}}}
So imagecreatefromstring fails because of a lack of memory. But as a chain reaction everything else fails afterwards. The library is not loaded and sent back, and so on. As a result no id is sent back to the frontend and the Loader hangs.
Maybe there should be any error catching and sending back before this GD function, that the frontend receives any error messages and that the upload is deleted in case of error.
Just my thoughts: As this error is a Fatal one, you can`t use any Exception stuff, cause there will not be any memory left to execute it. Maybe some checking if the id is present before sending the image back to crunching?" clubdesign
Needs Milestone 22040 wp_dashboard_recent_comments queries do not skip comment_approved=spam Performance normal normal Awaiting Review defect (bug) new 2012-09-28T17:56:47Z 2013-02-02T05:42:22Z "There is am oversight in `wp_dashboard_recent_comments` which can cause a large delay in the admin area for large sites that may have a lot of spam (ie. set by akismet)
Ironically the function contains the documentation
""Select all comment types and filter out spam later for better query performance.""
This is not the case, in fact it's the opposite. Filtering out the spam later via php and wp filters is far far slower since there is (now) an index on `comment_approved`.
As it is, it causes dozens of extra queries while it loops through all the comments 50 at a time in mysql when they contain a great deal of spam, and then via php filters the spam out (even for admin).
Since there IS an index on `comment_approved` that can be used, to fix this you should only show `WHERE comment_approved='approved'` OR `comment_approved='moderated'` Or do the reverse with `comment_approved!='spam'`
Since WP 3.5 has switched to a query class for comments, it should in theory be easy to add the additional WHERE condition for comment_approved." _ck_
Needs Milestone 23045 WP_User_Query features Users normal normal Awaiting Review feature request new 2012-12-22T06:14:45Z 2013-02-02T11:20:46Z WP_User_Query does not updated recently and due to more use of wordpress as CMS needs of custom query per users increased, WP_User_Query lack post type support(i add a ticket for it #21744) lack taxonomy/multiple taxonomies query and alot others, maybe its time to update WP_User_Query like WP_Query. it's really a need for common works these days. AliMH
Needs Milestone 23369 WP_Comment_Query meta query 'count' conflicts with 'group by' Comments 3.5.1 normal normal Awaiting Review defect (bug) new 2013-02-02T13:39:20Z 2013-02-02T14:52:54Z "This problem relates to {{{/wp-includes/comment.php}}}, both 3.5.1 and trunk are affected. The following line number refers to the 3.5.1 version.
At line 195, definition of class {{{WP_Comment_Query}}} , a typical meta query will generate such SQL:
{{{SELECT * FROM wp_comments INNER JOIN wp_commentmeta ON (wp_comments.comment_ID = wp_commentmeta.comment_id) WHERE ( comment_approved = '0' OR comment_approved = '1' ) AND comment_post_ID = 22 AND ( (wp_commentmeta.meta_key = 'my_flag' AND CAST(wp_commentmeta.meta_value AS CHAR) = 'my_value') ) GROUP BY wp_comments.comment_ID ORDER BY comment_date_gmt DESC }}}
Note that at line 357, a meta query will always generate a {{{GROUP BY}}} clause. This works for comment rows. Say that I've got 3 comments matching this query, I'll see each of them in a row:
{{{
comment row 1, data
comment row 2, data
comment row 3, data
}}}
However, this query doesn't work well then {{{$count = true}}}. Note that by specifying {{{$count = true}}}, the function only changes {{{'SELECT *'}}} into {{{'SELECT COUNT(*)'}}}. For 3 comment result, I'm seeing something like this:
{{{
1
1
1
}}}
And you can see, because there's a {{{'GROUP BY'}}} clause. And each comment has a unique ID. The result is 3 'grouped row' of comments, and each will always have count of 1.
Therefore, the result of {{{$wpdb->get_var()}}} will be either 1, or NULL (when nothing is matched). I believe this behavior is not by intention.
To get count working, {{{'GROUP BY'}}} clause must be removed when $count is true." heshiming
Needs Milestone 23368 Random order for wp_user_query Users 3.5 normal normal Awaiting Review enhancement new dev-feedback 2013-02-02T09:24:40Z 2013-02-02T15:42:14Z "Unlike the '''wp_query''', '''wp_user_query misses''' the order by random option.
This option is necessary when you have a lot of users and we want to show only some of them randomly in a widget or anywhere on the blog.
It would be great to have this option in the next wp release." gandham
Needs Milestone 13779 Preview doesn’t work - WP installed in its own directory General 2.9.2 normal normal Awaiting Review defect (bug) reopened 2010-06-08T01:32:04Z 2013-02-02T23:02:43Z "1. Wordpress is installed on /wp/ subdirectory.
2. Then it was set up to be visible from the site root according to http://codex.wordpress.org/Giving_WordPress_Its_Own_Directory
3. Site works fine
4. [BUG] Preview for posts & pages isn’t working.
When I press preview it goes to url like:
http://example.com/?preview=true&preview_id=235&preview_nonce=aa28f04
and says ""You do not have permission to preview drafts."".
5. If I type subdirectory name “/wp/” in that url by hands, it shows correct preview: http://example.com/wp/?preview=true&preview_id=235&preview_nonce=aa28f04
6. The situation is getting worse if i'm using permalinks. In that case - there is nothing i can do to see preview.
ps: I’ve tested that on clean install. " antares19
Needs Milestone 23374 Custom photo title is overwritten upon completion of upload Media 3.5.1 normal normal Awaiting Review defect (bug) new 2013-02-03T03:37:30Z 2013-02-03T03:37:30Z "Version: 3.5.1 (latest)
Environment: Chrome 24.0.1312.57 on Mac OSX 10.8.2
Steps to reproduce:
1. Create a new post and click the Add Media button.
2. Add several large photos (>4MB). This is necessary to give you time to perform step 3.
3. Add new titles to the photos that are in the process of uploading.
Output: after a photo finishes uploading, its newly-added title get overwritten by a default title (taken from the filename)
Expected output: on the completion of a photo upload, the title field should be checked and preserved if necessary, not overwritten
(not related to plugins or theme)" franksvalli
Needs Milestone 23373 Limiting get_users() results by meta value with LIKE wildcards Users 3.5 normal normal Awaiting Review enhancement new has-patch 2013-02-03T03:07:03Z 2013-02-03T06:56:27Z "I want to limit the results returned by get_users() to a subset of the users based on some criteria that will be stored in the User Meta table (e.g. all users whose first name begins with M).
Here arr the args I am passing to get_users():
{{{
(
[include] =>
[exclude] =>
[fields] => all_with_meta
[meta_key] => last_name
[meta_value] => M%
[meta_compare] => LIKE
)
}}}
This is the query the WordPress constructs for me:
{{{
[01-Feb-2013 16:01:08 UTC] WP_User_Query Object
(
[query_vars] => Array
(
[blog_id] => 1
[role] =>
[meta_key] => last_name
[meta_value] => M%
[meta_compare] => LIKE
[include] =>
[exclude] =>
[search] =>
[search_columns] => Array
(
)
[orderby] => login
[order] => ASC
[offset] =>
[number] =>
[count_total] =>
[fields] => all_with_meta
[who] =>
)
[results] => Array
(
)
[total_users] => 0
[query_fields] => wp_users.ID
[query_from] => FROM wp_users INNER JOIN wp_usermeta ON (wp_users.ID = wp_usermeta.user_id)
[query_where] => WHERE 1=1 AND ( (wp_usermeta.meta_key = 'last_name' AND CAST(wp_usermeta.meta_value AS CHAR) LIKE '%M\\%%') )
[query_orderby] => ORDER BY user_login ASC
[query_limit] =>
}}}
----
As you can see, the LIKE clause is escaped and wrapped with SQL wildcard operators. I can't figure out how to prevent this from happening as what I want is ""LIKE 'M%'"" to be my actually query.
Andrew Nacin wp@andrewnacin.com via lists.automattic.com
11:24 am (1 day ago) to wp-hackers
Currently, ""LIKE"" prepends and appends wildcards, as in %term%. We could add ""%LIKE"" and ""LIKE%"", though that would not help with the situation where you want LIKE taken literally, potentially without % wildcards at all. (Such as using _ as a single-character wildcard, or looking for case insensitive matching.) Probably the best way to add to this API would be to allow for a 'like_escape' => false; that would accept your value as provided. If you'd like to submit a ticket (and patch), this can definitely find its way into 3.6.
Nacin
----
I have prepared a patch to meta.php which allows escaped LIKE and NOT LIKE meta compares to work properly.
" mpwalsh8
Needs Milestone 23365 Add Option for user defined from_email Mail normal normal Awaiting Review enhancement new 2013-02-02T03:25:47Z 2013-02-03T08:04:34Z "As is admitted in pluggable.php in the wp_mail function, the default from address is not ideal. If set to wordpress@domain(dot)com, some hosts block the E-mail because it doesn't exist. If set to admin_email, some hosts block it because it's from an unknown domain.
The most natural answer to me is to add an option for this in the admin interface. This way, people with an issue, or simply trying to appear more professional, are able to change this without a plugin or adding code to their theme. Even if the option is pretty buried, a simple help doc could point folks to the right spot.
For proof of need, check out all the threads under http://wordpress.org/search/wordpress%40?forums=1" stevish
Needs Milestone 23257 Add plural versions of Post Format strings General 3.5 normal normal Awaiting Review enhancement new has-patch 2013-01-22T00:59:30Z 2013-02-04T08:45:32Z "To make it easier for theme authors to create meaningful titles for post format archive pages, we could extend `get_post_format_strings()` to also provide a standardized set of plurals.
I'm not entirely sure whether the plurals I used in the diff are the ones we actually want to go with (apparently there is no plural of 'Audio'?), but the change is fairly simple and is backwards compatible.
See [https://github.com/Automattic/_s/pull/137 this discussion] for additional context." obenland
Needs Milestone 18264 Future private posts listed as already published with future date specified Administration normal normal Awaiting Review defect (bug) new 2011-07-27T00:05:27Z 2013-02-04T09:27:17Z "Setting a post to private, and scheduling it for some future date or time, results in the stamp that the post was ""Published on (future date)"" in the publish module.
The discussion on tickets #5608 and #9136 suggests that all private posts are published immediately (and privately), and that this is intentional. So, it's misleading and confusing to report that it already was published on some future date.
In source:trunk/wp-admin/includes/meta-boxes.php#L163, I suggest we replace:
{{{
else if ( 'publish' == $post->post_status || 'private' == $post->post_status ) { // already published
$stamp = __('Published on: <b>%1$s</b>'); }
}}}
with:
{{{
else if ( 'publish' == $post->post_status ) { // already publicly published
$stamp = __('Published on: <b>%1$s</b>');
} else if ( 'private' == $post->post_status ) { // published privately
$stamp = __('Published privately'); }
}}}" chrisrudzki
Needs Milestone 23371 Subdir front-end Toolbar bug on first login Toolbar 3.3 normal normal Awaiting Review defect (bug) n