| [21523]
|
ryan
|
Fix phpdoc for switch_to_blog() and restore_current_blog(). Props SergeyBiryukov. fixes #21459
|
| [21522]
|
ryan
|
Add @since for _wp_get_user_contactmethods() and _get_additional_user_keys(). Props SergeyBiryukov. fixes #21246
|
| [21521]
|
ryan
|
Update @since for various wpdb properties. Props SergeyBiryukov. fixes #21582
|
| [21509]
|
ryan
|
Update wp_update_user() phpdoc to reflect a possible return of WP_Error. Props SergeyBiryukov. fixes #21439
|
| [21508]
|
ryan
|
Fix display issues in the custom header screen when height is not specified. Use get_header_image() instead of header_image() so that esc_url() can do its job. Props JarretC, SergeyBiryukov, georgestephanis. fixes #21130 #21433
|
| [21507]
|
ryan
|
Use admin_url() instead of get_edit_user_link() in wp-login.php since cookies are not yet set. Props SergeyBiryukov. fixes #14787
|
| [21506]
|
ryan
|
Add isset() check to avoid notice. Props c3mdigital. fixes #21512
|
| [21504]
|
ryan
|
Remove post type from post nonces. Fixes attachment deletion when EMPTY_TRASH_DAYS is 0. Props c3mdigital, kurtpayne, SergeyBiryukov. fixes #21194
|
| [21502]
|
ryan
|
Better instruction text on custom header screen. Props jane, JustinSainton fixes #20992
|
| [21497]
|
ryan
|
Avoid fatal error in the customizer when the current theme doesn't support custom headers. Props c3mdigital. fixes #21515
|
| [21496]
|
ryan
|
Allow passing stdClass and WP_User to wp_insert_user() and wp_update_user(). Introduce WP_User::to_array(). Eliminate uses of get_object_vars() when passing to wp_*_user(). fixes #21429
|
| [21485]
|
ryan
|
switch_to_blog() and restore_current_blog() housekeeping.
wp-includes/admin-bar.php:
* Replace get_admin_url() and get_home_url() with admin_url() and home_url() and place them inside a switch/restore. Likewise replace current_user_can_for_blog() with current_user_can(). This avoids doing multiple switch restores.
wp-includes/ms-blogs.php:
* Deprecate the $validate argument to switch_to_blog(). This avoids a not very necessary call to get_blog_details(), possibly saving a few queries.
* Use $_wp_switched and $_wp_switched_stack instead of $switched and $switched_stack to make it less likely these globals will be stomped.
* Use GLOBALS to access blog_id and other globals. I've preferred this style lately since it makes it obvious a global is being used and avoids global blog_id being stomped by a local variable.
* Lose some is_object() checks. wp_get_current_user() always returns an object, for example.
* Call the new WP_Roles::reinit() method.
wp-includes/class-wp-xmlrpc-server.php:
* Replace current_user_can_for_blog() with current_user_can() and move it inside the switch/restore pair. This eliminates a switch/restore.
wp-includes/capabilities.php:
* Use array_keys() instead of $role => $data since $data is unused. I *think* this is a bit faster.
* Introduce WP_Roles::reinit(). This reinitializes WP_Roles and is used after switch_to_blog() has already update the blog ID in the wpdb object. If a global roles array is being used instead of the db, reinit is skipped.
* current_user_can_for_blog() now does a switch/restore. It didn't before meaning it could be reinitializing the user with the wrong role information for the current blog.
wp-includes/ms-settings.php:
* Define $_wp_switched_stack and $_wp_switched. This way switch_to_blog() and restore_current_blog() can rely on it being set.
wp-settings.php:
* Instantiate the WP_Roles global. This was it is always defined during init. To remove the WP_Roles checks from WP_Role and WP_User this would probably have to move before plugins are loaded, which might not be a good thing.
wp-includes/functions.php:
* Update wp_upload_dir() to reference _wp_switched.
|
| [21484]
|
ryan
|
Move get_current_blog_id() to load.php so it is available during multisite bootstrap. fixes #21432
|
| [21480]
|
ryan
|
Undeprecate *_blog_option() by popular demand. Put them back in ms-blogs.php since direct inclusion of ms-blogs.php/ms-functions.php is unforntunately common.
see #21432
|
| [21414]
|
ryan
|
Deprecate get_blog_option(), add_blog_option(), update_blog_option(), and delete_blog_option().
Use the regular option functions wrapped in switch_to_blog() and restore_current_blog() instead.
Group multiple operations within a single switch where possible.
fixes #21432
|
| [21403]
|
ryan
|
Introduce wp_cache_switch_to_blog() and WP_Object_Cache::switch_to_blog() as a lighter/faster way to switch the cache to a new blog id.
Add the blog id to the cache keys for multisite installs.
Use wp_cache_switch_to_blog() instead of wp_cache_init() in switch_to_blog().
Use wp_cache_switch_to_blog() instead of wp_cache_reset() in wp_start_object_cache().
Deprecate wp_cache_reset().
This avoids the many queries needed to re-prime the cache after switch_to_blog() on multisite installs using the default cache backend.
fixes #21434
|
| [21378]
|
ryan
|
Use Yoda conditions. Props evansolomon. see #21270
|
| [21374]
|
ryan
|
Better phpdoc for user_nicename. Props SergeyBiryukov. fixes #21427
|
| [21373]
|
ryan
|
Call func_get_args() once in add_query_arg(). Props SergeyBiryukov. see #21332
|
| [21365]
|
ryan
|
Give Add New button on edit taxonomy pages primary button styling. Props JustinSainton. fixes #21406
|
| [21364]
|
ryan
|
Introduce get_edit_user_link(). Props scribu, georgestephanis, johnbillion. fixes #14787 see #20307
|
| [21363]
|
ryan
|
Take the mmm out of comment_ID. Just mm is sufficient.
Props wonderboymusic
fixes #21400
|
| [21362]
|
ryan
|
s/newuserconfimation/newuserconfirmation/
Props Jayjdk, lesteph
fixes #21415
|
| [21357]
|
ryan
|
Refactor *_blog_option() functions to use switch_to_blog(), restore_current_blog(), and the *_option() functions. Do not use site-options for blog option caching as this duplicated info and did not properly invalidate.
Props jeremyfelt
fixes #21270
|
| [21354]
|
ryan
|
phpdoc for Customizer classes and methods. Props bananastalktome. see #21303
|
| [21353]
|
ryan
|
Deprecate and stub _media_button. fixes #21317
|
| [21352]
|
ryan
|
Deprecate and stub _insert_into_post_button(). fixes #20427
|
| [21351]
|
ryan
|
Introduce wp_oembed_remove_provider(). Props r-a-y. fixes #16327
|
| [21350]
|
ryan
|
Improved phpdoc for file.php. Props tommcfarlin. fixes #21328
|
| [21349]
|
ryan
|
Remove debug cruft. Props ocean90. fixes #21315
|
| [21333]
|
ryan
|
Fix some spelling errors. Props thee17. fixes #21191
|
| [21332]
|
ryan
|
Use get_search_query() in feed-rss2-comments.php. Props SergeyBiryukov. fixes #21365
|
| [21330]
|
ryan
|
Don't attempt to define the COMMENTS_TEMPLATE constant twice. Props kitchin. fixes #21337
|
| [21324]
|
ryan
|
Set the global comment var before invoking callbacks in wp_list_comments(). Props sirzooro. fixes #21184
|
| [21323]
|
ryan
|
More screen reader text for list table checkboxes and theme install search. Props MikeLittle, SergeyBiryukov. see #21325
|
| [21322]
|
ryan
|
Fix per_page screen option for custom post types and taxonomies. Don't convert taxonomy and post type slugs from hyphen to underscore when saving the per_page usermeta. Props nacin. see #18958
|
| [21318]
|
ryan
|
Add screen reader text for search fields in theme-install.php. Props MikeLittle. see #21325
|
| [21317]
|
ryan
|
Add screen reader text to checkboxes in list tables. Props MikeLittle, nacin. see #21325
|
| [21316]
|
ryan
|
Translate role names in the new user notification email. Props obenland. fixes #20764
|
| [21315]
|
ryan
|
For get_settings_errors(), make sure errors from transient get added to the global variable and not unset when checking for an error of a specific setting. Also always return an array, as noted in the documentation. Props obenland. fixes #20833
|
| [21293]
|
ryan
|
Introduce cron_request filter. Props ikailo. fixes #13449
|
| [21074]
|
ryan
|
RC4 bump
|
| [21073]
|
ryan
|
Pass a post object instead of ID to help preserve ancestors. Props duck_. fixes #18536
|
| [21071]
|
ryan
|
Customize: If the preview is not logged in but the admin is, perform a front page request to setup any mapped domain cookies and then retry loading the preview.
Props nacin, koopersmith
fixes #20926
|
| [21070]
|
ryan
|
Pinking shears
|
| [21064]
|
ryan
|
Force a theme directory scan after installing and upgrading themes. Props nacin. fixes #20919
|
| [21063]
|
ryan
|
Fallback to /themes when there is no theme root. Props duck_. see #20919
|
| [21062]
|
ryan
|
Use the stylesheet rather than the template to create the network enable theme nonce. Fix network enable redirect following theme installation. Props duck_, nacin. fixes #20916
|
| [21060]
|
ryan
|
Fix warning when processing read_post cap. Props duck_. fixes #20917
|
| [21052]
|
ryan
|
Add RTL and locale classes to the press this body. Props SergeyBiryukov. fixes #19603
|
| [21051]
|
ryan
|
Remove obsolete help string. Props SergeyBiryukov. fixes #20909
|
| [21049]
|
ryan
|
Escape editable_slug as a textarea.
|
| [21048]
|
ryan
|
Restrict post IDs
|
| [21047]
|
ryan
|
In excerpt view, show the excerpt only if the user can read_post.
|
| [21046]
|
ryan
|
Make read_post more useful. Map read_post to edit_post for posts with protected post states. This makes read_post work naturally for draft, future, and pending posts belonging to other users. If the current user cannot edit these non-public posts then the user should not be able to read them either.
|
| [21040]
|
ryan
|
Bump bundled theme versions. Props nacin. fixes #20886
|
| [21039]
|
ryan
|
Make sure the path exists before copying. see #20657
|
| [21037]
|
ryan
|
* Introduce remove_header_image(), reset_header_image(), set_header_image(), and get_header_image_data() for Custom_Image_Header.
* Handle all set/get of header theme mod through these methods.
* Use these methods in the customizer.
Props kovshenin, nacin, SergeyBiryukov, koopersmith.
fixes #20871
|
| [21035]
|
ryan
|
Fix comment hotkeys for FF and IE. Props azaozz, SergeyBiryukov. fixes #20885
|
| [21031]
|
ryan
|
Customizer: Gravefully handle cookie expipration. Prompt for log in in the preview. Props ocean90, koopersmith, nacin. fixes #20876
|
| [21029]
|
ryan
|
Customizer: fix stuck urls and preview white screens after repeated save and activates. Props koopersmith. fixes #20868
|
| [21028]
|
ryan
|
Customizer: Redirect back to referrer. If referrer is a front end page, load that page in the customizer preview. Props nacin, koopersmith. fixes #20877
|
| [21024]
|
ryan
|
Customizer: Add keyup events to sync textarea values. Props koopersmith. fixes #20879
|
| [21018]
|
ryan
|
RC2 bump
|
| [21016]
|
ryan
|
Namespace the customize request arg to prevent collision with plugins and themes. Props nacin. fixes #20862
|
| [21013]
|
ryan
|
Don't resurrect a removed default image when changing colors in the Customizer. Props koopersmith, nacin. fixes #20448
|
| [21012]
|
ryan
|
Fix admin menu hover. Props koopersmith. fixes #20857
|
| [21009]
|
ryan
|
Check context before adding media upload filters. Props SergeyBiryukov. fixes #20819
|
| [21008]
|
ryan
|
Preserve context when searching in the media upload form. Props SergeyBiryukov. fixes #20856
|
| [21001]
|
ryan
|
Fix removing the default background image for themes that hard-code the default in css. Honor the default background image for themes that do not provide a fallback in css.
* <style> will appear if there is a default image registered. This is the same as 3.3.
* If only a default color is registered, it still assumes it is in the stylesheet, and no <style> will appear. This is a change from 3.3.
* <style> will continue to appear as before if there is a custom background color or image. This is the same as 3.3.
* This then allows for a default background image with background-image: none, overriding style.css. This is new.
Props nacin
see #20448
|
| [20999]
|
ryan
|
Remove text-align on search input. Props SergeyBiryukov. fixes #20841
|
| [20998]
|
ryan
|
RTL fixes. Props SergeyBiryukov, helenyhou. fixes #20841
|
| [20997]
|
ryan
|
The image selector arrows should not do a 4g inverted dive. Props helenyhou. fixes #20843
|
| [20991]
|
ryan
|
Customizer UI tweaks.
* Don't flip arrow when for open section.
* Give the open section a white background.
* Provide a darker hover state for section headers.
Props helenyhou, SergeyBiryukov
fixes #20828
|
| [20990]
|
ryan
|
Update Fire browser detection. Handle silke mode. Props azaozz, nacin, georgestephanis. fixes #20014
|
| [20988]
|
ryan
|
Theme Customizer: Fix race condition in previewer and use message channels. Props koopersmith. fixes #20811
|
| [20984]
|
ryan
|
Site/user autocomplete fixes.
* Lengthen the inputs in the Right Now network dashboard widget
* Border around the whole autocomplete widget/list
* Handle long strings
* Remove some CSS color cruft from the main stylesheet and de-dupe the JS closures for open/close callbacks.
Props helenyhou
fixes #20584
|
| [20983]
|
ryan
|
Back compat for bundled themes. Props nacin, SergeyBiryukov, kobenland. fixes #20768
|
| [20982]
|
ryan
|
Don't show mime type filter links when choosing an image header from the media library. Props SergeyBiryukov, georgestephanis. fixes #20819
|
| [20981]
|
ryan
|
Update custom header help text to reflect recent UI changes. Props SergeyBiryukov, rasheed. fixes #20827
|
| [20980]
|
ryan
|
Make the Skip Cropping button secondary. Props SergeyBiryukov, nacin. fixes #20815
|
| [20974]
|
ryan
|
Don't allow unfiltered HTML comments from a frame. Props nacin. fixes #20812
|
| [20973]
|
ryan
|
Custom background fixes:
* Specify default background colors for the bundled themes.
* Change the default custom background callback to only operate on saved values, rather than default values.
* Prevent an unsaved default value from overriding a manually modified style.css file.
Props nacin, kobenland
fixes #20448
|
| [20972]
|
ryan
|
Consolodate some strings. Props pavelevap. fixes #20809
|
| [20971]
|
ryan
|
Refresh whimsy. fixes #20794
|
| [20969]
|
ryan
|
Theme Customizer: Reduce reliance on fixed positioning and make sidebar UI flexible. Props koopersmith, ocean90, helenyhou. fixes #20799
|
| [20968]
|
ryan
|
Fix collapse button and return link markup for theme install preview. Props koopersmith. fixes #20800
|
| [20967]
|
ryan
|
Theme help text updates. Consistently use Live Preview. Props SergeyBiryukov. fixes #20795
|
| [20959]
|
ryan
|
Better description for 'Faster WP_Query'. Props simonwheatley. fixes #20789
|
| [20958]
|
ryan
|
Post theme upgrade/install tweaks.
* Add title attributes to Live Preview links.
* Show Customize instead of Live Preview after upgrading current theme.
* Hide activate and preview links after theme upgrade when in the network admin.
Props SergeyBiryukov
fixes #20784
|
| [20957]
|
ryan
|
"Live Preview" rather than "Customize" after installing/upgrading a theme. Props SergeyBiryukov. fixes #20784
|
| [20954]
|
ryan
|
Update help text to reflect new location of the customizer save buttons. Props tai. fixes #20775
|
| [20948]
|
ryan
|
RC1 bump
|
| [20944]
|
ryan
|
Shears of vigorous pinking.
|
| [20884]
|
ryan
|
Improve appearance of "choose from library" link for headers and backgrounds. Props SergeyBiryukov, sabreuse. see #20737
|
| [20878]
|
ryan
|
"Save & Activate" for customize controls localization. see #20692 #19910
|
| [20877]
|
ryan
|
"Save & Activate", "Save & Publish" for customizer save button. Props jane. see #20692 #19910
|
| [20857]
|
ryan
|
Don't pass action ID to the ajax actions to avoid possible back compat problems. Props sivel. fixes #20699
|
| [20856]
|
ryan
|
Introduce _prepare_comment(). Avoid repeated auth attempts. Props maxcutler. fixes #20703
|
| [20854]
|
ryan
|
Updated text for Customize pointer. Props jane. see #20554
|
