﻿ticket	summary	owner	component	version	priority	severity	milestone	type	_status	workflow	_created	modified	_description	_reporter
24413	Twenty Thirteen: phpdoc cleanup/completion		Bundled Theme	trunk	normal	normal	3.6	enhancement	new	has-patch	2013-05-24T17:31:51Z	2013-05-24T20:10:55Z	Patch adds some missing tag descriptions, fixes a reference to the wrong function and some other grammatical stuff.	DrewAPicture
24407	Twenty Thirteen: Misalignment of images in image post formats that use captions		Bundled Theme	trunk	normal	normal	3.6	defect (bug)	new	has-patch	2013-05-23T22:41:53Z	2013-05-24T19:59:26Z	"If you upload an image to a post that uses the image post format and include a caption, the image will be misaligned on the posts page.

[[Image(http://f.cl.ly/items/0b2v0o1N2I0t1z3y0K3l/caption-misalignment-1.png)]]

[http://f.cl.ly/items/1X0T201W173o3C3k0y3q/caption-misalignment.png Full sized image]

To recreate:

1. Add a new post
2. Choose ""Image""
3. Add an image via the media uploader
4. Add a caption to the image
5. Save and view the post

The misalignment occurs on the posts page and the individual post page."	tollmanz
24405	Revisions needs a functional fallback for no-js		Revisions	trunk	high	blocker	3.6	defect (bug)	new		2013-05-23T21:42:30Z	2013-05-24T03:27:32Z	"Since editing, comparing and restoring revisions requires javascript, we should not make it possible open revisions from the editing screen.

In the patch, I took a stab at adding an error message to the Revisions metabox as well as a solution for disabling the edit link if no-js. Not a huge fan of tacking on an extra span to `$date` just for no-js, but as far as I'm aware, we don't have a way to test for javascript support in PHP."	DrewAPicture
24404	Allow get_the_post_format_image to return image without link		Post Formats	trunk	normal	normal	3.6	enhancement	new	dev-feedback	2013-05-23T20:34:41Z	2013-05-24T19:54:43Z	"When a user adds a link to an image post in the new post format UI, `the_post_format_image()` and `get_the_post_format_image()` functions will always return the image HTML wrapped in the link. 

There are a number of cases in which a theme or plugin author may want to get the image without the link. For example, the author might want to wrap both the image and the title in a link. Having a link wrapped around the image complicates this. 

I think we should either add a new parameter that allows the image to be returned without the link, or create two functions: one that returns the image with the link and one without the link. I personally find it a little misleading to use a function called `the_post_format_image()` and get an image wrapped in a link. 

Separating functions that allow for returning just the image and the image with the link is important for flexibility. I think that wrapping the image in a link is making a decision that the developer should make and is limiting the developer without good reason. This will lead to some weird workarounds that will decrease the stability of community code. Having two functions instead of one does not increase complexity, yet it improves the flexibility of the API.

I'm happy to work on this if people think it's worth adding."	tollmanz
24402	Menus accordion should be auto-expanded for no-js		Menus	trunk	high	normal	3.6	defect (bug)	new	dev-feedback	2013-05-23T20:03:55Z	2013-05-24T19:49:03Z	If you visit the Nav Menus UI with javascript turned off, there's no way to expand the accordion sections for adding items. We should auto-expand the accordion for no-js.	DrewAPicture
24390	Post Formats: Return correct datatype in get_post_gallery()		Post Formats	trunk	normal	normal	3.6	defect (bug)	new	has-patch	2013-05-22T21:30:15Z	2013-05-23T02:11:42Z	`get_post_gallery()` has a flag to request HTML or data. By default HTML is requested, yet the fallback data type that is returned by the function assumes that data was requested. This might lead to an array to string conversion if `the_post_format_gallery()` is being called in a post without a gallery.	obenland
24388	Optimize revisions diff loading - especially when many revisions		Revisions	trunk	normal	critical	3.6	defect (bug)	new		2013-05-22T20:16:48Z	2013-05-24T14:00:24Z	"Currently viewing the revisions page chokes the browser when there are many revisions (say over 50) - even with a lower number the browser seems overwhelmed by the numerous ajax requests fired to load the comparison diffs.

* limit the number of simultaneous ajax requests
* group diff requests to optimize loading and limit total number of calls when there are many revisions
* caching for diff calculations  "	adamsilverstein
24377	Revisions 'compare_two_mode' always true, no longer used		Revisions	trunk	normal	normal	3.6	defect (bug)	new	has-patch	2013-05-20T23:17:21Z	2013-05-21T20:03:40Z	the variable compare_two_mode is no longer used in ajax-actions.php, it can be removed	adamsilverstein
24372	Text_Diff: Deprecated and Strict Standards PHP warnings		Warnings/Notices	trunk	normal	normal	3.6	defect (bug)	new		2013-05-20T17:19:49Z	2013-05-20T17:19:49Z	"Since [24288].


{{{
Deprecated: Assigning the return value of new by reference is deprecated in /wp-includes/Text/Diff.php on line 380

Deprecated: Assigning the return value of new by reference is deprecated in /wp-includes/Text/Diff.php on line 402

Deprecated: Assigning the return value of new by reference is deprecated in /wp-includes/Text/Diff.php on line 424

Deprecated: Assigning the return value of new by reference is deprecated in /wp-includes/Text/Diff.php on line 446

Deprecated: Assigning the return value of new by reference is deprecated in /wp-includes/Text/Diff/Renderer.php on line 101

Deprecated: Assigning the return value of new by reference is deprecated in /wp-includes/Text/Diff/Renderer.php on line 121

Deprecated: Assigning the return value of new by reference is deprecated in /wp-includes/Text/Diff/Engine/native.php on line 107

Deprecated: Assigning the return value of new by reference is deprecated in /wp-includes/Text/Diff/Engine/native.php on line 122

Deprecated: Assigning the return value of new by reference is deprecated in /wp-includes/Text/Diff/Engine/native.php on line 124

Deprecated: Assigning the return value of new by reference is deprecated in /wp-includes/Text/Diff/Engine/native.php on line 126

Strict Standards: array_walk() expects parameter 2 to be a valid callback, non-static method Text_Diff::trimNewlines() should not be called statically in /wp-includes/Text/Diff/Engine/native.php on line 33

Strict Standards: array_walk() expects parameter 2 to be a valid callback, non-static method Text_Diff::trimNewlines() should not be called statically in /wp-includes/Text/Diff/Engine/native.php on line 34
}}}

Upstream is http://www.horde.org/libraries/Horde_Text_Diff. There is a newer version, but it's NOT back compatible."	ocean90
24365	Suppressed errors during install		Warnings/Notices		normal	normal	3.6	defect (bug)	new		2013-05-19T12:18:35Z	2013-05-19T12:19:05Z	"Reported in http://wordpress.org/support/topic/36-beta3-24284-throws-a-stream-of-suppressed-errors-during-install:
{{{
PHP Strict standards:  Redefining already defined constructor for class WP_Widget in .../wp-includes/widgets.php on line 93
PHP Notice:  unserialize(): Error at offset 0 of 38 bytes in .../wp-admin/includes/upgrade.php on line 1420
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 589
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 622
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 644
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 655
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 662
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 675
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 675
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 696
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 702
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 708
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 720
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 733
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 746
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 760
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 774
PHP Strict standards:  Only variables should be assigned by reference in .../wp-admin/includes/schema.php on line 787
}}}"	SergeyBiryukov
24364	"Fix  autocomplete=""off"" in Chrome"	azaozz	Administration		normal	normal	3.6	defect (bug)	reopened		2013-05-18T22:45:28Z	2013-05-23T19:25:57Z	"Seems latest Chrome doesn't respect autocomplete=""off"" on <input type=""password"" /> fields. This is a problem in forms where the user has to choose a password like the Profile and Edit User screens. 

When the user wants to change a setting on the Profile screen, the first password field is auto-filled. That results in error on submitting the form: ""ERROR: You entered your new password only once...""."	azaozz
24360	Unable to use supports=>post-formats without support for thumbnail		Post Formats	trunk	normal	normal	3.6	defect (bug)	new	has-patch	2013-05-18T13:44:52Z	2013-05-19T15:09:52Z	in custom post type you cant choose post-formats capability whithout using thumbnail. Post formats UI shows but after changing format it redirects me to normal posts not the custom one.	zabatonni
24356	Admin Nav Menu Walker - Strict Standards compatibility		Warnings/Notices	3.5.1	normal	minor	3.6	enhancement	new	has-patch	2013-05-17T16:34:31Z	2013-05-24T10:40:04Z	"Admin -> Appearance -> Menus produces some warning for me for some methods overriding abstract definitions do not follow strict standards.

Patch is here:
http://pastebin.com/6a2ugms7"	dvarga
24355	Post Formats: any allowed file type can be uploaded to an audio, video or image post		Post Formats	trunk	normal	normal	3.6	defect (bug)	new	has-patch	2013-05-17T16:09:34Z	2013-05-18T03:31:47Z	"To reproduce:

1. Create a new post, select the video post format
1. Hit Select Video from Media Library
1. Choose Upload Files and upload an image
1. Hit Select Video

An image is inserted instead of a video, plus after saving, the dimensions constraints are not applied to the image because it's a video post format."	kovshenin
24350	Post Formats UI should have an 'after_post_format_fields' action		Post Formats	trunk	normal	normal	3.6	enhancement	new	dev-feedback	2013-05-15T22:00:07Z	2013-05-24T19:49:28Z	"I already know of several people who would like to extend the new Post Formats UI to include additional fields and info on a per-format basis. It would be nice to have an action hook in place for this right out of the gate in 3.6.

The patch adds a `'after_post_format_fields'` action."	DrewAPicture
24348	Consider the post thumbnail in get_the_post_format_image()		Post Formats	trunk	normal	normal	3.6	enhancement	new	dev-feedback	2013-05-15T21:39:45Z	2013-05-24T19:48:38Z	"`get_the_post_format_image()` makes valiant attempts to locate an image for use with a post of image post format.

The function first attempts to find suitable data in the post format meta field. If no image is found there, it grabs the first attached image. Finally, if all else fails, it will look in the post content to use the first image inserted in the content.

I think that the function should also consider grabbing the post's featured image as a fallback. I would prioritize this right after the post format meta data. 

I think this is important in that it seems that using the featured image was a common practice for adding an image to a post of image post format. I would think that this would help improve back compat for themes that have used this practice. Moreover, since grabbing an attached image or an image inserted in the post content is merely a guess at the right image to use for the post, I think that using the featured image is a better guess than either of these methods."	tollmanz
24346	Revisions reloading all comparisons in two handle mode instead of just available comparisons		Revisions	trunk	normal	normal	3.6	defect (bug)	new	has-patch	2013-05-15T19:41:23Z	2013-05-22T20:07:31Z	"as  ahoereth pointed out, see [http://www.screenr.com/vAI7 screencast], all comparisons were reloading after moving one handle; instead, only possible positions for the opposite handle need to be reloaded. 
"	adamsilverstein
24345	preview link for published posts does not apply the preview_post_link filter		Administration	3.5.1	normal	normal	3.6	defect (bug)	new	has-patch	2013-05-15T15:59:25Z	2013-05-15T16:09:01Z	"The ""Preview Changes"" button in the admin section (as created in wp-admin/includes/meta-boxes.php lines 40-49) does not apply the preview_post_link filter if the post has already been published (line 41).

The patch from #19378 ensures that the javascript that is called to open the preview link in a new tab/window DOES apply the preview_post_link filter, so if you click the link normally it will use the correct URL. However, hovering over the ""Preview Changes"" button shows the incorrect URL, and right-clicking the button and opening in a new tab/window opens the incorrect URL as well.

I have attached a patch that applies the preview_post_link filter to the link created for published posts."	joeybvi
24344	More Tag not visible in the Visual Editor		TinyMCE	trunk	normal	normal	3.6	defect (bug)	new		2013-05-15T10:23:54Z	2013-05-21T03:14:20Z	"When clicking on the ""Insert More Tag"" button in the WYSIWYG editor, the more tag line is not visible. The `<!--more-->` tag has been added & can be seen in the Text Editor but not in the Visual pane.

Both:
{{{
img.mceWPmore {
    background: url(""img/more_bug.gif"") no-repeat scroll right top transparent;
}
}}}
and:
{{{
img.mceWPnextpage, img.mceWPmore {
    -moz-border-bottom-colors: none;
    -moz-border-left-colors: none;
    -moz-border-right-colors: none;
    -moz-border-top-colors: none;
    border-color: #CCCCCC -moz-use-text-color -moz-use-text-color;
    border-image: none;
    border-right: 0 none;
    border-style: dotted none none;
    border-width: 1px 0 0;
    display: block;
    height: 12px;
    margin: 15px auto 0;
    width: 95%;
}
}}}
seem to be missing from content.css when checked using Firebug.

Using 3.6-beta3-24260 (lasest nightly 15/05/13) & Twenty Twelve. The issue has also been confirmed using other themes."	esmi
24341	the_post_format_audio() and the_post_format_video() don't work with [embed]		Post Formats	trunk	normal	normal	3.6	defect (bug)	new	has-patch	2013-05-15T01:14:47Z	2013-05-20T21:47:44Z	"This embed code in a video post content isn't picked up by `the_post_format_video()`.

{{{
[embed]http://wordpress.tv/2009/03/16/anatomy-of-a-wordpress-theme-exploring-the-files-behind-your-theme/[/embed]
}}}

This embed code in an audio post content isn't picked up by `the_post_format_audio()`.

{{{
[embed]http://soundcloud.com/dubstep/on-my-way-by-party-ghost[/embed]
}}}

However, both of these will work without the `[embed]` shortcode."	greenshady
24326	Admin RTL bugs		RTL	trunk	normal	normal	3.6	defect (bug)	new	has-patch	2013-05-12T18:22:37Z	2013-05-17T16:30:45Z	Hi, This a list of some RTL style bugs I found it today in the beta 3 update.	alex-ye
24316	Post Format Selector Icons Display One-per-line in IE7		Post Formats	trunk	normal	normal	3.6	defect (bug)	new	has-patch	2013-05-11T03:42:00Z	2013-05-14T20:41:17Z	IE 7 doesn't like max-width or min-width. By explicitly specifying the {{{width}}} property, the icons will display as intended instead of... horrifically. 	celloexpressions
24309	Add filters for get_post_galleries() and get_post_gallery()		Gallery	trunk	normal	normal	3.6	defect (bug)	new	has-patch	2013-05-10T21:47:26Z	2013-05-10T21:48:23Z	"As post format implementations were not tightly defined in the past, there are a variety of gallery implementations in the wild. For example, not all implementations included the use of the [gallery] shortcode.

Adding in a couple of hooks will likely allow for backward compatibility to those implementations."	alexkingorg
24306	Twenty Thirteen: border-box box sizing will break many plugins		Bundled Theme	trunk	normal	normal	3.6	defect (bug)	new		2013-05-10T17:14:19Z	2013-05-24T19:16:59Z	"WordPress 3.6-beta2-24227

/wp-content/themes/twentythirteen/style.css
{{{
* {
    -moz-box-sizing: border-box;
}
}}}

The setting of box-sizing to border-box for all elements rather than the default content-box (as used for twentyten, twentyeleven, and twentytwelve themes) will break the styling of many plugins for Firefox.

Strange that this is only done for firefox and the default setting of content-box is used for other browsers.

Suggest this css property be only used only the elements that need it in conjunction with the CSS3 box-sizing property and other browser equivalents.

Andy Bruin


"	professor99
24301	Unescaped user input in image preview		Post Formats	trunk	high	major	3.6	defect (bug)	new	has-patch	2013-05-09T23:45:53Z	2013-05-22T17:12:58Z	"On line 36 of `wp-admin/includes/post-formats.php` as of r24227, user inputted data is printed to the screen without being escaped. The data is the fourth fallback for the image data.

To recreate the issue:

1. Go to Posts > Add New.
2. Click the Image post format icon.
3. Click ""use an image URL or HTML"".
4. Enter `<img src=""http://placehold.it/200x200 />`, being sure to omit the last `""`.
5. Enter a title.
6. Save the post.
7. Things are messed up.

The problem is that on line 36 of `wp-admin/includes/post-formats.php` a value is printed directly to the screen without being escaped. I am not sure how this should be fixed as not all mangled HTML can be repaired; however, I do not think that unescaped user input should be printed to the screen like this. My example is annoying, but harmless. This seems like something that is exploitable."	tollmanz
24293	$allowedposttags to allow value for <li>		Security		normal	normal	3.6	defect (bug)	new	commit	2013-05-09T01:59:55Z	2013-05-09T02:11:01Z	"HTML 5 allowed the `value` attribute in `<li>` elements for use with `ol`s (e.g. setting `<ol><li value=""31"">` would result in that item of the `ol` rendering as 31.

$allowedposttags strips that out currently, as that's not allowed.

Submitting a patch to allow the value attribute."	kraftbj
24291	Tweaks to Image post format UI		Post Formats	trunk	high	major	3.6	task (blessed)	new	has-patch	2013-05-08T22:12:31Z	2013-05-22T01:37:38Z	"The image post format UI is not friendly enough. There is too much emphasis on providing a URL or HTML, and not enough emphasis on using the !WordPress media library.

We should hide the HTML behind a click, kind of like !WordPress.com's toolbar-poster does."	markjaquith
24288	Timestamps in chat formats should have IDs		Post Formats	trunk	normal	normal	3.6	defect (bug)	new	has-patch	2013-05-08T20:32:35Z	2013-05-23T08:10:23Z	If we add IDs to the time elements in the chat post format, and possibly wrap them in <a> tags.  This would let you link to a specific line in the chat, like our IRC logs.	aaroncampbell
24277	chgrp and chown don't work for Filesystem over SSH2	dd32	Filesystem		normal	normal	3.6	defect (bug)	assigned	has-patch	2013-05-07T16:04:11Z	2013-05-08T00:41:29Z	"As found using a static analyzer in #24210 (from rlerdorf).

Looks to be copy-pasted from the chmod method. Attaching a patch that I think does the trick."	nacin
24270	Post Formats: get_post_gallery() can return an array when asked for a string		Post Formats	trunk	normal	normal	3.6	defect (bug)	new	has-patch	2013-05-06T15:02:54Z	2013-05-06T15:12:36Z	If the requested post is not found or does not contain a gallery shortcode, `get_post_gallery` returns an empty array, regardless of what the `$html` argument is set to.	kovshenin
24269	Twenty Thirteen: Remove twentythirteen_search_form_format()		Bundled Theme	trunk	normal	normal	3.6	enhancement	new	has-patch	2013-05-06T11:24:32Z	2013-05-23T23:54:50Z	Per [comment:ticket:23850:19], we can replace `twentythirteen_search_form_format()` with an `add_theme_support()` call once the latest patch is committed.	SergeyBiryukov
24264	Post Formats - Gallery Format: the_remaining_content still contains the gallery		Post Formats	trunk	normal	normal	3.6	defect (bug)	new	dev-feedback	2013-05-04T20:15:31Z	2013-05-06T19:31:39Z	"If you use the_post_format_gallery() along with the_remaining_content(), the gallery will be displayed twice.

As far as I see, the only way to output a gallery separately from the rest of the post content is to use get_content_galleries():

{{{
$post_content = get_the_content();
$gallery = get_content_galleries( $post_content, true, true, 0 ); 

echo $gallery[0];
echo apply_filters( 'the_content', $post_content );
}}}

This differs from the implementation for audio, video and images, as the_remaining_content() strips the media from the post content before display. the_remaining_content() should do the same with galleries."	Frank Klein
24235	Post Formats: Externally linked audio files don't show in Audio Posts		Post Formats	trunk	normal	normal	3.6	defect (bug)	new	has-patch	2013-05-01T01:45:03Z	2013-05-15T20:53:59Z	"I'm not 100% sure this is Twenty Thirteen, but it works on Twenty Twelve.

On Twenty Thirteen, instead of embedding the audio, it shows the shortcode ''only'' if the audio is external. If it's loaded from inside the media library, it's fine.

See here: http://test.ipstenu.org/audio-test.2013/
"	ipstenu
24225	Improve regular expressions when matching attributes		General	trunk	normal	normal	3.6	enhancement	new	has-patch	2013-04-29T15:37:56Z	2013-05-13T17:51:54Z	"When working with HTML attributes in various functions we use something like `[\'""](.+?)[\'""]` to match the attribute value. Although not used much in attribute values, such an approach breaks when a single or double quote is intentionally part of the value:

* `attr=""val'ue""`
* `attr='val""ue'`

Some of these are new 3.6 functions, mostly around media."	kovshenin
24219	All post formats not available in PressThis		Post Formats		high	major	3.6	defect (bug)	new	commit	2013-04-29T04:50:17Z	2013-05-07T21:20:59Z	"When creating a new PressThis post with Twenty Thirteen active, only Standard, Link, and Video are available as post formats:

https://www.evernote.com/shard/s2/sh/112e7c92-76b8-4b68-a17f-b59ac5deaaf2/32cb568f188b328ae97f285b46e7ac3b

Yes, I do use PressThis.

Similarly, mobile apps respecting `wp_getPostFormats` in XML-RPC will only show the post formats available with `get_theme_support( 'post-formats' )`

I haven't been following all of the recent post format discussion, but `get_theme_support( 'post-formats' )` should probably return all post formats unless the theme has explicitly identified which formats it supports. This is a different approach than what r24089 did, and I only see two other uses of `get_theme_support( 'post-formats' )` in core, but it doesn't accommodate for plugin/theme use of `get_theme_support( 'post-formats' )`."	danielbachhuber
24216	wp_unique_term_slug uses variable that doesn't exist		Taxonomy	2.5	normal	normal	3.6	defect (bug)	new		2013-04-28T22:44:13Z	2013-04-28T23:30:19Z	"http://core.trac.wordpress.org/browser/trunk/wp-includes/taxonomy.php#L2380

`$args['term_id']` doesn't exist. It should be `$term->term_id`.

This means that even though the DB schema allows for different taxonomies to have the same slug the code will never allow it."	lonnylot
24210	Issues found using a static analysis tool	nacin*	General		normal	normal	3.6	defect (bug)	accepted		2013-04-28T06:16:09Z	2013-05-07T16:35:03Z	"These all look like valid, but minor, issues:
{{{
--------------------------------
File       : wp-includes/class-json.php:495
Reason     : UnknownFunction
Snippet    : class_name($var)
Line       : : new Services_JSON_Error(class_name($var).

--------------------------------
File       : wp-includes/SimplePie/Locator.php:94
Reason     : RequiredAfterOptionalParam
Snippet    : $type = SIMPLEPIE_LOCATOR_ALL
Line       : public function find($type = SIMPLEPIE_LOCATOR_ALL, &$working)

--------------------------------
File       : wp-includes/ID3/module.tag.id3v2.php:433
Reason     : TooFewArgument
Snippet    : substr($footer[5])
Line       : $id3_flags = ord(substr($footer{5}));

--------------------------------
File       : wp-includes/ID3/module.tag.id3v2.php:1586
Reason     : StatementHasNoEffect
Snippet    : $frame_ownerid == '';
Line       : $frame_ownerid == '';

--------------------------------
File       : wp-includes/ID3/module.audio.mp3.php:37
Reason     : TooManyArgument
Snippet    : $this->getOnlyMPEGaudioInfoBruteForce($this->getid3->fp, $info)
Line       : $this->getOnlyMPEGaudioInfoBruteForce($this->getid3->fp, $info);

--------------------------------
File       : wp-includes/SimplePie/Misc.php:127
Reason     : TooManyArgument
Snippet    : SimplePie_Misc::entities_decode(end($attribs[$j]), 'UTF-8')
Line       : $return[$i]['attribs'][strtolower($attribs[$j][1])]['data'] = SimplePie_Misc::entities_decode(end($attribs[$j]), 
'UTF-8');
}}}

Resolved:
{{{
--------------------------------
File       : wp-includes/class-wp-walker.php:118
Reason     : RequiredAfterOptionalParam
Snippet    : $depth = 0
Line       : function display_element( $element, &$children_elements, $max_depth, $depth=0, $args, &$output ) {

--------------------------------
File       : wp-includes/comment-template.php:1298
Reason     : RequiredAfterOptionalParam
Snippet    : $depth = 0
Line       : function display_element( $element, &$children_elements, $max_depth, $depth=0, $args, &$output ) {

--------------------------------
File       : wp-includes/deprecated.php:802
Reason     : RequiredAfterOptionalParam
Snippet    : $echo = false
Line       : function get_author_link($echo = false, $author_id, $author_nicename = '') {

--------------------------------
File       : wp-includes/deprecated.php:1709
Reason     : TooManyArgument
Snippet    : get_the_content($more_link_text, $stripteaser, $more_file)
Line       : $content = get_the_content($more_link_text, $stripteaser, $more_file);

--------------------------------
File       : wp-signup.php:493
Reason     : RequiredAfterOptionalParam
Snippet    : $user_name = ''
Line       : function confirm_blog_signup($domain, $path, $blog_title, $user_name = '', $user_email = '', $meta) {

--------------------------------
File       : wp-signup.php:493
Reason     : RequiredAfterOptionalParam
Snippet    : $user_email = ''
Line       : function confirm_blog_signup($domain, $path, $blog_title, $user_name = '', $user_email = '', $meta) {

--------------------------------
File       : wp-includes/widgets.php:76
Reason     : RequiredAfterOptionalParam
Snippet    : $id_base = false
Line       : function WP_Widget( $id_base = false, $name, $widget_options = array(), $control_options = array() ) {

--------------------------------
File       : wp-includes/widgets.php:93
Reason     : RequiredAfterOptionalParam
Snippet    : $id_base = false
Line       : function __construct( $id_base = false, $name, $widget_options = array(), $control_options = array() ) {

--------------------------------
File       : wp-includes/post.php:4789
Reason     : RequiredAfterOptionalParam
Snippet    : $deprecated = ''
Line       : function _future_post_hook( $deprecated = '', $post ) {

--------------------------------
File       : wp-admin/includes/class-wp-terms-list-table.php:173
Reason     : RequiredAfterOptionalParam
Snippet    : $start = 0
Line       : function _rows( $taxonomy, $terms, &$children, $start = 0, $per_page = 20, &$count, $parent = 0, $level = 0 ) {

--------------------------------
File       : wp-admin/includes/class-wp-terms-list-table.php:173
Reason     : RequiredAfterOptionalParam
Snippet    : $per_page = 20
Line       : function _rows( $taxonomy, $terms, &$children, $start = 0, $per_page = 20, &$count, $parent = 0, $level = 0 ) {

--------------------------------
File       : wp-includes/rewrite.php:92
Reason     : TooManyArgument
Snippet    : remove_action($hook, $hook, 10, 1)
Line       : remove_action($hook, $hook, 10, 1);

--------------------------------
File       : wp-admin/includes/user.php:350
Reason     : TooManyArgument
Snippet    : delete_user_setting('default_password_nag', $user_ID)
Line       : delete_user_setting('default_password_nag', $user_ID);

--------------------------------
File       : wp-admin/includes/class-wp-terms-list-table.php:159
Reason     : TooManyArgument
Snippet    : $this->single_row($term, 0, $taxonomy)
Line       : $out .= $this->single_row( $term, 0, $taxonomy );

--------------------------------
File       : wp-admin/includes/class-wp-terms-list-table.php:202
Reason     : TooManyArgument
Snippet    : $this->single_row($my_parent, $level - $num_parents, $taxonomy)
Line       : $output .=  ""\t"" . $this->single_row( $my_parent, $level - $num_parents, $taxonomy );

--------------------------------
File       : wp-admin/includes/class-wp-terms-list-table.php:208
Reason     : TooManyArgument
Snippet    : $this->single_row($term, $level, $taxonomy)
Line       : $output .= ""\t"" . $this->single_row( $term, $level, $taxonomy );

--------------------------------
File       : wp-includes/media.php:2453
Reason     : UnknownFunction
Snippet    : sprint($link_fmt, $image)
Line       : $image = sprint( $link_fmt, $image );

--------------------------------
File       : wp-includes/media.php:1040
Reason     : TooManyArgument
Snippet    : wp_mediaelement_fallback($fileurl, $width, $height)
Line       : $html .= wp_mediaelement_fallback( $fileurl, $width, $height );

--------------------------------
File       : wp-includes/Text/Diff/Engine/xdiff.php:30
Reason     : UnknownFunction
Snippet    : xdiff_string_diff($from_string, $to_string, count($to_lines))
Line       : $diff = xdiff_string_diff($from_string, $to_string, count($to_lines));

--------------------------------
File       : wp-admin/includes/class-wp-terms-list-table.php:159
Reason     : UseVoidReturn
Snippet    : $this->single_row($term, 0, $taxonomy)
Line       : $out .= $this->single_row( $term, 0, $taxonomy );

--------------------------------
File       : wp-admin/includes/class-wp-terms-list-table.php:202
Reason     : UseVoidReturn
Snippet    : $this->single_row($my_parent, $level - $num_parents, $taxonomy)
Line       : $output .=  ""\t"" . $this->single_row( $my_parent, $level - $num_parents, $taxonomy );

--------------------------------
File       : wp-admin/includes/class-wp-terms-list-table.php:208
Reason     : UseVoidReturn
Snippet    : $this->single_row($term, $level, $taxonomy)
Line       : $output .= ""\t"" . $this->single_row( $term, $level, $taxonomy );

--------------------------------
File       : wp-admin/includes/class-wp-terms-list-table.php:228
Reason     : UseVoidReturn
Snippet    : $this->single_row_columns($tag)
Line       : echo $this->single_row_columns( $tag );

--------------------------------
File       : wp-includes/wp-db.php:648
Reason     : TooManyArgument
Snippet    : $this->has_cap('collation', $dbh)
Line       : if ( $this->has_cap( 'collation', $dbh ) && !empty( $charset ) ) {

--------------------------------
File       : wp-includes/wp-db.php:649
Reason     : TooManyArgument
Snippet    : $this->has_cap('set_charset', $dbh)
Line       : if ( function_exists( 'mysql_set_charset' ) && $this->has_cap( 'set_charset', $dbh ) ) {

--------------------------------
File       : wp-admin/network/site-settings.php:63
Reason     : TooManyArgument
Snippet    : update_option($key, $val, false)
Line       : update_option( $key, $val, false ); // no need to refresh blog details yet

--------------------------------
File       : wp-admin/network/site-settings.php:126
Reason     : TooManyArgument
Snippet    : esc_html(maybe_unserialize($option->option_value), 'single')
Line       : $option->option_value = esc_html( maybe_unserialize( $option->option_value ), 'single' );

--------------------------------
File       : wp-admin/includes/class-wp-comments-list-table.php:318
Reason     : UseVoidReturn
Snippet    : $this->single_row_columns($comment)
Line       : echo $this->single_row_columns( $comment );

--------------------------------
File       : wp-admin/includes/class-wp-list-table.php:829
Reason     : UseVoidReturn
Snippet    : $this->single_row_columns($item)
Line       : echo $this->single_row_columns( $item );

--------------------------------
File       : wp-admin/includes/class-wp-upgrader.php:1132
Reason     : UseVoidReturn
Snippet    : screen_icon()
Line       : echo screen_icon();

--------------------------------
File       : wp-admin/includes/class-wp-posts-list-table.php:386
Reason     : UseVoidReturn
Snippet    : $this->single_row($page, $level)
Line       : echo ""\t"" . $this->single_row( $page, $level );

--------------------------------
File       : wp-admin/includes/class-wp-posts-list-table.php:401
Reason     : UseVoidReturn
Snippet    : $this->single_row($op, 0)
Line       : echo ""\t"" . $this->single_row( $op, 0 );

--------------------------------
File       : wp-admin/includes/class-wp-posts-list-table.php:447
Reason     : UseVoidReturn
Snippet    : $this->single_row($my_parent, $level - $num_parents)
Line       : echo ""\t"" . $this->single_row( $my_parent, $level - $num_parents );

--------------------------------
File       : wp-admin/includes/class-wp-posts-list-table.php:453
Reason     : UseVoidReturn
Snippet    : $this->single_row($page, $level)
Line       : echo ""\t"" . $this->single_row( $page, $level );
}}}"	rlerdorf
24202	Self-explanatory argument values for new media functions		Media	trunk	high	major	3.6	enhancement	new	dev-feedback	2013-04-26T13:14:52Z	2013-05-17T19:43:58Z	"We've introduced a bunch of functions, some with a relatively long list of arguments, which accept booleans:
{{{
function get_content_media( $type, &$content, $html = true, $remove = false, $limit = 0 )
function get_embedded_media( $type, &$content, $remove = false, $limit = 0 )
function get_content_audio( &$content, $html = true, $remove = false )
function get_embedded_audio( &$content, $remove = false )
function get_content_video( &$content, $html = true, $remove = false )
function get_embedded_video( &$content, $remove = false )
function get_content_images( &$content, $html = true, $remove = false, $limit = 0 )
function get_content_image( &$content, $html = true, $remove = false )
function get_content_galleries( &$content, $html = true, $remove = false, $limit = 0 )
function get_post_galleries( $post_id = 0, $html = true )
function get_post_gallery( $post_id = 0, $html = true )
function get_content_chat( &$content, $remove = false )
function get_content_quote( &$content, $remove = false, $replace = '' )
function get_content_url( &$content, $remove = false )
}}}
I wonder if we can convert them to use arrays instead for future-proof changes, or at least switch from booleans to self-explanatory values, per our [http://make.wordpress.org/core/handbook/coding-standards/php/#self-explanatory-flag-values-for-function-arguments coding standards].

Otherwise, we might fall into a trap of `submit_button()`: #20492.
"	SergeyBiryukov
24197	wp_localize_script() doesn't work for jquery handle		General	trunk	normal	major	3.6	defect (bug)	new	dev-feedback	2013-04-25T20:23:59Z	2013-05-22T17:27:12Z	"Here's another odd bug introduced by WP 3.6 latest development version.

I'm using the following code: [http://snippi.com/s/s058ms7]

In WP 3.5.1 everything worked as it should, and wp_localize_script returned the ""icy_ajax"".

Now, in 3.6-beta1-24067 , I get the following error in my console: ReferenceError: icy_ajax is not defined 

Just try and test it and let me know of any solution :-)

"	IcyPixels
24189	{$taxonomy}_relationships cache can easily become stale when a term is updated.		Taxonomy	trunk	high	major	3.6	defect (bug)	new		2013-04-25T11:18:16Z	2013-04-26T02:35:03Z	"The {{{{$taxonomy}_relationships}}} cache stores the information about the terms associated with an object for a particular taxonomy.

If you update the term then we don't invalidate the cache and therefore a call to something like: {{{get_the_terms()}}} will return invalid data.

An example set of steps to reproduce (needs some form of persistent caching like memcache):

 1) Create a new tag and assign it to a post
 2) Use get_the_terms()
 3) Edit the tag to change the description
 4) Use get_the_terms() and find the old description is returned.

Very easy to reproduce in a unit-test.

Re-constituting the relationships cache for every object that is related to the term is probably going to be very expensive.

Maybe we should just switch to only caching IDs and then populating the term data from a different cache?
"	westi
24183	MediaElement.js i18n issues		I18N	trunk	high	normal	3.6	defect (bug)	new	has-patch	2013-04-24T22:54:17Z	2013-04-25T03:18:34Z	"As reported by dimadin in #23282:

> MedaElement.js has very poor i18n support that isn't compatible with one we use in !WordPress since it relies on browser's language to determine locale, and strings are hardcoded in it (see [https://github.com/johndyer/mediaelement/pull/627 pull] that introduced this).
> 
> I looked how to improve this and have it backward compatible and attached patch contains my proposal. Note that this shouldn't go straight to !WordPress since it contains changes to MedaElement.js too. I wanted to hear thoughts from others before submitting pull to MedaElement.js. When they add compatible support, we can patch !WordPress."	SergeyBiryukov
24169	WP_Customize_Manager loads the current user too early		Themes	3.4	normal	major	3.6	defect (bug)	new	has-patch	2013-04-23T21:21:03Z	2013-04-24T17:55:17Z	"When previewing a theme, neither the locale nor the functions.php of either parent/child themes have had the opportunity to load ahead of the current user. This causes theme previews to load without translations in multisite setups where the user chooses their own language, and also means any theme that modifies the current user via actions or filters never has the chance to hook in in time.

The problem is introduced when WP_Customize_Manager prematurely calls is_user_logged_in() and current_user_can() before $wp->init() has fired, on the 'setup_theme' action.

From what I can tell, these specific checks can be moved into a new method, hooked to init, without any consequence. They are only responsible for maybe calling wp_die() where appropriate, meaning any past or subsequent actions or execution are irrelevant anyways.

Patch attached fixes this issue by adding an init() method to the WP_Customize_Manager class, and moves the user checks into this method."	johnjamesjacoby
24162	Add filter hook to get_post_format_meta()	markjaquith	Post Formats	trunk	normal	normal	3.6	enhancement	reopened	has-patch	2013-04-23T04:49:02Z	2013-05-24T19:47:32Z	As per [http://core.trac.wordpress.org/ticket/19570#comment:148 a previous request from Alex King], it would be useful if a filter hook could be added to get_post_format_meta(), particularly for plugin and theme builders looking to reformat the output of post formats for uses like HiDPI image plugins, lazy loading techniques, picture element polyfills, etc. 	stuntbox
24160	ALTERNATE_WP_CRON runs wp_cron() too early		Cron	3.4	normal	normal	3.6	defect (bug)	new	has-patch	2013-04-22T17:48:44Z	2013-05-08T18:47:13Z	"See #19818 for full details.

Then, [https://core.trac.wordpress.org/ticket/19818#comment:8 read my comment in that ticket].

Was advised to create a new ticket."	r-a-y
24159	Chats with spaces in the 'speaker' not parsing correctly		Post Formats	trunk	normal	major	3.6	defect (bug)	new	needs-unit-tests	2013-04-22T17:37:04Z	2013-05-17T22:53:29Z	"Since #23625 is closed and we were asked to make a new ticket, the issue I mentioned still remains.

Related to #23947 - currently this is broken in instances where chat names have spaces.

​http://test.ipstenu.org/testing-1.2013/

That has the post content as follows:


{{{
Nigel Tufnel: The numbers all go to eleven. Look, right across the board, eleven, eleven, eleven and…

Marti DiBergi: Oh, I see. And most amps go up to ten?

Nigel Tufnel: Exactly.

Marti DiBergi: Does that mean it’s louder? Is it any louder?

Nigel Tufnel: Well, it’s one louder, isn’t it? It’s not ten. You see, most blokes, you know, will be playing at ten. You’re on ten here, all the way up, all the way up, all the way up, you’re on ten on your guitar. Where can you go from there? Where?

Marti DiBergi: I don’t know.

Nigel Tufnel: Nowhere. Exactly. What we do is, if we need that extra push over the cliff, you know what we do?

Marti DiBergi: Put it up to eleven.

Nigel Tufnel: Eleven. Exactly. One louder.

Marti DiBergi: Why don’t you just make ten louder and make ten be the top number and make that a little louder?

Nigel Tufnel: These go to eleven.
}}}

But nothing shows.

You can see the exact same issue here: http://twentythirteendemo.wordpress.com/2013/02/10/never-say-never-say-never/

James Bond's lines are never shown."	Ipstenu
24134	Video Shortcode ignores sizes and aspect ratio		Media	trunk	normal	normal	3.6	defect (bug)	new	has-patch	2013-04-19T05:12:23Z	2013-04-24T20:40:12Z	"I think this may be related to #23955

Uploaded video and resized it:


{{{
[video width=""300"" height=""400"" mp4=""http://elfshot.org/wp-content/uploads/sites/3/2013/04/IMG_0328.mp4""][/video]
}}}

Looks fine in the post editor, it's got the right aspects yay.

Then on the live post, the placeholder HTML5 shows sideways (landscape) but when I click play, it shows as full sized to the content.

http://test.ipstenu.org/video-test.2013/ has the example on TwentyThirteen but it happens on all videos on all themes that I've tested. When I viewed source the video tag has the size of the content area, as do media elements.

At revision 24036.

"	Ipstenu
24131	Fix post previews for multisite with domain mapping		Administration		normal	normal	3.6	defect (bug)	new		2013-04-18T22:51:54Z	2013-04-24T02:45:56Z	Currently when previewing latest changes we create a nonce in the admin, then redirect to the front-end and check that nonce on 'init' before showing the preview. This fails sometimes on multisite with domain mapping as they may use JS redirects to log the user in on the front-end.	azaozz
24096	Restore option to change post format in Bulk Edit box		Post Formats	trunk	normal	normal	3.6	enhancement	new	commit	2013-04-16T03:10:40Z	2013-04-24T21:46:08Z	"For a faster change inline - to other format, add this option.

http://media.share.pho.to/1rFYs/7a29bd21_o.png"	alexvorn2
24076	Post Formats: Uploading an unsupported video or audio file type results in a grey box		Media	trunk	normal	normal	3.6	defect (bug)	new		2013-04-13T14:11:53Z	2013-05-15T20:57:52Z	"* Create a new post
* Choose video post format
* Upload a .mov video

Result:

A grey box which size is 1920x1080px. In the upper left is the download link, since mediaelement/HTML5 doesn't support .mov videos.
IMO there should be a notice, which video files are supported."	ocean90
24062	Force gallery state for gallery post format	markjaquith	Post Formats		normal	normal	3.6	defect (bug)	reopened	has-patch	2013-04-12T17:10:57Z	2013-05-19T00:06:51Z	"One of the items uncovered with the [http://make.wordpress.org/ui/2013/04/09/post-formats-usability-test-round-4/ last round of usability tests] was that users don't know that they are not adding a gallery.

When the gallery post format is selected, and the user clicks the ""Add Media"" button, we should take them to the gallery section of the media modal."	lessbloat
24059	All post formats filter to limit which formats a user can choose		Post Formats	trunk	normal	normal	3.6	enhancement	new	commit	2013-04-12T15:39:37Z	2013-05-13T23:56:16Z	Pretty straight forward. This filter allows plugins to limit which formats a user can use based on their role/capabilities.	tlovett1
24056	Revisions: UI a bit unusable when you have ALOT of revisions		Revisions	trunk	highest omg bbq	blocker	3.6	defect (bug)	new	has-patch	2013-04-12T04:35:28Z	2013-05-22T17:25:00Z	"It could be a good idea to limit to last 25 or 50 revisions in the new UI.

I came across an extreme example of this on a WordPress.com site today, where I have something like 130 revisions for the Custom CSS post type. But, this same issue could apply to core post types, though—posts and pages—if the number is high enough.

When I loaded the revisions page, the ""calculating revision diffs"" message rans for a few minutes, and then ""arrow"" to move with was moved way off the screen to the right, creating a horizontal scrollbar.

The next and previous buttons are obscured by the long scrubber timeline graphic.

Screenshot attached."	lancewillett
24055	Videos should be responsive when admin size shrinks		Media	trunk	normal	normal	3.6	enhancement	new		2013-04-11T22:41:25Z	2013-05-22T20:21:10Z		wonderboymusic
24018	Display the post format in the post editing H2 text		Post Formats	trunk	normal	normal	3.6	enhancement	new		2013-04-10T00:00:36Z	2013-05-09T17:43:55Z	"Instead of ""Edit Post"", we should do ""Edit {format} Post""."	markjaquith
24013	"Hide ""Add Media"" for some post formats"	markjaquith	Post Formats	trunk	high	normal	3.6	task (blessed)	reopened	commit	2013-04-09T18:59:25Z	2013-05-19T02:12:27Z	"""Add Media"" doesn't make sense for some post formats. Notably: aside, and status.

We should consider hiding it to simplify the UI for these formats."	markjaquith
24011	"Consider hiding post title for ""Status"" and ""Aside"" formats and autogenerating"		Post Formats	trunk	high	normal	3.6	task (blessed)	new	commit	2013-04-09T18:51:36Z	2013-05-21T18:10:14Z	The status and asides post formats shouldn't have a title. The only reason for having a title is to generate a slug. We should consider hiding the post title for these formats, and auto-generating a title based on the first X chars of the post, P2 style.	markjaquith
23984	Thickbox top margin		Themes	2.8	normal	minor	3.6	defect (bug)	new	has-patch	2013-04-08T07:54:55Z	2013-05-08T00:45:01Z	"The ""theme update details"" popup looks funky, the thickbox titlebar is hidden behind WP's adminbar: http://cl.ly/image/2m27131t3508"	tillkruess
23969	Sometimes when opening the theme customizer, then closing it, the URL gets 'stuck' at /wp-admin/customize.php		Appearance	trunk	normal	normal	3.6	defect (bug)	new		2013-04-06T23:58:26Z	2013-04-16T09:06:40Z	"Just what I said.

If I open the customizer, scroll down a bit, then back up, then click to close it, the URL doesn't change back as it should.

I can then click through to any other page on the admin or front-end, and the URL will still stay as /wp-admin/customize.php

View the bug in action here: http://youtu.be/RbdkudX6yGw"	georgestephanis
23967	Post formats: move color styling to color-*.css		Post Formats	trunk	normal	normal	3.6	defect (bug)	new	has-patch	2013-04-06T21:59:54Z	2013-05-13T18:48:35Z	As the title, there are colors and backgrounds currently in wp-admin.css that should be in the colors css.	azaozz
23930	Screen option for post formats UI		Administration	trunk	normal	normal	3.6	feature request	new	needs-unit-tests	2013-04-03T18:28:10Z	2013-05-14T18:16:58Z	"As discussed in IRC, there should be a screen option for the post format UI on the post editing screen.

Nacin would like the UI to be hidden by default when the current theme does not support post formats and there are no non-standard format posts in the database. In this case, the UI would have to be enabled by the user. The UI would need to be automatically enabled when a theme that supports post formats is activated.

Willing patchers, make yourself known.

See also #23929

IRC logs:

https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2013-02-18&sort=asc#m558297

https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2013-04-03&sort=asc#m588002"	johnbillion
23907	Scandinavian ligatures transcribed wrong in remove_accents()		I18N	trunk	normal	minor	3.6	defect (bug)	new	has-patch	2013-03-30T08:52:56Z	2013-03-30T16:32:08Z	"remove_accents() is transcribing old scandinavian ligatures wrong: ÆØÅøå should be transcribed as 'Ae', 'Oe', 'Aa', 'oe' and 'aa' respectively.

Transcribation rules are the same in swedish, danish and norwegian. In trunk they are transcribed as 'AE', 'O', 'A', 'o', 'a'.

See #4739, #9591 for history."	dnusim
23891	Post Formats: tab accessibility		Accessibility	trunk	normal	critical	3.6	task (blessed)	new		2013-03-29T10:32:49Z	2013-05-14T14:21:38Z	Post Format UI should allow for natural tabbing through the editable fields.	markjaquith
23890	Add slideUP/slideDown transitions to the menus accordion		Appearance	trunk	normal	normal	3.6	enhancement	new	has-patch	2013-03-29T07:54:01Z	2013-05-07T22:45:57Z	"We talked about this early in the cycle in #23119 and other places, but it would be nice to not make switching between accordion sections so jarring. 

A slideUP/slideDown transition similar to how we're handling post formats in #19570 would be a nice UX addition."	DrewAPicture
23863	Post Formats: allow filtering content_width per format in wp-admin		Post Formats		normal	normal	3.6	defect (bug)	new	dev-feedback	2013-03-25T20:55:33Z	2013-04-04T01:10:04Z	"On front-end a theme can filter {{{$content_width}}} like so:

{{{
function twentythirteen_content_width() {
	if ( has_post_format( 'image' ) || has_post_format( 'video' ) ) {
		global $content_width;
		$content_width = 724;
	}
}
add_action( 'init', 'twentythirteen_content_width' );
}}}

But ... functions called in wp-admin that use the global {{{$content_width}}} variable won't be changed.

For example, using trunk and Twenty Thirteen theme:

1. Create a new post, set to Image post format
2. Click Add Media to insert an image
3. Upload an image at least 800 px wide
4. You'll see in ""Attachment Display Settings"" that width for the ""large"" size to insert to the post is 604 pixels and not 724.

Also, even if detecting a Post Format this way worked correctly on edit, it wouldn't work on first post creation because of how the UI uses JS to switch between the formats."	lancewillett
23850	Searchform Format	SergeyBiryukov	Widgets	trunk	normal	normal	3.6	enhancement	reopened	commit	2013-03-22T19:51:03Z	2013-05-10T16:36:05Z	We should use a filter instead of an argument.	WraithKenny
23843	Consolidate and filter get_attached_audio|video|images	helen	Media		normal	normal	3.6	enhancement	reopened	dev-feedback	2013-03-22T07:42:29Z	2013-05-24T19:35:48Z	Seeing as they are so very similar, we should probably just de-spaghetti and consolidate them into `get_attached_media( $type )`. Should also filter the args and the resulting arrays.	helen
23831	Insert Into Post for Audio / Video doesn't always work		Post Formats	trunk	normal	normal	3.6	defect (bug)	new	commit	2013-03-20T20:05:43Z	2013-04-25T23:38:37Z	"As Otto pointed out, ""Link To"" can be set to ""None"" which was sending a broken shortcode to the editor. The HTML sent to the editor should be based on what is selected using ""Link To"" in the Media modal."	wonderboymusic
23817	Collapse menu button not working if browser size is 911px width		Administration		normal	normal	3.6	defect (bug)	new	has-patch	2013-03-19T14:18:37Z	2013-03-29T17:53:22Z	"After I added a metabox to the edit page of the post, from here:

http://codex.wordpress.org/Function_Reference/add_meta_box

the collapse but does not work if the browser size is 911px, need to refresh the page after resize to see the bug.

My browser is Firefox (latest), Windows 7


I use this for browser size check - http://whatsmy.browsersize.com/"	alexvorn2
23811	XML-RPC shouldn't display errors		XML-RPC	3.5.1	normal	normal	3.6	defect (bug)	new	has-patch	2013-03-18T17:35:59Z	2013-05-07T14:15:04Z	"I've got some user reports of XML-RPC returning this:

{{{
<b>Warning</b>
<a href='function.strpos'>function.strpos</a>
<b>
/home/www/simplythreemusic.com/wp-includes/class-wp-xmlrpc-server.php</b>
}}}

In this case, it seems to be #18310, but XML-RPC shouldn't be throwing any warnings, since that makes the client think the request failed when it actually succeeded"	koke
23801	Audio Shortcode: MP3s Display above plain text.		Shortcodes	trunk	normal	normal	3.6	defect (bug)	new		2013-03-17T03:40:30Z	2013-05-16T22:45:40Z	"MP3's render above text and inline elements that have been entered immediately before.

To reproduce, insert the following content using the HTML editor:

{{{
Just some text up here ...
[audio mp3=""http://wp-content/uploads/2013/03/mp3-hello.mp3""][/audio]
}}}

Something similar to the following should be rendered on the front-end:

{{{
<div style=""width: 400px; height: 30px;"" id=""mep_1"" class=""mejs-container svg wp-audio-shortcode mejs-audio"">...</div>
<p>Just some text up here ...<br>
</p>
}}}

I've tested similar content using both OGG and WAV file types. These files are not effected by the bug. Only MP3s seem to render above paragraphs.

This only seems to occur with the shortcode, I've tested a url on it's own line and it displays correctly:

{{{
Just some text up here ...
http://wp-content/uploads/2013/03/mp3-hello.mp3
}}}
"	mfields
23798	Audio Shortcode: Fallback link gets cropped by fixed-height container.		Shortcodes	trunk	normal	normal	3.6	defect (bug)	new	has-patch	2013-03-16T23:26:37Z	2013-04-15T11:39:50Z	"The ""Download File"" fallback for the audio shortcode is hard to read in all of my tests. Here are some screenshots:
 
 * [http://download.mfields.org/screenshot/2013-03-16_1615.png Twenty Ten]
 * [http://download.mfields.org/screenshot/2013-03-16_1614.png Twenty Eleven]
 * [http://download.mfields.org/screenshot/2013-03-16_1601.png Blog Simple]
 * [http://download.mfields.org/screenshot/2013-03-16_1612.png Adventure Journal]

I tested with a WMA file. It appears that the {{{.me-cannotplay}}} element is given a height greater than {{{.wp-audio-shortcode}}}. I've observed this in Both Chrome and Firefox.

A possible solution is to display a simple text link in a paragraph that would inherit style already provided by the theme. This would also ensure that the text is always readable in cases where the user's fontsize is bumped to a large value which would be cut-off by the hardcoded 30px height of {{{.wp-audio-shortcode}}}."	mfields
23779	Can't insert large image if it's smaller than media setting but larger than theme setting		Media	3.0	normal	normal	3.6	defect (bug)	new	has-patch	2013-03-15T00:47:08Z	2013-04-10T14:06:27Z	"If you upload an image that is larger than $content_width but not larger than the ""large"" setting in settings->media, the option to insert a ""large"" image into the post isn't available even though the image is large enough.

It looks like it must use $content_width as the actual width of the large image that's inserted, and the large_size_w setting to decide whether to show that option or not."	aaroncampbell
23761	Empty header color after enabling header text via Customizer		Appearance	3.4	normal	normal	3.6	defect (bug)	new	reporter-feedback	2013-03-13T19:59:14Z	2013-04-10T21:51:25Z	"Background: #23722

1. Go to Appearance > Header, disable header text.
2. Go to Customizer, enable header text.
3. Go to Appearance > Header again. `get_header_textcolor()` will return an empty value.

Bundled themes handle this situation differently:
* Twenty Thirteen shows the header with a wrong color (see the screenshot). 
* Twenty Twelve also has an empty color in the style attribute (as in the screenshot), but it still shows the correct color due to the declaration in `twentytwelve_admin_header_style()`:
 http://core.trac.wordpress.org/browser/tags/3.5.1/wp-content/themes/twentytwelve/inc/custom-header.php#L109
* Twenty Eleven doesn't display the header on Appearance > Header screen at all after those steps, because it specifically checks that `get_header_textcolor()` is not empty:
 http://core.trac.wordpress.org/browser/tags/3.5.1/wp-content/themes/twentyeleven/functions.php#L313

If you disable and re-enable header text on Appearance > Header screen, the correct color will be restored."	SergeyBiryukov
23713	WP 3.5.1 wp-image-editor: Scaling up images does not work		Media		normal	normal	3.6	defect (bug)	reopened	commit	2013-03-07T16:59:57Z	2013-03-28T15:17:58Z	"I can't scale up jpg within wordpress media library, while scaling down works as expected.
A new image file like somename-e1361912486333.jpg is created, but it has exact the same size as the original file.

phpinfo() says I have gd library installed. No imagick.

I already asked in WP Forums for help, with no reaction:
http://wordpress.org/support/topic/wp-351-wp-image-editor-scaling-up-images-does-not-work

"	ullemehner
23706	Image metadata encoding problem		Media	3.0	normal	normal	3.6	defect (bug)	new	needs-unit-tests	2013-03-06T17:05:43Z	2013-03-07T19:09:32Z	"I uploaded picture DSCF4480.jpg (attached for testing).

Metadata for title and caption should be the same: ""Bystřice u Benešova"". But after upload title is right, but caption is damaged:

{{{
'caption' => 'Bystøice u Beneova',
'title' => 'Bystřice u Benešova'
}}}

Using latest trunk."	pavelevap
23697	Check and refresh post locks with heartbeat		Administration		normal	normal	3.6	task (blessed)	new	has-patch	2013-03-05T18:57:10Z	2013-05-20T19:36:30Z	This will change the frequency we check post locks: 15 sec. when the user is active and 2 min. when inactive and add prominent warnings when somebody else is editing or when another user takes over.	azaozz
23688	esc_textarea, wp_richedit_pre and wp_htmledit_pre eat post content under PHP 5.4	westi	Formatting	trunk	high	blocker	3.6	defect (bug)	reopened		2013-03-04T17:27:22Z	2013-04-25T09:51:24Z	"Because of a change in default behaviour in {{{htmlspecialchars}}} in PHP5.4 it is possible for these three functions to eat perfectly valid post content and make it impossible to edit existing posts.

Scenario:
 * blog_charset is ISO-8859-1
 * Post contains some 8bit characters

You try and edit the post and instead of the post content you are presented with a blank editor :(

On the front end the posts display fine.

The underlying cause it this change in {{{htmlspecialchars}}}

""5.4.0 	The default value for the encoding parameter was changed to UTF-8.""

Because the string is not a valid UTF-8 sequence an empty string is returned :(


Related to #20368"	westi
23684	wp-admin CSS style conflicts with jQuery-UI breaking form elements in Firefox		Administration	3.5	normal	normal	3.6	defect (bug)	new	has-patch	2013-03-04T07:10:22Z	2013-05-10T02:09:17Z	"A default CSS style in the wordpress admin interface, which is loaded through load-styles.php either under the name wp-admin or buttons (both of which are inaccessible for removal as they are not listed in the WP_Styles object) interferes with jQuery-ui in such a way that any radio buttons (and possibly other form elements) that are styled with jQuery-ui in the admin interface (such as with a plugin) cause the browser window to jump to the top of the page when clicked. This behavious occurs with the current Wordpress version 3.5.1 using the latest Firefox 19.0 on linux (haven't tested in windows yet). After spending a few hours tracking down the offending code I narrowed it down to this statement in the admin CSS:
{{{
.screen-reader-text,.screen-reader-text span,.ui-helper-hidden-accessible {
position:absolute;
left:-1000em;
top:-1000em;
height:1px;
width:1px;
overflow:hidden;
}
}}}

The .ui-helper-hidden-accessible class is what is causing the conflict, specifically the ""top:-1000em;"" statement; due to the negative positioning values when a button is clicked the browser tries to focus on something styled with the ui-helper-hidden-accessible class, which is of course way outside the limits of the browser window. In order to correct the error I had to override it with the following in another stylesheet declared after load-styles.php:
{{{
.screen-reader-text,.screen-reader-text span,.ui-helper-hidden-accessible {
position:fixed;
left:1em;
top:1em;
height:1px;
width:1px;
overflow:hidden;
display:none;
}
}}}

We should not have to override default styles like this when making plugins, especially when we are using a js library (jQuery-ui) that is included with wordpress. Either the ui-helper-hidden-accessible class needs to be renamed or the negative values removed and replaced with a display:none; statement to fix this bug."	Colin84
23681	jQuery 1.9 doesn't like leading whitespace from wp_ajax_add_menu_item		Menus	trunk	normal	normal	3.6	defect (bug)	new	has-patch	2013-03-04T03:27:30Z	2013-03-04T03:51:57Z	"jquery-migrate logs this message to the console when adding a new menu item:

{{{
JQMIGRATE: $(html) HTML strings must start with '<' character
}}}

Walker_Nav_Menu_Edit returns a <li> indented with two tabs because there's inline HTML in that class and it's indented. jQuery 1.9 rejects HTML strings with leading whitespace [http://blog.jquery.com/2013/01/31/jquery-migrate-1-1-0-released/ for security reasons].

(Note: this is probably why jquery-migrate is calling parseHTML instead of using a regex in #23055)

This patch uses $.parseHTML on the HTML fragment instead of passing it directly to $(). As it's written, $.parseHTML will strip out any scripts in the fragment for security reasons. If you think a plugin might include a script for some reason, the call should be changed to $.parseHTML(menuMarkup, document, true)."	csixty4
23668	Check for empty slug input in register_taxonomy		Taxonomy	3.5.1	normal	normal	3.6	defect (bug)	new	dev-feedback	2013-03-02T18:20:56Z	2013-04-09T10:12:02Z	"If you give an empty string for the `slug` part of the `rewrite` array in a `register_taxonomy` call, like:

{{{
'rewrite' => array(
     'slug' => ''
)
}}}

...you get some wacky permalink issues, even when you flush properly. In my case, I was seeing top-level pages (only) 404 while everything else worked. Removing this admittedly poor part of the code fixed it, but this should be checked for. The `register_post_type` function ensures this isn't empty, and this function should as well."	cliffseal
23665	Create one autosave per user		Autosave		normal	normal	3.6	enhancement	new		2013-03-02T08:19:35Z	2013-04-03T04:37:51Z	"Currently when autosaving drafts we overwrite them, when autosaving published posts, we keep one autosaved revision. This works well as long as there is only one post author.

Having per-user autosaves will affect only sites with many authors/editors. It will avoid overwriting when more than one user edits a post, provide better audit trail, and let us auto save data stored in the browser even if another user is editing at that moment.
"	azaozz
23642	wp_mail() returns true if sending failed		Mail	3.2	normal	minor	3.6	defect (bug)	reopened	commit	2013-02-28T15:54:38Z	2013-05-22T17:41:30Z	"Here: source:/trunk/wp-includes/pluggable.php@23507#L449

The code is:
{{{
	try {
		$phpmailer->Send();
	} catch ( phpmailerException $e ) {
		return false;
	}
	
		return true;
}}}
However, $phpmailer->Send() may return false without throwing an exception. A simple change fixes this like so:
{{{
	try {
		return $phpmailer->Send();
	} catch ( phpmailerException $e ) {
		return false;
	}
}}}"	chmac
23634	New hook for adding content after each comment		Comments		normal	normal	3.6	enhancement	new	punt	2013-02-26T19:29:57Z	2013-05-24T19:32:31Z	"Similar to #18561 (which is for a new ""after post"" hook) add a hook that fires after each comment output with {{{wp_list_comments}}}."	lancewillett
23587	url_to_postid() needs to use # or @ for preg_match start/end character		Rewrite Rules	1.5.2	normal	normal	3.6	defect (bug)	new	has-patch	2013-02-22T19:10:21Z	2013-03-02T21:54:16Z	"[source:/tags/3.5.1/wp-includes/rewrite.php@23479#L344 url_to_postid()] uses ! for the start/end characters of regular expressions, which doesn't allow you to use expressions containing `!`, like `(?!negativelookahead)`.

The solution is to use `preg_match(""#^$match#"", $request_match, $matches)` or `preg_match(""@^$match@"", $request_match, $matches)`


See also: #7486 and [source:/tags/3.5.1/wp-includes/class-wp.php#L204 WP::parse_request()]"	coreygilmore
23567	Duplicate entries in IIS tbex.xml		IIS	3.4	normal	normal	3.6	defect (bug)	new	has-patch	2013-02-20T17:39:15Z	2013-02-22T02:40:16Z	There are duplicate entries in the CodeComplete section of the IIS tbex.xml file. This duplicate code causes an assertion error in WebMatrix when new files are opened.	msopentech
23560	Keyboard Accessibility of Add Media Panel		Accessibility	3.5.1	normal	normal	3.6	defect (bug)	new	has-patch	2013-02-20T14:26:56Z	2013-04-09T23:28:25Z	"Trying to keep this trac specific I'm talking here about keyboard-only interaction with the new Add Media panel once you have opened it by actioning the Add Media link whilst editing a page or a post.

Accessibility Issues:
* The most serious problem with accessibility in the Add Media functionality is that it is not possible to select any of the pre-uploaded media without using a mouse. This will effectively preclude any keyboard only or screen reader users from using this functionality.
* When the Add Media panel first opens it is unclear where keyboard focus sits. This could be disconcerting for some users.
* Reverse tabbing from the panel transfers focus back into the main page whilst leaving the panel open. Recommend that focus is kept cycling within the panel until the user either explicitly closes the Add Media panel or inserts some images.
* It is possible to tab through the text links on the panel(s), but the Upload Files link does not show focus as obviously as other links as there is no outline.
* When tabbing forwards from the Upload Files link there is a tab stop that is not at all visible. Believe this to be Media Library but it's not clear.
* The Insert into Page link can receive focus even when inactive.

Separate trac tickets will be raised to cover the full screen reader and speech recognition software experience."	grahamarmfield
23555	Fatal error when sunrise added		Multisite	3.5.1	low	normal	3.5.2	defect (bug)	new	has-patch	2013-02-20T09:18:07Z	2013-03-18T13:46:48Z	"Hi,

I have installed a WordPress multisite subdomains on a server. I have added a sunrise.php file on the wp-content folder.

In this file there is a $wpdb->prepare without the needed argument at the end. WordPress throw a _doing_it_wrong() but this launch a Fatal error : 

{{{
Fatal error: Call to undefined function __() in /home/site/public_html/wp-includes/functions.php
}}}


{{{

Call Stack:
    0.0001     335660   1. {main}() /home/site/public_html/wp-admin/network/settings.php:0
    0.0001     335964   2. require_once('/home/site/public_html/wp-admin/network/admin.php') /home/site/public_html/wp-admin/network/settings.php:11
    0.0001     336260   3. require_once('/home/site/public_html/wp-admin/admin.php') /home/site/public_html/wp-admin/network/admin.php:13
    0.0002     336564   4. require_once('/home/site/public_html/wp-load.php') /home/site/public_html/wp-admin/admin.php:30
    0.0002     337136   5. require_once('/home/site/public_html/wp-config.php') /home/site/public_html/wp-load.php:29
    0.0002     337500   6. require('/home/site/public_html/wp-config-dev.php') /home/site/public_html/wp-config.php:6
    0.0003     339004   7. require_once('/home/site/public_html/wp-settings.php') /home/site/public_html/wp-config-dev.php:109
    0.0037     791980   8. require('/home/site/public_html/wp-includes/ms-settings.php') /home/site/public_html/wp-settings.php:87
    0.0038     793784   9. include_once('/home/site/public_html/wp-content/sunrise.php') /home/site/public_html/wp-includes/ms-settings.php:18
    0.0039     795552  10. wpdb->prepare() /home/site/public_html/wp-content/sunrise.php:41
    0.0039     795872  11. _doing_it_wrong() /home/site/public_html/wp-includes/wp-db.php:995
}}}

Is this normal that the translations function are not available ?"	Rahe
23533	WordPress doesn't recognize IIS 8.0 (Windows Server 2012) properly		IIS	3.4	normal	major	3.6	defect (bug)	new	has-patch	2013-02-19T16:24:46Z	2013-03-02T20:40:50Z	"WordPress 3.5.1 doesn't recognize IIS 8.0 due to an invalid check in wp-includes/vars.php.

line 99:

{{{
$is_iis7 = $is_IIS && (strpos($_SERVER['SERVER_SOFTWARE'], 'Microsoft-IIS/7.') !== false);
}}}


Now WordPress, hosted on IIS 8.0, can't write a web.config for rewrites.

The check should be extended to include IIS 8.0, and preferably future verions. One more extended check to include IIS 8.0 only, and to patch this bug is:


{{{
$is_iis7 = $is_IIS && (strpos($_SERVER['SERVER_SOFTWARE'], 'Microsoft-IIS/7.') || strpos($_SERVER['SERVER_SOFTWARE'], 'Microsoft-IIS/8.') !== false);
}}}
 
Kind regards,
Jan"	JanR
23503	Post Formats: i18n issues		I18N	trunk	normal	normal	3.6	defect (bug)	new	has-patch	2013-02-18T21:09:13Z	2013-05-19T15:34:02Z	"1. Most of the time, we refer to the ""Standard"" post format with the appropriate context: [[BR]]
 http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/includes/class-wp-posts-list-table.php#L1013 [[BR]]
 http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/press-this.php#L480 [[BR]]
 http://core.trac.wordpress.org/browser/tags/3.5.1/wp-includes/post.php#L5325

 In a couple of places, however, the context is missing: [[BR]]
 http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/includes/meta-boxes.php#L318 [[BR]]
 http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/options-writing.php#L90

2. ~~[23449] introduced Edit screen UI for post formats. There's now a ""Standard"" tab above the post title. In Russian, ""post"" is feminine and ""format"" is masculine, so seeing ""Standard"" adjective without the ""format"" word next to it is confusing. I guess the tab needs a separate context.~~ Fixed in [23843].

3. [23843] introduced a couple of issues:
 1. `ucfirst( sprintf( __( '%s Post' ), $slug ) )`: [[BR]]
  http://core.trac.wordpress.org/browser/trunk/wp-admin/edit-form-advanced.php?rev=23868#L186
  1. `'%s Post'` is not localizable, see [comment:ticket:17609:3 dd32's comment] in #17609.
  2. `ucfirst()` doesn't always work correctly for UTF-8 characters, it depends on PHP locale.
 We should use actual labels instead of just putting post format slugs into a generic string.
 1. i18n is missing in line 397: [[BR]]
 http://core.trac.wordpress.org/browser/trunk/wp-admin/edit-form-advanced.php?rev=23868#L397"	SergeyBiryukov
23472	Retrieve the first x bytes of a remote file		HTTP		normal	normal	3.6	enhancement	new	has-patch	2013-02-14T01:31:02Z	2013-05-16T12:09:48Z	"A commonly useful functionality in HTTP clients is to only request the first x bytes of a document, this can be useful for example, when you only need to fetch the first few KB of a image so as to determine it's dimensions from the initial metadata in the file.

At present, we have no way to offer this through WP_HTTP, The attached patch is a first-scratch effort at adding it. No proper unit tests so far, just casual testing which confirms it working. 

Patch
* Supports all 3 transports
* Handles streaming-to-file as well
* Doesn't include Headers in the byte count
* Works with Redirects

I'll add some Unit tests for this soon hopefully."	dd32
23469	Comment meta query is parsed before the pre_get_comments filter		Comments	3.5	normal	normal	3.6	defect (bug)	new	has-patch	2013-02-13T12:21:26Z	2013-04-08T06:54:07Z	"Currently it is impossible to use the `pre_get_comments` filter to adjust the meta_query, because `parse_query_vars( $this->query_vars )` is run before the filter is applied http://core.trac.wordpress.org/browser/tags/3.5.1/wp-includes/comment.php#L243:

{{{
// Parse meta query
$this->meta_query = new WP_Meta_Query();
$this->meta_query->parse_query_vars( $this->query_vars );

do_action_ref_array( 'pre_get_comments', array( &$this ) );
}}}

Comment meta query should be parsed '''after''' the `pre_get_comments` filter has been applied."	kasparsd
23450	Refactor menu item meta boxes as accordion	markjaquith	Menus	trunk	normal	normal	3.6	task (blessed)	reopened	has-patch	2013-02-11T14:27:58Z	2013-05-14T18:56:41Z	Once #23449 is complete, we are going to refactor the menu items meta boxes on nav-menus.php to reflect the same design as the accordion in the customizer.  We've already [http://core.trac.wordpress.org/ticket/23119#comment:181 prototyped] & [http://make.wordpress.org/ui/2013/02/07/heres-round-7-of-our-menus-usability-tests/ tested] this design on users, and it seems to provide a better UI.	lessbloat
23449	Refactor customizer accordion to work anywhere in admin	markjaquith	Appearance		normal	normal	3.6	defect (bug)	reopened	has-patch	2013-02-11T14:23:41Z	2013-04-02T01:39:54Z	"We'll plan to use the default styles/structure from the customizer accordion for menu item selection options on nav-menus.php.  Currently the code is very customizer specific.  

- The class names should be made more generic.  
- The CSS should be extracted and placed in wp-admin.css
- The JS, should be moved so that you don't have to include the customizer JS elsewhere in the admin to re-use the accordion code."	lessbloat
23433	Custom background select needs a contextualized label		I18N	3.5	normal	minor	3.6	defect (bug)	new	has-patch	2013-02-09T16:55:23Z	2013-02-20T01:11:46Z	"In /themes.php?page=custom-background, the fixed/scroll selector uses the 'Attachment' label.

Problem is, that label name is also used for another type of attachment: files.

Ergo, translators might find themselves with an incorrect wording. In effect, the French translation displays ""Fichier attaché"" (attached file) instead of a more appropriate term.

I suggest turning the string into a contextualized one.

Another solution would be to change the wording altogether, for instance: ""Behaviour when scrolling"", with ""Scroll along"" and ""Keep in place"" as its options.

Hence, I submit both (hopefully correct) patches -- built against trunk for now, but the issue obviously exists in 3.5."	xibe
23418	banned names / illegal_names not being banned		Multisite	3.5.1	normal	normal	3.5.2	defect (bug)	new	has-patch	2013-02-08T04:41:52Z	2013-05-10T16:59:56Z	"new site registrations are ignoring the banned names i add to the list in network options.

out of the gate the default banned names function works and the system does not let me register any of those default names. the illegal_names value in the wp_sitemeta table is populated with: '''''a:7:{i:0;s:3:""www"";i:1;s:3:""web"";i:2;s:4:""root"";i:3;s:5:""admin"";i:4;s:4:""main"";i:5;s:6:""invite"";i:6;s:13:""administrator"";}'''''

when i add '''''seven eight nine''''' to the banned names field of the network setting page and save the page, the banned names field is populated with '''''www web root admin main invite administrator seven eight nine''''', just how you would expect. but now the illegal_names value in the db is '''''a:1:{i:0;s:61:""www web root admin main invite administrator seven eight nine"";}'''''

notice how the serialized array only has one string now instead of the original multiple strings. once it is saved like this users can register any site name including defaults like admin and root plus the new names i added to the list.

my setup: two fresh multisite 3.5.1 installs. one is on a vps and the other on a local xampp install. no plugins activated nor installed. using twenty twelve theme. these are test installs."	dohman
23401	Pass $metadata to intermediate_image_sizes_advanced filter		Post Thumbnails	3.5	normal	normal	3.6	enhancement	new	has-patch	2013-02-06T00:16:17Z	2013-05-24T19:31:10Z	"I'm requesting that the following patch be added, which simply passes the $metadata for the image to be used for the new post thumbnail sizes to any filters hooking the '''intermediate_image_sizes_advanced''' filter in the ''wp_generate_attachment_metadata'' function.

The purpose of this is for altering the size of a custom thumbnail size based on the given image's dimensions.  For example, I have a need for an post image size that's a '''minimum''' dimension size of 200px.  The default behavior will allow me to specify a '''maximum''' dimension size, but not a minimum.
So by hooking this filter, I can alter the '''$sizes''' array and correct the size of my custom post thumbnail size based on the current image's dimensions."	amereservant
23398	"Media Gallery - Clicking ""Restore Original Image"" in ""Scale Image"" pane loses 'Thumbnail Settings' pane."		Media	3.4	normal	normal	3.6	defect (bug)	new	dev-feedback	2013-02-05T21:11:36Z	2013-03-02T17:56:23Z	"Reproduce the problem thusly:

Click ""Edit image"" in the ""Edit Media"" interface for any image.

`/wp-admin/post.php?post=1119&action=edit`

Scale the image a couple times in the 'Scale Image' pane. Update.

Click ""Restore Original Image"" in the 'Scale Image' pane.

Try to crop just the thumbnail.

The 'Thumbnail Settings' Pane is '''''gone'''''.

The image has to be deleted and re-uploaded to gain thumbnail control once again."	gr33nman
23397	Taxonomy Parent Dropdown Concealed		Administration		normal	normal	3.6	defect (bug)	new	has-patch	2013-02-05T18:21:58Z	2013-02-05T19:11:15Z	"When a taxonomy has a really long term, the parent select drop down in the Add New form can be concealed behind the list table.

Normal
[https://dl.dropbox.com/u/2200339/WordPress%20Tickets/TaxSelects/normal.png]

Really Long Taxonomy Item
[https://dl.dropbox.com/u/2200339/WordPress%20Tickets/TaxSelects/really-long-title.png]

Fix
[https://dl.dropbox.com/u/2200339/WordPress%20Tickets/TaxSelects/fixed.png]"	desrosj
23381	update_option() stores unserialized value in object cache		Cache	3.0	normal	normal	3.6	defect (bug)	new	has-patch	2013-02-04T15:03:53Z	2013-02-22T12:11:37Z	"`update_option()` and `add_option()` have inconsistent behaviour when storing items in the cache. `add_option()` stores the serialized version, whereas `update_option()` stores the raw data. When using APC for object caching, this can result in objects being loaded in `wp_load_alloptions()` before the class for it is defined in a plugin.

In `update_option()` (storing raw data):
{{{
	$_newvalue = $newvalue;
	$newvalue = maybe_serialize( $newvalue );

	// ...
			$alloptions[$option] = $_newvalue;
			wp_cache_set( 'alloptions', $alloptions, 'options' );
	}
}}}

Whereas in `add_option()` (storing serialized data):
{{{
	$_value = $value;
	$value = maybe_serialize( $value );

	// ...
			$alloptions[$option] = $value;
			wp_cache_set( 'alloptions', $alloptions, 'options' );
}}}

Example plugin included, breaks horribly when using the APC cache, as that doesn't enforce serialization internally. This only occurs when using `update_option()` on an existing option.

Looks like this was introduced in r13673.

= Steps to reproduce =
  1. Install markjaquith's APC object caching plugin
  2. Activate my plugin. Each refresh will append an object to the array
  3. Note output is:
{{{
array(0) {
}
}}}
  4. Refresh. Note new output is:
{{{
array(1) {
  [0]=>
  object(rmccue_Test_Object)#275 (0) {
  }
}
}}}
  5. Refresh again. Output should be:
{{{
array(2) {
  [0]=>
  object(__PHP_Incomplete_Class)#5 (1) {
    [""__PHP_Incomplete_Class_Name""]=>
    string(18) ""rmccue_Test_Object""
  }
  [1]=>
  object(__PHP_Incomplete_Class)#6 (1) {
    [""__PHP_Incomplete_Class_Name""]=>
    string(18) ""rmccue_Test_Object""
  }
}
}}}"	rmccue
23380	3gp mime support		Media	3.5	normal	minor	3.6	enhancement	new	has-patch	2013-02-04T13:15:09Z	2013-05-23T05:16:29Z	Some devices using 3gp format for wp mobile app.	m_uysl
23362	Fields with HTML5 form validation constraints break post save UI		Validation	3.5	normal	minor	3.6	enhancement	new	has-patch	2013-02-01T22:12:41Z	2013-02-01T22:26:14Z	Consider a metabox added to the edit post screen which includes fields that utilize HTML5 form validation constraints (by supplying a specific `type` attribute or the `required` or `pattern` attributes). Normally upon hitting the Publish or Save Draft button, the buttons go disabled and a spinner appears until the page reloads. However, if any of the metabox input fields violate the HTML5 form validation constraints, then upon hitting a submit button the browser will display the native validation error messages, but the Save Draft and Publish buttons will still go into their disable state and the spinner will appear, even though the `submit` event never fired. This unfortunately discourages the use of HTML5 form validation and forces plugin authors to include a `formnovalidate` attribute on such input fields.  Attached is a patch that allows input fields to use HTML5 form validation constraints and which prevents the UI from going into an an indeterminate/broken state. See attached screenshot for a depiction of the issue.	westonruter
23341	Spell checker in the editor shows languages not supported by google spellchecker like hebrew		I18N	3.5	normal	normal	3.6	defect (bug)	reopened		2013-01-31T13:56:06Z	2013-02-01T05:52:57Z	"The spell checker in the editor uses via tinymce code the google translate service. Problem is that WordPress code assumes that the service supports all languages

{{{
/*
translators: These languages show up in the spellchecker drop-down menu, in the order specified, and with the first
language listed being the default language. They must be comma-separated and take the format of name=code, where name
is the language name (which you may internationalize), and code is a valid ISO 639 language code. Please test the
spellchecker with your values.
*/

$mce_spellchecker_languages = __( 'English=en,Danish=da,Dutch=nl,Finnish=fi,French=fr,German=de,Italian=it,Polish=pl,Portuguese=pt,Spanish=es,Swedish=sv' );

/*
The following filter allows localization scripts to change the languages displayed in the spellchecker's drop-down menu.
By default it uses Google's spellchecker API, but can be configured to use PSpell/ASpell if installed on the server.
The + sign marks the default language. More: http://www.tinymce.com/wiki.php/Plugin:spellchecker.
*/
$mce_spellchecker_languages = apply_filters( 'mce_spellchecker_languages', '+' . $mce_spellchecker_languages );
}}}

But google insist that they support only 12 languages http://support.google.com/toolbar/bin/answer.py?hl=en&answer=32703, therefor not any localization can localize it (ok it can, but it is pointless). The end result for hebrew is that any gibberish text thrown at the spell checker returns as good text.

"	mark-k
23337	TinyMCE, webkit and backspace/linebreak/italic issues		TinyMCE	3.5.1	normal	normal	3.5.2	defect (bug)	new		2013-01-31T08:23:50Z	2013-04-30T08:42:07Z	"On WP 3.5.1 and nightly I notice irregularities in TinyMCE on webkit (Chrome, Safari).

When editing existing paragraphs in TinyMCE visual mode:

- After deleting a paragraph break, it is impossible to insert a single linebreak
- When deleting paragraph breaks, sometimes text will be wrapped in `<em id=""__mceDel"">...</em>`

Steps to reproduce:

1. In a new post, type: ""One[return]two[return]three"" (i.e. three paragraphs)
2. Position the caret before the word ""three"". Hit [delete] to merge paragraphs two and three.
3. Do a shift+return key combo, which should insert a single linebreak. Instead, a paragraph break is inserted.
4. Place the caret before the word ""two"". Hit [delete] to merge paragraphs one and two. The third paragraph is italicised. Viewing the HTML source will show that it has been wrapped in an `em` tag with the id `""__mceDel""`

Expected behaviour:

- After deleting the space between two paragraphs, shirt+return should insert a single linebreak.
- Text should not be italicised without the user having specified for TinyMCE to do so.

I can consistently reproduce this behaviour in Chrome and Safari. Firefox seems to work as expected.

I have tested with a clean install of WP 3.5.1 and the nightly build. I have tested on two different computers.

OS: OS X Lion
Browser: Chrome 24.0.1312.56, Safari 6.0.2"	jnicol
23336	Sticky Posts lack sanity bounding. If used too much, can severely degrade performance.		Query		normal	normal	3.6	defect (bug)	new	reporter-feedback	2013-01-31T05:09:37Z	2013-05-24T18:18:19Z	"Came across an issue where a site was using sticky posts for a slider on the front page. The rest of the front page used custom taxonomy queries. As such, they'd mark items as sticky, have the slider grab the first three. Over years, they accumulated thousands of sticky posts, which, as you can imagine, made the front page of their site absurdly slow, as it was querying those thousands of posts every time.

Should we establish some sort of sanity limit here, to keep people from shooting themselves in the foot? I found this a REALLY hard issue to diagnose. Even with debug bar, there is no indication that sticky posts are being queried. There's just a giant WP_Query call that does a giant `IN()` query.

Something like a limit of 100 with FIFO would keep things from getting too crazy, without restricting people too much. If you have a need for more than that, you need to be using a taxonomy query."	markjaquith
23312	Post Lock Interface for Post List Screen		Autosave		normal	normal	3.6	task (blessed)	new	has-patch	2013-01-29T03:17:36Z	2013-05-16T15:04:13Z	"For 3.6, we'd like to improve the experience for users with post locks!

For the Post List screen, we'd like to:
- Make it easy for users to tell which posts are locked directly from the post list screen.
- Realtime lock update using Heartbeat API (#23216)

Maybe:
- Make it visible which user holds the lock
- Meta editing allowed while post is locked

"	dh-shredder
23299	Definition List in Editor		Editor	2.2	low	minor	3.6	defect (bug)	new	has-patch	2013-01-26T18:38:12Z	2013-01-27T19:13:36Z	After switch from Text to Visual and then from Visual to Text the formatting of the definition list is lost.	gputignano
23295	Improved login expiration warning		Autosave		normal	normal	3.6	task (blessed)	new	has-patch	2013-01-25T22:49:45Z	2013-05-16T03:47:09Z	"The goal here is to improve the user experience when your login has / will expire, as discussed in [http://make.wordpress.org/core/2013/01/07/wordpress-3-6-autosave-and-post-locking/ WordPress 3.6: Autosave and Post Locking] and the [http://make.wordpress.org/core/2013/01/25/agenda-for-todays-autosave-and-post-locking-team/ autosave and post locking team meeting in IRC].

The suggested tactic is to integrate the [https://github.com/Penske-Media-Corp/pmc-post-savior/ PMC Post Savior] plugin into core.  That part should be pretty straightforward.

I think 3 valuable enhancements that are on the plugin's roadmap, but not yet complete would be:
* Alert properly on failed requests and lost connectivity.  If my internet connection has gone down and I'm still working, I should be alerted that I'm ""Working offline"" and my changes aren't being automatically saved.  I don't think this should be a blocking UI, but it should be obvious.
* Block publish/save until login has been verified.  Polling duration can be decreased (or maybe even done away with entirely) if we block the Publish/Save/etc actions until we've verified the user's cookie.
* Pre-emptive notification.  When approaching the user's login cookie expiration time, say 1 hour before, display a message and allow the user to extend their login.  For example, how banking sites notify you when you've been inactive too long and they're about to log you out."	mintindeed
23290	When using switch_to_blog() with a persistent object cache that lacks wp_cache_switch_to_blog() support, non-persistent groups are not maintained		Cache	3.0	normal	normal	3.6	defect (bug)	new	has-patch	2013-01-25T05:28:44Z	2013-03-02T22:00:54Z	If you're using a persistent object cache that lacks the new `wp_cache_switch_to_blog()` support, WordPress core `else`s into a complete cache clobbering branch. It is smart about grabbing the global groups and re-adding those after `wp_cache_init()` is called, but it doesn't do the same for non-persistent groups. Those are a hardcoded array. So if you call `switch_to_blog()`, you would lose any custom-added non-persistent groups.	markjaquith
23284	Wrong parameter order for stripos in wp-includes/functions.php		General	3.5	normal	normal	3.5.2	defect (bug)	new	has-patch	2013-01-24T14:07:22Z	2013-03-03T20:18:42Z	"In wp-includes/functions.php lines 658 and 661 stripos is used two times with parameters in the wrong order.

This would be correct:
{{{
if ( 0 === stripos( $uri, 'http://' ) ) {
}}}


{{{
} elseif ( 0 === stripos( $uri, 'http://' ) ) {
}}}"	Kalindor
23268	NOT EXISTS meta query with OR relation		Query	3.5	normal	normal	3.6	defect (bug)	new	has-patch	2013-01-22T21:14:14Z	2013-05-10T02:10:22Z	"
With this meta query ( which is trying to exclude posts that have the  app_exclude checkbox checked, without excluding posts that don't have it set at all )

{{{
                 $query['meta_query'] = array(
                    'relation' => 'OR',
                    array(
                        'key' => 'app_exclude',
                        'compare' => 'NOT EXISTS'
                    ),
                    array(
                        'key' => 'app_exclude',
                        'compare' => '!=',
                        'value' => '1'
                    ),
                );
}}}

I'd expect / hope to get this sql. 

{{{
SELECT SQL_CALC_FOUND_ROWS
    wp_posts.ID
FROM
    wp_posts
        LEFT JOIN
    wp_postmeta ON (wp_posts.ID = wp_postmeta.post_id AND wp_postmeta.meta_key = 'app_exclude')
        INNER JOIN
    wp_postmeta AS mt1 ON (wp_posts.ID = mt1.post_id)
WHERE
    1 = 1 AND wp_posts.post_type = 'post' AND (wp_posts.post_status = 'publish') AND (wp_postmeta.post_id IS NULL 
    OR (mt1.meta_key = 'app_exclude' AND CAST(mt1.meta_value AS CHAR) != '1'))
GROUP BY wp_posts.ID
ORDER BY wp_posts.post_date DESC
LIMIT 0 , 6

}}}

but I get this SQL 

{{{
SELECT SQL_CALC_FOUND_ROWS
    wp_posts.ID
FROM
    wp_posts
        LEFT JOIN
    wp_postmeta ON (wp_posts.ID = wp_postmeta.post_id AND wp_postmeta.meta_key = 'app_exclude')
        INNER JOIN
    wp_postmeta AS mt1 ON (wp_posts.ID = mt1.post_id)
WHERE
    1 = 1 AND wp_posts.post_type = 'post' AND (wp_posts.post_status = 'publish') 
    AND (wp_postmeta.post_id IS NULL AND (mt1.meta_key = 'app_exclude' AND CAST(mt1.meta_value AS CHAR) != '1'))
GROUP BY wp_posts.ID
ORDER BY wp_posts.post_date DESC
LIMIT 0 , 6

}}}


Note the... (wp_postmeta.post_id IS NULL '''AND''' (mt1.meta_key = 'app_exclude' AND CAST(mt1.meta_value AS CHAR) != '1'))"	timfield
23267	Encoding problem with displaying filenames		Media	3.5	normal	normal	3.6	defect (bug)	new	has-patch	2013-01-22T20:35:10Z	2013-01-23T10:01:02Z	"Reported here: #21217 (first point).

It was repaired, but probably only for older media stuff (pre 3.5). Tested with latest version and there are still problems with displaying filenames. Testing media filename: ""Žluťoučký kůň.png""

- File successfully uploaded as ""Žluťoučký-kůň.png"" (space replaced).

- But filename is displayed as ""luťoučký-kůň.png"".

- URL is ​http://domain/wp-content/uploads/2012/07/Žluťoučký-kůň.png (and file is also accessible on this URL without problem).

Filename is saved right in database, but wrong filename can be seen in Save metabox or in Media modal window."	pavelevap
23254	Empty Page Title Not Handled in Menu System		Menus	3.0	normal	normal	3.6	defect (bug)	new	commit	2013-01-21T20:57:57Z	2013-05-16T02:06:55Z	"I noticed some peculiar menu layouts and sorted it out to having some pages with no titles (not sure the actual use case for a page without a title but it is in my test environments).

The Walker class is recognizing the page exists and creating an appropriate `<a href=...>` wrapper for it but with no Page Title it is not being displayed. If this is by design I think it should be revisited and if this is a defect then the included patch (not very pretty) may offer a possible solution or at least a consideration.

The patch checks if the Page Title is empty and if it is uses the Page ID as the title."	cais
23251	WordPress tries to unnecessarily set the memory limit		General	2.5	normal	normal	3.6	defect (bug)	new	has-patch	2013-01-21T15:25:01Z	2013-04-11T17:10:33Z	"Fixed bug where !WordPress tries to unnecessarily set the memory limit when a value like '2G' is used instead of '2048M'.

See bad code & good code over at Github, which is what you should be using for stuff like this; https://github.com/WordPress/WordPress/pull/26

Discovered by @willem_o and @PeterJaap"	peterjaap
23226	Always use meta caps directly instead of going through the post_type_object->caps array	nacin	Role/Capability		normal	normal	3.6	defect (bug)	assigned	has-patch	2013-01-17T17:14:42Z	2013-02-19T02:53:36Z	"When using post-related meta caps in core, we should use their meta cap name instead of manually digging into the post object looking for the cap.

e.g.

Do this:

{{{
if ( ! current_user_can( 'edit_post', $post_id ) ) {
  // ...
}
}}}

Instead of this:

{{{
$post_type = get_post_type_object( get_post_type( $post_id ) );
if ( ! current_user_can( $post_type->cap->edit_post, $post_id ) ) {
  // ...
}
}}}

Our meta caps resolve custom caps for the meta caps (if someone has been foolish enough to use them), and we should be consistent about doing it that way so people know that's the right way to do it."	markjaquith
23220	Extend autosave to use the browser's local storage in addition to saving to the server		Autosave		normal	normal	3.6	task (blessed)	new		2013-01-16T22:33:43Z	2013-05-15T23:29:06Z	"There are several types of local (DOM) storage in the modern browsers. Most suitable is the `localStorage` as it's persistent and supported in all browsers back to IE8.

The idea is to save the content in local storage every 10 seconds and push to the server every two minutes. When the server responds and there are no errors, we empty the local storage and start again. The local storage will also be emptied when the user saves the post. Then every time the user visits the admin we can check if the local storage is not empty and offer to recover from there or show a revision diff.
"	azaozz
23219	Duplicate enclosure metadata created because of disagreement on meta field formatting		XML-RPC	2.8	normal	normal	3.6	defect (bug)	new	needs-unit-tests	2013-01-16T21:48:42Z	2013-04-29T03:10:09Z	"Years ago I reported an issue in Ticket #7773 that the enclosures would be duplicated each time the post was edited and resubmitted through the XMLRPC API. That bug was fixed in [10383] but a nuance was overlooked that causes this kind of duplication to occur with every edit if the ORIGINAL custom field meta for the enclosure was generated by the automatic content-scraper in WordPress.

If a post with links to ""enclosure"" type files is submitted either through the web interface or through the XMLRPC API, it will automatically generate the insertion of enclosure metadata as a custom field with fragile-structured content of the format:

{{{add_post_meta( $post_ID, 'enclosure', ""$url\n$len\n$mime\n"" );}}}

But the XMLRPC implementation, where the attempt is made to avoid generating duplicates, uses a slightly different fragile template, with no trailing newline:

{{{$encstring = $enclosure['url'] . ""\n"" . $enclosure['length'] . ""\n"" . $enclosure['type'];}}}

To make a long story short: the attempt to detect an existing enclosure on the post always fails because the existing enclosure string has a newline, and the XMLRPC-based one does not.

I propose that this be fixed by at enacting 1 and probably also 2:

1. Make sure duplicate detection method insensitive to trailing whitespace. This will fix the bug in a way that doesn't require retroactively ""fixing"" the existing stored metadata with trailing newline.

2. Change the format of the ""scraped"" enclosure generation to match the format used by XMLRPC. Either with or without the newline would probably be fine, but it seems cleaner to stick with the one that doesn't require a trailing newline, just three blobs of text separated by newlines. It also seems lucky that the last blob is a MIME type and thus would never have a meaningful newline at the trailing end.

I'm attaching a patch that achieves both of these goals. I report this to the XML-RPC component because that's the impact is, even if some of the issue is in the default scraping code from functions.php.

I'm a little less certain about how to tackle a unit test for these cases, but if somebody wants to point me in the right direction I can take a hack at that too.
"	redsweater
23216	"Create ""WP Heartbeat"" API"		Administration		normal	normal	3.6	task (blessed)	new		2013-01-16T20:41:50Z	2013-05-23T13:12:00Z	"The purpose of this API is to simulate bidirectional connection between the browser and the server. Initially it will be used for autosave, post locking and log-in expiration warning while a user is writing or editing.

The idea is to have a relatively simple API that sends XHR requests to the server every 15 seconds and triggers events (or callbacks) on receiving data. Other components would be able to ""hitch a ride"" or get notified about another user's activities.

In the future this can be used to block simultaneous editing of widgets and menus or any other tasks that require regular updates from the server."	azaozz
23205	New Media Uploader slow for sites with many images		Media	3.5	normal	normal	3.6	enhancement	new	dev-feedback	2013-01-15T17:17:02Z	2013-05-17T08:11:21Z	"The new media uploader added in 3.5 looks very nice. Unfortunately, its functionality is worse for sites with thousands of images. I think this can be combated by allowing us to select the ""Upload Files"" page as our default after clicking ""Add Media,"" and rather than ""All Media Items"" be the page it jumps to after the image is uploaded, instead have it jump to ""Uploaded to this Post."" Is there any way the WordPress team can make this default? Or add the option to make it default? It's made posting on my site 10 times more annoying, especially for those posts with 40-50 images. And I'm sure there are others who feel the same."	salromano
23182	Offset error if the first item in an admin menu is a separator		Warnings/Notices	2.7	normal	normal	3.6	defect (bug)	new	has-patch	2013-01-11T18:03:03Z	2013-04-17T02:37:22Z	"There are a few ways you can get to this error, but the easiest way with the default install is:

{{{
add_action( 'admin_menu', create_function( '', 'unset( $GLOBALS[\'menu\'][2] );' ) );
}}}

I originally came across the error assigning the ''manage_sites'' capability to a non super admin role. If you do the same and visit /wp-admin/network/sites.php - you'll see the same error.

If this fix is approved, it raises another minor issue with the network page. There's now an unnecessary separator at the top of the menu. The second patch (network-menu) assigns the same capability requirement to the separator as the dashboard."	phill_brown
23178	"Screen reader shortcut links generated by _render() from WP_Admin_Bar class should use rel=""nofolow"""		Toolbar		normal	normal	3.5.2	defect (bug)	new	has-patch	2013-01-11T13:07:29Z	2013-04-02T12:45:12Z	"Screen reader related links generated by _render() from WP_Admin_Bar class assume toolbar is being shown only to logged in users. When toolbar is being shown to visitors using

{{{
function my_set_current_user() {
    if(!is_user_logged_in()){
        add_filter('show_admin_bar', '__return_true');
    }
}
add_action('set_current_user', 'my_set_current_user');
}}}

search engines report 403 error code on every page of the website when trying to follow wp_logout_url() from one of these links (Logout link). Including rel=""nofollow"" into _render() should avoid this.
"	Marko-M
23155	Fire update_blog_public action from update_blog_status()	ryan	Administration	3.5	normal	normal	3.6	defect (bug)	reopened		2013-01-09T16:43:00Z	2013-05-01T13:12:46Z	The update_blog_public action is fired from update_blog_public() but not from update_blog_status(). Since update_blog_public() calls update_blog_status() the action should move down the stack and reside along the other actions fired by update_blog_status().	ryan
23148	Add hook in wp_ajax_save_attachment for additional attachment fields		Media	3.5	normal	normal	3.6	enhancement	new	has-patch	2013-01-08T19:25:07Z	2013-02-15T21:56:58Z	"As of now, `wp_ajax_save_attachment` only looks for the attachment title, caption, description and alt text fields. Without a hook, there is no way to extend the new media system properly and take advantage of the save functionality. 

There should be a hook provided at the end of this function (before the JSON response is sent back) that allows devs to update any additional attachment fields that have been rendered by extending the `media.view.Attachment.Details` subview."	griffinjt
23136	Do not notify the post author about comments if they are no longer a member of the blog	markjaquith	Comments	3.5	normal	normal	3.6	enhancement	reopened	dev-feedback	2013-01-07T18:45:21Z	2013-04-19T20:08:24Z	wp_notify_postauthor() should not notify the post author of comments if the author is no longer a member of the blog.	ryan
23132	wp_timezone_override_offset() has noticeable performance hit		Date/Time	3.5	normal	minor	3.6	enhancement	new	has-patch	2013-01-06T22:05:19Z	2013-03-03T05:01:15Z	"While wandering through XHProf generated callgraph of my test stack I came upon `wp_timezone_override_offset()` eating 3.4% of runtime (73 calls). I do not expect noticeable resource consumption from such minor configuration-related function.

The obvious performance aspect is that it creates and discards two objects (`DateTime` and `DateTimeZone` - latter seemingly more heavy) per each call, while calculating same result each run.

The less obvious aspect is that the only use of this function is to pre-filter `gmt_offset` option, and it essentially hijacks option cache for it.

Possible solutions:

 - calculate result once per run and cache in static variable inside function (straightforward, but retains multiple function call)
 - filter `gmt_offset` on set rather than get (more involved)
 - scrap the extra function and/or option altogether? is there still practical need for having two options for timezone information?"	Rarst
23044	adjacent_image_link() needs optimization		Query	3.5	normal	major	3.6	enhancement	new		2012-12-22T05:04:20Z	2013-05-21T08:03:07Z	"`adjacent_image_link()` is really slow and stupid. It queries for '''all''' of the images attached to that post. And then it picks the previous or next one in PHP. And there's no caching, so you'll typically get this happening '''three times''' on an attachment page, (image [linked to next], prev link, next link).

We should actually just make the query grab the ONE image we want."	markjaquith
23041	Images Don't Become Attached When Inserting a Gallery		Gallery	3.5	normal	normal	3.6	defect (bug)	new	has-patch	2012-12-21T20:15:21Z	2013-05-24T07:40:16Z	"Steps to Reproduce:

1. Go to the ""Upload New Media"" page (wp-admin/media-new.php)
1. Upload an image.
1. Create a new post.
1. Create an image gallery that includes the newly-uploaded image.
1. Insert the gallery into the post.
1. Publish the post.

Expected result:  Any ""(Unattached)"" image(s) should get attached.

Actual result:  Images remain ""(Unattached)""."	miqrogroove
23033	Decimal and numeric options in meta_query do not produce correct MYSQL for floating point numbers comparisons	wonderboymusic*	Query		normal	normal	3.6	defect (bug)	accepted	dev-feedback	2012-12-21T05:02:10Z	2013-02-08T17:08:47Z	If you have a custom post type (shoes) that has floating point numbers (shoe size) as post meta, querying against this post meta with a specific decimal value ( >10.5 ) does not work properly because of the way the values are cast out of the database, and will produce surprising results.	ericlewis
23025	Review and update readme.html		Text Changes		normal	normal	3.6	defect (bug)	new	has-patch	2012-12-20T18:20:40Z	2013-04-16T02:45:00Z	While this should likely be done more toward the middle or end of the cycle, let's not forget to take a good look at readme.html and its contents.	helen
22985	Edit thumbnail image only - loses all sub sizes in attachment meta	markoheijnen	Media	3.5	high	critical	3.5.1	defect (bug)	assigned	has-patch	2012-12-18T00:52:47Z	2013-02-14T20:04:58Z	"I have several additional image sizes in my theme. When I crop an image and save over only the thumbnail, all references to the various sub-sizes are lost and only the new thumbnail is referenced in _wp_attachment_metadata.

1. Add an image to the media library.
2. Output _wp_attachment_metadata.
3. Edit the image (crop).
4. Save only the thumbnail.
5. Output the relevant _wp_attachment_metadata.

This may be an issue with wp_save_image() not re-genarating subsizes from the original.
I believe this to be different from Ticket #19889  as it appears to remove references to default sizes from media settings screen."	lewismcarey
22975	Remove deprecated jQuery methods from core to be safe for jQuery 1.9		External Libraries		normal	normal	3.6	enhancement	new		2012-12-17T15:47:26Z	2013-05-22T17:26:23Z	"Today [http://blog.jquery.com/2012/12/17/jquery-1-9-beta-1-released/ jQuery 1.9 Beta was released].

> jQuery 1.9 has removed many of the items we deprecated during the last few versions of jQuery. 
> To test, we recommend that you start with the jQuery Migrate plugin since it will warn you about any deprecated features the code may depend on. Just include these two script tags in your code, replacing your existing jQuery script include:
>
> `<script src=""http://code.jquery.com/jquery-1.9.0b1.js""></script>`
>
> `<script src=""http://code.jquery.com/jquery-migrate-1.0.0b1.js""></script>`

The attached patch adds both scripts to core so that you can test it. There are already some notices which we should try to reduce.
"	ocean90
22974	Media manager inaccessible when dragging several images on Safari	azaozz	External Libraries	3.5	normal	normal	3.6	defect (bug)	assigned	reporter-feedback	2012-12-17T13:54:07Z	2013-01-04T22:00:49Z	"Browser: Version 6.0.2 (8536.26.17)

Target: The new media manager

Bug Description: After drag and dropping multiple images on the manager for upload, the manager becomes inaccessible.

Reason: In some cases the uploader-window fails to change display:block to display:none which makes everything on that page unclickable:

    <div class=""uploader-window"" style=""display: block; opacity: 0; "">     <div class=""uploader-window-content""> <h3>Drop files to upload</h3> </div> </div>

Since this is an external jQuery plugin used in Core and related to html5 structure, attached is the fix in the minified versions, as well as a standalone dev new version and the related code itself.

"	mario-siteground
22965	"Change Recent Comments Number Input to type=""number"""	helen	Administration	3.5	normal	normal	3.6	enhancement	assigned	has-patch	2012-12-16T19:52:30Z	2013-03-01T16:31:20Z	"In order to be consistent with the rest of the dashboard, the ""Number of comments to show:"" input field in the Recent Comments widget should be changed to type=""number"" in order to add the up/down arrows. "	mordauk
22952	WP_HTTP can cause PHP Warnings during attempted decompression		HTTP		normal	normal	3.6	enhancement	new	has-patch	2012-12-15T05:13:55Z	2013-01-17T17:24:19Z	"{{{
WARNING: wp-includes/class-http.php:1656 - gzinflate(): data error
}}}

WP_Http_Encoding can cause PHP Warnings when it attempts to decompress data using gzinflate() which has been encoded in any way.
We currently work around this this in a few ways, but we still take a ""try it and see"" method instead of detecting the compressed contents signature and handling it appropriately.

Attached is a first-run patch at detecting Huffman coding, which is what we currently use `@gzinflate( substr( $gzData, 2 ) )` for (and hey, who doesn't like making magic numbers clearer?)

I have been running a similar patch on !WordPress.com and gathering data on how the myriad of different Web Servers out there respond, and so far this causes it to correctly identify the vast majority of responses.

It appears that we may also be attempting to decompress compressed files retrieved through WP_HTTP on some poorly configured servers, but this is something I haven't yet traced properly."	dd32
22935	Horizontal scrollbar in RTL media modal		RTL	3.5	normal	normal	3.6	defect (bug)	new	has-patch	2012-12-14T11:31:22Z	2013-05-11T16:30:59Z	The new media tab needs a few RTL adjustments on the UI, check out the screenshot.	ramiy
22916	Date/time format translations for front-end	nacin	I18N	3.5	normal	normal	3.6	enhancement	assigned		2012-12-13T14:51:25Z	2013-03-01T15:00:29Z	"Hi.

Since the split of mo/po files between admin and front-end contexts, some resources that were useful for the front-end are now available only for admin. One of them is the date/time format: it's really great it's localized in the reading options panel, but the main purpose of the option remains the front-end and the way the dates and times are displayed, so we need the ""translations"" in the front-end po/mo files.

So the request is to switch the following strings from admin to general text domain:
* F j, Y
* g:i a
* F j, Y g:i a

Thanks."	npetetin
22897	RTL on plugin information tab		RTL	3.5	normal	normal	3.6	defect (bug)	new	has-patch	2012-12-12T20:26:28Z	2012-12-15T11:51:32Z	The plugin information tab needs a few adjustments RTL adjustments, check out the screenshot.	ramiy
22895	user_can_admin_menu() is Type-Insensitive for Users who Can't Create Pages		Role/Capability	3.5	normal	normal	3.6	defect (bug)	new		2012-12-12T18:32:53Z	2012-12-29T07:32:41Z	"Utilization of the new separation edit_posts /create_posts capability separation reveals a flaw in admin menu privilege checking.

The issue occurs when:

1. For any post type other the ""post"", the user has $type->cap->edit_posts but not $type->cap->create_posts

2. User also does not have a manage_terms capability for any associated taxonomies

In that situation, access to ""edit.php?post_type=whatever"" fails unless the user has the ""edit_posts"" cap for the ""post"" type.

This occurs because:

1. '''wp-admin/includes/menu.php''' removes solitary submenus that have the same destination as the parent

2. '''get_admin_page_parent()''' returns nullstring if there is no $submenu item

3. '''user_can_access_admin_page()''' performs a type-sensitive capability check only if get_admin_page_parent() returns an existing $submenu key.

For now, my plugin workaround is to hook into 'admin_menu' and add a dummy submenu with nullstring caption. "	kevinB
22839	Toggle spinners by adding/removing a class instead of show()/hide()		Administration	3.4.2	normal	normal	3.6	defect (bug)	new	has-patch	2012-12-09T18:17:02Z	2013-01-24T22:13:37Z	"I've noticed a bug with the spinner while updating a previous submission (ticket:19159). It worked in 3.4 when .ajax-feedback was used instead of .spinner.

Elements with class .spinner don't show up in any .sidebar-name (e.g. Main Sidebar, Inactive Widgets etc.) when an action is in progress (e.g. clearing inactive widgets)."	cdog
22812	Tweak the media modal styles for longer strings in ru_RU		I18N	3.5	normal	normal	3.6	defect (bug)	new	has-patch	2012-12-07T15:38:16Z	2012-12-29T06:53:57Z	"1. In Attachment Display Settings, the Alignment dropdown is a bit off.
2. In Gallery settings, the Random checkbox is misaligned.

See the screenshots."	SergeyBiryukov
22799	Erase Formatting Doesn't erase		TinyMCE	3.4	normal	normal	3.6	defect (bug)	new	has-patch	2012-12-06T23:45:08Z	2013-02-01T16:33:30Z	"In the Content area of a page under the visual test manager of a page if you highlight text click the bold button add italics and cross out. When I I highlight the text and then click the erase format button it only removes the italics and leaves the cross out. 

On two other builds I have tested this problem with it turns the text red? 

Have tested on two local installs. (one clean to test this issue) and one external install. All using Trunk all the same issue. See screenshot for visual reference.

http://cl.ly/image/1Y1I1H2u471E  "	RDall
22692	Quotes Are Messing Up		Formatting	3.4.2	normal	normal	3.6	defect (bug)	new	needs-unit-tests	2012-12-03T09:39:36Z	2013-04-21T18:57:27Z	"Paste this into the body of a new post:

{{{
A sentence.  ""A quote after 2 spaces.""
}}}

Preview that, and be amazed.  The first quote is backwards.  :(

Due to font differences, this is easiest to see on the Twenty Ten theme."	miqrogroove
22623	Some string tweaks - duplicity, context, mistake		I18N	3.0	normal	normal	3.6	defect (bug)	new		2012-11-28T20:56:41Z	2013-01-16T00:03:41Z	"1) String ""Path"" has a little different meaning for TinyMCE (HTML position) and Multisite list sites column (subdirectory address). Can we have a context?

2) When you click ""Deactivate"" action link bellow any site (in Multisite admin), site is marked as ""Deleted"" instead of ""Deactivated""? You can ""Activate"" deleted site? Strange...

3) We have strings ""No results found."" (twice) and ""No matches found."" One string would be better instead of three similar strings?

4) String ""Show header text with your image."" is not accurate. You can show header text without header image."	pavelevap
22501	class-wp-upgrader.php is using the wrong theme directory		Upgrade/Install	2.9	normal	normal	3.6	defect (bug)	new	has-patch	2012-11-19T04:15:57Z	2013-01-04T10:29:36Z	"There are multiple places in `class-wp-upgrader.php` with a hard coded path to `WP_CONTENT_DIR . '/themes'`. Upgrades will fail if the theme directory is actually in another place.

If there is still a `wp-content/themes` directory, the theme will be installed into that, but the old theme is used and the upgrade nag doesn’t go away.

If there is no such directory the upgrader dies with an error.

In both cases the user is stuck with an outdated theme and no ability to the new one.

Test plugin to reproduce this bug:


{{{
<?php
/* Plugin Name: Local Theme Roots */

add_filter( 'theme_root_uri', 't5_switch_theme_root' );
add_filter( 'theme_root',     't5_switch_theme_root' );

/**
 * Create a custom theme directory.
 *
 * @wp-hook theme_root
 * @wp-hook theme_root_uri
 * @author  Thomas Scholz, http://toscho.de
 * @param   string $in URL or path
 * @return  string
 */
function t5_switch_theme_root( $in )
{
	if ( 'theme_root_uri' === current_filter() )
		return 'http://trunk-themes.wp';

	// If we made it so far we are in the 'theme_root' filter.
	$new_root = 'F:\wp.trunk.themes';
	register_theme_directory( $new_root );
	return $new_root;
}
}}}


The solution is to use `get_theme_root()` instead of a fixed path.

The attached patch does exactly that. Tested on latest Trunk."	toscho
22476	Standardize single and double quotes in CSS url()s		Administration		low	trivial	3.6	enhancement	new	has-patch	2012-11-16T17:26:05Z	2013-04-10T19:48:14Z	"As per http://www.w3.org/TR/CSS2/syndata.html#value-def-uri (and other locations), single quotes {{{'}}} and double quotes {{{""}}} in {{{url()}}} values in CSS like
{{{
body { background: url(""../img/image,gif"");
}}}
are optional. Most of core's CSS is already written without such quotes. The patch 22476-remove-quotes-in-url.diff removes the remaining ones, for consistency and to save us some bytes again, even in the minified CSS."	TobiasBg
22277	Admin (not just superadmin) should be able to add user without confirmation email in multisite		Multisite	3.4.2	normal	normal	3.6	defect (bug)	new	commit	2012-10-25T18:04:19Z	2013-05-02T00:48:36Z	I don't know why admins would be restricted from adding existing users without sending them a confirmation, but they are in multisite. You have to be a superadmin to get that option. I think that is lame, and would like to see admins have that admin option. Is there is a reason why it is that way (security etc)? Since neither @markjaquith nor I could remember a reason, making this ticket and hoping we fix it. 	jane
22160	Etags served by ms-files.php not specific enough		Multisite	3.3.2	normal	normal	3.6	defect (bug)	new	has-patch	2012-10-10T23:15:01Z	2012-12-29T22:23:12Z	"Today I was tracking an Etag issue we had where different versions of images uploaded to wordpress had the same etags. I first looked at apache and reconfigured it to serve filesize mtime etags. To no avail.
When investigating further i discovered that uploaded files get an etag from ms-files.php (line 57)

{{{
$etag = '""' . md5( $last_modified ) . '""';
}}}

which to my humble opinion should be something like:

{{{
$etag = '""' . md5( $last_modified . filesize($file)) . '""';
}}}

that way, images of different formats, created at upload time, which share the same mtime on a fast machine still get different etags."	xiffy
22134	"Update Network causes ""WordPress database error Table 'wp_signups' already exists for query"""		Database		normal	normal	3.6	defect (bug)	new	has-patch	2012-10-08T20:58:37Z	2013-04-19T10:54:17Z	The CREATE TABLE statements in wp-admin/includes/schema.php don't use IF NOT EXISTS so they create lots of SQL errors every time you update the network.	tomdxw
22096	IN meta_query with empty array as meta_value results in invalid database query	wonderboymusic*	Query	3.1.3	normal	normal	3.6	defect (bug)	accepted	has-patch	2012-10-04T13:56:54Z	2013-04-29T09:06:36Z	"If you do an {{{IN}}} meta_query and pass in an empty array to the {{{value}}}, the {{{INNER JOIN}}} clause for the postmeta table isn't added, which results in an invalid query:

{{{
new WP_Query( array(
       'meta_query' => array( array( 'key' => 'abc', 'value' => array(), 'compare' => 'IN' ) )
) );
}}}

This results in an error like so:

{{{
WordPress database error: [Unknown column 'wp_postmeta.meta_key' in 'where clause']
SELECT SQL_CALC_FOUND_ROWS wp_posts.ID FROM wp_posts WHERE 1=1 AND wp_posts.post_type = 'post' AND (wp_posts.post_status = 'publish' OR wp_posts.post_status = 'private') AND (wp_postmeta.meta_key = 'abc' ) GROUP BY wp_posts.ID ORDER BY wp_posts.post_date DESC LIMIT 0, 5
}}}"	batmoo
22030	"After ""clear background-color"" in design options, still css is added to html-output"		Appearance	3.4.2	normal	normal	3.6	defect (bug)	reopened	commit	2012-09-28T08:45:20Z	2013-04-22T19:12:19Z	"After you select ""clear background-color"" in design options, the default color still is added as inline css to html-output of frontend.

Tested with 3.4.2 and Twenty Twelve 1.0 theme

Steps to reproduce:

1. Look at default html-output, no inline css for background-color
2. Design -> Background -> Color, select e.g. color #123456, save
3. Look at html-output, this is added:

{{{
<style type=""text/css"" id=""custom-background-css"">
body.custom-background { background-color: #123456; }
</style>
}}}

4. Design -> Background -> Color -> Click ""clear"" option, save
5. Look at html-output, this is added with default value:

{{{
<style type=""text/css"" id=""custom-background-css"">
body.custom-background { background-color: #e6e6e6; }
</style>
}}}


Expected behaviour: After ""clear"" option is used and default value #e6e6e6 (or only a #) is shown in backend, no inline css should be included in html output of frontend.
"	Ov3rfly
21974	esc_url() doesn't allow protocol-relative URLs with colons		Formatting		normal	normal	3.6	defect (bug)	new	has-patch	2012-09-23T00:58:25Z	2013-04-10T18:15:42Z	"This doesn't work:
{{{
wp_enqueue_style( 'twentytwelve-fonts', ""//fonts.googleapis.com/css?family=Open+Sans:400italic,700italic,400,700"", array(), null );
}}}
The colon is the culprit. `wp_kses_bad_protocol()` reduces the URL to:
{{{
400italic,700italic,400,700
}}}
So `esc_url()` returns an empty string: [[BR]]
http://core.trac.wordpress.org/browser/tags/3.4.2/wp-includes/formatting.php#L2572"	SergeyBiryukov
21970	404 error when a post has the same slug as with a deleted (trash) page.		Permalinks	3.4.2	normal	normal	3.6	defect (bug)	new	needs-unit-tests	2012-09-22T20:25:04Z	2013-04-23T20:14:25Z	"I don't know if this is a bug/issue but I'll share this anyway.

A user creates a new '''Page''', for example, with a title ""New Garden"". But decides to delete it/""Move to Trash"" without deleting it permanently. Then creates a new '''Post''' with the same title ""New Garden"". Viewing that post will result to a ""404"" page not found."	janintia
21795	Menu collapse option not saved correctly		Administration	3.5	normal	normal	3.6	defect (bug)	reopened	reporter-feedback	2012-09-04T23:39:17Z	2013-04-08T01:00:54Z	"The menu collapse option is not saving correctly when at a resolution > 900px. When collapsing and them re-expanding the menu, the menu auto collapses on each new page load. It's caused by the script deleting the folded setting but not actually setting the unfolded setting as far as I can tell.

The attached patch works for me."	griffinjt
21787	While editing post, View Post link disappears if post status gets set to anything other than 'publish'		Editor		normal	normal	3.6	defect (bug)	new	has-patch	2012-09-04T10:00:54Z	2013-01-14T11:11:27Z	"To reproduce, edit a post and change the Visibility to private. You'll notice the 'View Post' link next to the slug editor disappear. 

I would suggest that we match the interface here with the way the 'View Post' link works in the admin bar: check read_post cap for the user against the post, and display accordingly. "	ericlewis
21682	Rewrite endpoints are lost if a custom category or tag base is defined		Rewrite Rules	3.4.1	normal	normal	3.6	defect (bug)	new	dev-feedback	2012-08-24T15:57:04Z	2013-02-08T14:19:31Z	"== Problem ==

So this little bug was winding me up for a while.

The standard approach according to the codex for adding rewrite endpoints is to call the `add_rewrite_endpoint()` function within the init hook. So far so good.

The problem occurs whenever `WP_Rewrite::init()` is called ''after'' the init hook. It resets the endpoints array and so when rewrite rules are subsequently generated through the options-permalink.php admin page the rewrite rules are unknown to the system and hence don't work.

`WP_Rewrite::init()` is called within `WP_Rewrite::set_category_base()`, `WP_Rewrite::set_tag_base()` and `WP_Rewrite::set_permalink_structure()`.

In the latter it is only called if the permalink structure has changed so on first save of a change endpoints are lost. In the other 2 it is called every time if the slug doesn't match the default so rewrites are always lost.


== Solutions: ==

1. add an action hook to the start of `WP_Rewrite::rewrite_rules()` where endpoints should be added
2. store the endpoints at the start of `WP_Rewrite::init()` and restore them at the end
3. don't reset them at all

I think solution 3 would make sense, the endpoints could be defaulted to an empty array and I can't see any reason to want to reset them anyway.

I've attached a simple patch that works (for me at least).

'''NB.''' this problem may also affect the `$extra_rules` and `$non_wp_rules` but I haven't tested that theory yet."	sanchothefat
21334	Accessibility of Quick Edit panel in Posts/Pages/etc		Accessibility	3.4.1	normal	normal	3.6	defect (bug)	new	has-patch	2012-07-21T06:46:51Z	2013-05-09T14:36:57Z	"Two issues here:

1) When someone using mouse hovers over a page/post row in main Pages/Posts screen - the 'quick links' appear. However these links will never appear when a user is tabbing around the screens - perhaps a blind user with screen reader or someone who is unable to use a mouse.

Please can the 'quick links' panel be opened when someone tabs to the page/post title and stay open so that they can then tab into the links provided.

2) Using Quick Edit. 

When the Quick Edit panel is open the input fields in there are all nicely accessible except for the date and time grouping. These input fields have a tabindex value set (unlike the surrounding input fields) which removes them far from the natural sensible tab order within this panel. Suggest the tabindex values are removed.

Also, none of the date and time input fields have labels so their meaning is unclear - certainly to blind users but also potentially to people with cognitive impairments too. Please can this be rectified.

Thanks"	grahamarmfield
21272	reporting typo in dbDelta		Database	3.4.1	normal	minor	3.6	defect (bug)	new	has-patch	2012-07-14T14:45:25Z	2013-01-08T07:05:05Z	"In dbDelta, there is the section:


{{{
                // For every remaining index specified for the table
                foreach ( (array) $indices as $index ) {
                        // Push a query line into $cqueries that adds the index to that table
                        $cqueries[] = ""ALTER TABLE {$table} ADD $index"";
                        $for_update[$table.'.'.$fieldname] = 'Added index '.$table.' '.$index;
                }
}}}

Note that $for_update is updated with the wrong array index.  This causes some updates not to be returned in $for_update.  Better would be:

{{{
                        $for_update[$table.'.'.$index] = 'Added index '.$table.' '.$index;
}}}

Even this is not really right, since indexes and columns may have the same names.  Given that the users of dbDelta don't even seem to care about the keys, it might be simpler just to change all the $for_update lines to

{{{
                        $for_update[] = ...
}}}

except for the first one that must be keyed on table name."	apimlott
21241	Default value for background_image_thumb fails when background_image URL includes a percent sign		Appearance	3.4.1	normal	minor	3.6	defect (bug)	reopened	has-patch	2012-07-12T16:49:14Z	2013-01-17T04:14:38Z	"If the background_image theme mod is set to a URL that includes a percent sign, and if background_image_thumb is not set, the code that uses background_image as the default setting for background_image_thumb fails due to get_theme_mod interpreting the percent signs in the background_image URL as sprintf conversion specifications.

I don't think that this situation can occur in a vanilla WordPress install (but that might be host-specific), but it's entirely possible that a plugin would set background_image to a URL including a percent sign."	cfinke
21213	Underscores get stripped out in $type ( get_query_template() )		Template	2.5	normal	normal	3.6	defect (bug)	new	has-patch	2012-07-11T05:29:37Z	2013-05-10T13:21:59Z	"What happens is:

{{{
$type = preg_replace( '|[^a-z0-9-]+|', '', $type );
}}}

strips underscore. Effectively, incoming ""front_page"" becomes frontpage, which leads to not working (but documented) hook front_page_template.

I tested this on: nginx 1.2.1/php-fpm 5.4.3 (homebrew macos) and nginx 1.0/php-fpm 5.3.3 with the latest revision ATM

The fix is as simple as 
{{{
$type = preg_replace( '|[^a-z0-9-_]+|', '', $type );
}}}

Patch is attached."	rinatkhaziev
20839	"""Visit plugin site"" should open in a new window"	helen	Administration	3.4	normal	minor	3.6	enhancement	reopened	close	2012-06-04T20:13:05Z	2013-05-05T05:56:44Z	It's weird to take users off the site when they click on this link in the plugins section. Just a little thing to make the experience that much better :)	empireoflight
20633	wp-includes/comment.php:738 - Undefined property: WP_Query::$comments		Warnings/Notices	3.3.2	normal	normal	3.6	defect (bug)	new	dev-feedback	2012-05-07T20:50:33Z	2013-03-15T09:29:29Z	{{{get_comment_pages_count()}}} can throw a notice. We use {{{$wp_query->comments}}} without checking it first.	markjaquith
20294	User profile edit: no label on second password field		Accessibility		normal	normal	3.6	defect (bug)	new	has-patch	2012-03-24T13:08:23Z	2013-05-05T05:35:32Z	"When editing a User profile in admin, there are 2 fields for password, the second one asking to ""Type your new password again"".

This second field has neither a {{{label}}} element nor a {{{title}}} attribute associated to it.[[BR]]
The first field has a label, the one in the {{{th}}} element: ""New Password"", correctly associated to the input via its for attribute (e.g. {{{for=""pass1""}}} when the input field has an {{{id=""pass1""}}}).

Any form field should have an associated label (or at least a title) per WCAG 2.0, see the Technique ''[http://www.w3.org/TR/WCAG-TECHS/H44.html H44: Using label elements to associate text labels with form controls]''. This helps screenreader and other assistive technologies users to understand without a doubt what is the role of each form field, improving the accessibility of the admin and thus ATAG and WCAG compliance of WordPress).

A simple solution would be to use the existing hint ""Type your new password again."" (right after the second password field) as its associated label.[[BR]]
{{{span.description}}} thus becomes:

{{{
<label class=""description""><?php _e(""Type your new password again.""); ?></label>
}}}

This new label isn't styled in italic anymore (because the applied selector is ''span.description'') so, in {{{wp-admin/css/wp-admin.dev.css}}}, one should also add {{{label.description}}} to the existing selector rule and to the one at the end of the same CSS file that removes italic for zh_CN localization.

Related ticket: [http://core.trac.wordpress.org/ticket/9445 #9445] ''(All Input Tags are not Section 508 Compliance)''"	PhilippeVay
20205	Add the ability to filter wp_get_attachment_image()		Media	3.4	normal	normal	3.6	enhancement	new	dev-feedback	2012-03-08T20:21:16Z	2013-02-19T18:38:38Z	"i'm working on a plugin that lets users define any image to serve as the thumbnail for any PDF document.  I'm storing the ID of the image as post_meta for the PDF attachment.  Instead of showing the default icon with wp_get_attachment_image() I'm quite close to being able to do this by filtering image_downsize.

the trouble is that the image_downsize filter it run ''after''


{{{
if ( !wp_attachment_is_image($id) )
		return false;

}}}

so the PDF image fails the test and I never have a chance to run my filter.  

"	helgatheviking
20201	wp.Options lies about the updatability of options.	westi	XML-RPC	3.4	low	normal	3.6	defect (bug)	new	dev-feedback	2012-03-08T12:04:08Z	2013-05-07T12:44:07Z	"When an XMLRPC client calls this API we give it a `readonly` status for each of the options returned which lets it know whether or not the options are writable or not.

This status is hardcoded in the code and not capability aware so a user with only subscriber level access is given the impression that they can update options they can't."	westi
20101	Can't use 'show_admin_bar' filter with conditional tags	nacin	Toolbar		normal	normal	3.6	defect (bug)	reopened	commit	2012-02-22T19:10:11Z	2013-04-22T22:10:49Z	"I'm trying to show the admin bar only on the front page:

{{{
function scribu_show_admin_bar() {
  return is_front_page();
}

add_filter( 'show_admin_bar', 'scribu_show_admin_bar' );
}}}

However, this doesn't work because '_wp_admin_bar_init' is called on 'init', before the main WP_Query is set up."	scribu
19889	Image Editor doesn't apply changes to custom image sizes		Media	3.3.1	normal	normal	3.6	defect (bug)	reopened	has-patch	2012-01-24T19:48:53Z	2013-05-21T15:54:15Z	"The built in image editor doesn't apply changes like cropping, rotation, etc. to image sizes added using add_image_size or similar methods.

This is because the code in image-edit.php is directly looking for the image sizes in the options table, which only valid for the built-in sizes, not for custom image sizes.

Specifically, in the wp_save_image function in image-edit.php, this code is incorrect:

{{{
$crop = $nocrop ? false : get_option(""{$size}_crop"");
$resized = image_make_intermediate_size($new_path, get_option(""{$size}_size_w""), get_option(""{$size}_size_h""), $crop );
}}}

The fix to this is to make the wp_save_image function aware of custom sizes in the $_wp_additional_image_sizes global, and to use the options data as a fallback (for the built in sizes).

Patch for trunk attached. Tested on trunk install with no obvious side effects. Patched version correctly creates the custom image sizes with the applied editing changes, and deletes them properly when the image is deleted in the admin. Meta data thus created looks correct as well.
"	Otto42
19856	wp_get_referer() doesn't return false when the referer URL is the same as the current URL		General	3.3.1	normal	normal	3.6	defect (bug)	new	has-patch	2012-01-19T08:08:53Z	2013-05-10T03:59:27Z	"Inside wp_get_referer(), there's this conditional statement:

`if ( $ref && $ref !== $_SERVER['REQUEST_URI'] )`

It is there to ensure that wp_get_referer() doesn't return the same page I'm on. This is useful when redirecting because I can detect and avoid infinite redirection.

According to PHP documentation, `$_SERVER['REQUEST_URI']` is only the URI on the host. As a result, the conditional statement above fails in this case:

Let's say I was redirected from http://example.com/sample-uri to itself (either by clicking a link or a form submission). Then:

{{{
$ref = 'http://example.com/sample-uri';
$_SERVER['REQUEST_URI'] = '/sample-uri';
}}}

So technically, the referrer is the same page, but wp_get_referer() doesn't return false as expected, because `$ref !== $_SERVER['REQUEST_URI']`.

A better conditional statement would be:

`if ( $ref && parse_url( $ref, PHP_URL_PATH ) !== $_SERVER['REQUEST_URI']  )`

Patch attached.

I'm using PHP 5.3.6, Apache 2.2.20."	garyc40
19847	wp_mail $from_name field is removing an extra character from the name		General	3.3.1	normal	normal	3.6	defect (bug)	new	dev-feedback	2012-01-17T05:13:18Z	2013-05-05T09:21:28Z	"If the headers are sent as a string to wp_mail, parsing of $from_name field removes one required character at the end of the name. Hence causing a name field of ""Hakan"" to show up as ""Haka"" in the received email.

Line 257 of pluggable.php is causing this error.

$from_name = substr( $content, 0, strpos( $content, '<' ) - 1 );

Removing ""-1"" from substr function call solves the problem.

$from_name = substr( $content, 0, strpos( $content, '<' ));

"	hakanca
19744	Custom post types doesn't receive pingbacks - url_to_postid() doesn't recognize CPT	wonderboymusic*	Query	3.3.1	normal	normal	3.6	defect (bug)	accepted	has-patch	2012-01-05T00:22:45Z	2013-05-12T02:45:25Z	"It seams like custom post type doesn't receive pingbacks. The XML-RPC server doesn't recognize the URL. The url_to_postid() function in rewrite.php finds a match, but the query is all wrong.

Example, if I set up custom post type with no ""rewrite"" in the arguments. 
The URL to a custom post type would be: mydomain.com/custom_post_type_name/post-slug/

The function url_to_postid() finds a match on: 
{{{
custom_post_type_name/([^/]+)(/[0-9]+)?/?$
}}}
The query is: 
{{{
custom_post_type_name=$matches[1]&page=$matches[2]
}}}

But the query string (after WP_MatchesMapRegexp::apply()) looks like this:
{{{
custom_post_type_name=post-slug&page=
}}}

And the array that is sent into WP_Query looks like this:
{{{
Array
(
    [tips_and_trix] => finns-sjukt-manga-tips-har
    [page] => 
)
}}}

Which makes url_to_postid() return 0; And XML-RCP server returns IXR_Error(33, ...)"	feedmeastraycat
18857	get_plugin_page_hookname uses menu_title to construct subpage load-hooks		Plugins	3.1.4	normal	normal	3.6	defect (bug)	new	has-patch	2011-10-04T15:16:33Z	2013-05-07T22:29:47Z	"The load-hook for PluginSubPages isn't working anymore if the PluginPage is translated.

The reason seems to be that the get_plugin_page_hookname function uses the menu_title instead of the menu_slug to create the hookname.

I attached a possible fix."	apocalip
18709	Hooks in user-new.php		Administration	3.2.1	normal	normal	3.6	enhancement	new	has-patch	2011-09-19T21:06:16Z	2013-05-24T18:32:28Z	"It would be nice to be able to enter extra metadata for users when manually creating them from the admin control panel. 

I assume it should be as simple as adding a new action, along the lines of the edit_user_profile_update one? 


"	standardtoaster
18650	Make archives and categories widgets dropdown ada compliant		Accessibility	3.2.1	normal	major	3.6	enhancement	new	dev-feedback	2011-09-13T00:12:37Z	2013-05-22T21:00:44Z	"Conditionally add the <label> tag for the archives and categories widgets so they are ada compliant.

http://webaim.org/techniques/forms/controls"	jlevandowski
18584	Nav menu UI needs more hooks		Menus	3.3	low	minor	3.6	enhancement	new	has-patch	2011-09-04T02:38:16Z	2013-04-16T15:29:35Z	"I'm trying to add some additional fields to the nav menu blocks but sadly there are no hooks for doing so. Zero.

We should add some and get in a better habit of just doing so when the code is written.

My specific suggestions are before the Remove/Cancel links (i.e. for adding standard stuff), one above the ""original"" field, and one after those action links (to add more actions)."	Viper007Bond
18402	Confused page ordering if filter drops parent pages	nacin	Administration	3.2.1	normal	normal	3.6	defect (bug)	reviewing	dev-feedback	2011-08-14T15:34:07Z	2013-05-05T05:01:40Z	"= Problem =
In Wordpress's page management section, the page ordering is confused if a page filter drops a page parent.

Originally, I experienced this with the User Access Manager Plugin:
http://wordpress.org/extend/plugins/user-access-manager/
This plugin only shows allowed pages to the user.


= Example =
{{{
Page A
- Page A1
-- Page A1.1
-- Page A1.2
}}}

By dropping page A, the ordering becomes for example:

{{{
-- Page A1.1: Parent Page is Page A1
-- Page A1.2: Parent Page is Page A1
- Page A1: Parent Page is A
}}}

But should become:

{{{
Page A1: Parent Page is A
-- Page A1.1
-- Page A1.2
}}}

= Solution =
The confusion results from the function `_display_rows_hierarchical`
in `wp-admin/includes/class-wp-posts-list-table.php` which only adds pages to $top_level_pages whose parent is 0 – the wrong assumption here.

By adding pages to $top_level_pages whose parent is either 0 or doesn't exist in $pages we get a usable order:
So I added to the above-mentioned file:

{{{
#!php
function is_parent_in_pages( $parent, $pages ) {    
    foreach ( $pages as $page ) {
        if ( $page->ID == $parent ) return true;
    }
    return false;
}  
}}}

and changed `_display_rows_hierarchical`
from

{{{
#!php
if ( 0 == $page->post_parent )
    $top_level_pages[] = $page;
else 
    $children_pages[ $page->post_parent ][] = $page;
}}}

to

{{{
#!php
if ( 0 == $page->post_parent || !$this->is_parent_in_pages( $page->post_parent, $pages ))
    $top_level_pages[] = $page;
else
    $children_pages[ $page->post_parent ][] = $page;
}}}


And finally - in order to remove the leading dash of $top_level_pages - I removed
the $level++ in function `single_row` (same file) below ""`case 'title':`""


Small change, better user experience :)





"	erdnah
18310	Attachments inserted with NULL value for GUID		XML-RPC	3.2.1	normal	normal	3.6	defect (bug)	new	dev-feedback	2011-08-01T13:30:01Z	2013-05-07T14:08:16Z	"This is the error I get when trying to post via xml-rpc interface:

Empty delimiter in .../wp-includes/class-wp-xmlrpc-server.php on line 2469 Warning:  Cannot modify header information - headers already sent by (output started at .../wp-includes/class-wp-xmlrpc-server.php:2469) in .../webraces/wp-includes/class-IXR.php on line 471

The line 2469 of class-wp-xmlrpc-server.php looks like:

if ( strpos( $post_content, $file->guid ) !== false )

Apparently $file->guid has invalid value as this is fixed by inserting

if($file->guid && !($file->guid == NULL))

right above the line in question. See also http://wordpress.org/support/topic/windows-live-writer-no-go-with-wp-312"	docfish
18178	"Add ""none"" option to $attr['link'] for [gallery] shortcode"		Gallery	3.2.1	normal	normal	3.6	enhancement	new	has-patch	2011-07-19T20:02:27Z	2013-04-08T08:13:15Z	"Currently, the `[gallery]` shortcode only supports output of linked images. By default, each gallery image links to the attachment page, or directly to the file, if `link=""file""` is passed to the shortcode. Both cases use `wp_get_attachment_image_link()`.

Attached patch adds support for `link=""none""`, enabling the gallery images to be output as flat image files, rather than linked, via `wp_get_attachment_image()`."	chipbennett
18043	Uploaded images dissapear after loading if using compression w/Apache		Multisite	3.2.1	normal	major	3.6	defect (bug)	new	dev-feedback	2011-07-08T22:49:15Z	2013-05-10T03:05:25Z	"I have found an issue between WordPress (Multisite) + Google Chrome (Mac) which I think appeared on my sever when I enabled compression a few months ago, but could never reproduce because it only happens with images managed by a Multisite WordPress install, not static images.

With images that are static Apache sends the file and calculates the Content-Length its self so these images work fine but if you access a file uploaded to WordPress it uses the .htaccess redirect so the image requests are sent via ms-files.php for what ever reason.

The problem is that WordPress decides to calculate its own Content-Length header in the HTTP Response which means that security conscious browsers like Google Chrome freak out when the data they receive is less than they we're told by Apache and they resultantly disable the image.

The Content-Length calculation comes on line 43 of ms-files.php I don't know why its needed because Apache seems to sort it out automatically if you don't send your own header, in fact most of the file seems like an unnessisary load of processing, perhaps it needs reviewing but this is a major issue as it is a growing browser, on a growing platform.

Here is a great video of it in action: http://www.screencast.com/t/cUYKSegW0N

This issue has been repeatedly reported on the forum:

http://wordpress.org/support/topic/disappearing-images
http://wordpress.org/support/topic/multisite-images-broken
http://wordpress.org/support/topic/image-not-show-in-google-chrome-timthumbphp

Please fix this asap!"	ctsttom
18042	Need a way to override wp_link_query()		Editor	3.2	normal	normal	3.6	enhancement	new	has-patch	2011-07-08T22:24:44Z	2013-05-05T04:18:55Z	"In previous versions of !WordPress, we were able to write a plugin which called add_filter on `tiny_mce_before_init` and then we were able to specify `external_link_list_url` which we gave it a list of all of the URLs on our site (we primarily linked to non-WordPress URLs on our site from this tool). Then when an author created a Link in the post tool the little popup would include a dropdown of all of the URLs/page titles that we specified.

In !WordPress 3.2 you have the new fancy ""link to existing content"" feature in the popup.

The problem is that there is NO hook, filter, or pluggable function whatsoever to allow you to override the functionality of this.

I needed to make the search results box return a list of pages (urls and titles) that I specified from a different database. In order order to do that I had to re-create the entire `wp_link_query()` function from wp-admin/includes/internal-linking.php to make it return search results from my own database. I put that function into a Plugin (to keep it out of Core) but then I had to hack core to rename `wp_link_query()` to `wp_link_query_ORIGINAL()` to get it to use my function and not the existing one.

Either `wp_link_query()` needs to be a pluggable function or there need to be hooks that let you completely replace how it works."	philfreo
17817	do_action/apply_filters/etc. recursion on same filter kills underlying call		Plugins	3.4.1	normal	normal	3.6	defect (bug)	reopened	needs-unit-tests	2011-06-16T18:04:04Z	2013-05-21T21:16:44Z	"Affects @wp-includes/plugin.php: do_action, do_action_ref_array, apply_filters, apply_filters_ref_array, _wp_call_all_hook

When calling a specific hook from a function that was called through that same hook, the remaining hooked functions from the first iteration will be discarded.[[BR]]
This is due to the handling of the array of registered functions using internal array pointers instead of a more robust approach.

In my example, this problem arose when I tried to programmatically delete a menu in reaction to the removal of a category. I hooked into the delete_term action to do so, upon which another function hooked into delete_term would no longer fire.[[BR]]
The obvious workaround is to adjust the priorities accordingly, but it shouldn't be necessary.


The current implementation as in apply_filters is:
{{{
reset( $wp_filter[ $tag ] );

if ( empty($args) )
	$args = func_get_args();

do {
	foreach( (array) current($wp_filter[$tag]) as $the_ )
		if ( !is_null($the_['function']) ){
			$args[1] = $value;
			$value = call_user_func_array($the_['function'], array_slice($args, 1, (int) $the_['accepted_args']));
		}

} while ( next($wp_filter[$tag]) !== false );
}}}

Using the following method instead, both iterations would develop properly:
{{{
if ( empty($args) )
	$args = func_get_args();

foreach ( $wp_filter[$tag] as $filters )
	foreach( (array) $filters as $the_ )
		if ( !is_null($the_['function']) ){
			$args[1] = $value;
			$value = call_user_func_array($the_['function'], array_slice($args, 1, (int) $the_['accepted_args']));
		}
}}}"	kernfel
17689	Terms should not be sanitized inside term_exists()		Taxonomy	3.2	normal	normal	3.6	defect (bug)	new	needs-unit-tests	2011-06-05T03:49:48Z	2013-05-05T04:05:44Z	"When adding a term to a post, the title of the term is sent through term_exists(). If term_exists finds and returns the ID of an existing term for the passed taxonomy, that ID is added to the post object. If no term is found, it returns false and a new term is created for that taxonomy with the same title that was passed to term_exists().

The problem is that term_exists() uses sanitize_title($term) on line 1457 of wp-includes/taxonomy.php while wp_insert_term uses stripslashes($name) on line 1985 of the same file.

This doesn't cause a problem in many circumstances, but if the term title happens to be something like $$$, that means it will always be added correctly in wp_insert_term() but never found as existing in term_exists(). The result is that every time you add $$$$ to another post it gets added as a new term with a unique slug so that you have  several terms with the title $$$$ for the same taxonomy but different IDs. 

The attached patch corrects that by passing the term title through stripslashes in term_exists() rather than through sanitize_title().

I haven't found any undesired side effects in testing."	blepoxp
17653	Canonical Redirect when space(s) are used instead of hyphens when requesting a page	dd32*	Canonical	3.2	normal	normal	3.6	enhancement	accepted	needs-unit-tests	2011-06-02T01:25:08Z	2013-02-21T01:15:53Z	"Create a page with a slug that contains a hyphen (eg. /page-name/).

If you then visit /page name/ (ie. use a space instead of a hyphen), WordPress currently manages to locate and display the page-name page. This could cause duplicate content issues.

The same issue occurs if multiple spaces are used instead of a hyphen.

As an example, this is the original page: http://jamesc.id.au/test-page/

This page is accessible via:
* http://jamesc.id.au/test%20page/
* http://jamesc.id.au/test%20%20page/
* http://jamesc.id.au/test%20%20%20page/
* http://jamesc.id.au/test%20%20%20%20page/

and so on.

WordPress should either output a 404 error, or redirect to /page-name/.

Tested using the latest 3.2 trunk (r18110)."	jamescollins
17588	fsockopen performs a POST request to a redirected location		HTTP	3.2	normal	normal	3.6	defect (bug)	new	has-patch	2011-05-27T08:56:34Z	2013-03-21T12:16:35Z	"Continuing off #17490.

Some background first: When you make a POST request, If you recieve a 3xx w/ Location in response, The correct thing to do next, is to perform a GET request to the new url, which is not what most people expect (Expecting the class to follow the Location with a new POST).

fsockopen doesn't follow this spec, cURL and Streams do, Upon receiving the redirection, fsockopen performs the exact same request against the new location, whereas, it should disregard the post fields (and the Content-length header) and perform a GET instead."	dd32
17375	Serialzed option values broken for classes and strings on unserialize for C and S	markjaquith	General	3.1	normal	normal	3.6	defect (bug)	reviewing	has-patch	2011-05-11T11:42:09Z	2013-01-14T01:06:27Z	"Wordpress has a feature build in to store arrays and objects into option values.

This is done by transparently serializing on storing and unserialize on retrieving.

The implementation is broken.

Wordpress is unable to unserialize serialized option values if they contain a serialized representation of classes implementing the [http://www.php.net/manual/en/class.serializable.php PHP serializeable interface] (C instead of O).

This is because the is_serialized() does not recorgnize that type of value."	hakre
17262	wp_get_attachment_thumb_file is always false		Media	3.0	normal	normal	3.6	defect (bug)	new	has-patch	2011-04-27T18:36:19Z	2013-05-05T03:33:40Z	The issue is that on line 3863 we always search for `$imagedata['thumb']` and it never exists. Instead we have `$imagedata['thumbnail']`. This always exists.	lonnylot
17154	TinyMCE inserts spans with font-styles atributes		TinyMCE	3.1	normal	normal	3.6	defect (bug)	reopened	has-patch	2011-04-17T12:04:38Z	2013-05-15T21:38:38Z	"This is continuation of #14218 which seems to be not fixed in 3.1 and still exist even in current 3.2. Reproducing steps
1. Open WP in latest Chrome (any version) - and probably also in other webkit browsers
2. Create new post
3. create UL with clicking on bullet icon
4. type some Li elements
5. close ul with <- icon (in advanced tinymce line)
6. type some text
7. switch to html view or publish article and see the code, you will see something like

{{{
asdfasdfh
<ul>
	<li>asfasdfa</li>
	<li>asdfa</li>
	<li>asfd</li>
</ul>
<span style=""font-size: small;""><span class=""Apple-style-span"" style=""line-height: 24px;"">adfasdfasd</span></span>

<span style=""font-size: small;""><span class=""Apple-style-span"" style=""line-height: 24px;"">asfasd</span></span>

<span style=""font-size: small;""><span class=""Apple-style-span"" style=""line-height: 24px;"">
</span></span>
}}}

P.S.: i can't select Version 3.2 in the bug report properties
"	thomask
17028	"Move the ""last edited at"" text and saved/updated/published notices in post/page editor"		Administration	3.1	low	normal	3.6	enhancement	new	has-patch	2011-04-02T21:56:59Z	2013-02-20T10:18:21Z	"1. The timestamp of the last save is currently displayed at the bottom right of the editor box. It would make more sense for this information to be tied to the Publish box instead. 

2. The yellow alert boxes that appear at the top of the page are weird. a) They should appear closer to the button that caused the action (general usability/accessibility best practice), so probably by the Publish box. b) Once you edit anything on the screen, the ""post updated"" (or saved, etc) text should go away, because it is no longer current. 

Am thinking we could combine these two things into one flexible status message that's located in or adjacent to the Publish box. "	jane
16956	Comments Being Pulled from Non-Existent Post Types		Post Types	3.1	normal	normal	3.6	defect (bug)	new	has-patch	2011-03-24T01:30:32Z	2013-05-10T17:25:46Z	"Originally on: #10461

I'm running standard LAMP on the latest trunk.

Just viewing the dashboard with no plugins activated:
{{{
Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 918 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 919 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 919 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 922 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 922 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 918 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 919 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 919 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 922 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 922 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 918 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 919 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 919 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 922 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 922 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 918 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 919 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 919 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 922 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 922 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 918 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 919 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 919 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 922 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 922 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 918 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 919 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 919 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 922 Notice: Trying to get property of non-object in /Users/grok/Projects/Local Development/wordpress/trunk/wp-includes/capabilities.php on line 922 
}}}

It's not recognizing ""$post_type->cap"" as valid.

And...here's why - I added this (/wp-includes/capabilities.php):
{{{
 918 echo ""POST TYPE: Y U NO OBJECT?\n"";
 919 var_dump($post_type);
}}}

And got:
{{{
POST TYPE: Y U NO OBJECT?
NULL
}}}

So in this context...the post type is null and the code was not expecting that.

Opening the actual $post object:
{{{
stdClass Object
(
    [ID] => 60
    [post_author] => 1
    [post_date] => 2011-01-28 19:46:23
    [post_date_gmt] => 2011-01-28 19:46:23
    [post_content] => CONTENT!
    [post_title] => I have it all!
    [post_excerpt] => 
    [post_status] => publish
    [comment_status] => open
    [ping_status] => open
    [post_password] => 
    [post_name] => i-have-it-all
    [to_ping] => 
    [pinged] => 
    [post_modified] => 2011-01-28 19:46:28
    [post_modified_gmt] => 2011-01-28 19:46:28
    [post_content_filtered] => 
    [post_parent] => 0
    [guid] => http://dev.wordpress.local/?post_type=staff_listing&p=60
    [menu_order] => 0
    [post_type] => staff_listing
    [post_mime_type] => 
    [comment_count] => 6
    [ancestors] => Array
        (
        )

    [filter] => raw
)
}}}

I think the problem might be custom post types or custom taxonomies...

So my custom post type in another plugin is creating: ""?post_type=staff_listing"".
And this post does show ""[post_type] => staff_listing"". BUT the plugin that had created these comments...is de-activated.

Activating the plugin resolves this issue.

So, whats a viable solution? Telling a developer to clean up after the plugin (removing content just because of deactivation), OR having WordPress not pull data (e.g. comments) that are assigned to other data (e.g. post types) that don't exist?

Old Code: Give me all comments.

New Code: Give me all comments that are tied to existing objects."	sterlo
16889	Having a location header does not mean that there should be a redirection.		HTTP	3.1	normal	normal	3.6	defect	reopened	has-patch	2011-03-18T16:49:43Z	2013-03-05T04:04:17Z	"Having a location header does not mean that there should be a redirection.

Automatic redirection depends foremost on the response code, not not having a location header.

See the descrption of #16888 for related RFC links.

Related: #11305"	hakre
16843	wp_unique_post_slug() doesn't check pagination base when CPT has archive		Post Types	3.1	normal	minor	3.6	defect (bug)	new	has-patch	2011-03-13T06:22:22Z	2013-01-14T00:12:14Z	Title says it all.	scribu
16746	post paginating <!--nextpage--> does not work	nacin	Query		normal	normal	3.6	defect (bug)	reopened	has-patch	2011-03-04T12:01:31Z	2013-03-13T08:55:57Z	"When <!--nextpage--> is placed at the very beginning of the post content (first page contains zero-length content) then pagination does not work at all.

Example post content for reproduction:

{{{
<!--nextpage-->
page2
<!--nextpage-->
page3
}}}

This will result in a single page, not in a three or two page setup.

It's related to strpos returning 0 which is casted into false when if'ed.

Related: #16745"	hakre
16705	"Unclear wording: ""An administrator must always approve the comment """		Text Changes	3.1	normal	normal	3.6	defect (bug)	new	commit	2011-02-28T21:22:12Z	2013-05-05T01:04:18Z	"I'm not certain if I should classify this as a bug or as a need to revise wording in the options menu, or if I should put in a feature request for a refined option...

...but...

If, under Settings->Discussion you have ""An administrator must always approve the comment"" checked, if the author of the post receiving the comment has the ""edit_comment"" capability, they will receive an email notification to moderate the comment in the queue.

After viewing the wp_notify_moderator function for 3.1 in pluggable.php (and comparing it to 3.0.5's version) I can see this functionality seems to be coded in by design.

What's confusing is that the option reads ""An administrator must always approve the comment"" and it's difficult to discern if that means the user role of ""Administrator"" or anyone who can be an ""administrator"" of the comments.

It's also hard to tell from the reading of the option text whether or not this means that the function is implemented incorrectly, or if the option is simply poorly worded.

In either case, it would be useful to be able to have more granular control over who is getting these email notifications for comment moderation.

Failing that, if the ""An administrator must always approve the comment"" is checked, that should mean that only users with the ""Administrator"" role should be able to approve the comment.

...depending on what the expected behavior of this functionality is meant to be."	joe.woidpress
16567	Can't create categories with different names but similar slugs on Edit Post screen		Administration	3.0.5	normal	normal	3.6	defect (bug)	new	needs-unit-tests	2011-02-15T18:29:10Z	2013-01-09T23:38:54Z	"We run a blog that deals with programming languages. Today we were creating a post concerning the C programming language and attempted to create a new category for it, called ""C"" (just one character). This angered WordPress; it appeared to create a superfluous ""Uncategorized"" category, but it wound up not actually creating any categories for the post.

I've attached a screenie so you can see what this looks like after I attempt to create the category.

If it's for some reason forbidden to create categories comprised of a single character, maybe a validation error message of some kind would be in order?"	jeffreymcmanus
16465	Querying taxonomies can trigger notices		Warnings/Notices	3.1	normal	normal	3.6	defect (bug)	new	has-patch	2011-02-05T14:07:34Z	2013-05-05T00:40:56Z	"Taxonomy queries variables related to backwards-compatbile taxonomy queries like {{{$cat_query}}} ({{{category}}}) or {{{$tag_query}}} ({{{post_tag}}}) do notices because they expect to have a term available.

But that's not the case if those taxonomies are getting queried ""advanced"" regardless of a concrete term.

Related: #15007 / [15685]

The related feature is: Advanced multi-taxonomy WP_Query()s (#12891, #15752)"	hakre
16276	Default value for search field - (#11420 Easy within-site linking from new content)		Editor	3.1	normal	minor	3.6	enhancement	new	has-patch	2011-01-17T20:14:42Z	2013-05-05T00:33:59Z	"The within-site linking available in the current release candidate looks like a great idea, but I'm wondering if it might make sense to pre-popular the search box area with the selected text that is highlighted.

Currently the search box (which is actually more of a filter box) is empty by default, but it seems to me that most of the time if you are linking to internal content, you will be linking to the material you are highlighting which will have a similar title."	jamie.richard
16215	Post Revision history displays the incorrect author	westi	Revisions	2.6	normal	normal	3.6	defect (bug)	reopened	has-patch	2011-01-13T06:52:06Z	2013-05-09T10:14:13Z	"Steps to reproduce:

1. Create and Publish a new post as user admin.
2. Edit that post and Update as user mdawaffe.
3. View revision history for that post.  Note that the revisions are attributed to the wrong authors.

The revision's post_author is currently being set to whoever edited the post away from the state represented by that revision row. It should be set to the person who edited the post *to* the state represented by that row.

This bug has been around since the introduction of post revisions.

To fix for future posts, I can think of two options.

1. We should be able to pull the correct author for a new revision row from the _edit_lock/_edit_last post meta of the post (as long as we grab that before we update the post row).

2. Currently, when a post is updated, revisions first grabs a copy of the current state of the post, stores it as a revision, then updates the post row.  To fix this bug, we could instead update the post row first then store a copy of that new state as a revision.  That would mean the most recent revision for all posts would be a duplicate of the actual post.

Option 2 would be cleaner code, option 1 would be cleaner data.

To fix for existing posts, we need to go through each post and fix each revision.  That's incredibly expensive to do on upgrade, so I suggest doing it per post on the fly when the post edit screen or post revisions screen is loaded.

If we fix on the fly, we have to be able to keep track of which posts/revisions have been fixed and which haven't.  We could track that with:

1. An option that is set on upgrade with a timestamp.  Compare post_modified to that timestamp.  This seems fragile to me since I bet there are plugins that override post_modifed.
2. Post meta.  Easy, but adds one post meta per post just to fix a lame bug.
3. Bump the menu_order of each fixed revision row from 0 -> 1.  (A version number for the revisioning system :)).  Hacky.

I like 3: menu_order.

We could also leave everything as is, allow the data to be wrong, and ""fix"" it on display or even in get_post().

Aside: While we're in there, we may want to ""fix"" revisions' post_modified columns.  Currently, post_modified is identical to post_date, which is the time the post was put into the state represented by the revision.  We could make post_modified the time the post was edited away from the state represented by the revision."	mdawaffe
15919	wp_count_terms() hide_empty not working	markjaquith*	Taxonomy		high	major	3.6	defect (bug)	accepted	has-patch	2010-12-20T17:13:46Z	2013-04-14T01:43:06Z	"For tax category, `wp_count_terms( 'category', array( 'hide_empty' => true ) )` returns all category and doesn't hide category with post count 0. Instead need to use `wp_count_terms( 'category', array( 'hide_empty' => true, 'hierarchical' => false ) )`.

Since hide_empty=false is the default args, `wp_count_terms()` should set hierarchical=false by default too."	zeo
15907	inconsistent handling of plugin_folder in get_plugins()		Plugins		normal	normal	3.6	defect (bug)	new	has-patch	2010-12-20T03:35:16Z	2013-05-05T00:25:18Z	"If you pass the name of a folder to get_plugins, it needs to have a leading slash which then stores the plugin list from that folder in {{{$wp_plugins['/folder-name']}}}. 

Secondly, the plugin file/path does not include folder-name passed to get_plugins, so the returned data has to have the {{{'folder-name/'}}} added to the key of each plugin's information before it can be used throughout WP. The code I'm currently using to work around the issue is

{{{
			$my_plugins = get_plugins( '/extra' );
			$extra = array();
			if( !empty( $my_plugins ) ) {
				foreach( $my_plugins as $k => $v )
					$extra['extra/' . $k] = $v;
			}
}}}

related #15906"	wpmuguru
15801	Network Admin: Deactivated / Deleted inconsistency	PeteMall	Text Changes	3.1	normal	normal	3.6	defect (bug)	assigned	has-patch	2010-12-13T18:12:54Z	2013-05-05T00:18:03Z	"Under the Sites screen, there are distinct inline links for Deactivate and Delete. However, when a site is deactivated, it is referred to as deleted in:

* Sites screen inline status

* Edit Site screen attributes section

* Error page for non-admins visiting the site"	kawauso
15765	wp-admin/ms-sites.php doesn't indicate required fields		Network Admin	3.0.2	normal	minor	3.6	defect (bug)	new	commit	2010-12-10T16:14:49Z	2013-05-05T00:12:24Z	In '''wp-admin/ms-sites.php''', apparently all fields under '''Add Site''' are required, but there is no visual indication.	novasource
15576	Proper l10n of items per page in the screen options		I18N	3.1	normal	normal	3.6	defect (bug)	new	commit	2010-11-25T02:57:13Z	2013-05-23T08:02:22Z	"Sites, Users, Comments, Media items and Plugins have their own translation context on the screen options tab, e.g. “sites per page (screen options)”.

To use the right grammatical case, Posts, Pages, Categories and Tags should have that context too. "	SergeyBiryukov
14979	custom background view shows cropped image and not original upload		Appearance	3.0.1	normal	normal	3.6	defect (bug)	new	dev-feedback	2010-09-27T19:59:12Z	2013-02-06T11:53:18Z	"trying to upload a very tall image to the custom background area (for example 100*1100px width*height) works but the image that is then shown in the view-pane is the cropped/thumbnail version of the upload and not the original image the user added.

it is possible a site would have a repeat-x on a really tall image."	obvio
14975	Nav-menu system does not always run titles through 'the_title' filter.		Menus		normal	normal	3.6	enhancement	new	commit	2010-09-27T15:19:48Z	2013-05-04T23:41:26Z	I am using the qTranslate plugin that uses the 'the_title' filter to parse its multilingual content (separated with comment tags). All titles are parsed well except for the titles appearing in the menu system's meta boxes; It seems this is because nav-menu functions don't run the titles through this filter.	Goldfrapper
14856	Add an $args parameter to comment_text filter		Comments		normal	normal	3.6	enhancement	new	has-patch	2010-09-12T12:20:06Z	2013-05-04T23:25:53Z	"When using the {{{comment_text}}} filter, there are times when the context provided by {{{$args}}} would be extremely useful. For example to know the depth of the commen. I propose adding an additional parameter for {{{comment_text}}} to add the {{{$args}}}.

I've incorporated the proposed {{{$comment_ID}}} parameter from #14261, which looks to add a {{{$comment_id}}} parameter to the same filter, in the hope that this is helpful... let me know if not and I'll refactor.

I've included a small plugin to demo the use and prove the new parameters are working, and the diff for a small tweak to Twenty Ten v1.1 which is needed to use this plugin with that theme."	simonwheatley
14773	Error in slug parsing leads to unlimited URLs for the same article = duplicate content		Canonical		normal	normal	3.6	defect (bug)	assigned	has-patch	2010-09-03T14:20:45Z	2013-04-11T03:30:30Z	"an example says more than 1000 words:

right url:

http://ahmongwoman.wordpress.com/2010/09/02/i-am-not-hmong-and-i-dont-speak-spanish/

wrong urls:

http://ahmongwoman.wordpress.com/2010/09/02/i-am-not------hmong-and-i-dont-speak-spanish/

http://ahmongwoman.wordpress.com/2010/09/02/i----am-not-hmong-and-i-dont-speak-spanish/

http://ahmongwoman.wordpress.com/2010/09/02/i-am-not-----hmong-and-i-------dont-speak---------spanish/

Problem:

Wordpress returns the article with HTTP status code 200 for the wrong URLs.

This is a serious issue for people regarding search engine optimization (duplicate content).

Expected results:

Wordpress returns HTTP Status code 301 with Location-Header and right URL to the client."	thermoman
14601	wp_new_comment method doesn't allow passed in values for IP and user-agent		Comments	3.0.1	normal	normal	3.6	enhancement	new	has-patch	2010-08-12T14:20:21Z	2013-05-04T12:03:02Z	"In a scenario where you have a client that receives comments from the internet and pre-processes those comments before feeding them into wordpress through xmlrpc the ip and user-agent of the commenting internet user gets lost because there is no way of passing those values into the wp_new_comment function. 

`$_SERVER['REMOTE_ADDR']` and `$_SERVER['HTTP_USER_AGENT']` are hard-coded, which in the above mentioned scenario will always have the IP and user-agent from the client that feeds the comments into wp through xmlrpc.

The attached patch will used passed in values and only fall back to `$_SERVER['REMOTE_ADDR']` and `$_SERVER['HTTP_USER_AGENT']` if not passed in."	mrutz
13822	Menu items that get unpublished still appear	nacin	Menus	3.0	normal	normal	3.6	defect (bug)	reopened	has-patch	2010-06-10T16:30:12Z	2013-03-21T14:53:47Z	"We need to properly account for menu items linked to unpublished/pending post type objects.

My thought is they should probably be hidden from the frontend with an indication on the backend (like ""(Pending)"") that they are are unpublished/pending.

We need to properly handle private posts too."	nacin
13459	Conflict between post and page slugs/permalinks when permalink setting is set to /%postname%/	ryan	Permalinks	2.9.2	normal	normal	3.6	defect (bug)	new	needs-unit-tests	2010-05-20T04:56:27Z	2013-03-03T03:01:45Z	"If Dashboard -> Settings -> Permalinks is set to /%postname%/, it is possible to create both a page and a post with the same slug. When viewing via the frontend, the page is always displayed.

I would have thought that WordPress should prevent a post and a page from having the same permalink.

Steps to reproduce:
1. Create and publish a page with any slug. eg. http://domain.com/test/.
2. Create and publish a blog post with the same slug. Wordpress says the permalink for the blog post is http://domain.com/test/, but when you visit that URL it displays the page instead.

I can reproduce this on my 2.9.2 install, as well as 3.0 trunk. I'm guessing the bug is present in earlier versions of WordPress as well.


Possibly related: #11863"	jamescollins
13239	Filter locate_template template_names variable		Themes	3.0	normal	normal	3.6	enhancement	reopened	has-patch	2010-05-03T21:43:05Z	2013-05-04T11:09:25Z	"I recently encountered a situation where it would be very helpful to supply alternate template file locations; however, this cannot be accomplished as the locate_template function is being used and that function's arguments are not filterable. So, I created a patch that adds the filter.

This patch adds two filters: locate_template and locate_template-TEMPLATENAME. This allows for both general and specific filtering.

The following example shows how this could be used to modify the location of a BuddyPress template file.

{{{
function filter_member_header_template( $template ) { 
    return dirname( __FILE__ ) . '/buddypress/members/single/member-header.php';
}
add_filter( 'locate_template-members/single/member-header.php', 'filter_member_header_template' );
}}}

While the value of this example is debatable as BuddyPress could be updated to support alternate template locations, the value of the patch itself is high. This opens up a new ability for plugins to modify template file locations, giving plugins a hook into the content rendering process without requiring themes to be modified."	chrisbliss18
10948	wp_list_comments() always assumes walker will echo.		Comments	2.8.6	normal	normal	3.6	defect (bug)	new	has-patch	2009-10-13T12:21:33Z	2013-05-04T10:33:03Z	"wp_list_comments() always assumes the walker called will echo it's constructed content (the default Walker does this).

However, if you want to use your own walker which doesn't echo, or you want to post process the output of the default walker in some way, you cannot.

The changes required are to wp_list_comments() which should check for an 'echo' arg and respond appropriately (like wp_list_pages does). The built in comment walker class Walker_Comment needs to write it's output to the passed $output reference. Finally the function edit_comment_link() needs to take an echo parameter.

The attached patch allows this functionality whilst preserving the status quo by adding a default echo => 1 argument to wp_list_comments and edit_comment_link.

"	MikeLittle
10840	Plugin upgrade sometimes shows a scrollbar		Plugins	2.8.4	low	normal	3.6	defect (bug)	new	has-patch	2009-09-24T10:34:05Z	2013-04-10T07:58:54Z	"Please see attached screenshot, made in Safari 4.0.3 on OS X.

The iframe only contains the ""Plugin reactivated successfully"" line.

Increasing the window's height or width does not make it disappear, or even evolve."	xibe
9272	Expand human_time_diff()'s abilities	Viper007Bond	Date/Time	2.8	normal	normal	3.6	enhancement	new	has-patch	2009-03-04T10:42:21Z	2013-05-24T05:00:52Z	"This is partially related to #7250.

Currently `human_time_diff()` can only do days, hours, and minutes. I propose we expand it a bit, to at least weeks and possibly even months and years (although that can be tricky unless PHP has a shortcut).

It should also support the ability to trim to a certain accuracy, i.e. for a 2 year 1 month old post, minutes don't matter.

In short, I propose we integrate Time Since's functionality into the core by expanding the current `human_time_diff()`."	Viper007Bond
8177	Comments disabled in post but not in media gallery		Gallery	2.7	normal	normal	3.6	defect (bug)	new	has-patch	2008-11-12T16:08:33Z	2013-04-22T12:46:10Z	"The options to ""allow comments on this post"" and ""allow trackbacks and pingbacks on this post"" have been deselected.  The post will then return the expected message ""Both comments and pings are currently closed"".  (ie. http://localhost/wordpress/?p=42)  However, when selecting an image from an embedded native Gallery of that post, the image redirects to an attachment_id (ie. http://localhost/wordpress/?attachment_id=38)and still has a comments field.  There is no decipherable means to disable comments on attachments through the native gallery.  

If this is the expected behavior, I would believe that if a post may disable comments, then all of its content should be disabled.

Related: #9839 Enable/Disable comments on a per item bases (some attachments don't have parents)"	canon2k5
7392	Don't create new autosave revision if nothing has changed yet	westi	Autosave	2.6	normal	minor	3.6	defect (bug)	reopened	has-patch	2008-07-23T22:03:39Z	2013-05-09T15:22:06Z	"I noticed that simply loading and saving a post creates a new revision. This seems rather dumb to me. Could we not load the post up, compare it with the revision, and not create a whole new revision if nothing changed (ignoring post save time, of course)?

Discuss."	Otto42
4463	Strange paging links	ryan	Permalinks	2.3	normal	normal	3.6	defect (bug)	new	has-patch	2007-06-14T03:00:49Z	2013-04-12T23:22:37Z	"Ryan:

{{{
In trunk, with cruft free links, I get stuff like this:

http://foo.blog/page/3/?s=test

That's not right. Maybe we should revert back to pre [5454] to fix the trunk problems.
}}}

[5454] was the commit for #3930

If at all possible, I'd like to work with the new code."	markjaquith
