Example

`, `

` and other tags, all attributes should be made available too. `role` should be added to the required tags falling under `$allowedposttags`. Go through the link for more information on [http://www.w3.org/wiki/PF/XTech/HTML5/RoleAttribute roles]." aniketpant 24093 "WP_Meta_Query is inefficient when referencing the same keys in ""OR"" query" Query 3.5.1 normal normal Awaiting Review enhancement new dev-feedback 2013-04-15T16:21:31Z 2013-04-15T16:24:39Z "This is part of the chain of thought from #19729 The corresponding fix for #19729 was done in [22103] I believe this fix didn't take things far enough. For example, a meta_query that does a lot of comparing on the same meta_key, will have a JOIN and a WHERE for each query array. It shouldn't have to re-join the postmeta table on each query array though, since they are based on the same meta_key. I'll attach a suggested patch that will only join if it needs to, and use the previous alias for the first meta_key joined table if it's already been joined." sc0ttkclark 24088 Update get_users_drafts() to support custom post types Users 3.5.1 normal normal Awaiting Review enhancement new 2013-04-15T11:17:52Z 2013-04-15T11:17:52Z Currently get_users_drafts() access drafts of 'post' type only. Would be useful if it could support custom post types as well. navjotjsingh 24085 wpautop filter and shortcodes Shortcodes trunk normal normal Awaiting Review defect (bug) new 2013-04-15T06:41:15Z 2013-05-17T05:12:47Z "I've been told here that this has been fixed in WP3.6 but it wasn't. I just installed WP3.6 Beta 1 and still doing this: {{{ [shortcode] [/shortcode] }}} produces this: {{{

}}} which is highly unwanted because I have to strip

tags manually in order to make carousel of images work." Looimaster 24084 Fix possible PHP notices after a user is deleted Administration normal normal Awaiting Review defect (bug) new 2013-04-14T22:24:48Z 2013-04-15T23:09:34Z "`get_comment_author()` doesn't check if a user that has commented still exists and may throw a notice. Also can return the user_login where a user name is expected. Same in `edit-form-advanced.php` in the code block that outputs ""Last edited by ..."" under the editor." azaozz 24081 Simplifying the 5 minute setup Upgrade/Install normal normal Awaiting Review enhancement new dev-feedback 2013-04-14T05:22:53Z 2013-04-14T06:14:21Z I decided to simplify the five minute setup. I teach a beginners class for WordPress, since it was badly needed and people usually get really confused when it asks for a database name and username. Please add onto my quickly written tutorial.php and let me know if you would be interested in putting it as a link in the five minute setup. ryansatterfield 24078 Remove 'admin' as default username in install Upgrade/Install 3.5 normal normal Future Release enhancement new commit 2013-04-13T19:07:29Z 2013-05-05T21:06:45Z "The installation process populates the username field with 'admin' by default. Many/most users probably leave it as-is, making them more vulnerable to brute force attacks that look out for ""admin"" usernames. Seems a pretty easy improvement to specify no default username, and force the user to choose one themselves. " chrisrudzki 24077 Anchor links unallowed for non-admins TinyMCE 3.5.1 normal minor Awaiting Review defect (bug) new 2013-04-13T15:51:02Z 2013-05-01T17:16:55Z "Due to the HTML filter for roles below the editor (and even editors in the multisite/network version), users cannot add anchor links as per the HTML5 specifications as the name attribute is obsolete: http://www.whatwg.org/specs/web-apps/current-work/multipage/obsolete.html#attr-a-name While valid in HTML4.01, it was still recommended that the id attribute is used: http://www.w3.org/TR/html401/struct/links.html#h-12.2.3" artychan 24073 wp_ajax_ajax_tag_search Taxonomy 3.5.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2013-04-13T09:59:25Z 2013-04-14T04:39:03Z "For some of custom taxonomies the tag autocomplete doesn't work I tried to solve this issue and changing t.name to name in $results = $wpdb->get_col( $wpdb->prepare( ""SELECT name FROM ..... ""); in wp-admin/includes/ajax-actions.php -> wp_ajax_ajax_tag_search() helped me to solve this problem. now everything looks ok for me . " samnajian 24071 Allow users to set three columns on Add Post/Add Page screen Administration normal normal Awaiting Review enhancement new 2013-04-12T23:53:07Z 2013-04-14T06:02:48Z "These days, an increasing number of people have desktops or laptops with high-resolution monitors. On such monitors, the layout of the WordPress Add Post/Add Page UI is not optimal. On, say, a 1920x1080 screen, the first column, containing the TinyMCE editor and title field, occupies the vast middle of the screen, with the WordPress chrome at the left and Column No. 2 at the right. If a user has chosen to show additional fields not shown by default - like Excerpt, Send Trackbacks, Custom Fields, Discussion, Slug, and Author - these all appear below the TinyMCE editor, out of sight on a widescreen. Take a lot at the screenshot attached to this ticket. Showing two columns by default is perfectly fine, but those with widescreen displays would benefit from gaining the ability to change the number of columns in the screen layout to three without needing a plugin, or having to hack the admin. This doesn't seem like it would be too difficult of an option to add to core. Allowing three columns to be set would permit users with hi-res monitors to easily make better use of the screen real estate: all of the available fields would be visible without the need for scrolling. Many users, incidentally, utilize fixed-width themes on their sites, and if the theme is sending its CSS to the post editor in order to enable the user to accurately preview what the text will look like (truer WYSIWYG), having a really wide post editor is especially useless. I've attached a three-column mockup I made in KolourPaint. The mockup shows what a three-column post editor layout could look like. As you can see from the mockup, all available fields in WordPress Core fit into the viewport. " avcascade 24068 Allow absolute paths to be passed into content_url() General normal trivial Awaiting Review enhancement new has-patch 2013-04-12T20:13:59Z 2013-04-12T20:13:59Z "It would be very useful if `content_url()` allowed an absolute path to be supplied just like `plugin_dir_url()` does. This would allow a script within a theme subdirectory to easily obtain the URL to that subdirectory, for example via `content_url(__DIR__)`, instead of having to add relative paths after `get_stylesheet_directory_uri()`. This would also allow code living somewhere else under `wp-content/` (not in plugins or themes) to likewise obtain its full URL. http://codex.wordpress.org/Function_Reference/content_url http://codex.wordpress.org/Function_Reference/plugin_dir_url http://codex.wordpress.org/Function_Reference/get_stylesheet_directory_uri" westonruter 24067 TinyMCE 4.0 TinyMCE 3.5.1 normal normal Awaiting Review enhancement new 2013-04-12T18:34:58Z 2013-04-12T21:40:47Z "Hi everyone, Do we have any plans on implementing Tinymce 4.0 into core? http://www.tinymce.com/presentation/index.html Thanks." josh401 24066 Version field in Trac's New Ticket form inappropriate for WordPress.org site tickets WordPress.org site normal minor WordPress.org enhancement new 2013-04-12T18:29:32Z 2013-04-14T03:02:55Z "WordPress.org site bugs are not related to WordPress versions. After selecting ""WordPress.org site"" as a component on the Create New Ticket form in Trac, the version field should be either hidden or disabled." Daedalon 24065 Allow previewing posts in WordPress.org support forums WordPress.org site normal normal WordPress.org feature request new 2013-04-12T18:17:31Z 2013-04-12T20:47:26Z "WordPress allows previewing posts before publishing everywhere else except on WordPress.org support forums. Preview functionality should be added there as well. Ideally the preview would be shown next to the editor so users can spot and correct mistakes without reloading the page, just like when commenting here in Trac." Daedalon 24064 Allow comment_form() to display the comment field first Template trunk normal normal Awaiting Review enhancement new has-patch 2013-04-12T17:44:36Z 2013-04-13T08:57:03Z "Many sites and many third-party comment system providers display the comment field before the name/email/URL fields in comment forms these days. It would be nice to have any easy option to do this with the `comment_form()` function. Currently if you want to display the comment field first you'll have to avoid using `comment_form()` or you'll have to do some crazy CSS or jQuery trickery to move things around. Neither are optimal." johnbillion 24063 Introduce some more _doing_it_wrong() calls in nonce functions Security 3.2 normal normal Awaiting Review enhancement new has-patch 2013-04-12T17:15:25Z 2013-04-12T17:17:09Z "`check_admin_referer()` will tell you that you're `_doing_it_wrong()` if you don't specify the `$action` parameter. The corresponding `wp_nonce_field()` and `wp_nonce_url()` functions should behave the same way. `check_ajax_referer()` should also behave the same as `check_admin_referer()` but I'm not sure if potentially raising notices in AJAX calls is a good idea. I've included it in the patch anyway. " johnbillion 24061 Introduce blog-archived.php and blog-spam.php Multisite normal normal Awaiting Review enhancement new has-patch 2013-04-12T16:54:46Z 2013-04-13T08:54:29Z "When Multisite is active and an archived or spammed site is loaded, WordPress first looks for a file in the content directory called `blog-suspended.php` and loads it if it's found. Two problems: 1. The file name is counter-intuitive because 'suspended' isn't the name of a status that a site can have. 2. It's not possible to serve a different file for spammed and archived sites. The upcoming patch introduces support for `blog-spam.php` and `blog-archived.php` for sites with the respective status. It will fall back to `blog-suspended.php` for backwards compatibility." johnbillion 24057 "wp_list_bookmarks links target=""""" General 3.5.1 normal minor Awaiting Review defect (bug) new reporter-feedback 2013-04-12T11:28:53Z 2013-04-15T23:41:22Z "When adding links via the add links function in WordPress, the default target of the link is _none. The problem is, the code generated for that code is , target being an empty string. This is not HTML5 compliant, as target has to have at least 1 character." moscar09 24054 (get_)comment_class() should include a is_user_member_of_blog() class Comments 3.5.1 normal normal Awaiting Review enhancement new has-patch 2013-04-11T22:35:04Z 2013-04-11T23:27:06Z "On multi-site, there's no way to style comments that are members of the site. You can either style the post author or all registered users (who may not have access to the site's admin area). Example use case would be a multi-author site where you want comments from all authors highlighted. I think it'd also be cool to include what role they are so that you could style say all authors, editors, and administrators but not style contributors or something like that. I'm not sure if this would an information exposure issue though (does it matter if it is known what role a user is or that they are a member of the site?)." Viper007Bond 24051 a way of turning on upload space quota on single-site WordPress install Media 3.5.1 normal normal Awaiting Review feature request new 2013-04-11T19:12:19Z 2013-04-12T16:11:20Z "I was searching for a way to turn on upload space quota for single-site WordPress (not multisite) install. There does not seem to be one. I can't even emulate one with hooks, because in media.php 'upload_ui_over_quota' hook is multisite-specific and 'pre-upload-ui' does not allow me to emulate the same behavior. I understand that need for upload space quota for single-site is not a very common scenario, but the relevant code is already there, only an alternative method of enabling it (e.g. a constant in wp-config.php) is needed." ideag 24049 Make Plugin Editor's file list alphabetical by full path Plugins 2.8 normal normal Awaiting Review defect (bug) new has-patch 2013-04-11T18:24:43Z 2013-04-15T23:07:29Z The files under Plugin Editor's (plugin-editor.php) Plugin Files header should be shown in alphabetical order of their full path. Currently their order seems completely random, which makes the list cumbersome to use. Daedalon 24048 Increase the usability of Plugin Editor's files list (separate directories, limit height) Plugins 3.5.1 normal normal Awaiting Review defect (bug) new 2013-04-11T18:21:15Z 2013-04-12T14:25:54Z "Regarding the list under Plugin Files in the Plugin Editor (plugin-editor.php): 1. Plugin root directory does not need to be mentioned in the file list. 2. In order to improve readability, directories should be marked in a way that distinguishes them from the filename. Preferably directories should not be shown next to every file, but rather as headers, under which all files in the same directory are grouped. This would make the list a lot shorter, as currently most of the filename-and-path-combinations span two lines. 3. The form of the list should be changed to limit the total height of the list. This is especially useful for plugins with dozens of editable files. One way would be to use a < ul > element with expansible/collapsible directory headers, showing only the first-level directories and files by default." Daedalon 24047 Line numbers in post editor text mode? Editor 3.5.1 normal normal Awaiting Review enhancement new 2013-04-11T17:48:32Z 2013-04-11T22:23:28Z "I would love to see line numbers in the post editor when in text mode. This and/or the cursor returning to the editing point when updating a post. It can be very annoying that the cursor always returns to the top of the editor when a manual update is initiated. Making a lot of small edits in various parts of a longish post can be really tedious." dgwyer 24044 Add index to wp_options to aid/improve performance Performance trunk normal normal Awaiting Review enhancement new has-patch 2013-04-11T11:26:54Z 2013-05-07T21:34:09Z "I work for a hosting company and we manage many '000s of WP sites for people. In order to improve the performance of all of these instances I find myself adding an index onto wp_options autoload many times daily. I'm aware this is a small gain, but any gain is good. This index will be hit on every single page load." DanBUK 24042 Help text visibility in title input box is not intuitive Accessibility trunk normal normal Awaiting Review enhancement reopened 2013-04-11T03:45:04Z 2013-04-12T04:32:03Z "Currently, the input box for title which shows on a new post creation page uses a label to display the help text- ''""Enter title here""''. This text disappears on focus and an that point of time, there is no place which points out that this input box is for the title. This problem has been pointed out by a lot of people and it surfaced after the new Gmail design came out. The problems it generated are very similar and as you may have used it, there are no labels for the email recipients field and the subject field. The issue is not very big as such but it does generate ambiguity in some cases. The solution to this would be to have the label as an overlay on the input, which can slide/move to a new position on focus. And placeholder text can be used as help text. This way the help text will be visible at the start and the label will be visible throughout." aniketpant 24040 "Use ""posts"" instead of ""topics"" (in tagcloud tooltips)" Widgets normal minor Awaiting Review enhancement new 2013-04-11T01:56:36Z 2013-04-11T06:30:42Z "Hello, I suggest use ''post(s)'' instead of ''topic(s)'' [http://core.trac.wordpress.org/browser/trunk/wp-includes/category-template.php#L563 here]. ""Topics"" is very related to forums (bbPress), while ""Posts"" are more general term I think? Thanks" Dianakc 24035 in WP 3.5.1, filter wp_nav_menu_items is never called on empty menus Menus 3.5 normal normal Awaiting Review defect (bug) new close 2013-04-10T18:03:23Z 2013-04-11T17:01:27Z "We upgraded from 3.4 to 3.5.1 and our main navigation menu vanished. Our theme uses the ""wp_nav_menu_items"" filter to add menu items to an empty menu, depending on login context & other things. I have verified that in 3.5.1, this filter is never called on empty menus. wp_nav_menu() called with the proper args to select our menu just returns null. we are specifying theme_location in the call. A workaround/hack is to add a bogus menu item to the DB, via the admin interface, and then delete that bogus menu item in our filter. I imagine this crept in with the new 3.5 behavior of not emitting HTML for an empty menu. The bug is in wp-includes/nav-menu-template.php . The comment at line 174 claims we will fallback on empty menus only if no theme_location is specified, and we do test that on line 177, but on line 181 we test again and fallback on empty menus without checking theme_location. This line (181) : {{{ if ( !$menu || is_wp_error( $menu ) || empty( $menu_items ) ) }}} ... should be this line: {{{ if ( !$menu || is_wp_error( $menu )) }}} " mykle 24032 An issue with the theme customize function and jQuery tabs Appearance 3.5.1 normal normal Awaiting Review defect (bug) new 2013-04-10T15:07:04Z 2013-04-10T18:31:50Z "WP 3.5.1 ( same happens in the 3.6 beta-1 ) No plugins installed ( vanilla WP ) TwentyTwelve Theme ( happens with TwentyThirteen as well ) So when you have or using jQuery Tabs in a page and you go to the theme customize page, the customizer panel will become sluggish and not very responsive when you hover your mouse over the accordion panel and if you look at the preview, the content is jumbled and also very sluggish. It seems something is executing in a loop over and over again making it sluggish but I did not see anything in the error console for some reason. Perhaps this is because it is on an iFrame. Please note that the page in the frontend loads just fine with the jQuery Tabs and works normally. It is only when you use the backend theme customize page is where this issue starts. I have tried this in both 3.5.1 and 3.6 beta-1 and same results. Here are the steps to reproduce this. In functions.php load up: {{{ wp_enqueue_script( 'jquery-ui-core' ); wp_enqueue_script( 'jquery-ui-tabs' ); }}} In the homepage (any page) put in: {{{

some content here

some other content

}}} In theme js, put in: {{{ $('.test').tabs(); }}} Then go to your homepage in the frontend to confirm the tabs are working and normal. Now go to the backend theme customize and you will see the issue I am trying to describe." splashingpixels.com 24030 Add an action for when nonce verification fails General 3.4.1 normal normal Awaiting Review defect (bug) new 2013-04-10T10:21:37Z 2013-04-10T10:21:37Z "Currently when a plugin (or core) calls `check_admin_referer()` there is no way for auditing (or debugging) plugins to hook in and record an event that the nonce check failed. Previously it was possible to use the `explain_nonce_$nonce` filter to do this, but that was removed in [21133]. If a plugin wants to record an event for a failing nonce, it'll need to call wp_verify_nonce() manually itself, and die afterwards, or call `check_admin_referer()` after verifying the nonce itself for logging purposes. I'd suggest either resurrecting the previous filter as an action (for back compat) or adding a new nonce failure hook." dd32 24026 No /themes/ folder causes strange behaviour Themes 3.1 normal normal Awaiting Review defect (bug) new 2013-04-10T07:05:04Z 2013-04-11T04:09:40Z "I know, that it's a tricky behaviour, but the problem exists. 1. Unzip WordPress files to appropriate place 2. Go to /wp-content/ and delete /themes/ folder 3. Install WordPress using it's wizard (ignore error in Dashboard that no theme activated) 4. Go to Plugins page in admin area 5. Install BuddyPress (this plugin register the theme BP Default that is situated in plugin folder - '''this is very important''') 6. Activate BuddyPress and complete its wizard to make BP functional 7. Go to Themes page in wp-admin 8. You will now see BP Default Theme. Try to activate it 9. Ta-da! You've just unlocked a new badge for catching an error." slaFFik 24023 3.5/wp-includes/functions.php : missing break statement General 3.5.1 normal normal Awaiting Review defect (bug) reopened 2013-04-10T02:44:54Z 2013-04-10T18:59:20Z "Line 263: {{{ switch ( $token ) { case 's' : if ( '""' !== $data[$length-2] ) return false; case 'a' : }}} Need ""break"" after ""return false"", because return happens only if condition met. Otherwise - falls to case 'a' " tivnet 24019 "Allow user to specify image size when selecting ""Media File"" as ""Link To"" target for image attachments." Media trunk normal normal Awaiting Review enhancement new has-patch 2013-04-10T00:39:26Z 2013-04-15T15:43:33Z "Currently selecting ""Media File"" as the ""Link To"" target causes an embedded image to link to the originally uploaded file. These files can be very large and there is no way to non-destructively resize them on upload while retaining this ""Link To"" functionality. This enhancement patch adds a drop down list of available image sizes to the form (defaulting to Full Size - the existing behaviour) when ""Media File"" is selected, allowing the user to link to custom image sizes as specified in their themes or plugins if desired. [[Image(http://dfcowell.net/wp-content/uploads/2013/04/attachdisplay.png)]] [[Image(http://dfcowell.net/wp-content/uploads/2013/04/attachdisplay2.png)]] This is a significant improvement over default functionality, especially when used in conjunction with a lightbox plugin. It allows the user to retain the full-size image on the server while being able to specify a link to a smaller size if desired." dfcowell 24017 Network admin sites list page displaying bad links for Dashboard and Visits Multisite normal normal Awaiting Review defect (bug) new reporter-feedback 2013-04-09T22:44:04Z 2013-04-10T06:14:46Z "After upgrading to 3.5.1 (from 3.5), we noticed that the links to Dashboard and Visits in the/wp-admin/network/sites.php weren't working properly. For subsites, the Dashboard link pointed back to the root site, and the same for the Visits link. I traced the code to the following file: /wp-admin/includes/class-wp-ms-sites-list-table.php. Line 251 currently is: {{{ $actions['backend'] = """" . __( 'Dashboard' ) . ''; }}} Adding the $blogname variable to the get_admin_url function as the second parameter fixed the issue: {{{ $actions['backend'] = """" . __( 'Dashboard' ) . ''; }}} Similarly for the Visits link. Line 272 currently is: {{{ $actions['visit'] = """" . __( 'Visit' ) . ''; }}} Changing it to the following fixes it: {{{ $actions['visit'] = """" . __( 'Visit' ) . ''; }}} " morriswanchuk 24016 RFE : Amend coding standards so that theme developers place dynamic styles in separate files Themes 3.5 normal normal Awaiting Review enhancement new 2013-04-09T21:19:08Z 2013-04-10T10:54:28Z "Currently, theme authors are placing their dynamically generated CSS styles inline of the HTML output on every page. In a recent example I have seen from a purchased theme, what should have been a ~45KB page was being sent as a ~225KB page because of dynamically generated styles. With minimal code, the styles can be moved to there own file (at least from the perspective of the client user agent) and HTTP features such as ""etag"", ""last-modified"", and ""expires"" can easily be made use of to make the browsing experience better. My suspicion is that most of theme designers are not programmers, and so would not do such a thing on their own. A standardized example would help theme designers builder leaner pages. ---- * dynamic styles -- CSS rules created based on administrator input into theme specific settings pages" pembo13 24008 Widgets title improvement Widgets normal normal Awaiting Review enhancement new 2013-04-09T18:12:17Z 2013-04-09T18:12:17Z "we have now: {{{ $title = apply_filters( 'widget_title', empty( $instance['title'] ) ? __( 'Categories' ) : $instance['title'], $instance, $this->id_base ); }}} why not to use? {{{ $title = apply_filters( 'widget_title', empty( $instance['title'] ) ? $this->name : $instance['title'], $instance, $this->id_base ); }}} " alexvorn2 24005 WordPress.org search field looks broken in Opera WordPress.org site normal minor WordPress.org defect (bug) new 2013-04-09T13:07:58Z 2013-04-09T13:13:08Z This is how it looks in Opera 12.15, Win8, x64 (see attach) seezer 23995 Weird Error After Post Published Successfully General trunk normal normal Awaiting Review defect (bug) new 2013-04-08T20:46:26Z 2013-04-09T23:20:59Z "I didn't get the exact message, but I was stuck on the New Post screen after clicking Publish with something to the effect of: The server connection has been lost. This message will go away once you get reconnected. I ended up clicking on Visit Site and I could see that the post was already published. My server has been acting up a bit today, so I figured this is a good time to test out the new post saving logic. I'm not sure if this was the intended experience though? Tested on 3.6-beta1. Only happened once so far." miqrogroove 23989 Wonky download button on plugin support forums WordPress.org site normal normal WordPress.org defect (bug) new 2013-04-08T15:27:57Z 2013-04-08T18:21:06Z "On the 'Support' tab for any plugin in the wordpress.org plugin repo, the Download button is a bit wonky. [[Image(http://i.imgur.com/5gctAEO.png)]]" johnbillion 23988 Add post info on comment.php?action=editcomment Comments 3.5.1 normal minor Awaiting Review enhancement new 2013-04-08T12:58:20Z 2013-04-08T14:54:39Z "When you get a comment notification, if you click on a link to mark as spam, etc, when you get to the edit comment screen, there's no indication of which post/page the comment was in response to, which can be a determining factor in deciding if a comment is valuable, off-topic, or spam. We should add an ""In response to"" area that lists the post title, date/timestamp like on comment list screen. If it's in response to another comment that should show as well, but since we don't have that in comment screen functionality yet, at least adding the post info that we already have and show on the list would be a clue and a step in the right direction." jenmylo 23987 add_image_size() shouldn't crop 0 values Media 3.5.1 normal normal Awaiting Review feature request new 2013-04-08T08:35:10Z 2013-04-08T08:35:10Z "When using add_image_size() the image should only be cropped by values that are entered, the following example should only crop the height, and leave the width as the upload original; {{{ add_image_size( 'wide-image', 0, 400, true ); }}} If one uploads a 1600x1600 image, the above should then crop this to 1600x400." Clorith 23986 Add filter for css class in admin Administration trunk normal minor Awaiting Review enhancement new 2013-04-08T08:23:10Z 2013-04-08T08:23:10Z It would be handy (looking at MP6), if it would be possible to alter the CSS class of `` in the backend. tillkruess 23983 Add filter to get_post_thumbnail_id to override default thumbnail use Media normal normal Awaiting Review enhancement new dev-feedback 2013-04-07T20:48:44Z 2013-04-08T00:43:56Z "The current function for getting the post thumbnail ID, used in among others `get_the_post_thumbnail`, is as follows: {{{ function get_post_thumbnail_id( $post_id = null ) { $post_id = ( null === $post_id ) ? get_the_ID() : $post_id; return get_post_meta( $post_id, '_thumbnail_id', true ); } }}} In my opinion, this needs a filter, so the user can override this by the attachment of his choosing, such as an Advanced Custom Fields image attached to the post. Something like: {{{ function get_post_thumbnail_id( $post_id = null ) { $post_id = ( null === $post_id ) ? get_the_ID() : $post_id; return apply_filters( 'post_thumbnail_id', get_post_meta( $post_id, '_thumbnail_id', true ), $post_id ); } }}} I know you can hook into the `get_{$meta_type}_metadata` filter, but getting the post thumbnail ID should still be possible by using get_post_meta, the other thumbnail should just be used for displaying." Jesper800 23982 Add array of screenshots to the Plugins API WordPress.org site normal normal WordPress.org feature request new 2013-04-07T20:31:16Z 2013-04-07T20:31:16Z The response to the `plugin_information` method of the Plugins API includes a formatted list (in a `

` turning it into ``. If we call force_balance_tags after adding the more link, we need to establish filter hooks for formatters. This should have happened before r11398 already, but because balancing tags wasn't forced, this issue has not affected sites that disable balancing tags in their preferences. Typically formatters attach to the `the_content` filter (among others). This should probably change into a `get_the_content` filter (similar to `get_the_excerpt`) that is called early on the full content of the post. I haven't yet decided where the best place for the new filter would, or if it would be better to undo the force_balance_tags call. Thoughts? I could work on the change, but would rather prefer some input first." ruckus 23973 Add filter to _wp_post_revision_meta_keys() so developers can store custom meta data revisions Revisions trunk normal normal Awaiting Review enhancement new has-patch 2013-04-07T08:14:04Z 2013-04-07T17:29:53Z "In r23928 we added functionality to: * Store the post format as meta on revisions (including autosaves). * Add post formats data (post meta) when autosaving. '''There is still no way to autosave and revision custom post meta.'''[[BR]] Adding a filter to _wp_post_revision_meta_keys() will allow developers and plugin authors to effectively save post_meta revisions. Related #20564, " c3mdigital 23971 Post Set Featured Image No Light Box Media trunk normal normal Awaiting Review defect (bug) new reporter-feedback 2013-04-07T03:51:04Z 2013-04-08T13:21:09Z "For posts when clicking on set featured image the media browser is opened in the current window instead of a light box. Setting featured image on pages works fine" azchipka 23966 Allow to use order_by in addition to orderby Taxonomy 3.5 normal minor Awaiting Review enhancement new close 2013-04-06T19:36:45Z 2013-04-09T18:44:56Z "http://codex.wordpress.org/Function_Reference/get_categories The above link and the same for wp_list_categories suggests that you can order categories by count. In practice it seems to ignore the parameter. It doesn't seem to work with a few other parameters either -- the only things that seem to work are ID, name, and slug, but these might merely be incidental to the fact that I created my test categories in alphabetical order." Denis-de-Bernardy 23958 http://wordpress.org/showcase/ is broken for retina WordPress.org site normal normal WordPress.org defect (bug) new 2013-04-06T12:19:26Z 2013-04-06T12:19:26Z "First time I do see an image but when whole page is loaded the image is ""File not found"". Only Quartz is showing up in the slider." markoheijnen 23956 jQuery UI Datepicker adds empty but visible div at bottom of page Appearance 3.5.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2013-04-06T01:52:12Z 2013-04-06T08:19:52Z "This bug seems to be related to the [http://bugs.jqueryui.com/ticket/4111 this] jQuery UI bug, which has been fixed, but the following WordPress stylesheet seems to be making the bug re-appear: wp-includes/css/jquery-ui-dialog.min.css As far as I can tell, removing the following rule seems to fix it: {{{ .ui-helper-clearfix:after { content:"".""; } }}} " julianm 23954 Checkbox value is not updated correctly inside media-views.js Media 3.5.1 normal major Awaiting Review defect (bug) new dev-feedback 2013-04-05T22:11:18Z 2013-04-06T14:43:52Z "I added two custom fields to the ""Edit Gallery"" interface using a hook and discovered that my ""select"" and ""text"" inputs were working fine, but my ""checkbox"" input did not work at all. I enabled `SCRIPT_DEBUG` so that I could explore further and discovered that the bug on line 3939 of media-views.js. A double-bang has been incorrectly used to cast from a string encoded boolean value to an actual boolean value (since !!""false"" is actually true). This is the current implementation: {{{ } else if ( $setting.is('input[type=""checkbox""]') ) { $setting.attr( 'checked', !! value ); } }}} This is my recommendation which resolves the issue: {{{ } else if ( $setting.is('input[type=""checkbox""]') ) { value = value !== false && value !== 'false'; $setting.attr( 'checked', value ); } }}} I would submit a patch, but I do not know how to do that." NumberKruncher 23951 Add filter to all sidebar widget content Widgets normal normal Awaiting Review enhancement new dev-feedback 2013-04-05T18:53:20Z 2013-05-15T21:40:41Z "I'm looking for opinions of other people here before proposing an approach for this. What I'm missing, as far as widgets are concerned, is a filter for changing widget content. I would suggest something along the lines of a filter for the content in WP_Widget's display_callback method. Using this, small changes could be made to widgets while still maintaining upgradability when the plugin, core or theme updates the widget — something that is not the case when extending the widget and overriding the widget method." Jesper800 23950 Company recognition WordPress.org site normal minor Awaiting Review feature request new dev-feedback 2013-04-05T15:13:24Z 2013-04-09T17:04:30Z "My company, and many others, have a policy of sponsoring WordPress community contribution, core and otherwise, by strongly encouraging employees to participate during paid company hours. I want to open a discussion on how this company contribution could be recognised, while not allowing ""corporates"" to take over the credits page on each release. * Would greater recognition encourage your company to foster contribution? * Should companies contributing employee time to WordPress, particularly core contributions, be recognised? * How should companies be recognised? * What are the pros and cons for the WordPress project in allowing this kind of recognition? This follows a [https://twitter.com/jenmylo/status/320144575266160640 Twitter conversation] re showing company names in the WordPress credits page, and Nacin's suggestion to open this discussion." simonwheatley 23944 Update to latest jquery.form External Libraries trunk normal normal Awaiting Review enhancement new has-patch 2013-04-04T21:16:51Z 2013-04-04T21:37:17Z "Any chance of getting the included jquery.form update to the latest version? We keep running into various script errors (mostly access) within jquery.form with IE. Updating to the latest jquery.form corrects these errors. WP using version 2.73 and the latest is 3.32 Thanks for consideration..." usermrpapa 23939 Wrong capability check in wp_ajax_replyto_comment Comments 3.1 normal normal Awaiting Review defect (bug) new has-patch 2013-04-04T18:39:21Z 2013-04-05T01:06:32Z "The wp_ajax_replyto_comment function in the wp-admin/includes/ajax-actions.php checks the ""edit-post"" capability instead of the ""edit-comment"" capability. Attached a tested patch. " fgauthier 23934 Calling sidebar two times, widgets have the same ID Widgets normal normal Awaiting Review defect (bug) new 2013-04-04T14:03:50Z 2013-04-16T00:20:26Z "If we call in the Twenty Thirteen the function of the sidebar {{{ }}} then the widgets ids from each sidebars are the same. " alexvorn2 23932 Support for remove_post_type_support() in attachment post type Media 3.5.1 normal normal Awaiting Review enhancement new 2013-04-03T22:07:02Z 2013-04-03T22:07:02Z "In the past it was possible to remove certain fields from the media editor by hooking ""attachment_fields_to_edit"" and unset'ing the fields you didn't want included (e.g. caption). After the media library got the major rework in WP3.5 its longer possible to remove those fields. I believe that since the attachment post type has been more closely lined up to normal posts it should support remove_post_type_support() et al. The easiest (and probably popular) case for this is removing the editor. I believe this code should do the trick: {{{ #!php remove_post_type_support( 'attachment', 'editor' ); }}} " flyingtrolleycars 23931 wp_insert_comment should require comment_post_ID Comments normal normal Awaiting Review defect (bug) new 2013-04-03T18:41:58Z 2013-04-03T19:06:08Z "At this moment there is no check for example comment_post_ID. Not sure if there are more checks needed. Reason I asked are a few notices on the unit tests caused by WP_UnitTest_Factory_For_Comment. Those comments don't add a post ID what should change. Currently, if a null comment_post_ID is passed, the comment isn't connected to a post. This can create confusion. Also Unit tests should run with WP_Debug on." markoheijnen 23923 wp_get_post_revisions returns incorrect order Revisions normal minor Awaiting Review defect (bug) new 2013-04-03T12:07:19Z 2013-04-08T00:27:47Z "When a post has multiple revisions and each revision has the exact same timestamp, `wp_get_post_revisions` returns revisions in reversed order, causing `wp_save_post_revision` to [http://core.trac.wordpress.org/browser/trunk/wp-includes/revision.php#L116 make a bad choice] for `$last_revision` (which is actually the first revision) and produce an extra revision, even if it has not been changed. In a normal environment this doesn't happen, unless you run `wp_update_post` several times in a row in under one second, so this is an edge case. This edge case causes our [http://core.trac.wordpress.org/browser/tests/trunk/tests/post/revisions.php#L55 revisions.php tests] to fail randomly, depending on whether the updates happened with the same timestamp or not. To reproduce, try running the revisions unit tests several times in a row." kovshenin 23922 make_clickable() breaks when colon in hash Formatting lowest minor Awaiting Review defect (bug) new needs-unit-tests 2013-04-03T00:41:39Z 2013-04-03T19:31:00Z "`make_clickable()` doesn't like this string: {{{ http://en.wikipedia.org/wiki/URI_scheme#tel: }}} It results in this HTML: {{{ http://en.wikipedia.org/wiki/URI_scheme#tel: }}} Specifically it's the colon that is causing the issue. It can be a part of the URL too, it doesn't have to be a part of an anchor." Viper007Bond 23915 discover_pingback_server_uri cases an error when discovery URI sets multiple Content-type headers Pings/Trackbacks 3.5.1 normal normal Awaiting Review defect (bug) new 2013-04-01T14:25:25Z 2013-04-02T01:58:44Z "Line 1673 in wp-includes/comment.php uses preg_match() on the output of wp_remote_retrieve_header(). When multiple headers are set of the same name, wp_remote_retrieve_header() returns an array. Thus occasionally the following error occurs: PHP Warning: preg_match() expects parameter 2 to be string, array given in xxxxxxx/wp-includes/comment.php on line 1673 I have no idea how to make pingbacks happen so to reproduce, add this line to functions.php: discover_pingback_server_uri('http://localhost:8080/'); And in a terminal window run this (you may need to install the netcat-openbsd package in Debuntu): while true; do echo -en 'HTTP/1.1 200 OK\r\nContent-type: text/html\r\nContent-type: text/plain\r\n\r\n' | nc -lp 8080; done Then visit your WP installation and you shall get the aforementioned error message." tomdxw 23914 Document WP_Dependencies Inline Docs normal normal Awaiting Review enhancement new has-patch 2013-03-31T05:58:42Z 2013-03-31T17:31:49Z "The code in `wp-includes/class.wp-dependencies.php` needs better documentation. Three confusions in particular: 1. $args has a different meaning in WP_Dependencies and _WP_Dependency. In the first, it is a way to append query strings to the URL's. In the second it is a generic 5th parameter used by the API functions wp_register_*() and wp_enqueue_*(). In class WP_Styles it stands for $media. In class WP_Scripts it stands for $in_footer. 2. `$handle` sometimes means the registered `handle`, and other times means `handle?args`. 3. `$group` stands for page placement in WP_Styles (0=header, 1=footer), and is unused in WP_Scripts (false). But a prominent comment uses the word ""Groups"" to describe something entirely different, a registered item with dependencies but no src. In my proposed documentation I use the word ""Alias"" for this meaning. An example of an alias is in wp-includes/script-loader.php: {{{ add( 'scriptaculous', false, array('scriptaculous-dragdrop', 'scriptaculous-slider', 'scriptaculous-controls') ); }}} Patch attached. No code changes. An example of contributors not knowing about Confusion 2 is #13078." kitchin 23912 Add Composer package description General 3.5 normal trivial Awaiting Review feature request new has-patch 2013-03-30T20:44:16Z 2013-05-18T18:51:47Z "WordPress, as software download, lacks machine-readable source of meta information about it. For PHP projects de-facto standard for such is Composer via `composer.json` file in project root. While WP currently doesn't use or need Composer dependency functionality, it will help provide information to developers and improve WP usage ''as'' dependency in projects that make use of Composer. Suggested `composer.json` draft: {{{ { ""name"" : ""wordpress/wordpress"", ""description"" : ""WordPress is web software you can use to create a beautiful website or blog."", ""keywords"" : [""blog"", ""cms""], ""homepage"" : ""http://wordpress.org/"", ""license"" : ""GPL-2.0+"", ""authors"" : [ { ""name"" : ""WordPress Community"", ""homepage"": ""http://wordpress.org/about/"" } ], ""support"" : { ""issues"": ""http://core.trac.wordpress.org/"", ""forum"" : ""http://wordpress.org/support/"", ""wiki"" : ""http://codex.wordpress.org/"", ""irc"" : ""irc://irc.freenode.net/wordpress"", ""source"": ""http://core.trac.wordpress.org/browser"" }, ""require"" : { ""php"": "">=5.2.4"" } } }}} " Rarst 23909 Widgets Settings Loaded When No-Needed Widgets 3.5.1 normal normal Awaiting Review defect (bug) new 2013-03-30T16:02:05Z 2013-04-03T19:21:32Z "Hi, This ticket about the performance in the back-end interface . WordPress run query to get the active widgets settings in every page even in the dashboard ! , This makes the site admin slow especially when the site have many widgets ! You can use '''Debug Bar''' & '''Debug Bar Extender''' plugins to check the queries ." alex-ye 23908 wp_nav_menu generates wrong classes for li elements Menus 3.5.1 normal normal Awaiting Review defect (bug) new dev-feedback 2013-03-30T13:42:46Z 2013-03-30T13:42:46Z "Function '''wp_nav_menu''' generates 2 different classes for '''

''' with exactly the same meaning: e.g. '''current-page-parent''' and '''current_page_parent'''. It sometimes generates one of them, but sometimes both. Also this coresponds to '''current-page-ancestor''' and '''current_page_ancestor''' classes. I think there should be one of them, but to preserve compatibility with older websites, it is better to leave both but generate both at the same time, so that user could use either ""'''-'''"" or ""'''_'''"" as separators." anyname2 23905 Add_post_meta strips slashes General 2.5 normal normal Awaiting Review defect (bug) new 2013-03-30T00:20:29Z 2013-03-30T05:32:01Z "Let's assume that JS generated an object that I want to store in custom field. Everything goes smooth when I convert it back and forth from JS to PHP and from PHP to JS (using json_encode() and json_decode()) and it even works when I do update_post_meta() manually in my file but this stops working as soon as WordPress Importer tries to load it from XML file (in XML it's still valid object) using add_post_meta(). This is the code from importer from the bottom of process_posts() function: {{{ if ( $key ) { // export gets meta straight from the DB so could have a serialized string if ( ! $value ) $value = maybe_unserialize( $meta['value'] ); $value = '{""0"":{""type"":""text"",""text"":""""},""1"":{""type"":""html"",""html"":""

here goes html

"",""css_class"":""""}}'; // I added this for test purposes add_post_meta( $post_id, $key, $value ); do_action( 'import_post_meta', $post_id, $key, $value ); }}} This is an object: {{{ {""0"":{""type"":""text"",""text"":""""},""1"":{""type"":""html"",""html"":""

here goes html

"",""css_class"":""""}} }}} It strips slashes from HTML tags (before each double quote sign) from objects that are stored as strings. I bet it shouldn't happen. Why would add_post_meta strip slashes or anything if XML explicitly says: {{{

here goes html

"",""css_class"":""""}}]]> }}} which in XML language is considered ""use as is. Do not modify"". I think that it might be a bug." Looimaster 23904 CSS glitch when the browser window width isn't right Administration normal normal Awaiting Review defect (bug) new 2013-03-29T21:20:47Z 2013-03-29T22:29:53Z "The post editor's layout now switches when the width of the window is narrow enough. But there's an intermediary zone, at least on Webkit/Safari where it's too narrow for the conditional CSS to kick in, yet too wide for the browser to deal with it. I presume, based on what I was working on a few minutes ago, that it's related to paddings. Screenshot attached." Denis-de-Bernardy 23902 Classes set with nav_menu_css_class are not accessible in walker_nav_menu_start_el Menus 3.5.1 normal normal Awaiting Review defect (bug) new 2013-03-29T20:46:33Z 2013-03-29T20:46:33Z "Hello, If you use the filter hook nav_menu_css_class to add classes to a menu item, those classes are not available in other menu filter hooks like walker_nav_menu_start_el. This can be found in the start_el function in wp-includes/nav-menu-template.php. I would think line 75: {{{ $class_names = join( ' ', apply_filters( 'nav_menu_css_class', array_filter( $classes ), $item, $args ) ); }}} Should merge those $class_names back into $item. Thanks" jamesmehorter 23895 Max upload size 0 when post_max_size = 0 Upload 3.5.1 normal normal Awaiting Review defect (bug) new 2013-03-29T15:01:32Z 2013-03-29T16:00:11Z "As a convention, post_max_size can be set to 0 to disable any limitation on max post size. Quote from php.ini: {{{ ; Maximum size of POST data that PHP will accept. ; Its value may be 0 to disable the limit. It is ignored if POST data reading ; is disabled through enable_post_data_reading. ; http://php.net/post-max-size }}} WordPress does not take this into account in wp-admin/includes/template.php " moscar09 23886 Use set_url_scheme for draft Preview links in post table Administration trunk normal normal Awaiting Review defect (bug) new has-patch 2013-03-29T01:20:52Z 2013-03-29T01:23:03Z "When using FORCE_SSL_ADMIN and this filter to prevent non-SSL preview of posts: {{{ add_filter('secure_logged_in_cookie', '__return_true'); }}} Preview links for unpublished drafts on `wp-admin/edit.php` do not use SSL and will 404. This can be fixed by using `set_url_scheme` for the unpublished preview link. A similar unpublished preview link in `meta-boxes.php` was changed to use `set_url_scheme` in [21664]. For context, see #20759, #13328." reidburke 23883 Add Media 'Title' box does not update html title attribute Media 3.5.1 normal normal Awaiting Review defect (bug) new close 2013-03-28T19:26:42Z 2013-03-30T01:05:39Z "This bug is reproduced when going to the edit page / post screen, and clicking the ""Add Media"" button. If a Title is saved for the image, it will not create a title html attribute when navigating to the site. However, if the 'Edit Image' dialog is opened for the image that was just inserted into the post / page, the Title can be saved from this screen and it will add the title attribute in the html. " drewshen 23882 get_the_permalink() accepts an ID, the_permalink() does not Permalinks 3.5 normal normal Awaiting Review enhancement new has-patch 2013-03-28T17:12:06Z 2013-04-07T02:48:26Z "I always found it odd that the_permalink() doesn't accept a post ID passed into it, when get_the_permalink() does, and the_permalink() just calls get_the_permalink(). After scouring trac for a duplicate (and not finding one) I've attached a patch to improve this. Related: #1271" johnjamesjacoby 23881 get_transient() could delete transient timeout options in an unexpected way General 2.8 normal minor Future Release defect (bug) new needs-unit-tests 2013-03-28T11:02:07Z 2013-04-22T21:17:24Z "get_transient() could delete transient timeout options if a given transient name has the ""timeout_"" prefix. To reproduce: {{{ set_transient( 'test', 'test', 60*60 ); get_transient( 'timeout_test' ); // will delete the _transient_timeout_test option }}} Solution: Check if get_option( $transient_timeout ) is not returning false. {{{ if ( false !== get_option( $transient_timeout ) && get_option( $transient_timeout ) < time() ) { }}} " tenpura 23873 Gallery shortcode orderby does not support multiple column sorting Gallery 3.5.1 normal normal Awaiting Review defect (bug) new 2013-03-27T21:13:53Z 2013-04-05T12:42:03Z "In wp-includes/media.php, function gallery_shortcode, lines 689-694 are: {{{ // We're trusting author input, so let's at least make sure it looks like a valid orderby statement if ( isset( $attr['orderby'] ) ) { $attr['orderby'] = sanitize_sql_orderby( $attr['orderby'] ); if ( !$attr['orderby'] ) unset( $attr['orderby'] ); } }}} The sanitize_sql_orderby function requires commas between multiple column names. If you enter, for example orderby=""menu_order ID"", the lack of a comma causes the parameter to be deleted from the query. Just after this test, on line 698, a multi-column sort without the comma delimiter is used as the default value. If you enter commas to get past the sanitize_sql_orderby test, logic in wp-includes/query.php, function get_posts will not accept the commas (lines 2358 - 2361) and all but the last of the columns are ignored. This issue should be considered along with those raised in #17065 and #16584. Thank you." dglingren 23870 Filter Glyph for Comment Required Fields Comments 3.5 normal normal Awaiting Review enhancement new has-patch 2013-03-27T16:57:51Z 2013-03-31T15:31:37Z "Currently the `comment-template.php` file uses an asterisk (*) as the default glyph for required fields used in the `comment_form()` function. This glyph is not easily manipulated without having to essentially over-write the entire `comment_form()` function. I suggest the glyph be filtered. Therefore if one wants to change it, for example, to a hash (#) symbol then they can simply filter the output; or, if for any other reason one might want to enhance the glyph visibility or utility the filter would then allow for this while minimizing the impact on the default comment form." cais 23867 add_rewrite_endpoint causes front-page.php template to be ignored Rewrite Rules 3.5.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2013-03-26T21:49:18Z 2013-04-16T00:50:35Z "I have a front-page.php template in my theme folder, as per the template hierarchy this is used regardless of whether I am showing posts or a page as the front page. However, when I add a rewrite endpoint (on the init hook), index.php is used for the front page template when I add my query var to the URL. It makes no difference if I set the front page to show posts or a page. If I do not add the query var, front-page.php is correctly used. i.e. http://domain.com correctly uses front-page.php, http://domain.com/nl wrongly uses index.php This happens whether I use EP_ALL or EP_ROOT as the places parameter. All other template files are fine, it's only the homepage with the problem as far as I can see." lumpysimon 23866 Wordpress xmlrpc wp_getPosts filter for slug XML-RPC 3.4 normal normal Awaiting Review enhancement new dev-feedback 2013-03-26T20:09:31Z 2013-03-26T22:29:43Z "When using the Wordpress xmlrpc, it is sometimes very useful to get posts based off of slugs rather than post id. A use case for this would be synchronizing or migrating two Wordpress sites with the same posts, but with different databases and post ID's. " SunWaves 23865 Trailing slash is not enforced when editing the path for a subdirectory site in multisite Multisite 3.0 normal normal Awaiting Review defect (bug) new needs-unit-tests 2013-03-26T19:53:23Z 2013-04-01T09:38:28Z "It is possible to edit an existing subdirectory site so that the path does not end in a trailing slash, this causes the subdirectory site in question to have an inaccessible home URL. To reproduce: * Create a multisite network in subdirectory mode * Create a new subdirectory site * Visit the subdirectory site successfully * Edit the site to change the path so there is no trailing slash * You should be unable to visit the subdirectory site now" simonwheatley 23857 Delete User Should Delete Comments Users 3.5.1 normal normal Awaiting Review enhancement new 2013-03-25T07:10:55Z 2013-04-02T04:53:31Z The delete user function should also delete that user's comments or attribute that users comments to the person specified. That way, deletion of accounts goes a lot smoother. jamcat22 23856 add style for

tag in the Dashboard Administration normal trivial Awaiting Review enhancement new 2013-03-24T17:07:21Z 2013-03-29T05:21:03Z "Lines are with black color, Lines are important to separate something in a widget for example. or in a metabox... {{{ border: 0; border-top: 1px solid #DFDFDF; border-bottom: 1px solid white; }}} " alexvorn2 23855 Leave Shortcode functions early, if there's no Shortcode delimiter Shortcodes normal normal Awaiting Review enhancement new has-patch 2013-03-24T15:15:03Z 2013-04-04T11:59:36Z "The main Shortcode processing functions (like {{{do_shortcode()}}}) all make several function calls to build the Shortcode RegEx, with a lot of array handling and string concatenation, before finally using a comparably expensive {{{preg_replace()}}} - and that's for every post that is shown on a page, even if there's no Shortcode in the post. With a quick check for the opening bracket {{{[}}}, that is required for every Shortcode, we can skip that extra work and leave those functions early to save some processing time. The attached patch adds that to {{{do_shortcode()}}}, {{{strip_shortcodes()}}}, and {{{has_shortcode()}}}. (Hat tip to bobbingwhite, who suggested this in [http://core.trac.wordpress.org/ticket/17657#comment:18 this comment] before, but it didn't gain traction as the ticket dealt with a different aspect of Shortcodes.)" TobiasBg 23851 Can we get some classes on the comment form output? Comments 3.0 normal normal Awaiting Review enhancement new has-patch 2013-03-22T20:02:00Z 2013-04-04T03:32:41Z "The `comment_form()` function is quite useful, but styling it pretty much requires that you target the IDs, since the the outermost div and the form itself don't have classes. If you're trying to stay as low on the specificity scale when writing CSS, not having classes available to target pretty much stops you cold. I don't really care about the class names, though something descriptive and somewhat semantic would be preferable. Anybody have thoughts?" nathanrice 23849 Unexpected results when running WP_User_Query with role and meta_query Query normal normal Awaiting Review defect (bug) new dev-feedback 2013-03-22T19:48:50Z 2013-04-24T00:42:11Z "There appears to be a couple of bugs in WP_User_Query when doing a role query and adding additional meta_query options (especially when relation is set to ""OR""). This code: {{{ $args = array( 'role' => 'Author', 'number' => 100, 'offset' => 0, 'meta_query' => array( 'relation' => 'OR', array( 'key' => '_my_key', 'compare' => 'NOT EXISTS', ), array( 'key' => '_my_key', 'value' => 'off', 'compare' => 'NOT LIKE', ), ), ); $users = new WP_User_Query( $args ); }}} Expected results: Any author where _my_key either does not exist or if it does exists is set to ""off"" Returned results: All authors and/or all users with _my_key set. The above generates this SQL: {{{ SELECT DISTINCT SQL_CALC_FOUND_ROWS wp_users.* FROM wp_users INNER JOIN wp_usermeta ON wp_users.ID = wp_usermeta.user_id INNER JOIN wp_usermeta AS mt1 ON (wp_users.ID = mt1.user_id) INNER JOIN wp_usermeta AS mt2 ON (wp_users.ID = mt2.user_id) WHERE 1=1 AND (wp_usermeta.meta_key = '_pigeonpack_subscription' OR (mt1.meta_key = '_pigeonpack_subscription' AND CAST(mt1.meta_value AS CHAR) NOT LIKE '%off%') OR (mt2.meta_key = 'wp_capabilities' AND CAST(mt2.meta_value AS CHAR) LIKE '%\""Author\""%') ) ORDER BY user_login ASC LIMIT 100 }}} This seems like a bug to me, the ""Author"" meta should not be modified by the relation => 'OR' argument and thus should not be included in the other meta query statement. Further, the NOT EXISTS isn't a true NOT EXISTS statement. In fact, I'm not even sure why the NOT EXISTS statement looks the way it does. I haven't had too much time to look into this any more in depth. I tested this in WP3.5 and Trunk " layotte 23847 "Media Manager default ""link to"" setting overriding custom setting" Media 2.7 normal minor Future Release defect (bug) new 2013-03-22T17:58:40Z 2013-04-04T03:18:58Z "http://core.trac.wordpress.org/browser/trunk/wp-includes/js/media-views.js#L444 The line I'm looking at is this: {{{ link: defaultProps.link || getUserSetting( 'urlbutton', 'file' ) }}} {{{getUserSetting( 'urlbutton', 'file' )}}} returns the correct value that I set in the theme on 'init' with {{{set_user_setting( 'urlbutton', 'none' )}}} but that value is not saved on this line because defaultProps.link has already been set to 'file'. I can't figure out why it tests for a default setting before a user setting, and not the other way around" joshkadis 23845 Install new theme via FTP failed Filesystem 3.5.1 normal normal Awaiting Review defect (bug) new has-patch 2013-03-22T12:19:03Z 2013-04-10T21:12:23Z "New theme installation via FTP has failed when we specified custom FTP_BASE folder. If we try this theme installation , wordpress shows error message: ""Unable to locate WordPress theme directory"". This was because search_for_folder method do not respect FTP_BASE setting and allows to walking on parent directories. All solutions I found in google is ugly hacks who only mask the problem but does not resolved it I attached patch example who resolve this problem. I hope is useful and will help to repair this bug." Przemyslaw Plewa 23836 add_submenu_page() duplicate menus Administration normal major Awaiting Review defect (bug) new 2013-03-21T16:43:24Z 2013-04-04T03:22:08Z "Creating two sub-menus with the same ""menu slug"" using add_submenu_page() should create only the last sub-menu. But it creates two sub-menus with the same ""menu slug"". Based on documentation ""menu slug"" should be unique for each sub-menu." king_of_the_ring 23834 Twenty Thirteen: add visual Indicator for menu items with children Bundled Theme trunk normal normal Future Release enhancement new 2013-03-21T04:07:43Z 2013-03-21T23:38:44Z "It's helpful to have a visual indicator when a top level menu item contains a hidden drop down menu. This patch adds a filter to wp_nav_menu_objects in order to add the class ""has-children"" to top level menu items that contain children. This allows us to style it with psuedo element, similar to how the menu-toggle is styled for smaller screens. The filter I used was posted by @chipbennet on the WordPress Theme Reviewers List. The same functionality could also be achieved by a Custom Nav Walker (see http://wptheming.com/2013/03/drop-down-menu-indicator/), but Chip's solution seemed more straightforward. Neither method works unless a menu has actually been set. " downstairsdev 23833 Add a unique ID or NAME to target queries . Query normal normal Awaiting Review enhancement new 2013-03-21T03:03:43Z 2013-05-08T21:48:03Z "I am not sure if this is enhancement or feature request .[[BR]] wordpress allows us to change / filter queries with various methods , for example the pre_get_posts(). ( e.g. $query->set ($args) ). But in today´s wp ecosystem, there are so many themes, plugins, widgets etc. that modify the query or add custom queries, that it had become very difficult to target a specific query, where The available conditions might not be enough. (is_admin, is_main_query etc.. ) The suggestion here is to add an identifier (ID or specific NAME) to a query , much like with textdomains or actions. In this manner, targeting a query becomes a breeze something along the lines of {{{ #!php $query->set($query_id_or_name,$args) }}} Each developer has struggled one time or another with custom queries and with targeting 3rd party queries . This feature / enhancement could potentially change all that by allowing a simple way to address custom queries ." krembo99 23832 Nav menu screen text tweaks Menus trunk normal normal Awaiting Review enhancement new has-patch 2013-03-20T22:38:08Z 2013-03-21T17:23:57Z johnbillion 23826 Funky conditional tags for posts archive Query trunk normal normal Awaiting Review defect (bug) new 2013-03-20T13:51:22Z 2013-04-04T04:14:12Z "If a WordPress install is set to ""Front page displays ... Your latest post"", then some funky conditional tags are set. Of interest here are: {{{ [""is_home""]=> bool(true) }}} Sure, makes sense. {{{ [""is_post_type_archive""]=> bool(false) }}} Erm, what? Isn't this the post type archive for the posts post type? {{{ [""is_archive""]=> bool(false) }}} Isn't this also an archive? This means is_post_type_archive( 'post' ); doesn't work anywhere. I also attempted creating a ""posts page"" for blog posts, and got the same results." ericlewis 23825 Demand to disable plugins in order to create a network doesn't make sense Network Admin 3.0 normal normal Awaiting Review defect (bug) new 2013-03-20T11:02:37Z 2013-04-03T14:46:47Z "1. have some plugins active on a stand alone WP 2. add define('WP_ALLOW_MULTISITE', true); to wp-config.php 3. go to ""tools"" >> ""Network Setup"" and you get a ""Warning: Please deactivate your plugins before enabling the Network feature."" 4. you have to disable the plugins in order to continue the process And I have to ask why? This doesn't make sense for the following reasons 1. Why plugins and not themes? any ""bad"" code that can be in a plugin can also be in a theme. 2. If the plugins provide essential functionality, then my site will stop behaving as expected. This basically will put the site in maintenance mode, so why not to do it automatically in the code to be able to get faster in and out of this mode? 3. Did it ever happened that a plugin ruined a network install? At the least this should be treated as a warning and not as an error, i.e. the text get displayed but the user can continue with the process if he decides to ignore the warning." mark-k 23822 Invalid Plugin Contributors JSON from WP.org Plugin API WordPress.org site normal normal WordPress.org defect (bug) new 2013-03-19T23:41:46Z 2013-03-20T05:39:59Z "Under some rare conditions, some plugins can break the plugin API with invalid JSON, specifically in regards to the list of contributors returned. This is likely because of the string encoding used to either parse or store the values returned from the plugin file headers. Basically though, it results in using a null name for a JSON object member where there absolutely needs to be a string. For example, the ""Aaaaah Lek Lek"" plugin (aaaaaaah-lek-lek) returns the following JSON: {{{ { ""name"": ""Aaaaah Lek Lek"", ""slug"": ""aaaaaaah-lek-lek"", ""version"": ""1.0"", ""author"": ""Valério Souza<\/a>"", ""author_profile"": ""http:\/\/profiles.wordpress.org\/valeriosza"", ""contributors"": { null: """" }, ""requires"": ""3.0.1"", ""tested"": ""3.5.1"", ""compatibility"": [ ], ""rating"": 0, ""num_ratings"": 0, ""downloaded"": 20, ""last_updated"": ""2013-03-12"", ""added"": ""2013-03-12"", ""homepage"": ""http:\/\/valeriosouza.com.br"", ""sections"": { ""description"": ""

Coloque a frase da música LekLek em seu WordPress, dentro do painel administrativo.<\/p>"", ""installation"": ""

Siga para Instalar<\/p>\n\n

Faça Upload aaaaaaah-lek-lek<\/code> para a pasta \/wp-content\/plugins\/<\/code><\/li>\n

Ative no menu 'Plugins' no seu WordPress<\/li>\n<\/ol>"", ""changelog"": ""1.0<\/h4>\n\n\nLançada Versão 1.<\/li>\n<\/ul>"", ""faq"": ""What about foo bar?<\/h4>"", ""other_notes"": "" Arbitrary section<\/h3>"" }, ""short_description"": ""Coloque o Lek Lek no seu WordPress"", ""download_link"": ""http:\/\/downloads.wordpress.org\/plugin\/aaaaaaah-lek-lek.zip"", ""tags"": { ""frases"": ""frases"", ""leklek"": ""leklek"" } } }}} JSONLint comes back with: {{{ Parse error on line 7: ...ibutors"": { null: """" }, ----------------------^ Expecting 'STRING', '}' }}} These plugin details come from these files: * http://plugins.svn.wordpress.org/aaaaaaah-lek-lek/trunk/readme.txt * http://plugins.svn.wordpress.org/aaaaaaah-lek-lek/trunk/leklek.php (it mentions a stable tag, but there are no actual tags) You might also notice that Extend is unable to display these details correctly either: http://wordpress.org/extend/plugins/aaaaaaah-lek-lek/" bpetty 23808 allow multisite to match bare URL Multisite 3.5 normal normal Awaiting Review enhancement new 2013-03-18T13:33:07Z 2013-04-01T09:39:30Z "Currently, when matching the requested URL to a blog, the ""domain"" and ""path"" are used together. When there is no match, no blog will be selected. $path can never be interpreted as just ""/"". This makes it impossible to have multiple domains working from the root ""/"" pointing to separate blogs. The attached patch makes this possible. A little more in-depth explanation can be found here: http://wordpress.org/support/topic/allow-multisite-to-match-bare-url?replies=4 " fuentez 23806 Nav Menu Edit Walker per menu item type, not menu? Menus normal normal Awaiting Review enhancement new 2013-03-18T02:09:11Z 2013-03-19T11:53:01Z "The assignment of a walker to show the menu items on the right side of the Menus screen is set per menu in `wp_get_nav_menu_to_edit()`. Ideally, it could be overridden per menu item type. That is, posttype, custom and taxonomy menu items can be handled by `Walker_Nav_Menu_Edit`, while a menu item (in the same menu) or 'foobar' can be handled by the `start_el()` from a different walker. As things stand, I'd have to extend `Walker_Nav_Menu_Edit`, copy `start_el()`, and place the conditional code for what to output in there (in my case, strip out fields that aren't ever going to be used in my 'foobar' menu item type)." GaryJ 23805 wp_ajax_add_menu_item() closed to user-created menu item types Menus normal normal Awaiting Review defect (bug) new has-patch 2013-03-18T01:41:52Z 2013-03-19T11:53:02Z "I'm building a new Menus meta box, that can add a new type of menu item, lets call it 'foobar'. The conditional inside `wp_ajax_add_menu_item()` is slightly off. It checks that the menu item type is not 'custom', then proceeds to assume that it's either post-type or taxonomy so it can do some DB look-ups and create an `$_object` variable which is then used. This means it's closed to other types of menu items. I've chosen 'foobar', so I can distinguish those items later on when walking through the front-end output." GaryJ 23800 Filter Comment Blacklist, to delete duplicated terms Comments normal normal Awaiting Review enhancement new 2013-03-16T23:37:13Z 2013-03-16T23:37:13Z "Hi, In Comment Blacklist, when I save terms, duplicates are not eliminated. Would be good if the function array_unique would remove these duplicate terms." shadowhck 23797 Hard coded HTML marking in comment_form() Comments 3.5.1 normal normal Awaiting Review enhancement new 2013-03-16T21:16:23Z 2013-03-17T14:50:58Z "Hello it seems so ugly hard coding has slipped in the comment form. On line 1554 of comment-template.php, there is some hard-coded html : {{{ }}} Semantically speaking, a H3 is far from being optimal. Also, filters exists for all other elements of the comment form. The h3 and small should not be hardcoded. A new value could be included in the defaults : {{{ 'comment_reply_markup' => '%1$s %2$s', }}} and line 1554 replaced by : {{{ }}} Thanks a lot, hope you'll take it :)" Marie-Aude 23794 load_plugin_textdomain fails if plugin is loaded from mu-plugins I18N 3.5.1 normal minor Future Release enhancement reopened 2013-03-16T09:48:38Z 2013-05-08T12:43:08Z "load_plugin_textdomain is realative to WP_PLUGIN_DIR, so it fails to load localization files if plugin keeps them in its directory. The function should check if is called from mu-plugins and use WP_MUPLUGIN_DIR in that case. I can fix this in my own plugin by adding '../mu-lugins/' like this: {{{ load_plugin_textdomain( 'tiny_tribuna', false, '../mu-plugins/'.dirname( plugin_basename( __FILE__ ) ) . '/languages/'); }}} but this is not a good option for other plugins. " ideag 23788 get_posts(array('post_type' => 'any')) Should include custom post types in result Post Types 3.5.1 normal minor Awaiting Review enhancement new dev-feedback 2013-03-15T15:07:49Z 2013-04-16T00:35:08Z "Hi, I have a post type called with the id of 'career'. When I use post_type => 'any' I don't get results from this post type even though it is set to public. Are custom post types automatically ignored when using 'any'? When replacing 'any' with 'career' it works fine." keendev 23786 Shortcodes working inside HTML and PHP comments Shortcodes normal minor Awaiting Review enhancement new 2013-03-15T11:59:25Z 2013-03-15T14:06:02Z "I think that shortcodes should not work inside html or php comments. The following comment inserted in the Wordpress editor shows the images gallery, breaks the layout of the theme and shows after the gallery these characters --> If I use do_shortcode() in a plugin with a shortcode inside a php comments, it's the same as it is with html comments." javitxu123 23785 highlight rows on hover for tables with widefat class Administration 3.5 normal minor Awaiting Review enhancement new 2013-03-15T10:57:06Z 2013-04-02T20:58:26Z "If .widefat tables had this css code system-wide (wp-admin.css) {{{ .widefat tr:hover td { background-color: #DDD; } }}} handling these tables on (extreme) widescreens would be improved. [[Image(http://picload.org/image/aocipap/widefat.jpg)]]" cfoellmann 23781 New Post Publishes to Wrong URL General 3.4.2 normal major Awaiting Review defect (bug) new 2013-03-15T04:59:52Z 2013-03-16T01:13:12Z "The ""Permalink"" displayed in the editor for new posts may be wrong, and changes (surprise!) when the Publish button is clicked. Steps to reproduce this: 1. Start typing a title in a new post. 1. Wait for an auto-save and Permalink to appear. 1. Make the title longer. 1. Type a post body. 1. Click Publish. Expected result: The new post should be published at the Permalink being displayed on the post editor. Actual result: A completely different permalink is generated based on the current title. The new page gets cached at the ""wrong"" URL before any changes can be made. General pandemonium ensues. Etc. (It's not a blocker bug, but it is so completely annoying!)" miqrogroove 23778 How do you keep WordPress from removing the non-breaking space? TinyMCE 2.0 normal normal Awaiting Review defect (bug) reopened 2013-03-15T00:02:25Z 2013-03-15T08:51:41Z "I am hoping you guys have a simple solution for me. I would really appreciate it. I am doing a lot of porting existing sites to be wordpress sites and I have notived that every time there is a non-breaking space it removes it fron the code when it is saved or when switching back and forth between visual and text mode. I have combed google for a solution and come up with nothing but other people complaining about the same thing with no real solution. Thoughts anyone?" spherman 23776 "A string of text starting with ""http://"" turned into a paragraph" Embeds 2.9 normal normal Awaiting Review defect (bug) new 2013-03-14T21:11:00Z 2013-03-15T07:10:14Z " In either editor, if there's a line of text that starts with http:// wordpress will create a new paragraph. This description box isn't working to show what I mean see this support post. http://wordpress.org/support/topic/a-string-of-text-starting-with-http-turned-into-a-paragraph" winterstreet 23768 Add option to turn post gallery into a slideshow Media normal normal Awaiting Review enhancement new close 2013-03-14T14:09:34Z 2013-04-04T05:10:18Z To build on the improvements to the WordPress Media manager, it would be great to have an option built-in to output a gallery as a slideshow. ericlewis 23767 remove_menu_page: Check for existing menu items Warnings/Notices 3.5 normal normal Awaiting Review enhancement new close 2013-03-14T13:32:47Z 2013-03-16T17:56:37Z "This error appears in my error log: ''PHP Warning: Invalid argument supplied for foreach() in /www/htdocs/wp-admin/includes/plugin.php on line 1290'' The if-empty patch is attached. " sergej.mueller 23764 "Add ""works for this version"" to the plugin review form" WordPress.org site normal normal WordPress.org feature request new 2013-03-14T00:56:30Z 2013-04-04T04:49:05Z "It would be nice if users could select whether a plugin ""works"" for their selected !WordPress version in the plugin review form. Obviously, the main ""Does it work? form"" would stay on the main areas of the plugin page, but this would, I think, help balance the reviews:works stats for many plugins. This would also be related to #23704." DrewAPicture 23760 Cannot use spacebar to trigger OK button or links in Publish widget (eg. schedule settings) Accessibility 3.5.1 normal minor Awaiting Review defect (bug) new 2013-03-13T16:23:43Z 2013-04-19T23:16:59Z "When changing the scheduled publishing time of a post, the OK button after the time fields cannot be triggered by pressing spacebar. The same applies to all buttons and links in the Publish widget on the Add New / Edit Post page. The Add button in the Tags widget on the same page can be triggered with space since WordPress 3.5. Steps to repeat: 1. Create a new post by navigating to wp-admin/post-new.php. 2. Click the underlined link in ""Publish immediately _Edit_"" in the Publish widget. 3. Click the last field (minutes). 4. Press Tab once to move focus to the OK button. 5. Press spacebar. What happens is the screen scrolling down exactly as if Page Down was pressed. What should happen is the same that happens when the button (or link) is clicked with mouse, which depends on the button (or link). Tested on Windows XP & 7 and all the recent Firefoxes I can remember and Internet Explorer 9." Daedalon 23759 Pass $update to save_post and wp_insert_post actions Post Types 3.5.1 normal normal Awaiting Review enhancement new has-patch 2013-03-13T15:14:35Z 2013-04-04T04:23:44Z For now it's hard to check if the post is updated or publish for the first time when using save_post and wp_insert_post hooks alex-ye 23758 Add hook after loading WordPress locale object I18N 3.5.1 normal normal Awaiting Review enhancement new close 2013-03-13T14:58:37Z 2013-04-24T02:39:09Z "We face some problems when we work on bbPress last month , see :[[BR]] http://bbpress.trac.wordpress.org/ticket/2219 There is no proper hook to add roles ( an example ) in WordPress ,[[BR]] especially when you use a translated display name .. You can also read some lame in bbPress source code [[BR]] ""This is kind of lame, but is all we have for now. "" http://bbpress.trac.wordpress.org/changeset/4773" alex-ye 23757 convert_smilies should not convert in pre,code tags Formatting 3.5.1 normal normal Awaiting Review defect (bug) new 2013-03-13T14:26:07Z 2013-03-14T11:22:31Z "This related to this ticket [[BR]] #23756 The purpose to this ticket is to make writing codes in posts more easier !! " alex-ye 23756 make_clickable should not convert the URLs in pre,code tags Formatting 3.5.1 normal normal Awaiting Review defect (bug) new 2013-03-13T14:17:36Z 2013-03-14T10:44:29Z "Hi , Maybe it's a duplicate ticket but I tried to search in history. Anyway , The purpose of this ticket is to have a clean snippet code posts .. for now it's hard to do it by plug-in .. and many people remove make_clickable filter at all ! So let's make it possible in 3.6 :)" alex-ye 23755 Old /files/ support in new installs Multisite normal minor Awaiting Review defect (bug) new 2013-03-13T13:54:10Z 2013-03-15T13:35:17Z "I moved a blog to a new network that using new upload folder system. Problem is: old /files/ links that using ms-files.php are not working. My temporary fix: Added in .htaccess: {{{ # uploaded files RewriteRule ^files/(.+) wp-includes/ms-files.php?file=$1 [L] }}} Added ms-files.php: {{{ define( 'BLOGUPLOADDIR', WP_CONTENT_DIR . ""/uploads/sites/{$current_blog->blog_id}/"" ); }}} above of: {{{ $file = rtrim( BLOGUPLOADDIR, '/' ) . '/' . str_replace( '..', '', $_GET[ 'file' ] ); }}} Solution is working but I am not happy because it needs to edit core files. Is this working as intended? If it is, what is proper way to define BLOGUPLOADDIR for ms-files.php without breaking anything or editing ms-files.php" unsalkorkmaz 23750 Uploads go into subdirectory install of WordPress Multisite 3.5.1 normal normal Awaiting Review defect (bug) new 2013-03-12T22:10:59Z 2013-03-13T02:26:44Z "In upgrading a few sites to WordPress 3.5 and then giving WordPress its own directory (`wp/`), we continually see the uploads end up in `wp/wp-content/blogs.dir` instead of `wp-content/blogs.dir`. For the time being as a work around we have enabled a network wide plugin that consists of {{{ function ms_upload_fix($uploads) { $uploads['path'] = str_replace('/wp/', '/', $uploads['path']); $uploads['basedir'] = str_replace('/wp/', '/', $uploads['basedir']); return $uploads; } add_filter('upload_dir', 'ms_upload_fix'); }}} We do have `WP_CONTENT_DIR` defined and assume it should use this if set." jondavidjohn 23749 Post Format Archive Conditional Tag Template normal normal Awaiting Review enhancement new 2013-03-12T20:27:04Z 2013-03-13T01:47:41Z "As far as I know there is no conditional tag for detecting when a post format archive is shown. I bumped into this problem while creating a theme for quick-blogging and realized that I couldn't create a menu (easily) and style the 'current' post format menu item differently. I will try and submit a diff if I can although I've never done it before so it may take me a while :) " danielpataki 23748 Suggest rewrite rules on IIS Network (Multisite) Multisite 3.5.1 normal normal Awaiting Review defect (bug) new 2013-03-12T18:23:35Z 2013-03-12T18:23:35Z "Server: Microsoft IIS - 8 Wordpress: 3.5.1 (multisite) On subfolder install, suggest for web.config is: {{{ }}} On sudomain install, it is: {{{ }}} I think that Wordpress Rules for files and Wordpress Rule 4 and 5 should follow same rules than htaccess suggest. When following actual suggest in a subfolder installation, I get an HTPP Error in call to sub site, error is always reproductible for me - can you confirm. A fix could be to add a subdir replacement rule {R:1} for subdomain install and {R:2} for subfolder. Implementation in the network.php file (adding $iis_subdir_replacement_12): {{{ $iis_subdir_replacement = $subdomain_install ? '' : '{R:1}'; $iis_subdir_replacement_12 = $subdomain_install ? '{R:1}' : '{R:2}'; $web_config_file = ' '; if ( is_multisite() && get_site_option( 'ms_files_rewriting' ) ) { $web_config_file .= ' '; } $web_config_file .= ' '; }}} Sorry for my english :) regards " guy_fr 23747 Ordering Categories Taxonomy normal normal Awaiting Review feature request new dev-feedback 2013-03-12T10:14:05Z 2013-03-12T11:17:06Z There should be provision to order categories. This will open up many possibilities to use with CustomPost types. valllabh 23746 add_role require string does not check for empty string Role/Capability 3.5.1 normal normal Awaiting Review defect (bug) new has-patch 2013-03-12T03:45:33Z 2013-03-13T01:16:16Z " `` add_role works with $role as `''`. Perhaps it should check for empty string before allowing it to be added? " Kenshino 23738 Audit our secondary button uses Administration trunk normal normal Future Release enhancement new 2013-03-11T17:31:26Z 2013-05-16T12:12:03Z "helen pondered in #wordpress-ui that maybe the ""apply"" button in the Screen Options dropdown should be a primary button. There's a good argument to be made that when this panel is down, that ""apply"" button is your new primary. We should do an audit of our buttons to see if there are any other cases where we could make an action or a temporarily primary action more obvious by using the primary button style." markjaquith 23734 Pass more information to wp_dropdown_pages filter Template normal normal Awaiting Review enhancement new has-patch 2013-03-09T23:26:08Z 2013-04-17T02:28:20Z We need to pass more information to the 'wp_dropdown_pages' filter for others to make decisions with. Here's a small & quick patch for passing more args to the filter. bigdawggi 23731 Use jQuery Menu Aim to improve responsiveness of our admin menus Administration normal normal Awaiting Review enhancement new 2013-03-09T16:00:11Z 2013-03-15T21:01:34Z "This is a fantastic read: http://bjk5.com/post/44698559168/breaking-down-amazons-mega-dropdown And it resulted in an MIT-licensed jQuery plugin that we should absolutely consider using to improve our menus: https://github.com/kamens/jQuery-menu-aim" markjaquith 23729 Ticket #11289, IE bug fix: always pad the error page with enough characters General normal normal Awaiting Review defect (bug) new reporter-feedback 2013-03-09T06:25:21Z 2013-03-20T15:59:02Z Is it really such a good idea to put the padding where it is currently in the error pages? This causes all sorts of problems with Dom parsers... it should be placed somewhere after the html tag or better yet in the body... almost looks like someone is very proud of their fix and wants the world to see it lol wp4j 23728 Errors when trying to upload media before saving network settings Multisite normal major Awaiting Review defect (bug) new reporter-feedback 2013-03-09T03:28:47Z 2013-03-21T16:43:14Z "foreach warning due to unpopulated $mimes array and denial of uploads even when file types defined in network admin settings. This seems to happen because there is a disconnect between the defaults and what is actually present in the db (before the first save). Should be noted that the site was installed programmatically using wp_install() so this may have something to do with it. I am giving this a major severity because the server path is disclosed from the foreach warning and the least that should be done is do an is_array() check on that $mime var and give a meaningful message stating that there are no mimes defined or something..." wp4j 23724 Pass $post into 'protected_title_format' and 'private_title_format' filters Template 3.5 low minor Awaiting Review enhancement new has-patch 2013-03-08T22:53:57Z 2013-03-09T05:22:43Z "Currently it's only possible to change these prefixes globally. Being able to change these prefixes based on specific $post data would be helpful for narrowing down the scope, say to specific custom post types. I noticed also that we don't pass $post into the 'the_title' filter, which could cut down on an additional get_post() call later if we pass it here. Obviously not essential, but wouldn't hurt." johnjamesjacoby 23721 Better control of textdomains. I18N normal normal Awaiting Review enhancement new 2013-03-08T07:23:45Z 2013-03-08T13:19:37Z "At the current state , loading a text domain is done by the plugin/theme author , and leaves no control to the user / other devs to intervene with this process. we are left to the mercy and good will of the original author . It would be a good thing to create some HOOK or ACTION that will allow a user to override this somehow. At the very least (and maybe it should be a different ticket) a function that will return all available $domain names and paths should be made available (currently no way of retrieving that but parsing the $i18n global) Example : If a user need a plugin/ theme that does not have a translation for my desired language , or a BAD translation (or no translation at all) the user then creates it´s OWN translation, and by dropping it inside wp-content/languages folder , that translation will be loaded instead of the one supplied (or not supplied ) with the original plugin / theme . Current state : If a user loads a translation to the original plugin folder for translations, it will be deleted upon first update . " krembo99 23720 Make it obvious that by default support for plugin and themes in the repository is not guaranteed WordPress.org site normal minor WordPress.org feature request new 2013-03-08T07:10:13Z 2013-03-08T15:24:09Z "Or even better, people should assume it doesn't exist. This follows the discussion here http://tommcfarlin.com/upgrade-wordpress/ I know it is possible to add a text to that effect in the readme.txt file, but it is not the same, and you can't expect plugin authors to release new versions just to reflect the change in their available time. Alternatively support policy should have a tab of its own on the plugin's page. In addition, there should be a way to contact someone that will provide paid support for the plugin. By default it should be the plugin's author, but it might be a good idea for other people to be able to provide this kind of service as well." mark-k 23712 My browser is NOT out of date WordPress.org site normal minor WordPress.org defect (bug) new 2013-03-07T15:42:29Z 2013-03-09T23:36:13Z "Hello. I'm running Win7 64bit with Firefox 19.0. When I log in my wordpress site admin panel an orange box pops up saying I should update my browser. The operating system and the browser are completely updated." assenoff 23711 file include wrapper for media_sideload_image Media 3.5 normal normal Awaiting Review enhancement new dev-feedback 2013-03-07T15:14:26Z 2013-03-10T06:07:52Z "Currently, when using `media_sideload_image` outside of wp-admin, you are required to load three extra files, as explained at [http://codex.wordpress.org/Function_Reference/media_sideload_image#Notes the bottom of this codex page]. This function simply calls those three files, but will allow flexibility in future versions if those file dependencies change." norcross 23709 Relax wildcard restrictions for populate_network() when installing in subdomain mode Multisite 3.5 normal normal Awaiting Review enhancement new has-patch 2013-03-06T20:03:49Z 2013-04-01T09:25:14Z "I ran into the issue while trying to use wp-cli install-network command with --subdomains support. Underlying core issue is that populate_network is trying to check if wildcard subdomain is accessible. This makes sense for large networks, but might not work with certain setups, or not needed for small sites. Proposed solution is to add extra arg for populate_network() $wildcard_check with default to true. See attached patch" rinatkhaziev 23704 Add a field onto WordPress.org support forums for plugin version number WordPress.org site normal normal WordPress.org enhancement new 2013-03-06T06:17:31Z 2013-03-14T00:57:15Z "WordPress.org support forums ask the user to specify the version of WordPress they are using. In plugin-specific support forums such as http://wordpress.org/support/plugin/events-manager there should also be a field for the plugin version number. Like the WordPress version number, this should be a dropdown list, for which the values should be available in the WordPress.org database. This way plugin authors don't need to ask the user for that version, which speeds up the resolution of support tickets and saves the plugin authors' time, letting them concentrate more on creating and improving the plugins." Daedalon 23694 Shortcode attributes mess up html strings Shortcodes 3.5.1 normal normal Awaiting Review defect (bug) new dev-feedback 2013-03-05T15:15:48Z 2013-03-07T03:42:37Z "{{{ [shortcode attribute=""some HTML""/] }}} produces: {{{ some HTML }}}" prometh 23692 feed_links should have a parameter to choose which feed to display Feeds normal minor Awaiting Review enhancement new dev-feedback 2013-03-05T14:02:12Z 2013-04-05T08:52:19Z "Hello, '''feed_links''' is a function located in wp_includes/general_template.php. It displays 2 feeds in the header : the main feed and the comment feed. The function is activated along with feed_links_extra when automatic-feed-links support is activated. Currently, developers can't choose if they want both feeds to be displayed, or just one of them. I think this function should be improved. Here is the current function : {{{ function feed_links( $args = array() ) { if ( !current_theme_supports('automatic-feed-links') ) return; $defaults = array( /* translators: Separator between blog name and feed type in feed links */ 'separator' => _x('»', 'feed link'), /* translators: 1: blog title, 2: separator (raquo) */ 'feedtitle' => __('%1$s %2$s Feed'), /* translators: %s: blog title, 2: separator (raquo) */ 'comstitle' => __('%1$s %2$s Comments Feed'), ); $args = wp_parse_args( $args, $defaults ); echo '\n""; echo '\n""; } }}} Currently, the only way to display only one feed (the main post feed or the main comment feed) so is to deactivate feed_links with : {{{ remove_action('wp_head', 'feed_links', 2); }}} and then to create our own function to only display one feed. Do you think this should be improved ? Regards," Confridin 23691 Visiting post-new.php using the back button overwrites an existing post Autosave normal normal Awaiting Review defect (bug) new 2013-03-04T18:54:46Z 2013-03-04T18:54:46Z "1) visit post-new.php 2) write a post 3) publish it 4) click back in your browser 5) write a new post 6) if you save it as draft or publish it, it will overwrite the old post Reproducable in Firefox, Chrome and Safari." jkudish 23687 Filter Contextual Help Label Help/About 3.5 normal normal Awaiting Review enhancement new close 2013-03-04T11:54:04Z 2013-03-04T17:40:07Z "The contextual help feature is a great way to add help to themes and Plugins. However, we often find that our theme/Plugin users do not even notice the generic 'Help' button on the top right of the admin screen. It would be useful to be able to customise this label to include the theme/Plugin name so users know this is help specific to that theme/Plugin and not just WordPress generated help. Currently there is no way to filter the help label. It is fixed to 'Help'. I have included a patch that allows you to filter it to display your own custom help label such as 'Plugin Help', 'Theme Help' etc. Usage is then: {{{ function custom_label($label, $screen_id){ global $options_page_id; if ($screen_id == $options_page_id) $label = __( 'Plugin Help' ); return $label; } add_filter('contextual_help_label', 'custom_label', 10, 2); }}} " dgwyer 23686 wp_handle_(upload|sideload) have a lot of copy-pasted code from each other Upload trunk normal normal Awaiting Review enhancement new 2013-03-04T11:27:35Z 2013-03-04T17:49:36Z A huge part of those two functions is the same. It needs to be refactored, so that they share the code. nbachiyski 23685 Explicitly globalize version variables Unit Tests trunk normal normal Awaiting Review defect (bug) new has-patch 2013-03-04T11:00:09Z 2013-03-04T17:24:03Z "When WordPress is loaded in a function (e.g. unit tests) the variables initialized at the top level aren't globals, but we expect them to be. For example, if in a unit test there is no way to access `$wp_version`. Neither via `$wp_version` (it's not in the same scope), not via `$GLOBALS['wp_version']` (it's not a global). To fix that we need to explicitly make the version variables global. See #17749." nbachiyski 23680 Obsolete function previously used in Theme Editor Administration normal normal Awaiting Review enhancement new 2013-03-04T03:15:56Z 2013-03-04T03:15:56Z "`get_real_file_to_edit()` is unused since [12063] and should probably be deprecated: [[BR]] http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/includes/file.php#L96" SergeyBiryukov 23677 Feed autodiscovery for custom taxonomy and perhaps date archives General 3.5 normal normal Awaiting Review enhancement new 2013-03-03T16:53:09Z 2013-03-03T16:53:09Z "In #21648 we enabled the ""autodiscovery"" of feeds for custom post types. Further review of this solution reveals a few remaining issues: a) Function `feed_links_extra()` in file `wp-includes/general-template.php` still does not add `` tags for autodiscovery of either custom taxonomy archives or date (year/month/day) archives. You can argue that feeds for date archives might not be particularly useful, but they are generated, so why do we not provide links to them? A helper function does exist to obtain the link for custom taxonomy archive feeds, but there is no corresponding support for date archives. b) The helper functions for obtaining feed links in file `link-template.php` are not particularly easy to use, requiring much examination of the queried object. If a theme or plugin wishes to include explicit hyperlinks to feeds (i.e. `` tags) then it is presently forced to duplicate much of the code from function `feed_links_extra()`. I suggest the bulk of the code from here should be moved into a new function within `link-template.php` where it can be reused to generate either `` or `` tags as needed. c) We seem to have a helper function for feeds containing search results with comments (`get_search_comments_feed_link()` in `wp-includes/link-template.php`). Whilst this feed is generated, it's not clear why ""search"" is treated specially here and why if this was considered useful there are no corresponding feeds for comments on other archives." mdgl 23669 Allow front page template to fall back to home template when site displays blog posts index on front page Template 3.5.1 normal normal Awaiting Review enhancement new has-patch 2013-03-02T21:15:25Z 2013-03-03T06:00:01Z "The `front-page.php` template file is intended to define custom, static front page content. However, this template file takes precedence, regardless of whether `get_option( 'show_on_front' )` is set to `'posts'` or `'page'`. If the user sets the front page to display the blog posts index, this choice is effectively superseded by `front-page.php`, and the blog posts index is not displayed unless the Theme specifically accounts for this setting in the template file, using something like so: {{{ if ( 'posts' == get_option( 'show_on_front' ) ) { get_template_part( 'home' ); } else { // front page markup goes here } }}} But requiring all Themes to include such a conditional in `front-page.php` essentially defeats the purpose of the the `front-page.php` file in the template hierarchy. Instead, WordPress should consider `get_option( 'show_on_front' )`, and should return ''either'' `front-page.php` (for `'page'`) ''or'' `home.php` (for `'posts'`) on the site front page. Attached patch modifies `get_front_page_template()` accordingly. Impact to current Themes is almost certainly minimal to none, for Themes that already properly use `front-page.php` and `home.php`." chipbennett 23662 Twenty Twelve: style.css with Table of Contents Bundled Theme 3.5 normal normal Future Release enhancement reopened has-patch 2013-03-02T00:44:33Z 2013-03-15T18:08:49Z "Hello, I really like the 2013 initiative with Table of Contents, because it helps new users understand where goes what, especially developing child themes. I added Table of Contents to Twenty Twelve theme and renamed CSS comments titles accordingly." TomasM 23661 get_theme_root_uri doesn't get correct theme root for themes in folders registered by register_theme_directory Themes 3.5.1 normal normal Awaiting Review enhancement new 2013-03-01T22:59:40Z 2013-03-02T04:42:11Z "get_theme_root_uri doesn't get correct theme root for themes in folders registered by register_theme_directory Doing this in wp-config.php: {{{ define('DKO_ABSPATH', __DIR__ . '/'); // just sets DKO_ABSPATH to the path of the wp-config.php file, which happens to be my web root }}} Doing this in an mu-plugin: {{{ register_theme_directory( DKO_ABSPATH . 'themes/' ); // add the webroot/themes folder as a theme directory, trailing slash required (ideally trailingslashit in the register_theme_directory function) }}} Yields this for get_stylesheet_uri(): {{{ http://www.davidosomething.dev/wp/Users/dotrakoun/Sites/openshift/main/php/themes/2013-davidosomething/style.css?ver=3.5.1 }}} i.e. the full path is returned instead of the uri. Think the case matching in theme.php lines 477-490 (get_theme_root_uri) doesn't cover paths registered using register_theme_directory but outside of ABSPATH, site_url, and content_url" davidosomething 23650 make get_space_allowed() filterable Multisite 3.4 normal normal Awaiting Review enhancement new has-patch 2013-03-01T00:38:34Z 2013-03-01T00:57:30Z "When the `blog_upload_space` option is set to `0`, instead of returning `0`, `get_space_allowed()` returns the default value which is currently hardcoded to `50` in core. As discussed in #18119 and committed in [19314], the function should return `0` if the option is set to `0`. However this was reverted in [19654] (see #19538). So I am not sure which is the desired behaviour. The attached patch adds filters for the default value and for the returned value. This is useful for scenarios where you don't want it to fallback to `50` if the option is accidentally set to `0`, and you want to set your own default. I can adjust the patch if the consensus is that an option of `0` should in fact return `0`." jkudish 23637 wp-signup.php has overly aggressive CSS Multisite 3.0 normal normal Awaiting Review defect (bug) new has-patch 2013-02-27T14:33:46Z 2013-02-27T18:25:15Z The CSS added through wp_head by wp-signup.php stops Multisite form fields from being styled through inheritance. Allowing inheritance will result in more consistent styling with the active theme (for example, field font-size). kwight 23636 Allow multiple slugs in get_terms Taxonomy 3.5 normal normal Awaiting Review enhancement new has-patch 2013-02-27T00:22:26Z 2013-04-01T09:37:17Z Just as the title says, sometimes I need to retrieve multiple term IDs from slugs. Rather than calling get_term_by over and over, it'd be better to be able to specify an array of slugs for get_terms. jfarthing84 23635 get_objects_in_term - identify matching terms Taxonomy 3.5.1 normal minor Awaiting Review enhancement new 2013-02-26T21:29:54Z 2013-02-26T21:29:54Z "`get_objects_in_term` is great for viewing taxonomy relationships for non-posts. However the return value is too limited for certain use cases. For When fetching object_ids for multiple terms the return value doesn't inform as to the matching term. For instance this query: {{{ #!php $object_ids = get_objects_in_term(array(55, 66, 77, 88, 99), ""my_custom_taxonomy""); }}} Might return an array of object_ids as follows: {{{ #!php array(101, 202, 303, 404); }}} However there's no way to tell '''which''' term a particular object_id matched. Did object 101 match term 77? Or maybe it was term 99? Or both? I've created a modified version of `get_objects_in_term` which will addresses this issue. I'll submit a patch, but am wondering if there's another way to achieve this functionality. " leepowers 23630 Simplify the DFW implementation Editor normal normal Future Release enhancement new early 2013-02-26T16:44:57Z 2013-03-06T20:04:42Z "I was sad to see that distraction free writing [http://make.wordpress.org/core/2013/01/08/wordpress-3-6-distraction-free-writing-improvements/#comment-7469 didn't get picked up] for 3.6. I decided to play around with a rough proof of concept to see how difficult it would be to use the existing TinyMCE instance for DFW. Benefits of handling it this way include: - It eliminates the need (and complexity) of juggling multiple instances of TinyMCE - We'll be able to remove a bunch of the old DFW code - It makes the transition between regular mode and DFW mode much more smooth - It can be as fully featured as we want it to be" lessbloat 23627 Allow plugins to short-circuit wp_nav_menu, good for performance Menus 3.5.1 normal normal Awaiting Review enhancement new has-patch 2013-02-26T12:49:28Z 2013-02-26T14:44:22Z "We already have short-circuit filters for [http://core.trac.wordpress.org/browser/tags/3.5.1/wp-includes/widgets.php#L180 widgets], [http://core.trac.wordpress.org/browser/tags/3.5.1/wp-includes/option.php#L40 options], [http://core.trac.wordpress.org/browser/tags/3.5.1/wp-includes/link-template.php#L115 links] that all can be used for retrieving items from non-persistent data store. It would make a lot of sense if this feature was also available to `wp_nav_menu` which is particularly DB heavy. My suggestion is to add `pre_wp_nav_menu` right after `wp_nav_menu_args`, like so: {{{ $args = wp_parse_args( $args, $defaults ); $args = apply_filters( 'wp_nav_menu_args', $args ); $args = (object) $args; // Allow plugins to short-circuit menu output $nav_menu = apply_filters( 'pre_wp_nav_menu', '', $args ); if ( ! empty( $nav_menu ) && $args->echo ) echo $nav_menu; elseif ( ! empty( $nav_menu ) ) return $nav_menu; // Get the nav menu based on the requested menu $menu = wp_get_nav_menu_object( $args->menu ); }}}" kasparsd 23622 Support Google Maps / Docs / Spreadsheet embeds Embeds normal normal Awaiting Review feature request new 2013-02-26T06:08:17Z 2013-05-06T21:19:58Z "Google Maps and Drive (docs, spreadhseets, and presentations) all can do embeds, but don't support oEmbed. Still, I think they're big enough for the core to have support for natively. We already have Google Video support, and it's pretty much dead now. Initial patch attached. - To get a Maps URL, view a Google Map, then select the ""Link"" icon in the left menu bar, top-right corner. - To get a docs/sheet/presentation URL, open the item, select ""File->Publish To Web. Once it's published and visible to the web, the dialog will give a link for you to copy/paste. This uses the normal embed handler, meaning that either the [embed] shortcode or just pasting the URL on a line by itself will trigger the embed. Width and height parameters are supported, and Presentations has special parameters to allow full-screen viewing. " Otto42 23616 General Handler for Whitelisted Options' Submissions Plugins normal normal Awaiting Review feature request new 2013-02-26T03:06:55Z 2013-02-26T03:09:09Z As stated over on #18285 WordPress should move away from posting to options.php. In order to do that, the Settings API needs a general purpose function that can be safely called on all Settings Pages that can handle posts to itself (generally referred to as 'take_action' in various places) and can handle what options.php currently does. WraithKenny 23605 esc_url() strips spaces instead of encoding them Formatting normal normal Awaiting Review defect (bug) new 2013-02-25T17:41:21Z 2013-02-27T23:56:38Z "If I pass a URL into `esc_url()` that contains a space, the space is stripped instead of encoded. To reproduce: {{{ $url = 'http://example.com/foo bar/'; echo ' '; var_dump( $url ); var_dump( esc_url( $url ) ); echo ' '; }}} The resulting URL ends up as `http://example.com/foobar/` instead of the expected `http://example.com/foo%20bar/`" johnbillion 23603 Custom post password form label Post Types normal normal Awaiting Review defect (bug) new has-patch 2013-02-25T08:46:38Z 2013-02-26T05:42:45Z "[http://core.trac.wordpress.org/browser/trunk/wp-includes/post-template.php?rev=23416#L1214 get_the_password_form()] hardcodes the password protected message. {{{#!php __(""This post is password protected. To view it please enter your password below:"") }}} This results in misbehavior, wherein all post types (including Pages) do not make a distinction between what is password protected. Considering the difficulty of chunking up that string to be dynamic and more importantly easily localizable, I attach a draft patch which makes that message a label instead." soulseekah 23602 "Incorrect canonical redirect if p=123 query argument present in ""paged"" archives" Canonical 3.5 normal normal Awaiting Review defect (bug) new 2013-02-25T08:34:19Z 2013-02-25T08:34:19Z "URLs that include `page/n` AND `p=n` query variable, such as: http://example.com/page/3/?p=123 will issue a 301 redirect to the homepage. This is being reported as incorrect behaviour in Google Webmaster Tools, because: The target URL does not exist and your server is not returning a 404 (file not found) error. Your server is redirecting requests for a non-existent page, instead of returning a 404 response code. This creates a poor experience for searchers and search engines. A fix would be to strip the `p=` query variable and redirect to the paged archive. From: http://example.com/page/3/?p=123 to: http://example.com/page/3/ " kasparsd 23601 Use ACE Code Editor for Theme and Plugin editors Administration normal normal Awaiting Review enhancement new has-patch 2013-02-25T06:56:00Z 2013-03-21T21:33:49Z "Ace is an embeddable code editor written in JavaScript. It's the code editor used on GitHub and is actively developed by Mozilla. Its license is Modified BSD which is compatible with GPL. The plugin and theme editors in their current state are lame. Upgrading the experience with ACE could lead to a more robust file editing solution in the admin. Perhaps, ability to add files? Here's the link to the project: http://ace.ajax.org/" wonderboymusic 23594 Categorization of files in Media Library (i.e. folders, tags, etc.) Media 3.5.1 normal normal Awaiting Review enhancement reopened close 2013-02-23T10:16:26Z 2013-03-27T23:39:24Z "Hi, the new media library is great but if you have a site with a lot of images, it is really hard to find anything. My suggestion would be to allow admins to create a folder structure for media files, so that content can be grouped accordingly. If folders are not an option, then I would at least like to see tags as a taxonomy for media files. Anybody who has more than 100 files of media in the library can't possibly be happy about how they find their media. Thanks for considering this. I know it's been a request in the forums for something like 3 years now, and there was a lot of hope in the community that the new media library would accommdate for this. NextGen Gallery probably comes closest to what I am thinking of, but sometimes you don't want a bloated gallery plugin when all you want to do is categorize your media library files.. " titush 23591 Can't insert media into wp_editor() without quicktags and/or tinymce Media 3.5.1 normal normal Awaiting Review defect (bug) new 2013-02-22T23:39:04Z 2013-03-05T16:15:36Z "If I set up an editor with no TinyMCE or Quicktags, I'm unable to insert any media. {{{ $args = array( 'tinymce' => false, 'quicktags' => false, 'textarea_rows' => 5, ); wp_editor( '', 'test1', $args ); }}} No js errors or anything. Media modal comes up, I can use it without any issue, but as soon as I click insert (be it single media or gallery), nothing happens. I have to enable tinymce and/or quicktags to get media insertion to work. Here's a simple plugin for testing: https://gist.github.com/trepmal/5016952 I can replicate this in 3.5.1 and trunk, have not tested in anything older. I don't think this is a browser quirk, but just in case, I've tested and confirmed the issue in Firefox 19 and Chrome 25.0.1364.84 beta both on Mac 10.8.2." trepmal 23589 FS_CHMOD_FILE doesn't work for ssh Filesystem 3.5.1 normal normal Awaiting Review defect (bug) new 2013-02-22T21:34:44Z 2013-02-23T00:19:11Z "Steps to reproduce: 1. set up ssh access for !WordPress (FTP_* constants). 2. `define('FS_CHMOD_FILE', 0664)`. 3. install some theme. Expected result: files have 0664 permissions. Actual result: files have default permissions (0644). I believe this happens because filename is ltrimmed before sending over SSH, but not restored before changing permissions. See [http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/includes/class-wp-filesystem-ssh2.php#L164 this]." x-yuri 23578 URLs wrapped in <> parsed as HTML when wp_mail_content_type set to text/html Mail 3.1 normal normal Awaiting Review defect (bug) new 2013-02-21T17:04:34Z 2013-02-22T18:22:02Z "[16285] wrapped the password-reset URL in the e-mail sent from retrieve_password() in greater-than/less-than signs in order to prevent it from breaking when line wrapped (see #14140). That has the side-effect of causing the URL to be parsed as HTML by the mail client when the message's content-type is set to text/html via the wp_mail_content_type filter. I don't see any other places in Core where this happens. Using wp_mail_content_type to enable HTML e-mails is a common technique documented on the Codex and across the Web. Is it considered a bad practice to enable it globally -- as opposed to adding it before calling wp_mail(), then removing it after; or just setting the content type in the $headers param of wp_mail()? If so, we should document that on the Codex and possibly in wp_mail() where the filter is applied. Even if it is, I don't think it'd hurt to have retrieve_password() check the content-type and behave accordingly. If it's ""text/html"", then create a proper link; otherwise wrap the URL in greater-than/less-than signs. If everyone agrees on that approach, I'll submit a patch." iandunn 23577 Better Date Fields Administration 3.5.1 normal normal Awaiting Review enhancement new close 2013-02-21T11:52:59Z 2013-02-22T16:15:20Z "I think the Dates should be prettified (i.e 2 days ago etc) and the last state put in front i.e (""Published 2 days ago"" rather than ""2 days ago Published"") As I think it would make it even more user friendly to used. I have attached a Image showing what I mean." jscampbell.05 23576 WordPress Editor Config to Stop Using Font Tag TinyMCE 3.5 normal normal Awaiting Review enhancement new reporter-feedback 2013-02-21T09:10:57Z 2013-02-21T16:33:41Z "Please could you change the default config so that the Font tag isn't used for styling, there is a option for the editor you use to switch to using spans instead but it isn't set to do that by default. " jscampbell.05 23575 Standard UI Classes and Functions Administration 3.5 normal normal Awaiting Review feature request new 2013-02-21T09:09:27Z 2013-02-22T02:31:55Z "It would be nice if wordpress allowed you to use the Post UI natively in my plugins, at the moment I've had to write a few classes for my Plugin Framework that mimic the Publish Metabox and Tabbed Metabox. As there is simply no easy way to do this at the moment, I think there should also be a better way of registering hidden menus. I have to jump through loads of hoops just to do this. " jscampbell.05 23569 Network Admin Email description falsely claims e-mails will be sent from it Text Changes normal minor Awaiting Review defect (bug) new 2013-02-21T01:27:05Z 2013-02-21T01:37:36Z "The description for the Network Admin Email option on wp-admin/network/settings.php says, ""Registration and support emails will come from this address. An address such as support@local.nordstrom.audrey.mpangodev.com is recommended.""; but that's not true. If the From name/address isn't set in wp_mail()'s $header argument, it gets set to ""WordPress "". What would a better description be? Maybe some like: ""Where you would like to be notified about new site creation and new user registration."" That would be consistent with the structure of the Network Name description just above it, which reads, ""What you would like to call this network."" If that sounds good to others I'll go ahead and create a patch for it." iandunn 23562 Using Speech Recognition Software with the Add Media Panel Accessibility 3.5.1 normal normal Awaiting Review defect (bug) new 2013-02-20T16:06:02Z 2013-02-20T17:59:42Z "Linked to #23560 this ticket specifically concerns the speech recognition user's accessibility experience of the Add Media functionality. I'm using Dragon Naturally Speaking with IE9 on Windows 7 - a typical setup as Dragon works best with IE. Within the Edit Post screen I can use Dragon to action the Add Media link successfully. The command in Dragon for such an action is ""Click Add Media"". This works, but then I run into the following problem: * With the exception of Set Featured Image, none of the other links on the panel appear to be directly accessible with Dragon. * If I select Set Featured Image I can't action any of the other links. Dragon users can use voice commands to replicate pressing the tab key. The experience then mirrors that outlined in #23560 - but of course this cannot be used to select the images or other files. It is possible for Dragon users to interact with screens using mouse commands but it is an incredibly laborious and time consuming process - used only as a last resort. If one of the images is selected, the information panel for that images opens to the right. Unfortunately none of the input fields (for title, alt, etc) are directly available to Dragon. Ironically, the Insert Into Post button can be accessed directly with a voice command. Some investigation needs to be done as to why most of the links and input fields cannot be directly accessed by Dragon when the panel is opened. This is a parallel with the situation on the Theme Customizer panel. It is interesting that the Set Featured Image link and the Insert Into Post button '''can''' be directly accessed. What is different about them? " grahamarmfield 23561 Using a Screen Reader with the Add Media Panel Accessibility 3.5.1 normal normal Awaiting Review defect (bug) new 2013-02-20T15:16:55Z 2013-02-20T17:59:54Z "Linked to #23560, this trac specifically concerns accessibility issues found when using the Add Media panel with a screen reader. I used NVDA 2012.2.1 with IE9 and FF16.0.2 on Windows 7. '''IE9''' * On initially clicking Add Media link in Edit Post page the focus appears to initially be transferred into the edit content textarea within the main page. There is no audible notification that the panel has opened. * Further tabbing shows that the focus has not been transferred into the panel - so this would be a showstopper for most users. If you continue tabbing you eventually do come to the panel in the tab order at the bottom of the main page maybe... * It is possible to tab round the text links in the panel. However actioning the Insert Media or Create Gallery links does not apparently do anything - there is no audible feedback that the contents of the next panel have changed. Suggest that when one of these links is actioned that focus is transferred into the relevant panel - to the heading would be a good place. * The 'images' select does not have an associated label so it's purpose would not be clear to all users. * The search box does not have an associated label so screen reader users in IE9 receive no feedback as to the purpose of this text box. * There is no Go or Search button available to trigger the action for these two input fields - both of which change the content of the panel below. For accessibility reasons the user should be in control of triggering the filtering. * As mentioned in the other ticket #23560 the main accessibility problem here is that it is not possible to select any of the previous uploaded media. '''Firefox''' * When the Add Media panel opens it is not clear where focus sits. But after this first link the focus is transferred into the Add Media panel. * The close link does not announce itself when tabbing forwards, but it does when reverse tabbing. * See IE9 section re actioning Insert Media, Create Gallery links. * AS IE9 re label for media type select box. NVDA does announce Search box label in FF. * As IE9 re lack of Go or Search button for these input fields. * As IE9 it is not possible to tab to any of the previously uploaded images/files. Separate ticket to be raised for Speech Recognition software experience." grahamarmfield 23559 Sticky single post page doesn't have .sticky class Template 2.7 normal normal Awaiting Review enhancement new dev-feedback 2013-02-20T11:34:44Z 2013-02-20T13:52:10Z "As explained in summary, it's impossible to style a single page for a sticky post without modifying content.php, why this? it's a behavior wanted. wp-includes\post-template.php, line 344: {{{ // sticky for Sticky Posts if ( is_sticky($post->ID) && '''is_home()''' && !is_paged() ) $classes[] = 'sticky'; }}} Thanks :)" sgr33n 23554 Change Header Delete Behavior Appearance normal normal Awaiting Review defect (bug) new 2013-02-20T07:11:27Z 2013-02-20T08:57:30Z When clicking the Remove header button, it should remove the header image from the list of images for rotation as well as remove from the currently selected image. Currently you must delete the image from the media library (which may be several hundred or thousand images deep) to remove it from the list. tribuseric 23537 Require attributes, not classes Template normal normal Awaiting Review feature request reopened 2013-02-19T18:20:03Z 2013-02-28T19:40:43Z "Currently themes[http://codex.wordpress.org/Theme_Review#Template_Tags_and_Hooks must] use [http://codex.wordpress.org/Function_Reference/language_attributes language_attributes], [http://codex.wordpress.org/Function_Reference/body_class body_class], [http://codex.wordpress.org/Function_Reference/post_class post_class] [http://codex.wordpress.org/Function_Reference/comment_class comment_class]. Rather then requiring direct usage of those, it'd be far more useful to have (and instead require) functions for the entire attributes output, with corresponding filter hooks. The current `_class` functions/hooks would still run, albeit internally via these new functions. This approach is scalable to future attribute needs. {{{ > > > > }}} There also should be `get_` versions. Using the `get_` version in the theme (or manually applying the hook) should suffice to meet requirements. The hooks are the underlying reason for requiring these functions. Hooks would run in the `get_` versions. #23236 can ensure safe output and DRY code." ryanve 23532 Sync Tests Repository on Github Unit Tests normal normal WordPress.org enhancement new 2013-02-19T15:56:53Z 2013-04-18T13:31:26Z "Like with Wordpress, the tests should be synched as well with a git repository under https://github.com/WordPress/ Especially after taking in https://github.com/nb/wordpress-tests" hakre 23531 Separate tests into unit / integration / ... directories Unit Tests trunk normal normal Awaiting Review enhancement new 2013-02-19T15:51:16Z 2013-02-19T15:51:16Z "To improve the speed how tests can be run - especially the unit-tests - I suggest to divide tests into sub-directories, for example: ''unit'' - for unit tests[[BR]] ''integration'' - for integration tests[[BR]] ''functional'' - for functional tests Right now all tests are roughly labeled as ""Unit-Tests"" even they are not unit-tests per-se, e.g. some of them interacting with the database or the file-system. Background: [http://stackoverflow.com/q/4904096/367456 What's the difference between unit, functional, acceptance, and integration tests?]" hakre 23525 Deleting one Image from upload resets/destroys upload batch changes Media 3.1 normal normal Awaiting Review defect (bug) new 2013-02-19T12:02:45Z 2013-02-19T13:16:35Z "Confirming the image delete of one image from an upload batch discards all text-changes so far with the properties of all other images of that batch. " hakre 23520 Rename sidebars to something more appropriate Widgets normal normal Awaiting Review enhancement new 2013-02-19T08:38:12Z 2013-02-19T13:43:59Z "The things that we put widgets into are no longer just sidebars. Maybe they never were just sidebars. Widgets go into areas that can literally be displayed anywhere within themes. Proposal: rename ""Sidebars"" to ""Widget Areas"". Discuss." johnbillion 23517 Shortcode: if last parameter ends with '/', it is mistaken for self-closing shortcode closure Shortcodes 3.5.1 normal normal Awaiting Review defect (bug) new has-patch 2013-02-19T05:45:16Z 2013-02-19T13:39:12Z "In example: {{{ [shortcode urlparam=http://somesite/path/]content text[/shortcode] }}} {{{ ""[shortcode urlparam=http://somesite/path/]"" }}} is interpreted as self closing: {{{ [shortcode/] with urlparam=""http://somesite/path"" }}} All examples in http://codex.wordpress.org/Shortcode_API include whitespace before `'/]'` This prevents implementation of bbcode parser for people to paste flickr photo snippets." sergem 23509 Conditional function that lets you know if your site is being viewed through the Customizer Appearance normal normal Awaiting Review enhancement new dev-feedback 2013-02-19T01:41:24Z 2013-04-22T22:10:51Z "I can provide a use case if necessary, but this should be relatively simple. If I need to do something special with my theme when my site is being viewed through the customizer, there's no easy way determine if it is. A simple `is_customizer()` (or similar) function would be incredibly useful in this scenario. I'd write up a patch, but I don't know where to put the new function." nathanrice 23506 get_terms() assumes its taxonomies argument is a numeric array with a 0 key Taxonomy trunk normal normal Awaiting Review defect (bug) new has-patch 2013-02-18T23:41:42Z 2013-02-19T00:36:21Z "In a few places in `get_terms()` we are using `$taxonomies[0]` after we've established that we have more than one taxonomy. The array isn't always 0-based, though. For example, `get_taxonomies()` returns arrays with the taxonomy name as a key, which breaks this pattern. In the attached patch, the taxonomies are run through `array_values()`, which gives us a 0-based array of the taxonomies." nbachiyski 23505 Some files still have closing PHP tags General 3.4 lowest trivial Awaiting Review enhancement new has-patch 2013-02-18T23:33:19Z 2013-05-14T15:36:25Z "[19712] removed EOF `?>` from nearly all the files, including `wp-content/index.php`: [[BR]] http://core.trac.wordpress.org/browser/tags/3.5.1/wp-content/index.php In a couple of files, however, it's still there, which doesn't seem intentional: [[BR]] http://core.trac.wordpress.org/browser/tags/3.5.1/wp-content/plugins/index.php [[BR]] http://core.trac.wordpress.org/browser/tags/3.5.1/wp-content/themes/index.php We should probably make the same change there for consistency." SergeyBiryukov 23501 add filter for post count query in WP_Posts_List_Table Administration 3.5 normal normal Awaiting Review enhancement new 2013-02-18T14:02:40Z 2013-02-18T19:09:48Z "I've a custom post type ""products"" with a custom taxonomy ""manufacturers"" I've hooked the parse_query filter when fired from edit.php because I've wanted to show posts based on current user criteria (user can edit only products belong to specific manufacturers). Everything worked as expected, except for the post count in the table header that shows total amount of posts (not a filtered count). Digging into the code I've found that inside WP_Posts_List_Table constructor ([http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/class-wp-posts-list-table.php#L59])the following code is performed: {{{ $this->user_posts_count = $wpdb->get_var( $wpdb->prepare( "" SELECT COUNT( 1 ) FROM $wpdb->posts WHERE post_type = %s AND post_status NOT IN ( 'trash', 'auto-draft' ) AND post_author = %d "", $post_type, get_current_user_id() ) ); }}} I think that the simplest solution is to add a filter for the count query. By this way is possibile to customize the query that reflects the effective post count." cardy_Web 23498 wp_list_authors ignores 'exclude_admin' arg when admin account has a display_name other then 'admin' Users 3.1 normal normal Awaiting Review defect (bug) new 2013-02-18T09:37:59Z 2013-02-18T19:03:38Z "Line 293 of author-template.php should be changed from: {{{ if ( $exclude_admin && 'admin' == $author->display_name ) }}} to: {{{ if ( $exclude_admin && 'admin' == $author->user_login ) }}} Thanks." raphaabreu 23496 Front-end admin toolbar dropdowns inaccessible on Chrome/Android Toolbar 3.5 normal normal Awaiting Review defect (bug) new 2013-02-17T23:45:36Z 2013-02-17T23:46:04Z "The dropdown menus that appear on the first touch of admin toolbar menus with sub-items are inaccessible because the top level menu URL is triggered. Steps to reproduce: 1. Visit the front-end of your website using Chrome on Android. 2. Click an admin toolbar menu item that has sub-items, eg. the Add New menu, the site name menu or your user profile menu. 3. The sub-menu is triggered, but the browser also immediately navigates to the URL of the top level menu item. The issue doesn't occur when using these menus in the admin area. Tested using Chrome 18 on Android 4.2. Theme is TwentyTwelve." johnbillion 23492 svn:ignore wp-config.php General trunk low minor Awaiting Review defect (bug) new 2013-02-17T17:59:42Z 2013-02-17T17:59:42Z `wp-config.php` very often exists in Subversion checkouts, but it should never be committed. Could we add a `svn:ignore` property for it? nbachiyski 23491 Add hook to insert_with_markers() so theme/plugin authors can prevent writing to .htaccess Rewrite Rules normal normal Awaiting Review enhancement new 2013-02-17T17:09:18Z 2013-02-17T17:09:18Z "If not using .htaccess to rewrite, but instead keeping those settings in an Apache config file, it would be nice if writing the .htaccess file could be prevented by hooking into the function that does that (e.g. returning false or something like that). Why? If the Apache option AllowOverride is turned off (which it should be for performance reasons, if not using any .htaccess files) the file won't ever be read. But still having it around (except cluttering) can possibly confuse someone having access to the server, seeing the file and thinking it actually controls anything. Especially since most WordPress support threads on the Internet assumes that an .htaccess file is used for rewrite rules. One solution is to keep an empty, non-writable .htaccess file, optionally having a comment in it saying it's unused, but getting rid of the file altogether would be much cleaner. Also, it can still happen that someone accidentally changes the file permission, and someone else (or the same person) saves permalink options, saving a new .htaccess file, having created the possibility of confusion once again." alimony 23490 "add margin: 0px to ""#titlediv #title"" in wp_admin.css" General normal minor Awaiting Review enhancement new 2013-02-17T14:34:23Z 2013-02-17T14:34:23Z "Firefox adds some margin to the input, as system css settings... adding margin: 0 to the title input element makes the title text to be more correctly positioned in the center. http://wpimpact.com/wp-content/uploads/2013/02/Untitled-6.png fixed: http://wpimpact.com/wp-content/uploads/2013/02/Untitled-8.png" alexvorn2 23487 is_blog_installed gives errorneus result on moved database Upgrade/Install 3.0 normal trivial Awaiting Review defect (bug) new 2013-02-16T13:11:37Z 2013-02-16T13:31:48Z "I resently moved my blogs to a new database, but when I tried it out, on of the blogs wanted a new install. Of course I did not want to do an install and overwrite my blog. I indirectly found the reason in is_blog_installed, which suppresses database errors. Thus I did not see this error. SELECT command denied to user 'techblog'@'localhost' for table 'wp_options' Of course it was my fault, but I virtually had to take the wordpress code apart to find out why my migration failed. Of course this is not a big problem on new installs, but very likely to happen on moving databases. " Kjeld Flarup 23485 Theme Preview on Extend starts in the middle of the page WordPress.org site normal normal WordPress.org defect (bug) new 2013-02-16T10:39:50Z 2013-03-05T16:02:50Z "The theme preview iframe is positioned at 50% from top, the lower 50% are invisible. Tested in Chrome, Firefox and Opera, all up-to-date. Clicking ''Inspect Element'' in any of these browsers makes the iframe jump to the correct position, so I cannot provide more details, sorry. " toscho 23483 Incorrect image URL for subsites when using UPLOADS constant on multisite subdirectory installation Multisite 3.5.1 normal normal Awaiting Review defect (bug) new 2013-02-15T18:56:54Z 2013-02-18T21:40:51Z "If the UPLOADS constant is used on a Wordpress Multisite installed to subdirectory, using subdirectory mode, then image URLs for subsites are incorrect. Example: * WP MS installed to www.domain.com/wordpress, subdirectory not subdomain * UPLOADS set to 'assets' Main site uploads images to /wordpress/assets/... [[BR]] Main site image URL is www.domain.com/wordpress/assets/... 1. Create subsite called 'subsite'; 2. Subsite uploads images to /wordpress/assets/sites/2/... 3. Subsite image URL is www.domain.com/subsite/assets/sites/2/... when it should be www.domain.com/assets/sites/2/... This is because wp_upload_dir() uses get_option('siteurl') to derive the URL. It is probably right for subdomain multisite but wrong in this use case." creativeinfusion 23482 Fix improper use of comment_exists() in some importers Import normal normal WordPress.org defect (bug) new 2013-02-15T18:49:18Z 2013-02-15T18:49:18Z "Background: #20494 DotClear Importer and TextPattern Importer treat the returned comment post ID as a comment ID: [[BR]] http://plugins.trac.wordpress.org/browser/dotclear-importer/trunk/dotclear-importer.php#L416 [[BR]] http://plugins.trac.wordpress.org/browser/textpattern-importer/trunk/textpattern-importer.php#L429" SergeyBiryukov 23479 tiny_mce_before_init filter is not fired for users with Author role TinyMCE 3.5.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2013-02-15T10:01:01Z 2013-02-15T17:56:41Z "http://www.designzzz.com/how-to-stop-wordpress-editor-from-removing-iframe-and-embed-code/ explains how to change wordpress so that you can embed an iframe in a post without tiny MCE removing it. This works fine if you are logged in to wordpress as an administrator. It has no effect when you login to wordpress as an author. I guess that the tiny_mce_before_init filter is not fired unless the user has an administrator role." paulmackinlay 23478 "Impossible to view posts titled ""WP Content"" or ""WP Includes"" with some forms of permalinks" General normal normal Awaiting Review defect (bug) new close 2013-02-15T06:33:05Z 2013-02-15T09:35:07Z "Posts titled ""WP Content"" or ""WP Includes"" (without quotes) are impossible to view when using the following forms of permalinks: 1. /%postname% 2. /%postname%/ A post titled ""WP Content"" will have a permalink of either http://example.com/wp-content or http://example.com/wp-content/, '''both will show a blank page'''. A post titled ""WP Includes"" will have a permalink of either http://example.com/wp-includes or http://example.com/wp-includes/, '''both will show the directory index of the wp-includes directory'''. WordPress should either: a) make it possible to view both posts normally b) warn the user or make it not possible to have a combination of some post titles and some certain forms of permalink." kjasdu 23477 r21789 creates a breaking change in behavior for get_submit_button Administration 3.5 normal minor Awaiting Review defect (bug) new 2013-02-14T23:23:57Z 2013-02-15T17:32:18Z "A recent change made to get_submit_button (http://core.trac.wordpress.org/changeset/21789/trunk/wp-admin/includes/template.php) has caused an unwanted change in behavior for a button on a site I maintain. Previously, the string passed as the second argument, `$type`, was matched against a switch statement with several unique cases. In the event of a non-match in the switch, the default action prior to [21789] was to assign the parameter's value as the `$class` string without altering it. The change introduced in [21789] now breaks a string into individual classes, which prevents the use of the unique class names within a string of additional class names. For example, the string `button-secondary save-button action` used to generate a class string in HTML of `button-secondary save-button action`, but now generates the unexpected result `button save-button action` (note lack of '-secondary') because it matches against the following if check on line 1600: `if ( 'secondary' === $t || 'button-secondary' === $t )` It should be noted that the phpdoc associated with the function does not name the use case that I was employing, but that the behavior of passing in a space-separated class string has previously resulted in the string being passed through untouched (and the comment here indicates it was known and expected behavior (http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/template.php?rev=21781#L1649), and this is no longer the case. Not sure if this is worth a programmatic fix, or if it might just be worth noting in the function docblock that certain classes are now 'reserved' and cannot be passed into the `$type` string." vhauri 23476 disabling wpautop in TinyMCE settings leads to strange behavior in Text editor TinyMCE normal normal Awaiting Review defect (bug) new has-patch 2013-02-14T21:57:20Z 2013-02-15T12:45:26Z "If I disable the `wpautop` behavior in TinyMCE with a `tiny_mce_before_init` filter like so: {{{ function ars_disable_tinymce_wpautop($in) { $in['wpautop'] = false; $in['remove_linebreaks'] = false; $in['apply_source_formatting'] = true; return $in; }}} The text view of the editor exhibits some odd behavior when saving. Instead of submitting the current state of the text editor, the text editor is updated with the contents of the HTML view, and then saved. However, if I click over to the Visual editor before saving it will save correctly. I believe this logic in the `wordpress` TinyMCE plugin may be the cause: {{{ ed.onSaveContent.add(function(ed, o) { if ( ed.getParam('wpautop', true) && typeof(switchEditors) == 'object' ) { if ( ed.isHidden() ) o.content = o.element.value; else o.content = switchEditors.pre_wpautop(o.content); } }); }}}" leedo 23475 Feed querystring not limiting returned posts by post type when also using category Query 3.5.1 normal normal Awaiting Review defect (bug) new 2013-02-14T20:15:44Z 2013-02-14T20:15:44Z "I set up an example to demonstrate what's happening: http://demo.jarrodpyper.com/feed/?post_type=syndicated&category_name=craft This feed *should* only return the one post on my site, ""test syndicate"" that is in the ""Syndicated"" post type and also in the ""craft"" category. Instead the post titled ""post"" of the default ""post"" post_type is being returned in the feed as well because it is also in the ""craft"" category. This works correctly within a normal page using query_posts, which I thought would be similar if not the same as the way the querystring was handled when put into the URL. Not sure if ""Query"" or ""Feed"" is the more relevant component keyword to use here." jpyper 23473 Performance Improvement in three JavaScript Source Codes Performance 3.5 normal normal Awaiting Review enhancement new has-patch 2013-02-14T02:44:14Z 2013-02-15T17:19:29Z "By performance profiling in Internet Explorer 10, Firefox 17 and Chrome 25, I found performance improvement in wp-admin/js/post.js, wp-includes/js/media-views.js and wp-includes/js/utils.js. Function clean() at line number 17 in post.js, function set() at line number 98 in util.js and function visibility() at line number 2767 in media-views.js can be improved with same functionality. I measured inclusive execution times of original code and improved code. The image is the result. The machine I used to measure execution times has Intel Core i5 1.6GHz CPU and 4GB RAM. I also attached a patch file." yongbae 23471 Abstraction of post format parameters (wp_update_post(), XML-RPC, template tags) General trunk normal normal Future Release enhancement new 2013-02-13T19:55:58Z 2013-05-16T12:07:38Z "#19570 is introducing a UI for post formats. Correspondingly, various post meta fields will be introduced to store the extended data that's used in some post formats (eg. the URL field for a link or the source field for a quote). Anything that interacts with the XML-RPC API and wants to support post formats (eg. future versions of the [http://wordpress.org/extend/mobile/ WordPress mobile apps]) will therefore need to: 1. Send the various post format meta fields in its requests, and 2. Receive the various post format meta fields in responses. There should be some abstraction available at all levels of saving and fetching posts, don't we have to deal with the post meta fields directly. We should: 1. Introduce a new parameter to the `wp.newPost` and `wp.editPost` XML-RPC methods for specifying the values of the extended post format fields when saving posts, 2. Introduce a new parameter to the `wp.getPost` and `wp.getPosts` XML-RPC methods for returning the values of the extended post format fields when fetching posts, 3. Introduce a new parameter to `wp_update_post()` for specifying the values of the extended post format fields when saving posts, and 4. Introduce template tags for displaying/returning the values of the extended post format fields. Point number 4 may be being covered somewhere else. I know it's been mentioned in IRC but I couldn't find mention of it on Trac. The end result of this is that extended post format data is abstracted from its storage method. Consideration: Which of these fields will be required and which are optional (on a per-post-format basis). Thoughts? I'm happy to volunteer a first patch (or patches)." johnbillion 23470 Convert slash to dash and make body class for page templates look better Template 3.4 normal normal Awaiting Review defect (bug) new has-patch 2013-02-13T12:24:09Z 2013-04-01T03:16:13Z "If you keep you page templates in a page-templates folder in your theme. Let's we have a template named front-page.php - the template slug written in the postmeta will be '''page-templates/front-page.php''' When generating the classes for the body, get_body_class() will convert the dot to a dash but the slash will be stripped by sanitize_html_class(). So finally we will have a class: '''page-template-page-templatesfront-page-php''' Isn't it prettier to convert the slash to dash and to have it like: '''page-template-page-templates-front-page-php'''" Caspie 23466 In user selection WXR importer should not suggest importing to subscriber Import normal normal Awaiting Review enhancement new 2013-02-13T07:17:21Z 2013-02-13T07:17:21Z right now when associating a user from the WXR file with a wordpress user there is a dropdown containing all users. IMO there is no point in even offering associating with a subscriber as he will not be able to edit anything related to the imported content, and including subscribers can make the list needlessly long. mark-k 23465 WXR importer does not import posts if a post with the same title is in the trash Import normal normal Awaiting Review defect (bug) new 2013-02-13T07:11:29Z 2013-04-22T03:12:42Z "1. export a WXR file with some/all posts 2. send posts to trash 3. import the file generated at step 1. 4. for each post there is a message that the post already exist If something is in the trash it should be handled as if it doesn't exist. " mark-k 23464 WXR importer: Creating new user to import to sucks, should be fixed or removed Import normal normal Awaiting Review defect (bug) new 2013-02-13T07:05:33Z 2013-02-13T07:05:33Z "When importing WXR you are prompted to assign a user to which of the existing users the imported content will be assigned, but it is also possible to provide a name of a new user which will be created and the content then will be associated with it. The new user functionality sucks 1. No email or password is required therefor the user for a while is missing data which is assumed to always exist for a user. In the end of the import there is a small notice about updating the user data, but it gets lost in all the output being generated during import 2. Processing does not stop if user creation had failed (I used hebrew characters for user name) and the imported content is assigned to the current user. WTF? " mark-k 23463 WP_HTTP HTTP/1.1 needs to send Connection Close + support Transfer-encoding better HTTP normal normal Future Release defect (bug) new has-patch 2013-02-13T06:15:45Z 2013-02-13T06:15:45Z "WP_HTTP accepts a 'httpversion' argument, and supports some functions of it (such as Transfer-encoding). However, there are 2 things which are rather broken 1. It doesn't send a `Connection: close` header, so the connection is held open and WP_HTTP never returns 1. Transfer-Encoding: chunked appears to be rather broken, causing it to returning the end of the document rather than the decoded document. The attached patch goes some of the way towards making that work better, but is mostly untested, and could do with a unit test or two." dd32 23462 Add top Save Settings button for MU Site settings Network Admin 3.0 normal trivial Awaiting Review enhancement new has-patch 2013-02-13T05:21:47Z 2013-02-13T23:03:47Z It's quite a long list, and it'd be awesome to have a button at the top to use, as well as at the bottom, so that one doesn't have to scroll all the way down just to save. tw2113 23460 'get_plugin_data' doesn't load text domain Plugins 3.5 normal normal Awaiting Review defect (bug) new 2013-02-12T18:09:24Z 2013-02-12T18:09:24Z "'get_plugin_data' calls '_get_plugin_data_markup_translate' with the full path of the plugin file instead of the expected path relative to the plugins directory. The patch is the following on line 99 of 'wp-admin/includes/plugin.php': {{{ $plugin_data = _get_plugin_data_markup_translate( plugin_basename( $plugin_file ), $plugin_data, $markup, $translate ); }}} It might solve ticket #20813 as well." npetetin 23458 Implement filters on post_status, check get_post_status() instead of the object's post_status in get_post_permalink() Post Types 3.5 normal normal Awaiting Review enhancement new has-patch 2013-02-12T17:16:35Z 2013-02-12T17:20:50Z "We have some custom post types that we wanted to implement the `inherit` post_status on, using the pattern created by attachments that allows child posts to inherit their status from the parent. In our case we have a top-level custom post that has a number of children of a different post type, and we wanted to make it easy to publish the entire set simply by publishing the parent. In implementing this, however, we discovered some hard coded assumptions in `get_post_permalink()` and `get_post_status()` that got in our way. Examples: `get_post_status()` has specific support for `inherit` as a post status, but only for `attachment` post types. Everything else can pound sand. To work around this we added a filter to the return value, which seemed to be both the most compatible and lowest-cost way to implement such a change. It looks like this: `return apply_filters( 'get_post_status', $post->post_status, $post );`. And in `get_post_permalink()` we found that it's checking `$post->post_status`, making it impossible to ascend the hierarchy and get the status of the parent. The change there was also pretty straightforward: `$draft_or_pending = get_post_status( $id ) && in_array( get_post_status( $id ), array( 'draft', 'pending', 'auto-draft' ) );`. I believe this is compatible with #23169 and #23168, which seek to improve support for custom `post_status`es. The only other recent ticket/changeset I found mentioning post_status was r22963, which changed from `get_post_status( $id )` to `$post->post_status` for compatible, but opposite reasons." misterbisson 23455 Theme Customizer does not load when static Front Page is moved to Trash Appearance trunk normal normal Awaiting Review defect (bug) new 2013-02-12T12:27:37Z 2013-04-23T22:33:32Z "Steps to reproduce: 1. Go to Pages > Add New, and publish a new page 2. Go to Appearance > Themes > Customize 3. Under Static Front Page, set this new Page as your Front Page. Save changes 4. Go to Pages > All Pages, and trash the page 5. Go back to the customizer * The sidebar loads, but not the preview * I see the following error in the console: http://i.wpne.ws/MpDR When commenting out {{{$this->handle_404();}}} in [http://core.trac.wordpress.org/browser/trunk/wp-includes/class-wp.php#L550 wp-includes/class-wp.php#L550], the Preview appears again, but generates quite a lot of notices. Tested with WordPress Trunk (Version 3.6-alpha-23400)" jeherve 23454 _deprecated_function Messages General 3.5 normal normal Awaiting Review enhancement new has-patch 2013-02-12T11:20:39Z 2013-04-01T09:28:58Z "Unlike ''_deprecated_file'' and ''_deprecated_argument'', the ''_deprecated_function'' function has no option to append a message to the triggered notice. I propose adding this to make it consistant with the other 2 functions. Patch to follow." mikejolley 23453 Absolute path added to same page anchor tag links Multisite 3.5.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2013-02-12T04:56:18Z 2013-02-20T03:42:34Z "In a multisite setup with a sub-folder configuration when I create a link with a hash tag to an anchor point on the same page, the rendered HTML includes the absolute path plus the hash tag. When I tested creating a same page link with a hash tag on a regular install it worked fine. This might have to do with re-writes using sub-folders in multisite. I don't think it should be adding the absolute path into the href" angio 23446 Expose 'login_url' and 'admin_url' via XML-RPC XML-RPC 3.5 normal normal Awaiting Review enhancement new has-patch 2013-02-11T10:41:14Z 2013-04-01T09:28:14Z "To show the preview of 'private'/'draft'/'pending review' posts we need to authenticate to WordPress by using the login form, and the redirect_to parameter. Sometime the URL of the login form cannot be guessed by replacing xmlrpc.php with wp-login.php :) We have the same issue for the URL of the admin dashboard. " daniloercoli 23444 Publish actions not readily available after scrolling when editing a post Administration normal normal Awaiting Review enhancement new dev-feedback 2013-02-11T01:37:14Z 2013-02-11T02:26:42Z When editing a post in 2-column mode, the user is forced to scroll to the top of the screen. As publishing is always the final action while editing a post, the user should have the metabox available regardless of the user's scrolling. ericlewis 23442 Allow wp_remote_get args to be filtered for oEmbed calls Embeds 3.5 normal normal Awaiting Review enhancement new has-patch 2013-02-10T21:48:10Z 2013-02-15T20:36:04Z "Currently, the oEmbed code use wp_remote_get() to communicate with the oEmbedded service. However, there's no way to filter the arguments that get used - it simply uses the system wide defaults. Filtering the defaults (E.g. http_request_timeout) seems overkill when you know that you only want to change things for something specific like an oEmbed call that you know may take longer than 5 seconds (E.g. https://github.com/leewillis77/wp-github-oembed/blob/1.2/github-api.php#L35) The attached patch adds a new filter oembed_remote_get_args which allows plugins to override the wp_remote_get args for oembed calls (Including discovery)" leewillis77 23438 "iframe dimensions getting broken when clicking ""remove formatting"" icon in TinyMCE" TinyMCE 3.3.2 normal normal Awaiting Review defect (bug) new reporter-feedback 2013-02-10T21:23:42Z 2013-02-11T09:38:48Z "I copy-pasted existing HTML content into the Visual editor, then clicked ""Remove Formatting"" to clean it up a bit. However, this broke the dimensions of the iframes I had in the code, changing the widths of iframes from 120px to 320px (320px seems to be the default that WP uses every time). I think the original width was in a ""style"" tag, but WP seems to have removed it from the iframe - I don't need that removed! It's costing us lots of effort to manually go back and fix every iframe." rubberduck 23436 Media Gallery - Cropping Image and then Cropping a thumbnail from that crop doesn't work. Media 3.5.1 normal minor Awaiting Review defect (bug) new 2013-02-10T17:20:00Z 2013-02-10T18:04:06Z "'''A recipe for repeating the bug behavior:''' Navigate to Library in the admin sidebar. Click ""Add new"". Drag the 800x480 copy of this or any image to the drag and drop area: http://en.wikipedia.org/wiki/File:Cheese_platter.jpg (I suggest this image for ease of recipe duplication and best explanation.) After the blue status bar has completed, ""Edit"" to bring the media edit window up in a new tab. Click ""Edit Image"" below the actual image. Drag anywhere inside the image to create a cropping box. In the ""Image crop"" pane, set the crop area to 500px width, 100px height. Drag the cropping box so that the fancy toothpick is as far left as possible along the horizontal axis of the cropping box, but centered vertically. Click the ""Crop"" icon. Click ""Save"". Click ""Update"". Click ""Edit Image"" once again. Drag inside the newly-cropped image again to create a new cropping box. In the ""Image Crop"" pane, change the cropping dimensions to 150 x 100. Drag the box so the fancy toothpick is somewhere in the left third within the crop boundary. '''Important:''' In the thumbnail settings pane, set ""Apply Settings to:"" '''Thumbnail'''. Click the ""Crop"" icon. Click ""Save"". Click ""Update"". Click ""Library"" in the admin sidebar. The newly preferred thumbnail for our previously-cropped image does not save. Thumbnail remains default, based on center of previously-cropped image. Instead, you will see a small wheel of cheese sliced into six wedges with garnishes for the thumbnail, even though we chose the part with the fancy toothpick." gr33nman 23432 Links in Setting pages to open in new window Administration 3.5.1 normal minor Awaiting Review enhancement new has-patch 2013-02-09T15:26:25Z 2013-02-10T16:02:57Z "Some links in the Setting Pages (General, Discussion, Permalink) pages open in same window, which sometime can be awful. [[BR]] While the users can press cmd/ctrl + click and click the link to open it in new tab but If the user does not open the link in new window, options (which are not saved) will be lost and one have to go through them again.[[BR]] Also links in the Edit Profile page and all the links in the help tab open in new window except a few.(so it is possible that users may just click it thinking them to alike other links which open in new window)[[BR]] So a consistency will be there and ux can be a little better." theadityajain 23431 [embed] shortcode doesn't work with do_shortcode() Embeds 3.5 normal normal Awaiting Review feature request new has-patch 2013-02-09T15:05:02Z 2013-02-10T15:35:37Z It would be preferable to use the [embed] shortcode through do_shortcode rather than apply_filters( 'the_content',... in order to avoid sharing plugins, related posts plugins etc appending content to something that could simple be post meta, i.e. looking to convert a youtube url to a video. jtsternberg 23430 sanitize_user() disallows + in usernames causes problem for email as username Users 3.5.1 normal minor Awaiting Review enhancement new has-patch 2013-02-09T08:48:31Z 2013-02-10T15:39:20Z "I want to use email addresses as usernames which seems to work fine, except sanitize_user() doesn't allow a + in the username and my email addresses have + in them. Google/gmail allows one to use a + modifier on emails like so: user+admin@gmail.com, user+editor@gmail.com, user+author@gmail.com, etc... I often use this to get around WordPress's requirement for unique email addresses but it's also intended for and useful in filtering: user+blog1@gmail.com, user+blog2@gmail.com, etc... Is there a reason we can't allow +'s in usernames or could it be moved to the strict case only? See formatting.php:892 " jb510 23429 undefined tinyMCE: no ?> at the end of load-scripts.php General 3.5.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2013-02-08T22:01:36Z 2013-02-14T03:47:40Z "I noticed a theme throwing an error in console today. I noticed ""Uncaught ReferenceError: tinyMCE"" In particular, switchEditors.switchto() and a few others like .do - where undefined. I thought that was strange. I googled the error and eventually found this thread: http://wordpress.org/support/topic/javascript-error-in-admin-panel-with-load-scriptsphp?replies=2 Adding ?> to the end of load-scripts.php fixed the issue. Very strange bug. I have seen it on 2 installations now (4 referencing the two in the support forum thread) - but I am unable to recreate it anywhere else." chaos1 23428 comments_open causes PHP notice in certain cases Warnings/Notices 2.5 normal normal Awaiting Review defect (bug) new has-patch 2013-02-08T21:51:39Z 2013-02-10T15:59:50Z when `comments_open()` is called for a non-existant post (either a bad ID, or no ID passed and called from a non-single page), a PHP notice is caused. Ideally, plugins shouldn't be doing this, but a simple null check in `comments_open()` fixes the problem. willnorris 23427 Restore shift-click checkbox range selection Administration 3.5 normal normal Awaiting Review enhancement new close 2013-02-08T19:35:32Z 2013-02-26T16:48:58Z "It used to be possible to select a range of checkboxes in the post list by shift-clicking (see #6541). I'm not entirely sure when this feature disappeared, but it's been a while. Patch restores the functionality using the [http://www.sanisoft.com/blog/2009/07/02/jquery-shiftcheckbox-plugin/ jQuery shiftcheckbox plugin]." sillybean 23424 WP_Image class for handling images from the media library Media 3.5 normal normal Awaiting Review enhancement new dev-feedback 2013-02-08T15:41:24Z 2013-02-08T15:41:24Z "Since 3.5 we have the class WP_Image_Editor. This needs a file path to be able to manipulate an image. Currently you would have to use something like wp_get_image_editor( _load_image_to_edit_path( $post_id ) ). What is wrong since you are using a ""private"" function. Currently I'm working on this idea and you can find the code here https://github.com/markoheijnen/WP_Image/blob/master/wp-image.php. What it does now is getting the filepath, be able to get the image editor, add an image size on the fly and getting/updating the metadata. We really miss something like a WP_Image class in WordPress. However I'm not sure what kind of functionality is needed for it. I like the current class mainly because it gives you the power to create an image size for a specific media image and stores it in the sizes array. When a user removes the media image then also the custom sizes will be removed." markoheijnen 23423 sanitize_title() in dynamic_sidebar() restricts the use of specific characters for sidebar IDs Widgets 2.2 normal normal Awaiting Review defect (bug) new 2013-02-08T13:25:00Z 2013-02-19T05:20:42Z "In the dynamic_sidebar() function in wp-includes/widgets.php uses sanitize_title() on the given index when it looks for a sidebar with a name that matches the index. After that it leaves the index value sanitized making it impossible to use characters not allowed by sanitize_title() in a sidebar ID. By not overwriting the given index value with the sanitized version it would still be possible to use any character for the ID. To achieve this, lines 847-853 {{{ $index = sanitize_title($index); foreach ( (array) $wp_registered_sidebars as $key => $value ) { if ( sanitize_title($value['name']) == $index ) { $index = $key; break; } } }}} should be replaced with {{{ $sanitized_index = sanitize_title($index); foreach ( (array) $wp_registered_sidebars as $key => $value ) { if ( sanitize_title($value['name']) == $sanitized_index ) { $index = $key; break; } } }}}" paulvandermeijs 23422 Add query filter argument to register_taxonomy Taxonomy normal normal Awaiting Review enhancement new 2013-02-08T12:38:35Z 2013-02-08T12:50:58Z "Following on from the #21240 ticket which introduced the show_admin_column functionality I would like to suggest an additional argument to easily add the select list query filter for a taxonomy to the post-type list. Currently a taxonomy query can be added via the 'restrict_manage_posts' action and 'parse_query' filter. It would be useful to add an additional register_taxonomy argument of 'show_column_filter' to define a standard select option list of the taxonomy terms. Things like default option and hierarchy could be optional settings is an array is passed instead of boolean. " tifosi 23421 Add sortable to taxonomy column Taxonomy normal normal Awaiting Review enhancement new 2013-02-08T12:34:20Z 2013-02-09T10:57:33Z "Following on from the #21240 ticket which introduced the show_admin_column functionality one limitation is the 'as easy' way to make that column sortable. It's possible to do it through the 'manage_edit-{$post_type}_sortable_columns' filter but the column_key is different for 3.5+. A standardisation as for adding the column may be advantageous: a register_taxonomy argument and / or new filter. argument: show_column_sortable, boolean default false, requires show_admin_column to be set and true. In the same way that the get_columns function uses the new ""manage_taxonomies_for_{$post_type}_columns"", filter to add a taxonomy column there could be a ""manage_taxonomies_for_{$post_type}_sortable_columns"" filter in the get_sortable_columns function of the post-list class: i.e. {{{ function get_sortable_columns() { $default = array( 'title' => 'title', 'parent' => 'parent', 'comments' => 'comment_count', 'date' => array( 'date', true ) ); return apply_filters( ""manage_taxonomies_for_{$post_type}_sortable_columns"", $default ); } }}} The developer could then set the filter as normal {{{ add_filter( ""manage_taxonomies_for_{$post_type}_columns"", 'add_sortable_column' ); function add_sortable_column ( $columns ) { $columns[ taxonomy-tax_name ] = 'Taxonomy Label'; return $columns; } }}}" tifosi 23420 Lost password, invalid key - noticed something Mail 3.5.1 normal normal Awaiting Review enhancement new close 2013-02-08T09:26:31Z 2013-02-22T18:22:52Z "Hi there, I have noticed something about the lost password/email retrieval that may be a bug or may help out with the number of requests this gets. The link sent with the key and user name is surrounded with < and > Some email clients are misinterpreting this link and including the > at the end of the user name which in turn kills the database query because the user name does not match. I have run a couple of tests changing line 235 of wp-login.php to be: {{{ $message .= network_site_url(""wp-login.php?action=rp&key=$key&login="" . rawurlencode($user_login), 'login') . ""\r\n""; }}} from {{{ $message .= '<' . network_site_url(""wp-login.php?action=rp&key=$key&login="" . rawurlencode($user_login), 'login') . "">\r\n""; }}} This seems to sort the problem out." demonpengu 23416 Form handlers assume $_POST elements will be strings Warnings/Notices 3.5.1 normal normal Awaiting Review defect (bug) new 2013-02-07T19:26:18Z 2013-02-08T16:59:16Z "I'm running Wordpress 3.5.1 on PHP 5.3. This example is from lines 50-53 of wp-comments-post.php: {{{ $comment_author = ( isset($_POST['author']) ) ? trim(strip_tags($_POST['author'])) : null; $comment_author_email = ( isset($_POST['email']) ) ? trim($_POST['email']) : null; $comment_author_url = ( isset($_POST['url']) ) ? trim($_POST['url']) : null; $comment_content = ( isset($_POST['comment']) ) ? trim($_POST['comment']) : null; }}} The issue is that If your post data contains something like: {{{ author[]=foo&author[]=bar }}} or {{{ comment[]=foo }}} Then the corresponding values in $_POST will be arrays, not strings, causing an E_WARNING. There seem to be a number of other places where $_POST data is passed directly to PHP string functions as well, causing potential warnings. These should be handled gracefully by checking the type of the element being grabbed from $_POST first: {{{ $comment_author = ( isset($_POST['author']) && is_string($_POST['author']) ) ? trim(strip_tags($_POST['author'])) : null; $comment_author_email = ( isset($_POST['email']) && is_string($_POST['email']) ) ? trim($_POST['email']) : null; $comment_author_url = ( isset($_POST['url']) && is_string($_POST['url']) ) ? trim($_POST['url']) : null; $comment_content = ( isset($_POST['comment']) && is_string($_POST['comment']) ) ? trim($_POST['comment']) : null; }}}" tabacco 23413 Provide query result data to custom user columns Users normal normal Awaiting Review enhancement new has-patch 2013-02-07T15:22:53Z 2013-02-16T19:25:01Z "When the filter manage_users_custom_column is triggered, it sends an empty string for the value field. Since it's easy enough to extend the WP_User_Query with extra fields, it would be good to have those fields passed through if they exist to save having to requery the database with the user_id parameter to get the data. I have attached a patch to show what I mean." JohnC28 23412 Password protected pages - redirect after login General 3.5.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2013-02-07T10:32:30Z 2013-03-02T16:03:02Z "Hi, I am using WP 3.5.1 and I have found out that after a successful login to a password protected page, WP won't redirect back. This is because referrer is empty. So I have modified page login script to have hidden ""_wp_http_referer"" field in form. After that, login redirects back to page normally. Here is my script: {{{ function my_password_form() { global $post; $label = 'pwbox-'.( empty( $post->ID ) ? rand() : $post->ID ); $o = ' ' . __( ""To view this protected post, enter the password below:"" ) . ' ' . __( ""Password:"" ) . ' '; return $o; } add_filter( 'the_password_form', 'my_password_form' ); }}} This functions returns empty URL to wp-login.php script: {{{ function wp_get_referer() { $ref = false; if ( ! empty( $_REQUEST['_wp_http_referer'] ) ) $ref = $_REQUEST['_wp_http_referer']; else if ( ! empty( $_SERVER['HTTP_REFERER'] ) ) $ref = $_SERVER['HTTP_REFERER']; if ( $ref && $ref !== $_SERVER['REQUEST_URI'] ) return $ref; return false; } }}} I hope this helps. I have tried this with all plugins disabled, and also on 20-12 theme, same error occurs. Bye, Dubravko " dood_cro 23411 Plugin images are sent with wrong Content-Type WordPress.org site normal normal WordPress.org defect (bug) new 2013-02-07T09:26:46Z 2013-02-07T10:01:38Z "Some images are sent with the Content-Type `application/octet-stream`. Example: http://s-plugins.wordpress.org/buddypress/assets/screenshot-1.gif?rev=626668 {{{ HTTP/1.1 200 OK Accept-Ranges: bytes Content-Type: application/octet-stream Date: Thu, 07 Feb 2013 09:18:48 GMT ETag: ""626668//buddypress/assets/screenshot-1.gif"" Last-Modified: Sun, 18 Nov 2012 17:27:41 GMT Server: ECS (fcn/419A) X-Cache: HIT Content-Length: 11248 }}} Linked from http://wordpress.org/extend/plugins/buddypress/screenshots/ Each time I want to load the pure image I get a download dialog in my browser." toscho 23410 Screenshots behaviour not same between /assets and /tags/xxx WordPress.org site normal normal WordPress.org defect (bug) new 2013-02-07T06:04:23Z 2013-02-17T04:32:27Z "Plugins screenshots have differing behaviour whether stored in /assets or /tags/xxxx folders in plugin SVN repository. * /tags/xxxx => scaled images with links to source images * /assets => scaled images without links Also, when loading a plugin for the first time recently, the screenshots didn't appear until after I added them to the /assets folder. I suspect something has changed there, as I had read that screenshots should fallback to stable tag/trunk folder. Examples: * [http://wordpress.org/extend/plugins/gravity-forms-dps-pxpay/screenshots/ Gravity Forms DPS PxPay] has /assets folder, screenshots don't link * [http://wordpress.org/extend/plugins/gravityforms-eway/screenshots/ Gravity Forms eWAY] has no /assets folder, screenshots link to source images" webaware 23409 Featured Images Not Working when From Media Library Media 3.5.1 normal normal Awaiting Review defect (bug) new 2013-02-07T02:37:57Z 2013-02-16T01:39:02Z "I am in 3.5.1, Multisite, all plugins disabled, using Twenty-Twelve theme. While editing a post, when clicking on ""Set Featured Image"" in the meta box, I get the popup and select the image. I then click ""Save Featured Image."" The box closes. The meta box displays nothing -- just the original ""Set Featured Image"" link. So, I Update the post. Still, no featured image. Going through the above steps, I decide instead to upload an image from my computer. When I do, and select it as my featured image, it works. It seems to choke only on files that are already in the media library. " saracup 23408 Link to rss-feed in default installation causes redirect loop Canonical normal major Awaiting Review defect (bug) new 2013-02-06T21:20:04Z 2013-02-20T02:56:37Z "I noticed, that google webmastertools complained about dead links in my blog. Those links were hidden in the html-code and were links to rss-feeds of attachments. (e.g. ?attachment_id=1647&feed=rss2) When i try to open the link, it returns a 301 error and if the new url is called, anoter 301 error is shown. After two or three times, the original url is shown again by a 301 error message. I installed two clean installations on different servers, which show the behaviour either. If i use the link ""?attachment_id=1647&feed=rss"" the correct feed is loaded. (using rss instead of rss2 which is provided by the template) It seems that the error is caused by the function get_post_comments_feed_link(...) in ""wp-include/link-template.php used wp-include/canonical.php. When i add another line to the function to return a link with ""attachment_id="" and not ""p="" or ""page_id"", the comment feed is loaded without errors. But the fact, that rss feeds do not cause an error and rss2 feeds create a loop makes me think, that another module may be defect and my workaround is not a solution. Regards Fabian" clusterone 23407 http 403 should be returned for private content General 3.4 normal normal Awaiting Review defect (bug) new 2013-02-06T20:32:29Z 2013-02-07T09:18:40Z "Right now a 404 is returned which indicates that there is no content at the URL while all you need to do in order to see it is to login. Same probably applies to posts which where published and returned to draft state. " mark-k 23406 Some notices messages which can maybe fixed Warnings/Notices 3.5.1 normal trivial Awaiting Review defect (bug) new 2013-02-06T17:59:55Z 2013-02-06T18:07:32Z "Hi, I use wordpress multisite on my own cms and I notice there are many notice messages when I load WP (include($wppath.""includes/wp.inc.php"") : 1) Declaration of Walker_Category::start_el() should be compatible with that of Walker::start_el()) in /wp-includes/category-template.php line 902 2) Declaration of WP_Scripts::set_group() should be compatible with that of WP_Dependencies::set_group()) in wp-includes/class.wp-scripts.php 3) Declaration of Walker_Nav_Menu::start_el() should be compatible with that of Walker::start_el()) in wp-includes/nav-menu-template.php 4) is_a(): Deprecated. Please use the instanceof operator) dans le fichier wp-includes/capabilities.php Hope it helps Regards, Alexandre" uniterre 23402 remove_query_arg messing up some URLs General normal normal Awaiting Review defect (bug) new 2013-02-06T01:00:41Z 2013-02-06T15:15:02Z "I'm using remove_query_arg to strip utm campaign parameters from user-submitted URLs, but for some URLs it is replacing dots with underscores. E.g. if you pass http://www.nanowerk.com/news2/newsid=28843.php into this: {{{ $url = remove_query_arg( array( 'utm_source' 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content' ), $url ); }}} it returns http://www_nanowerk_com/news2/newsid=28843.php " lumpysimon 23399 Add filter wp_insert_attachment_data mirroring wp_insert_post_data Post Types 3.5 normal minor Awaiting Review enhancement new has-patch 2013-02-05T21:36:26Z 2013-02-05T21:56:44Z "In commercial applications it's handy to use the wp_insert_post_data filter in wp_insert_post() to control attributes of a post being inserted based on the user's role and other variables. We're using this to force content to go through a complex approval process which runs off of the post status. wp_insert_attachment() does not have a similar filter, which makes content approval processes difficult to implement. This patch adds a filter named wp_insert_attachment_data filter to wp_insert_attachment() which mirrors the form and functionality in wp_insert_post()." israelshirk 23395 Video elements removed after revision Embeds 3.5.1 normal critical Awaiting Review defect (bug) new 2013-02-05T14:19:40Z 2013-02-05T14:19:40Z "Users have been reporting that when they make a revision to an article that includes embedded videos, their updated version removes all YouTube embed videos. This is occurring from both Text & Visual editor views. Restoring a previous revision does not resolve the issue. This also happens when ""previewing"" a post prior to publish. Site with issues: http://porchdrinking.com Thanks! - Chris" chris_pd 23393 Popular tags shown at the add plugin page are useless Plugins normal normal Awaiting Review enhancement new 2013-02-05T11:29:28Z 2013-02-05T11:57:26Z "It seems like it reports the popular tags plugin authors use. Right now the popular tags I get are ""admin"",""post"",""widget"", ""Ajax"",""plugin"",""posts""... even ""wordpress"" is there. I don't know if wordpress.org should simply automatically remove this type of tags, but how plugin authors tag their plugins is the least interesting information to the user. The user probably want to install a plugin which was installed by other people so tag popularity here should be by amount of downloads per tag. There are two SEO plugins in the most popular, but fro the tag cloud you might think that wordpress users are not interested in SEO" mark-k 23391 User in contributor role can add images to post only via the text editor Role/Capability normal normal Awaiting Review enhancement new 2013-02-05T07:34:26Z 2013-02-05T10:15:34Z "1. Create a user with contributor role 2. start new post with it 3. notice there is no ""add media"" button anywhere 4. switch to text editing 5. use the img button to insert a URL to a valid img on the web 6. request approval for the post 7. let admin/editor approve it 8. go the the post's URL and notice that the image is shown So, it is not that contributors are not allowed to use images, it is just that WP makes it hard to do so. Either HTML needs to be sanitized and have all img tags removes for contributors, or access to the media library should be allowed for contributors denying only access to uploading. I vote for the second option." mark-k 23389 Only First Letter of Edited Link is Linked TinyMCE 3.5.1 normal normal Awaiting Review defect (bug) new 2013-02-05T03:08:27Z 2013-02-05T13:01:01Z "Steps to reproduce: 1. Make a link. 1. Highlight it. 1. Start typing. Expected results: New text should be linked. Or, maybe the link should disappear? Actual results: The first letter is linked, the rest are not." miqrogroove 23387 Adding priority to individual settings via the settings API. General 3.5 normal normal Awaiting Review enhancement new has-patch 2013-02-05T00:05:19Z 2013-02-05T11:54:36Z "Currently there is no way (at least that I could find) to specify the order of settings on a settings page (for example, a theme options page). Use case: a child theme adding a setting to the parent theme's ""Theme Options"" page has no way of specifying the order in which the new setting should be inserted. I've modified the add_settings_field() function to allow for a priority to be set (much like when adding settings to the theme customizer). I also added uasort($wp_settings_fields[$page][$section], 'compare_priority'); to the do_settings_fields() function, where 'compare_priority' is a slightly modified version of the compare function used to set the priority of the theme customizer sections. This patch is loosely related to #22487 which adds priority to settings sections, but not individual settings." alexmansfield 23383 High archive page numbers cause invalid database queries Database trunk normal normal Awaiting Review defect (bug) new 2013-02-04T20:36:30Z 2013-02-05T13:46:24Z "Visiting `http://www.viper007bond.com/category/videos/page/6805063692754011230` on my site generates the following database query: `SELECT SQL_CALC_FOUND_ROWS wp_posts.ID FROM wp_posts INNER JOIN wp_term_relationships ON (wp_posts.ID = wp_term_relationships.object_id) WHERE 1=1 AND ( wp_term_relationships.term_taxonomy_id IN (21) ) AND wp_posts.post_type = 'post' AND (wp_posts.post_status = 'publish' OR wp_posts.post_status = 'private') GROUP BY wp_posts.ID ORDER BY wp_posts.post_date DESC LIMIT 6.805063692754E+19, 10` Note the scientific notation `LIMIT` value. PHP: 5.3.15-pl0-gentoo[[BR]] MySQL: 5.2.12[[BR]] WordPress: r23386 " Viper007Bond 23382 WordPress admin panel lags Editor normal normal Awaiting Review enhancement new 2013-02-04T19:02:20Z 2013-05-15T16:34:39Z "I'm using Windows 7, brand-new laptop with i7 processor, 8GB RAM and 1080p resolution. I have created a post with 15 1920x1080 images in it and a lot of content (25000 characters). Results: === CHROME & CHROME CANARY === It's far from being usable at all. It lags that much that cursor doesn't even change from ""default"" to ""pointer"" when I hover over ""Publish"" button. Even switching to WordPress Admin Panel tab takes 5 seconds. Textareas are not resizable because lags prevent my mouse cursor from doing anything. Actually, entire Admin Panel lags, all these Drag&Drop widgets etc. === FIREFOX === A bit better than Chrome, everything lags but at least I can resize textareas and after 10 seconds it becomes usable. Nonetheless, it's not as smooth as other websites. === IE10 === Excellent. Not even a single slowdown! === SAFARI === Very close to IE10. I think that WordPress Admin Panel is stuffed with heavy Javascript. Maybe it's worth taking a look at that. The module that seems to be the heaviest is TinyMCE - when this appears then lags appear as well. Chrome works fine everywhere except WP Admin Panel. Good luck guys and thank you for your hard work during WordPress development :) My complaints are here only to make it better. I can live with these lags (since I can do it in IE10) but those are just my thoughts (many people use Chrome)." Looimaster 23379 Make it possible to update localization files through subversion again, or provide a standalone mo/po file download WordPress.org site normal normal WordPress.org defect (bug) new 2013-02-04T04:57:40Z 2013-02-04T08:38:15Z "Hi, I wrote a script here a couple years ago to update the core WordPress application through subversion, coz I am tired of tracking my own modifications (if there is any) https://github.com/timdream/wp-script However, starting v3.3.1, I am not be able to update mo/po files through wordpress-i18n svn repo. According to the localization site here https://tw.wordpress.org/, I would have to export the files through GlotPress myself. That leave me two choices with my script: 1. Hack my way through GlotPress, curl the GET requests to download the l10n files. The script would have to figure out 3.5.1 comes from 3.5.x first, and zh_TW -> zh-tw. 2. Download http://tw.wordpress.org/latest-zh_TW.tar.gz, extract and discard everything except the language directory. Neither approach is optimal. So I would like to propose some possible approaches here: A. Export the po/mo files back to subversion. I think this must have been discussed somewhere with people against it. B. Provide latest-zh_TW-language.tar.gz package. I am not aware of whether (B) is already exist or not, nor I am aware of where the packaging script is being maintained. If the script is somewhere publicly available through subversion, I am more than happy to provide a patch to it. Until then, I would probably need to find some time to implement (1) in shell script :-/ Thank you for reading the bug report. " timdream 23378 wp_(insert|update)_term() should accept term slug as 'parent' argument Taxonomy normal normal Awaiting Review enhancement new has-patch 2013-02-04T02:54:38Z 2013-02-10T06:56:17Z For those programmatically using `wp_insert_term()` and `wp_update_term()`, it would be great if the 'parent' argument could be a term_id or term slug. danielbachhuber 23377 map_meta_cap() throws error from has_cap() from current_user_can() Role/Capability normal normal Awaiting Review defect (bug) new dev-feedback 2013-02-04T02:49:22Z 2013-03-07T05:57:10Z "Based on the [http://codex.wordpress.org/Function_Reference/current_user_can current documentation], current_user_can() only requires one argument, a capability. However, if I call it from the `save_post` hook with WP_DEBUG turned on, I will receive the following errors: {{{ Notice: Undefined offset: 0 in /var/www/XXXX/htdocs/wp-includes/capabilities.php on line 1067 Notice: Undefined offset: 0 in /var/www/XXXX/htdocs/wp-includes/capabilities.php on line 1067 Notice: Undefined offset: 0 in /var/www/XXXX/htdocs/wp-includes/capabilities.php on line 1067 Warning: Cannot modify header information - headers already sent by (output started at /var/www/XXXX/htdocs/wp-includes/capabilities.php:1067) in /var/www/XXXX/htdocs/wp-includes/pluggable.php on line 876 }}} As a result, the admin save post will die. Basic Sample Code: {{{ if ( ( 'page' == $post->post_type && ! current_user_can( 'edit_page' ) ) || ! current_user_can( 'edit_post' ) ) return; }}} As a result, in my opinion `map_meta_cap()` should ensure that `$args[0]` exists." wpsmith 23374 Custom photo title is overwritten upon completion of upload Media 3.5.1 normal normal Awaiting Review defect (bug) new 2013-02-03T03:37:30Z 2013-02-03T03:37:30Z "Version: 3.5.1 (latest) Environment: Chrome 24.0.1312.57 on Mac OSX 10.8.2 Steps to reproduce: 1. Create a new post and click the Add Media button. 2. Add several large photos (>4MB). This is necessary to give you time to perform step 3. 3. Add new titles to the photos that are in the process of uploading. Output: after a photo finishes uploading, its newly-added title get overwritten by a default title (taken from the filename) Expected output: on the completion of a photo upload, the title field should be checked and preserved if necessary, not overwritten (not related to plugins or theme)" franksvalli 23373 Limiting get_users() results by meta value with LIKE wildcards Users 3.5 normal normal Awaiting Review enhancement new has-patch 2013-02-03T03:07:03Z 2013-02-03T06:56:27Z "I want to limit the results returned by get_users() to a subset of the users based on some criteria that will be stored in the User Meta table (e.g. all users whose first name begins with M). Here arr the args I am passing to get_users(): {{{ ( [include] => [exclude] => [fields] => all_with_meta [meta_key] => last_name [meta_value] => M% [meta_compare] => LIKE ) }}} This is the query the WordPress constructs for me: {{{ [01-Feb-2013 16:01:08 UTC] WP_User_Query Object ( [query_vars] => Array ( [blog_id] => 1 [role] => [meta_key] => last_name [meta_value] => M% [meta_compare] => LIKE [include] => [exclude] => [search] => [search_columns] => Array ( ) [orderby] => login [order] => ASC [offset] => [number] => [count_total] => [fields] => all_with_meta [who] => ) [results] => Array ( ) [total_users] => 0 [query_fields] => wp_users.ID [query_from] => FROM wp_users INNER JOIN wp_usermeta ON (wp_users.ID = wp_usermeta.user_id) [query_where] => WHERE 1=1 AND ( (wp_usermeta.meta_key = 'last_name' AND CAST(wp_usermeta.meta_value AS CHAR) LIKE '%M\\%%') ) [query_orderby] => ORDER BY user_login ASC [query_limit] => }}} ---- As you can see, the LIKE clause is escaped and wrapped with SQL wildcard operators. I can't figure out how to prevent this from happening as what I want is ""LIKE 'M%'"" to be my actually query. Andrew Nacin wp@andrewnacin.com via lists.automattic.com 11:24 am (1 day ago) to wp-hackers Currently, ""LIKE"" prepends and appends wildcards, as in %term%. We could add ""%LIKE"" and ""LIKE%"", though that would not help with the situation where you want LIKE taken literally, potentially without % wildcards at all. (Such as using _ as a single-character wildcard, or looking for case insensitive matching.) Probably the best way to add to this API would be to allow for a 'like_escape' => false; that would accept your value as provided. If you'd like to submit a ticket (and patch), this can definitely find its way into 3.6. Nacin ---- I have prepared a patch to meta.php which allows escaped LIKE and NOT LIKE meta compares to work properly. " mpwalsh8 23371 Subdir front-end Toolbar bug on first login Toolbar 3.3 normal normal Awaiting Review defect (bug) new dev-feedback 2013-02-02T22:36:59Z 2013-02-04T20:17:25Z "In an obscure set of circumstances, I encountered a small bug where the Toolbar doesn't display on the front-end of a subdirectory install on the first login where the site URL points to the root domain. `show_admin_bar_front` is rightly set to true both on first and second+ logins, but the Toolbar doesn't display on the front-end. The js isn't even being loaded. I can reproduce this all the way back to 3.3. To reproduce: 1. Install a fresh copy of !WordPress in a subdirectory. 2. Login. 3. Change site url to point to the main domain. 4. Visit the front-end, observe the Toolbar isn't displayed. 5. Logout. 6. Login again. 7. Re-visit the front-end, observe the Toolbar now displays as expected. I'm unable to trace back what's causing the Toolbar not to be displayed after the initial login. Maybe we should just force the user to login again after changing the site url." DrewAPicture 23369 WP_Comment_Query meta query 'count' conflicts with 'group by' Comments 3.5.1 normal normal Awaiting Review defect (bug) new 2013-02-02T13:39:20Z 2013-02-02T14:52:54Z "This problem relates to {{{/wp-includes/comment.php}}}, both 3.5.1 and trunk are affected. The following line number refers to the 3.5.1 version. At line 195, definition of class {{{WP_Comment_Query}}} , a typical meta query will generate such SQL: {{{SELECT * FROM wp_comments INNER JOIN wp_commentmeta ON (wp_comments.comment_ID = wp_commentmeta.comment_id) WHERE ( comment_approved = '0' OR comment_approved = '1' ) AND comment_post_ID = 22 AND ( (wp_commentmeta.meta_key = 'my_flag' AND CAST(wp_commentmeta.meta_value AS CHAR) = 'my_value') ) GROUP BY wp_comments.comment_ID ORDER BY comment_date_gmt DESC }}} Note that at line 357, a meta query will always generate a {{{GROUP BY}}} clause. This works for comment rows. Say that I've got 3 comments matching this query, I'll see each of them in a row: {{{ comment row 1, data comment row 2, data comment row 3, data }}} However, this query doesn't work well then {{{$count = true}}}. Note that by specifying {{{$count = true}}}, the function only changes {{{'SELECT *'}}} into {{{'SELECT COUNT(*)'}}}. For 3 comment result, I'm seeing something like this: {{{ 1 1 1 }}} And you can see, because there's a {{{'GROUP BY'}}} clause. And each comment has a unique ID. The result is 3 'grouped row' of comments, and each will always have count of 1. Therefore, the result of {{{$wpdb->get_var()}}} will be either 1, or NULL (when nothing is matched). I believe this behavior is not by intention. To get count working, {{{'GROUP BY'}}} clause must be removed when $count is true." heshiming 23368 Random order for wp_user_query Users 3.5 normal normal Awaiting Review enhancement new dev-feedback 2013-02-02T09:24:40Z 2013-02-02T15:42:14Z "Unlike the '''wp_query''', '''wp_user_query misses''' the order by random option. This option is necessary when you have a lot of users and we want to show only some of them randomly in a widget or anywhere on the blog. It would be great to have this option in the next wp release." gandham 23367 Remove message parameters fron admin URl's in the browser address bar General normal minor Awaiting Review enhancement new 2013-02-02T07:31:20Z 2013-02-02T07:31:20Z "Scenario: When a post is being published successfully ""message=6"" is appended to the URL. If I refresh the page while in that state I will get the ""post published"" message again, although nothing was done. There is probably nothing functionally wrong with the way things work now but it can be esthetically more pleasant if that parameter was removed which in turn will eliminate the message problem. This can be done on browsers that support the history API of HTML5. The following piece of code can be used after displaying the message or maybe it can be generalized to work in the admin footer. {{{ }}} " mark-k 23365 Add Option for user defined from_email Mail normal normal Awaiting Review enhancement new 2013-02-02T03:25:47Z 2013-02-03T08:04:34Z "As is admitted in pluggable.php in the wp_mail function, the default from address is not ideal. If set to wordpress@domain(dot)com, some hosts block the E-mail because it doesn't exist. If set to admin_email, some hosts block it because it's from an unknown domain. The most natural answer to me is to add an option for this in the admin interface. This way, people with an issue, or simply trying to appear more professional, are able to change this without a plugin or adding code to their theme. Even if the option is pretty buried, a simple help doc could point folks to the right spot. For proof of need, check out all the threads under http://wordpress.org/search/wordpress%40?forums=1" stevish 23364 Unstable sorting with jQuery UI 1.9.1 and above External Libraries 3.5 normal normal Awaiting Review defect (bug) new dev-feedback 2013-02-02T03:07:18Z 2013-02-02T03:09:35Z "There seems to be an issue with jQuery UI (sortable) 1.9.1 and above that affects (rather severely) sorting of elements inside sortable source and target containers. I haven't seen this affect core, but since WP has been shipping with one of the affected versions (1.9.2) since 3.5, I'm worried about potential repercussions on WP theemes, plugins or projects relying on this script. For instance, Ultimate Tinymce, by Josh Lobe and myself (recently), has been affected by this.[[BR]] [http://elblawg.com/jqueryui-test/ Here] is a testing platform I created on my server about the problem. Choosing any version of UI newer than 1.9.0 will result in said behavior.[[BR]] [http://bugs.jqueryui.com/ticket/9041 Here] is the ticket I submitted to jquery UI Trac and [https://github.com/MarventusWP/jquery-ui/commits/master here] the Commits to their github project.[[BR]] Finally, as recommended by Andrew Nacin on the wp-forums list, [http://jsfiddle.net/Marventus/THwqS/1/ here] is a JSFiddle that reproduces the problem.[[BR]] I am not really sure what to do about this, but I thought I should leave it on record just in case. Thanks!" Marventus 23363 When uploading batches of photos oversized photos fail silently Upload 3.5.1 normal normal Awaiting Review defect (bug) new 2013-02-02T01:52:42Z 2013-02-02T03:28:47Z "Summary: When uploading a batch of photos as part of a gallery, some of which are larger than the maximum allowable, the photos under the maximum size upload successfully while the photos that are too large fail silently. Steps to Reproduce: 1. On a post or page, click ""Add Media"" button 2. Click ""Create Gallery"" and ""Upload Files"" 3. Click ""Select Files"" and select several files, some of which are larger than the maximum allowable file size, and some which are smaller 4. Press select Expected Results: Either no files upload (as some are to large to upload) or the files small enough to upload upload successfully (as is the current case) ''and'' an error is displayed stating which photos cannot be uploaded and why. Actual Results: Only the photos that are small enough to be uploaded upload successfully while the photos that are too large fail to upload with no explanation, before, during, or after the upload process. Browser: Safari 6.0.2 on Mac OS" davidwillmore 23361 "Deleting a user in Network Admin still defaults to ""Delete all posts""" Network Admin 3.5 normal normal Awaiting Review defect (bug) new 2013-02-01T19:02:55Z 2013-02-01T19:21:46Z "Background: #20045, #23224 We should either do what those tickets suggested in Network Admin as well for consistency, or redo/remove the form, since the attribution only works for the main site, as noted in [comment:ticket:20045:14]." SergeyBiryukov 23358 Switch to a usermeta key for email confirmation in Multisite Multisite 3.0 normal normal Awaiting Review enhancement new 2013-02-01T13:54:05Z 2013-02-01T13:54:53Z "Background: #23146 In `send_confirmation_on_profile_email()`, an option is used to store the new email: [[BR]] http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/includes/ms.php#L238 A usermeta key should be used instead." SergeyBiryukov 23356 Editor's text color button indicated different text color then the one use in several cases TinyMCE 3.4 normal normal Awaiting Review defect (bug) new 2013-02-01T08:50:53Z 2013-02-01T15:12:22Z "1. Select a text color - the underline in the button will be displayed in that color 2. write some text with this color 3. start a new paragraph 4. button color remain the same but the text is in the theme's default color Same when moving to different section of the document, the button do not pick the right color used in the text and stays in its last setting." mark-k 23355 "There should be away to select ""no color""/""theme color"" at the editor's text color selection" TinyMCE normal normal Awaiting Review enhancement new 2013-02-01T08:42:51Z 2013-02-01T11:38:48Z "If I changed the color of a selected text the only way to revert the change is by using the ""delete styling"" button which is totally not obvious" mark-k 23353 Color picking for text color in the editor doesn't use standard color picker TinyMCE 3.4 normal minor Awaiting Review defect (bug) new 2013-02-01T07:35:59Z 2013-02-01T18:03:26Z It is bad enough that I don't really understand how to work with farbtastic, so having two different ones make me feel double stupid ;) mark-k 23350 Pingback Denial of Service Fix - filter_var based IP validation Pings/Trackbacks 3.5.1 normal normal Awaiting Review defect (bug) new has-patch 2013-02-01T02:24:57Z 2013-02-01T02:44:04Z "Just a small improvement upon review of [23330] (some points were not clear to me, especially colons in hostnames and trimming of the hostnames for dots; left them as-is). Also used {{{strcasecmp}}}. BTW, what about #4137, can it be closed now? " hakre 23349 Be able to suppress registration redirect for multisite in wp-login.php Multisite 3.5.1 normal normal Awaiting Review enhancement new 2013-02-01T01:29:35Z 2013-02-01T02:06:55Z "Currently I commented out the following lines in wp-login.php. But I should be able to use a filter. Maybe test the result 'wp_signup_location' filter if false do not exit. Easy, and seems to annoy many people. {{{ case 'register' : /* AJB Comment out if ( is_multisite() ) { // Multisite uses wp-signup.php wp_redirect( apply_filters( 'wp_signup_location', network_site_url('wp-signup.php') ) ); exit; } */ }}}" aberglas 23346 Remove rate limiting for plugin authors on their own support topics WordPress.org site normal normal WordPress.org enhancement new 2013-01-31T18:46:41Z 2013-02-05T01:42:56Z I frequently get the 'slow down' message on the support forums when responding to support threads for my plugin - can the limit not be lifted when posting to topics tagged with a plugin that I am author of. volcanicpixels 23343 tinymce supports sevaral spellchecker but there is no option to configure it in wordpress TinyMCE normal normal Awaiting Review enhancement new close 2013-01-31T14:15:25Z 2013-02-01T11:38:45Z "tinymce configuration is in wp-includes\js\tinymce\plugins\spellchecker\config.php, at seems to support pspell, pspellshell, google spellchecker and rpc. Will be nice if it will be possible to configure it. A use case is create a network installation for a company which want to have its own vocabulary shared among all its writers." mark-k 23342 php error is display when using the spellchecker with php that doesn't include the openssl module TinyMCE 3.5 normal minor Awaiting Review defect (bug) new 2013-01-31T14:04:28Z 2013-02-01T21:35:06Z "I get the following error when trying to spell check on wordpress running on vanila install of wamp {{{ Error response: Warning: fsockopen() [function.fsockopen]: unable to connect to ssl://www.google.com:443 (Unable to find the socket transport "ssl" - did you forget to enable it when you configured PHP?) in D:\wamp\www\wp342\wp-includes\js\tinymce\plugins\spellchecker\classes\GoogleSpell.php on line 86 Could not open SSL connection to google.{""id"":null,""result"":[],""error"":null} }}} Enabling the module solves the problem. Suggesting to made is something human readable if it is possible." mark-k 23339 DFW in HTML mode should have switch text direction button for RTL languages Editor normal normal Awaiting Review enhancement new 2013-01-31T12:22:55Z 2013-02-01T19:14:02Z It is hard to edit HTML when the flow of the text is right to left. The normal HTML editor has this button when used in RTL environment. mark-k 23335 Bizarre sorting while browsing WordPress themes and plugins WordPress.org site normal normal WordPress.org defect (bug) new 2013-01-31T05:01:52Z 2013-04-05T15:21:54Z "Currently, there's some fuzzy logic while sorting plugins and themes. Sorting by popularity seems to be reset I'm guessing on every major WP version update, which I guess is fair, in which case the problem is just missing the proper description of the sort option. However, while sorting by rating, nothing really makes sense of the bizarre sort order there. ( [http://wordpress.org/extend/themes/browse/top-rated Top Rated Themes] ) Even while searching for a keyword, and sorting by ""rating,"" the [http://wordpress.org/extend/plugins/search.php?q=slideshow&sort=top-rated bizarre sorting ensues]. WordPress.org should be a shining example of what WordPress can do, and nail it. " ericlewis 23332 iPad Can't Move Cursor in Visual Editor Editor normal normal Awaiting Review defect (bug) new 2013-01-30T23:13:50Z 2013-02-11T23:33:20Z "I've been ramping up iPad usage with WordPress both for mobility as well as testing. The more I use it, the more frustrated I become with the visual editor. Due to what appears to be multiple bugs with both iOS and WordPress, I am often unable to move the cursor and must switch to the Text tab to do my editing. When tapping into the Visual editor in a long post, the screen auto scrolls so that the cursor is sitting directly above the keyboard, and the admin bar moves to the middle of the page, covering most of the remaining editing area. This blocks the view of any preceing or following text, and makes it very awkward to write sentences longer than the editor is wide. To move the cursor to a different part of the post, I have to un-focus the editor and the tap into the editor on a different line. The only place I can reliably land the cursor is at the end of a line, so to change anything in the middle of a paragraph, I have to use the text editor." miqrogroove 23331 Gmagick support Media normal normal Future Release enhancement new has-patch 2013-01-30T22:33:53Z 2013-04-25T20:50:14Z In 3.5 we added Imagick support. It would be great to also include Gmagick. Since Graphicmagick is just more awesome then ImageMagick. markoheijnen 23330 Allow autoloading all options, not just autoload = yes options Cache 3.5.1 normal normal Future Release defect (bug) new 2013-01-30T21:12:57Z 2013-02-21T04:26:41Z "For 5 years on wordpress.com we have ignored the autoload field for options. In wp_load_alloptions(), autoload = yes is not part of the query. Why? Because wordpress.com has a persistent cache. Thus, the transients that constitute the bulk of autoload = no options are stored in cache, never in the options table. Querying autoload=yes makes the query slower for no reason. Having autoload = no options also complicates notoptions caching. Core has a notoptions cache that would be unnecessary if you can assume that wp_load_alloptions() loads every option. If an option is not in alloptions, then it does not exist. Other large sites that use a persistent cache might also like to ignore the autoload flag. Core could automatically switch to ignoring autoload when an external object cache is being used, but administrators might want to control this so they can clean out old transients from options tables and do whatever other housekeeping is desired. So, let's add a filter that allows toggling this. When autoload is being ignored the wp_load_alloptions() query does not include autoload=yes and notoptions is not used." ryan 23329 Deprecate is_main_query() Query normal normal Future Release enhancement new has-patch 2013-01-30T21:04:29Z 2013-05-14T13:48:58Z "The function `is_main_query()` is misleading, and rather useless. In practical situations, it is necessary to reference the method in the current query object, such as when used at the `pre_get_posts` action. The example in the Codex is even wrong: {{{ add_action( 'pre_get_posts', 'foo_modify_query_exclude_category' ); function foo_modify_query_exclude_category( $query ) { if ( ! is_admin() && is_main_query() && ! $query->get( 'cat' ) ) $query->set( 'cat', '-5' ); } }}} I propose deprecating the function as an encouragement for users to refer to the query object method instead." ethitter 23328 While editing widgets in accessibility mode the position can be indicated by widget titles instead of numbers Widgets normal normal Awaiting Review enhancement new 2013-01-30T18:32:33Z 2013-03-04T20:06:35Z "Guess it title says it all. Right now you need to figure out the position you want the widget to be at and try remember it while editing the widget. I suggest to change the text text of the position column header from ""position"" to ""position after"" and use labels in the drop down 1 => ""top"" 2 => top widget title 3 => second widget title[[BR]] etc" mark-k 23327 Cache incrementors for get_bookmarks() Cache 3.5.1 normal normal Future Release task (blessed) new early 2013-01-30T18:24:08Z 2013-04-16T17:11:33Z "Make use of a caching incrementor and store queries in individual cache buckets to avoid memory exhaustion. Pattern this after #23167, which does the same thing for get_pages(). See #23173 for an explanation of the motivation behind this." ryan 23323 img quicktag is so inferior to add media, should be merged or removed Editor 3.5 normal normal Awaiting Review enhancement new close 2013-01-30T09:55:50Z 2013-01-30T20:16:31Z "Right now, in the text editor there are two ways to add an image, with the ""img"" button or the ""add media"" button. ""Add media"" contains all the functionality of ""img"" and adds much more, while ""img"" is ugly and feels like an historical artifact. IMO ""img"" should be deleted or be an alias to ""add media""" mark-k 23321 ins button in text editor produce semantically different HTML then the U button at the visual editor Editor normal minor Awaiting Review defect (bug) new 2013-01-30T06:54:51Z 2013-01-30T06:54:51Z "U button at the visual editor makes something like {{{ text }}} while the ins at the text editor makes {{{ text }}} It is actually not easy to understand that the intentions behind both are equivalent - underline the text*, but semantically they have different meaning, and in the context of WP usage the styling one has probably the more correct meaning. Alternatively, if ""ins"" is important html tag then why it is not possible to add it in the visual editor. related #20149 *Browsers by default underline ""ins"" but twentyeleven and twentytwelve remove it." mark-k 23318 Plugins Admin Showing Details for Wrong Plugin Plugins normal normal WordPress.org enhancement new dev-feedback 2013-01-29T22:41:54Z 2013-04-05T02:00:19Z "I just set up a new site with some plugins, none of them activated yet. The plugins screen says: ""There is a new version of Google XML Sitemaps available. View version 4.1 details or update now."" I know for a fact there is no such version of this plugin. When I click details link, it tells me to install some other plugin called page-list?!" miqrogroove 23316 Top level admin sidebar menu items with conflicting positions bury one another Administration 3.5.1 normal major Awaiting Review defect (bug) new 2013-01-29T21:07:27Z 2013-01-30T04:23:58Z "I have now seen two separate instances where a top level admin sidebar menu item wasn't showing up when another Plugin or Theme was activated. In the most recent case, using WP 3.5.1. my Plugin was creating a top level menu item with no position specified (blank, default). When I activated my client's Theme, our Plugin sidebar item disappeared and in place came the Theme Options item. I set our Plugin to use position 70, and it came back in place of the Users top level menu item. In the earlier case, I had a custom post type that was requesting position 20. Whenever I activated Gravity Forms, my custom post type menu item was disappearing. This was with WordPress v3.5 According to the codex page: ""''WARNING: if two menu items use the same position attribute, one of the items may be overwritten so that only one item displays! Risk of conflict can be reduced by using decimal instead of integer values, e.g. 63.3 instead of 63 (Note: Use quotes in code, IE '63.3').''"" This seems like a bug to me. Why should items be allowed to completely overwrite one another? Shouldn't they just fall in line, albeit randomly when two conflict? I can see tons of problems with Themes and Plugins killing one another's top level menu items, and the user not understanding what's going on when they loose something unexpectedly." beautomated 23314 Allow published posts to be revised without being updated immediately Revisions normal normal Future Release feature request new early 2013-01-29T19:39:01Z 2013-04-10T09:08:15Z Two things. Let's allow contributors to submit changes for review to their published posts. Let's also allow users to make changes to their posts and pages and save those changes, without updating the published post or page. kovshenin 23311 Enable internationalization in PHPMailer I18N 3.5 normal minor Future Release enhancement new has-patch 2013-01-28T16:37:06Z 2013-05-16T12:12:28Z Per the discussion in #23291, we should enable PHPMailer's internationalization feature so that any error messages returned by it and displayed to the user will be translated. iandunn 23309 Not all WP_Query::query_vars get updated during WP_Query::get_posts() Query normal normal Awaiting Review defect (bug) new 2013-01-28T15:40:56Z 2013-01-28T19:51:54Z "There is a lot of logic within the WP_Query::get_posts() method that fills in missing query vars with defaults and manipulates others based on the rest of the query. However, some of the final states for many of the variables aren't updated in the WP_Query::query_vars array. For example, the post type is lost as a local variable and post_status is used for building compiling mysql expressions, but never directly updated. The result is that any plugins that want to recreate the query for another system, (ie, an external search provider) must directly copy much of the business logic that WP_Query::get_posts() has embedded in it in order to fill in for the incomplete query_var array. " prettyboymp 23308 "make_clickable problem with multiple ""Punctuation URL character""" Formatting 3.5.1 normal normal Awaiting Review defect (bug) new 2013-01-28T15:09:59Z 2013-01-28T15:09:59Z "make_clickable problem with multiple ""Punctuation URL character"" E.g. {{{ http://www.wordpress.org/some-(parentheses).html }}} Results in this html code: {{{ http://www.wordpress.org/some-(parentheses).html }}} But obvious should be: {{{ http://www.wordpress.org/some-(parentheses).html }}} I suggest to replace: wp-includes/formatting.php:1603 {{{ [\'.,;:!?)] # Punctuation URL character }}} with {{{ [\'.,;:!?)]{1,} # Punctuation URL character }}}" DrPepper75 23307 shortcode_parse_atts may return empty string Shortcodes normal minor Awaiting Review defect (bug) new has-patch 2013-01-28T11:08:50Z 2013-01-28T11:15:33Z "See http://core.trac.wordpress.org/browser/tags/3.5.1/wp-includes/shortcodes.php#L243 . If there are no attributes in a shortcode e.g. `[foobar]`, then shortcode_parse_atts returns an empty string. This is not reflected in the long description or `@return` tag. Ideally though, it should return an empty array, so that it's not only consistent, but writing a shortcode function can type hint the `$atts` argument to be an array e.g. {{{ add_shortcode( 'foo', 'my_shortcode' ); function my_shortcode( array $atts ) { ... } }}} This might also be combined with checking if the incoming `$text` is empty, and returning an empty array immediately." GaryJ 23302 Feeds or Feed - add_permastruct missunderstanding. Post Types 3.5.1 normal normal Awaiting Review defect (bug) new has-patch 2013-01-27T16:00:59Z 2013-01-27T16:19:00Z "In case of register_post_type you ""can"" specify to add feeds to permalink structure or not. You actualy [http://codex.wordpress.org/Function_Reference/register_post_type can do that] by specifing a 'feeds' element to '''false''' in rewrite array. But add_permastruct doesn't accept feeds element of rewrite argument. Its accept 'feed' element which default is true. So in this case its not posible to disable feeds for any post type via register_post_type API." butuzov 23296 3.6 - Edit Post, Invalid implode after Core-Update Warnings/Notices normal normal Awaiting Review defect (bug) new reporter-feedback 2013-01-25T23:48:51Z 2013-01-26T11:51:16Z "'''Error:''' implode(): Invalid arguments passed The implode function have invalid Arguments. '''URL:''' /wp-admin/edit.php [[BR]]'''HTTP referrer:''' http://adrean-test.eatserver.nl/wp-admin/update-core.php '''FIX (wp-includes/compat.php - Line 32):''' {{{ return ($chars ? implode( '', $chars ) : array()); }}} '''Stacktrace:''' {{{ in implode called at /www/htdocs-test/wp-includes/compat.php (32) in _mb_substr called at /www/htdocs-test/wp-includes/compat.php (18) in mb_substr called at /www/htdocs-test/wp-includes/formatting.php (3096) in wp_html_excerpt called at /www/htdocs-test/wp-includes/admin-bar.php (230) in wp_admin_bar_site_menu called at ? (?) in call_user_func_array called at /www/htdocs-test/wp-includes/plugin.php (487) in do_action_ref_array called at /www/htdocs-test/wp-includes/admin-bar.php (58) in wp_admin_bar_render called at ? (?) in call_user_func_array called at /www/htdocs-test/wp-includes/plugin.php (406) in do_action called at /www/htdocs-test/wp-admin/admin-header.php (113) in require_once called at /www/htdocs-test/wp-admin/edit.php (220) }}}" hovida 23292 Media uploader loads full size image and slows down, please change to thumbnails. Media 3.5 normal normal Awaiting Review defect (bug) new has-patch 2013-01-25T09:31:11Z 2013-01-25T12:31:37Z "The media uploader is really slow if you upload 1024 x 768 images, the reason for this is that the preview shows full size images. Underneath here is a quick fix to speed up the media uploader to thumbnails. Please change line 1333 in ""wp-includes/media.php"" from: {{{ $attachment_url = wp_get_attachment_url( $attachment->ID ); }}} to: {{{ $attachment_url = wp_get_attachment_thumb_url($attachment->ID ); }}}" mnrtjeR 23291 wp_mail should handle phpmailer exceptions instead of ignoring them Mail 3.5 normal minor Awaiting Review enhancement new has-patch 2013-01-25T07:04:37Z 2013-03-04T07:12:02Z "Right now code in wp_mail that call phpmailer looks like {{{ try { $phpmailer->Send(); } catch ( phpmailerException $e ) { return false; } }}} or worse (not failing at all). Yesterday had to hack core files to find out that an email address did not have a valid email format. Exceptions should either propagate in some way, or be reported to an error log. " mark-k 23287 Press This enhancement - enclose included content in a div to allow styling Press This 3.5 normal normal Awaiting Review enhancement new 2013-01-24T19:24:14Z 2013-01-24T19:24:14Z "The Press This functionality is effective and simple, but the content it drops into a blog post has no enclosing , and as a result cannot be styled using the theme's CSS file to differentiate it from the blogger's comments. I've posted on my own blog [http://aldred.org/blog/blog/2013/01/24/improving-press-this-in-wordpress/ this post] describing how I've made a fairly simple change to insert div tags round the quoted content. Ideally the div would also wrap the image, but that was beyond me! Can this be looked at as an enhancement?" daldred 23285 Implement an AMD JavaScript loader in WordPress General normal normal Awaiting Review feature request new 2013-01-24T14:28:47Z 2013-01-25T07:04:55Z "AMD = Asynchronous Module Definition See comment: http://core.trac.wordpress.org/ticket/22896#comment:29 I think this is a must for the future viability of WordPress and plugins written for it. Multiple versions of JavaScript libraries are a fact of life and we have to deal with it somehow. If WordPress provides the framework for the use of multiple versions of JavaScript libraries then a lot of the problems we see with WordPress now will be a thing of the past. This represents a major re-think of the current WordPress JavaScript loading paradigm, but I think it is necessary and would be well worth it. I'm not a terribly advanced developer, and there might be better solutions out there or others to come, but for now, I think this is the way to go. Example: http://requirejs.org/docs/why.html http://requirejs.org/docs/whyamd.html https://github.com/amdjs/amdjs-api/wiki/AMD It does not have to be RequireJS, but it seems the most mature and popular of the implementations. From the unminified jQuery source: {{{ // Expose jQuery as an AMD module, but only for AMD loaders that // understand the issues with loading multiple versions of jQuery // in a page that all might call define(). The loader will indicate // they have special allowances for multiple jQuery versions by // specifying define.amd.jQuery = true. Register as a named module, // since jQuery can be concatenated with other files that may use define, // but not use a proper concatenation script that understands anonymous // AMD modules. A named AMD is safest and most robust way to register. // Lowercase jquery is used because AMD module names are derived from // file names, and jQuery is normally delivered in a lowercase file name. // Do this after creating the global so that if an AMD module wants to call // noConflict to hide this version of jQuery, it will work. if ( typeof define === ""function"" && define.amd && define.amd.jQuery ) { define( ""jquery"", [], function () { return jQuery; } ); } }}} Note: '''multiple versions of jQuery'''" auniquename 23281 Enhancement for comment_form(); allow styling the submit button Template 3.5 normal normal Awaiting Review enhancement new has-patch 2013-01-24T01:08:14Z 2013-01-26T23:43:17Z "Hi there, I'm looking at adding a feature where we can define the class for the submit button. I'm happy to create a patch for this if required. The reason for this is because right now we can change say the email field so much but we get little to no concrol over the submit button. I'm looking at A: Convert the entire submit button into somehing like how the text areas are done (author and email) then we get full control over the styling and other things related or; B Add something like class_submit so that we can set the style of the submit button. Kind regards, Daniel Fenn" Danielx64 23280 TinyMCE issue with table wrapped with shortcode TinyMCE 3.5 normal normal Awaiting Review defect (bug) new 2013-01-24T01:07:43Z 2013-01-25T03:02:55Z "TinyMCE will generate unbalanced tags when a table is included as the content of a wrapping style shortcode. In this example, assume a shortcode called `[div] ... [/div]` that simply brackets the content with a ` ... `. This is an example as it would be in the editor's Text view (and it works if you switch back and forth to Visual.): ----------------- {{{ There will be a table following. [div] Simple table [/div] Next line is here. }}} ------------------------ The HTML output generated is this: {{{ There will be a table following. Simple table Next line is here. }}} ------------ The shortcode is very simple - just a demo. It returns simply: {{{ return '' . do_shortcode($text) . ''; }}} Doesn't seem to matter with or without the do_shortcode() call. -------- So note the excess after the added starting , and the extra before the from the shortcode. Seems to happen only with a wrapping style shortcode, and I think only with tables. " wpweaver 23279 Add templates to style registration, signup, activation, login and password reset pages Themes normal normal Awaiting Review enhancement new 2013-01-23T22:20:58Z 2013-01-25T15:29:55Z "As [https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2013-01-23&sort=asc#m539267 discussed in IRC], the ability to override the various user-related pages would be a great ability for themes to have. At the moment, it's pretty tedious to style these and there's very little control over the content of the page (some for good reason, others not so much). Related: #1155, #3123, #22139" rmccue 23278 Spin PressThis off into a plugin Press This 3.5 normal normal Awaiting Review enhancement new dev-feedback 2013-01-23T21:43:23Z 2013-01-24T12:25:15Z "PressThis has really been the ignored stepchild of WordPress for quite a while now. I'd like to propose that we spin it out of core and into a plugin (either installable via the plugin repo or bundled with wp, whatever) Several things to consider: * Backwards Compatability: What happens when someone upgrades then uses an old bookmarklet? I'd suggest either autoinstalling, or prompting them immediately to install the plugin through a special catch in core. * Press This doesn't have an includes file in wp-admin/includes that other plugins could pull in, so extracting it is very unlikely to break plugins that could be manually pulling that in. * This will make it easier to upgrade in plugin form, and let other people have an easier time hijacking it to use their own implementations. In today's IRC chat, as sabreuse pointed out, everyone seemed to either favor spinning it out into a plugin, or didn't have much of an opinion. If you really want it in core, please speak up! I'd love to hear your reasons. I'm willing to throw a massive chunk of time at this to make it work, if that's the decision that we decide to move forward with." georgestephanis 23276 WordPress Importer: Update existing navs instead of new Import normal normal WordPress.org defect (bug) new has-patch 2013-01-23T17:00:06Z 2013-01-25T02:41:23Z "A possible solution (reuses logic present in the code): {{{ $menu_item_db_id = (int) $item['post_id']; $original_object = get_post( $menu_item_db_id ); if ( is_null( $original_object ) ) { $post_parent = (int) $item['post_parent']; if ( $post_parent ) { // if we already know the parent, map it to the new local ID if ( isset( $this->processed_posts[$post_parent] ) ) { $post_parent = $this->processed_posts[$post_parent]; // otherwise record the parent for later } else { $this->post_orphans[intval($post['post_id'])] = $post_parent; $post_parent = 0; } } // map the post author $author = sanitize_user( $item['post_author'], true ); if ( isset( $this->author_mapping[$author] ) ) $author = $this->author_mapping[$author]; else $author = (int) get_current_user_id(); $postdata = array( 'import_id' => $item['post_id'], 'post_author' => $author, 'post_date' => $item['post_date'], 'post_date_gmt' => $item['post_date_gmt'], 'post_content' => $item['post_content'], 'post_excerpt' => $item['post_excerpt'], 'post_title' => $item['post_title'], 'post_status' => $item['status'], 'post_name' => $item['post_name'], 'comment_status' => $item['comment_status'], 'ping_status' => $item['ping_status'], 'guid' => $item['guid'], 'post_parent' => $post_parent, 'menu_order' => $item['menu_order'], 'post_type' => $item['post_type'], 'post_password' => $item['post_password'] ); $menu_item_db_id = wp_insert_post( $postdata, true ); if ( is_wp_error( $menu_item_db_id ) ) { $post_type_object = get_post_type_object( $item['post_type'] ); printf( __( 'Failed to import %s “%s”', 'wordpress-importer' ), $post_type_object->labels->singular_name, esc_html($item['post_title']) ); if ( defined('IMPORT_DEBUG') && IMPORT_DEBUG ) echo ': ' . $post_id->get_error_message(); echo ' '; } } $id = wp_update_nav_menu_item( $menu_id, $menu_item_db_id, $args ); }}}" WraithKenny 23275 WordPress Importer: line-ending mismatch corrupts serialized meta Import normal normal WordPress.org defect (bug) new has-patch 2013-01-23T16:56:04Z 2013-01-25T02:36:14Z "A possible solution: {{{ if ( $key ) { // export gets meta straight from the DB so could have a serialized string if ( ! $value ) $value = maybe_unserialize( $meta['value'] ); // Occationally, line-endings break unserialize() if ( empty( $value ) ) // Try normalizing... $value = maybe_unserialize( str_replace( array(""\r\n"", ""\r"", ""\n""), ""\r\n"", $meta['value'] ) ); if ( empty( $value ) ) // Adjust string length if needed $value = maybe_unserialize( preg_replace( // e flag deprecated in PHP 5.5.0 I think '!s:(\d+):""(.*?)"";!se', ""'s:'.strlen('$2').':\""$2\"";'"", $meta['value'] ) ); add_post_meta( $post_id, $key, $value ); do_action( 'import_post_meta', $post_id, $key, $value ); // if the post has a featured image, take note of this in case of remap if ( '_thumbnail_id' == $key ) $this->featured_images[$post_id] = (int) $value; } }}}" WraithKenny 23270 Links are not updated when changing a multisite path Multisite 3.5 normal minor Awaiting Review enhancement new 2013-01-23T07:37:24Z 2013-01-25T04:28:14Z "When changing the path of a site under a network install, URIs are not updated in post_content. I know this can be achieved with search and replace plugins (and that this is how regular WP installs work), but the wording on the edit site page makes it appear as if WP should be updating this for you with; ""Update siteurl and home as well."", where the ""as well"" makes it sound as if other elements on your site will be updated regardless. I'm not sure if the best approach would just be a re-wording of this area, or if implementing a function to update post_content when this is modified is the way to go." Clorith 23269 .maintenance location issue on symlinked install Upgrade/Install 3.5 normal normal Awaiting Review enhancement new 2013-01-22T21:57:11Z 2013-01-22T21:57:11Z "I've started to symlink some of our WordPress installs using a folder structure as follows: .htaccess index.php wp -> /var/www/wordpress/WordPress-latest wp-config.php wp-content The wp folder is a symlink to either the latest version of WordPress, trunk or a specific version and the WordPress core files are all read only by the web server (WordPress core file installs are taken care of by Chef) I thought creating a .maintenance file in the root or the wp-content folder would trigger maintenance mode but it looks like the .maintenance file is only detected if it lives in the same folder as the WordPress core files ($wp_filesystem->abspath()) which is read only so it's never going to be created there. Having a shared core codebase even if I did override the write only permissions and set a .maintenance file in the WordPress directory that would mean every single site using that codebase would go into maintenance mode. (which sometimes might be useful since wordpress-latest might need updating) What about having WordPress look for the .maintenance file in the directory above similar to what we can do with the wp-config.php file? This would then mean with a symlinked install and shared codebase you could trigger .maintenance mode for a single install or all installs using the codebase. Or relocating the .maintenance file into the wp-content folder. This is after all where most web servers usually have write permission and where created files are meant to go." WPsites 23263 Move Media's backbone template regexes Template 3.5 normal normal Future Release enhancement new has-patch 2013-01-22T08:09:54Z 2013-05-16T12:13:49Z "Media has custom Backbone templating (because PHP is stupid and sometimes parses `<% %>` as PHP code — I know, I know). That templating should be available elsewhere instead of being specific to media. {{{ template: _.memoize( function( id ) { var compiled, options = { evaluate: /<#([\s\S]+?)#>/g, interpolate: /\{\{\{([\s\S]+?)\}\}\}/g, escape: /\{\{([^\}]+?)\}\}(?!\})/g, variable: 'data' }; return function( data ) { compiled = compiled || _.template( $( '#tmpl-' + id ).html(), null, options ); return compiled( data ); }; }) }}}" markjaquith 23261 Add include to orderby options for get_terms() Taxonomy normal normal Awaiting Review enhancement new has-patch 2013-01-22T05:10:43Z 2013-01-22T05:10:43Z "In light of WordPress 3.5 allowing WP_Query to orderby `post__in` (#21776, #13729), it would be awesome to have the same functionality for `get_terms()` and the `include` argument. Likewise (#13729), term queries can specify the posts to retrieve by passing an array of term IDs to the `include` parameter. There is no built in method for sorting those posts by the order specified. " wpsmith 23260 Enhancement for paginate_links(); to include in wordpress core Template 3.5 normal normal Awaiting Review enhancement new 2013-01-22T04:24:12Z 2013-01-24T00:45:02Z "Hello all, I asked a question over at theme-reviewers [1] and one of the answers (and a helpful one) was that any improvement/s that I find could be push back into the core. The first thing that I would like to see is a ""Page x of x"" and make it a link to that people can click on it and enter the page munber that they want to go to then they can go stright to that page. Now I did find some code to do it but for some reasons I don't feel that it the right way of doing it[2]. The next thing that I'm looking at is if we can have it so that we can set our own style class or even replace tags altogether. Right now the only way that I can do this (as far as I know) is by editing core code or copy and paste code from care into my function.php file and rename things. I see that with the sidebar callback, I can set before and after tags for title and other things and that to the theme author gives us alot of control over layout and how we can style things. The reasons why the above improvements should be included in core: A: No need to create custom functions [[BR]] B: Don't need to install extra plugin just to get the ""Page x of x"" function or to create a hacked paginate_links function. [[BR]] C: It gives theme developers more control over style without alot of extra coding and if they don't want something they can disable it (example ""Page x of x"") [[BR]] D: It means that if wordpress devs change the paginate_links function theme authors don't need to update their custom functions [see A] Regards, Daniel Fenn [1] http://lists.wordpress.org/pipermail/theme-reviewers/2013-January/011488.html [[BR]] [2] http://design.sparklette.net/teaches/how-to-add-wordpress-pagination-without-a-plugin/" Danielx64 23257 Add plural versions of Post Format strings General 3.5 normal normal Awaiting Review enhancement new has-patch 2013-01-22T00:59:30Z 2013-02-04T08:45:32Z "To make it easier for theme authors to create meaningful titles for post format archive pages, we could extend `get_post_format_strings()` to also provide a standardized set of plurals. I'm not entirely sure whether the plurals I used in the diff are the ones we actually want to go with (apparently there is no plural of 'Audio'?), but the change is fairly simple and is backwards compatible. See [https://github.com/Automattic/_s/pull/137 this discussion] for additional context." obenland 23256 Mitigate Plugins SVN Exponential Storage Growth WordPress.org site normal major WordPress.org defect (bug) new 2013-01-21T23:41:56Z 2013-02-03T21:02:40Z "We all know Subversion is terribly inefficient with storage compared to most modern version control systems, however I've noticed a pretty serious problem that goes way beyond this in the plugins SVN repo. Please forgive me if some details are slightly off as obviously anything running WP.org infrastructure is mostly a black box that no-one outside of Automattic or Audrey has any insight into (and I'm lucky to have found this problem in the first place). If you take a look at the attached graph, you can see that the plugins repository is growing exponentially by disk usage regardless of what rate commits are coming in (but that has always been growing too, making this worse). I am assuming the repository is using FSFS, though this is actually still a problem if it were using BDB. All SVN repositories suffer from this weakness if used the same way the plugins SVN repo is being used. The problem is that every SVN commit stores off node IDs of every sibling node of every parent node of all nodes that have changed in that revision. This means that a single commit to `/myplugin/trunk/readme.txt` contains references to all files and directories (and their related revision) in the `/myplugin/trunk` directory, the references to the `branches`, `tags`, and `trunk` nodes in `/myplugin`, and finally references to every directory in the root node (`/`) which means every single plugin in the repository. Since the root node is related to any changed node in every single commit, and the list of plugins is constantly growing, this means that even though the repository is somewhere around 450GB right now, the actual data in the repo, including the full history, is only about 30GB. You can confirm with a simple dump of the repository. The other 420GB or so is entirely wasted space by SVN overhead. If nothing is done in the next two years, the SVN repository is expected to double in size to about 900GB, and it’s performance will quickly degrade as the server takes longer to read revisions and the filesystem cache can no longer be used (which I suspect is already the case now). Another four years, and we could be looking at a 2TB Subversion repository with every single commit being required to write about 8MB to disk even if it's a one line change. I know that any solution to this is going to take years to fully implement mostly because I believe this is going to require plugin SVN URLs to change during a migration at some point most likely. However, at the least, we should be heading up this problem by getting new plugin submissions started in their own repository rather than creating new directories for them in the current plugins SVN repo. This would at least stop the exponential growth of the plugins repository, extending it's lifespan significantly." bpetty 23253 Lack of a do_settings_section (singular) function Plugins normal normal Awaiting Review enhancement new 2013-01-21T19:20:06Z 2013-01-21T19:20:06Z "After considerable research I have found that plugin authors, including myself, have to go to great lengths to put options into tabs on a plugin settings page. The majority use JavaScript to modify the DOM in order to achieve this, others have broken their options into several settings arrays instead of the recommended single array to facilitate the creation of tabs using the traditional WordPress nav-tab-wrapper class approach. To get my own options into tabs in a fully scoped css jquery ui theme I ended up adding my own hacky function to my plugin: myplugin_do_settings_section( $page, $sectionid ) - which is just a copy of the core function do_settings_sections( $page ) with an additional parameter for the section id and an added conditional to only output the section with the requested id. This allows me to wrap each section in the appropriately classed tags for either jquery ui tabs or traditional WordPress nav-tabs. This however, is not an acceptable long-term solution as the core code will undoubtedly change, I already see tickets and revisions relating to the removal of those nasty tables... This functionality should be in the core code. A settings section is a ''section'' and it should be possible to output them one at a time to allow for styling. Thanks for considering my proposal. (Also, the Iris color picker does not play nice with jquery-ui - it needs its own css scope or something - that will be a separate ticket once I have a better understanding of what is wrong with it and have searched for existing tickets on the subject.) " auniquename 23247 Grammar Fix on setup when wp-config-sample.php does not exist Text Changes normal trivial Future Release enhancement new commit 2013-01-20T22:45:50Z 2013-05-14T13:26:47Z "Patch changes Sorry, I need a wp-config-sample.php file to work from. Please re-upload this file from your WordPress installation. to Sorry, I need a wp-config-sample.php file to work from. Please re-upload this file to your WordPress installation. Makes it a little more clear. Perhaps in the future, we can remove the need for wp-config-sample.php all together." bradparbs 23243 "wp_mail() not working with ""Name "" format in buggy PHP versions on Windows" Mail 3.5 normal minor Awaiting Review defect (bug) new 2013-01-20T15:59:30Z 2013-01-31T16:53:36Z "As a result of ticket #17305, wp_mail() accepts the $to parameter in the format ""Name "". There exists a PHP bug in versions below 5.2.11 and in 5.3, on Windows. This bug occurs when addresses are passed to the PHP mail() function in the ""Name "" format and prevents e-mails from being sent. I believe this bug in fixed in 5.3.1 and above. (see https://bugs.php.net/bug.php?id=28038) I don't believe this affects any core functionality, but may affect some plugins which pass $to in the above format. I tested in PHP 5.2.4 on Windows with the following code: {{{ wp_mail(""email@ext.com"", ""Test"", ""Test""); wp_mail(""Name "", ""Test 2"", ""Test 2""); }}} The first email is received; the second isn't. When removing error suppression from the mail() calls in class-phpmailer.php, the following warning is outputted: Warning: mail() [function.mail]: SMTP server response: 501 >: ""@"" or ""."" expected after ""Name"" in C:\xampplite\htdocs\wp-includes\class-phpmailer.php on line 771" bbosh 23237 Add tag function to format markup General normal normal Awaiting Review enhancement new 2013-01-19T06:46:55Z 2013-05-16T04:32:30Z "Related to #23236 I'd like to add a generic function for making html tags: {{{ wp_tag( $tagname, $attrs, $inner_html ) // returns an html tag wp_tag_e( $tagname, $attrs, $inner_html ) // echoes an html tag }}} $attrs could be an array|string, and the tag should only close if $inner_html is defined, like tag() in [http://phat.airve.com phat]." ryanve 23236 Add functions to format attributes Formatting normal normal Awaiting Review feature request new 2013-01-19T06:32:57Z 2013-05-16T04:15:04Z "I'd like to see WP add functions for attributes. These would be extremely useful and resuable for theme devs and internally. I've developed very solid generic functions for this in [http://phat.airve.com phat] and would be happy to make WP versions to the effect of: {{{ wp_attrs( $array ) // converts array to attributes string wp_attrs( $name, $value ) // formats attribute string wp_attrs( $string ) // reformats attribute string wp_parse_attrs( $string ) parses attributes into assoc array }}}" ryanve 23233 Radio Button instead of Checkboxes on Comment Moderation option? Administration 3.5 normal trivial Awaiting Review enhancement new close 2013-01-18T16:26:23Z 2013-01-19T03:13:00Z "Hi! I've been a loyal Wordpress user for years. This is nothing urgent, but something that may improve the user experience. In Settings > Discussion > Before a comment appears, there are two options: ""An administrator must always approve the comment "" and ""Comment author must have a previously approved comment"" Perhaps I have missed something here, but aren't these options pretty much either/or? If the first box is checked, it's rather irrelevant if the second box is checked, because the first checkbox would override it? If I'm correct, shouldn't this be changed from a both/and checkbox to an either/or radio button?" danielmount 23231 preprocess_comment should get the normalised comment data Comments 3.5 low minor Awaiting Review defect (bug) new 2013-01-18T11:38:02Z 2013-01-18T11:39:30Z "In '''wp_new_comment''' we normalise some data like user_ID/user_id so that we support people providing both versions but we fire the filter to preprocess the comment first. This means if someone writes a filter they have to re-implement this normalisation if they want to filter the comment data properly. An example of where this currently goes wrong is when Akismet tries to fetch the roles of the user submitting the comment - http://plugins.trac.wordpress.org/browser/akismet/tags/2.5.7/akismet.php#L332 This only works if the comment comes via a route that supplies the data correctly and not one that doesn't." westi 23230 "Change hyphen in front of ""Draft"" to em dash" Administration 3.5 normal normal Awaiting Review enhancement new 2013-01-18T09:08:47Z 2013-01-25T20:08:00Z "When a post/page/etc. is saved as a draft there is a ""- Draft"" appended after the title in the overview list in the dashboard. Rather than using an hyphen (-) it should be an em dash (—) and ideally it should be translatable as the typographic rules for dashes varies with languages. Rather than ""- Draft"" it should say ""— Draft""" kkalvaa 23229 Pagination Links Broken Permalinks normal normal Awaiting Review defect (bug) new has-patch 2013-01-17T23:11:04Z 2013-01-19T04:47:55Z "Currently, if the request URL ends with ""page/[\d]+/?"" it will always assume that it is the pretty version of the paged parameter, and rewrite that section of the URL. This breaks in any condition where a numeric value follows that string at the end of a URL. An example that can be easily reproduced is as follows: 1) Set theme to TwentyEleven 2) Modify the theme to output the results of get_pagenum_link(2) anywhere. 3) Change permalink structure to ""/daily-page/%year%/%monthnum%/%post_id%/"" 4) Go to a year archive for the permalink structure above. 5) The result of the get_pagenum_link will look like this: ""/daily-/page/2/"", breaking pagination within this context. I've attached a patch against current trunk code that addresses this, providing the following features: 1) Pagination links functional in the scenario above, along with custom rewrite rules. 2) Updated to allow numeric post names for hierarchical post types (currently always rewritten with ""-2"") 3) Updated get_pagenum_link filter to include pagenum parameter as it was passed in. " ssmathias 23228 get_users() cannot include AND exclude Users 3.5 normal normal Awaiting Review defect (bug) new reporter-feedback 2013-01-17T22:45:51Z 2013-01-19T03:56:22Z "The codex describes the parameters for get_users() as an array of options, so it seems like you can set an array of includes and an array of excludes. But the code looks like it can only do one or the other. It would be a simple fix. Lines 521-527 in wp-includes/user.php {{{ if ( !empty( $qv['include'] ) ) { $ids = implode( ',', wp_parse_id_list( $qv['include'] ) ); $this->query_where .= "" AND $wpdb->users.ID IN ($ids)""; } elseif ( !empty($qv['exclude']) ) { $ids = implode( ',', wp_parse_id_list( $qv['exclude'] ) ); $this->query_where .= "" AND $wpdb->users.ID NOT IN ($ids)""; } }}} To fix, change the elseif to its own if: {{{ if ( !empty( $qv['include'] ) ) { $ids = implode( ',', wp_parse_id_list( $qv['include'] ) ); $this->query_where .= "" AND $wpdb->users.ID IN ($ids)""; } if ( !empty($qv['exclude']) ) { $ids = implode( ',', wp_parse_id_list( $qv['exclude'] ) ); $this->query_where .= "" AND $wpdb->users.ID NOT IN ($ids)""; } }}} Thanks for the consideration." dlim_vernier 23227 Properly reflect date and time formats throughout admin area Date/Time 3.5 normal trivial Awaiting Review defect (bug) new dev-feedback 2013-01-17T19:37:21Z 2013-01-18T14:13:53Z "I have noticed several places in the admin area where the time & date formats set on the General Settings screen are not reflected. For example, on Page Edit, revisions have a hardcoded date format of `'j F, Y @ G:i'` and ajax autosaves use `'g:i:s a'` to show the ""Draft Saved at"" time (of note is the 24 hour vs 12 hour time). The ""Last Edited By _ on _"" time ''does'' properly use the time & date format options. I have included a patch for the two examples above (comments/critiques welcomed), but there were a few others I noticed that may be somewhat more involved to fix. These include: - Dates shown in the ""Date"" column of list tables (both the displayed and title text) - ""Published on:"" date/time for pages (this may be tricky since editing the published time uses a 24-hour time format) - ""Uploaded on:"" date/time shown in 'Save' metabox on Media edit screen And there are probably other places I have missed as well. Obviously somewhat low priority compared to other issues (and may be enhancement rather than defect), but I figured I'd bring it here and see what others thought." bananastalktome 23225 Customizer is Incompatible with jQuery UI Tabs. Appearance 3.4 normal normal Awaiting Review defect (bug) new 2013-01-17T09:34:21Z 2013-05-10T03:39:09Z "Steps to reproduce: 1. Install the attached mfields-test-jquery-ui-tabs.php plugin. 2. Open the Chrome console. 3. Open the customizer and watch the console. At this point you should see that a slew of XHR requests are triggered. If you reach a certain type of javascript error then the XHR requests will stop and the preview frame in the customizer will go blank. It seems like jQuery UI Tabs and the customizer are currently incompatible. This will affect any theme or plugin that is using this library including the popular [http://wordpress.org/extend/plugins/genesis-tabs/ Genesis Tabs] plugin." mfields 23212 wp_signup.php always get 404 status header Multisite 3.5 normal normal Awaiting Review defect (bug) new reporter-feedback 2013-01-16T02:04:14Z 2013-01-16T04:20:54Z "I get 404 in status header for wp_signup.php in few server, I think it was caused by class WP->handle_404(); " apineraka 23207 Add $labels argument to register_post_status() Post Types 3.0 normal normal Awaiting Review enhancement new 2013-01-15T19:32:54Z 2013-03-08T22:59:14Z "WordPress functions '''register_taxonomy()''' and '''register_post_type()''' has '''labels''' argument. Why not add labels to '''register_post_status()'''? The current way to add status: {{{ $args = array( 'label' => __( 'draft', 'text_domain' ), 'label_count' => _n_noop( 'Draft (%s)', 'Drafts (%s)', 'text_domain' ), 'public' => false, 'show_in_admin_all_list' => true, 'show_in_admin_status_list' => true, 'exclude_from_search' => true, ); register_post_status( 'draft', $args ); }}} The new way (using labels): {{{ $labels = array( 'name' => __( 'Draft', 'text_domain' ), 'singular_count' => __( 'Draft (%s)', 'text_domain' ), 'plural_count' => __( 'Drafts (%s)', 'text_domain' ), 'any_other_label' => __( 'Any Other Label', 'text_domain' ) ); $args = array( 'labels' => $labels, 'public' => false, 'show_in_admin_all_list' => true, 'show_in_admin_status_list' => true, 'exclude_from_search' => true, ); register_post_status( 'draft', $args ); }}}" ramiy 23203 Scheduling Posts assumes GMT but UI uses local timezone (creating undesired scheduled posts) Date/Time 3.5 normal normal Awaiting Review defect (bug) new dev-feedback 2013-01-15T15:32:09Z 2013-01-16T13:16:59Z "I experienced an odd behavior when going to edit a page on a newly created site in a multisite environment. The site uses the New York timezone (GMT-5). When quick-editing the page, I changed the title and slug, but pressing ""Update"" set the page as ""Scheduled"" rather than leaving it ""Published"". This was very confusing, and took a while to figure out and then explain to the end user. It seems that although the date/time is shown in the UI in the current time zone, once submitted the form interprets the time as if it were in GMT. To the end user, it looks like the page should be published since the time shows what we thought was a 5 minutes ago. In reality, the time in the date field is not recognized as 5 minute ago but 4 hours and 55 minutes in the future. This is a problem in the full edit form for pages in this newly created site as well. When I go to edit the published time/date, the posted time in my timezone is shown. However, ''even if I hit 'Cancel' the ""Update"" button changes to ""Schedule""''." bananastalktome 23202 Enable is_page_template() within the Loop Template normal normal Awaiting Review defect (bug) new dev-feedback 2013-01-15T14:21:48Z 2013-01-15T17:28:07Z "There have been a few times where, in the loop, I need to know if I were on a page using a specific page template. The function `in_the_loop()` provides this functionality for us to expand is_page_template()." wpsmith 23196 mkdir not recursive (in wp-includes/functions.php) Filesystem normal normal Awaiting Review defect (bug) new 2013-01-14T08:35:51Z 2013-01-14T10:25:01Z "This January, Wordpress tried to create a directory and a subdirectory in ""uploads"": ""2013"" and inside it ""01"". `mkdir($target)` was used to create these two directories, but since the $recursive option (3rd argument) was not set, this operation failed. I have just checked this path and it does exist, hence I suspect this procedure is being done somewhere else (and succeeding). Still, this is a problem since: 1. It is showing up in our error logging system. 2. It is very easy to fix. 3. It potentially fixes more problems than it seems. The solution is to change this line: 1306: if ( @mkdir( $target ) ) { To the following: 1306: if ( @mkdir( $target, 0777, true ) ) { On a sidenote, PHP's default directory creation mode is 0777 (so the above code is best for compatibility), but as you may know, it is not good in terms of security, so you may want to look for a more secure fix (eg, lowering the mode if it doesn't cause problems)." uuf6429 23188 Hardcoded relative url 'async-upload.php' in plupload/handlers.js Upload 3.5 normal normal Awaiting Review defect (bug) new 2013-01-12T11:47:48Z 2013-01-14T08:19:23Z "On line 127 in plupload/handlers.js you can find relative path to 'async-upload.php'. It rather should use wpUploaderInit.url (or something like that), so you could use WP Plupload in front-end for example or with your custom uploading scripts. Now you can write your custom uploader script and provide it via wpUploaderInit, but on that line in handlers.js it is ignored (and if you run it in front-end, bad request to ./async-upload.php is made)." drozdz 23185 Hyphens surrounded by non-breaking spaces are not texturized Formatting 2.8 normal normal Awaiting Review defect (bug) new has-patch 2013-01-11T20:13:11Z 2013-01-14T01:45:52Z "Thanks to Ticket #8161, a single hyphen or double hyphen surounded by space is converted to an en-dash or em-dash, respectively. The problem is this conversion doesn't take place as expected when the space immediately before or after the affected hypehns is a non-breaking space. Example paste the following into a post as HTML and view it in a browser after texturization: {{{ Line 1 - Non-breaking spaces around the hyphen. Line 2 - Regular spaces around the hyphen. Line 3 - Non-breaking space before the hyphen. Line 4 -- Non-breaking space after the double-hyphen. Line 5 -- Regular spaces around the double-hyphen. }}} Only the lines where ""Regular spaces"" are around the hyphens get converted as expected.Lines 1, 3, and 4 are not converted to match their regular-space counterparts. It's reasonable to use non-breaking spaces in web content and I think that for situations where a non-breaking space is used it should imply the same kind of texturization for the hyphens as a regular space does. The attached patch removes the static replacement rules for hyphens and adds dynamic rules to meet this expectation. I had to add a dynamic rule '--' to prevent it being prematurely converted in the static phase, when it was surrounded by appropriate spacing. Since I havd to move that one from static to dynamic, it made sense to me to just have all the hyphen-conversion behavior in one place in dynamic. " redsweater 23184 Twenty Eleven/Twelve: Mismatched lines in GitHub Gists Bundled Theme 3.5 lowest normal WordPress.org enhancement new close 2013-01-11T19:29:36Z 2013-04-26T14:26:57Z "GitHub Gists are displayed with the code and line numbers misaligned, due to the difference in font-size and/or line-height of `` and `` elements. Originally reported in [http://wordpress.org/support/topic/gists-look-crazy-with-twenty-twelve this thread] and on wp.com. Example: http://themebuster.wordpress.net/gist-test/" obenland 23183 Single Page Application/OData API General normal normal Awaiting Review enhancement new 2013-01-11T18:15:34Z 2013-01-11T22:45:13Z I am interested in helping out. Are there any plans to move to a Single Page Application model. I know this would take a lot of work as we would have to code a secure Web API into the core (I would go with standard OData service API) but as mobile devices become more critical to web success WordPress needs to find a way to minimize requests and allow for occasionally connected solutions. I know this would be for major release 4 or possibly even 5 depending on the impact to plugin developers but it make a noticeable difference on the scalability of wordpress. cportwood 23179 New avatar related option - use gravatar only for registered users Comments normal normal Awaiting Review enhancement new 2013-01-11T15:40:59Z 2013-01-21T04:42:39Z "The use of gravater is problematic because there is no attempt to verify that a comment with which an email was used was actually left by the owner of the email (AFAICT gravatar doesn't even have an API for authentication). This makes impersonating to someone else that have a gravatar in a wordpress site comments much too easy. IMO non autogenerated gravatars should be displayed by default only for users for which it is known that they actually own the email address, which are usually only the registered users." mark-k 23173 Don't cache arrays of query results in a single cache bucket Cache 3.5 normal normal Future Release task (blessed) new 2013-01-10T19:05:17Z 2013-04-16T17:10:11Z We have started using one cache bucket per query with passive invalidation controlled through a last_changed incrementor. See #22024 for an example. We also need to do this with get_pages(), wp_get_archives(), and elsewhere. On wordpress.com we have hacked some of these into separate buckets because saving multiple queries per cache bucket results in huge buckets. We have seen 72MB get_pages caches. Let's finally clean this up for good. Some of the last_changed work done for #22176 can be used here. ryan 23172 "Media Library - Rename the default ""Images"" in dropdown to something more clear" Media 3.5 normal normal Awaiting Review enhancement new has-patch 2013-01-10T17:05:32Z 2013-02-01T21:40:13Z "I have a group of about 6 people on my team and after the upgrade to 3.5 not one of them could figure out how to filter down to only the images attached to a post. I'm assuming that other people out there are having similar trouble.. The label ""Images"" makes it seem like that is where you could switch to other media types like ""Audio"" instead of filtering search results. I think ""All Images"" would be much more clear as to what the dropdown changes.." jacopo.vip 23171 Add Meetup.com oEmbed support Embeds 3.5 normal normal Awaiting Review enhancement new has-patch 2013-01-10T12:21:01Z 2013-04-25T23:19:37Z "Given the number of meetups people are doing around the world I think it would be nice to add Meetup.com to the list of oEmbed providers. http://www.meetup.com/meetup_api/docs/oembed/ Currently there is a ''minor issue'' with their oEmbed API as it fails when the Meetup group has a custom domain for the group. I've had to do some ''dodgy'' code for our Aussie custom domains to get around that: https://github.com/BronsonQuick/wpaustralia/blob/master/plugins/wpoz-meetups/wpoz_meetups.php Seeing their is a new agreement between http://make.wordpress.org/events/ and Meetup.com hopefully one of the Automatticians can let Meetup.com know that their API needs a patch for custom domains ;)" sennza 23169 Introduce register_post_status_for_object_type General normal normal Future Release enhancement new 2013-01-10T08:35:46Z 2013-05-10T12:37:39Z Similar to what `register_taxonomy_for_object_type` does with taxonomies. kovshenin 23168 Introduce remove_post_status General normal normal Future Release enhancement new 2013-01-10T08:32:49Z 2013-05-10T12:37:37Z Plugins and themes should be able to remove the default post statuses defined by core. kovshenin 23165 Admin validation errors on form nonce element IDs (_wpnonce) Validation normal normal Awaiting Review enhancement new has-patch 2013-01-10T02:25:17Z 2013-04-03T03:21:53Z "The `wp_nonce_field()` method has a design flaw in that the `name` parameter is optional, but its default value (""_wpnonce"") is used for the field element `id`. This wouldn't be bad if only one form is used on each page, but that is rarely the case in the admin panel. Currently, this only results in harmless HTML validation errors in admin, and in very rare situations (depending on plugins installed), can result in javascript scope-related issues breaking forms. This is an issue that keeps being reported and fixed several times (see #5962, #6564, r14737 from #13383, and the latest [http://core.trac.wordpress.org/ticket/22712#comment:11 #22712]) by simply specifying the name in all locations that don't at the time in core. There's at least three different approaches that I can see where we could prevent this from popping back up in the future and encourage better coding habits. == A: Require the Name Parameter == The most obvious approach is to simply adds a `_doing_it_wrong()` call (though it could just be `_deprecated_argument()` instead) for any calls to `wp_nonce_field()` that don't specify the `name` parameter, forcing everyone to give nonce fields unique IDs (and names). A side-effect of this change is that it will also warn developers they are doing it wrong if they use `wp_nonce_field()` without the (also currently optional) `action` parameter, which is actually a good thing since the docs already warn that this is a security hole. There are 46 locations in core that would need updated with this change that make this mistake, and the fix for each of them with this change is exactly the same as what every other commit to fix this problem has always done: just specify the `name` to give a unique ID. The downside to this approach is that this pushes for an immediate change not only to all calls to `wp_nonce_field()`, but also their corresponding `check_admin_referer()` calls (to update the changed field name) in a single WP release, and considering how frequently it's called this way in core, I don't even have to look at plugins to see how often it happens there (it's going to be too many to count). This approach still results in an explicitly named ID that really doesn't need to be on the field in the first place in most locations. I gave this approach a shot anyway, and started on a patch just to see how much work it would be at least in core, but I started to find a few locations that could benefit from unique IDs, but similar field names. I also found myself already spending hours updating and testing just 9 of the 46 locations (unit tests don't cover this stuff) where I was forced to make changes to IDs that would be best left alone for now. I have attached this unfinished patch anyway if anyone is curious to see how it works, what it does, and to see what kinds of changes it ends up requiring. It's still possible to just pass ""_wpnonce"" as the `name` with this change, so the rest of the locations could simply use that to progressively work towards unique IDs, but I just don't see this as a good solution overall, and it seems like a lot of work for very little gain on a minor issue. == B: Use Action for ID or Remove ID Entirely == Another option might be to remove ID entirely, or use (and require) the action parameter as the ID. This would improve results with unique IDs fixing most locations where `wp_nonce_field()` is used without requiring a change to each one individually for most uses (except for nonces used with ajax calls). All locations in core at least use `action` already, so the case for using `action` as ID instead seems better than using `name`. Unfortunately, either removing or using the action parameter for ID (changing the ID) would obviously break a few plugins that made the mistake of relying on the default `_wpnonce` (or the current `name` value) value for `id` from within JavaScript code for existing form endpoints. In the WP.org plugin repo, this appears to happen in the following plugins (searching up through plugins starting with 'r') for forms using the default value: {{{ automatic-youtube-video-posts buddypress buddypress-backwards-compatibility canalblog-importer community-submitted-news eyes-only-plus facepress-ii globalfeed lazyest-gallery lazyest-maps maven-member pagely-reseller-management pluginbuddy-yourls post-event2 qtranslate-separate-comments repostus ... }}} There's likely way more plugins that post to core forms using a non-default `name` that would break though as well, and even though I think ID should have never been added to the nonce field attributes and was never necessary in the first place, compatibility rules would need to be broken if this approach was used. This of course means this option is most likely not really an option at all. == C: Use an Option Array Parameter in Place of Name == To keep this concise, this last approach basically involves changing `wp_nonce_field()` to: {{{ function wp_nonce_field( $options = array() ) { ... } }}} The `options` parameter is a standard arguments array used with `wp_parse_args()`. This accomplishes not just one, but two different goals. First, if `$options` is not an array or the method was called with anything other than 1 parameter, we know this is an older call that needs to use the `name` parameter for both `name` and `id`, using `func_get_args()` for the original arguments, and can do so for full 100% backwards compatibility. Second, unrelated to this issue, the function has been refactored to adhere to coding standards in regards to [http://codex.wordpress.org/WordPress_Coding_Standards#Self-Explanatory_Flag_Values_for_Function_Arguments self-explanatory flag values] as far as the `referrer` and `echo` options are concerned. The `options` array can then be made to accept the following settings: - action: The same unique name included in the nonce hash as is the case now. - name: The field name (and *only* used for the name attribute). (Default: ""_wpnonce"") - id: The field ID if this really is still desired, and can even be different than the name, but by default, the field won't have an ID at all. - referrer: Whether to set the referer field for validation. (Default: true) - echo: Whether to display or return hidden form field. (Default: true) The only downside here is that each `wp_nonce_field()` call will be more verbose in most cases, especially if they do need to use an ID. For example, this: {{{ wp_nonce_field('add-tag', '_wpnonce_add-tag'); }}} Will now become this: {{{ wp_nonce_field( array( 'action' => 'add-tag', 'name' => '_wpnonce_add-tag' ) ); }}} I see plenty of benefits to this last solution though, and it requires very few changes up front, so I think it comes down to this approach ultimately. Please see attached patch." bpetty 23163 3.6 Network Admin Help Text Help/About low normal Future Release enhancement new has-patch 2013-01-09T23:35:35Z 2013-03-09T03:19:18Z "One of the [http://make.wordpress.org/docs Doc team's] action items for 3.6 is to work on overhauling the Network Admin help tabs, many of which contain outdated and, well, unhelpful information. Our goals: * Focus on writing action vs description-based help text * Aim for a consistent voice * Pave the way for future Help UI changes in how we structure the information Any Network Admin screen is fair game but by no means do we intend to change strings just for the sake of change. It was the consensus of the team to focus on this effort earlier in the release cycle than usual so that translators will have plenty of time to work on new strings and provide feedback. Following some [https://twitter.com/DrewAPicture/status/295248525699190785 feedback] from @nacin, @markjaquith, and @aaroncampbell, it was decided the best format for concatenating help tabs strings should follow this format going forward: {{{ $example_string = '' . __( 'This is some help text' ) . ''; $example_string .= '' . __( 'This is some more help text' ) . ''; get_current_screen()->add_help_tab( array( 'id' => 'example', 'title' => __( 'Example' ), 'content' => $example_string ) ); }}}" DrewAPicture 23162 Allow to call parent_dropdown() for an arbitrary post Administration normal normal Awaiting Review enhancement new 2013-01-09T22:48:08Z 2013-01-09T23:24:26Z "parent_dropdown() can no longer be used outside of the loop, such as within the wp-admin, because an E_NOTICE will be emitted in template.php:683 since $post is null. A simple fix is to change the function argument declarations from {{{ function parent_dropdown( $default = 0, $parent = 0, $level = 0 ) { }}} to: {{{ function parent_dropdown( $default = 0, $parent = 0, $level = 0, $post = array() ) { }}} and then also change: {{{ $post = get_post(); }}} to {{{ if ( empty( $post )) { $post = get_post(); } }}} which would allow a WP post object to be passed into the function. Sorry I am unable to provide an SVN patch. " charliespider 23160 Better 404 page for WordPress.org WordPress.org site normal minor WordPress.org enhancement new 2013-01-09T20:10:23Z 2013-01-09T20:13:01Z "Right now, if you get a 404 on wp.org, there isn't really much. example: [http://wordpress.org/howabouta404] I'd suggest at the minimum changing the wording away from 'no posts' to 'no pages', and potentially adding links to commonly accessed areas, such as 'Were you looking for a plugin, theme, blah blah?' In the side bar, there is also a 'Categories' section, that always displays 'No categories', maybe remove that as well?" bradparbs 23159 Add Words Counter In The Excerpt Metabox Editor 3.5 normal normal Awaiting Review enhancement new 2013-01-09T19:46:57Z 2013-01-11T17:26:24Z "Hi WordPress Lovers :) , WordPress 3.6 fouces on ""Content Editing"" a small good idea is to add a words counter in the bottom of excerpt meta-box , and a small tip of the current theme max words count .." alex-ye 23150 Sanitize the class passed to wp_list_bookmarks() and allow passing an array Template 3.5 normal normal Awaiting Review defect (bug) new has-patch 2013-01-08T20:50:58Z 2013-01-08T23:10:22Z "The class argument to wp_list_bookmarks() could use some sanitization. While at it, let's enhance it to accept an array of classes like we do elsewhere." ryan 23149 YouTube Embedding is incorrect for https:// URLs Embeds 3.5 normal normal Awaiting Review enhancement new 2013-01-08T19:46:28Z 2013-04-07T01:52:09Z "Reference: #18719, #20102, Conversation from 9-19-2012: https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2012-09-19&sort=asc#m459455 This is incorrect and a bug. If the user has posted an https link, then we should send the correct parameters to YouTube to get an https value in the resulting HTML returned. At present, there is no way within WordPress to get the proper https code in a YouTube oEmbed iframe when https is actually desired. " Otto42 23144 Non writeable uploads folder may result in URLs to existing attachments fallbacking to use GUID Media 2.7 normal minor Awaiting Review defect (bug) new 2013-01-08T16:19:44Z 2013-01-08T23:22:10Z "When using wp_get_attachment_url() the returned url may fall back to using the value stored in the GUID field, if the uploads folder is not writeable. I think this only happens if the uploads folder for the current year + month does not exists. Reason for this is in wp_upload_dir(): it returns everything ok, including an error like ""Unable to create directory wp-content/uploads/2013/01. Is its parent directory writable by the server?"" which makes the wp_get_attachment_url() function think something is wrong and therefor uses GUID instead, since it does a check for just FALSE and not the type of error. In my example I am getting an attachment/file that exists in the folder ""uploads/2012/12"", so the month/folder 01 is not necessary at all. I don't see the need for falling back to GUID because of a non-writeable uploads folder since this should only be considered wrong when adding files, not when reading existing files. All other information for getting the file is correct. Also, perhaps you can spare some MS if you skip the does-folder-exist-for-current-month checks when just getting file info. " eskapism 23142 "Make it possible to ""stem"" an arbitrary prefix with the Template Hierarchy's ""stemming"" logic." Template 3.5 normal normal Awaiting Review feature request new 2013-01-08T13:04:03Z 2013-01-09T00:23:21Z "Please expose the template hierarchy ""stemming"" logic for theme developers. By ""stemming"" I mean the process by which the list of candidate template filenames (e.g. page-meaningoflife.php, page-42.php, page.php) is generated. I '''know''' that the way template-loader.php is currently written, such list is never explicitly assembled. I consider this a deficiency. The ""stemming"" logic should be available as an API: {{{ function wp_template_candidates($prefix="""") { $filenames = array(); // Extensively refactored code from template-loader.php and template.php return $filenames; } }}} The new template-loader.php could then probably be just reduced almost to this: {{{ locate_template(wp_template_candidates(),true); }}} But the real motivation is to be able to use a single layout template that includes different versions of ""parts"" like menu or sidebars depending on the query type and queried object, exactly as the template hierarchy does. This can of course be done with ad-hoc checks: {{{ if (is_home()) { locate_template(""home/sidebar.php"", true); } }}} but making this consistent with how template hierarchy works would involve basically reimplementing much of it. The proposed API would make it possible to override parts of a template for specific query types or queried objects just by creating an appropriately located and named file, and without modifying the main layout file: {{{ /* * File: MyTheme/includes/body-layout.php */ }}}" rulatir 23141 "Add autocomplete=""off"" to all inputs that have a value" Administration 3.5 normal normal Awaiting Review defect (bug) new 2013-01-08T12:49:51Z 2013-01-08T19:44:44Z "On '''refresh''' in the browser - old data is filled in the inputs, instead of the actual data from the value attribute of the input. to be more clear : http://www.screenr.com/p2K7" alexvorn2 23135 Filter for Block Elements in wpautop() Formatting 3.5 normal normal Awaiting Review enhancement new dev-feedback 2013-01-07T16:21:44Z 2013-01-08T12:55:40Z "This addresses the need to exclude certain block elements (iframe, img) from wpautop. Using the newly defined filter '''wpautop_block_elements''' every plugin dev, theme dev etc. can redefine, modify and enhance the list of block elements. Exsample for functions.php {{{ #!php function add_block_elements($block_elements){ $block_elements[] = ""iframe""; $block_elements[] = ""img""; return $block_elements; } add_filter(""wpautop_block_elements"", add_block_elements); }}} Thanks for reviewing! :) Regards, Hendrik" luehrsen 23133 Display a warning in the admin if cron tasks fail due to blocked HTTP requests Cron 3.5 normal major Awaiting Review enhancement new dev-feedback 2013-01-07T08:33:05Z 2013-01-29T20:08:25Z "I recently upgraded my very simple WP site to 3.5 where the following was in use: Theme: Twenty Eleven Plugins: None Activated I have been completely unable to submit a post for publishing in a future date, when the time occurs, I get a ""missed schedule"" message. The schedule entry in cron is as follows: Next due (GMT/UTC): Jan 4, 2013 @ 11:28 (1357298880) Schedule: One-off event Hook: publish_future_post Arguments: [0]: 358 Increasing the timeout value in cron.php has made no difference. I will need to remain on a lower release until this is fixed or a diagnosis ""kit"" is made available. I am not using any software other that WP produced at this point and feel that the lack of wp-cron documentation and support in the public domain leaves alot of people clocking many hours googling in desperation... Make a difference in 2013 and get 3.5 development priorities to de-mystify the methods of fixing wp-cron please :o)" prb22public@… 23127 Media Upload hangs on Crunching on too big image sizes. Media 3.5 normal normal Awaiting Review defect (bug) new 2013-01-05T22:56:14Z 2013-02-02T03:29:32Z "If the uploaded file is too big for the Max Memory Limit Setting, then the upload is executed, but the image isn't resized to the set image sizes and the frontend gets stuck on ""Crunching"". I tracked the error down into the core and found out, that the main problem is in the GD library class ( wp-includes/class-wp-image-editor-gd.php ) in the load() function. Everything works fine before line 91: {{{ $this->image = @imagecreatefromstring( file_get_contents( $this->file ) ); }}} So imagecreatefromstring fails because of a lack of memory. But as a chain reaction everything else fails afterwards. The library is not loaded and sent back, and so on. As a result no id is sent back to the frontend and the Loader hangs. Maybe there should be any error catching and sending back before this GD function, that the frontend receives any error messages and that the upload is deleted in case of error. Just my thoughts: As this error is a Fatal one, you can`t use any Exception stuff, cause there will not be any memory left to execute it. Maybe some checking if the id is present before sending the image back to crunching?" clubdesign 23122 inline doc improvements in WP_Filesystem_Direct and WP_List_Table Inline Docs 3.5 normal trivial Future Release enhancement new has-patch 2013-01-04T17:49:42Z 2013-05-16T12:07:16Z A pass over `WP_Filesystem_Direct` and `WP_List_Table` classes to improve inline docs. Any suggestions/improvements/critiques are welcomed. bananastalktome 23120 There should be indication that widget settings have been saved Widgets 3.5 normal normal Future Release enhancement new has-patch 2013-01-04T16:28:05Z 2013-05-14T12:45:51Z "There's currently no confirmation that adding a widget or changes to a widget have been saved. In some cases(fast hosting and a solid internet connection) the changes are saved so quickly the spinner is barely on the screen at all. I think a best course of action would be to have the word ""Saved"" appear briefly after the spinner goes away. Or perhaps a check mark as that doesn't need to be translated. Related post on make.wordpress.org: http://make.wordpress.org/ui/2013/01/02/this-morning-i-ran-2-users-through-some/" jacopo.vip 23117 permalink failed on IIS7 and Reserved Proxy for wordpress 3.5 Permalinks 3.5 normal major Awaiting Review defect (bug) new 2013-01-04T06:30:33Z 2013-01-04T11:03:08Z "it seems to work fine on local but get into a canonical redirect loop when we deploy to production after we upgrade to wordpress 3.5. We did a little debug and found the issue with permalink in file .\wp-includes\canonical.php at line 42 with new coded ""&& !iis7_supports_permalinks()"" added in 3.5. the issue is iis7 does support permalink and so it go into create and redirect to pretty link which use the website URL in wp-admin settings which is the site URL. when it hits the site URL, our reserved proxy write back to the wordpress site on diff server with port and canonical.php think that's incorrect, so it redirect back to the website URL and the loop go on and on. we found a temp workaround but not desirable, add this ""remove_filter('template_redirect', 'redirect_canonical');"" in the function.php file in the theme folder you are using. or add a wordpress plugin or simply remove the additional codes in canonical.php file that was added in 3.5. but may cause issue in future upgrade." romeoqngo 23116 Media GalleryEdit Controller should have an option to hide gallery settings Media normal normal Awaiting Review enhancement new 2013-01-04T05:53:46Z 2013-01-04T05:53:46Z wp.media.controller.GalleryEdit (from /wp-includes/js/media-views.js, line ~557) should include an option to disable the gallery settings in the right sidebar. The settings might not always be desired (when editing a Gallery that doesn't go directly into a shortcode, for example). nd987 23115 Refactor wp.media.gallery.attachments to accept an array of attachment ids rather than shortcode Media normal normal Awaiting Review enhancement new 2013-01-04T05:22:32Z 2013-01-04T05:22:32Z "In /wp-includes/js/media-editor.js, line 175, the wp.media.gallery.attachments method is too closely coupled to the shortcode. This makes it impossible to fetch Attachments without first creating a shortcode to pass in. A better approach would be to accept an array of attachment ids or a hash of properties; more than just shortcodes need to fetch Attachments by their ids." nd987 23113 Automatic notice of new localized version missing Upgrade/Install 3.5 normal major WordPress.org defect (bug) new 2013-01-03T21:47:44Z 2013-02-02T08:19:13Z There was standard behaviour, that users could upgrade quickly to the latest WordPress version and when localized version was ready and released, notice about new localized version appeared in administration. But some users found that it was changed (in 3.5 or maybe 3.4) and when they upgrade to English version, they are not noticed about new Czech version in the future which is annoying. I tried it on some websites and it is true. I am not sure, if it is wanted change (but does not make sense for me) or bug (regression)? pavelevap 23110 Tiny MCE - when adding blockquote, entering twice no longer backs out of blockquote TinyMCE 3.5 normal normal Awaiting Review defect (bug) new 2013-01-03T16:48:00Z 2013-01-03T19:47:08Z When using the visual editor you used to press enter twice to back out of a blockquote and continue writing paragraphs, but now it just adds a nbsp; in the blockquote. Without going into the html view and actually adding content below, there's no way to get out of writing in the blockquote. jack.nycz 23108 Deprecate add_object_page() and add_utility_page() Administration normal normal Future Release enhancement new has-patch 2013-01-03T02:47:52Z 2013-05-16T11:55:27Z "`add_object_page()` and `add_utility_page()` are not used in core and are just wrappers which pass `$_wp_last_object_menu++` and `$_wp_last_utility_menu++`, respectively, to `add_menu_page()`. This can lead to a conflict with other menu items added by plugins, see #23095." SergeyBiryukov 23103 Non image caption shortcode lost when switching from text to visual editor and back Editor 3.4 normal normal Awaiting Review defect (bug) new 2013-01-02T16:40:25Z 2013-02-13T05:56:05Z "1. Add the line in text editor {{{ [caption caption=""test"" width=""300""]Checkuot this text[/caption] }}} 2. switch to visual editor 3. switch back to text and you get {{{ Checkuot this text test }}} " mark-k 23099 Add JSON-RPC support using existing XML-RPC methods XML-RPC 3.5 normal normal Future Release feature request new needs-unit-tests 2013-01-02T01:22:37Z 2013-04-22T21:18:54Z Many people have expressed interest in a JSON API for WordPress core. Until a full REST API can be implemented, the existing XML-RPC method implementations can be re-used by wrapping them in JSON-RPC serialization/de-serialization logic. maxcutler 23096 Provide callback before setting state of the editor media manager Media 3.5 normal normal Awaiting Review enhancement new dev-feedback 2012-12-31T18:33:52Z 2013-01-25T16:54:03Z "In the current setup, there is no way to modify the current state or views when the media manager is opened from the ""Add Media"" button. By the time you can modify anything, all the default views have been rendered and all of the events have been fired. It would be helpful to check for the existence of a callback, and if it exists, run that before returning the workflow. My patch does this, which you could invoke in this way: {{{ wp.media.editor.extend = function(workflow){ // Manipulate the workflow here } }}} Thoughts? This is only for the default media manager that is invoked by clicking the Add Media button." griffinjt 23092 "Word count, Edit Post > Publish > Visibility, Published Date & Status ""Edit"" links don't work" General 3.5 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-12-31T02:38:48Z 2012-12-31T23:03:22Z "hosting platform: Apache 2.2.23 PHP 5.4.10 FreeBSD 8.3 WordPress 3.5 (no modifications to codebase & themes, no plugins) - client: Mac OS X Firefox and Safari prior to upgrading to 3.5, Edit Post > Publish > Visibility, Published Date & Status ""Edit"" links worked as expected. I can make changes then hit Update. after upgrade to 3.5, these Edit links no longer work. Tons of load-styles.php errors. Word count is always set to 0 - Quick Edit works just fine. tw2113 (from #wordpress Freenode) suggested I enable script_debug in wp-config.php and that resolve the issues I was having. Word count now works also. As tw2113 have mentioned, I shouldn't need to have script_debug enabled just to get your post editor working. Any thoughts? Please advise, thank you!" scaturan 23091 Need to remove deprecated get_bloginfo('url') from _fix_attachment_links() function Administration 3.5 normal normal Awaiting Review enhancement new close 2012-12-31T01:57:33Z 2013-01-29T21:51:19Z "get_bloginfo('url'); is deprecated. Should be home_url();" hexalys 23088 Multisite, Subdomains and www Multisite 3.0 normal normal Awaiting Review defect (bug) new 2012-12-30T20:05:33Z 2013-04-28T16:21:25Z "I installed a WordPress Multisite network (in subdomain mode) on Zend's PHPCloud.com. Zend does not provide an IP address, recommending a CNAME instead. CNAME records are not allowed on the root of a domain, so they recommend using the www subdomain, with a redirect from the root domain to www. This site can NEVER be accessed on the naked domain; it will always be accessed via the www subdomain. So, I setup wildcard DNS for *.mydomain.com, then created a network on www.mydomain.com. Then, I went to a non-existant subdomain on my network, nonexistant.mydomain.com, and WordPress redirected to www.mydomain.com/wp-signup.php?new=nonexistantwwwmydomaincom. The correct behavior is to redirect to www.mydomain.com/wp-signup.php?new=nonexistant The fix for this is in wp-includes/ms-settings.php, replace line 89 with: {{{ $site_domain = preg_replace( '|^www\.|', '', $current_site->domain ); $destination = 'http://' . $current_site->domain . $current_site->path . 'wp-signup.php?new=' . str_replace( '.' . $site_domain, '', $domain ); }}} Also, on the registration page at the bottom it says: ""The site you were looking for, http://nonexistant.www.mydomain.com/ does not exist, but you can create it now!"" The fix is in ms-blogs.php, line 53: {{{ $url = preg_replace( '|^([^\.]+://)(?:www\.)?|', '$1' . $blogname . '.', $url ); }}}" jkhoffman 23087 Filter wp-register.php canonical redirect in single site too Canonical normal normal Awaiting Review enhancement new has-patch 2012-12-30T16:02:06Z 2012-12-30T21:05:43Z "in canonical registration location redirecting we have a filter for MS but none for WP Single Site. I'm unsure of how to convert Git patches to svn, so... yeah... Sorry. patch: https://github.com/ChrisClayton/WordPress/commit/449ac581ff45bfd68050280cdad6211d907ca12f" chrisclayton 23085 Calling $wpdb->query() when no connection exists causes mysql_error() to throw an error Database 3.5 normal minor Awaiting Review defect (bug) new dev-feedback 2012-12-30T10:30:49Z 2013-01-21T00:42:22Z "In the query() method of wp-db.php, the mysql_error() expects that if a parameter is passed to it then it should be a valid link identifier. *May need feedback or added testing* ...this error may be specific to transactions, which is why it hasn't been noticed before. Unit tests do use transations and I only get these errors when ROLLBACK is called during specific unit tests that don't modify the DB state. A simple transaction opened & rolled back in the Debug Bar Console is not triggering this for me. Unit test failure examples: '''Test: test_is_image_positive''' {{{ mysql_error() expects parameter 1 to be resource, integer given Execution time: 0.02507209777832s Stack Trace: Array ( [0] => Array ( [file] => C:\xampp\htdocs\wpnew\wp-includes\wp-db.php [line] => 1202 [function] => mysql_error [args] => Array ( [0] => 0 ) ) [1] => Array ( [file] => C:\xampp\htdocs\wp_test_svn\includes\testcase.php [line] => 25 [function] => query [class] => wpdb [type] => -> [args] => Array ( [0] => ROLLBACK ) ) ) }}} '''Test: test_is_image_negative''' {{{ mysql_error() expects parameter 1 to be resource, integer given Execution time: 0.02237606048584s Stack Trace: Array ( [0] => Array ( [file] => C:\xampp\htdocs\wpnew\wp-includes\wp-db.php [line] => 1202 [function] => mysql_error [args] => Array ( [0] => 0 ) ) [1] => Array ( [file] => C:\xampp\htdocs\wp_test_svn\includes\testcase.php [line] => 25 [function] => query [class] => wpdb [type] => -> [args] => Array ( [0] => ROLLBACK ) ) ) }}} I don't think we should attempt {{{if ( $this->last_error = mysql_error() )}}}. That is because when mysql_error() is called without a link identifier then the most recent connection to MySQL is referenced. On a busy server this may not be the same connection as our page or transaction originally used. See #3544 for history/details." mbijon 23084 Replace the use of the $more global with a filter General 3.5 normal normal Awaiting Review enhancement new 2012-12-30T09:35:31Z 2012-12-30T09:35:31Z Globals are evil is a good enough reason, but this global is also very poorly documented http://codex.wordpress.org/Customizing_the_Read_More#How_to_use_Read_More_in_Pages claims that it can have negative value while it is being used as boolean in the code. mark-k 23083 Tag balancing for text widgets Widgets normal normal Awaiting Review enhancement new has-patch 2012-12-30T09:11:18Z 2013-01-29T20:58:48Z "Based on inspecting the code it looks like tag balancing is not applied to th content of the text widget. IMO people are more likely to produce broken HTML when adding HTML in a text widget then when writing post, but tag balancing is done only for posts and comments (in which HTML is rarely used)." mark-k 23082 "replace XHTML with HTML in ""WordPress should correct invalidly nested XHTML automatically"" setting" Text Changes normal normal Awaiting Review defect (bug) new 2012-12-30T09:02:43Z 2012-12-30T09:02:43Z "From inspecting the code it seems like tag balancing is done whatever flavour of HTML is being used, so maybe using the more generic term HTML will reflect better what is being done in the code. Actually I'm not even sure that it should be more then ""Try to auto correct publishing standard errors found in the text"", just avoid totally the whole XHTML/HTML thing. I'm sure someone with better english language skills then me will find a way to make it shorter." mark-k 23076 Update menu item title when editing menu item label Menus 3.5 normal minor Awaiting Review enhancement new 2012-12-29T13:59:46Z 2012-12-29T13:59:46Z "I'd like to suggest that the menu item title gets updated when the user is editing the ""Navigation Label"" field. That results in a nicer preview, when the menu item is collapsed again before saving." tillkruess 23074 Changing post's URL and then setting it back causes redirect loop Canonical 3.5 normal normal Awaiting Review defect (bug) new close 2012-12-29T00:44:50Z 2012-12-30T06:59:34Z This morning, I changed the URL of one of my posts, but then changed my mind and set it back. When you change the URL of your post, WP automatically creates a redirect from the old page to the new page, which is good, but in this case it led to an unintended consequence: after I changed the link from A to B and then back to A, it set up a redirect from A to B and a redirect from B to A, causing anyone trying to access A or B to end up in a redirect loop between the two (or possibly it created a redirect loop from A to A; I'm not sure). It should check for such loops when you update the URL to avoid this problem. vbuterin 23072 Forums should use title to show a hint about accesskeys for , etc. WordPress.org site normal normal WordPress.org defect (bug) new 2012-12-28T21:56:47Z 2012-12-28T22:02:10Z "WordPress.org forums should use the HTML title="""" attribute to give users a hint that there are keyboard shortcuts that will help their writing process. That hint would be displayed when users hover their mouse over the , and other buttons. Current HTML for the button: {{{ }}} A more user-friendly alternative: {{{ }}}" Daedalon 23069 For plugins that create custom taxonomies, wp_delete_term does not work during plugin uninstall. Taxonomy 3.5 normal trivial Awaiting Review defect (bug) new 2012-12-28T15:10:51Z 2013-01-02T19:37:39Z "I ran into this problem while writing a plugin uninstall class to clean up any options, custom post types, taxonomies & terms related to the plugin. The problem is, if a plugin creates a custom taxonomy and the plugin user creates terms for that taxonomy, the plugin cannot delete those terms during uninstall. How to reproduce: 1. Create a plugin that creates a custom taxonomy. 2. Create some terms for that taxonomy. 3. In uninstall.php, try using wp_delete_term to remove those terms. Because the plugin is already deactivated by the time uninstall.php fires, $wp_taxonomies no longer contains the custom taxonomy that the plugin created. Since wp_delete_term requires a valid taxonomy as its second parameter, it does not work. The issue is also being discussed here: http://bit.ly/RUDYOv" sscovil 23062 Issue warnings for deprecated and wrong behavior in pre-release builds Warnings/Notices normal normal Future Release enhancement new 2012-12-27T16:51:05Z 2013-05-16T11:56:07Z "Coming out of #22873 and the [https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2012-12-12&sort=asc#m518273 associated development chat]: _doing_it_wrong(), _deprecated_argument(), _deprecated_file(), and _deprecated_function() should issue an E_USER_WARNING up to and including RC1, and an E_USER_NOTICE otherwise." nacin 23061 get_post_meta() on post with large amount of meta keys uses too much memory Database normal normal Awaiting Review enhancement new 2012-12-27T13:40:17Z 2012-12-27T14:54:48Z "I think it's likely there has been a ticket on this in the past, but I couldn't find one so here goes! If I have a post that have say 25k post meta entries, and I call `get_post_meta( $id, 'foo', true )` then `update_meta_cache` is going to cause all post metas to be loaded into memory. In most cases I can see this makes sense, however I recently had an issue where I was storing contest votes as meta keys, a post had 30k votes, and would take about 70MB of memory to get any meta key of that post (even if I didn't want votes). This is fairly edgecase, but the idea that all meta for a post is always loaded even if you don't want it is perhaps over presumptuous as a dev may be storing a large amount of data in meta. With persistant object caching this is somewhat worse, as the object cache store gets very large. I am not proposing this functionality is removed, maybe just a filter or something in http://core.trac.wordpress.org/browser/trunk/wp-includes/meta.php#L524 so one could either adjust the query or perhaps pass an array of meta keys to exclude from the sql query" joehoyle 23060 Throw 404 if URL Rewriting is Used With Default Permalinks Permalinks 3.5 normal normal Awaiting Review enhancement reopened dev-feedback 2012-12-26T20:54:55Z 2012-12-26T21:34:04Z "Suddenly I discovered that my blog is not returning error 404 page. My blog permalink is set as default style http://test.onetarek.com/?p=123 Now I am trying to create 404 error by using this url http://test.onetarek.com/adsfjkasjdd , it showing home page. Then I tested http://test.onetarek.com/?p=123654 now it shows 404 page. Then I tried to load a not existing image http://test.onetarek.com/wp-content/themes/twentyeleven/images/headers/not-image.jpg it shows my home page instead of 404 page. I changed my permalink settings to ""Day and name"" then it show 404 page. I tested this problem in my another blog, this blog is return 404 page but that is not generated by wordpress. Wordpress 404 theme page is not being loaded. A blank page is being loaded with a message by Apache Server ""Additionally, a 404 Not Found error was encountered while trying to use an ErrorDocument to handle the request...."" So what is the problem with permalink settings and 404 page." onetarek 23057 Pass $reassign in the delete_user hook Users 3.5 normal normal Awaiting Review enhancement new has-patch 2012-12-26T05:42:00Z 2012-12-26T06:21:14Z "File: wp-admin\includes\user.php In the wp_delete_user function, there are 2 do_action hooks - do_action('delete_user', $id); - do_action('deleted_user', $id); The $reassign variable should also be passed along. We can then decide what to do when the admin delete a user by ""Delete all posts"" or ""Attribute all posts to: XYZ""." genkisan 23056 date_i18n() does not localize dateformat 'r' I18N 1.5 normal normal Awaiting Review defect (bug) new 2012-12-26T02:47:11Z 2012-12-26T04:32:58Z "The weekday and month strings in a date being formatted with the 'r' format character are not being localized. I've looked at the [http://core.trac.wordpress.org/browser/trunk/wp-includes/functions.php trunk code] and it looks like the 'r' case is not being considered at all in the [http://codex.wordpress.org/Function_Reference/date_i18n date_i18n()] function. This bug is very easy to reproduce: {{{ print ( date_i18n( 'r', 972144067 ) ); }}} Expected output for language Dutch:[[BR]] ''za, 21 okt 2000 16:01:07 +0200'' Received output:[[BR]] ''Sat, 21 Oct 2000 16:01:07 +0000'' == Potential patch: == A bit of a hacky patch would go along the lines of: {{{ if( !function_exists( 'patch_date_i18n' ) ) : add_filter( 'date_i18n', 'patch_date_i18n', 10, 4 ); function patch_date_i18n( $formatted_date, $req_format, $timestamp, $gmt ) { if( $req_format !== 'r' ) return $formatted_date; global $wp_locale; $datefunc = $gmt? 'gmdate' : 'date'; $find = array ( $datefunc( 'M', $timestamp ), $datefunc( 'D', $timestamp ), ); $replace = array( $wp_locale->get_month_abbrev( $wp_locale->get_month( $datefunc( 'm', $timestamp ) ) ), $wp_locale->get_weekday_abbrev( $wp_locale->get_weekday( $datefunc( 'w', $timestamp ) ) ), ); return str_replace( $find, $replace, $formatted_date ); } endif; }}} Hope this helps. Would be great if this could be fixed. Smile, Juliette " jrf 23050 make_clickable incorrectly formats anchors with URL's and spaces in them in comments Formatting 3.4.2 normal normal Awaiting Review defect (bug) new 2012-12-23T00:32:30Z 2012-12-23T16:27:36Z "When posting a comment, if an anchor tag contains both a URL and some words, make_clickable formats the output incorrectly. To duplicate, post the following content in a comment: {{{ Hey! http://wordpress.org is awesome in case you didn't know! }}} When viewing the comment, you'll get: {{{ Hey! http://wordpress.org is awesome in case you didn't know. }}}" johnjamesjacoby 23049 Template hirarchy for 404 Template normal normal Awaiting Review enhancement new 2012-12-22T17:19:05Z 2012-12-22T19:43:02Z "load 404-{post-type}.php when url structure matches post permalink structure but there is no post at that address. load 404-{taxonomy}.php when url structure matches taxonomy permalink structure but doesn't match any specific taxonomy tag URL. And so on.... The idea is to have different 404 pages based on the context to which the URL refers. For example if a site has a blog and a shop it might be better to show a blog specific 404 page when the URL might be interpreted as a post and a shop specific 404 page when the URL might be interpreted as a product." mark-k 23047 Gallery sort options Media 3.5 normal normal Awaiting Review defect (bug) new close 2012-12-22T16:58:41Z 2012-12-23T22:54:46Z "Hi, as stated in this ticket (#22637) I would question wether this is the (complete) solution to the mentioned behaviour: ""...missing gallery sort options. There were a bunch of them in core, in a number of forms: — Sort the queue ascending and descending (these seemed to invert the queue) — Order by: Menu order, title, Date/time, and Random — Order: ascending and descending sort for the ""Order by"" properties It looks like we need some of this back. These should all be ""on-the-fly"" sorting, as in, they sort the images in the view, then save it to the ""ids"" attribute of the gallery shortcode. We should support a way to immediately sort the entire gallery by title, date/time, random, and then the ability to inverse the gallery.""" th23 23045 WP_User_Query features Users normal normal Awaiting Review feature request new 2012-12-22T06:14:45Z 2013-02-02T11:20:46Z WP_User_Query does not updated recently and due to more use of wordpress as CMS needs of custom query per users increased, WP_User_Query lack post type support(i add a ticket for it #21744) lack taxonomy/multiple taxonomies query and alot others, maybe its time to update WP_User_Query like WP_Query. it's really a need for common works these days. AliMH 23040 Expand __get() method of WP_Theme object Themes normal normal Awaiting Review enhancement new dev-feedback 2012-12-21T20:11:54Z 2012-12-21T22:28:31Z "Currently, a user can do the following: {{{ $theme = wp_get_theme(); $version = $theme->Version; $name = $theme->Name; $author = $theme->Author; $version = $theme->Version; }}} So, when I tried to get the other data in the same method, I was getting nothing. However, to get the other data, one must do this: {{{ $theme->{'Author URI'}; // per Codex; $theme->get( 'AuthorURI' ); // $theme->AuthorURI doesn't work $theme->get( 'ThemeURI' ); // $theme->ThemeURI & $theme->{'Theme URI'}; doesn't work $theme->get( 'TextDomain' ); // $theme->TextDomain & $theme->{'Text Domain'}; doesn't work }}} get() is a great method to get the other data; however, shouldn't we make this consistent for developers?" wpsmith 23034 wordpress-sources is not up to date nacin WordPress.org site normal normal WordPress.org defect (bug) assigned 2012-12-21T08:16:31Z 2013-01-10T06:55:04Z "It would be nice if you could include as part of your standard release workflow a step that ensures that http://code.trac.wordpress.org/browser/wordpress-sources is up-to-date. For instance WP 3.5 ships JQuery 1.8.3 but the above repository only contains the source for version 1.8.1. JQuery UI is at 1.9.2 while the above repository only contains 1.8.23." rhertzog 23032 Call get_page_hierarchy without passing by reference in wp-includes/rewrite.php page_uri_index Warnings/Notices 3.0 normal minor Future Release defect (bug) new has-patch 2012-12-21T01:06:13Z 2013-05-16T12:38:59Z " PHP Strict Standards: Only variables should be passed by reference in wp-includes/rewrite.php on line 825 Due to &$pages in the function declaration. {{{ function get_page_hierarchy( &$pages, $page_id = 0 ) }}} Instead of calling get_page_hierarchy with the full $wpdb->get_results as the arg, save the get_results to a variable and pass that to get_page_hierarchy. {{{ $pages = $wpdb->get_results(...) $posts = get_page_hierarchy( $pages ); }}} " Askapache 23023 Touch UI Menu Code doesn't address flyout menus two-levels deep. Menus 3.5 normal minor Awaiting Review defect (bug) new 2012-12-20T15:21:17Z 2013-03-08T15:54:40Z "The code we did in #20614 only addressed the single dropdowns you normally see in a single site install. A multisite install will have flyouts coming out of the dropdowns that we need to account for as well. Related: http://wordpress.org/support/topic/wp-admin-bar-doesnt-play-well-with-touch-device-in-wp-35" georgestephanis 23022 Always set posts to draft status when untrashing Trash 2.9 normal normal Awaiting Review enhancement new dev-feedback 2012-12-20T15:00:43Z 2013-01-16T05:51:21Z "In some situations it is bad when trashed posts immediately go live after being untrashed. Such as: * A published post is found to have libellous/wrong/other_bad content in it * Admin trashes the post * Admin wants to edit the post and republish it without the bad things * Admin cannot do this without republishing the bad things, which they cannot do. I appreciate that the user should have unpublished the post rather than trashing it but people don't always think clearly in these situations, and once you're in it, you can't get out -- your options are to republish, permanently delete, or leave the post in limbo. I did wonder if it would be better to make trashed posts viewable/editable in the admin but that felt like a pretty big move, and one that would make the status of a trashed post much less clear and rather ambiguous. So, the attached patch sets all untrashed posts to draft status, rather than restoring their original status, which was the only other thing I could think of. (Definitely happy to debate alternative solutions)" harrym 23020 wp.getPageList should act like wp.getPages XML-RPC 2.2 normal minor Awaiting Review defect (bug) new has-patch 2012-12-20T13:47:13Z 2012-12-30T15:07:53Z "I know that wp.getPageList is obsolete, but I think it should act like wp.getPages At the moment wp.getPageList returns even the trashed pages and doesn't return the status of the page. The weird behavior i've seen with wp.getPageList on a third-party client is shown below: - Refresh the pages list. - The Page 'A' is in the list. - Select the page 'A' and delete it. - Refresh the pages list and the page is still there. Doh!" daniloercoli 23017 Support for fatal errors on XML-RPC XML-RPC 3.5 normal normal Awaiting Review defect (bug) new has-patch 2012-12-20T11:24:27Z 2013-03-19T11:22:13Z "Similar to #16748, when a fatal error occurs, PHP will output some HTML code which at best is confusing for XML-RPC clients. Using the `shutdown` action, we could die more gracefully and return a XML-RPC formatted error" koke 23016 Allow plugins to manipulate WP_Roles ($wp_roles global) on construct Role/Capability 3.5 normal normal Future Release defect (bug) new early 2012-12-20T08:38:46Z 2013-05-14T13:32:58Z "The WP_Roles class is difficult to extend. There are no actions, filters, or intercept points to allow plugins to target it. Because the $wp_roles global can be created anytime (even doing_it_wrong on plugins_loaded) there's no reliable way to modify any part of $wp_roles. (The only place WP_Roles actually has any action at all is in the set_role() method, which is the least useful function in the class since it noops all user roles if a user has more than one.) The specific use case I have is bbPress's dynamic roles. bbPress is unable to add its dynamic roles to the $wp_roles global on switch_to_blog(). Neither of WP_Roles's initialization methods have actions to allow bbPress to add its roles on. * switch_to_blog() calls $wp_roles->reinit() * then wp_get_current_user() * finally $current_user->for_blog() At no point can bbPress reliably append its roles to $wp_roles->roles, causing the current user to incorrectly be missing their bbPress role for that site. More over, the WP_Roles::reinit() method seems like a one-use stop-gap to fix a specific problem, that ends up introducing other issues with trying to extend it. If the use_db flag is set to false, it bails early, and there's no way for plugins that don't use database roles to reinitialize their roles correctly again. The attached patch does two things: * Removes the reinit() method completely, and instead re-instantiates the $wp_roles global inside switch_to_blog(). WP_Roles::_init() is not a heavy function, and the guts are basically identical between the two methods. * Adds a byref action to WP_Roles::init() that allow plugins like bbPress to add their dynamic roles anytime $wp_roles is created." johnjamesjacoby 23012 Refresh the code for the default widgets Viper007Bond* Widgets 3.5 low minor Future Release enhancement accepted 2012-12-20T01:49:37Z 2012-12-21T21:28:45Z "The default widgets serve as examples for many people to make new widgets. We should make sure they're up to date in terms of coding standards and best practices. There's many places where this is not the case. A few examples: * `$instance['text'] = stripslashes( wp_filter_post_kses( addslashes($new_instance['text']) ) );` * `$text = esc_textarea($instance['text']);` rather than at output Also tons and tons of formatting issues. I'll volunteer to take this on." Viper007Bond 23008 Add a Hook To Hide Inactive Widgets Widgets 3.5 normal minor Awaiting Review feature request new dev-feedback 2012-12-19T19:59:12Z 2012-12-19T20:21:09Z "Hello, This is my first feature request so hopefully I'm going through the process correctly. Onto the request... Adding a hook to remove or hide the Inactive Widgets sidebar on the WordPress Admin Widgets page would be very useful for developers who don't use the area and want to be able to hide it for better UX. If this is approved I would love to submit a patch. :)" BFTrick 23005 wp_update_user breaks if ID not set Users 3.5 normal normal Awaiting Review defect (bug) new 2012-12-19T15:18:42Z 2012-12-19T15:47:58Z "Passing an array of userdata to wp_update_user (first_name, last_name, user_email, user_login). If ID is not in the array, then a PHP Fatal Error is triggered: [19-Dec-2012 15:03:16 UTC] PHP Fatal error: Call to a member function to_array() on a non-object in [..]/web/content/wp-includes/user.php on line 1456 The codex for wp_update_user (http://codex.wordpress.org/Function_Reference/wp_update_user) does state ""If $userdata does not contain an 'ID' key, then a new user will be created and the new user's ID will be returned."", which makes me think this might be a new bug." actionnerd 23003 Long filename breaks styling in media modal Media 3.5 normal normal Awaiting Review defect (bug) reopened 2012-12-19T12:11:17Z 2012-12-19T16:48:47Z "Long filename in media modal breaks styling of right sidebar. Long filename is displayed bellow thumbnail and longer labels bellow are moved to separate line. See attached picture." pavelevap 23002 Maybe a little styling? WordPress.org site normal normal WordPress.org enhancement new 2012-12-19T11:25:29Z 2012-12-19T11:49:23Z "Hi, The fields in registration page http://wordpress.org/support/register.php are without style. Maybe a little styling for the fields? Now not are very nice..." j.conti 22999 The position of the cursor is ignored when inserting media in DFW and Text mode (IE) Media 3.5 normal normal Awaiting Review defect (bug) new 2012-12-19T00:58:22Z 2012-12-19T01:07:36Z "When editing a post in IE8/IE9 in either full screen mode or in text mode, media is always inserted at the top of the post when regardless of where the cursor is positioned prior to opening the ""Add Media"" modal. I suspect that IE7 is also affected, but I have not tested it." gcorne 22997 IE 8 issue with new Media Manager Media 3.5 normal major Awaiting Review defect (bug) new 2012-12-18T19:25:30Z 2012-12-18T19:38:55Z When in any post in IE8 you are unable to remove featured images also if you add a new post and attempt to set a featured image the media manager does not open in a model as it should which prevents you from setting the image. th3fallen 22996 IE8 - Hierarchical Taxonomies with bulk terms cause massive slow-down / freeze Editor normal minor Awaiting Review defect (bug) new dev-feedback 2012-12-18T19:18:02Z 2013-01-06T08:07:28Z "For a project, we have about 550+ terms in a single taxonomy, the other taxonomies have around 10-40 each themselves too. There appears to be an issue when IE8 comes across too many checkboxes on a page, and this recently was exacerbated by an upgrade to WP 3.5. The upgrade itself didn't cause it, but it coincided with the addition of a few new terms (don't know how many were added before the upgrade just yet, will post if I find out more info). To reproduce, you've gotta have a large amount of terms for your taxonomies, then go into the post editor (for whatever post type you're testing on), and ensure your taxonomies have 'hierarchical' set to true in their definitions. I've seen the issue crop up on save (on subsequent load of the page w/ success message on it), and on open of the edit page itself. The issue seems to be more severe for IE8 on Windows XP Service Pack <= 1, but I've seen it cause a massive slow-down for newer XP versions, just not freeze up entirely like it did on the XP SP 1 machine I was primarily testing on. ''I'm not really sure'' what the solution is going to have to be here, or if this will serve merely as a paper-trail for the folks searching for information about this. I did a blanket forceful change for checkbox input to autocomplete on the meta boxes associated to hierarchical taxonomies using the following Gist to resolve the freezing for now: https://gist.github.com/4330772 Here's the info you'll probably ask for, I went down to the basics to see exactly what the cause was: 1. No plugins activated (except a small plugin that had the Gist in it to resolve the issue for me) 2. Standard Twenty Twelve theme activated 3. Tested and found the issue happening on both WP 3.4.x and WP 3.5 4. Tested on XP SP 1 with IE8, saw the greatest degradation of performance here 5. Tested on XP SP 3 with IE8, saw a noticeable freeze and then slow-down of performance as the page loads here" sc0ttkclark 22995 WP_Query Category stuff blank page Query 3.5 normal normal Awaiting Review defect (bug) new 2012-12-18T18:59:18Z 2012-12-19T23:48:54Z "hey there, maybe I have found a bug. Sending following parameter to the WP Query (with my theme via ''?s=test%cat=1234'') you should get a blank page. At first I thought it was a bug of mine, but deleting following line in /wp-includes/query.php:1746 fixes the problem. {{{ $q['category__in'][] = $cat; }}} So I think there's a bug in the query function... Thanks, Ninos" Ninos Ego 22994 Remove 'blogroll' from the import options Import 3.5 normal normal Awaiting Review enhancement new has-patch 2012-12-18T17:53:16Z 2012-12-18T20:52:24Z "Now that we've dropped links (#21307), we shouldn't encourage importing them. It'll just confuse the newbies. This will require a change to http://api.wordpress.org/core/importers/1.0/, so while we can clean up /wp-admin/includes/import.php (attached) it won't matter till that's scrubbed. Maybe upgrade that to 1.1 so people who are on older WP are left alone?" Ipstenu 22993 Admin - users without a role are difficult to find Users 3.5 normal normal Awaiting Review defect (bug) new 2012-12-18T17:32:21Z 2012-12-20T06:21:38Z "There doesn't appear to be a filter to display users *without* a role (see the screenshot). The ideal solution would be to add a filter for ""None"". [http://i.imgur.com/3S5pH.png]" logikal16 22992 get_the_author() not working outside the post query Template 3.5 normal normal Awaiting Review defect (bug) new close 2012-12-18T16:16:04Z 2012-12-18T19:55:33Z "get_the_author() function return empty value if is used outside the : have_posts() ( the_post() .. function... the function should return the author name on the author page even if the function is not called inside the query... " alexvorn2 22990 Edit custom image sizes Media 3.5 normal normal Awaiting Review enhancement reopened 2012-12-18T13:36:46Z 2013-05-07T11:54:04Z "There is currently no way to edit custom image sizes. Since it's possible to create custom image sizes, it should also be possible to edit them in the backend. Right now there three scenarios: 1. All images 2. All images except thumbnail 3. Thumbnails only Whatever choice you make it will affect all custom image sizes. I propose more options added here,for instance: 1. All images 2. Custom -> Select size from select menu 3. Thumbnails only" jonkristian 22988 Import blogger site from its exported XML file Import normal normal WordPress.org enhancement new 2012-12-18T05:45:07Z 2013-01-22T18:52:34Z I saw that wordpress.com has an option to do that. mark-k 22986 WP uses header image's GUID as URL Themes normal normal Awaiting Review defect (bug) new has-patch 2012-12-18T01:28:18Z 2012-12-18T11:57:53Z "See summary. If I move my site (old domain becoming inaccessible), I cannot use my header images any more since a) I am not allowed to change GUIDs. b) GUIDs are used as URLs for header images: http://core.trac.wordpress.org/browser/trunk/wp-includes/theme.php {{{ 1008 foreach ( (array) $headers as $header ) { 1009 $url = esc_url_raw( $header->guid ); }}}" bersbers 22984 "Media Modal - Auto-save for compat-items doesn't trigger the UI to show the spinner or ""Saved"" indicators." Media 3.5 normal normal Awaiting Review enhancement new 2012-12-18T00:10:53Z 2013-01-22T00:22:10Z "When the auto-save kicks in for the standard attachment editor fields, it triggers the spinner icon in the top right corner. This is followed by ""Saved"" which then disappears on its own. None of these UI indicators are triggered for custom input items added via the 'attachment_fields_to_edit hook. Not sure if its was an oversight or simply not seen as important." eddiemoya 22981 Tweets import plugin tracking ticket PeteMall* Plugins high normal WordPress.org task (blessed) accepted 2012-12-17T18:43:42Z 2013-03-29T14:04:16Z "This ticket is to track the development of a plugin that can import tweets from a downloaded twitter.com archive. Presumably, such a plugin would be added to the importers list on wp-admin/import.php. Trac is best when it is used to discuss implementation. If you want to discuss the general idea, please do so on [http://make.wordpress.org/core/2012/12/16/antsy-for-3-6-to-start-and-need-a/ make/core]. Some initial thoughts on implementation: * It should use the JSON-formatted data that comes with a downloaded tweet archive. The importer should take the entire zip, extract it, and loop through the monthly files. Anything more is an unnecessary burden on the user. * The plugin should import the tweet as actual content. A filter is good idea, if someone wishes to toggle this to instead insert links to tweets (and thus rely on oEmbed). It should also store the JSON-serialized array of data (directly from 1.1 of Twitter's API) in postmeta. * It should import posts as a post format. Status makes the most sense; 'link' could also work for links, then there's also 'aside'. The post format to use should be filterable on a tweet-by-tweet basis. The post type to use should be filterable, as a 'tweet' type may be desired. * It should handle importing an archive over an existing archive, by looking for the existing tweet (probably IDs as a meta key). I don't think deleted tweets should be removed in this process, though. * Remember that tweet IDs are going to be bigger than 32-bit integers, so they must be treated as strings, and we should not try to set a post ID as we might with other importers. This importer should be tested on a 32-bit environment. Beyond that, there are other ""nice to haves"" that would likely be left to plugins of this plugin, given they are beyond the standard role of an importer. Beau Lebens, for example, has done some/all of this already: * Tagging based on hashtags, and a separate mentions and/or in-reply-to taxonomy. * Filtering over raw (no-HTML) content to add things like links to hashtags, links in tweets, etc., on display, rather than doing all of this on save. (Should a hashtag link go to the internal tag, or to twitter.com? Maybe the internal tag's description links to twitter.com?) * A cron to import new tweets using the same importing methods. One thing I will suggest: decisions, not options. Note I said ""filter"" a bunch of times, but never the word ""option."" Not that there won't be a need for any user decision here, but we should make a plugin that works well for the common use cases, and leave the rest to other enterprising developers. Side note: I am working on acquiring a namespace for the Twitter importer in the wordpress.org plugin repository." nacin 22980 Get Shortlink button should be appended using the get_sample_permalink_html filter Editor 3.5 normal normal Awaiting Review enhancement new has-patch 2012-12-17T18:39:43Z 2012-12-17T18:49:00Z "Currently the Get Shortlink button is appended directly to the output of get_sample_permalink_html(), which makes it impossible (without CSS/JS) to append items to the HTML. The get_sample_permalink_html filter should be used inside of [source:/trunk/wp-admin/edit-form-advanced.php?rev=23180#L334 edit-form-advanced.php] so the user has complete control over the generated output." coreygilmore 22976 Remove reference to category to tag converter from the tools page Text Changes normal normal Awaiting Review enhancement new 2012-12-17T16:02:00Z 2012-12-18T16:41:02Z It has been such a long time since version 2.3, does anybody really need a reminder for the existence of this tool on that relatively high profile page? mark-k 22972 Improve parameter name for wp_get_theme() Themes 3.4 normal minor Awaiting Review enhancement new has-patch 2012-12-17T12:33:15Z 2012-12-17T14:25:51Z "The name of the first parameter for `wp_get_theme()` is misleading. It's called `$stylesheet` when in fact you're passing in the name of the theme's template directory, not the stylesheet. The function is a wrapper for the `WP_Theme` class which gets its parameter names correct." johnbillion 22971 Don't work quotes auto closing in that case Formatting 3.5 normal minor Awaiting Review defect (bug) reopened 2012-12-17T12:06:43Z 2012-12-18T13:33:41Z "Hello, use latest wordpress version - 3.5. If I enter {{{ ""My Simple Text"" }}} to wordpress text editor - all right quotes close automatically and it will have view: «My Simple Text» But if I'll write {{{ ""My Simple Text 2013"" }}} It will have view: «My Simple Text 2013"" conclusion: quotes auto closing don't work if string ends by numbers " Stafox 22970 No Set Featured Image Option in existing Media Gallery Media 3.5 normal normal Awaiting Review enhancement new 2012-12-17T05:57:12Z 2013-01-29T02:24:00Z "There is a Set Featured Image link when you add new gallery but in already existing gallery, you can't set Featured Image (in case you want to add more photos and set a new featured image). You have to do it from Set Featured Image link on the post which means more clicks. Plus, I wanted to add, wouldn't it be easier if we have Set Featured Image link on the right side where all image meta exists, instead of having to click on a separate link on the left? Similar to what we had with 3.4. That would really lessen the number of clicks you have to do to set a featured image. You could do the same with existing galleries/posts too. For example, if you upload one image, its selected by default and on the right side, you can just click a Set Featured Image link." nhuja 22968 No way to view_others_posts without being forced to have edit_others_posts enabled Role/Capability 3.5 normal normal Awaiting Review enhancement new 2012-12-17T02:02:42Z 2012-12-18T06:48:22Z "I'm using the Roles plugin to tweak default roles, and I'm looking to add the capability for Authors to read unpublished posts (drafts by other users, so that they can give feedback before they're published). Unfortunately, it seems that while there's an edit_others_posts perm, there's no equivalent read_others_posts, so doing this is impossible unless you enable editing as well (that's not something I want to do). Read_private_posts doesn't do the trick either, in case you were going to suggest trying it. The right solution, IMO, is to introduce read_others_posts (and same for pages). Thank you." archon810 22967 Null value in meta query changes the type of comparison Query 3.5 normal normal Awaiting Review defect (bug) new has-patch 2012-12-17T00:05:35Z 2012-12-17T14:36:42Z "If a null value is set in a meta query, it effectively returns the same results as setting the 'compare' arg to 'EXISTS', even if it's explicitly set to the default '='. For example: {{{ $value_var = null; ... meta_query => array( array( 'key' => '_my_meta_key', 'value' => $value_var, 'compare' => '=' ) ) ... }}} That returns all rows where '_my_meta_key' exists and ignores 'value' instead of treating it like an empty string. This can be troublesome where the value is passed in dynamically like the example, so validation would have to be done prior to every meta query to ensure the value isn't null. I've attached a patch for review that checks for the existence of the 'value' key rather than using `isset` and casts it to a string if it's null." bradyvercher 22966 Show admin-cropped thumbnails instead of Wordpress-cropped thumbnails Media normal normal Awaiting Review enhancement new 2012-12-16T22:22:59Z 2012-12-16T23:27:18Z "Used to be able to see which images have been cropped (and which ones haven't) in image search results. Now have to click 'edit image' and check the image individually. It's valuable for the publisher to see what his/her readers will see on the front end of the site when the 'thumbnail' function is called (either publisher's hard-cropped image or full un-cropped image). Useful especially for publishers that are pulling images from a time before 'thumbnails' existed in WP. Main reason this is an issue is that when an un-cropped thumbnail is selected as the featured image, it will be stretched/distorted to dimensions of thumbnail settings in function.php." beerpulse 22961 """Allow link notifications from other blogs (pingbacks and trackbacks.)"" description is misleading" Text Changes normal normal Awaiting Review defect (bug) new 2012-12-16T14:39:50Z 2012-12-17T11:34:24Z "The description for enabling pingbacks and trackback is ""Allow link notifications from other blogs (pingbacks and trackbacks.)"". Which is not correct a more appropriate description should be ""By default new posts can recieve notification (pingbacks and trackbacks) from other blogs"". The current description is broken in particular when the option is not set which leads to the assumption that the pingbacks and trackbacks are block while they are not as they are still enabled for posts which were create before the option was disabled." mark-k 22959 Show all roles in user list table Role/Capability normal normal Future Release enhancement new has-patch 2012-12-16T03:20:33Z 2013-05-14T13:45:46Z "From [22686]: > we should show a comma-separated list of all roles, editable or otherwise, and this list should be filterable, either by user, or by the roles which can appear. Probably both. Previously: #22361" scribu 22957 get_boundary_post Only works from a single page Template 2.8 normal normal Awaiting Review defect (bug) new has-patch 2012-12-16T00:36:35Z 2012-12-20T23:29:33Z "I was trying to use `get_boundary_post` in my theme to display a link to the first and last posts, but it does not work from the homepage. Unless called from a single post, `get_boundary_post` will return NULL. I can't see any reason for this behavior, or any good way around it." pathawks 22951 Performance enhancements for esc_url() Performance normal normal Future Release defect (bug) new 2012-12-15T04:36:03Z 2013-05-14T12:34:06Z "`esc_url()` gets used a lot on WordPress admin pages. Sometimes 100 times or more. Nacin did some KcacheGrind measurements that had it as 7% of some pages. We can speed it up. Most of the grind comes from `wp_kses_bad_protocol()`. I had a thought that we're sort of going about things backwards. We're being very careful to exclude anything harmful — bad characters, bad protocols, duplicate fake-out protocols, etc. But almost 100% of the time, the URL going through it is a http/https URL that has completely normal characters in it. We can detect that really early, and bail. I did some tests with this approach that showed a good time savings. Quite obviously, there's no room to compromise on security, so we'll need to be watching unit test, and maybe even writing some new ones for good measure." markjaquith 22950 get_boundary_post Does not return single post object General normal normal Awaiting Review defect (bug) new 2012-12-15T00:56:48Z 2012-12-15T11:49:01Z "`get_boundary_post` Seems not to return a single `post` object, the way `get_adjacent_post` does. It seems that `get_boundary_post` should call `array_shift` or `get_post` on the results, in a similar way to `get_adjacent_post`. It's just odd that the behavior is different." pathawks 22949 More Accurate and Extensible MIME Type Handling Media 3.5 normal normal Awaiting Review enhancement new has-patch 2012-12-14T22:08:16Z 2012-12-17T21:42:22Z "In the general case, a file extension may represent more than one MIME type. Currently, file extensions are married to a single MIME. Specifically, let's look at the case of the ""ico"" file extension. Officially, the MIME type for this file should be ""image/vnd.microsoft.icon"". Unofficially, ""image/x-icon"" along with many others are usable. The solution to this problem is extremely simple. First, allow key => value pairs in the exhaustive MIME list located in wp_get_mime_types to be arrays so we can account for cases such as ico. Second, add the proper handling for this change in wp_check_filetype. The way I have written it should not interfere with existing uses of this function (as they were all passing strings and now can pass a string or array)." mattonomics 22946 Default filter erroneously turns FTP hostnames into HTTP links Formatting 2.0.4 normal normal Awaiting Review defect (bug) new 2012-12-14T20:01:51Z 2012-12-22T19:40:55Z "The function _make_web_ftp_clickable_cb in wp-includes/formatting.php is invoked upon any hostname matching ""www."" or ""ftp."" at the beginning. It pre-pends 'http://' and makes the link clickable (i.e. wraps it in ). As a default that makes sense for things beginning www. - but not for everything beginning ftp. In my case, I was using the plugin WP Better Emails, and sent out an email with this line (approx): `Here is the FTP server: ftp.example.com` WP, by default, ""helpfully"" totally mangles this into: `Here is the FTP server: http://ftp.example.com` The recipient of my email now believes that I was sending him an HTTP link, and is confused that it does not work. But in fact I never sent such a link - that was WordPress mangling what I did send. Sure, some FTP servers will also have HTTP listening. But by default WordPress assumes that they all do, which is crazy. Proposed solution: on line 1471 of wp-includes/formatting.php (as found in 3.4.2), change: {{{ $ret = preg_replace_callback( '#([\s>])((www|ftp)\.[\w\\x80-\\xff\#$%&~/.\-;:=,?@\[\]+]+)#is', '_make_web_ftp_clickable_cb', $ret ); }}} by removing the ""ftp"" case, hence: {{{ $ret = preg_replace_callback( '#([\s>])((www)\.[\w\\x80-\\xff\#$%&~/.\-;:=,?@\[\]+]+)#is', '_make_web_ftp_clickable_cb', $ret ); }}} The function _make_web_ftp_clickable_cb should then be renamed by removing ftp_, since the case of turning FTP hostnames into clickable HTTP links would have been removed." DavidAnderson 22942 Deprecate Post by Email Blog by Email 3.5 normal normal Awaiting Review enhancement new dev-feedback 2012-12-14T16:48:46Z 2013-05-01T16:18:38Z "We said last year that we'd remove the post by email functionality from core as it was better suited for plugins. The Jetpack plugin has already added this functionality and, honestly, includes better functionality than the core version. We should move forward with our plans to remove this feature. I recommend ''deprecating'' it similar to the way the link manager was removed in 3.5. Essentially: * New WordPress installations will never see the core feature * Existing installations that aren't using it won't see it any more * Existing installations that ''are'' using it will see a notice explaining they should switch to a plugin instead as the feature will be completely removed in the future Basically, I want the option to go away, but I don't want anyone to start a riot if we remove a tool they're actively using." ericmann 22940 Adding term checklist to Media modal has undesired results Media 3.5 normal normal Awaiting Review defect (bug) new 2012-12-14T14:59:27Z 2012-12-14T14:59:27Z If you use '''attachment_fields_to_edit''' to add a term checklist to the media modal, there is no way to know when a term is unchecked. I propose that when a checkbox is clicked in the compat section, all the checked boxes of the same name are passed in the POST request. jfarthing84 22938 Presentation of hierarchical taxonomy in Media modal should be checkboxes rather than comma-separated tag list Media normal normal Awaiting Review enhancement new 2012-12-14T14:10:16Z 2013-01-31T18:24:24Z Since 3.5, using register_taxonomy_for_object_type on attachments, if the taxonomy used is hierarchical, whereas in the edit attachment UI you see the normal list of checkboxes, in the corresponding modal it is presented as a comma-separated list of slugs, as if it were a non-hierarchical taxonomy (tags rather than categories). I'm sure this is not a bug / mistake / oversight, but at best it's a little unintuitive (you need to have memorised the category slugs to add new ones) and worst a bit dangerous (risk of adding unwanted categories), and it would be great if in future it was presented here too as a list of checkboxes. yeswework 22937 Bulk Actions > Edit could allow batch-assignment of taxonomies to Media following the WP 3.5 media changes Media normal normal Awaiting Review feature request new 2012-12-14T13:59:37Z 2012-12-14T13:59:37Z "[First and foremost the media improvements in WP 3.5 are wonderful, thanks to all involved.] Now that you can assign taxonomies to media easily, it would be extremely useful if you could also use Bulk Actions > Edit (as you can with posts / pages / custom post) to assign them to multiple images more quickly. Real world case: we added a taxonomy to media yesterday for a client, so they could categorise their ~500 images into sitewide categories, and they immediately replied to ask if there was a way of doing it in batches..." yeswework 22936 XML-RPC WordPress api setOption double escapes args XML-RPC normal major Awaiting Review defect (bug) new 2012-12-14T13:46:35Z 2012-12-15T15:31:10Z "Parts of the xml-rpc wordpress api are not usable, as they doublequote strings. e.g. `Munich's` becomes `Munich\\'s`. wp.setOptions($args) escpapes all args and calls update_option() which is then calling mysql_real_escape_string(), leading to a double escaping. To solve this options should not be escaped in wp-setOptions() function. Here the callStack showing the 2nd escaping: {{{ wp-includes/wp-db.php.wpdb->_real_escape:884 wp-includes/wp-db.php.wpdb->escape_by_ref:950 wp-includes/wp-db.php.array_walk:0 wp-includes/wp-db.php.wpdb->prepare:1003 wp-includes/wp-db.php.wpdb->update:1365 wp-includes/option.php.update_option:258 }}}" jachzen 22929 "The text for themes under ""Available Themes"" could use some structure" Themes 3.5 normal minor Awaiting Review enhancement new close 2012-12-14T00:09:18Z 2012-12-30T21:32:51Z The text for each theme under Available Themes seems to be just floating in space, adding a border around it might look cleaner. wycks 22926 attachment_fields_to_edit doesn't show on edit image screen Media 3.5 normal normal Awaiting Review defect (bug) new 2012-12-13T23:11:33Z 2012-12-13T23:11:33Z """attachment_fields_to_edit"" works normal when inserting an image with the new media manager, but it doesn't work when editing an image that's already been inserted into the post. It looks like it's just displaying editimage.html without ever using the filter. " vvu 22925 media_upload_tabs filter not functioning Media 3.5 normal normal Awaiting Review defect (bug) new 2012-12-13T22:21:28Z 2012-12-15T04:32:25Z When using the media_upload_tabs filter, the array passed through contains a 'library' item that usually can be unset, therefore removing the Media Library tab from the front-end uploader. This no longer works. I cannot even rename the labels using this method, however the array of tabs is still coming through, and modifying it does nothing. The filter is still active, but appears to do nothing. kegster 22924 Add filter to theme editor accepted files Editor 3.5 normal normal Awaiting Review enhancement new has-patch 2012-12-13T21:35:48Z 2013-02-22T20:41:09Z "Proposing adding a filter to theme-editor.php so theme authors can add to the list of files that are editable. ie html/less/js files. Hers an example of what could be possible: {{{ add_filter( 'wp_theme_editor_filetypes', 'add_my_filetype', 10, 2 ); function add_my_filetype( $allowed_types, $theme ) { $extra = $theme->get_files( 'less', 1 ); return $allowed_types += $extra; } }}}" pross 22922 Add filter 'comment_notification_email_to' in wp_notify_postauthor() Comments 3.5 normal normal Awaiting Review enhancement new has-patch 2012-12-13T17:53:32Z 2013-01-03T17:57:54Z "Currently, mailto: address is not filterable in pluggable function `wp_notify_postauthor()`. Thus, in order to send replies to email addresses other than the post author, the entire function must be overridden. Patch makes mailto: filterable for `wp_notify_postauthor()`, moving `$author->user_email` to an array, and applying the `'comment_notification_email_to'` filter." chipbennett 22921 Allow get_users() to return array of values via 'fields' parameter Users 3.5 normal normal Future Release enhancement new has-patch 2012-12-13T17:39:24Z 2013-05-16T11:54:18Z "Currently, the `'fields'` parameter in the arguments array for `get_users()` only accepts either an array of user data fields, or the string `'all'`. Both of these options cause `get_users()` to return an array of object comprised of the specified user data. Passing any other string value to `'fields'` causes `get_users()` to return an array of user IDs. Per the Codex: > Array of objects, '''except when fields specifies a single field to be returned, then an array of values is returned'''. If fields is set to all_with_meta, it will return an array of WP_User objects. This statement appears to be untrue, but would be incredibly useful if it were true. Patch adds this functionality to `get_users()`. Potentially related: #18581" chipbennett 22918 Allow to include ajax url javascript argument in the template header Template 3.5 normal normal Awaiting Review enhancement new close 2012-12-13T15:04:36Z 2012-12-19T02:52:58Z "in the admin-header.php we have a hardcoded javascript code for showing the ajax url in the header. I think this should be included in a function and enqueue when needed, allowing to include it in the template header too using only: wp_enqueue_script('load-ajax-url'); " alexvorn2 22917 Allow Live Updating of User & Site number in Multisite network dashboard 'Right Now' meta box Multisite 3.5 normal normal Future Release enhancement new dev-feedback 2012-12-13T14:54:48Z 2013-05-14T12:40:17Z "Wordpress installation don’t show the correct number of users and sites correctly registered in the site. Please see images for reference: - https://dl.dropbox.com/u/7531173/mu/Only1Site1User.png - https://dl.dropbox.com/u/7531173/mu/UsersNumber.png - https://dl.dropbox.com/u/7531173/mu/UsersSites%20.png" vmaia 22909 Special characters are not displayed properly on the menus Menus 3.5 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-12-13T08:09:46Z 2012-12-15T18:52:14Z The previous version of Wordpress 3.4 did handle special characters like ★ and ✄ pretty well. Wordpress 3.4 displays such special characters and they can be used on the Wordpress menus, however in version 3.5, these characters are displayed as empty squares, which does mean that 3.5 can't recognize them properly. varna_city 22898 No validation of update_plugins site transient Plugins 2.3 normal normal Awaiting Review defect (bug) new close 2012-12-12T20:50:13Z 2012-12-15T05:55:34Z "When retreiving available plugin updates, no checks are done on update_plugins site transient. Adding a filter on pre_set_site_transient_update_plugins means any developer can modify the update_plugins transient for a plugin to contain incorrect data. The attached diff has code which is 'reactive', but performs the minimal checks. This has been tested on trunk." warrenholmes 22894 Need WordPress Media Uploader Stop or Cancel Button in WP Version 3.5 Media 3.5 normal normal Awaiting Review enhancement new 2012-12-12T17:34:01Z 2013-01-09T20:11:46Z "Today I was testing the new media uploader of WP 3.5 from post editor by clicking 'Add Media'. I clicked 'upload files' and I choose a big file from my computer by a mistake. But I did not want to upload that file. Then I wanted to cancel the uploading, but there is no stop or cancel button . Then I close the popup window and open again by clicking 'Add Media' button. I see the previous file is being uploaded yet. I choose another small file and both files upload are running. [[Image(http://onetarek.com/wp-content/uploads/2012/12/stop-media-uploader.jpg)]]" onetarek 22889 Reconsider no-JS ?replytocom= links Comments normal normal Awaiting Review enhancement new 2012-12-12T15:13:20Z 2012-12-14T13:05:31Z "We have a no-JS fallback for comment replies. Normally JS moves the comment form around. For people with JavaScript disabled, they follow the `?replytocom={123}` link. This results in a lot of extra crawling by search engines (potentially an additional crawl per reply-able comment!) in exchange for enabling an awkwardly executed, likely underused, and non-essential feature for non-JS users. I'd like to consider making comment reply JS-only." markjaquith 22887 "JavaScript inserted using ""attachment_fields_to_edit"" executes too early" Media 3.5 normal normal Awaiting Review defect (bug) new 2012-12-12T13:14:43Z 2012-12-12T16:04:47Z "If I add JavaScript using ', 'value' => 0 ); return $form_fields; } }}} This should always pop a message box containing ""1"" (i.e. the number of elements found with the ""bug_test_div"" id), but it doesn't in the following situation: Access the admin panel, add a new post and click on the ""Add Media"" button. Upload an image and you will get a message box saying ""1"". Good. Now upload another image and select it. Now you'll get ""0"" instead of ""1"". Select the previous image or any other image and you will still get ""0"" instead of ""1"". Note that this works without a problem (i.e. always outputs ""1"") in the ""Admin panel -> Media -> Edit Media"" pages. " liviumirea 22884 What if I delete wp_posts table from database. Database 3.5 normal normal Awaiting Review enhancement new dev-feedback 2012-12-12T12:48:24Z 2012-12-13T11:51:20Z "I am not a experienced or mature programmer but I have seen it While I was playing with database of WordPress. I have deleted wp_posts table in database in WordPress - 3.5(beta). It looks normal on other pages at admin side but when i open single post it shows post-new.php and when hit save, it shows ""wp_error"" with this message ""You are not allowed to edit this post."" That's OK. I was expecting error but not this type of error. It seems WordPress doesn't know that its most important table has gone away and that's why admin may not know( well for a while). I think its not good. well I don't know its issue or it is way it behaves with database and its normal but I think WordPress should know what exactly happened. when I have updated WordPress with stable 3.5 it has updated but database is still same which is normal. Should we( can we )track tables( some of tables which are important ) by PHP ?" mukkundthanki 22881 upgrade fails when disk space is exhausted due to quotas Upgrade/Install 3.4.2 normal normal Awaiting Review defect (bug) new 2012-12-12T11:38:41Z 2012-12-12T11:38:41Z "The upgrade from wordpress 3.4.2 to 3.5 failed due to a disk space limitation: {{{ Downloading update from http://wordpress.org/wordpress-3.5-new-bundled.zip… Unpacking the update… The package could not be installed.: PCLZIP_ERR_BAD_FORMAT (-10) : Unable to find End of Central Dir Record signature Installation Failed }}} A similar bug occurs if the space for the files themselves is exhausted. On the same installation, functions.php was truncated at 112k, leaving the installation in a non-functional state. This kind of behaviour can be avoided with an upgrade function of the form: {{{ # test for 64k free disk space ... dd if=/dev/zero of=biggish-test-file bs=1024 count=64 && rm biggish-test-file && wget -O - http://wordpress.org/latest.tar.gz | tar -zvx --strip-components=1 }}} Streaming the download imposes no additional disk space requirements for the intermediate .zip file, but does require a change in the extraction code. Streaming an update cannot be done with zip files, since the index is at the end. ZIP files have to be complete, since the tag is at the end. 'tar' files are more suitable for streaming." list2010@… 22880 Customize Themes without activation Appearance normal normal Awaiting Review enhancement new 2012-12-12T11:34:51Z 2012-12-12T11:38:58Z "Add a posibility to customize deactivated themes with the Theme-Customizer without activating them by default. Useful for Blogs running multiple Themes between which the frontend user can switch." kkkrys 22879 Canonical Link Missing on Front Page Canonical 3.4.2 normal normal Awaiting Review defect (bug) new 2012-12-12T11:03:05Z 2012-12-30T19:54:30Z "Canonical links are provided for posts, so if someone links to /2012/12/my-post/?whatever then Google will know it is a duplicate of /2012/12/my-post/ But if someone links to /?whatever there is no canonical address." miqrogroove 22876 Wrong robots meta output Template 3.5 high major Awaiting Review defect (bug) new 2012-12-12T10:01:38Z 2012-12-12T15:15:11Z "in default-filters.php, we add a new action: {{{ if ( isset( $_GET['replytocom'] ) ) add_action( 'wp_head', 'wp_no_robots' ); }}} the issue is, wp_no_robots outputs noindex, nofollow. The noindex is fine, the nofollow stops any link equity from that URL, so that's actually a bad idea. Just noindex alone would be fine. Setting to priority high and severity to major as this is basically a regression." joostdevalk 22875 Additional custom taxonomy object types Taxonomy 3.5 normal major Awaiting Review enhancement new 2012-12-12T09:59:37Z 2012-12-12T19:53:43Z "At the moment, a taxonomy can be registered for one of the following objects (ref http://codex.wordpress.org/Function_Reference/register_taxonomy ): - post - page - attachment - revision - nav_menu_item - a particular cpt Taxonomies would become much more powerful and flexible, if: - They accept additional objects, e.g. users, taxonomies - They accept multiple objects, e.g. a single custom taxonomy could group together posts, pages and attachments" sooskriszta 22870 Add New Media Page doesn't fail out on large images Media 3.5 normal normal Awaiting Review defect (bug) new 2012-12-12T05:20:15Z 2012-12-12T05:20:15Z "Discovered while debugging #22869 (which is why your steps to repro are similar) To Reproduce: Upload https://objects.dreamhost.com/ipstenu-images/sunset_2_22_11_by_kenshinkyo-d3a6slk.jpeg to your WP install in the media-new.php page Note: Image is 12600x9450 and 4.9MB Expected Outcomes: VPS/Dedicated with tons of memory: Success Shared hosted without a lot of memory: Failure, not enough memory Actual outcomes: VPS as expected. Shared * On 3.4.2: ""Fatal error: Allowed memory size of 268435456 bytes exhausted (tried to allocate 50400 bytes) in /home/blah/site.com/wp-includes/media.php on line 258"" (good) * 3.5 new uploader correctly errors out with (good) * 3.5 media-new.php hangs on 'Crunching' (bad) Obviously media-new.php hanging on crunching isn't desirable. That should error out." Ipstenu 22869 Large Image Uploads Don't Error Well Media 3.4 normal normal Awaiting Review defect (bug) new 2012-12-12T05:10:10Z 2013-02-02T03:29:06Z "Related to #22849 but not restricted to the new uploader. Happens on 3.4 and 3.5 in different ways. To Reproduce: Upload https://objects.dreamhost.com/ipstenu-images/sunset_2_22_11_by_kenshinkyo-d3a6slk.jpeg to your WP install in the media-new.php page Note: Image is 12600x9450 and 4.9MB Expected Outcomes: * Shared hosted without a lot of memory: Failure, not enough memory, no image uploaded. * VPS/Dedicated with tons of memory: Success Actual outcomes: * VPS as expected. * Shared not so much. You get the errors as expected however the failure is not correct. The image actually does upload, contrary to the errors, however no thumbnails are made, which then causes a memory problem as the full size image shows when you go to any media library view (in lieu of actual thumbnails). This crashed Chrome (as @markjaquith saw when we were testing Monday night) until I deleted the large images. The actual issue is on thumbnail creation, so the best 'fix' I can think of is if on failed thumbnail gen, it nukes the master image, but I don't know if that would make sense since some of the thumbnail gen might be on extra image sizes set by themes/plugins. Then again, do you want those if all fail? " Ipstenu 22862 Consider a CSS preprocessor Administration normal normal Awaiting Review feature request new 2012-12-11T22:01:36Z 2013-01-16T10:33:34Z "The WordPress admin UI CSS is woefully doomed to a life of inadequacy unless we can amenably agree to use technology already available to build a better future for us and our children. I propose the introduction of SASS for the WordPress admin styling. SASS is a CSS pre-processor that allows us to write DRY, structured, lightweight CSS. In terms of licensing, SASS is GPL-compatible, licensed under the MIT license. '''Why use SASS over LESS?''' The answer is simple. SASS is easier to learn and easier to use because it follows the conventions of CSS at its core. In addition, for developers itching to contribute, there are some extremely useful and easy-to-follow reference docs for SASS, making it easy to set up your local development environment and build websites. '''What are the advantages?''' The biggest advantage is that we can write less CSS and offer advanced features for theming the WordPress Admin UI. Developers can more easily reskin the WordPress admin. Another major benefit is that SASS offers the use of variables within our stylesheets. For our purposes, these variables can be used to calculate layout widths, generate color schemes, font sizes, etc. Another simple advantage is the fact that we can combine all our CSS styles into a single stylesheet, saving precious HTTP requests. In addition, we can easily minify generated CSS files in bundled versions of WordPress, saving file size and killing unnecessary white space, thus decreasing load times of the admin even further. '''What are the disadvantages?''' Developers will need to install Ruby and SASS in order to modify styles for the WordPress Admin. For plugin authors, we should write admin UI CSS in such a way that it is easily overridden with a custom CSS file. In addition, developers would need to learn SASS if they are going to work directly on the styles for the WordPress admin. For the most part, once you've got the idea of variables, mix-ins, and the structure - you're ready to rock. Last, but not least, when SASS files are modified, they would need to be compiled and committed to Core every time they change. So instead of pushing a single CSS file, you would be pushing potentially many SCSS files and a generated CSS file. '''In Summary''' SASS is a great way to reduce code overhead by adhering to DRY principles and will improve performance and modularity in the WordPress admin, which is a top priority." chriswallace 22860 Site list in Network Admin shows Master Site where each network site should Multisite 3.5 normal normal Awaiting Review defect (bug) new 2012-12-11T19:27:54Z 2012-12-11T19:56:49Z When in the Network Admin area, hovering on My Sites should present a list of all the active sites on the network, however, while it shows the correct number of sites, the name and links all point to the master site, and not the network sites. This behaviour is not reflected when on the child sites and acts correctly. It is only when in Network Admin. thewanderingbrit 22857 'Header Image' state isn't removed from images previously used as header image Appearance 3.4.2 normal normal Awaiting Review defect (bug) new 2012-12-11T18:54:08Z 2012-12-11T23:04:31Z "Steps to reproduce: 1. Set your site's header image from Appearance -> Header by uploading an image or choosing one from your media library. 2. Repeat step 1. 3. Visit the Media Library and note that your previous header image still says 'Header Image' next to it. Not a 3.5 regression as it happens in 3.4.2 too. " johnbillion 22854 "Rename ""Alt text for the image, e.g. “The Mona Lisa” when inserting an image" Media 3.4.2 normal normal Awaiting Review enhancement new 2012-12-11T16:00:09Z 2012-12-11T16:18:16Z "When inserting an image, a message appears under the ""Alt"" field ('''Alt text for the image, e.g. “The Mona Lisa”'''). This message is not clear. For a long time I didn't bother about it and I never completed it because I had no idea what its purpose was nor it result. Not knowing, I preferred to no change the default settings since that field is not completed by default, unlike the field ""Title"" which is completed by default. Then through internet browsing, I finally learnt that field is used by blind people in order to know about the displayed images. From there, I manually copied/pasted what was in the field ""Title"" of my almost 350 images (a one hour job). If the text displayed under the field ""Alt"" had been ""'''Alternative text to be read by our blind friends unable to see the image'''"" ('''or something of the kind'''), that would have been clearer to me and I would have completed that field as soon as I inserted my first image. Here, as it is, the text explaining that field doesn't help newbees ; it's a language for people knowing HTML (since the field names are exactly those of the img HTML tags). Also, it would be clearer for newbees not knowing HTML if the explanatory text for the field ""Title"" itself was something like: ""Displayed in a bubble when hovering the image"". The idea of all this is to tell expliciteley what fields are for, so that a person not knowing HTML can rapidly understand what they are supposed to do with them, without having to go through long searches on internet in order to understand those fields. I hope some members of the WordPress staff will consider my present comments. Best regards" luciole135 22846 Site transient autoload even when they have expiry time Performance 3.4.2 normal normal Awaiting Review defect (bug) new 2012-12-10T09:14:36Z 2013-05-13T04:40:52Z "I guess set_site_transient should set autoload to NO after calling add_site_option when there is expiration time. As far as I can see the all of the site transients right now are used only by cron and admin so no reason to auto load" mark-k 22845 On 32-bit systems, with post IDs higher than PHP_INT_MAX (2147483647) wordpress does not run fine General 3.4.2 normal normal Awaiting Review enhancement new 2012-12-10T09:13:01Z 2012-12-12T17:42:54Z "Logging all the MySQL queries I discovered that the queries that should pick my posts were all doing something like this: SELECT post_id, meta_key, meta_value FROM wp_postmeta WHERE post_id IN (2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647,2147483647) This 2147483647 number clearly has something in it: it's the PHP_INT_MAX value on 32-bit operating systems, while on 64-bit machines it's 9223372036854775807 http://php.net/manual/en/language.types.integer.php So, the problem is divided in 2 parts: I run on a 32 bit system, and I have my IDs a bit too high. I know that 2147483647 is a bit high for a post ID, but I discovered this the hard way. Now, I would have preferred an error message in the administrator interface. Do you think it's a good idea?" copesc 22844 random_seed transient is autoloaded with no reason Performance 3.4.2 normal normal Awaiting Review defect (bug) new 2012-12-10T08:55:36Z 2012-12-12T09:00:37Z "As the only use is in password/secret generation which never happens on front end this should not be auto loaded. IMO Either set an expiry time to avoid auto loading it, or make it an not auto loading option instead of transient." mark-k 22840 Uploading an existing plugin saves the zip in media library Upgrade/Install 3.4.2 normal normal Awaiting Review defect (bug) new 2012-12-09T19:35:25Z 2012-12-10T14:01:45Z "Action: Install the same plugin twice. Expected behavior: Second time, plugin should fail and not install. Actual Behavior: Install fails, but the plugin's .zip shows in the Media Library. (Shows in Site #1 on Multisite) This ''is not'' a 3.5 regression, same things happens in 3.4.2" Ipstenu 22837 "WP Needs to Set ""Sender"" and ""Reply-To"" or DKIM/DMARC will not work using wp-mail (via PHPMailer)" Mail 3.4.2 normal normal Future Release defect (bug) new 2012-12-09T17:23:48Z 2013-01-24T03:58:25Z "I notice that for DKIM to function (while using DMARC) correctly for outgoing mail the PHPMailer object needs to make sure the Sender and Reply-To fields match the ""From"" field otherwise the ""Return-Path"" header uses the server it is sending from causing a mismatch. When this happens DKIM fails authentication on the receiver side because it is not added to outgoing mail. I tried adding the reply-to and sender header manually to wp_mail() but it did not work. One had to do the following: Right now i have to manually modify the /wp-includes/pluggable.php file in the wp_mail() function to include: {{{ if (strlen($phpmailer->Sender)==0) { $phpmailer->Sender = $phpmailer->From; $phpmailer->AddReplyTo($phpmailer->From); } }}} This resolves the problem and DKIM works again. " kellogg9 22834 Live Preview should map sidebars as done on activation Appearance 3.4 normal normal Awaiting Review enhancement new 2012-12-09T12:51:00Z 2012-12-13T12:07:31Z "'''Problem:''' Sidebar disappears in the live preview after theme deactivated. '''Reproduce:''' Fresh install of the WordPress trac: 1. Activate Twenty Ten theme 2. Click the Live Preview of Twenty Twelve 3. No sidebar in the preview Bug 100%" alexvorn2 22828 Remove Duplicate Array Check Performance 3.4.2 normal normal Future Release enhancement new has-patch 2012-12-08T18:33:52Z 2012-12-08T21:22:49Z "I just stumbled across this silly bit of code in function get_core_updates() {{{ if ( !isset( $from_api->updates ) || !is_array( $from_api->updates ) ) return false; $updates = $from_api->updates; if ( !is_array( $updates ) ) return false; }}} " miqrogroove 22827 "Remove profile page ""Visual Editor"" setting right margin" Administration 3.2 normal normal Awaiting Review enhancement new has-patch 2012-12-08T16:31:58Z 2013-03-15T09:09:32Z "I assume this once has been added to align with the profile page ""Admin Color Scheme"" setting, but for consistency with other settings my request to remove it. Some screenshots: http://cl.ly/image/3t3k1w3y2Q1D/8-12-2012%2016-26-26%20ltr%20after.png [[BR]] http://cl.ly/image/420C1i1c1f2n/8-12-2012%2016-21-26%20rtl%20before.png [[BR]] http://cl.ly/image/3H3R0u080I0Q/8-12-2012%2016-25-14%20ltr%20before.png [[BR]] http://cl.ly/image/183U2g3x381I/8-12-2012%2016-21-26%20rtl%20after.png Please note this is my first patch, and thus I'll probably mess up something somewhere. Terribly sorry about that." corvannoorloos 22823 Texturize should handle apostrophes before primes Formatting 3.4.2 normal minor Future Release defect (bug) new has-patch 2012-12-08T04:48:06Z 2013-02-26T07:14:59Z "Not sure if anyone else noticed this, but my recent post on make/core exhibited an odd bug in wptexturize() — {{{ The new target for WordPress 3.5′s release is Monday }}} Note how that's a prime — `′` — rather than an apostrophe, `’`. Switching the rules seems to work without breaking any unit tests." nacin 22822 New media: 'Create a new gallery' button should indicate that it's the first of two steps Media 3.5 normal normal Awaiting Review enhancement new has-patch 2012-12-08T00:35:34Z 2013-01-22T01:57:11Z "When creating a gallery, the primary action button at the bottom of the screen says 'Create a new gallery'. This button is actually the first of two steps, but this button doesn't make that clear. It should either have an ellipsis appended, which is a standard UI convention for a non-immediate action, or it should say something like 'Next »'" johnbillion 22816 Multisite WP_Query Multisite normal major Awaiting Review feature request reopened 2012-12-07T18:25:10Z 2012-12-08T18:28:12Z Multisite has no global search functionality, and suppose I want to show on the home page of my main site posts from all the other sites in my network... I don't have a multisite wp_query functionality. Sure, I can use switch_to_blog, but that only works for results from each blog, one by one, suppose I want navigation on my results, suppose I want to make a most recent posts widget, or any type of functionality where I want to query posts from the entire multisite, custom post types, pages, all the wp_query class has to offer only works for each individual site so far, It would really help as a huge feature for WordPress multisite ciapci 22813 "Media Uploader doesn't escape ""+"" in filenames and doesn't upload file" Media 3.4.2 normal normal Awaiting Review defect (bug) new has-patch 2012-12-07T16:02:27Z 2013-04-23T03:48:58Z "I downloaded a photo this morning with filename `Screenshot+2012-12-07+at+08.55.33.png` — when I upload it in the WordPress media uploader it acts like its uploading (progress bar, crunching) but then shows a broken image as the result. 1. Upload media with ""+"" in filename 2. Observe progress bar uploading and complete the upload Expected: file is uploaded A-OK to server, attachment created, image loads as expected. Actual: no file is stored in uploads (or blogs.dir/files) directory, attachment is still created, no error, file does not exist. FWIW the filename that WordPress expects to have uploaded is `/2012/12/Screenshot+2012-12-07+at+08.55.33-150x150.png` I'm on Media Temple, running trunk as of this morning. Not sure if a regression, specific to my server configuration, etc. so more testing here would be appreciated." devinreams 22811 Make WordPress.org's links use http or https by auto-detection WordPress.org site normal normal WordPress.org defect (bug) new 2012-12-07T15:27:04Z 2013-04-15T15:34:43Z "WordPress.org's links are hardcoded to use the http protocol despite the pages also being viewable using https (which is great). This causes unwanted hassle with eg. bookmarks, showing which pages were or were not visited and so forth. An example of the steps to reproduce: 1. Go to a https URL (eg. https://wordpress.org/extend/plugins/search.php?q= with the search string appended after the ""="", this being the only way to search on WordPress.org via https as all the forms redirect to http). 2. Type anything in any of the search forms. -> A warning is shown that you're being redirected to an unencrypted page. OR 3. Go to a https URL (eg. https://wordpress.org/extend/plugins/types/ ). 4. Bookmark the page. Imagine a few months happening before the next step. 5. Click the Description tab (when browsing normally you'd click another tab in between but it's not a necessary step here). 6. You're now on a page that you haven't bookmarked. Bookmark it, because you like this page and don't remember having bookmarked a rather identical page months ago. 7. You end up having multiple bookmarks for the same pages. The fix for all these is rather easy on paper: have all links on wordpress.org that point to wordpress.org automatically use the protocol used for loading the page currently being viewed. Start with having forms' targets use this, then navigational links, and later consider either auto-converting links in page contents (eg. plugin descriptions) or mentioning the possibility of using `://` links for this next to editors." Daedalon 22810 Support for theme changelogs Themes normal normal Future Release enhancement new early 2012-12-07T14:39:22Z 2013-02-20T20:40:06Z "Plugins' changelogs are shown in the WordPress plugin repository in tabs, eg. http://wordpress.org/extend/plugins/events-manager/changelog/. Plugins' changelogs are also linked to when viewing available updates in WP-admin, so the siteadmins can know if the update could mess with their customizations. Theme changelogs are not visible in either place. They should be supported in both places. Also http://codex.wordpress.org/Theme_Review should be updated to reflect that the theme changelogs are much recommended if not mandatory to use and to specify the exact format for them. Currently it uses language that is not clear for those who don't speak English as their first language: ""In lieu of..."" and then ""...Themes are recommended to include a changelog"", which doesn't let the theme author know what format should the changelog be in. At the moment I've seen changelogs for themes in different formats, but none of them is supported. Summary of the issues: 1. Add support for theme changelogs on https://wordpress.org/extend/themes/ theme pages in tabs. 2. Add support for theme changelogs in wp-admin theme list views. 3. Clarify Theme Review codex page on the supported format(s) and use more simple English than ""in lieu of""." Daedalon 22809 Support Pale Moon browser in out-of-date dashboard widget WordPress.org site normal normal WordPress.org defect (bug) new 2012-12-07T14:28:40Z 2012-12-08T12:44:00Z "The ""Your browser is out of date!"" notification in WordPress dashboard is shown erroneusly for Pale Moon users. Pale Moon is the most popular optimized version of Firefox, and its version numbering scheme runs a bit different from the mainstream Firefox. The current version of Pale Moon http://www.palemoon.org/ is 15.3.2, which is just as up-to-date as Firefox 17.0.1. Summary of the issues: 1. The version check should be done against Pale Moon version number instead of Firefox version number. 2. The text and links should refer to update Pale Moon instead of Firefox." Daedalon 22807 Updating a non-expiring transient with a new expiry date does not make it expire General 3.4.2 normal normal Awaiting Review defect (bug) new 2012-12-07T11:38:18Z 2012-12-07T11:38:18Z "Consider this: set_transient( 'Bug', 'v1'); set_transient( 'Bug', 'v2', 10 ); The second line will update 'Bug' with 'v2', but will not set autoload to 'no'. Hence, 'Bug' does never expire, and you can get its value 'v2' infinitely using echo get_transient( 'Bug' );" bersbers 22805 Add a hook for the live theme preview event Themes 3.4.2 normal normal Awaiting Review enhancement new 2012-12-07T11:19:52Z 2013-01-17T23:42:52Z "We have a hook for theme activation and deactivation, but for the theme live preview - not... " alexvorn2 22801 Update documentation on wp_insert_term to state that it will return an error if inserting an existing term. Inline Docs normal normal Awaiting Review defect (bug) new 2012-12-07T04:51:53Z 2012-12-07T04:51:53Z "phpdoc for wp_insert_term() states: If both the term id and taxonomy exist previously, then an array will be returned that contains the term id and the contents of what is returned. However it returns an error object instead. That may have changed with #13481. Anyway, returning an error seems to be an acceptable solution. Although, #16567 might change that a bit. Should we just adjust the docs to fit the current behavior?" lgedeon 22798 "Invalid URLs not giving 404 with ""Default"" permalink settings" Rewrite Rules 3.4.2 normal normal Awaiting Review enhancement new 2012-12-06T23:39:35Z 2012-12-07T03:25:50Z "'''Steps to reproduce:''' - Set up Wordpress with the default .htaccess - Select the ""Default"" option under Permalink Settings - Enter an invalid URL eg 'http://blogroot.com/garlbeflax.abc' '''Expected Behaviour:''' - 404 page is displayed '''Observed Behaviour:''' - No 404 page is ever shown, no matter what the request string is - Instead, Wordpress behaves as if no path was requested, eg displaying the homepage/posts lists. - If requested url has any of the standard params in it, those params ARE executed, eg http://blogroot.com/foo?paged=2 would properly show the 2nd page of the posts. '''Suspected cause:''' In line 620 of wp-includes/class-wp.php (in WP->parse_request), there is a conditional which means the only time the request can be marked as a 404 error is if the array of rewrite rules is NOT empty: {{{ $rewrite = $wp_rewrite->wp_rewrite_rules(); if ( ! empty($rewrite) ) { ... }}} If the ""Default"" permalink is selected, and no other rewrite rules are set up elsewhere (for reasons I didn't investigate, adding a add_rewrite_rule to the theme didn't affect anything), then the $rewrite array IS empty and the request can not be checked to see if it's a 404. Therefore, execution of the request continues as if no path info were submitted. This prevents the showing of the theme's 404 page, and can get a website flagged as spam/exploitative in Google's index. '''Workaround:''' Define a permalink redirect (eg pick one of the options other than Default). Server info: {{{ Apache/2.2.16 (Debian) (w/ mod_rewrite) PHP Version 5.3.3-7+squeeze3 (mod_php5) }}} .htaccess contents: {{{ RewriteEngine On RewriteBase / RewriteRule ^index\.php$ - [L] RewriteCond %{REQUEST_FILENAME} !-f RewriteCond %{REQUEST_FILENAME} !-d RewriteRule . /index.php [L] }}}" vanchuck 22795 TinyMCE does not recognize finger selections in WIndows 8 / MSIE 10 TinyMCE normal normal Awaiting Review defect (bug) new 2012-12-06T19:24:16Z 2012-12-06T20:07:14Z "MSIE 10 (and/or Windows 8) seems to treat finger selection and mouse/keyboard selections differently. A symptom of this can been seen in the attached screenshots, when selecting text in visual mode with one's fingers vs a keyboard or standard mouse. When selected via iOS style gestures, TinyMCE does not recognize the text as selected, and therefore does not let the user insert a link (note how the link tool is disabled). When selected via the mouse or kb, all is well. Everything also works fine with touch, mouse and kb when in text mode, pointing to an issue in TinyMCE. Screenshots were taken while running core trunk, r23108 This might be affecting more versions of MSIE, or different contexts. We've recently seen similar reports from users on WordPress.com. " stephdau 22794 Theme screenshots scaling breakpoint should be different when admin menu is collapsed Themes 3.4 normal normal Future Release enhancement new 2012-12-06T19:14:10Z 2012-12-06T19:14:20Z "The goal of the breakpoint was to ensure we had 3 themes across. When the admin menu is collapsed, we get an extra 100+ pixels to work with. This means we should adjust our 1200px breakpoint to something less." nacin 22793 Image Editor is jumpy when opening. Media 2.9 normal minor Awaiting Review defect (bug) new has-patch 2012-12-06T18:52:37Z 2012-12-06T19:58:08Z "When clicking Edit Image in the attachment editor, there is a flickering - that is, the new stuff gets added to the page before the old stuff has been completely removed, so there is a fraction of a second when the page gets pushed down. Simple fix. Patch included ( hopefully i created the patch correctly this time :p )" eddiemoya 22792 Cannot change name attribute of comment submit button Comments 3.4.2 normal normal Awaiting Review defect (bug) new 2012-12-06T17:03:01Z 2012-12-06T17:20:24Z "This prevents developers from using client-side validation, as the name attribute being set to ""submit"" interferes with the .submit() method. I can change the id and the label of the submit button, but that is all. The default WordPress server-side validation is unacceptable from a user-experience standpoint. This would be the solution for me, which I find cumbersome (http://wordpress.stackexchange.com/questions/65001/error-when-posting-comment-form-the-error-is-typeerror-eh-is-not-a-function). The developer should be allowed to set the name attribute of the submit button (maybe through the use of comment_form())." willi828 22785 Gallery placeholder buttons sometimes appear overlaid on the wrong editor Media 3.4.2 normal normal Awaiting Review defect (bug) new 2012-12-06T08:24:12Z 2012-12-14T23:32:53Z "If you have multiple visual editors on a screen, the edit/remove buttons that overlay on the gallery placeholder can appear in the right position, but in the wrong editor. If you click the edit button that appeared in the wrong place, the new-to-3.5 media modal shows the image set for the previously clicked placeholder. To reproduce: * Enable a second editor. Code (`edit_form_after_editor` is new to 3.5): {{{ add_action( 'edit_form_after_editor', 'hhs_edit_form_after_editor' ); function hhs_edit_form_after_editor() { wp_editor( '', 'hhs_test_editor' ); } }}} * Insert a gallery or two into one of the editors. * Click inside the editor without the galleries. * Single click a gallery placeholder in the other. Note that the buttons appear overlaid on the gallery-less editor. Double clicking a placeholder will bring the buttons to the right place. Clicking within the same editor instance keeps the buttons in the right place. It seems specific to clicking a placeholder in an editor that did not previously have focus, including on page load. On page load, clicking a placeholder in the first (top) editor seems to show the buttons in the lower editor, whereas clicking a placeholder in the lower editor works just fine. Reproduced in 3.4.2. Probably goes back farther. It probably wouldn't have been noticed in 3.4.2 since the old modal wouldn't have displayed much of anything differently." helen 22781 setUserSetting cannot handle hyphens General 2.7 normal normal Future Release defect (bug) new early 2012-12-06T06:18:39Z 2012-12-06T18:25:43Z "sanitize_key() can, setUserSetting should be able to as well. It's not that sanitize_key() plays a role, but it sets expectations for what is allowed in keys across core. Both keys and values should be able to accept a hyphen. The post-thumbnail image size cannot be remembered, for example, if it is added to image_size_names_choose." nacin 22773 """Gallery Settings"" should be extensible" Gallery 3.5 normal minor Awaiting Review enhancement new 2012-12-06T03:17:19Z 2013-01-06T02:29:57Z "This isn't necessarily new to 3.5, but now that we have a great gallery management system, I think we need to allow developers to customize the Gallery Settings fields (other than Link To / Columns / Random). My specific use - which I think is common - is a completely custom gallery shortcode for a client. First and foremost, the client would like to be able to ""title"" the gallery itself, so a hook allowing the addition of custom field(s) would be needed. Ideally, the default fields would also be filterable so they can be removed as well (though I suppose we can do that with CSS now): for instance, most custom gallery implementations don't use the ""columns"" option." jakemgold 22772 Introduce HOMEPATH Filesystem 3.5 normal normal Awaiting Review enhancement new 2012-12-06T03:05:42Z 2013-03-03T20:23:48Z "I was poking around with get_home_path() and wondering if there's any reason to not set a constant HOMEPATH (like ABSPATH) in the root index.php I'd seem to be more reliable then get_home_path() and that function could simply return the new constant. get_home_path has it's origins 8 years ago when the code was very different: [1567]" WraithKenny 22770 Tweak Browse Happy so it doesn't jump the gun with out-of-date browser messages WordPress.org site normal normal WordPress.org defect (bug) new 2012-12-06T01:28:44Z 2012-12-06T06:44:20Z "Browse Happy is a useful tool for encouraging WordPress users to keep their browsers current. However, sometimes Browse Happy jumps the gun. For instance, on GNU/Linux distributions like Ubuntu, users can choose to install Chromium directly from the repository (as opposed to downloading Chrome from Google's site). Chromium, when installed this way, is kept up to date by the operating system's package management tool, not manually. Users receive notifications from their operating system prompting them to upgrade when new versions of the browser are available. It makes no sense to show a Chromium user a ""your browser is out of date"" message when their browser is, in fact, up to date - as provided by their distribution. Unfortunately, that is what it happening now. Similarly, Microsoft has not yet released Internet Explorer 10 for Windows 7, so it is not appropriate to tell users of IE9 that their browser is out of date. IE10 is available for Windows 7, but only as a release preview - similar to a WordPress release candidate. We wouldn't prompt users to upgrade their production WordPress installations to a release candidate, so why is Browse Happy telling Windows 7 IE users to upgrade to IE10 when the final version of IE10 has yet to be released? Browse Happy should be tweaked so it does not jump the gun with out-of-date browser messages before browsers are really out of date. Users should only get a prompt to upgrade if there is in fact a newer version of their web browser available to them that is out of beta and suitable for production use." avcascade 22768 EXIF/IPTC captions should populate caption/post_excerpt on upload, not description/post_content Media 2.5 normal normal Future Release enhancement new early 2012-12-06T00:24:39Z 2012-12-15T20:10:37Z "It's been this way forever, but it is dumping data into the wrong field. Two schools of thought on this: * Plugins have used the description field, so we should not change this. * Users continue to struggle with moving *captions* from the description field to the caption field, so we should change this. I am in the latter school of thought. A plugin can remain compatible by ensuring it checks either description or caption before falling back to the other." nacin 22746 The metadata_exists() function should return the correct value if the get_$meta_type_metadata filter returns a non null value General normal normal Awaiting Review defect (bug) new 2012-12-05T00:04:20Z 2012-12-05T00:04:20Z "The line [http://core.trac.wordpress.org/browser/trunk/wp-includes/meta.php?rev=23043#L324 324] should return $check instead of true, otherwise the filter doesn't normally work when someone wants to always return false for a given meta key. Here's a quick way to reproduce it {{{ > add_filter('get_user_metadata', '__return_false'); return metadata_exists('user', 1, 1) TRUE }}}" xknown 22745 Missing number_format_i18n() on term counts I18N 2.1 normal minor Awaiting Review defect (bug) new has-patch 2012-12-04T23:51:06Z 2012-12-04T23:52:00Z The `Walker_Category` and `Walker_CategoryDropdown` classes output term counts as-is. They should be wrapped in `number_format_i18n()`. johnbillion 22744 Media search doesn't include file name Media 3.0 normal normal Future Release enhancement new 2012-12-04T22:56:45Z 2012-12-29T10:37:30Z "Upload a file called `foo.png` and then do a search for `foo.png` (either on the Media screen or in the new media modal) and it won't find the file. Probably existed since forever. Marking as 3.0." johnbillion 22742 Fix feed inefficiencies - Possibly Extend Etag/Last-Modified/Conditional Get functionality Performance 3.4.2 normal normal Awaiting Review enhancement new 2012-12-04T21:25:20Z 2012-12-04T21:36:32Z "'''First the story.''' Attempting to generate what are effectively feeds on our WP site, we've been using the WP rewrite functions in a page/template context for some time, but recently it's made more sense to use the feed context for this. It seems as if there is some liability to using pages--requires a page to be created and not changed by non-dev users and requires a coordinated database and code solution to create. And it introduces some complexity/mess with creating template files for feed logic/display, and again, these dummy pages have to exist. Finally--assigning this feed to a page required the WP URL canonical functionality to occur, so I couldn't use ""feed.json"", I had to use ""feed.json/"" which is just not cool. An entirely code-based solution that effectively rewrites a URL pattern to a function is perfect--which is effectively what the feed context is. As an aside--for my purposes could I use actual Apache rewrites? Well sure, but I am using WP functions to retrieve the data for my feed--in which case I would have to separately bootstrap my function, and I would assume incur fairly similar performance implications. Also, adding a feed still feels like something that should be code-addressable to me and rolling rewrites to all of our production web servers isn't necessarily fun. I'll be benchmarking this and get back to you though. In my page->feed conversion, I was curious what the performance implications were. I figured with less files and functions (related to the theme layer) involved, it could only be better using a feed. Not so, it was worse at about 5x to run the same feed creating logic. I sat down with xdebug and query logging to figure out what was going on and found that there were a few extra queries being run on the feed side: {{{ SELECT post_modified_gmt FROM wp_posts WHERE post_status = 'publish' AND post_type IN ('post', 'page', 'attachment', 'story') ORDER BY post_modified_gmt DESC LIMIT 1; SELECT post_date_gmt FROM wp_posts WHERE post_status = 'publish' AND post_type IN ('post', 'page', 'attachment', 'story') ORDER BY post_date_gmt DESC LIMIT 1; SELECT SQL_CALC_FOUND_ROWS wp_posts.ID FROM wp_posts WHERE 1=1 AND wp_posts.post_type = 'post' AND (wp_posts.post_status = 'publish' OR wp_posts.post_status = 'private') ORDER BY wp_posts.post_date DESC LIMIT 0, 50; SELECT FOUND_ROWS(); }}} These are coming from a branch in /wp-includes/class-wp.php WP::send_headers(). It's doing very basic logic to determine via the query string if we expect this request to be a feed, then it uses either ''get_lastcommentmodified()'' or ''get_lastpostmodified()'' and uses the result of that to set and send some headers for last modified and etag, and evaluate request values for conditional get (304) responses. '''The problem:''' For my application--creating arbitrary feeds actually based on WP options--the last time any post or comment was updated/added has no correlation to my feed. It may not be updated at the point a post is updated, but it would show as being updated--more dangerously, it would show as not being updated and return a 304 if a post hasn't been updated. Also, it's incurring overhead doing this lookup that has absolutely no value. How about the most common WP core uses? I'm thinking it's still going to result in a lot of false positives (saying it's updated more recently than it really is) that certainly is going to depend on number of post types, but even with say a default install with pages and posts, any time a page is updated (which is not in any default feed), it will be affecting the default posts feed. There is no hook to allow for the disabling or changing of this logic. And, there is no way to apply some form of this logic to heavier page generations that might be kind of nice. '''The options:''' 1. Add a hook to this send headers function that would allow it to be fully disabled for certain feeds. 2. Move the functionality to a discrete function that can be passed the actual page/feed updated time and it can then send the proper headers. Then the default feed generation functions can call back to this functionality when they know the actual updated dates. I actually favor the latter--this is kinda nice functionality that is trapped inside a less useful branch and is ""stuck on"" even when it's not helpful. I would be happy to help write a patch for some of this if some core people can jump on here and provide some direction and blessing. '''I've noticed a little discussion on this issue elsewhere:''' #19466 - This person is attempting to apply the existing logic--page/comment last modified across every request which would be a massive mistake. Assuming that's why there has been no response. #15499 - This person is suggesting an index to get the results quicker--that could be beneficial additionally, but perhaps my modifications could reduce the need for such an index." brokentone 22739 wp_register_script/wp_enqueue_script problem General 3.4.2 normal minor Awaiting Review defect (bug) new reporter-feedback 2012-12-04T18:51:01Z 2013-01-16T04:27:53Z "First of all: sorry for my bad English. Hi, i've seen may be a bug while programming a plugin (Len Slider). I have some handle-scripts like jquery, jquery-ui to enqueue, its ok. Also I have my known js-files to enqueue, ok too. BUT! When I want to enqueue dynamic js (gets from folders via glob), it enqueue too BUT BEFORE jquery, jquery-ui itc. When I enqueue script with custom handle and in foreach loop, BUT with deps parameter as array of jquery, jquery-ui etc. And this dynamic js-file loads BEFORE jquery or jquery-ui! Now I solve the problem by load known handles jquery, jquery-ui in header and my own in footer, but i think we need to look for core to solve it. You can see it on Len Slider in len-slider/lib/lenslider.class.php:313 - lenslider_make_skins_files_wp_head method Also I think about parameter like priority for wp_register_script/wp_enqueue_script(style) functions to load it by this range." tigusigalpa 22736 Outdated plugins marked as 'Works' for the current version should show in search results WordPress.org site normal normal WordPress.org feature request new 2012-12-04T18:11:57Z 2013-01-06T02:35:09Z "When a plugin hasn't been updated in over 2 years, it gets the ""this is outdated"" message on WP.org and it no longer shows up in plugin search results from the Dashboard. But if the plugin is marked as ""Works"" for the current version - even though it hasn't been updated in 2 years - we should make it so it shows up in search results." DrewAPicture 22735 A given pointer should only show once on a screen Administration normal normal Awaiting Review defect (bug) new 2012-12-04T18:10:44Z 2012-12-14T23:51:42Z If you have, say, multiple media buttons on a screen, you'll get multiple pointers, each pointing to an instance of that button. This shouldn't happen. In the case of the media button, it should probably only show up for the one associated with the main editor. In terms of the pointers in general, it should only show up once, not for each match in the DOM. helen 22734 do_action-post_edit_form_tag Administration 3.4.2 normal normal Awaiting Review feature request new reporter-feedback 2012-12-04T18:01:27Z 2012-12-04T18:21:12Z "Possible to add an action on the form for adding media. {{{ File : /wp-admin/media.php Line : 115 }}} {{{ }}} to {{{ > }}}" bems78 22726 New Media: 'From URL' tab should move Media 3.5 normal normal Awaiting Review enhancement new 2012-12-04T11:36:57Z 2012-12-07T00:15:18Z "Should the 'From URL' tab on the left hand side of the new media modal should be moved into the same tab group as 'Upload Files' and 'Media Library' across the top? It makes no sense in the context of the other tabs on the left, 'Insert Media', 'Create Gallery' and 'Featured Image'." johnbillion 22712 Admin using deprecated valign attribute Validation 3.4.2 normal normal Future Release defect (bug) new has-patch 2012-12-04T06:54:10Z 2013-01-18T23:38:46Z "Hi, I noticed when I validated one of my plugins' admin pages, I received approx. 40 error messages regarding the use of ""v-align:top;"" within the css structure. (Please see attached screenshot) Is there a way to use a different css to target these elements instead of the deprecated v-align usage? Thanks!" josh401 22704 Automatic Core Updates pento Upgrade/Install 3.5 normal normal Awaiting Review feature request assigned dev-feedback 2012-12-03T22:05:04Z 2013-01-14T18:12:02Z "It's time to think about automatic updates for WordPress Core. Plugins and Themes are a totally different ball game, so it's probably best to leave them for the moment. Currently, I'm thinking it would be a good idea to release this in stages (some of which may be combined, just spelling them out): - SVN updates in trunk installs - SVN updates in branch installs - Opt-in updates in stable installs - Opt-out updates in fresh installs - Opt-out updates in all installs - Remove option for opting out I'd like to see SVN updates go into 3.6 early, so we can quickly get a good idea of compatibility issues that we're likely to run into when we get to beta. Finally, are there any features we should be looking at adding to the upgrader for this? More sanity checking, notifications, other?" pento 22701 Allow the use of SITEURL and HOME constants for Multisite Installations Multisite normal normal Awaiting Review enhancement reopened 2012-12-03T21:21:26Z 2012-12-03T22:02:13Z "This is a proposal to allow the use of the SITEURL and HOME constants, as we do with single site installations. My proposal would be to follow the naming conventions put forward by the database schema for multisite installations. Example for a constant override of the siteurl and home option for blog_id 3. {{{ #!php define('WP_3_SITEURL', 'http://example.com'); define('WP_3_HOME', 'http://example.com/wp'); }}} " jondavidjohn 22700 Walker_Category_Checklist should sometimes set the value as the term name Administration 3.0 normal normal Awaiting Review defect (bug) new dev-feedback 2012-12-03T19:45:57Z 2013-02-19T05:12:08Z "The `Walker_Category_Checklist` class has been partially adapted to work with taxonomies other than `category`, but it does not seem to cope with non-hierachical taxonomies. For non-hierachical taxonomies, the HTML form elements (checkboxes, radios, dropdowns, whatever) need to set the term **name** as the value, not the ID… otherwise WordPress will cast the ID to a string and create a new term with that string as a name. To see the problem: * Use `Walker_Category_Checklist` to create a checkbox in a metabox on the post edit screen for a non-hierarchical taxonomy * Add some terms to the taxonomy * Check the box for the taxonomy and update the post * Watch a new term appear with its name set to the ID of the term you checked " simonwheatley 22694 Uploading File with Apostrophe in filename Media 3.4.2 normal normal Awaiting Review defect (bug) new 2012-12-03T11:33:20Z 2012-12-03T14:40:31Z "When uploading a file with an apostrophe in the filename wordpress returns a 'HTTP Error' message. I have replicated this on two separate installs of wordpress, on different LAMP hosting environments. The filename used for testing was Trend_Forecaster's_Handbook_1.jpg" ianatkins 22683 Don't load advanced-cache.php when running via CLI Cache normal normal Awaiting Review defect (bug) new has-patch 2012-12-02T18:46:48Z 2012-12-03T20:05:29Z "When you're loading WP via a command-line program, it doesn't make much sense for a plugin like WP Super Cache to take over. It's not like you have thousands of CLI users hammering the install. Example issue in wp-cli: https://github.com/wp-cli/wp-cli/issues/164" scribu 22682 Close Button Breaks in Customizer After Refresh Accessibility 3.5 low minor Future Release defect (bug) new 2012-12-02T17:10:01Z 2012-12-04T04:43:17Z "Steps to reproduce (keyboard only): 1. Open the theme customizer. 1. Tab past the top buttons. 1. Press F5. 1. Now try to use the Close or Cancel button. Expected result: Should be able to Close or Cancel. Actual result: The button can still be clicked, but it is broken for keyboard usage. Found in 3.5-RC2-22961 using Chrome 23 and WinXP." miqrogroove 22679 Ensure that unattached images inserted from media library get pretty url directly Media 3.5 normal normal Awaiting Review enhancement new has-patch 2012-12-02T11:24:19Z 2012-12-02T22:13:17Z "When inserting an unattached image (with no parent) from the media library and setting the ""Link To"" option to ""Attachment page"", the URL at first gets the default query string format (with a '?'). Though after updating the post it gets the final ""pretty"" format (which seems to happen in the function _fix_attachment_links() in wp-admin/includes/post.php). The provided patch, gives the URL the final pretty format directly. See also #22085." jond3r 22671 "Attachment pages 404 for media attached to an ""Auto Draft""" Media 3.4.2 normal normal Awaiting Review defect (bug) new close 2012-12-01T02:50:25Z 2012-12-02T01:17:42Z "Any image uploaded to a new post through the post editor or QuickPress has a broken View link in the Media Library. To reproduce: 1. Go to Dashboard. 1. Upload an image in QuickPress. 1. Go to Media Library. 1. Click the View link for the image. Expected result: I thought it was going to show me the image or the image's attachment page. Actual result: ""This is somewhat embarrassing, isn't it?"" - 404 message from URL like /?attachment_id=112 This won't happen if the image is uploaded via the Upload New Media page." miqrogroove 22670 Konami Code Easter Egg to trigger new Media model Media low normal Awaiting Review enhancement new 2012-12-01T02:41:23Z 2012-12-11T17:31:43Z "Just a harmless easter egg that will trigger 3.5's media uploader via the post editor page. It'd be a fun touch, imho. To trigger, just use your keyboard and press, in order, up up down down left right left right B A" tw2113 22669 iPad: Can't Scroll Plugins Modal Administration 3.4.2 normal normal Awaiting Review defect (bug) new 2012-12-01T02:31:23Z 2012-12-02T01:43:48Z "Steps to reproduce: 1. Tap Plugins 1. Tap Add New 1. Tap Featured 1. On any item, tap Details. 1. Tap Changelog 1. Swipe to scroll Expected result: See more Changelog. Actual result: The page is scrolling around behind the modal. Modal not scrolling. Related: #22064" miqrogroove 22663 Performing a non-square rotate() with Imagick, then cropping, can result in incorrect Image Media 3.5 normal minor Future Release defect (bug) new commit 2012-11-30T22:49:42Z 2013-05-07T20:38:29Z "Note: This is only for *some* recent versions of ImageMagick. Older ones seem to be a bit more sane, and work fine without any patch whatsoever. When ImageMagick performs certain operations, it sets its virtual page's x/y origin values to non-zero numbers and leaves them there, which can break some further operations that depend on the virtual page. In this case, when rotating in non 90 degree increments, Imagick doesn't set the x/y, which means that core doesn't run into this bug, since the built-in image editor only allows for 90 degree rotates in either direction. However, if you're a user of the API, and perform a ""non-square"" rotate, then a crop, you could end up with an image result that differs from what you'll get from GD. There are two ways of fixing this: - Update the virtual page with each update_size() - Update the virtual page immediately after a rotate() only The first is what I think we should land on eventually, because it will prevent plugins' methods from breaking core's accidentally (if they do not reset the page's values). However, that would require an additional error message to be added, which means a new string. The second would fix the bug for anything core's APIs would do, but would depend on plugins handling resetting the page values appropriately in their own methods. It is, however, a bit safer (and wouldn't require a string change), if this is something that might land for 3.5. I've attached patches for each method." DH-Shredder 22661 Allow object caches to degrade gracefully Cache normal normal Awaiting Review defect (bug) new 2012-11-30T20:53:57Z 2013-01-10T00:08:36Z "Because of the way object caches are loaded, if a custom object cache can't run (say, Memcached or APC is not actually installed), it cannot gracefully degrade to the built-in object cache. Witness this code in {{{wp_start_object_cache()}}}: {{{ if ( ! function_exists( 'wp_cache_init' ) ) { if ( file_exists( WP_CONTENT_DIR . '/object-cache.php' ) ) { require_once ( WP_CONTENT_DIR . '/object-cache.php' ); $_wp_using_ext_object_cache = true; } else { require_once ( ABSPATH . WPINC . '/cache.php' ); $_wp_using_ext_object_cache = false; } $first_init = true; } else if ( !$_wp_using_ext_object_cache && file_exists( WP_CONTENT_DIR . '/object-cache.php' ) ) { // Sometimes advanced-cache.php can load object-cache.php before it is loaded here. // This breaks the function_exists check above and can result in $_wp_using_ext_object_cache // being set incorrectly. Double check if an external cache exists. $_wp_using_ext_object_cache = true; } }}} So a custom object cache is loaded. If it wants to bail and defer to the built in object caching, it can do that by doing the include itself. But then WordPress sets {{{$_wp_using_ext_object_cache = true;}}} '''after''' that require. So WordPress thinks it is using an external object cache when it's actually not. This leads to oddness. This can sometimes be hacked around by adding a callback to the very first WP action available that sets {{{$_wp_using_ext_object_cache = false;}}}, but that has issues: calls to the object cache might be made before that code can run, and {{{add_action()}}} is not always available at that point (because some {{{advanced-cache.php}}} drop-ins load the object cache really early. See Batcache. Proposed solution: change the order of the {{{require_once()}}} and the setting of {{{$_wp_using_ext_object_cache}}}. That way, the external object cache can override the variable." markjaquith 22660 "Admin bar in multisite: mobile tap on ""My Sites"" dropdown in back-end doesn't work" Toolbar 3.4.2 normal normal Awaiting Review defect (bug) new 2012-11-30T20:40:17Z 2012-12-21T00:33:39Z "Quick steps here to reproduce an issue where the ""My Sites"" dropdown (multisite networks) will drop down and show the ""Network Admin"" link and the list of your sites. But, clicking on a site (to expand and see ""Dashboard"", ""New Post"", etc.) does not happen. Tapping the blog name just closes the dropdown. I'm not sure what's different but I can consistently reproduce this when in the admin back-end (but works OK on front-end admin bar when viewing a site): From /wp-admin/ on a mobile device (tested on iOS 6, iPhone 5, iPad) with a multisite network: 1. Tap ""My Sites"" in admin bar 2. See ""Network Admin"" and list of sites below 3. Tap one one of the site names Expected: Site name expands to show ""Dashboard"", ""New Post"", etc. (same behavior as front-end when viewing site). Screenshot: http://d.pr/i/reOi Actual: Tapping site name simply closes the ""My Sites"" dropdown, does not browse anywhere nor expand menu" devinreams 22650 Filter the Gravatars on credits.php Administration normal normal Awaiting Review enhancement new has-patch 2012-11-30T08:39:58Z 2012-11-30T08:51:59Z "All Gravatars should be generated by get_avatar() or at least run through apply_filters('get_avatar', $avatar) for the sake of extensibility. Related: #22329" miqrogroove 22649 iPad: Media Modal Problem Editing Long Values azaozz Media 3.5 low normal Future Release defect (bug) assigned has-patch 2012-11-30T07:40:36Z 2012-12-04T18:06:24Z "In Brief: When I try to edit a very long image title (uploaded file name) the media modal window jumps around and I can't see what I'm editing. Steps to Reproduce: 1. On Dashboard, tap Add Media. 1. If necessary, upload an image with an obnoxiously long filename, such as a friend's photo from Facebook. 1. Select an image in the Media Library tab that has an obnoxiously long title. 1. Tap the title field. Cursor should appear at right end of value and visual keyboard should open. 1. Tap the backspace key. Expected Result: Plain text editing. Actual result: Media Library moves off screen. Found in 3.5-RC2-22944. Screen shot coming momentarily." miqrogroove 22648 No error reporting for failed upload of background image in theme customizer Media 3.4 normal normal Future Release defect (bug) new 2012-11-30T00:54:48Z 2013-01-24T22:27:49Z "I tried uploading a background image using the theme cusomizer in 3.5 RC2 but nothing happened. After a few more tries I worked out that there was a problem uploading the file but WordPress didn't inform me of this, which it should. It was only once I'd looked at the response from async-upload.php that I realised there even was a problem. {{{ filename: ""Screen Shot 2012-11-28 at 17.50.55.png"" message: ""Unable to create directory wp-content/uploads/2012/11. Is its parent directory writable by the server?"" success: false }}} " WPsites 22641 Request: include post_id on media_send_to_editor filter call in wp_ajax_send_attachment_to_editor Media 2.6 normal minor Awaiting Review enhancement new 2012-11-29T20:44:58Z 2012-12-02T15:37:53Z "Before 3.5, by combining some hidden fields on the add media popup (using attachment_fields_to_edit) and then looking for those fields in $attachment in the media_send_to_editor filter, you could alter the $html sent back to the editor on a per custom post type basis. Here's a pre 3.5 tutorial on what I'm on about: http://shibashake.com/wordpress-theme/how-to-hook-into-the-media-upload-popup-interface - The relevant part is in step 4, ""Set Our Own Action"". Because recent changes mean that the fields added by attachment_fields_to_edit are posted separately (""save-attachment-compat""), there's no way to identify the custom post type when hooking into the media_send_to_editor filter. In wp_ajax_send_attachment_to_editor(), is there any reason we couldn't also include $_POST['post_id'] with the ""media_send_to_editor"" filter? e.g. {{{ $html = apply_filters( 'media_send_to_editor', $html, $id, $attachment, $_POST['post_id']); }}} I'm new to WP, but I would've thought that wouldn't break anything because of the way most filter hooks will only look for params 1-3. Thanks, Adrian" adrianhardy 22635 comments made on iPad get the comment_author_url removed in the pre_comment_author_url filter Comments 3.4.2 normal major Awaiting Review defect (bug) new 2012-11-29T14:21:04Z 2012-11-29T22:18:48Z "I have tested this on version (3.5-RC1-22909) nightly build too. if I submit a comment with a valid author url using the iPad then the URL gets removed by the pre_comment_author_url filter in wp-includes/comment.php '''works''' * windows 7 works fine * windows xp works fine * debian box works fine * macbook pro works fine '''Not working''' * iphone ios 5.1.1 * ipad ios 5.1.1 duplicable on local, live and someone elses site. I can see the POST vars show all the proper data. in wp-includes/comment.php the wp_filter_comment function the `$commentdata['comment_author_url']` exists before {{{ $commentdata['comment_author_url'] = apply_filters('pre_comment_author_url', $commentdata['comment_author_url']); }}} (line 1291 of wp-includes/comment.php (3.4.2) but is gone after the filter has been applied, this happens only if using an ipad or iphone. " commentluv 22633 Update Icon Inconsistency Administration normal normal Awaiting Review enhancement new 2012-11-29T11:37:57Z 2012-11-29T14:44:27Z "The update icon at the moment is 2 arrows in a circle in the admin bar ( aka the refresh icon ). In Network Admin it's a pair of tools. I'd suggest we change these to the same icon rather than have 2 inconsistent icons. I'd also suggest we use a single arrow as the new icon, a refresh/recycle icon isn't as clearcut as it could be ( and what if a caching plugin implements a refresh button to the admin bar? ). We could follow Google by using an arrow pointing upwards, or we could follow Apples convention with a downwards pointing arrow in a circle" TJNowell 22631 Allow change of dropins folder General 3.5 normal normal Awaiting Review enhancement new 2012-11-29T07:02:44Z 2012-11-29T15:44:06Z "Dropins are stored in the `wp-content` directory. Currently there is no way to alter this (short of editing core code). The `get_dropins()` function does not utilize filters or predefined constants in any way. Probably the best method here would be to define `WP_DROPINS_DIR` constant in `/wp-includes/default-constants.php` that can be overridden in wp-config.php." bungeshea 22630 plugin_basename() fails on case-sensitive plugin directories General 1.5 normal minor Awaiting Review defect (bug) new 2012-11-29T06:11:13Z 2012-11-29T17:06:49Z "When `WP_PLUGIN_DIR` has slightly different casing to the actual path, `plugin_basename()` returns the full path to the plugin file. For example: If `WP_PLUGIN_DIR` is set to `C:/Website/wp-content/plugins`, but the actual file-system path is `C:/Website/wp-content/Plugins`, `plugin_basename()` will return the full path to the plugin file. The `plugin_basename()` function uses a `preg_replace` statement to find path to the plugin relative from `WP_PLUGIN_DIR`. If the actual path to the plugin directory does not match case to `WP_PLUGIN_DIR`, the preg_replace will fail. This is because preg_replace is not case sensitive." bungeshea 22625 Lone less than (<) characters foul up balanceTags() General normal normal Awaiting Review defect (bug) new has-patch 2012-11-28T22:47:23Z 2012-12-11T20:34:57Z "1. Turn on tag balancing. 2. Try this text: {{{ This is < That. foo Text link. Post-link text. }}} 3. On save, the ending blockquote tag is stripped, and the subsequent text is blockquoted. We should recognize lone {{{<}}} characters and entity encode them like we do for {{{<3}}}." markjaquith 22624 New current_user_has_role function to work for roles like current_user_can does for caps Users normal normal Awaiting Review feature request new 2012-11-28T22:11:49Z 2012-11-28T23:14:31Z "current_user_can( 'capability' ) is great, but it would save some code and be more reliable if we had something like this for roles as a global function that's easy to get at: current_user_role( 'editor' ) would return true if the user has the editor role, false if they weren't. I'll work on a patch for this when I get a moment, this is just here to remind me and let others know what I'm thinking." sc0ttkclark 22619 add_rewrite_endpoint generates incorrect attachment rules Rewrite Rules normal normal Awaiting Review defect (bug) new 2012-11-28T08:47:43Z 2013-05-15T17:31:34Z "{{{add_rewrite_endpoint}}} with {{{EP_ALL}}} or {{{EP_ATTACHMENT}}} results in incorrect endpoint matches. The index set for the endpoint value is {{{2}}} which ends up returning the slash as well. The index should actually be {{{3}}} since we only care about the inner match. Example: {{{add_rewrite_endpoint( 'my-endpoint', EP_ALL )}}} Results in rules like (dump from {{{$wp_rewrite->generate_rules}}}: {{{ '.?.+?/([^/]+)/my-endpoint(/(.*))?/?$' => string(35) ""index.php?attachment=$1&my-endpoint=$2"" '.?.+?/attachment/([^/]+)/my-endpoint(/(.*))?/?$' => string(35) ""index.php?attachment=$1&my-endpoint=$2"" }}} Visiting a {{{my-endpoint}}} URL for an attachment like {{{/2012/01/01/post-name/attachment/my-endpoint/foo/}}} will return the value of {{{get_query_var( 'my-endpoint' )}}} as {{{/foo}}} instead of {{{foo}}}." batmoo 22612 Filterable default for wp_safe_redirect/wp_validate_redirect General normal normal Awaiting Review enhancement new 2012-11-27T21:00:22Z 2012-11-29T18:06:41Z The default/fallback for {{{wp_safe_redirect}}} is {{{admin_url()}}}. It would be nice to have a filter to be able to modify this (e.g. redirect to {{{home_url()}}} instead, which is probably a better default anyway). batmoo 22602 Additional error handling when installing child and parent theme from WordPress.org Themes normal normal Future Release enhancement new has-patch 2012-11-27T04:35:17Z 2012-11-27T04:35:17Z See #22515 and ticket:22515#comment:6. nacin 22601 Make post content autosave work more generically Autosave normal normal Awaiting Review enhancement new 2012-11-27T04:00:31Z 2012-12-14T23:51:36Z "The JS for autosave/AYS looks for the contents of `#post #content`. While we should fix the other JS issue related to targeting `#content` in #22600, it seems that autosave/AYS should be looking for the textarea (or whatever type of input) with the name of content instead, since having that data in the form will save to the post content. That way, if somebody does choose to use a different ID but the right input name, the autosave benefits will kick in. Discovered while working on #22491." helen 22600 Editor sizing JS puts the resize handle in the wrong place Administration normal normal Awaiting Review defect (bug) new 2012-11-27T03:58:09Z 2012-12-14T23:51:29Z "If you do the following, say to deal with the post content editor in a different way, the resize handle ends up in the wrong place because there is no status bar: {{{ wp_editor( $post->post_content, 'content', array( 'tinymce' => false ) ); }}} The JS that deals with the editor size/height should probably be checking for the status bar before moving the resize handle. Discovered while working on #22491." helen 22599 Show reviews in the plugin installer Plugins normal normal Awaiting Review enhancement new 2012-11-27T03:48:50Z 2012-12-14T23:51:19Z Pretty much as it says. Add reviews to the API endpoint, and then allow them to be shown as a tab in the modal. Seems like users should be able to vet via reviews from the comfort of the admin, now that they exist. helen 22590 get_post_class() do not set 'sticky' class in administration posts table Administration 3.4.2 normal minor Awaiting Review enhancement new has-patch 2012-11-26T09:31:54Z 2012-12-21T19:30:40Z "get_post_class() does set a 'sticky' class to sticky post on the frontend but not in the administration. So, there's no way to differentiate a sticky post from another non-sticky post excepted the span element to its right. Adding something similar to this fix the problem: {{{ // sticky for Sticky Posts in administration if ( is_sticky($post->ID) && is_admin() ) $classes[] = 'post-sticky'; }}}" corsonr 22589 Network Admin + Ajax requests Administration normal normal Awaiting Review enhancement new 2012-11-26T09:12:18Z 2012-11-26T14:40:53Z "Currently there is no Network admin based ajax handler, forcing plugins which exist solely within the Network Admin to either use `wp-admin/admin-ajax.php` or using the `load-{$page_hook}` hook to perform any actions. This is primarily a problem when the plugin only includes code on a conditional such as `is_network_admin()`, which would be false for a `/wp-admin/admin-ajax.php` request, as a result, only the `load-{$page_hook}` option above is viable for those.[[BR]] As a work around, plugins can include code on `is_network_admin() || DOING_AJAX` to allow the usage of admin-ajax.php. Of course, the User Admin also suffers the same issue. I didn't see any previous tickets, and kind of want to say the existing 'workaround' is appropriate, but recording it here so we can at least close it as wontfix if appropriate." dd32 22587 Cast image sizes to array before looping Warnings/Notices 3.3 normal normal Awaiting Review defect (bug) new has-patch 2012-11-25T22:02:49Z 2012-11-27T05:11:01Z "If someone doesn't filter the `image_size_names_choose` filter correctly, or uses some helper function like `__return_false` if they don't want to display any image sizes, a warning is thrown. The `$sizes` var should be cast to an array before looping to avoid this warning." griffinjt 22580 "Add an option to preserve aspect ratio when changing image size in ""Advanced Image Settings""" TinyMCE 3.4 normal minor Awaiting Review feature request new 2012-11-25T00:03:03Z 2012-11-25T02:52:04Z "Having an option to preserve aspect ratio would make it much easier for me to show an image smaller and still have the proportion being correct. It could be either done as a plain checkbox (in case of no JS) or, like the GIMP, as an imagebutton with a connected chain link when aspect ratio is preserved, and a broken chain link when aspect ration is not preserved. " edwardw 22579 Confusion of WP admin Discussion settings Text Changes normal major Awaiting Review enhancement new 2012-11-24T20:46:05Z 2013-05-01T16:51:55Z "On the ""Settings>Discussion"" page: 1) ""'''Default article settings'''"" should be replaced by ""'''Default comment settings'''"" (because these important settings do not only apply to posts (''articles'')), but also to pages! 2) ""'''Allow people to post comments on new articles'''"" should be replaced by: --> ""'''Allow people to post comments'''"" (best option in my opinion) or --> ""Allow people to post comments on new pages and posts"" Sorry if this is not the right place to make such suggestions." Lorangeo 22573 esc_sql() works with arrays too Inline Docs low normal Awaiting Review defect (bug) new has-patch 2012-11-24T14:31:21Z 2012-11-24T17:50:11Z ... but the doc block only says string. scribu 22567 Preview button triggers popup blocker in some browsers if no title is set Editor normal normal Awaiting Review defect (bug) new has-patch 2012-11-23T21:41:35Z 2012-12-05T21:31:33Z "Steps to reproduce: 1. Click on Add New (for a post) 2. DO NOT enter a title. 2. Start typing in the post body. 3. Click Preview Expected result: New tab opens with preview. Actual result: If popup blocking is disabled, a new window opens with the preview. On subsequent clicks of the Preview button, it reverts to opening a new tab as it should. Found in WordPress 3.5-RC1." miqrogroove 22558 Attachment term counts feels/are inaccurate Media normal normal Awaiting Review defect (bug) new dev-feedback 2012-11-23T16:21:26Z 2013-02-21T14:31:24Z "For posts: * Assign a term to a post, save as draft. Term count returns 0. * Publish the post. Term count returns 1. * Change post status back to draft. Term count returns 0. For attachments: * Upload an image, assign a term. Term count returns 0. * Create a new post and insert the image in a published post. Term count returns 0. * Create a new post, use the insert media modal and upload an image. Then go the the media edit screen and assign a term to the image. Term count returns 1. * Change the post status back to draft. Term count returns 1. * Upload an image, assign a term, attach the attachment to a published post. Term count returns 0. The default term update callback is `_update_post_term_count`. The function includes a special case for attachments, that's the reason why we have the 1 in step 3. IMO the term count for attachments shouldn't rely on the parent post status. We should just force `_update_generic_term_count`. Also noted here: comment:ticket:21391:41" ocean90 22557 """Trash"" should be a name" I18N 3.4.2 normal normal Awaiting Review enhancement new close 2012-11-23T15:56:48Z 2012-12-19T04:39:57Z "Hi there, Not sure if this happens to other languages than pt_BR, but the string ''trash'' sometimes works bad when not as a name. I would like to suggest to keep the word as a name and avoinding to flex it such ''Trash it, transhing'' etc, there is no need to singular and plural for it, I find silly ""Trashes"" in content tables since there is a counter next to the label. That's all!" Dianakc 22556 A taxonomy archive query for attachments can't return results Query 3.5 normal normal Future Release defect (bug) new early 2012-11-23T15:11:50Z 2012-12-19T20:08:06Z "In #21391 we made it easier to use custom taxonomies for attachments. Example: {{{ function ds_register_attachment_taxonomies() { $args = array( 'label' => 'Color', ); register_taxonomy( 'image-color', 'attachment:image', $args ); } add_action( 'init', 'ds_register_attachment_taxonomies' ); }}} This makes it also possible to make a query for this specific taxonomy. Example: 5 images has the term ""red"". The query: !http://example.com/image-color/red/ But: The page returns no attachments. The query: {{{ SELECT SQL_CALC_FOUND_ROWS wp_posts.ID FROM wp_posts INNER JOIN wp_term_relationships ON (wp_posts.ID = wp_term_relationships.object_id) WHERE 1=1 AND ( wp_term_relationships.term_taxonomy_id IN (404) ) AND wp_posts.post_type IN ('attachment') AND (wp_posts.post_status = 'publish' OR wp_posts.post_status = 'private') GROUP BY wp_posts.ID ORDER BY wp_posts.post_date DESC LIMIT 0, 1 }}} The problem is the `AND (wp_posts.post_status = 'publish' OR wp_posts.post_status = 'private')` part. Attachments post status is inherit, therefore no results. The attached patch checks if the current post type is `attachment` and sets the post_status to `inherit`. I would like to get this in 3.5, since it's one of the new features and could be really annoying, " ocean90 22548 Better behaviour when embedding oEmbed supported URLs Media 3.5 normal normal Awaiting Review enhancement new 2012-11-23T00:11:57Z 2012-11-23T00:11:57Z "If a user isn't aware that they can just paste the URL of a video from YouTube/Vimeo/etc into a post in order to embed it, then the user experience for embedding such content could do with some improvement. In [http://make.wordpress.org/ui/2012/11/14/to-change-things-up-i-tested-a-different/ this recent user interaction test by lessbloat], the user was given a URL to a Vimeo video and asked to embed it into their post. The user clicked 'Add Media', switched to the 'Embed From URL' tab and pasted the URL there. All that happened was the URL to the video was inserted into the post as a formatted link (`{title}`). This meant oEmbed didn't do its thing when the post was displayed and the user just ended up with a link to the Vimeo URL. == What Should Happen == URLs inserted via the 'Embed From URL' tab in the media modal should be handled according to whether or not there's oEmbed support for the URL. To do this an AJAX request should be fired off to a new AJAX handler which reports whether there's oEmbed support for the URL. If there is, then a UI element (message/icon/something) should be shown indicating that the media will be embedded. As a bonus we could even grab the oEmbed data immediately and display the title/thumbnail/etc if it's relevant. Note that if you paste a URL to an image file (gif/png/jpeg) you're immediately shown an interface for entering a caption and selecting the alignment and the link. This is nice behaviour and improves on the UI we had in 3.4. ---- This isn't specific to the new media modal because this has always been the behaviour, but marking as an improvement to trunk anyway (I'd call this a bug, but I'll leave it as an enhancement)." johnbillion 22542 wp_insert_term and wp_update_term should include taxonomy as the second parameter when invoking actions edit_terms and edited_terms Taxonomy 2.9 normal normal Awaiting Review defect (bug) new has-patch 2012-11-22T19:04:06Z 2012-11-22T20:03:46Z "wp_insert_term and wp_update_term only send term id when invoking edit_terms and edited_terms. This makes it hard for plugins hooking into those to retrieve the actual term, since get_term and get_term_by require taxonomy in addition to the id. Other actions on these functions do add the taxonomy to the parameters. For example edit_term and edited_term. So it is hard to understand why the hooks in question do not." akibjorklund 22540 Drilling categories for relevant posts via XML-RPC XML-RPC 3.4.2 normal major Awaiting Review enhancement new 2012-11-22T16:46:52Z 2012-11-23T22:17:25Z "Hello WordPress, Requirement for us was to drill down the category relevant posts, and I have implemented the solution using xmlrpc for the .net env using c#. The trouble is there is no available option to filter using category for the posts. So I have done following changes, please recommend if we can do any better to avoid the override of the change may be by upgrading the next version with it from WordPress version natively. Describing the basic nitty-gritty with in : After doing some cross referencing I was able to figure out adding following code shouldn't harm : 1: With in LLN#1374 function wp_getPosts( $args ) I added the filter option for category as follows on LN#1410 {{{ if ( isset( $filter['category'] ) ) $query['category'] = $filter['category']; }}} I have done few tests and seems to be working fine, just its expects the categoryId to drill the category relevant posts for me. I wonder if you could integrate this from WordPress. 2: Our second requirement was to get out of the box wpautop for the content, so we don't need to worry about adding tags. hence the another change of code I had integrated with in the file is as following : with in protected function _prepare_post( $post, $fields ) on LN#624 , I had added the wpautop call to surrounds to post_content as in follows : {{{ 'post_content' => wpautop($post['post_content']), }}} Please guide or suggest how to avoid the override when upgrading the WordPress, one option is WordPress integrate these changes out of the box and until that we keep an eye and on ever upgrade keep doing the change. Please feel free to reach me with any possible suggestions. Regards, Nidhi" nidhi.patel 22534 Make bundled JavaScript LibreJS compatible General normal normal Awaiting Review enhancement new 2012-11-22T01:27:21Z 2012-12-16T06:45:43Z "Many free software advocates don't want to run proprietary JavaScript code in their browsers. The Free Software Foundation has releases a Firefox extension called LibreJS that blocks non-free JavaScript from running: https://www.gnu.org/software/librejs/ WordPress is released under the GPLv2 license, but LibreJS still blocks WordPress JavaScript files because they don't have the appropriate license blocks. To fix this, we can either add comments to the top of each .js file with the license, or we can use JavaScript web labels to define the license for each js file in HTML. Here are instructions for marking your JavaScript as free so that LibreJS users will execute it: https://www.gnu.org/software/librejs/free-your-javascript.html" micahflee 22533 Plugin Rating stars is incorrect WordPress.org site low minor WordPress.org defect (bug) new 2012-11-21T23:04:07Z 2012-11-21T23:27:52Z "The stars rating doesn't reflect the average rating correctly. For example: http://wordpress.org/extend/plugins/automatic-updater/ At the time of reporting, there were 13 ratings: 9*5, 3*4, 1*1, for an average of 4.46, shown correctly in the text as ""4.5 out of 5 stars"". The star rating doesn't seem to be using the same number, however - it should be 89.2% (or 90%, if it uses the rounded up ""4.5"" as the rating), but is showing as 82%." pento 22526 Changing category doesn't invalidate cache Cache 3.4.2 normal normal Awaiting Review defect (bug) new 2012-11-21T11:55:37Z 2012-11-21T11:55:37Z "Hi, I am using object-cache.php Memcached v2.0.2 (Dropins) with the current WordPress version, but I don't think this has anything to do with the dropin. I noticed that category changes don't invalidate/update the cache. For example: 1. Create a category ""Foo"". 2. Assign some postings to ""Foo"". 3. View your postings in backend and frontend, so that results get cached. 4. Rename ""Foo"" category to ""Bar"". 5. Reload some postings, which are in that category. But they still display the old ""Foo"" category instead the new ""Bar"" category name. Flushing memcached would ""solve"" this problem, that's why I think renaming categories don't invalidate/update the cache." Whissi 22525 Marking duplicates on Trac without a ticket number improperly resolves the ticket nacin WordPress.org site normal normal WordPress.org defect (bug) assigned 2012-11-21T11:38:50Z 2012-12-02T16:39:39Z For some reason, the last ticket I submitted closed itself when I tried to reply to it. Looking for a Trac bug now. miqrogroove 22523 Can't Open Menu on iPad WordPress.org site normal normal WordPress.org defect (bug) reopened 2012-11-21T09:34:49Z 2012-11-21T11:59:47Z "To reproduce: 1. Go to http://make.wordpress.org/core/ 1. Click ""Get Involved"" What Should Happen: Menu should open. What it Does: Reloads current page. Found in Safari iOS 6.0.1" miqrogroove 22519 iPad toolbar location Toolbar normal normal Awaiting Review defect (bug) new 2012-11-20T17:45:44Z 2013-04-15T15:34:13Z "The toolbar moves after using quick edit on a post or page. Also the customizer button look strange on iPad. Steps to reproduce 1: Click quick edit on a post 2: Click ""Allow Pings"" 3: Now the admin toolbar should be be lower on page. (I was able to reproduce 4/5 tries)" MikeHansenMe 22511 Taxonomy manage screen checks for manage_terms and edit_terms, instead of just manage_terms. Taxonomy 3.0 normal normal Awaiting Review defect (bug) new dev-feedback 2012-11-19T23:13:56Z 2012-11-20T03:14:40Z "I'm trying to set up permissions so the Contributor role can add terms but not edit or delete terms. I setup my taxonomy so it looks like this: {{{ register_taxonomy( 'custom_taxonomy', array( 'post' ), array( ... 'capabilities' => array ( 'manage_terms' => 'edit_posts', 'edit_terms' => 'manage_options', 'delete_terms' => 'manage_options', 'assign_terms' => 'edit_posts' ) ) ); }}} However, when logged in as a contributor I get the error ""You are not allowed to edit this item."" In edit-tags.php there are two checks for caps, one is for manage_terms and one is for edit_terms. I don't believe the second one should be there, because looking at the other code it should be like this: * User with manage_terms can access the main taxonomy page * They can also add terms * There are checks in WP_Terms_List_Table to restrict showing the Edit/Quick Edit/Delete links for users without those capabilities (edit_terms/delete_terms). * There is even plenty of other checks on edit_terms in edit-tags.php to include/change the content shown to the user.. if the entire page is restricted for users without edit_terms, why are any of those necessary? Even if I'm wrong on the fact that roles with edit_terms can't add new terms (it's not completely clear anywhere, it seems like manage_terms should be enough), I still think that this page should be viewable at the very least considering the other code in that page and the list table. Recommended solution: move the edit_terms check back into case 'edit' (line 121 of edit-tags.php in trunk, currently) as it was before [15491]. This was introduced in: [15441] and [15491]. Related: #14343." andrewryno 22509 No-JS fallback for default color in color picker Administration normal normal Awaiting Review defect (bug) new has-patch 2012-11-19T19:42:19Z 2012-12-19T20:48:22Z "The no-JS fallback for the color picker is just a plain input. Since the color picker implementation now includes the ability to reset to a specified default, it seems to make sense to include a no-JS fallback for the default, even just as a little bit of hidden descriptive text. See #22461 for discussion stemming from the custom header screen." helen 22506 Bogus Last-Modified Header on Forum Feeds WordPress.org site normal major WordPress.org defect (bug) new 2012-11-19T15:45:46Z 2012-11-19T15:59:19Z "In troubleshooting RSS problems, I found that all of the plugin support feeds are responding with {{{ Last-Modified: Tue, 16 Oct 2012 14:09:51 GMT }}}" miqrogroove 22505 Toolbar dropdowns don't hide on front end on tap away Toolbar 3.4.2 normal normal Awaiting Review defect (bug) new 2012-11-19T14:46:03Z 2012-12-01T21:12:52Z "In the wp-admin pages I can open the Howdy or New menus and tap away to close them. In the front end admin bar, the menu stays open until navigating to a new page. Found on 3.5-beta3-22637 using iPad3 iOS 6.0.1." miqrogroove 22498 Disabling Header Text should not reset Header Text Color to default Appearance 3.4.2 normal normal Awaiting Review defect (bug) new 2012-11-18T22:31:17Z 2012-11-18T22:31:17Z "In Appearance > Header, if you uncheck the 'Show header text with your image' option and Save, the Text Color option is reset to whatever the default is. With JS enabled, the Text Color option is hidden when the checkbox is unchecked, but in no-js both options are displayed all the time. It's odd to set a header text color and uncheck the option only to have it reset your choice to the default. Related: #22461" DrewAPicture 22497 Post type should be able to show on mobile apps XML-RPC normal normal Awaiting Review enhancement new has-patch 2012-11-18T18:48:58Z 2012-11-20T11:40:24Z "Currently the mobile apps only show Post and Pages. Part of the reason is that the apps can't know if the post type is worth showing in the apps since it's heavily based on several meta-boxes. I think this is a nice add-on for developers to make that decision. The patch is really simple and is just adding a extra parameter to register post type." markoheijnen 22492 Duplicate MIME-Version header External Libraries 3.4.2 normal minor Awaiting Review defect (bug) new 2012-11-18T03:16:33Z 2012-11-18T10:46:26Z "In certain cases, Wordpress sends emails containing two ""MIME-Version"" headers. This causes email rejections from some Amazon SES SMTP servers in particular. To reliably reproduce, a default multisite install with BuddyPress can be used. When a user tries to register and create a website, the activation email contains this bug. Unfortunately I don't know how to reproduce this error with Wordpress itself, but I believe this bug is related to the Wordpress core. If any plugin happens to set a custom header of ""MIME-Version"" to an email message, Wordpress core is the culprit for the insertion of the duplicate mail header. Patch attached to this report, it's a trivial fix. All the fix does is checks to see if ""MIME-Version"" was already included in custom mail headers, and if so, don't insert the duplicate header." ryderlewis 22487 Adding priority to settings sections. General normal normal Awaiting Review enhancement new has-patch 2012-11-17T09:08:34Z 2013-02-05T10:35:14Z "Currently there is no way (at least that I could find) to specify the order of settings sections on a settings page (for example, a theme options page). Use case: a child theme adding a settings section to the parent theme's ""Theme Options"" page has no way of specifying where on the page the new section should be placed. I've modified the add_settings_section() function to allow for a priority to be set (much like when adding sections to the theme customizer). I also added `uasort($wp_settings_sections[$page], 'compare_priority');` to the do_settings_section() function, where 'compare_priority' is a slightly modified version of the compare function used to set the priority of the theme customizer sections. The patch is based on version 3.4.2, but I'd be happy to make another for the development version if that would help. This is my first patch submitted, so please let me know if I need to do anything differently. Thanks!" alexmansfield 22478 Remove $force argument from WP_Object_Cache::delete() Cache 3.4.2 normal normal Future Release defect (bug) new 2012-11-16T19:02:07Z 2012-11-16T19:02:07Z This was introduced way back in [3086] and hasn't been needed for years. ryan 22474 Change case in Hello world! Text Changes 3.4.2 low trivial Awaiting Review enhancement new has-patch 2012-11-16T14:08:21Z 2013-05-10T20:01:57Z "Currently, the ""Hello world!"" headline on the default post is in sentence case rather than title case, which would be ""Hello World!"" Title case and sentence case are both grammatically correct, you just need to pick a standard and stick to it. But let's face it, headlines usually use title case. I propose that we change the default post title to use title case instead of sentence case." jane 22470 WP_Scripts: output script element only if src not empty General normal trivial Awaiting Review enhancement new has-patch 2012-11-16T00:36:50Z 2012-11-16T00:36:50Z "I was able to make async JavaScript loading work with existing !WordPress code by acting on the script_loader_src filter before the `}}} in the ""Caption"" field. 5. Click ""Insert into Post"". Instead of the image (or Shortcode) being added to the editor (with a somehow escaped caption field), the media upload iframe just gets a new content: {{{ [/caption]'); /* ]]> */ }}} Reproduced in 3.4.2 and trunk." TobiasBg 22128 Adding upload mimetype in Multisite does not work if mimetype is not already defined Multisite 3.0 normal critical Awaiting Review defect (bug) new 2012-10-08T13:13:54Z 2012-12-23T17:11:20Z "'''Description''' We would like to add 3gp to the list of file types to be uploaded in the sites of our network install. We've tried to add 3gp to the Network Settings->Upload File Types setting for this. However after having saved the setting we were still not able to upload 3gp. It seems the user setting is being overruled by the list of global settings. '''Steps to reproduce issue:''' 1. Use WordPress Network install (aka Multisite) 2. Add the file extension 3gp to the upload file types setting in Network Settings 3. Save Settings 4. Try to upload a 3gp file using the Media Library, it will fail with the message: 'Sorry, this file type is not permitted for security reasons.' It seems the upload file types defined in the Network Settings cannot overrule / add new file types if this file type has not already been defined in the function wp_get_mime_types() (see file: wp-includes/functions.php). '''Expected behaviour''' Changing the Upload File Types by adding a new extension results in WordPress accepting files ending in this extension. Or warn the admin that this extension is unknown and more info (such as the full mime type) is needed. '''Proposed solution''' We are aware of the hook 'upload_mimes' to fix this with a plugin, but we suggest that the superadmin Network Settings->upload file type overrules WordPress' built-in defaults instead of the other way around." BjornW 22127 strange behaviour with shortcode with the_content filter Shortcodes 3.4.2 normal normal Awaiting Review defect (bug) new 2012-10-08T11:04:01Z 2012-10-08T12:03:34Z "let's say i have installed any lightbox/thickbox/... plugin (same behaviour with 'auto thickbox plus', 'lightview plus', 'jquery lightbox', 'fancybox plus', 'wp jquery lightbox' ...) and i have a shortcode, which uses the_content filter, e.g. {{{ function test_shortcode( $atts, $content = null ) { return apply_filters('the_content', $content); } add_shortcode( 'test', 'test_shortcode' ); }}} then if i use [test] shortcode anywhere in the post, the lightbox does not work. e.g. {{{ [test]test[/test] [caption ... /] // this is standard image }}} if the shortcode do not have the_content filter, or the shortcode is not use anywhere in the post, or i put the 'lightbox' etc. class to [a] directly than it works as a charm. There may be a bug in the lightbox plugins, but it is strange, that it is in ALL lightbox plugins. But even in that case for me it is very strange, that something what is INSIDE the shortcode affects OUTSIDE of the shortcode. That's why i think it is a bug of core." thomask 22119 Rename 'QuickPress' to 'Quick Post' or something similar. Text Changes normal normal Awaiting Review enhancement new has-patch 2012-10-07T04:11:02Z 2013-01-22T03:21:21Z I think 'QuickPress' should be renamed to 'Quick Post' to be a little more user friendly. As it stands, Quick press gives no indication whether it will be a post or page, or what QuickPress even does. I think renaming it Quick Press gives more direction, and is a little easier to understand. bradparbs 22117 Better backtrace Database 3.4.2 normal normal Awaiting Review enhancement new dev-feedback 2012-10-06T14:06:50Z 2012-10-06T18:25:28Z "Hey, This is a small hack for a prettier backtrace info. the file '''''/wp-includes/functions.php''''' at Line 3547 the new functions with added lines {{{ function wp_debug_backtrace_summary( $ignore_class = null, $skip_frames = 0, $pretty = true ) { if ( version_compare( PHP_VERSION, '5.2.5', '>=' ) ) $trace = debug_backtrace( false ); else $trace = debug_backtrace(); $caller = array(); $check_class = ! is_null( $ignore_class ); $skip_frames++; // skip this function $last_info = array(); foreach ( $trace as $call ) { if ( isset( $call['class'] ) && 'wpdb' == $call['class'] ) { $last_info['file'] = basename($call['file']); $last_info['line'] = $call['line']; } if ( $skip_frames > 0 ) { $skip_frames--; } elseif ( isset( $call['class'] ) ) { if ( $check_class && $ignore_class == $call['class'] ) continue; // Filter out calls $caller[] = ""{$call['class']}{$call['type']}{$call['function']}""; if( empty( $last_info['func'] ) ) $last_info['func'] = $call['class'].'->'.$call['function']; } else { if ( in_array( $call['function'], array( 'do_action', 'apply_filters' ) ) ) { $caller[] = ""{$call['function']}('{$call['args'][0]}')""; } elseif ( in_array( $call['function'], array( 'include', 'include_once', 'require', 'require_once' ) ) ) { $caller[] = $call['function'] . ""('"" . str_replace( array( WP_CONTENT_DIR, ABSPATH ) , '', $call['args'][0] ) . ""')""; } else { $caller[] = $call['function']; if( empty( $last_info['func'] ) ) $last_info['func'] = $call['function']; } } } if ( $pretty ) return sprintf(__(""Error at %s, at line %d, in function %s %s""), $last_info['file'], $last_info['line'], $last_info['func'], join( ', ', array_reverse( $caller ) ) ); else return $caller; } }}}" msolution 22115 Further Simplifying errors Database 3.4.2 normal normal Future Release enhancement new dev-feedback 2012-10-06T11:32:15Z 2013-05-16T11:55:15Z "tracking errors while making API's and cron jobs, is a tad difficult. from the latest wordpress pack, '''''/includes/wp-db.php''''' {{{ function query( $query ) { ... ... if ( defined( 'SAVEQUERIES' ) && SAVEQUERIES ) $this->queries[] = array( $query, $this->timer_stop(), $this->get_caller() ); // If there is an error then take note of it.. if ( $this->last_error = mysql_error( $this->dbh ) ) { $this->print_error(); return false; } ... ... }}} if we change the above to simply {{{ // If there is an error then take note of it.. $this->last_error = ''; if ( $this->last_error = mysql_error( $this->dbh ) ) $this->print_error(); if ( defined( 'SAVEQUERIES' ) && SAVEQUERIES ) $this->queries[] = array( $query, $this->timer_stop(), $this->get_caller(), $this->last_error ); // If there is an error then take note of it.. if ( ! empty( $this->last_error ) ) return false; }}} then we have all required info in the array queries, for use later. may it be wp_footer, or for a plugin as debug info." msolution 22114 Propagating password on change Users 3.4.2 normal normal Awaiting Review feature request new close 2012-10-06T08:30:47Z 2012-10-08T04:54:45Z "After creating an account or changing profile information, it is possible to intercept the changed data in a hook. However, this is not possible for the cleartext psasword, and this is a useful feature especially when propagating a password change over different accounts spanning across different systems (in contexts such as updating the password for phpBB, Prestashop, or any PAM thingie when the WordPress password is changed). Since this feature is by no means possible to implement without core hacks, I am submitting a patch to include this feature in the WP core. This patch proves useful if we are to integrate other software bricks without having to implement SSO using WordPress' architecture. In my context, I need to be able to log-in through WordPress or directly through the business specific back-end. Proposed patch is attached." ChloeD 22112 get_adjacent_post excluded_categories isn't excluded Template normal normal Awaiting Review defect (bug) new 2012-10-05T18:21:28Z 2012-10-05T18:25:53Z "The category I expect to be excluded in $excluded_categories, is not excluded. With get_adjacent_post, Assuming $in_same_cat = TRUE and $excluded_categories = 'ID_OF_CATEGORY' $cat_array gets built with the ID's of categories it should include. cool. But, when $excluded_categories contains an ID that $cat_array contains, the ID is removed from the $excluded_categories by array_diff() (link-template.php:1155). So: the category I expect to be excluded in $excluded_categories, is not excluded. My resolution: I remove 1154-1157. {{{ if ( ! empty( $cat_array ) ) { $excluded_categories = array_diff($excluded_categories, $cat_array); $posts_in_ex_cats_sql = ''; } }}}" PatNarciso 22110 Check for current conditional General 3.4 normal normal Awaiting Review enhancement new 2012-10-05T17:12:18Z 2012-10-11T00:37:05Z "More than once I've needed a programmatic way to determine what page is being displayed, for example when implementing event tracking recently: {{{ add_action( 'wp_enqueue_scripts', function() { wp_enqueue_script( 'my-site', get_template_directory_uri() . '/js/mysite.js', array( 'jquery' ), '1', true ); // Figure out what type of page we're on $is = ''; foreach ( $GLOBALS['wp_query'] as $key => $value ) { if ( true === $value && 'is_' === substr( $key, 0, 3 ) ) { $is = substr( $key, 3, strlen($key) ); break; } } wp_localize_script( 'my-site', 'event_tracking', array( 'category' => $is, ) ); } ); }}} And then used like: {{{ Action }}} Now granted the above way to determine the current page is a little janky, and has at least one flaw (on custom post type archives because both ""is_archive"" and ""is_post_type_archive"" are set, and it will find ""is_archive"" first, every time). TBH this was me with a bowl of chili in one hand trying to avoid typing out ""if ( is_* ) { } elseif ( is_* ) { } elseif ( is_* ) {} ..."". A saner function would probably explicitly check each conditional, which would make it a little more tedious but also more maintainable: {{{ function where_am_i( $return = 'simple' ) { global $wp_query; if ( ! isset( $wp_query ) ) { _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the query is run. Before then, they always return false.' ), '3.5' ); return false; } $primary = null; $secondary = null; $tertiary = null; // Tried to maintain the hierarchy from query.php if ( true === $wp_query->is_robots ) { $primary = 'robots'; } elseif ( true === $wp_query->is_attachment ) { $primary = 'attachment'; $secondary = 'single'; $tertiary = 'singular'; } elseif ( true === $wp_query->is_page ) { $primary = 'page'; $tertiary = 'singular'; } elseif ( true === $wp_query->is_single ) { $primary = 'single'; $secondary = 'singular'; } elseif ( true === $wp_query->is_search ) { $primary = 'search'; } elseif ( true === $wp_query->is_time ) { $primary = 'time'; $secondary = 'date'; $tertiary = 'archive'; } elseif ( true === $wp_query->is_day ) { $primary = 'day'; $secondary = 'date'; $tertiary = 'archive'; } elseif ( true === $wp_query->is_month ) { $primary = 'month'; $secondary = 'date'; $tertiary = 'archive'; } elseif ( true === $wp_query->is_year ) { $primary = 'year'; $secondary = 'date'; $tertiary = 'archive'; } elseif ( true === $wp_query->is_date ) { $primary = 'date'; $secondary = 'archive'; } elseif ( true === $wp_query->is_category ) { $primary = 'category'; $secondary = 'archive'; } elseif ( true === $wp_query->is_tag ) { $primary = 'tag'; $secondary = 'archive'; } elseif ( true === $wp_query->is_tax ) { $primary = 'custom_taxonomy'; $secondary = 'archive'; } elseif ( true === $wp_query->is_author ) { $primary = 'author'; $secondary = 'archive'; } elseif ( true === $wp_query->is_post_type_archive ) { $primary = 'post_type'; $secondary = 'archive'; } elseif ( true === $wp_query->is_feed ) { $primary = 'feed'; } elseif ( true === $wp_query->is_trackback ) { $primary = 'trackback'; } elseif ( true === $wp_query->is_comments_popup ) { $primary = 'comments_popup'; $secondary = 'comments'; } elseif ( true === $wp_query->is_preview ) { $primary = 'preview'; $secondary = 'singular'; } elseif ( true === $wp_query->is_admin ) { $primary = 'admin'; } elseif ( true === $wp_query->is_comment_feed ) { $primary = 'comment_feed'; $secondary = 'comments'; $tertiary = 'feed'; } elseif ( true === $wp_query->is_404 ) { $primary = '404'; $secondary = 'singular'; } elseif ( true === $wp_query->is_home ) { $primary = 'home'; if ( true === $wp_query->is_posts_page ) { $secondary = 'posts_page'; $tertiary = 'page'; } else { $secondary = 'static_page'; } } if ( 'detailed' === $return ) { $details = compact( $primary, $secondary, $tertiary ); $details = array_filter( $details ); // Remove empty return $details; } // 'simple' === $return return $primary; } }}} Should it use $wp_the_query so that it always acts on the main query? " mintindeed 22106 SVN Notify emails don't support UTF-8 WordPress.org site normal minor WordPress.org defect (bug) new 2012-10-05T06:30:42Z 2012-10-05T06:38:07Z "If there are UTF-8 characters in the changelog, they are shown as UTF-8 numerical codes, instead of the appropriate character. For example, see this change: http://plugins.trac.wordpress.org/changeset/608203/automatic-updater Compared to the attached email screenshot." pento 22104 High contrast admin colour scheme Accessibility normal normal Awaiting Review feature request new 2012-10-04T17:35:54Z 2012-11-20T16:57:21Z "We should consider bundling a high contrast admin colour scheme with WordPress to aid accessibility for the visually impaired. Some discussion on this has taken place previously on IRC but nothing much beyond that. Some potential points of discussion: * Is anyone in the [http://make.wordpress.org/accessibility/ WordPress accessibility group] an expert on accessibility for the visually impaired? Can we get someone on board for some expert guidance? * Is an admin colour scheme sufficient? Would any JavaScript need altering too? If so, would an admin colour scheme suffice as a starting point? Related: * [http://www.timobrienphotos.com/2009/03/hich-contrast-admin-color-scheme-for-wordpress/ A high contrast admin theme plugin] * [http://wordpress.org/support/topic/admin-color-scheme Support forum discussing admin theme for visually impaired user] * [http://wordpress.org/extend/plugins/easy-admin-color-schemes/ Easy Admin Colour Schemes plugin]" johnbillion 22101 "Gallery shortcode with link=""file"" is not linking the file in the RSS feed" Feeds 3.4.2 normal normal Awaiting Review defect (bug) new 2012-10-04T16:14:16Z 2012-10-27T15:58:55Z "Hi, In a WordPress site I'm currently developing I want to use the stock gallery shortcode. I use [gallery link=""file""] to link directly the image URL which, should fix Flipboard, Currents et al. showing just a little thumbnail. In the page the code is displayed properly and the a tag links the image file, but, on the RSS feed, it links to the attachment page. I've tested this in the latest nightly version 3.5-beta1-22104 and on the stable 3.4.2. I attach the output of the page and the feed. " ifrins 22100 Treat built-in image sizes the same as custom image sizes Media normal normal Future Release enhancement new has-patch 2012-10-04T15:39:44Z 2013-05-14T13:50:34Z "Goals: 0. Have a solid API for working with intermediate image size definitions. 1. Don't hardcode default image sizes; register them like any other. 2. ~~Introduce a 'pregenerate' arg, which will allow defining an image size that will not be automatically generated right after upload.~~ Related tickets: #15311, #21810" scribu 22086 "HTML5 and cellspacing=""0"" in admin pages" Administration 3.4 normal minor Awaiting Review enhancement new dev-feedback 2012-10-03T19:37:25Z 2013-02-19T20:46:43Z "There are several instances where generated table content uses 'cellspacing=""0""' in the admin areas of WordPress. The W3C validator (albeit experimental) states that this parameter should be dropped and CSS used instead for HTML5 compliance. I think the patch I'm going to attach in a moment will fix these validation issues." MattyRob 22082 WordPress Import Tool looses the complete category hierachical structure Import 3.4.2 normal normal WordPress.org defect (bug) new 2012-10-03T01:53:05Z 2012-10-05T13:49:54Z "I have exported from my local laptop wordpress installation the posts I had. They have the following structure with categories: {{{ language --> main category, parent - source language --> for example AF -- target language --> for example AFAR for Africans to Arabics --- lessons ----- lesson 1 --> up to 100 lessons entries -- next target language }}} and so on this complete structure is lost after import - they are all changed to parent categories no single child category. I will attach the export file." christian_gnoth 22080 add_theme_support should merge post-thumbnail post types by default (currently stomps) Post Thumbnails 2.9 normal normal Future Release enhancement new has-patch 2012-10-02T19:44:59Z 2013-04-09T20:02:23Z "As documented in the Codex: http://codex.wordpress.org/Function_Reference/add_theme_support#Post_Thumbnails you can pass a second param to `add_theme_support( 'post-thumbnails' )` to specify the post types you want support enabled for. I expected any post types I passed in to be added to the currently specified post types, instead the passed value stomps the existing value. This means that if you create plugin that registers a post type and enables post-thumbnails for it, you need to write code like this: https://gist.github.com/3822786 instead of a simple: `add_theme_support( 'post-thumbnails', array( 'my-new-post-type' ) );` The latter makes more sense to me, and I think it's likely other devs might make the same mistake and accidentally stomp on the previous value for post-thumbnails. The attached patch enables a merge or stomp behavior for post-thumbnails. It defaults to ""merge"". Passing a `bool true` as a 3rd param will cause the second param to replace the existing value (current behavior)." alexkingorg 22076 WP Upgrader: update_bulk_plugins_complete_actions and update_bulk_theme_complete_actions should pass information about all plugins/themes to the filter Upgrade/Install 3.0 normal normal Awaiting Review defect (bug) new 2012-10-02T07:56:19Z 2012-10-05T23:10:07Z "In class-wp-upgrader.php, line 1214 there is this line: {{{ $update_actions = apply_filters('update_plugin_complete_actions', $update_actions, $this->plugin); }}} When adding a filter to it like this: {{{ add_filter('update_bulk_plugins_complete_actions','test_filter',99,2); function test_filter( $update_actions, $plugins ) { echo print_r( $plugins, 1); return $update_actions; } }}} Only the last updated plugin info will be printed. However, it should contain information about all the plugins that were updated (since we are dealing with a bulk upgrade here)." ragulka 22075 Improving `wp_get_attachment_link` Media 3.4 normal normal Awaiting Review enhancement new dev-feedback 2012-10-02T04:29:05Z 2012-10-07T22:07:52Z "I answered a [http://wordpress.stackexchange.com/questions/65982 question] not so long ago on [http://wordpress.stackexchange.com/ WordPress StackExchange]. There I saw the need on a filter for `wp_get_attachment_link()` to allow the developer to add or remove attributes to the HTML without having to use a regex on it or creating the `a` tag again. So I've done this small patch with changes to apply this enhancement to the function." webord 22074 Very Large Query that Crashes the whole My SQL and site Performance 3.4.1 normal normal Future Release enhancement new needs-unit-tests 2012-10-02T03:13:14Z 2013-05-16T11:59:00Z "Hi David, The problem is being caused by an extremely large mysql query. This is just a snippet of it. The full query is in /home/profithunters/query. You should have your dev look at it. What user/pass are you using for mysql? You can login as the root mysql user by logging into https://profithunters.nmsrv.com/gadmin/ and then going to MySQL -> Launch phpmyadmin. {{{ | 370 | 371 | | 1697 | profithu_wrdp2 | localhost | profithu_wrdp2 | Query | 78 | statistics | SELECT * FROM wp_posts WHERE (post_type = 'page' AND post_status = 'publish') AND ( ID <> 3778 AND ID <> 49911 AND ID <> 0 AND ID <> 20531 AND ID <> 3776 AND ID <> 3792 AND ID <> 3794 AND ID <> 3797 AND ID <> 3799 AND ID <> 3801 AND ID <> 3803 AND ID <> 3805 AND ID <> 3807 AND ID <> 3811 AND ID <> 5540 AND ID <> 6500 AND ID <> 8965 AND ID <> 9363 AND ID <> 10974 AND ID <> 11516 AND ID <> 11822 AND ID <> 12903 AND ID <> 12907 AND ID <> 12911 AND ID <> 13928 AND ID <> 13930 AND ID <> 14188 AND ID <> 14192 AND ID <> 14935 AND ID <> 14937 AND ID <> 14939 AND ID <> 14941 AND ID <> 15023 AND ID <> 15376 AND ID <> 19768 AND ID <> 20980 AND ID <> 20984 AND ID <> 21353 AND ID <> 21550 AND ID <> 21554 AND ID <> 21559 AND ID <> 21562 AND ID <> 21618 AND ID <> 21623 AND ID <> 21629 AND ID <> 21674 AND ID <> 21677 AND ID <> 21682 AND ID <> 21689 AND ID <> 21694 AND ID <> 21703 AND ID <> 21706 AND ID <> 21707 AND ID <> 21714 AND ID <> 21717 AND ID <> 21744 AND ID <> 21834 AND ID <> 21859 AND ID <> 21862 AND ID <> 21865 AND ID <> 21873 AND ID <> 21876 AND ID <> 21880 AND ID <> 21884 AND ID <> 21897 AND ID <> 21900 AND ID <> 21902 AND ID <> 21905 AND ID <> 21936 AND ID <> 21938 AND ID <> 21940 AND ID <> 21949 AND ID <> 21951 AND ID <> 21958 AND ID <> 21966 AND ID <> 21983 AND ID <> 21986 AND ID <> 21989 AND ID <> 21995 AND ID <> 22000 AND ID <> 22004 AND ID <> 22006 AND ID <> 22010 AND ID <> 22014 AND ID <> 22016 AND ID <> 22020 AND ID <> 22024 AND ID <> 22026 AND ID <> 22028 AND ID <> 22030 AND ID <> 22037 AND ID <> 22040 AND ID <> 22043 AND ID <> 22046 AND ID <> 22049 AND ID <> 22058 AND ID <> 22060 AND ID <> 22062 AND ID <> 22065 AND ID <> 22068 AND ID <> 22071 AND ID <> 22073 AND ID <> 22075 AND ID <> 22078 AND ID <> 22085 AND ID <> 22087 AND ID <> 22089 AND ID <> 22094 AND ID <> 22125 AND ID <> 22128 AND ID <> 22133 AND ID <> 22137 AND ID <> 22141 AND ID <> 22144 AND ID <> 22151 AND ID <> 22153 AND ID <> 22155 AND ID <> 22157 AND ID <> 22160 AND ID <> 22162 AND ID <> 22165 AND ID <> 22168 AND ID <> 22170 AND ID <> 22172 AND ID <> 22174 AND ID <> 22176 AND ID <> 22178 AND ID <> 22180 AND ID <> 22184 AND ID <> 22186 AND ID }}}" adest 22070 Deleting menus with no title / slow menu saving Menus 3.4.2 normal normal Awaiting Review defect (bug) new dev-feedback 2012-10-01T12:28:55Z 2012-10-01T12:35:48Z "Hello there I saw that when saving nav menus in wp-admin/nav-menus.php WordPress executes the following lines, if a menu item is saved (no matter if newly added or existing) that doesn't have a title: {{{ if ( empty( $_POST['menu-item-title'][$_key] ) ) continue; }}} I changed this to the following to make it work. Problem is, it needs to be removed from $menu_items, because it's handled like a deleted menu else. {{{ if ( empty( $_POST['menu-item-title'][$_key] ) ) { if (isset($menu_items[$_POST['menu-item-db-id'][$_key]])) unset($menu_items[$_POST['menu-item-db-id'][$_key]]); continue; } } }}} '''Sidenote''': With that fixed, I was able to solve a major saving bug. Many of our customers have a lot of menu items in out nav_menu (like 100 - 600), which without a timeout would take 10 minutes and more to save. So I created some hotfix jQuery script that does ""dirty-handling"". Basically it marks everything that's touched (like changed data, adding a menu item or moving things around) as ""dirty"". On submit it doesn't nothing more than change every ""undirty"" menu items title to an empty string so it doesn't get saved. I think WordPress core developers could integrate something like this with far less code since I wasn't able to use events - I didn't really had a lot of time to fix this. So if it helps anyone, this is the jQuery code I used to create the fix: {{{ jQuery(function($) { // the currently displayed menu form var $form = $('#update-nav-menu'); // Listen to new menus, since we have no possibility to hook // we have to interval it, because we can't capture an event here $('.submit-add-to-menu').click(function() { var $item_count = $form.find('.menu-item-handle').length; var $interval_id = setInterval(function() { var $current_item_count = $form.find('.menu-item-handle').length; if ($item_count < $current_item_count) { clearInterval($interval_id); // Add the dirty flag and set it to dirty immediately add_dirty_flags(1); // Reassign the mousedown/up events assign_mouse_events(); } },200); }); // add a hidden field, telling if the menu is dirty (by default, it's not) function add_dirty_flags($flag) { $form.find('.menu-item-handle').each(function() { if ($(this).find('.dirty-handle').length == 0) { var $html = ''; $(this).append($html); console.log('flag added'); } }); } // (re)assigns mouse events to menu items function assign_mouse_events() { var $menu_items = $('.menu-item-bar'); // Unbind previously assigned events $menu_items.unbind('mouseup').unbind('mousedown'); // Dirty Flag handler if a click happens $menu_items.mousedown(function() { $(this).find('.dirty-handle').val('1'); }); // if the parent changes on release the mouse handle, change all items with the new parent to dirty $menu_items.mouseup(function() { menu_save_mouseup($(this)); }); } // The call back for mouseup on menu bars function menu_save_mouseup($this) { var $temp_object = $this.parent(); // Mark everything with the same parent dirty setTimeout(function() { var $parent_id = $temp_object.find('.menu-item-data-parent-id').val(); // Go through all fields, dirtying everything that has the same parent $('.menu-item-data-parent-id').each(function() { if ($(this).val() == $parent_id) $(this).parent().prev().find('.dirty-handle').val('1'); }); },200); } // On submit make every undirty menu an empty title, so it won't get saved // We're using a hoax in nav-menus.php, line 335 here.. $form.submit(function() { // Now traverse all handles and make only dirties saveable $form.find('.menu-item-handle').each(function() { // Find the dirty flag var $is_dirty = $(this).find('.dirty-handle').val(); $(this).find('.dirty-handle').remove(); if ($is_dirty == 0) { // The div containing the menu informations var $forms = $(this).parent().next(); // Remove the title value so it doesn't get saved $forms.find('.edit-menu-item-title').val(''); } }); return true; }); // Assign mouse events on first load assign_mouse_events(); // Add all dirty flags (not dirty by default of course) add_dirty_flags(0); }); }}} Since WordPress now only saves the menu's that changed it doesn't matter how many menu items a customer has, but only how many he want's to save at one time." msebel 22069 unify function naming convention get_ vs. the_ General 3.4.2 normal normal Awaiting Review enhancement new 2012-10-01T10:24:15Z 2012-10-01T10:24:15Z "even after about 400 custom wordpress instalation i always got problem remembering the proper name of many functions, if they are returning the content or echoing it. Most of the functions got get_something() and the_something() but some functions got get_the_something() (e.g. get_the_post_thumbnail) and some got the_something(echo=false) or something(echo=true) etc. It would be nice if we would consolidate the naming convention (IMO get_ and the_ would be the best) and make current functions obsolete." thomask 22059 Making the admin bar responsive Toolbar 3.4 normal normal Awaiting Review enhancement new has-patch 2012-09-30T16:58:12Z 2013-02-28T18:32:30Z "Hi, This patch is made to add responsive layout to the admin bar. It comes from the ""Responsive adminbar"" plugin (http://wordpress.org/support/plugin/responsive-adminbar, thanks to skodnik). Basically, I added some html tags to some menu items in the admin bar (using the ab-icon / ab-label combo) in order to handle the new icons I added to the ""admin-bar-sprite.png"". I took the images straight from the plugin but some states are missing or some images should be changed as they are not appropriate (a ""heart"" for the network seems weird). I'm also missing the ""View post"" icon which now defaults to the ""Edit post"" one. the CSS could be refactored I guess in order to avoid using ids. I have not tested RTL! Cheers from Hackday Lisbon :) Jonathan" JoN1oP 22058 Custom background vertical position Appearance 3.4.2 normal normal Awaiting Review enhancement new dev-feedback 2012-09-30T16:30:29Z 2013-04-25T01:20:25Z For the the custom background display options there is only left, centre and right position. The top and bottom position is missing. grapplerulrich 22056 Integrate a list of notices for newbie users Administration 3.4.2 normal normal Awaiting Review feature request new dev-feedback 2012-09-30T14:39:40Z 2012-10-02T18:21:13Z "Integrate a list of possible warnings and notices for the power-user (admin) if some problems or security thread occur, or to check if the site was infected with viruses and malicious .php files... Example: - Notice: GD Graphics Library is not installed, install this so the images could be resized - Notice: Your site is not giving search engines the right to index the site, please consider changing the settings. - Warning: An unknown file mail.php is in the site main directory, please check if you are not infected. - Notice: Your site files permissions are set to 777, please change to 644 or 640, your site is in a security thread. - Notice: Upload folder is not writable, please change permission to 755 for the upload dir. - Notice: Please use a caching file plugin to make your site load faster than ever. " alexvorn2 22051 Turning off italic at the end of the word de-italicizes whole word. TinyMCE 3.4.2 normal minor Awaiting Review defect (bug) new 2012-09-30T07:34:16Z 2012-10-02T01:55:39Z "I'm on a mac so I am using command-I to turn on italics in the post editor, visual mode, as I write. To replicate: Write the first letter of a word. Then backspace. Then press command-I, and write the whole word, which will now be italicized. Before pressing the space bar, hit command-I again. Instead of just turning off italics for your next word, it turns the word you just wrote back into non-italicized text. Through testing I discovered that it does not happen if you press command-I at the beginning of the word, it only happens when you back up in the middle of the word and then press command-I. And it doesn't happen when you press the ""I"" italics toolbar button to turn italics on and off, it only happens when using the keyboard shortcuts. This is new behavior that started with one of the recent updates, but I don't know which one. I know it's not a huge bug, but it's not expected behavior and it really gets in the way of my typing flow. I have to stop, go back to select the word, and make it italic again." cheekyboots 22049 "Reading settings let users choose between ""Full text"" or ""Summary"" for the feeds but not for the blog page" General 1.2 normal normal Awaiting Review enhancement new 2012-09-30T00:35:38Z 2012-10-01T11:20:57Z "Please make the life of new Wordpress users easier. Why not let users chose with a simple option if they want Wordpress to show the ""Full text"" or a ""Summary"" of the posts on the blog page? == Scenario == '''> OPTION 1:''' If user checks option 1 (""Full text"") the blog page would ''always'' (!) show Full text. '''> OPTION 2:''' If user checks option 2 (""Summary"") the blog page would show summaries based on the following priority order: '''1)''' Teaser (generated with the ""more"" tag"") '''2)''' Manual excerpt (if there is no ""more"" tag in the post) '''3)''' Automatic excerpt (if there is no manual excerpt and no ""more"" tag in the post) The way it is working now seems very confusing to me. Relation between ''manual excerpts'', ''automatic excerpts'' and ''teasers'' is everything but simple to understand for a beginner. Moreover some themes use the ""''the_content()''"" tag in their post template while others use the ""''the_excerpt()''"" tag. This makes the whole thing even more difficult to understand when switching from a theme to another. Such a '''basic''' option is available for the feeds. It should also be available for the pages, shouldn't it? '''Please check the attached image as my English is not perfect. ''' Thanks P.S. The ""[http://wordpress.org/extend/plugins/post-teaser/ Post teaser]"" plugin might be a good starting point." Lorangeo 22043 Undocumented default of post_type parameter to WP_Query with taxonomy queries Query normal normal Awaiting Review defect (bug) new 2012-09-28T19:24:35Z 2012-11-01T11:53:41Z "post_type parameter default depends on the is_tax attribute. This is not documented here: http://codex.wordpress.org/Class_Reference/WP_Query#Type_.26_Status_Parameters If is_tax is true, and post_type is not provided, the default of 'any' kicks in, and if is_tax is not set, the default of 'post' kicks in. Either it is a bug, or perhaps just the documentation needs to be updated. Please let me know what you think. Thank you for sharing your software." dbernar1 22041 Importer dies silently when multisite upload limit is reached Import normal normal WordPress.org enhancement new 2012-09-28T17:58:57Z 2012-09-28T18:03:31Z "The scenario: You're importing a WXR file into a site on a multisite network and the WXR includes a number of large attachments. For whatever reason, the upload capacity for each site is set at 100MB. If the upload capacity is reached during the import process, the import will look like it's hanging forever. Instead, it would be nice to show an alert that the upload capacity was reached or similar." danielbachhuber 22040 wp_dashboard_recent_comments queries do not skip comment_approved=spam Performance normal normal Awaiting Review defect (bug) new 2012-09-28T17:56:47Z 2013-02-02T05:42:22Z "There is am oversight in `wp_dashboard_recent_comments` which can cause a large delay in the admin area for large sites that may have a lot of spam (ie. set by akismet) Ironically the function contains the documentation ""Select all comment types and filter out spam later for better query performance."" This is not the case, in fact it's the opposite. Filtering out the spam later via php and wp filters is far far slower since there is (now) an index on `comment_approved`. As it is, it causes dozens of extra queries while it loops through all the comments 50 at a time in mysql when they contain a great deal of spam, and then via php filters the spam out (even for admin). Since there IS an index on `comment_approved` that can be used, to fix this you should only show `WHERE comment_approved='approved'` OR `comment_approved='moderated'` Or do the reverse with `comment_approved!='spam'` Since WP 3.5 has switched to a query class for comments, it should in theory be easy to add the additional WHERE condition for comment_approved." _ck_ 22037 Customizer: Live preview fetches page but does not display Appearance 3.4.2 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-09-28T15:14:54Z 2012-11-14T17:29:37Z "I just set-up a plain installation of 3.4.2. Configured it for multisite use. Set-up two sites, both working fine. When going into a sites Appearance settings to customize the theme (TwentyEleven), the Customizer shows the control panel on the left, but the preview remains blank. Firebug shows no Javascript errors. '''It also shows, that a POST request is sent to fetch the front page and that the page is actually returned in the response. It appears the response is just not added to the right-hand preview area.'''" marcoliverteschke 22029 Install multiple plugins Plugins 3.5 normal normal Awaiting Review feature request new 2012-09-28T00:44:34Z 2013-04-09T08:51:32Z "The new favourite plugins list is very welcome. On this list, or in general, I would like to be able to install several selected plugins. The use case is for site admins, pretty much the same use case as for the new favourites list. That featured would be really useful if one could install many plugins at a time, as one can upgrade many selected plugins at a time. The use case when searching in other categories of plugins is not so obvious. It could be a special feature for the favourites list, or it could be available on all kinds of plugin search results." knutsp 22028 Comments feed Feeds 3.4.2 normal normal Awaiting Review defect (bug) new 2012-09-28T00:29:04Z 2012-09-28T08:04:24Z "The problem I have noticed is with the comments feed however I think that this can happen with any of the other feeds. When there are no comments accessing somedomain.com/comments/feed will cause a 404 error message in some browsers and in others just a blank screen, no errors whatsoever are generated which makes it very hard to figure out what the underlying cause is. I would suggest providing a message that clearly states the lack of comments instead of a 404 error message or blank page, I think this same problem applies to all other feeds except it is clearly not noticeable as posts are the first things that are created after a clean install but comments can sometimes take longer or may not even happen however the comments feed url is added in the head of the document causing the site to have a broken link." tlacaelelrl 22023 Remove UNIQUE for slug in wp_terms Taxonomy 2.3 normal normal Future Release enhancement new 2012-09-27T20:23:10Z 2013-05-14T13:38:13Z "To set us up for future changes to the taxonomy API, we should remove the UNIQUE key for 'slug' for wp_terms. Said future changes include: * Splitting shared terms on update (#5809) * Stop creating shared terms (#21950) * Forcibly split remaining shared terms * Merge wp_terms and wp_term_taxonomy (I can dream, right?) The term_exists() check should prevent duplicate terms from ever being inserted (before, of course, we fix #5809 and #21950). But, this needs unit tests, particularly because there is a case where term_exists() breaks. See #17689, which blocks this ticket." nacin 22022 Can’t properly add pages of type edit.php?post_type=xxx as submenu items to arbitrary parent menus Administration 3.0 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-09-27T20:22:43Z 2013-01-11T11:22:48Z "The following code illustrates the problem. {{{ add_menu_page('My Pages', 'My Pages', 'edit_posts', 'parentslug', array(class, func)); add_submenu_page('parentslug', 'Settings', 'Settings', 'edit_posts', 'mysettings', array(class, func)); add_submenu_page('parentslug', 'Custom Post Type', 'Custom Post Type', 'edit_posts', 'edit.php?post_type=xxx'); }}} When you click on the first submenu item, the menu stays open, displaying the submenu items as it should. When you click on the item for the custom post type, the parent menu is closed and submenu pages are not displayed. The root of the problem is how $parent_page is handled for pages of type edit.php?post_type=xxx. In get_admin_page_parent(), $parent_file is always set to $submenu[$parent], which may cause the submenu slug to be different from $parent_file. But in _wp_menu_output, if the submenu slug and parent slug are not equal, the 'wp-has-current-submenu wp-menu-open' classes do not get added which means the menu gets displayed as being closed. Since there are no actions called between get_admin_parent_page() and the output of the menu, the only workaround I can see is some ugly JS that fixes up the classes. It seems like the least intrusive fix would be to just move the call to apply_filters(""parent_file) in menu-header.php to after the call to get_admin_page_parent() so that $parent_file can truly be overridden. This also seems inline with the intent of the filter. " jjharr 22014 $arg was undefined, added it as optional param External Libraries 2.5 normal trivial Awaiting Review defect (bug) new 2012-09-27T09:40:45Z 2012-09-27T09:56:35Z "The variable $arg was not defined, so I added it as an extra parameter. wp-admin/includes/class-ftp.php function nlist Patch here : https://github.com/h4ck3rm1k3/WordPress/commit/1bb897fc0e20de43122a468d1dae85ad2ad33c37" h4ck3rm1k3 22010 RSS Widget with hardcoded icon and style Widgets normal normal Awaiting Review defect (bug) new 2012-09-26T22:13:58Z 2012-09-26T22:13:58Z "Standard RSS Widget outputs hardcoded icon and oldschool inline style=""border:0"" e.g. {{{ }}} this makes it hard to style (even more that the parent anchor has the same css class as following title, so you can't even hide it without some css3 only magic (:first) IMO this part of WP_INC/default-widgets.php row 766-777 {{{ $icon = includes_url('images/rss.png'); if ( $title ) $title = "" $title""; }}} + line 764 should be replaced by standard way e.g. {{{ $title = apply_filters( 'widget_title', empty( $instance['title'] ) ? __( 'RSS' ) : $instance['title'], $instance, $this->id_base ); }}} so when someone wants to output there an icon, he could simply with the widget_title filter" thomask 22009 Menu Builder URL structure Menus 3.4.2 normal normal Awaiting Review enhancement new 2012-09-26T21:16:12Z 2012-09-26T21:16:12Z "Menu builder is a great functionality, but I can't figured it out why URL structure is based on page builder rather than menu builder?[[BR]] In my point of view, it would make more sense if we could define a simple ""identifier"" for each page (ie : ""my-page"" for a page named ""My page"") and build architecture in menu builder (or make it optional) --> the URL structure will be generate base on the menu builder hierarchy.[[BR]] Actually, when moving an element, we have to define a new parent in the page builder to follow the menu logic?" will83 22003 Saving custom fields goes to post-new.php rather than post.php Administration 2.5 normal normal Awaiting Review defect (bug) reopened 2012-09-26T15:57:01Z 2012-09-26T19:19:54Z "Create a new post or page. Add a title and message. Add a custom field (click ""Add Custom Field"") The post is saved, but as you are taken to post-new.php rather than post.php, it looks as if your post has disappeared! All is well - it is actually saved - but it's confusing. Tested on 3.5-alpha-21989" curiousdannii 22001 Handling private and protected posts when querying multiple post types Query 3.4 normal normal Awaiting Review defect (bug) new has-patch 2012-09-26T14:16:17Z 2012-09-28T07:57:52Z "When querying multiple post types (e.g. new WP_Query(array('slug'=>$slug, 'post_type'=>'any') the automatic handling of protected and private posts fails because it looks for capabilities 'edit_any' and 'read_any' which don't exist. The attached patch illustrates the problem with a suggested fix. However it's possible I have misunderstood how this is supposed to work." tamlyn 21999 Passing cookie arguments to the HTTP API should be easier HTTP 3.4.2 normal normal Awaiting Review enhancement new 2012-09-26T06:24:38Z 2012-09-26T06:24:38Z "If you want to set cookies during a remote HTTP request in WordPress, it's currently a rather pain in the ass to do. Rather than having to deal with `WP_HTTP_Cookie`, it'd be nice if you could just pass a `name => value` array and have the rest taken care for you behind the scenes." Viper007Bond 21994 Subdomains may not exceed 63 characters in length Network Admin 3.4 normal normal Awaiting Review enhancement new has-patch 2012-09-25T22:31:44Z 2012-09-28T07:57:15Z "According to section 3.1 ""Name space specifications and terminology"" of [http://www.faqs.org/rfcs/rfc1034.html RFC1034], domain names are nodes in a tree structure and ""Each node has a label, which is zero to 63 octets in length."" WP should help to correctly enforce this requirement, so I've attached a patch that adds a maxlength=""63"" attribute on the input field on line 126 of wp-admin/network/site-new.php. This should help sites and network admins prevent the creation of blogs hosted on subdomain installs that will not resolve properly, and at the same time allow for maximum length subdomains." humanshell 21991 Username input placeholder text cut off WordPress.org site normal normal WordPress.org defect (bug) new 2012-09-25T08:18:21Z 2012-09-25T08:18:21Z "On wordpress.org I'm invited to log in using my ""Username or em""." johnbillion 21989 update_option() calls sanitize_option() twice when option does not exist Administration normal normal Awaiting Review defect (bug) new dev-feedback 2012-09-25T05:04:34Z 2012-09-25T05:54:32Z " I just spent several hours tracking down an issue when using the Settings API where `sanitize_option()` is called twice which is unnecessary execution especially if sanitization includes calling an external API for username/password authorization ''(this was how another developer set it up for a plugin I was debugging.)'' What happens is that a call to `update_option()` will call `sanitize_option()` and then if the option wasn't previously in the options table `update_option()` will delegate to `add_option()` which calls `santize_option()` a second time. This would normally be easy to workaround by first calling `get_option()` and testing for `false` and calling `add_option()` instead of `update_option()` if `false`, but not when the Settings API chooses how to call it. I've looked at the problem and can envision several different ways to solve it such but don't know which the core developers would choose ''(or if they'd choose yet another option I haven't envisioned)'' so I didn't submit a patch: - Adding a 3rd parameter `$mode` to `sanitize_option()` that identifies the mode ''('add', 'edit', default = 'unknown')'' and thus allow the hook to ignore one of the options ''(this would be more backward compatible but would put the onus on the developer to know to do this)'', - Adding a 5th parameter `$bypass_sanitize` to `add_option()` defaulted to `false` that is only passed as `true` in `update_option()` allowing `update_option()` to disable the call to `sanitize_option()` found in `add_option()` ''(this would be less backward compatible and hacky, but seemless to the developer)'' - Adding a 3rd parameter `$bypass_sanitize` to `update_option()` defaulted to `false` that is only passed as `true` from `/wp-admin/options.php` allowing `update_option()` to bypass the call to `sanitize_option()` if an `add_option()` will happen ''(this would be less backward compatible and hacky, but seemless to the developer)'' - Have `/wp-admin/options.php` test for no pre-existing option and then call `add_option()` or `update_option()`, respectively ''(this would be seemless to the developer but less backward compatible and not hacky, and it wouldn't handle the general case.)'' So is this worth fixing to save other users and developers debugging time, and to reduce the chance of subtle errors in new code? If yes, how best to approach?" MikeSchinkel 21988 Filter get_media_item output Media 3.4 normal normal Awaiting Review enhancement new dev-feedback 2012-09-25T03:56:27Z 2012-09-25T09:38:43Z "L1027-1028 of media.php looks like this: {{{ if ( $item = get_media_item( $id, array( 'errors' => isset($errors[$id]) ? $errors[$id] : null) ) ) $output .= ""\n $item\n""; }}} The biggest issue I see with this is that because you can only attach images to one post, this will unnecessarily display images that cannot be attached to the current post type in instances where the Media Library tab is forced to send items even though no editor support has been added for the post type. In that light, it would be nice to have a filter to remove the output of these unnecessary items in order to improve UI and UX when navigating through images to attach to the post type. Currently I am having to create an error-like overlay on each item that is already attached in order to prevent users from trying to attach an item that is already attached elsewhere. Where would it make the most sense to have this filter? At the end of get_media_item? " griffinjt 21987 function get_post_time - if gmt (unset) Date/Time normal minor Awaiting Review defect (bug) new has-patch 2012-09-24T19:33:18Z 2012-12-05T08:47:55Z "For no publish items and mode auto-draft = close if GMT is unset ('0000-00-00 00:00:00' == $post->post_date_gmt) at wp-includes/general-template.php function get_post_time effect list table -> date column (Last Modified -> %s hours) Effect code : wordpress\wp-admin\includes\class-wp-posts-list-table.php class WP_Posts_List_Table -> function single_row Line 579 : $time = get_post_time( 'G', true, $post ); I don't know if it affects something else ... " soficgr 21986 Roll sticky posts into MySQL query Query 3.4.2 normal normal Awaiting Review enhancement new has-patch 2012-09-24T19:10:09Z 2012-12-19T19:53:55Z "The way that WP currently queries for sticky posts is quite long winded and prone to error. Sticky posts output behaviour is erratic when using pagination or ordering. I suggest that the sticky posts feature would be better served by being rolled into the MySQL query rather than trying to reconstruct the result set after the main query has run. I have tested the attached patch against 3.4.2 and it works as expected. The query additions are performed on every page of home, rather than just the first, so that page boundaries behave as expected and that the sticky posts don't appear on subsequent pages. ignore-sticky-posts is honoured." martinshopland 21982 check wp_authenticate_cookie Users 3.4.2 normal normal Awaiting Review enhancement new has-patch 2012-09-24T06:45:56Z 2012-09-24T06:45:56Z "I am analyzing the authentication system wordpress, caught my atension the function logic `wp_authenticate_cookie` in (`wp-includes/user.php`) and decided to make a very small change. >I made a file of changes: > https://gist.github.com/3774628" fitorec 21977 Allow 0, NULL and empty string values for 'parent'. XML-RPC normal normal Future Release defect (bug) new dev-feedback 2012-09-23T18:28:04Z 2012-11-07T21:51:29Z We must allow 0, NULL and empty string values for 'parent' in wp_newTerm and wp_editTerm sam2kb 21976 "Remove the ""standard"" fullscreen mode from the default configuration of TinyMCE" TinyMCE normal normal Future Release enhancement new has-patch 2012-09-23T18:07:56Z 2012-11-07T22:16:57Z "The ""standard"" TinyMCE fullscreen is incompatible with the DFW fullscreen. Currently we are loading both plugins and trying to give access to the standard fullscreen by shortcut only. This is left over from when DFW was working only for the Edit Post screen. Best would be to remove the standard fullscreen completely. It can be added by a simple WordPress plugin for users that prefer it." azaozz 21969 Wrong URL in wp_enqueue_script() Themes 3.4 normal normal Awaiting Review defect (bug) new has-patch 2012-09-22T19:21:21Z 2012-09-28T08:06:31Z "This problem is probably related to fixed ticket #21749 Example theme directory {{{ wp-content/themes/Some Theme/Theme }}} I noticed it with one premium theme. Users usually upload downloaded files through FTP with one more parent directory. Function get_template_directory_uri() returns right URL: {{{ wp-content/themes/Some Theme/Theme }}} But using it with wp_enqueue_script(): {{{ wp_enqueue_script( 'maxheight', get_template_directory_uri() . '/js/maxheight.js' ); }}} it returns wrong URL: {{{ wp-content/themes/SomeTheme/Theme/js/maxheight.js }}} And script is not loaded in the end (Not Found error). Reproduced on current trunk and 3.4.x." pavelevap 21963 Consolidate post insertion APIs Post Types normal normal Future Release defect (bug) new needs-unit-tests 2012-09-22T03:46:24Z 2012-12-27T15:14:44Z "In wp-includes, we have: * wp_insert_post() * wp_insert_attachment() * wp_update_post() * wp_publish_post() For saving from the admin, we have: * edit_post() * wp_write_post() * write_post() '''wp_publish_post()''' is, as of [21942], now wraps wp_insert_post(). '''wp_update_post()''' is a fairly mundane wrapper of wp_insert_post(), but we really should eliminate the differences between the two functions and make it a straight-up wrapper. '''wp_insert_attachment()''' was a fork of wp_insert_post(), and wp_insert_post() has gotten a lot of improvements that haven't reached wp_insert_attachment(). It doesn't take much to merge these two, though, and make wp_insert_attachment() a wrapper. '''wp_write_post()''' calls edit_post() if it has a post ID. And since we have had a post ID since the days of auto-drafts, this function is dead code. It's wrapper, '''write_post()''', can also be deprecated. I'm attaching a patch that takes care of wp_insert_post(), wp_write_post(), and write_post(). wp_update_post() will require a bit more concentration. Needs testing and unit tests." nacin 21959 No way to override the name of an image when that is being resized Media 3.4.2 normal normal Awaiting Review enhancement new needs-docs 2012-09-21T16:34:23Z 2012-09-22T20:42:44Z "The most obvious solution is to add a hook to allow the destination file name to be modified. The solution attached gives pretty much all the information you could possibly want to modify the filename as you might need to." jkmassel 21950 Don't create shared terms Taxonomy normal normal Awaiting Review enhancement new 2012-09-20T22:52:48Z 2013-01-15T17:04:02Z "Step 1: Split shared terms: #5809 Step 2: Don't create new shared terms: this ticket. Step 3: Profit." scribu 21949 Allow private taxonomies (public = false) Taxonomy normal normal Future Release enhancement new commit 2012-09-20T22:22:14Z 2013-05-14T13:33:47Z "In a discussion with jaredatch & nacin, we discovered that the public arg is not working properly within WordPress query. So I merged Limiting publicly queried post_types to those that are publicly_queryable with limiting publicly queried taxonomies to those that are public instead of just duplicating the code and making it for taxonomies." wpsmith 21947 Fix 3-column dashboard display Administration 3.4 low normal Awaiting Review defect (bug) new has-patch 2012-09-20T20:06:46Z 2013-04-14T06:02:52Z "Issue #20015 'enhanced' the dashboard with a pure-CSS based multi-column dashboard. Excellent. The CSS used makes gross assumptions about how many columns are appropriate for different-sized displays. Double plus ungood. Users should be left to decide how many columns they wish to use. There was [http://wordpress.org/support/topic/three-column-dashboard/ considerable discussion] of this when 3.4 was released, but no remedy yet, other than to hack away at the CSS of one's install, precluding upgrades; I've changed {{{@media only screen and (min-width:800px) and (max-width:1200px){}}} to {{{@media only screen and (min-width:800px) and (max-width900px){}}} in wp-admin.css to get a usable interface." belg4mit 21945 wp_list_categories feed links unaware of custom type Post Types 3.4.1 normal normal Awaiting Review defect (bug) new 2012-09-20T19:40:27Z 2012-09-20T20:35:47Z "wp_list_categories accepts a taxonomy argument to specify a custom taxonomy, and correctly lists item of said taxonomy. However the feed links produced lack the necessary ?post_type= for the corresponding custom post types that may be used with a category. Ideally the function could auto-detect stuff and do the right thing automatically. Less ideally it might accept another argument to define the post types used in the category. At a minimum, this should be documented, and a work-around such as the following included: {{{ function wp_list_cat_custom_feed($txt){ return preg_replace('/\/feed\/?/', '/feed/?post_type=foo', $txt); } add_filter('wp_list_categories','wp_list_cat_custom_feed'); }}} " belg4mit 21941 Remove get_post_format_slugs() General normal minor Awaiting Review enhancement new dev-feedback 2012-09-20T14:40:52Z 2012-09-20T14:41:03Z "I just encountered the `get_post_format_slugs()` function, which is basically just wrapping `get_post_format_strings()` and setting the strings as keys too. So its output is an assoc array where the keys equal the values. The three times core calls it, it does it the following: {{{ // ~/wp-includes/posts.php -> set_post_format() if ( 'standard' == $format || !in_array( $format, array_keys( get_post_format_slugs() ) ) ) // ~/wp-includes/posts.php -> _post_format_request() $slugs = get_post_format_slugs(); if ( isset( $slugs[ $qvs['post_format'] ] ) ) $qvs['post_format'] = 'post-format-' . $slugs[ $qvs['post_format'] ]; // ~/wp-includes/theme.php -> add_theme_support() switch ( $feature ) { case 'post-formats' : if ( is_array( $args[0] ) ) $args[0] = array_intersect( $args[0], array_keys( get_post_format_slugs() ) ); break; }}} So in every case it would've been enough to simply call `get_post_format_strings()`. Do we really need this function?" F J Kaiser 21938 "Add ""no-store"" to Cache-Control header to prevent history caching of admin resources" Administration 3.4 normal trivial Awaiting Review enhancement new has-patch 2012-09-20T10:54:27Z 2012-09-28T07:56:36Z "The current implementation of [http://core.trac.wordpress.org/browser/trunk/wp-includes/functions.php#L891 wp_get_nocache_headers] does not take into account history caching, which results in a browser serving a cached copy of pages from history (by pressing the Back button) even if the user has long logged out. [http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.9.2 RFC 2616 14.9.2 no-store] describes this cache directive. To repoduce: login to dashboard, logout, press the back button. Expected: the login screen. Reality: a copy of the previous page. By adding the ""no-store"" directive to all non-cachable resources the behavior was mitigated successfully in Chrome 21, Firefox 15. Fails on Opera 12 (they chose to disregard ""no-store"" when applied to history, RFC allows this)." soulseekah 21934 Title field on Insert/edit link form shouldn't allow autosuggest Editor 3.4.2 normal normal Awaiting Review defect (bug) new dev-feedback 2012-09-19T21:10:18Z 2012-09-20T22:37:44Z "When entering a link through the ""Insert/edit link"" thickbox form, Firefox displays autosuggest dropdowns for both the URL field and the title field. This would be helpful, except that the javascript keyboard handlers bound on keydown/keyup prevent the browser UI from being accessible. What happens is: 1. User tries to add link to text through the editor (Visual or HTML). 1. User enters the correct URL into the URL field, and exits that field by hitting ""tab"". 1. User begins typing the link title. Firefox browser UI helpfully suggests some similar titles. 1. User sees a title they'd like to use, and hit the keyboard down arrow, thinking that this will select the correct title for them. 1. What actually happens is that the first link listed below in the link to existing content gets selected. This overwrites what's been entered in the URL and title field. 1. User says, WTF just happened. Solutions: - Adding `autocomplete=""off""` to these two form fields would prevent Firefox from displaying its autosuggestions. This might fix the problem, but feels kind of like a bandaid. - A keydown/keyup handler could be attached to each of the text input fields with event.stopPropagation could stop the ui keyboard behavior when typing into those fields." goldenapples 21931 White screen of death if theme can't be found Themes normal normal Awaiting Review enhancement reopened dev-feedback 2012-09-19T16:55:39Z 2012-09-21T15:31:41Z "If the current theme can't be found or is renamed, the front-end of the site will white screen. This is developer error, as when WP_USE_THEMES is true, the template loader should always have a template to load (as far as I understand). It's rare, but I come across it every once in a while in developing. It might be nice to have a wp_die() if a proper template can't be found in template-loader. Proof of concept: {{{ if ( $template = apply_filters( 'template_include', $template ) ) include( $template ); else wp_die(""Whoops! Looks like you're missing a theme.""); }}}" ericlewis 21930 Allow hooks to define avatar before Gravatar processing General 3.4 normal trivial Awaiting Review enhancement new has-patch 2012-09-19T16:30:35Z 2012-09-28T08:13:29Z "The get_avatar() function allows for developers to override avatar output in two ways. You can replace the function (pluggable) - not a good idea in my view, especially if you still want the ability to fallback and use Gravatar sometimes. You can also filter the output at the very end of the function with the 'get_avatar' hook. This works fine, but in highly common instances where a plug-in might want to override the avatar on a case by case basis, this forces each get_avatar call to needlessly process through the entire default avatar / Gravatar ""construction"". Admittedly, that processing is mostly trivial string manipulation and conditionals with an md5 in the mix, but it still seems like needless overhead in instances where many avatars might get called in a comments thread or authors list. Proposing a pretty trivial change that allows an avatar to be defined by a filter hook before proceeding through Gravatar / default avatar processing, skipping over all of that if one is, in fact, defined. My inspiration for this is an attempt to improve the performance of my fairly popular Simple Local Avatars plug-in, that allows users to upload local avatars: http://wordpress.org/extend/plugins/simple-local-avatars/" jakemgold 21925 Ability to upload multiple .zip files to install in bulk Administration normal normal Awaiting Review feature request new 2012-09-19T12:40:09Z 2012-09-28T08:03:18Z "It'd be nice to have a drag-and-drop or similar functionality to the Media Uploader to be able to select 5, 10, 17 plugins/themes to upload several .zip files at a time. Of course, if a folder already exists or if you upload a theme .zip to the plugins page or something like that, then display the appropriate error(s). Otherwise, display the success notification per install." cliffpaulick 21924 add action / filter to wp-login.php so we can replace WordPress login and force using 3rd party login Security normal normal Awaiting Review feature request new 2012-09-19T11:59:58Z 2012-09-19T11:59:58Z "I want to turn off WordPress login because I don't have an SSL certificate. I want to replace (not just hide with CSS or something) the WordPress wp-login.php login form so that a plugin can hook into that and be called within themes that use the hook to display the WordPress login form. Then, if the plugin is disabled, the generic WordPress login will display by default/fallback. Worst concern about this is the plugin failing, especially upon an update or theme change or something and this can be fixed by logging in and disabling the plugin via FTP or via database or something. (Of course, applies to both ""login"" and ""register"", not just ""login"".) What I tried before posting here: http://premium.wpmudev.org/forums/topic/is-there-a-plugin-to-disable-wordpress-default-login?replies=9#post-276574 and http://www.wpquestions.com/question/show/id/7065 Might be related to: http://core.trac.wordpress.org/ticket/19097 Thank you very much." cliffpaulick 21919 Theme Customizer: loading preview with FORCE_SSL_ADMIN does not work Multisite 3.4.2 normal normal Awaiting Review defect (bug) new 2012-09-18T14:17:28Z 2012-09-18T14:17:28Z "When FORCE_SSL_ADMIN is configured theme customizer JQuery will try and load the theme preview over ssl and get a 302 redirect error. The path is https://site.com/?customize_messenger_channel=preview... redirects to http://site.com/?customize_messenger_channel=preview... since site is non-SSL." Jasonheffner 21918 WP_Customize_Control() doesn't work with add_setting() default theme_mod type Themes 3.4.2 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-09-18T11:29:03Z 2012-09-18T13:54:58Z "Consider the following code: {{{ $wp_customize->add_setting($color,array( 'default' => '#000000', 'sanitize_callback' => 'sanitize_hex_color', 'capability' => 'edit_theme_options', 'transport' => 'postMessage' ) ); $wp_customize->add_control(new WP_Customize_Color_Control($wp_customize,$color,array( 'label' => 'somelabel', 'section' => 'colors' ) ) ); }}} The default 'type' used for add_setting() is 'theme_mod' as defined in http://codex.wordpress.org/Class_Reference%5CWP_Customize_Manager%5Cadd_setting The WP_Customize_Color_Control '''does not''' accept the 'default' setting when there is no 'type' specified. The WP_Customize_Color_Control '''does accept''' the 'default' setting when 'type' is either set to 'option' or 'theme_mods'. Setting it to 'option' makes no sense because that would imply that one would be using a custom option database field with get_option() instead of the default database field used by get_theme_mod(). Because setting it to 'theme_mods' works and 'theme_mod' does not i suggest checking code for typos. Expected behavior would be for it to work with theme_mod/get_theme_mod stored values when the default 'type' is used." sebstyle 21913 Detecting MIME Types in WXR Files Import 3.4.2 normal normal WordPress.org enhancement new dev-feedback 2012-09-17T21:09:07Z 2012-10-10T21:46:11Z "In the process of creating a service to convert TypePad data to WXR formatted files, we've encountered some unique problems with TypePad data. Namely, many TypePad files are saved without file extensions, which prevents the existing importer from importing those files into the wp-content/uploads folder. In order to import and rename these otherwise ignored files, we've created a patch for the WordPress importer that does the following: 1. If there is an attachment in the WXR and the importer is not able to determine the file type from the file name (ie missing extension), the patched version will make a light (body-less) request to the web server where the file is hosted for information we can use about the file. The things we're interested in are file type, size, and filename. 2. If the importer is processing an attachment under the above situation, and it is able to determine the file type, then it will rewrite the local version of the file to have the appropriate file extension. This is a simple bit of code, but it makes a huge difference as TypePad saves without file extensions quite regularly. We've attached our patch and a sample WXR file from ragsgupta.com, the Brightcove co-founder's blog." ReadyMadeWeb 21912 Add return filter to current_theme_supports() Themes 3.4 normal normal Awaiting Review enhancement new has-patch 2012-09-17T18:39:29Z 2012-09-28T08:06:29Z "current_theme_supports() makes it hard for plugins to affect whether a theme supports a certain feature. The use case I have is that I am building a plugin that utilises bbPress (and soon, BuddyPress)-style template compatibility parts. In those template parts, I display something very, very similar to a post thumbnail or custom header. I want to use the ""Featured Image"" metabox on the Post screen to set that image. If I use the plugin on a theme that doesn't support post thumbnails, the metabox correctly doesn't appear, and so users have no way of choosing a featured image. While there are ways around this -- manual conditional registering of the Featured Image metabox, creating my own metabox, or calling add_theme_support/remove_theme_support like a toggle -- none of them are particularly elegant. While current_theme_supports has a return filter, it's not reached by all code execution paths. The attached patch reworks the function so that the return value is always passed through the filter." DJPaul 21911 Add 'All Themes', 'Parent Themes' and 'Child Themes' tabs Administration 3.4.2 normal minor Awaiting Review enhancement new close 2012-09-17T18:37:44Z 2013-03-08T15:31:36Z "When you have multiple themes installed which are a mixture of parent and child themes, it can be a bit overwhelming sometimes to have ALL themes lumped together in one view. It would be nice on the themes.php page to replace the 'Available Themes' text with some tabs such as: All Themes | Parent Themes | Child Themes The 'All Themes' tab would show all available themes (default view), 'Parent Themes' tab would only show parent themes, and 'Child Themes' for child themes, but only if any are installed (to prevent an empty tab from being shown). Hopefully this wouldn't be too hard to implement, but would be pretty handy for the end user for multiple available themes. An extension to this could have a further tab called something like 'Favorites' where you can flag certain themes you like. This could be a great way of displaying just a select custom subset of themes that you have complete control over (only if at least one theme had been flagged as a favorite). All Themes | Parent Themes | Child Themes | Favorites " dgwyer 21910 wpmu_create_user() standardization Multisite 3.0 normal minor Awaiting Review enhancement new 2012-09-17T18:03:24Z 2012-09-17T23:36:26Z "There seems to be some inconsistencies between wpmu_create_user(), create_user(), and wp_insert_user(). The former two are wrappers, and do different things but potential to consolidate and clean up some old code. Per Nacin: >nacin: wpmu_create_user() should probably just go away. >nacin: fairly useless function >nacin: by default, it looks like wp_insert_user() would create a role-less user. >nacin: as would wp_create_user() Looking at wp_insert_user() it sets the default role if none is provided, where wpmu_create_user() would actually delete the default roles and caps. Although, I'm not really sure there's a use case where you'd be using both the wpmu_new_user and user_register hooks simultaneously so possibly depreciate the former in favor of the latter. One real issue with wpmu_create_user is that it returns false instead of the WP_Error object which is probably not desired since the error could be useful. The false return is used in wpmu_activate_signup() to either set the returned ID or create it's own WP_Error. Lastly... documentation for create_user says it returns the ID, but it looks like it could potentially also return a WP_Error object. Didn't test, but possible documentation fix there. " ryanduff 21900 update_post_meta() returns FALSE when meta_value to be updated is the same General 3.4.2 normal normal Awaiting Review defect (bug) new 2012-09-15T17:15:17Z 2012-10-13T00:52:12Z "Since [14564] update_metadata() (wp-includes/meta.php [20435]) in lines 129-136 checks to see if the meta_value to be updated is the same as the value that already exists in the database. The point of this check, presumably, is to prevent running a needless UPDATE query. That's fine and good. Currently, if the values are the same the function returns FALSE. I think it should return TRUE in this case. While I understand that from one point of view it should be false, since nothing was actually updated, if I'm trying to update my metadata to a certain value, and the end result is that the value in the database matches the value I submitted, isn't that a win? In other words, even though no UPDATE query was actually executed, the postmeta was ""updated"" to have the value that was specified in update_post_meta(). Here's an example of when this could be an issue: {{{ function my_plugin_ajax_save_metadata() { // create a success flag $success = true; // $postid passed in via post variables $postid = $_POST[ 'postid' ]; // data fields from post passed in from a serialized array parse_str( $_POST[ 'data' ], $fields ); // my custom post meta fields all have names that begin with _mymeta foreach( $fields as $key => $val ) { // if a field is one of my meta fields, attempt to update it if ( false !== strpos( $key, '_mymeta' ) ) { // if $val is the same as what's already in the db, $success will be false $success = update_post_meta( $postid, $key, $val ); } if ( false === $success ) { // uh-oh, update_post_meta failed, need to handle it // but updating a meta value to the same value is not really a fail $message = ""Error updating metadata: $key = $val""; break; } } echo ( $success ) ? 'Success.' : $message; exit; } add_action( 'wp_ajax_save_meta', 'my_plugin_ajax_save_metadata' ); }}} Of course, I could use get_post_meta() to find out if values have changed before calling update_post_meta(), but since update_metadata() already does this (line 131), it seems wasteful for me to have to do it. I guess another alternative would be to return something besides TRUE or FALSE when the values are the same, but I'm not sure what that would be. " mcbenton 21899 Missing class identifier for password protected posts Template 3.4.2 normal normal Awaiting Review enhancement new 2012-09-15T17:00:40Z 2012-09-15T17:00:40Z "Password protected posts are insufficiently identified for good CSS styling. Presently, the class name ""post-password-required"" is added to protected posts if a valid password cannot be found in the cookie. On the other hand, no special class name is added to protected posts if a valid password *can* be found, even though this is just a temporary condition until the cookie expires. I suggest that both cases are interesting from a CSS styling perspective. Note that the title of protected posts is prefixed by the string ""Protected:"" in both situations. This behaviour occurs because get_post_class() just checks post_password_required() [which validates the cookie] but get_the_title() just checks if the $post->post_password field is not empty. I suggest an additional class name should be added by get_post_class() for the case when the post->post_password field is not empty. Current usage of class names here is not very consistent with the admin tool, so options might be ""visibility-protected"", ""status-protected"" [similar to ""status-private"" which is added for those with visibility ""Private"" and reflecting the underlying implementation] or perhaps just simply ""protected"". Protected posts would thus be identified as follows: Protected, with correct password: class=""protected""[[BR]] Protected, missing or invalid password: class=""protected post-password-required"" See also #13860 and #18729. I can do a patch if needed but this is literally just a couple of lines of code (three if you include a comment)." mdgl 21894 tag does nothing in secondary loops when is_single because of $more global Template normal normal Awaiting Review defect (bug) new has-patch 2012-09-14T20:11:48Z 2013-03-07T01:19:02Z "In the sidebar of single posts I have a listing of short posts from a particular category. We recently started using the {{{}}} system to define teasers because in this case excerpts are overkill. The ""more"" system works for archive views but does nothing in the sidebar of single posts. The reason is the overly global nature of the {{{global $more}}} variable. It gets defined in {{{setup_postdata()}}} like this: {{{ if ( is_single() || is_page() || is_feed() ) $more = 1; }}} Then in {{{get_the_content()}}} global $more is checked to determine whether to apply the effect of the {{{}}} tag or not: {{{ if ( $more ) { // show full content with span ID } else { // show intro text and more link } }}} This means that any time {{{is_single()}}} is true all posts shown during the pageload ignore {{{}}}, even those who's {{{is_single}}} view we are not on. This seems like an understandable result of the unpopularity of the more tag (and rareness of showing ""full"" posts in secondary loops), but also something that should be fixed. Only the post who's single view we are looking at should have the more tag disabled based on the {{{is_single()}}} check. '''SOLUTION''' As far as I can tell what's needed is to modify {{{get_the_content()}}} and in addition to using {{{global $more}}}, also check if the post being shown is the same as {{{get_queried_object()}}}. My first instinct was to just add the check in the {{{if}}} statement above: {{{ if ( $more AND ( $post-ID == get_the_queried_object_id() ) ) { // show full content with span ID } else { // show intro text and more link } }}} Unfortunately that will screw with the {{{is_feed()}}}-related checks for {{{global $more}}}. Overall my investigation of {{{$more}}} is making me think it should be removed entirely, as it's only used a few times and in all cases its meaning is vague. Either way I think the simplest way to handle the issue in {{{get_the_content()}}} without completely stripping out {{{$more}}} is to use {{{$more}}} as the base for a {{{$show_full_content}}} variable, then set that to false if {{{$post->ID}}} doesn't match {{{get_queried_object_id()}}}: {{{ $show_full_content = $more; if ( is_single() OR is_page() ) { if ($post->ID != get_queried_object_id()) $show_full_content = false; } }}} The new variable gives a better sense of what it will do inside this function, and lets us change the value without stomping the {{{global $more}}}. The attached patch fixes {{{get_the_content()}}} as described above. If core devs are willing to I think the best solution would be to remove all uses of {{{$more}}} and simply replace them with the appropriate logic for the given situation like I've done above for {{{get_the_content()}}}. " jeremyclarke 21891 Need ability to filter page templates Template 3.4.2 normal normal Awaiting Review enhancement new close 2012-09-14T17:38:50Z 2013-01-13T18:33:14Z "The old way of removing a parent theme's templates (as documented [http://wordpress.org/support/topic/removing-page-template-from-child-theme?replies=3 here], [http://wordpress.stackexchange.com/questions/54054/how-to-remove-a-parent-theme-template-from-quick-edit here], and [http://stackoverflow.com/questions/9411612/wordpress-hiding-or-removing-parent-themes-templates here]) broke with the big theme-handling rewrite in 3.4. The primary use case of a new filter would be to allow a child theme to remove or rename a parent theme page template in the Dashboard. It's possible that part of the `get_page_templates()` function might have to be tweaked to allow for the scenario where one or more pages is using a template that no longer ""exists,"" but I'm not sure. Hopefully this is as simple as adding `apply_filters( 'page_templates', $page_templates );` somewhere in [http://core.trac.wordpress.org/browser/trunk/wp-includes/class-wp-theme.php#L920 class-wp-theme.php]." mrwweb 21890 Customizer spinner breaks button alignment with longer strings Appearance 3.4 normal normal Future Release defect (bug) new 2012-09-14T10:57:02Z 2012-11-08T22:01:23Z See the screenshot. SergeyBiryukov 21883 WP_Plugin action/filter concept Plugins lowest minor Awaiting Review enhancement new 2012-09-13T18:24:04Z 2012-10-22T19:58:57Z "Attached is a concept for allowing plugins to have dedicated action/filter loops. The problem: * Plugins like !BuddyPress and bbPress that have their own actions and filters pollute the global action/filter namespace. This isn't necessarily bad, but it's arguably not optimal. * Allowing plugins to have their own action/filter hooks means mirror action/filter names to match what's used in !WordPress, without adding more items to the global action/filter array. * !BuddyPress and bbPress namespace their actions with prefixes, I.E. 'bp_init', 'bp_ready' et all. This works fine, and is straightforward to use, so I'm not really even sure this patch is that good. * More conceptual than anything; it's intended as a fun experiment to toy with a new way of looking at !WordPress how actions/filters might evolve in the future. Attached is a big patch with a small example file. The patch is ugly looking, due to running out of time in the day and wanting feedback sooner." johnjamesjacoby 21881 wp_list_categories show_option_all does not work for custom taxonomy Taxonomy normal normal Awaiting Review defect (bug) new 2012-09-13T12:46:59Z 2012-09-13T13:41:09Z I am using wp_list_categories on a custom post type page to list the taxonomy values (categories). However if I include an All link it links by default to /blog/ and not /taxonomy/. arkinex 21879 wp_count_posts() cache is not destroyed after post inserts and deletions Cache 3.4.2 normal normal Awaiting Review defect (bug) new has-patch 2012-09-13T01:23:38Z 2012-09-13T02:11:19Z "`wp_count_posts()` caches its results, but that cache is not destroyed when posts are inserted, deleted, or transitioned. This can lead to incorrect counts. The attached patch fixes that (although it doesn't destroy the cache set when `$perm='readable'` in `wp_count_posts()`, which would be more complex as we wouldn't know the name of the key(s), though it could be done with `preg_match`). " mark8barnes 21876 unregister_default_headers() will sometimes return null Themes 3.4.2 normal minor Awaiting Review defect (bug) new 2012-09-12T19:23:07Z 2012-09-12T19:27:38Z "File: wp-includes/theme.php Function: unregister_default_headers() Line: ~1046 Problem: PHPDoc comment says: @return True on success, false on failure. Expected: true or false: Actual: `var_dump(unregister_default_headers(array('FAKE')));` will return NULL Suggested fix, change: {{{ function unregister_default_headers( $header ) { global $_wp_default_headers; if ( is_array( $header ) ) { array_map( 'unregister_default_headers', $header ); } elseif ( isset( $_wp_default_headers[ $header ] ) ) { unset( $_wp_default_headers[ $header ] ); return true; } else { return false; } } }}} To: {{{ function unregister_default_headers( $header ) { global $_wp_default_headers; if ( is_array( $header ) ) { $_ret = array_map( 'unregister_default_headers', $header ); return in_array(false, $_ret, true) ? false : true; } elseif ( isset( $_wp_default_headers[ $header ] ) ) { unset( $_wp_default_headers[ $header ] ); return true; } else { return false; } } }}} Thank you for your consideration." conner_bw 21874 Remove unused functions in wp-admin/includes/update.php Upgrade/Install 2.8 normal minor Awaiting Review enhancement new has-patch 2012-09-12T05:13:06Z 2012-09-12T10:22:52Z Just noticed these two functions, `wp_update_plugin()` and `wp_update_theme()`, which aren't used anywhere in core, and haven't been for a very long time far as I can tell. Looks like redundant code. solarissmoke 21872 RSS Widget, and all of fetch_feed() I believe, forces its own feed order of Post Date DESC General normal normal Awaiting Review defect (bug) new 2012-09-11T15:25:32Z 2012-09-11T15:58:00Z "My events management plugin wanted to provide Upcoming Events via RSS. I wrote a pre_get_posts filter to modify the order and orderby of the event's feed to be Ascending based on a the event's start date, and it was good. Good, however, for only as long as you don't subscribe to the feed using WordPress (whether it be the event site or one on a totally different network). WordPress, upon fetching the feed, always re-sorts the posts according to the post date. Subscribing with something like iGoogle, will show me my upcoming events in the order that I've coded. Is this an intentional design decision? It feels to me that the generating site should be responsible for the order of the feed, and WordPress should respect the generating site's wishes and present the feeds in the order it is given." madtownlems 21870 @ error control operator hides fatal error on mysql_fetch_object Database 1.5 normal normal Future Release defect (bug) new has-patch 2012-09-11T14:59:36Z 2012-11-07T19:49:19Z "I ran a get_posts() query that took me a while to track down to the @ error control operator on the mysql_fetch_object call (see wp-db.php:1219 in trunk), therefore PHP was silently die'ing on me because of a memory limit error. I'm curious as to what use cases there are for the error control operator to be used here. In my case, I want to see these errors and fix my code accordingly, or tailor my query to the memory constraints, or rethink my data relations in the database. " ericlewis 21864 PHPDoc incorrect with the return value of add_*_meta functions Inline Docs 3.4.2 normal normal Awaiting Review defect (bug) new has-patch 2012-09-10T20:54:14Z 2012-09-10T23:37:28Z "The PHPDocs for `add_comment_meta`, `add_post_meta` and `add_user_meta` all say that they return `true` on success. In fact, each calls `add_metadata`, which returns the metadata_id on success. In addition, `update_metadata` currently returns the metadata_id on success if the metadata did not already exist, but true on success if the metadata did already exist (the PHPDoc says simply that it is true on success). The patch corrects the documentation, and additionally ensures consistency with the return value for `update_metadata`." mark8barnes 21862 Don't display show_option_none in wp_dropdown_categories when categories exist Taxonomy normal normal Awaiting Review enhancement new 2012-09-10T15:14:04Z 2012-09-10T15:16:48Z "I can't find an application of having an extra entry for '''show_option_none''' select option if we have category listing. Is there any reason to keep it there, like for external filters? If so, that still conflicts with the second example below. First off, it is invalid since there are some categories available. Second, having both '''show_option_none''' and '''show_option_all''' displays both entries. Related to #21856 trying to list only visible terms." nofearinc 21859 Import blog and media library is not working Import 3.4.2 normal normal Awaiting Review defect (bug) new 2012-09-10T08:02:25Z 2012-09-28T15:42:33Z "Hi, I have problems (due to hosting php timeout) to import all my blog at once. I tried doing it by months, but it's also not working. Blog posts are imported, but nothing of the media library is imported. I can describe too what happens when trying to import everything at once. I've just 200 photos and every 90 secs the connection is reseted trying to import them. If you try to retry using browser, photos begin to duplicate, or triplicate, or more... After all this, then you finish, there is no attachments related to their post. I've tried importing by months, which would not spend more than 60 secs importing photos, but then the photos are not imported. Please, fix the import/export by months or by splitting files every 10 post (or configurable). I would suggest too to allow any mechanism to import photos first, doing it in groups of 20 (or by configuration) and later, after that, importing post and attaching files to each post. I set it as critical as moving a blog it's impossible without a huge amount of work. I could try to help debugging if needed. Version 3.4.1 is also affected. Thanks and regards" don_ousian 21856 Hide category selection when no posts are available Administration 3.1 normal normal Awaiting Review enhancement new has-patch 2012-09-09T14:38:10Z 2012-11-13T20:18:02Z "Just an idea that popped up while testing #21015. The months dropdown gets hidden when there are no posts available, so why not hide the category dropdown list too? Might be a bit confusing though, when certain elements are not showing when you first start using the screens that these elements are used. But showing something that does not do what it looks like is even more confusing, I think." CoenJacobs 21853 Unable to Add Whitespace After Hyperlinks Editor 3.3.2 normal major Awaiting Review defect (bug) new 2012-09-09T06:22:43Z 2012-09-09T15:10:02Z "This bug seems to have developed somewhere after version 3.1. To reproduce this bug: 1. Start a new post or page. 2. Click the HTML tab. 3. Paste this snippet: {{{ Parent itemSPACEME Child item }}} 4. Click the Visual tab and note how the hyperlink runs up against the word ""SPACEME"". 5. Click the HTML tab. 6. Add a space before ""SPACEME"". 7. Click the Visual tab. 8. Like magic, the space has vanished! :( Curiously, I am unable to reproduce this behavior if I add the space on the Visual tab rather than the HTML tab. Very buggy!" miqrogroove 21848 A single space in the image caption breaks alignment Media 3.4.2 normal normal Awaiting Review defect (bug) new 2012-09-08T15:07:42Z 2012-09-09T08:53:24Z "If you add just a single space in the caption field of an image using the media uploader, it ignores any alignment settings. The expected behaviour would mean that regardless of what is entered into the caption box, the image alignment should be honoured." luffer 21845 Losing comment reply by accidentally clicking on another comment Comments 3.4.2 normal normal Awaiting Review defect (bug) new 2012-09-08T13:17:20Z 2012-09-17T22:31:50Z "This is a usability bug. When replying to a comment in the Edit Comments (wp-admin/edit-comments.php) page, double-clicking on another comment will open that comment for editing and wipe away the reply you were writing. If you want to highlight a word to copy from the comment that you are replying to this can be done by double-clicking the word. So completely by accident your reply is wiped out. This occurred on wordpress.com so I'm guessing their using the latest 3.4.2 version." icc97 21842 Diffrerent Custom Taxonomy Unable to Have Same Term Name in Version 3.4.2 oneTarek Taxonomy 3.4.2 normal major Awaiting Review defect (bug) new reporter-feedback 2012-09-08T09:27:28Z 2012-09-14T23:47:16Z "Before WordPress version 3.4.2 We know that WordPress does not support same word as category and tags. Assume you have a category named ""iPhone"" and it's slug is 'iphone' and now you want to add a new tag named ""iPhone"" , in this case tag slug will be 'iphone-2'. But if you have a custom taxonomy ""Device"" then the slug will be 'iphone' same as category ""iphone"". It means WordPress did not support same category and tag but can be same with any custom taxonomy. I tested many times this case. But today after updating My WordPress Blog to version 3.4.2 I found a mistake on it. I have 3 custom taxonomy. 'Type', 'Brand' and 'OS' . Before WP 3.4.2 I was able to use same word as Category and Type and also same slug for those. But now in version 3.4.2 when I am adding new terms It is getting slug with extra number 2. Example: I have a Category 'Apple' it's slug 'apple'. Now I am trying to add a 'Brand' taxonomy term 'Apple', the slug is being created 'apple-2'. But this problem was not in before WP 3.4.2" onetarek 21840 Add filter for taxonomies shown in quick edit Quick/Bulk Edit normal normal Awaiting Review enhancement new 2012-09-08T02:02:36Z 2012-09-08T17:08:36Z "I'd like to propose that there be more options to adjust the default quick edits. For instance, my Radio Buttons for Taxonomies plugin removes the default metabox for taxonomies and replaces it with one that uses radio inputs, which limits the user to a single term choice. However in the quick edit, this is easily circumvented, because I have no way to remove the taxonomy inputs from being displayed in their default ways. At the minimum, just adding a filter to the taxonomies would let me disable the default taxonomy inputs and then add my own. More hooks/filters would be ideal, but I think this is the minimum I can get away with. Sorry it isn't a patch or diff... I'll try to get WordPress set up as a repo on my computer. But in the mean time I'm proposing a change to : /wp-admin/includes/class-wp-posts-list-table.php file in the '''inline_edit()''' method, for instance, i'd like to change {{{ $taxonomy_names = get_object_taxonomies( $screen->post_type ); }}} to: {{{ $taxonomy_names = apply_filters( 'inline_edit_taxonomies', get_object_taxonomies( $screen->post_type ), $screen->post_type ); }}} " helgatheviking 21837 Site search for a domain by text fails in subdomain installs of multisite with www in primary domain Multisite 3.4.2 normal normal Awaiting Review defect (bug) new 2012-09-08T00:30:50Z 2013-04-28T16:21:22Z "To reproduce: 1) Create a subdomain network install where the main site's domain contains www 2) On the Network Admin->Sites search for an existing site based on the domain name, such as some* to find somedomain.domain.com. 3) Search returns ""No sites found."" even when the site exists and was searched for using a valid technique. I've tested the problem on Apache and Nginx servers, with Twenty Eleven as the theme on the main site, and network activated plugins. Existing sites can never be found by domain name. Subdomain installs in a network are allowed where the main site is www.domain.com. DOMAIN_CURRENT_SITE in wp-config.php points to www.domain.com. But blogs.domain stores the domain of a multi-site site named somedomain as somedomain.domain.com (without the www). As a result, any site search for a domain based on text (the name of the domain) fails because of how the query is built on lines 70-73 of wp-admin\inludes\class-wp-ms-sites-list-table.php. A search for some* produces a query that searches for some%.www.domain.com instead of some%.domain.com; the result is that nothing is ever found. Searches based strictly on site ID work fine. Possible fixes: 1) leave as is but warn that subdomain network installs where the primary domain includes www will have a broken site search (not ideal) and encourage no www on primary site of a subdomain network install or 2) check if the primary domain contains www and strip it out prior to building the query (ideal)." frisco 21834 Comment History Comments normal normal Awaiting Review enhancement new has-patch 2012-09-07T20:30:47Z 2012-09-08T03:37:40Z "This ticket provides a simple patch for comment history in core. ''The Problem'': In at least a few places: ([comment:ticket:9117:10], [comment:ticket:15534:4], [comment:ticket:9495:3]) Nacin has mused about the desirability of introducing comment history to core, citing Akismet’s implementation as a model for how this might be done. There are good reasons for wanting this, as comment history could serve as a solid underpinning for a variety of other features such as more informative moderation emails, some indication of why a message was marked as spam, and even comment versioning. The idea is that to implement any of that, we really should have basic comment versioning in core, a la Akisment. ''The Solution'': Our goal was to expand the API so as to reproduce and streamline the basic history functionality provided by Akismet, port and tweak Akismet’s nice history UI, and keep the change set minimal. Comment history API: * added simple functions to /wp-includes/comment.php to get and update comment history. These in turn use existing comment_meta functions. UI: * there’s now a comment history meta box on the comment edit screen. It looks just like Akismet’s. This was implemented as a real meta box. A sorting function is also included. History Events: * this patch supports the following history events, each of which has a nice, plain-english (internationalizable) history message, which always includes the user responsible for the action and a timesince. * edit_comment (“edited by user”) * trashed_comment (“trashed by user”) * untrashed_comment (“un-trashed by user”) * comment_unapproved_to_approved (“user approved this comment”) * comment_approved_to_unapproved (“user unapproved this comment”) * spammed_comment (“user marked this comment as spam”) * unspammed_comment (“user marked this comment as ham”) ''Next steps'': Here’s what we’d think of doing next if this were to be introduced into core: * support more history events and provide more detail. In particular, support events where the comment is spammed as a result of a blacklist word or other reason. * include some of this detail in moderation emails ''Note'': * the Akismet plugin should be updated to use this new API instead of its own history functions * meta boxes on edit comment did not work properly until this: http://core.trac.wordpress.org/ticket/21499 (in 3.5) ''Who we are'': This patch comes from [http://profiles.wordpress.org/bbrooks Ben Brooks], [http://profiles.wordpress.org/mattoperry Matt Perry] and [http://profiles.wordpress.org/natebot Nathan Letsinger]. Enjoy" mattoperry 21826 There should be more filters when displaying a theme in the list table Administration 3.4 normal normal Awaiting Review enhancement new has-patch 2012-09-06T22:54:43Z 2012-09-15T22:27:50Z "In `WP_Themes_List_Table::display_rows()`, there is a filter for the theme actions, but no filters for the theme information itself: screenshot, title, author, version, and description. Why not fix that? The attached patch introduces `theme_list_*` filters within the `display_rows()` method. Suppressing one of the pieces of information is simply a matter of returning an empty value through the filter." ethitter 21821 wp_title spits warnings and returns a blank when a query is both is_post_type_archive and is_category/is_tax/etc Template 3.4 normal minor Awaiting Review defect (bug) new 2012-09-05T23:31:38Z 2012-11-01T22:19:33Z "When a query is made against both a post type and a category / taxonomy / et cetera, the query is both is_category and is_post_type_archive. The queried_object is set to the first object type it comes to; category / taxonomy come before post_type, so the queried_object is a term here. wp_title walks through each is_ option in turn and resets the title with every one it finds being true. When there is both a category and a post type archive, single_term_title gets called first, successfully setting the title, but then post_type_archive_title is called, which assumes the queried_object is in fact a post type object; it spits out a couple of warnings and returns a blank title. Probably, since its subordinate title functions depend on the queried_object being as expected, wp_title should use else if rather than just if (in the same way that get_queried_object does), but I'm not sure if that would have implications elsewhere. (Tested against trunk r21768 as well as 3.4.1) Attached is a unit test that demonstrates the problem. " devesine 21819 Use an image size for custom headers instead of duplicating an attachment Media 3.5 normal normal Future Release enhancement assigned 2012-09-05T21:19:51Z 2012-11-07T20:40:58Z The improvements in #21810 will allow us to use an image size for custom headers, and we definitely should — it results in fewer attachments, allows the user to recrop the header, and allows us to make intelligent decisions regarding how to treat custom headers when the theme is changed. koopersmith 21811 Add image editing UI to the media modal Media 3.5 normal normal Future Release feature request new 2012-09-05T20:33:10Z 2013-04-08T14:00:02Z "The media modal should contain a way to edit a given image size. This should include the capability to crop, resize, rotate, and flip (as all are currently possible). The core of this UI should be capable to serve as both the crop step in a workflow like choosing a custom header, or in editing a given image size to include within a post. This UI will benefit greatly from (and heavily relies upon) improvements on #21810, and should probably wait until work on that ticket is underway." koopersmith 21810 Improve intermediate image size handling Media 3.5 normal normal Future Release enhancement new 2012-09-05T20:28:14Z 2013-01-15T20:29:29Z "When discussing the new media workflows on #21390, the need to improve our image size API became apparent. A quick overview of the improvements that should be made: * All image attachments have an original, or ""golden master"", which is never altered. * An image size creates a new image and stores all transformations applied to the image as metadata. Transformations are described relative to the golden master. An image size has a unique slug (which means a set of dimensions does *not* have to be unique). * Image attachments have a ""master"" image size, which is used to create any automatically generated image sizes. * Automatically generated image sizes can be overridden with manual transformations. Would love for someone to step up on this ticket, as the media modal editing UI will benefit greatly from these improvements." koopersmith 21803 Add filter to make extending searching easier Query 3.4 normal normal Future Release enhancement new needs-unit-tests 2012-09-05T13:50:13Z 2012-11-07T07:14:55Z "I'm using custom post types, and want to extend the search function so more than post_title and post_content are searched. It is currently possible to filter `posts_search` but that returns a string such as ` AND (((wp_posts.post_title LIKE '%test%') OR (wp_posts.post_content LIKE '%test%'))) `. This string then has to be rather messily manipulated via `preg_replace` or `str_replace`. It would be more useful if we could filter a list of fields to be added to the search criteria, so that we could add a function to extend or change the criteria: {{{ add_filter ('search_fields', 'my_custom_search_fields'); function my_custom_search_fields ($fields) { global $wpdb; $fields[] = ""{$wpdb->prefix}posts.post_excerpt""; return $fields; } }}} The attached patch implements that filter." mark8barnes 21793 Incorrect parsing of readme files for plugins on wordpress.org WordPress.org site normal normal WordPress.org defect (bug) new 2012-09-04T22:47:36Z 2012-09-06T23:07:00Z "When wordpress.org parses plugin readme files, it changes URLs in the form www.site.com to links, and adds http:// to the text displayed. That's good and proper. However, it's not helpful when this happens in a code block. For example, see the first and third code block of this readme - http://wordpress.org/extend/plugins/sitepush/installation/ The readme validator shows the same behaviour. The parser should not do any URL parsing in code blocks." markauk 21792 Add link to settings.general from appearance.header Appearance normal normal Awaiting Review enhancement new 2012-09-04T19:38:50Z 2012-09-04T19:40:36Z "Multiple users that we've tested have ended up on appearance->header when asked to change their ""site title"". It seems logical. Should we add a link there?" lessbloat 21791 Enhancement: locate_template() support for multiple file types (not just .php) Template normal normal Awaiting Review enhancement new 2012-09-04T14:59:29Z 2012-09-15T08:10:10Z "I have modified locate_template() to allow location of file types other than .php. The core currently only searches for .php extensions for template file names (search.php, 404.php, etc). I have a HAML parser, and this mod allows the core to locate .haml files (search.haml, 404.haml). Then I can use the 'template_include' filter to handle that file type. Do you think this is the best way to accomplish it? I also made the function a little more DRY. {{{ function locate_template($template_names, $load = false, $require_once = true ) { $located = ''; $template_paths = array( STYLESHEETPATH, TEMPLATEPATH ); $template_file_types = apply_filters('template_file_types', array('php')); foreach ( (array) $template_names as $template_name ) { if ( !$template_name ) continue; foreach($template_file_types as $template_file_type) { $template_name_try = str_replace('.php', '.'.$template_file_type, $template_name); foreach($template_paths as $template_path) { $template_name_try = $template_path . '/' . $template_name_try; if ( file_exists($template_name_try)) { $located = $template_name_try; break 3; } } } } if ( $load && '' != $located ) load_template( $located, $require_once ); return $located; } }}} you think this modification would be a good core enhancement?" benallfree 21790 When set a static front page WP main query isn't set correctly Query 3.4.1 normal normal Awaiting Review defect (bug) new dev-feedback 2012-09-04T13:50:26Z 2012-09-05T16:00:06Z "In my project I use on several places pre_get_posts filter. When setting a static frontpage and blog page I get several notices on my screen. When I var_dump the main query the only value that is set it the page_id. Even the post_type isn't set." markoheijnen 21788 Relocate revoke_super_admin() and grant_super_admin() to capabilities.php Role/Capability normal normal Awaiting Review defect (bug) new 2012-09-04T11:09:57Z 2012-09-16T21:32:38Z "Would be nice to move revoke_super_admin() and grant_super_admin() out of /wp-admin/includes/ms.php and into to /wp-includes/capabilities.php, where the rest of the _super_admin() functions are. This allows theme-side user profile plugins (see: the bb's) to use these functions without needing to pull in a wp-admin file directly." johnjamesjacoby 21785 Add header image uploads with cropping to the customizer Appearance 3.4 normal normal Future Release task (blessed) new early 2012-09-04T04:56:41Z 2013-04-26T01:08:30Z See #21355 for an explanation for why header image uploads (sans cropping) was removed from the 3.4 branch. This ticket is about adding it back, with a crop step, to ensure proper support. nacin 21774 Page attributes structure Administration normal normal Awaiting Review enhancement new has-patch 2012-09-02T14:58:57Z 2012-10-08T17:45:53Z "Currently, the ""Page Attributes"" module is organized like this: * Parent * Template * Order Wouldn't it make more sense to put ""Parent"" and ""Order"" together, as both are closely similar and related to the site structure? We could have: * Template * Parent * Order or maybe * Parent * Order * Template" Lorangeo 21773 Scheduled pages/posts should not appear in custom menus Menus 3.0 normal normal Awaiting Review defect (bug) new 2012-09-02T14:30:48Z 2012-10-23T22:03:31Z "When I add a '''scheduled page/post''' in a custom menu the page/post immediately appears in the front-end menu. I think these scheduled pages/posts should only be visible in the front-end navigation when their scheduled time is reached (as it is the case with automatic menus). Otherwise the ""Schedule"" functionality makes no sense with custom menus, especially for pages. Here is another forum post regarding this issue: http://wordpress.org/support/topic/custom-menu-support-for-scheduled-pagesposts" Lorangeo 21770 Multiple New Feature Pop-ups mess UI Administration 3.4.1 normal normal Awaiting Review defect (bug) new dev-feedback 2012-09-02T11:09:51Z 2013-01-22T03:06:39Z "WordPress admin and plugins [[Image(http://dl.dropbox.com/u/184353/wordpress-admin-pop-ups.png)]] New Feature Pop-up messages appear on the admin simultaneously, blocking each other messages and functionality. The UI gets seriously messed up. User attention focuses on how to get rid the overlaping pop-ups rather than reading the messages and understand and start using the new features." titanas 21769 Can we remove un-minified versions of all external libraries? External Libraries 3.5 normal normal Future Release enhancement new dev-feedback 2012-09-02T09:32:35Z 2012-10-24T20:50:12Z "With [21646] and [21648] we had removed the un-minified versions of Jcrop and jQuery Color. A quick search through the plugin repo shows that there is only one plugin which includes the script directly: Pie Register: http://plugins.trac.wordpress.org/browser/pie-register/trunk/pie-register.php#L1444 Should we be consistent and remove the un-minified versions of other external libraries too? These would be: * colorpicker.js * hoverIntent.js * jquery.imgareaselect.js * cropper.js (not used in core anymore and no minified version exists) * json2.js * tw-sack.js" ocean90 21766 modify body_class function to allow non-class items Template normal normal Awaiting Review feature request new dev-feedback 2012-09-01T18:11:43Z 2013-02-19T21:26:12Z "Currently, the `body_class` only allows for filtering with additional classes. For users that want to add other items, they have to manually edit the theme files. The best example of this is schema.org body elements (itemtype and itemprop). The diff file shows two things: 1. the new `body_items` function that grabs any items added via filter, if they exist. 2. the modified `body_class` function, which appends the output with the items if they exist. The patch, as I've written it, allows for this additional filter to be included without interfering with how themes / plugins interact with the current `body_class` filter, and doesn't require theme authors to include an additional tag in their themes. Below is an example function that could be placed in a theme or plugin to add other items to the body tag element. {{{ function schema_bodyitems($item) { if (is_page() ) : $item[] = 'item-foo=""item-bar""'; endif; $item[] = 'itemtype=""http://schema.org/Blog""'; $item[] = 'itemscope=""""'; return $item; } add_filter('body_items','schema_bodyitems'); }}} " norcross 21765 Redirect to canonical URL if URL has 'preview' parameter with any nonempty value and user not log in Canonical 3.4.1 normal normal Awaiting Review enhancement new 2012-09-01T13:18:44Z 2012-09-01T15:15:07Z "if any URL has nonempty GET-parameter 'preview' that there is noredirection to canonical URL. If we have http://example.com?p={post_id}&post_type={post_slug}&preview=true there is no redirection to correct URL like http://example.com?{post_type}={post_slug} or like http://example.com/{post_type}/{post_slug} (if site has permalinks). This is bad for SEO and bad user experience. If user not log in there must be redirecttion." egorpromo 21763 Add Support To Pass An Array Of Plugins To The Plugin Info API Plugins 3.4.1 normal normal WordPress.org feature request new 2012-09-01T03:14:42Z 2012-09-01T11:13:54Z "https://api.wordpress.org/plugins/info/1.0/ Currently only allows one plugin to be passed in a request to get the relevant information back. However, the update check API allows an array of plugins to be passed. I'm requesting the same functionality be added to the info API and not just for developer use, but for consistancy." crypticmauler 21762 Storing a multidimensional array using register_setting double-serializes subarrays identified with a string sekatsim Database 3.4.1 normal normal Awaiting Review defect (bug) new 2012-08-31T22:43:16Z 2012-09-01T16:36:41Z "Storing a multidimensional array, such as `$options['my-option'][$id] = ""value""`, into the database using register_setting results in the ""my-option"" string getting double serialized. The option_value is stored as: `s:9:""'my-option'"";a:1:{s:9:""option-id"";s:5:""value"";}` The my-option array is encased in both single and double quotes, so that `isset($options['option-id']` evaluates false, but `isset($options[""'option-id'""]` evaluates true." sekatsim 21760 get_term_by() calls are not cached Taxonomy 2.3 normal normal Future Release enhancement new needs-unit-tests 2012-08-31T21:26:22Z 2013-05-03T16:00:39Z {{{get_term()}}} is the simplest way to retrieve one term, but it requires {{{term_id}}} and {{{taxonomy}}}. Because of this, terms are cached with {{{term_id}}} as key and {{{$taxonomy}}} as bucket. As a result, you can't easily grab a term by slug, unless you use {{{get_term_by( 'slug' )}}}. {{{get_term_by( 'slug' )}}} and {{{get_term_by( 'name' )}}} don't even have a query cache, so they go to the database every time. Because you can't get a term by {{{slug}}} without hitting the db, every place you want to get a term by {{{slug}}}: you first have to transform it into a {{{term_id}}} where it will then be cached. This is inefficient because the user may query by {{{slug}}} constantly and never by {{{term_id}}}. wonderboymusic 21758 Do not require a file in comments_template() Comments 3.4.1 normal normal Awaiting Review enhancement new has-patch 2012-08-31T20:22:16Z 2012-09-01T11:23:07Z "comments_template() is a very useful and reliable way to set up comments for a page, but it has a major downfall: it forces a file to be included when, in reality, one does not need to be. Numerous times it has been the case that I needed comments to be setup in the wp_query object, but did not want to output anything at that time. The hack I have used is simply to include an empty comments.php file. This method is less than desirable for obvious reasons. So, I propose that we simply add a parameter I'm calling $require that will control whether or not a file is included at all." mattonomics 21753 Feed excerpts are missing important filter formatting Feeds 3.4.1 normal normal Awaiting Review defect (bug) new 2012-08-31T14:20:56Z 2012-08-31T14:20:56Z "Excerpts included in feeds are missing important formatting because the relevant filters are not applied (e.g. wpautop). In file wp-includes/feed.php, function the_excerpt_rss() does not apply the same filters as the_excerpt() whilst results in lost formatting instructions. By comparison, function the_content_feed() ensures that the same filters declared for the_content() are applied. A suggested patch is attached. Note that for symmetry between the_excerpt_rss() and the_content_feed() this patch also removes the (unnecessary?) filter ent2ncr() from the_excerpt_rss() and retains the (controversial?) escaping for CDATA blocks (see #3670). A few related issues are worth mentioning. Firstly, shortcodes are still not applied to excerpts (see #7093). Also, the (obsolete?) RDF feed does not make use of a CDATA block unlike those for RSS, RSS2 and Atom (see #20888). Finally, a similar problem occurs with comment text in feeds (see #16466)." mdgl 21744 WP_User_Query does not support post type Users 3.4.1 normal normal Awaiting Review enhancement new has-patch 2012-08-31T00:13:59Z 2012-12-22T07:46:03Z "unfortunately WP_User_Query only support 'post' right now. i've attached my modified user.php" AliMH 21738 PHPMailer fourth argument '-oi' does not work with some hosts with safe_mode off Mail 3.4.1 normal minor Future Release defect (bug) new 2012-08-30T13:56:54Z 2012-09-19T21:15:58Z "See also #20970 Some hosts (e.g. TransIP) do not accept the '-oi' parameter in the fourth argument for mail() even when safe_mode is off. The result is that no mail can be sent through !WordPress on these hosts. Changeset [21129] provides a partial fix when either safe_mode is off, or no sender is defined. The parameter seems to be unnecessary, therefore it is recommended to remove this parameter. In version 3.4 and 3.4.1, it is in lines 740 and 742 of file wp-includes/class-phpmailer.php " Keeslavin 21737 Users should have to jump through hoops to set passwords of their choosing, and we should guard better against weak passwords westi* Security normal normal Awaiting Review feature request accepted 2012-08-30T04:07:17Z 2013-04-18T02:44:43Z "People are terrible at choosing secure, unique, complex, unguessable passwords. Unless someone is using a password storage system, the chances are good that the passwords they're choosing are really weak. We can mitigate this problem. 1. Let's make the default to always be that WordPress picks a password for you. When installing WordPress, or when creating a new user account, or when changing your password on your profile. The default should be that we generate a secure password for the user. They can remember it, write it down (not ideal, but generally more secure than choosing a weak password), or copy and use it once, check the ""remember me"" box, and not worry about it until their cookie expires on that computer. 2. If they do opt to manually create a password, we need to do better than our current password strength meter. And the lowest level should actually nag them with an AYS before they proceed. I suggest the following, to start, which would trigger the lowest level, and cause them to have to dismiss a warning (or check a checkbox... UI TBD) before continuing: * compare the strtolower'd version of their password to strtolower'd versions of all their info (username, first/last name, part of e-mail address before the @, etc). * any password that is shorter than 8 characters * a blacklist of popular passwords (these lists are available... even grabbing the top 100 would give use good coverage) * 3 or more consecutive digits (""123456"" and company are very popular) * anything that looks like a date" markjaquith 21734 Completely remove global terms Taxonomy normal normal Future Release enhancement new has-patch 2012-08-29T21:38:55Z 2013-01-03T01:21:56Z "It's an obscure WPMU feature that 1) hasn't been maintained 2) hardly anyone uses and 3) slows down development on the regular taxonomy code: #5809 #18609 #18617 There isn't much code to remove, but the idea is to not have to worry about ""global terms"" anymore at all." scribu 21730 More modular and reusable email validation functions Users normal normal Awaiting Review enhancement new dev-feedback 2012-08-29T16:04:04Z 2012-08-29T19:56:12Z "Email validation, especially as it's handled in Multisite (most of which is verbatim from MU), is pretty messy. We have some functions like `is_email_address_unsafe()` for checking banned domains, but we don't have a parallel function for checking against limited_email_domains. There are no filters outside of `wpmu_validate_user_signup`, which means that if you want to use email validation outside of the normal MS registration workflow and want to tweak the way that it works (see eg #15706, #20459), you pretty much have to roll your own. And there's no single function that a plugin like BuddyPress can use to do all relevant email checks in one fell swoop. The attached patch suggests the following changes: - Put the limited_email_domains check into a function, `is_email_address_allowed()`. - Put filters on the output of this new function as well as `is_email_address_unsafe()`. - Introduce function wp_validate_email_address(), which wraps the following four checks: is_email(), email_exists(), is_email_address_allowed(), is_email_address_unsafe(). - Rearranges `wpmu_validate_user_signup()` a bit so that all email checks (as opposed to username checks) happen together. I'm not married to anything in this particular implementation (the way that wp_validate_email_address() sends back error messages is not particularly beautiful, but I didn't want to introduce a ton of overhead), but I would really like to see some sort of treatment along these lines, to make things more modular and reusable. If something like this gets approved by the devs, I would like to further suggest the following: - Give a similar treatment to username validation - Move the generic validation functions out of ms-functions.php (with function_exists() checks on the MS-specific stuff) I'm happy to work more on this kind of patch, but didn't want to go too far in case it's a non-starter for some reason." boonebgorges 21729 Better logic for comments email notification General normal normal Awaiting Review defect (bug) new 2012-08-29T15:26:37Z 2012-11-22T03:49:45Z "Please see attached patch. - If comment_author_email is known, it can be used in ""From"" email header. - Also in ""Reply-To"" header we can use comment_author. I am not sure if there is any reason for current logic, but my friend noticed it and he thought that this way it would be better..." pavelevap 21714 Enable Intermediate choice in UI if Full Size Image is exact match to Intermediate Image General 3.4.1 normal minor Awaiting Review enhancement new 2012-08-28T15:56:09Z 2012-08-28T15:56:09Z " This is simply a minor usability enhancement for Media Gallery. If an image is uploaded that is exactly the same size as an intermediate image (300x300 = Medium for example) it is not a choice when inserting that image into a post. It would be nice if it was a choice pointing to the full/original image since full is the same size as the intermediate. It seems to be caused in the image_downsize function in /wp-includes/media.php because image_get_intermediate_size returns false. I believe image_downsize can be updated as such to provide this enhancement: Line 162 (if statement) Currently: {{{ if ( !$width && !$height && isset($meta['width'], $meta['height']) ) { // any other type: use the real image $width = $meta['width']; $height = $meta['height']; } }}} could be updated to read the intermediate width and height and set intermediate to true if it is an exact match to the original image: {{{ if ( !$width && !$height && isset($meta['width'], $meta['height']) ) { // any other type: use the real image $width = $meta['width']; $height = $meta['height']; // add check for real image being exact match to intermediate image to enable intermediate choice in UI if (isset($_wp_additional_image_sizes[$size])) { $goal_width = intval($_wp_additional_image_sizes[$size]['width']); $goal_height = intval($_wp_additional_image_sizes[$size]['height']); } else { $goal_width = get_option($size.'_size_w'); $goal_height = get_option($size.'_size_h'); } if ($width == $goal_width && $height == $goal_height) $is_intermediate = true; } }}} Thanks for considering, and hope I put this in the right place, Andrew " andrewteg 21713 Extend login body class to support custom background Template normal normal Awaiting Review enhancement new has-patch 2012-08-28T14:46:00Z 2012-09-01T07:19:36Z "It would be useful to have a class `custom-background` on the `body` element for `wp-login.php`. Then we could just write: {{{ add_action( 'login_head', '_custom_background_cb' ); }}} Currently we have to copy the whole function with a very tiny difference: replace `body.custom-background` with `body.login`. Not very elegant." toscho 21712 Enhancements to wp-signup.php and wp-activate.php Template 3.4.1 normal minor Awaiting Review enhancement new 2012-08-28T12:00:38Z 2012-08-28T12:00:38Z "While #17948 going on, I suggest calling get_header()/get_footer() along with 'singnup'/'activate' parameter on wp-signup.php and wp-activate.php. Something like: {{{ get_header( 'signup' ); get_footer( 'activate' ); }}} Also adding before_activate_form and after_activate_form action hooks into wp-activate.php just like wp-signup.php" geminorum 21699 Losing post status Post Types 3.4.1 normal normal Awaiting Review defect (bug) new dev-feedback 2012-08-27T05:19:40Z 2012-08-27T07:00:09Z I created custom post type and custom post status for it. Then I programmatically set custom status for new post and then edit it using admin panel. When I save post status is set to 'published' and I can't select my status from statuses list. barmin.alexander@… 21691 WPLANG not settable in multisite if there are no language files Multisite normal normal Awaiting Review defect (bug) new close 2012-08-26T11:16:24Z 2012-10-12T13:26:56Z "I got a plugin running on a multisite and there is definitely something up with the translation. I tracked the problem down to the WPLANG option in `http://localhost//wp-admin/options.php` being empty. I tried to update it, but it keeps reverting to blank. So down the line the issue with get_locale() looking for the WPLANG value in the site_options and then defaulting back to en_US because it's not picking it up from the wp-config.php defined WPLANG. I'm assuming that the defined WPLANG in the wp-config.php does not apply in multisite instances. The plugin is only enabled on the separate blog instance, and I changed the translation in wp-config.php after the install if that has anything to do with it. Simple filter to force the locale in the plugin for the moment: {{{ function modify_locale(){ return 'de_DE'; } add_filter('locale','modify_locale'); }}} I hope someone can reproduce this issue." foxinni 21689 Unbalanced tags are generated when shortcodes are followed by HTML tags and wpautop is enabled Formatting 3.4.1 normal normal Awaiting Review defect (bug) new 2012-08-26T06:58:21Z 2013-03-07T03:42:49Z "This bug was encountered in separate plugins, but it seems that its source is in the core: http://wordpress.stackexchange.com/questions/21414/wordpress-wpautop-shortcode-generating-invalid-markup https://github.com/pods-framework/pods/issues/271" dandv 21687 Need to be able to float sticky posts to top in custom queries Query 3.4 normal normal Awaiting Review enhancement new 2012-08-25T16:12:08Z 2012-08-25T16:12:08Z "Currently sticky posts are only floated to the top of the loop when on an index page (blog/home). When making a new WP_Query for posts as a secondary loop on a ""page"" page (whilst developing shortcode) sticky posts only appear in the natural date order because my query does not have the is_home flag. My proposal would be to add a new parameter/argument to the WP_Query class, either connected to 'orderby' or 'ignore_sticky' parameters, stating whether sticky posts should have order 'float', 'natural', 'exclude' (it seems that the mechanism for excluding sticky posts from the loop is a bit clunky, although well documented; this would simplify it). Default behaviour can be retained, the query on the index page can use the 'float' option and themes/plugins can call it in custom queries if required. Alternatively, the sticky sorting could be moved to a separate function and called via an action, so developers can use the same function (or build their own) in their custom queries. This is how I have my current workaround, running a filter on 'posts_results' having copied code for floating stickies from core. It seems a shame to be be duplicating code though, especially when it should be an option available in custom queries." ChemicalSailor 21683 Choose the relationship between the meta_query and what it's pulled into (AND/OR) Query 3.4.1 normal normal Awaiting Review enhancement new dev-feedback 2012-08-24T19:00:11Z 2012-08-27T14:13:06Z "The use case for this is that I'd like to be able to, much like meta_query's ""relation"" option, be able to choose whether or not 'meta_query' itself should be treated like AND or OR in it's WHERE inclusion. meta_query's ""relation"" option is already helpful, letting you treat any of the meta_query's arrays as OR instead of the default AND. Adding this new option would provide the ability to treat meta_query as AND / OR based on the need of the WP_Query lookup." sc0ttkclark 21679 media_handle_upload does not provide a way to change the file's name Media 2.5 normal normal Awaiting Review defect (bug) new dev-feedback 2012-08-24T04:00:30Z 2012-08-24T10:33:06Z "`wp-admin/includes/media.php` has two operations that I believe should be reversed. Basically, `$name` is set based on the name of the raw uploaded file ( `$_FILES[$file_id]['name']`), however in the `wp_handle_upload` function you are able to use `wp_handle_upload_prefilter` to adjust the file's name - but when after the `wp_handle_upload` returns the changes will not show up in the title of the media dialog field even though the file has been renamed properly: {{{ $name = $_FILES[$file_id]['name']; $file = wp_handle_upload($_FILES[$file_id], $overrides, $time); if ( isset($file['error']) ) return new WP_Error( 'upload_error', $file['error'] ); $name_parts = pathinfo($name); $name = trim( substr( $name, 0, -(1 + strlen($name_parts['extension'])) ) ); }}} In short, uploading a file named Picture.png and changing the name to test3.png using the `wp_handle_upload_prefilter` filter does in fact allow the file's name to be changed before it is saved, but the ""title"" is then incorrectly displayed in the media uploader dialog box. [[Image(http://img24.imageshack.us/img24/3679/pictureyp.png)]] This would be relatively easy to fix using this patch: {{{ --- media.php 2012-08-23 23:57:02.000000000 -0400 +++ media-patch.php 2012-06-06 12:00:08.000000000 -0400 @@ -209,8 +209,8 @@ $time = $post->post_date; } + $name = $_FILES[$file_id]['name']; $file = wp_handle_upload($_FILES[$file_id], $overrides, $time); - $name = $file['name']; if ( isset($file['error']) ) return new WP_Error( 'upload_error', $file['error'] ); }}}" Willshouse 21676 Pass a variable to get_template_part() Template 3.4.1 normal normal Awaiting Review enhancement new close 2012-08-23T20:15:37Z 2013-04-03T13:05:31Z "Having the ability to pass a variable into get_template_part would be invaluable, it would really clean up the issues with using globals and to further cement it's use rather than the alternative of a normal PHP include/require. It would be the third variable passed into get_template_part, which I could pass it a string, array, object, or whatever I want really. Here's an example of passing all the current scope's variables: {{{ }}} and then catching them in my feed-twitter.php file: {{{ if ( !empty( $_data ) && is_array( $_data ) ) extract( $_data, EXTR_SKIP ); }}} I can pass other things in, but that's a really valuable example in my uses for this new variable." sc0ttkclark 21674 "Please add ""plugins"" link under ""my sites > network admin"" in toolbar" Multisite 3.4.1 normal normal Awaiting Review feature request new has-patch 2012-08-23T19:13:46Z 2012-08-24T15:43:16Z This would remove a click and I think a lot of people would enjoy the addition. I know I go to the plugins page more than users or sites combined. archonic 21672 Custom menu memory problem Menus 3.4.1 normal normal Awaiting Review defect (bug) new 2012-08-23T18:53:46Z 2012-10-15T08:38:03Z "I found some strange memory problem related to updating custom menu. One website is using about 22 MB from 128 available (memory_limit). But when trying to update custom menu, there is error related to unsufficient memory. This custom menu has about 100 items, I also tried to export it to my PC and testing memory uasge. There are some strange results... In file wp-admin/nav-menus.php there is following line: {{{ $menu_item_db_id = wp_update_nav_menu_item( $nav_menu_selected_id, ( $_POST['menu-item-db-id'][$_key] != $_key ? 0 : $_key ), $args ); }}} When I set memory checks before and after this line, then there are following results on my testing environment, for example: {{{ Before: 25.28 MB After: 25.29 MB }}} I added also some checks directly into wp_update_nav_menu_item() function and there are some small peaks (about 1 MB). But in the end (after this function) everything is somehow reset and memory usage is as low as in the beginning. But when I test it with affected hosting, there are following results: {{{ Before: 26.59 MB After: 27.77 MB }}} So everytime wp_update_nav_menu_item() is running, 1 MB more is needed on this server and there is no reset. And because it is foreach cycle and menu has more than 100 items, then more then 128 MB is needed. Same conditions, but one server needs more than 128 MB memory_limit and my local environment works well with 32 MB. There is no other problem with this hosting, everything works, no special server settings. Any ideas?" pavelevap 21669 "Make ""Home"" option persistent in Pages box on Menus screen" Menus 3.4.1 normal minor Awaiting Review defect (bug) new 2012-08-23T16:57:08Z 2012-08-27T15:09:43Z "If you have some pages, or even a page, then on nav-menus.php in the Pages box, View All, it will display Home as an option. However, if you do not have any pages at all (mostly Blog on front page scenarios), then it just says ""No items."" in the Pages box. It should always be populated with at least the Home option. Oversight on our part that we didn't uncover this behavior before. " jane 21668 WordPress still does not save jpeg as progressive jpeg Media 3.4.1 normal normal Awaiting Review enhancement new has-patch 2012-08-23T16:44:06Z 2013-04-08T12:52:45Z "Every time WordPress does `imagejpeg` it should be doing `imageinterlace` beforehand to set progressive mode, but it's not. http://php.net/manual/en/function.imageinterlace.php Progressive jpeg has been supported by ALL browsers since 2001 or so. progressive demo: http://bbshowcase.org/progressive/ Note that even if an ancient browser is listed somewhere as not rendering progressive, progressive jpeg still will be displayed, simply showing it all at once rather than gradual. IE6 for example WILL load progressive jpeg, it will just not render it progressively, instead it will load the entire image and then render all at once at the end. Progressive algorithm will also make slightly smaller jpeg as a side effect in most cases. ie. in `media.php` ` imageinterlace($newimage,1); imagejpeg( $newimage, ... ` This update is years overdue. It might be possible to futureproof this by adding a filter to `$newimage` before the final `imagejpeg`. I am uncertain if that would work since filters would not pass `$newimage` by reference and instead make a copy - while newimage is only a pointer to php/gd memory. Can apply_filters be forced to work somehow by reference instead of a copy? Maybe that should be another feature idea. " _ck_ 21667 Add some user agent to wp_is_mobile Administration 3.4.1 normal normal Awaiting Review enhancement new dev-feedback 2012-08-23T12:35:29Z 2013-05-07T18:45:53Z "Hello, I've run some test with the help of the twitter/G+ community on wp_is_mobile and found some mobile browser that don't pass the test. You can see the test here : http://www.inpixelitrust.fr/blog/wp_is_mobile/ I was able to get the user agent of 3 of those which don't work : HTC sensation z710 4.0.3 native browser (UA: Mozilla/5.0 (X11;Linux x86_64; HTC/Sensation/3.32.162.11; fr-de) AplliWebkit/534.24(KHTML,like Gecko) Chrome/11.0.696.32 Safari/534.34 ) BlackBerry Playbook (Ua Mozilla/5.0 (PlayBook; U; RIM Tablet OS 2.0.1; en-US) AplleWebkit/535.8+ (KHTML, like Gecko) Version/7.2.0.1 Safari/535.8+ ) Could be great to add those to the UA sniffing :) " inpixelitrust 21666 Theme customizer reset Appearance 3.4.2 normal normal Awaiting Review feature request new 2012-08-23T10:09:49Z 2013-05-18T13:13:22Z "It would be useful to be able to reset the settings to the defaults as specified in the add_setting() class method when setting up each setting. These could be reset on a section by section basis and/or for ALL settings." dgwyer 21665 "Allow non-editable pages to be classified & organized as ""System Pages""" Administration normal normal Awaiting Review feature request new dev-feedback 2012-08-23T01:08:34Z 2013-01-22T03:21:44Z "We currently have no means of distinguishing regular “content” pages (pages that users can edit) and pages that are used as placeholders for custom templates / dynamic content. As alexking mentions in #17470, users are often confused when they attempt to edit these ""placeholder"" or ""dummy"" pages only to find that the pages appear empty from within the page editor. While his ticket concerned the ""page_for_posts"" page specifically, this issue is equally relevant to custom page templates that do not make use of user-generated content via the page editor. isaackeyet proposed a solution [http://core.trac.wordpress.org/ticket/17470#comment:4 in that ticket] which introduces the idea of classifying such pages as ""System Pages"", which would offer a more limited set of options for how they can be changed: >Idea to solve this permanently as brought up in the UI chat July 10 2012: > >* Pages have a new, hidden meta field to indicate ""System Page"" or >something that better describes it. Pages are marked System Page when >WP is using it as a placeholder for a custom blog set up, or a plugin >can use it to indicate a page is used for a contact form (for >example). >* Pages are highlighted with a meta description in the pages list, >indicating why it's there (created by? reason?) >* Most importantly, these System Pages are grouped in the pages >filter to be excluded from the regular list, so the list may read >""All | Published | System Pages"", which should be a better long term >solution for this ticket specifically (user confusion). " bootsz 21663 Use PDO for MySQL queries when PDO is available Database 3.5 normal normal Future Release task (blessed) new dev-feedback 2012-08-22T21:02:28Z 2013-05-06T18:00:51Z "the mysql_* functions are officially deprecated for PHP 5.4 and will begin throwing E_DEPRECATED errors in the next version of PHP. http://marc.info/?l=php-internals&m=131031747409271&w=2 Wordpress should use PDO by default, but fall back to mysql_* when PDO is not present. See also: #11622 for last year's discussion." scottconnerly 21662 wp-signup.php says there's no limit to the number of blogs even when that is not desired or impossible Multisite 3.4.1 normal normal Awaiting Review defect (bug) new has-patch 2012-08-22T20:48:26Z 2012-12-29T16:53:04Z "Please remove the statement in '''wp-signup.php''' that exclaims that there's no limit to the number of blogs one can create. It's on line 169. I ask for two reasons: 1. Hosters of WordPress Networks may not wish to encourage users to open a ton of blogs. I don't because I don't want to encourage a support nightmare. 2. We might use a plugin that limits the number of blogs that users may create, like [http://buddydev.com/buddypress/limit-blogs-per-user-plugin-for-wpmu/ Limit Blogs per User]. For #2, an acceptable alternative may be to make it a string that can be overridden by a plugin. But the current situation, where it's a one-size-fits-all string, is bad because I have to manually edit it each time I (frequently) upgrade WordPress." novasource 21660 'p' arg should work with custom post types Query normal normal Awaiting Review enhancement reopened 2012-08-22T15:27:49Z 2012-11-01T18:20:10Z "Doing a query like following, where 42 is a custom post_type, will fail: {{{ $query = new WP_Query( array( 'p' => 42 ) ); }}} The resulting query looks like: {{{ SELECT wp_posts.* FROM wp_posts WHERE 1=1 AND wp_posts.ID = 42 AND wp_posts.post_type = 'post' ORDER BY wp_posts.post_date DESC }}} This is because WP_Query forces the {{{post_type}}} arg to 'post' when it's not set. We should not force it when the {{{p}}} arg is set." batmoo 21659 wp_mail() problem with Reply-To header General 3.4.1 normal normal Awaiting Review defect (bug) new 2012-08-22T14:43:43Z 2012-08-22T14:43:43Z "I am using in email headers also Reply-To: {{{ $headers .= ""Reply-To: \""$name\"" <$email>\r\n""; }}} But there is a problem when name contains special non-English characters. Example (from email headers): Name: Žlutý kůň {{{ Reply-To: =?UTF-8?Q? ""=C5=BDlut=C3=BD_k=C5=AF=C5=88"" _ , ?=@example.com }}} I think that it is somehow related to wp_mail() function, because I also tried to use SMTP plugin and it worked well: {{{ Reply-To: =?UTF-8?Q?""=C5=BDlut=C3=BD_k=C5=AF=C5=88""_?= }}} Also when I use simply mail() instead of wp_mail() then everything works well. Problem can be seen only for Reply-To header, all others work well (for example From). I am using WP 3.4.1." pavelevap 21658 Meaningless adjacent post links for pages General 3.4.1 normal normal Awaiting Review defect (bug) new 2012-08-22T12:34:26Z 2012-08-22T12:34:26Z "In WP 3.3 we removed a number of obsolete elements from the page header leaving just those with rel=""next"" and rel=""prev"" generated by function adjacent_post_rel_link_wp_head() in file wp-includes/link-template.php [see #18128]. This change brings the function of these links into sharper relief and raises several concerns. Presently, they are generated only for singular pages/posts that are not attachments. Such links make some kind of sense for ordinary posts, because these can be considered to be part of an ordered collection where the next/previous relationship is meaningful. It may also make sense for custom post types, depending on the use to which they are being put. For pages, however the links generated refer to the next/previous pages as they happen to be stored in the WP database and these are unlikely to have any meaningful relation to the originating page. Others have reported performance and other problems with browsers such as Firefox that use these links to prefetch content [see #12603, #14382 and #19018]. You can see their point! If I'm viewing page ""about"" what are the chances that I will next want to view the page ""contact"" just because this happens to have the next sequential ID in the WordPress database? At the very least, I believe that these links should not be generated for pages. Better still would be to follow Google's advice [see #18672] and use these just for paginated content (i.e. individual posts/pages [with ] or archives [including blog home]). Some potential patch code is available against #18660 which raised a similar issue. Links between adjacent posts can be left to the usual navigation elements within the page body." mdgl 21653 Introduce current_date() Date/Time low normal Awaiting Review enhancement new has-patch 2012-08-21T19:33:59Z 2013-01-07T09:25:24Z "WordPress comes with a function called `current_time()` which returns the current time according to the timezone chosen on the General Settings screen. It's used when populating the post date, among other things. It would be nice to have a date equivalent of this function for outputting the current date according to the timezone setting. Currently if you want to output the current date you need to do this: {{{ echo date( 'd/m/Y', current_time( 'timestamp' ) ); }}} I'd like to be able to use this instead: {{{ echo current_date( 'd/m/Y' ); }}} Note that just using `date()` doesn't give the desired effect as WordPress sets the default timezone (as used by `date()`) to UTC, not to the timezone chosen on the settings screen." johnbillion 21652 wp_update_nav_menu_items returns false instead of WP_Error for non-existent menu items Menus 3.4.1 normal normal Awaiting Review defect (bug) new has-patch 2012-08-21T16:57:45Z 2012-08-25T14:49:33Z "'''Use case:''' Calling wp_update_nav_menu_items with a non-existent menu_item_id as the first parameter '''Expected return value:''' WP_Error object (as per the method's documentation) '''Actual return value:''' Boolean false '''Fix:''' wp-includes/nav-menu.php#L279 - This line should check for a false value first, and if `$menu == false`, set it equal to a `new WP_Error` object - then check `is_wp_error($menu)`" mltsy 21651 Add term_taxonomy_id to available fields in get_term_by Taxonomy 3.4.1 normal minor Awaiting Review enhancement new dev-feedback 2012-08-21T14:07:33Z 2012-08-21T14:11:01Z In my experience {{{term_taxonomy_id}}} has proven to be exponentially useful in a number of ways, specifically in prevention of same-id collisions of terms used in multiple taxonomies. I'd love to be able to grab a term object by passing along its {{{term_taxonomy_id}}} to {{{get_term_by()}}}. A recent change was made to {{{WP_Query}}} that provides this functionality, so I'm hoping this makes the cut as well. jchristopher 21650 replace serialize() with print_r() in stats() function in wp-includes/cache.php Cache 3.4.1 normal minor Awaiting Review defect (bug) new has-patch 2012-08-21T13:42:29Z 2012-09-10T15:17:49Z "In PHP 5.3 it is no longer possible to serialize data that contains a SimpleXMLElement object. It produces a fatal error. See https://bugs.php.net/bug.php?id=49800 The stats() function attempts to determine the allocated space for objects in the cache by using strlen() of the serialized object. This can fail for the reason above. Given that the figure returned is simply an estimation of the space I propose that the code is changed to use print_r( $cache, true ) instead of serialize( $cache ) ie. to become `echo "" Group: $group - ( "" . number_format( strlen( print_r( $cache, true ) ) / 1024, 2 ) . 'k )';` This TRAC was raised after a longish chain of events starting with #18488 and the final response (today) which led to another chance discovery of a similar problem in the debug-bar plugin. http://wordpress.org/support/topic/plugin-debug-bar-fatal-error-uncaught-exception-serialization-of-simplexmlelement-is-not-allowed " bobbingwide 21649 _WP_Editor class is currently marked as final Editor normal normal Awaiting Review enhancement new 2012-08-21T13:13:08Z 2012-08-21T17:16:30Z "Revision [19420] turned {{{ class _WP_Editors{} }}} from wp-includes/class-wp-editor.php into {{{ final class _WP_Editors{} }}} I'm aware that editor API is currently under large changes but it would be great if plugins could extend _WP_Editors class by removing ""final"" keyword." Marko-M 21645 Rewrite API logic and flush_rules Rewrite Rules 3.4.1 normal normal Awaiting Review defect (bug) new 2012-08-21T00:24:05Z 2012-08-21T08:24:19Z " It is not clear if or how visiting the Settings -> Permalinks calls flush_rules. It is referenced occasionally as an apparent alternative to $wp_rewrite->flush_rules() in Documentation. This should be explicitly confirmed in the admin interface and/or a button based action. Documentation for the Rewrite API functions do not point at $wp_rewrite->flush_rules() effectively. (Updated some codex links, but seems worth including a pointer inline in function definitions.) I was confused while editing an existing theme why duplicating existing add_feed() structures in functions.php did not produce duplicated behaviour in the permalinks. ?feed=atom1 worked , but /feed/atom1/ didn't, until calling flush_rules() Logic seems broken between these functions. Why call Rewrite API add_feed() every init, but still require a flush_rules reset to activate? They should be more explicitly linked / combined / triggered. See prior conversation in #21335 http://codex.wordpress.org/Rewrite_API" here 21644 Should contributors be allowed to edit their posts once scheduled? General 3.4.1 normal normal Awaiting Review feature request new 2012-08-20T21:36:55Z 2013-01-29T19:42:14Z " This may not be a ""bug"" per-se,but seems to have a lot of negative consequences so I'll give it a shot. According to the rules: A contributor can edit their own Posts - irrespective of who scheduled it. http://codex.wordpress.org/Roles_and_Capabilities#Contributor This creates problems for large publications where there is an editor who makes changes to posts and then schedules them, sometimes a couple days in advance. As it stands now, a contributor can still log in after that process is done which means unexpected changes and shenanigans might take place. Wouldn't it make more sense for a contributor to lose editing privileges as soon as something is no longer in draft modea? Just my two cents. " nickaster 21642 language_attributes() print WP lang instead content lang. General 2.1 normal normal Awaiting Review enhancement new dev-feedback 2012-08-20T18:15:37Z 2012-08-20T20:46:33Z "If you have WordPress in a language does not mean that the content has to be in that language. It would be good if there was an option to select it. Another detail is for example: If we have the translation ""'''Spanish - Spain'''"", ""'''es-ES'''"", WordPress print ""'''es-e'''s"" instead of ""'''es'''"" simply. This would be good because it is the only translation into Spanish." shadowhck 21641 Filter on pending/draft array in wp_insert_post() General normal normal Awaiting Review enhancement new 2012-08-20T16:53:56Z 2012-08-20T16:53:56Z "Hi In wp_insert_post() function, there is no possibility to add a status to the list of status for which postname can be set to empty (no filter). Thus, to have the 'pending' like behaviour for a custom status it seems you have to update the postname to '' and the gmt to 000-00 after the insert, as you have to hack the permalink construction too. In the same way, it would be nice to add the $post parameter to the filter 'display_post_states' in the '_post_states($post)' function (wp-admin/includes/template.php), in order to add easily a post state according to a custom status of the post (seems better as retrieving the global $post of the admin loop). Hope these are real issues. Sorry if not. Regards " villagora 21636 Add category dropdown to QuickPress in Dashboard Administration 3.4.1 lowest minor Awaiting Review enhancement new has-patch 2012-08-19T20:14:09Z 2012-08-31T18:28:22Z "This would make QuickPress more useful to people who use categories instead of tags, have been meaning to do this for years. " jane 21632 Adding Imgur as an oEmbed provider markjaquith Embeds normal normal Future Release enhancement reopened dev-feedback 2012-08-19T15:51:15Z 2012-09-23T18:26:36Z Adding imgur to the list of oEmbed providers! (wcgr rocks) bradparbs 21631 HTML encoded characters in the custom menu's URL html are decoded after first save and removed after second save Menus 3.4.1 normal normal Awaiting Review defect (bug) new 2012-08-19T15:27:20Z 2012-08-19T15:49:04Z "Special characters in the custom menu's URL get double html encoded after second save. Having an array in the URL that is using square brackets (site.com/key[value]), the links break after the second save of that menu item because the & in the & gets double html encoded." rocketwood 21628 Attach image(s) to WordPress.org support topics/replies WordPress.org site normal normal WordPress.org enhancement new 2012-08-18T22:27:29Z 2012-08-19T22:28:27Z The ability to upload images to a support reply or topic would assist in describing issues and solutions. Sure, a user could link to an externally sourced image, however that's another step in the process. ericlewis 21627 Filter for custom-background CSS selector Horttcore Themes 3.4.1 normal trivial Awaiting Review enhancement new has-patch 2012-08-18T11:46:55Z 2013-01-10T20:34:50Z "There should be an easier way for changing the css selector from body to html or any other then making your own callback. " Horttcore 21622 Validate or sandbox file edits before saving them Administration 2.7.1 normal minor Awaiting Review enhancement new 2012-08-17T20:50:45Z 2012-09-24T23:20:03Z "While using the [http://www.wpzoom.com/themes/academica/ academica] theme, I accidentally missed an ending bracket while editing functions/wpzoom-seo.php in the theme editor. This is used as part of a set of pages creating a theme options page on the dashboard. When the function went bad, it caused my entire installation to be unaccessible. It was necesssary to ftp to fix the error, because even the dashboard was blanked out by a fatal error. Messing something up in the theme should not cut off access to the dashboard." eschwartz93 21621 setting meta_type doesn't CAST orderby value Query 3.2 normal normal Future Release enhancement new has-patch 2012-08-17T20:01:20Z 2013-05-16T11:54:37Z "Setting {{{meta_type}}} in {{{WP_Query}}} will cast the {{{meta_value}}} in WHERE clauses to whatever {{{Meta_Query}}} internally resolves it as, however it does not create an alias and does not order by that alias. It orders by an un-CAST'd {{{meta_value}}} which doesn't work for numbers. I realize that {{{orderby}}} set to {{{meta_value_num}}} will fix this, but that doesn't change the fact that {{{meta_type}}} is being ignored. To test: {{{ update_post_meta( 1, 'num_as_longtext', 123 ); update_post_meta( 2, 'num_as_longtext', 99 ); add_filter( 'query', function ( $sql ) { error_log( $sql ); return $sql; } ); $stuff = new WP_Query( array( 'fields' => 'ids', 'post_type' => 'any', 'meta_key' => 'num_as_longtext', 'meta_value' => '0', 'meta_compare' => '>', 'meta_type' => 'UNSIGNED', 'orderby' => 'meta_value', 'order' => 'ASC' ) ); print_r( $stuff->posts ); exit(); }}} That should return 2 then 1, it returns 1 then 2. It generates this SQL: {{{ SELECT SQL_CALC_FOUND_ROWS wp_posts.ID FROM wp_posts INNER JOIN wp_postmeta ON (wp_posts.ID = wp_postmeta.post_id) WHERE 1=1 AND wp_posts.post_type IN ('post', 'page', 'attachment') AND (wp_posts.post_status = 'publish') AND ( (wp_postmeta.meta_key = 'num_as_longtext' AND CAST(wp_postmeta.meta_value AS UNSIGNED) > '0') ) GROUP BY wp_posts.ID ORDER BY wp_postmeta.meta_value ASC LIMIT 0, 10 }}} My patch returns: {{{ SELECT SQL_CALC_FOUND_ROWS wp_posts.ID FROM wp_posts INNER JOIN wp_postmeta ON (wp_posts.ID = wp_postmeta.post_id) WHERE 1=1 AND wp_posts.post_type IN ('post', 'page', 'attachment') AND (wp_posts.post_status = 'publish') AND ( (wp_postmeta.meta_key = 'num_as_longtext' AND CAST(wp_postmeta.meta_value AS UNSIGNED) > '0') ) GROUP BY wp_posts.ID ORDER BY CAST(wp_postmeta.meta_value AS UNSIGNED) ASC LIMIT 0, 10 }}} " wonderboymusic 21616 add-textdomain doesn't conform to WP coding standards I18N normal normal WordPress.org defect (bug) reopened 2012-08-17T03:07:19Z 2012-08-17T21:37:50Z I used add-textdomain.php from http://i18n.svn.wordpress.org/tools/trunk on my plugin code, but it does not include a space before the closing parenthesis of the gettext function call it alters, which violates http://codex.wordpress.org/WordPress_Coding_Standards#Space_Usage groovecoder 21613 format_to_edit runs esc_textarea if $richedit param is set to false, not true General normal minor Awaiting Review defect (bug) new has-patch 2012-08-16T19:59:20Z 2012-08-17T15:35:26Z "Currently, the docs on format_to_edit() indicate that it runs the content through esc_textarea (which in turn runs htmlspecialchars() ) if the $richedit param is set to true. The code, however, runs the filter if the param is not set (or passed as false, see line 1270). {{{ #!php 1255 /** 1256 * Acts on text which is about to be edited. 1257 * 1258 * The $content is run through esc_textarea(), which uses htmlspecialchars( 1259 * to convert special characters to HTML entities. If $richedit is set to t 1260 * it is simply a holder for the 'format_to_edit' filter. 1261 * 1262 * @since 0.71 1263 * 1264 * @param string $content The text about to be edited. 1265 * @param bool $richedit Whether the $content should not pass through htmls 1266 * @return string The text after the filter (and possibly htmlspecialchars( 1267 */ 1268 function format_to_edit( $content, $richedit = false ) { 1269 $content = apply_filters( 'format_to_edit', $content ); 1270 if ( ! $richedit ) 1271 $content = esc_textarea( $content ); 1272 return $content; 1273 } 1274 }}} My thought is the if statement should evaluate whether $richedit is true, rather than false, and therefore apply the esc_textarea function only when explicitly passed as a param. This would, however, result in unexpected behavior for anyone currently passing only the default $content param and getting sanitized output." vhauri 21610 ssh2/sftp doesn't work with chrooted/openssh sftp-internal user accounts (no shell) albert@… Filesystem 3.4.1 normal normal Awaiting Review feature request new 2012-08-16T16:06:35Z 2012-09-10T18:20:52Z "The current wordpress 3.4.1 wp-admin/includes/class-wp-filesystem-ssh2.php code will crash php or spin in an endless loop when someone supplies ssh/sftp credentials (username/password) to an (open)ssh server where users don't have a shell and are chrooted to their home directory e.g. by using openssh's sftp-internal server and ChrootDirectory functionality. There is no neat fix for the code in the WP_Filesystem_SSH2 class. I've implemented a new WP_Filesystem_SFTP class making use of the portable phpseclib library. At this moment it is necessary to change a line in wp-admin/includes/file.php to be able to use WP_Filesystem_SFTP. Attached is the code for this new class up for review or for anyone with the same problem." albert@… 21606 term_exists returns 0 and null barrykooij Taxonomy 3.4.1 normal normal Future Release defect (bug) new has-patch 2012-08-16T09:27:33Z 2012-11-06T23:26:58Z "The function ''term_exists'' in ''wp-includes/taxonomy.php'' has two different return values, ''0'' and ''null''. The function does a few checks and returns ''0'' if the condition of the check is not met. If the checks are met, the return value will be the result of a ''$wpdb->get_row'' or ''$wpdb->get_var''. If the term is not found in the database the methods ''get_row'' and ''get_var'' will return ''null''. Because of the different type of return values it's not possible to do a strict check on the return value to see if a term was found. I've changed the return ''0'' in ''term_exists'' to return ''null'', so that if there is no term found the result of ''term_exists'' will always be ''null''." barrykooij 21605 Fix TinyMCE statusbar styling TinyMCE normal normal Awaiting Review defect (bug) reopened 2012-08-16T04:09:21Z 2012-10-21T17:36:07Z When the breadcrumb links in the TinyMCE statusbar (at the bottom) are too long (many nested elements with long class names), the statusbar pushes the width of the editor and breaks the layout. azaozz 21603 Add a delete button to individual menu items Menus 3.4.1 normal normal Awaiting Review enhancement new 2012-08-15T21:45:29Z 2012-08-15T21:45:29Z "When working with a menu in the Admin, if you need to delete a lot of entries it's really slow because you have to expand each entry, then click delete, then wait for the refresh to do it all over again. If we had an X next to the down arrow for each menu item, it would be much faster/easier to delete them. Thanks!" wphound 21602 redirect_canonical can lead to infinite loop on index navigation if site url is not all lower case Canonical normal normal Awaiting Review defect (bug) new needs-unit-tests 2012-08-15T21:31:17Z 2013-04-23T07:53:55Z "The function redirect_canonical in wp-includes/canonical.php (WordPress 3.4.1) on line 406 and 422 makes the following check: {{{ if ( !$redirect_url || $redirect_url == $requested_url ) return false; }}} This ensures that it does not attempt to redirect you to the page you requested in the first place. However this function is not case sensitive so if the redirect URL is in a different case than the requested URL then the user can enter an infinite redirect loop. (For example if the Site Address (URL) of the site is set to be in all upper case.) This function should do a case-insensitive string comparison since domain names are case-insensitive. The issue only appears to happen with certain plugins installed (ShareThis and PilotPress both led to this issue,) I haven't figured out yet why it's only an issue with certain plugins but it should still be fixed in WordPress to make the proper string comparison. " sreedoap 21599 wp-admin post-screen: Make metabox visibility filterable General 3.4.1 normal minor Awaiting Review enhancement new 2012-08-15T19:10:46Z 2012-09-25T17:57:10Z We are using wp as a cms and we want to influence the visibility options our users see. Right now, that part is hardcoded in wp-admin/includes/meta-boxes.php. We would appreciate a filter to influence the visibility options. I'd be willing to provide a patch, if I get a positive feedback from a core dev. pampfelimetten 21597 WordPress Importer $base_url index failed Import 3.4.1 normal minor WordPress.org defect (bug) new has-patch 2012-08-15T18:30:11Z 2012-09-10T10:03:12Z "When XRS file without the site url tag is imported, it throws a notice. This patch allow people to upload hand-made and not-attached-to-any-site XRS file. I came across creating a XRS file to import names of cities from Portugal to a specific custom taxonomy to some sites. This can reflect the necessity of this patch." lightningspirit 21596 enhance wp_get_archives to support post types General normal normal Awaiting Review enhancement new has-patch 2012-08-15T18:13:53Z 2013-05-07T19:05:42Z I needed to populate an option list of a form with the titles of custom post types. It seemed like wp_get_archives would do the trick, except there was no way to tell it to grab a post_type. So I enhanced wp_get_archives to support and additional parameter. jjminkle 21584 Allow to create more networks Multisite 3.4.1 normal normal Awaiting Review feature request new dev-feedback 2012-08-15T00:34:24Z 2013-01-17T23:38:47Z "After creating a multisite installation allow users to create their own network of blogs. " alexvorn2 21583 Improve discoverability and visual design of Screen Options and Help Panels Help/About normal normal Future Release enhancement new early 2012-08-14T22:34:05Z 2012-11-03T05:36:33Z "The Screen Options and Help panels are not very discoverable and, in part because of this, aren't very helpful to our users. Here are the problems with them right now: * Most users are blind to these tabs. * The labels and positioning give little indication as to what these tabs actually do. * For a lot of users, Help is not that helpful. *They’re position in the admin creates yet another point of navigation for users to be aware of (and per #1, most of them aren’t). * The very wide container for text makes a lot of the help text difficult to read. Here are some proposals to improve the design and discoverability of these tabs (related images and mockups are here: http://make.wordpress.org/ui/2012/08/06/we-did-some-brainstorming-at-dev-day-today/) : * Adding icons to these tabs would (hopefully) both make these tabs more visible and give a better indication as to what these tabs too. * Moving these to the right side of the toolbar would give even more context to what these do, as they would be grouped with other user-specific settings. * (6) The toolbar dropdown would allow for a slimmer content area for better readability. * (7) The slimmer content area would let us make screen options read like a list for better scannability. * (4/5) Putting the gear on the upper right would standardise with several other web apps (Twitter, etc). Related: #21326" chexee 21581 Add orderby meta_value to WP_User_Query General normal normal Awaiting Review defect (bug) new dev-feedback 2012-08-14T21:24:05Z 2012-08-14T21:40:10Z "For some reason, we cannot easily order the WP_User_Query() by last_name without directly editing the SQL statements. However, there is an easy way to add this that would work parallel to WP_Query(). {{{ // prepare arguments $args = array( 'orderby' => 'meta_value', 'meta_key' => 'last_name', ); $user_query = new WP_User_Query( $args ); }}}" wpsmith 21573 NOBLOGREDIRECT interfering with 404 errors Multisite 3.4.1 normal normal Awaiting Review defect (bug) new has-patch 2012-08-14T07:32:06Z 2013-04-16T05:36:08Z When the `NOBLOGREDIRECT` constant is defined, 404 pages on the main site will not work and instead redirect to URL defined in `NOBLOGREDIRECT`. This is the cause of the `maybe_redirect_404` action/function, which is not needed and should be removed. bungeshea 21571 Add support multiple comment types in get_comments Comments normal normal Awaiting Review enhancement new 2012-08-14T00:49:42Z 2012-08-24T19:54:42Z "Custom comment types are a nice way to categorize comments, however, if you wish to retrieve multiple comment types you cannot use ''get_comments''. This enhancement request (patch attached) adds support for multiple comment types a la: {{{ $comments = get_comments( array( 'post_id' => $post->ID, 'type' => array( 'a-sweet-comment-type', 'some-other-comment-type', ), )); }}}" borkweb 21563 """Save as"" button disappearing on edit/new post screens" Editor 3.4.1 normal normal Awaiting Review defect (bug) new has-patch 2012-08-13T15:15:58Z 2013-03-11T22:01:41Z "When switching ""visibility"" from ""public"" to ""private"", the ""Save as (draft/etc.)"" button disappears. It doesn't come back when switching to ""public"" anymore. [[Image(http://i.imgur.com/EExwB.png)]]" F J Kaiser 21554 Problem with determining e-mail charset in wp-mail.php lizhenry Blog by Email 3.4.1 normal normal Awaiting Review defect (bug) assigned dev-feedback 2012-08-12T11:06:52Z 2012-08-29T13:58:26Z "In wp-mail.php the charset of the incoming e-mail message is determined on line 77 by taking the string between the second ""="" in the line and the end of line/second "";"" respectively. '''The problem''' If the header line in question looks like any of the following that method is perfectly fine: {{{ Content-Type: text/plain; charset=UTF-8; format=flowed; delsp=yes Content-Type: multipart/alternative; }}} However in messages sent from e.g. Gmail or Goolge Reader this header line usually looks like this: {{{ Content-Type: multipart/alternative; boundary=f46d044516dd9cd71f04c70e55e8 }}} I this case ""f46d044516dd9cd71f04c70e55e8"" is determined as the charset and the iconv function further down on line 187 returns false which causes the post content to be emptied. '''Suggested solution''' I personally think that it is better to have the post published with an ""incorrect"" charset than with no content at all. Therefore I suggest that on line 76 in wp-mail.php... {{{ if ( ! empty( $content_type[1] ) ) { }}} ...is replaced by... {{{ if ( ! empty( $content_type[1] ) && stripos( $content_type[1], 'charset' ) !== FALSE ) { }}} ...in order to check if there is actually a charset definded. Alternatively/additionally the return value of the iconv function on line 187 should be checked and the $content variable only modified if the return value doesn't equal FALSE." mighty_mt 21551 Press This Structural Rewrite Press This 3.4.1 normal normal Awaiting Review enhancement new has-patch 2012-08-11T19:59:54Z 2013-01-24T12:25:37Z "This is a ticket to tidy up and abstract some of the Press This code into wp-admin/includes/press-this.php to make it simpler to work with and use functionality in plugins and such. Once this structural change is done, I've got a couple enhancements coming down the pipes including reading OG/Twitter/Meta tags from the source page, simpler upgrades to the JS (jorbin's suggestion) better image pulling, etc. This patch below, however, is merely structural, not adding in any new functionality, merely tidying up what we've got so far." georgestephanis 21550 Plugin changelog truncation can break WordPress.org site layout WordPress.org site normal normal WordPress.org defect (bug) new 2012-08-11T16:32:59Z 2012-08-11T16:35:41Z "WordPress.org appears to truncate plugin changelogs after a certain number of characters. However, if the truncation occurs in an inconvenient place -- such as the middle of an HTML tag -- it can cause browser rendering issues in other parts of the page. For example, on the [http://wordpress.org/extend/plugins/seo-ultimate/changelog/ changelog page] for my plugin SEO Ultimate, the plugin page sidebar is currently showing up below the changelog ([http://img405.imageshack.us/img405/7557/brokenchangelogscreen.png screenshot]). This is because the changelog is being truncated in the middle of an tag, apparently leading my browser (Chrome) to fail to recognize a closing tag: {{{ }}} I would suggest that the easiest and perhaps best solution would be simply to stop truncating plugin changelogs. Layout breakage possibilities aside, I would prefer it if my plugin's changelog were not cut off after a certain point." JohnLamansky 21547 Enable 'delocalization' of scripts General normal normal Awaiting Review enhancement new has-patch 2012-08-11T04:04:27Z 2012-08-12T20:19:51Z "I created a patch to enable developers to 'delocalize' a script they added. Currently if somebody localizes a script with wp_localize_script() there's no going back. Can someone look at it and offer feedback? I'm not a regular WordPress contributor, so there may be stylistic issues." gkb6891 21546 Site Settings page is a hot mess Multisite 3.0 normal normal Awaiting Review enhancement new has-patch 2012-08-10T21:44:07Z 2012-08-20T16:50:59Z "I found out just how bad this page is when debugging an issue related to {{{WPLANG}}}. {{{WPLANG}}} is an option for a blog in your network (overrides {{{WPLANG}}} in {{{wp-config.php}}}), but if you delete the option on purpose or accidentally, there is no way of restoring it in the admin. Site Settings just loads your options table and POSTs back to itself. The only reference to the original options map (the defaults) is in schema, which WP has zero access to outside of upgrade. I have abstracted the default options and the default ""fat"" options into functions in {{{ms.php}}}. Also, when loading your Site Settings options - if a default option is missing, I display it in the admin so you can save it (it is populated with its default value). I have also streamlined and condensed some code that was happening in and around {{{populate_options()}}}" wonderboymusic 21543 Add a show_metabox parameter to register_taxonomy Taxonomy normal normal Awaiting Review enhancement new dev-feedback 2012-08-10T18:45:17Z 2012-10-09T18:44:16Z "Currently when registering a taxonomy we have the `$show_ui` param, this effects both the admin menu and the actual taxonomy meta box on the post edit screens. There are cases when you want it to show in one but not the other, to do that now you have to use either `remove_meta_box` or `remove_menu_page`. It would be nice to add another parameter like `show_metabox => array(posts)` to `register_taxonomy` which would effect the meta boxes only. And one for the admin menu as well. related: #12718 " wycks 21542 WP.org notifications don't support UTF-8 WordPress.org site normal normal WordPress.org defect (bug) new 2012-08-10T18:10:09Z 2012-08-10T18:12:51Z See the screenshot. SergeyBiryukov 21540 Add support for responsive video embeds Viper007Bond Embeds normal normal Awaiting Review enhancement assigned 2012-08-10T17:15:50Z 2013-01-17T17:27:31Z "By wrapping the html content of a video embed with a container (incl. class name), we could provide a simplified way for Theme authors to make video embeds truly responsive, through basic CSS. See #21480" obenland 21539 category_description filter not applied to Description field on Categories page Administration 3.4.1 normal minor Awaiting Review enhancement new has-patch 2012-08-10T13:53:03Z 2012-08-12T17:31:42Z "The category_description filter is not applied to the Description field on the Posts > Categories page (wp-admin/edit-tags.php?taxonomy=category). Need: I use very long category descriptions, which are displayed on the front end of the site. This means that the Posts > Categories page is blown out by the long descriptions. I wrote a plugin to filter the category_description to limit it's length in the admin area. However, I then discovered that the filter is not applied on this page. I'm wondering if there is some reason this was left out by design, but I can't see any reason why the filter should not be applied at this point. If I've missed something, please let me know. It is easy to fix - simply apply the category_description filter to the description field in column_description() in wp-admin/includes/class-wp-terms-list-table.php I have applied this on my local install. Now I just need to work out how to create a patch and submit it for review (this is my first attempt). Note: It may be sensible to limit the length of the category description displayed on this page, but that's outside the scope of this ticket, which is just about the filter not being applied." StephenCronin 21538 wp_get_attachment_image_src() is misnamed Media 2.5 normal normal Awaiting Review enhancement new 2012-08-10T11:58:20Z 2012-09-06T06:25:45Z "The function wp_get_attachment_image_src is misnamed. The name suggests that the function returns the URL for the src attribute of img tag, and this suggestion is so strong that it is practically impossible to remember that it in fact returns an array. I've just now been bitten by this for perhaps 50th time, and I have lost what amounts to days of debugging on finding out again and again that a function named ...get...src doesn't get src. I suggest renaming to wp_get_attachment_image_attributes and forwarding+deprecating the old function." rulatir 21537 Email address sanitisation mangles valid email addresses General 3.4.1 normal normal Awaiting Review defect (bug) new dev-feedback 2012-08-10T11:24:50Z 2013-01-22T09:00:07Z "If you change your email address to one including an ampersand then we mangle the address with html entities. For example: * This - peter&paul@sitting.in.a.tree.com * Becomes - peter&paul@sitting.in.a.tree.com This is due to the call to {{{wp_filter_kses}}} on {{{pre_user_email'}}} in {{{default-filters.php}}}. The was added in [5906] for #4546. I'm not sure if we need kses filtering for emails - if we do which should probably revert this conversion of the & => & afterwards." westi 21534 Walker: has_children is only set if $args[0] is an array betzster Menus 3.0 normal normal Future Release defect (bug) new commit 2012-08-10T02:12:33Z 2013-04-23T02:09:53Z "You can't depend on `has_children` because it doesn't get set if `$args[0]` is an object. This is obviously an easy fix, just check if it's an object and set it in that case. Related: #15214" betzster 21526 get_post_type_capabilities() assumes $args->capabilities is an array Role/Capability normal normal Awaiting Review defect (bug) new dev-feedback 2012-08-09T12:29:01Z 2012-08-09T12:46:39Z "get_post_type_capabilities() assumes $args->capabilities is an array and should check and confirm it. Otherwise a warning appears: Warning: array_merge() [function.array-merge]: Argument # 2 is not an array in /home/username/public_html/wp-includes/post.php on line 1183. I discovered this when I accidentally set this to null instead of array(). Type setting it seems to clear the warning, if we want to clear the warning. {{{ $capabilities = array_merge( $default_capabilities, (array)$args->capabilities ); }}} " wpsmith 21523 Add additional escaping to credit.php Help/About 3.4.1 normal normal Future Release enhancement new has-patch 2012-08-09T01:13:41Z 2012-11-07T20:16:49Z "`/wp-admin/credits.php` doesn't fully escape all of the data that it displays. It should be properly escaped like any other third party data. What if WordPress.org were somehow compromised?" Viper007Bond 21521 Audit use of set_time_limit() General 3.4.1 normal normal Future Release enhancement new 2012-08-08T17:28:21Z 2012-10-18T13:07:12Z Core calls this half a dozen times. The call in wp_get_http() interferes with unit tests. Unit tests will terminate 60 seconds after wp_get_http() is called. Let's justify each use of set_time_limit() and remove what we can. ryan 21520 Prevent recursive script dependencies in wp_enqueue_script General normal normal Future Release defect (bug) new 2012-08-08T17:21:43Z 2012-10-23T20:32:51Z "If a script sets itself as a dependency, we should catch that, strip out the dependency, and throw a {{{_doing_it_wrong}}}: {{{wp_enqueue_script( 'my-script', '/path/to/file.js', array( 'my-script' ) );}}} This may need to be done at the lowest level possible, i.e. {{{_WP_Dependency}}}" batmoo 21516 Make the entire .check-column the click target for the checkbox Administration normal minor Awaiting Review enhancement new has-patch 2012-08-08T03:34:38Z 2012-10-22T15:27:26Z Sometimes checkboxes are quite small. In various list tables, checkboxes are wrapped in a .check-column. Why not make the entire .check-column clickable, in case people (like me) miss? mitchoyoshitaka 21510 Use get_background_color() in _custom_background_cb() Themes 3.4.1 normal normal Awaiting Review defect (bug) new has-patch 2012-08-07T17:57:52Z 2012-08-07T21:53:35Z "When themes add a default background color via the `custom-background` feature, it isn't shown until the user saves it in the admin. The issue is that the `_custom_background_cb()` uses `get_theme_mod( 'background_color' )` instead of `get_background_color()`, which will handle the default. The attached patch should correct this." greenshady 21506 Standard Theme Hooks Bundled Theme normal normal Awaiting Review enhancement new 2012-08-07T02:10:55Z 2013-03-28T22:12:58Z "During the hack day at WordCamp SF, Konstantin Kovshenin and I sat down to work out a solution to allow for better communication between themes and plugins. We propose that core introduce 4 new hooks into the default WordPress themes allowing plugins to add custom markup relative to common theme elements. While many other theme locations could be recognized, we have only included hooks that we could provide at least three use common use cases for. header_after: Allows custom markup to be inserted after all visual header elements have rendered. Possible use cases for this hook include: * Breadcrumb navigation. * Links to social profiles. * Advertising. * log in/out form. post_after: Allows custom markup to be inserted after all visual elements have rendered for the current global post object. This hook would fix the issue originally reported in #18561. Possible use cases for this hook include: * Sharing links. * Related posts. * Ratings. * Author bio. comment_after: Allows custom markup to be inserted after all visual elements have rendered for the current global comment object. Possible use cases for this hook include: * Upvote/Downvote control. * Ratings. * Show/hide threads functionality. footer_after: Allows custom markup to be inserted after all visual elements have rendered for the footer. While this action is similar to {{{wp_footer}}}, it would be possible for the theme author to move this into nested html elements. To my knowledge, {{{wp_footer}}} is intended to fire immediately before the closing {{{body}}} tag. Possible use case for this hook include: * Links to social profiles. * Advertising. * The ""small print"" or copyright information. If standardized hooks such as these were recognized by core, it would also have a positive effect on child theming. Theme authors would no longer need to override entire files just to introduce an element of two. We have prepared 3 patches for the default themes to demonstrate placement of these hooks as well as a plugin to demonstrate their usage." mfields 21504 Not checking if apply_filters exists before calling it in WP_DB Database 3.4.1 normal normal Future Release defect (bug) new has-patch 2012-08-06T22:49:52Z 2012-10-25T21:17:48Z "Prior to version 3.4, there was a check to verify that apply_filters existed before calling it in wp-includes/wp-db.php. {{{ // some queries are made before the plugins have been loaded, and thus cannot be filtered with this method if ( function_exists( 'apply_filters' ) ) $query = apply_filters( 'query', $query ); }}} In version 3.4 and above, that check doesn't exist anymore, and can throw an error. There is still a comment indicating that a check should be made, but the actual code to perform the check is now gone. This is around line 1081 {{{ // some queries are made before the plugins have been loaded, and thus cannot be filtered with this method $query = apply_filters( 'query', $query ); }}} Here is the github blame view to show when the code was remove (I'm not sure how to find this same view in your svn): https://github.com/WordPress/WordPress/commit/81ed9a7563e5ad4c0edccd059bc4ea7d9c1a4a10 There's no explanation about why the code was removed, so would it be possible to add it back in? Thanks! Julia " jdkoelsch 21497 Make uploads on XML-RPC resumable XML-RPC normal minor Awaiting Review enhancement new has-patch 2012-08-06T02:48:56Z 2012-08-06T20:06:06Z In order to play nicely with unreliable internet connections (ie, mobile, conference wifi) it would be nice to be able to resume uploads over the XML-RPC API. pento 21495 wp_insert_user allows a user to be created with empty passwords Users normal minor Awaiting Review defect (bug) new 2012-08-06T02:10:00Z 2012-08-06T02:10:00Z "While looking at the different files where user information is created, I noticed that there are some differences between wp_insert_user(programmatic creation of users) and edit_user (called from the admin). wp_insert_user assumes that a user_pass parameter is included, which creates a user with no password. " ancawonka 21492 Theme customizer > Static front page: missing error message when front page and posts pages are similar Appearance normal normal Awaiting Review defect (bug) new 2012-08-06T00:15:25Z 2012-08-06T01:11:40Z "Steps to reproduce: 1. Activate Twenty Eleven 2. Open the Customizer 3. In ""Static Front page"", choose the same page as your front page and Posts page: * You do not receive any warning * http://i.wpne.ws/IYAO * In Reading Settings, you do actually receive a warning: http://i.wpne.ws/IY2S (see http://core.trac.wordpress.org/browser/trunk/wp-admin/options-reading.php#L99 ) Would it be possible to display the same warning in the Customizer, to avoid any confusion for the users? Related: #19627 and #16379" hd-J 21488 Add Default Callback Functions for add_settings_field() General normal normal Future Release enhancement reopened dev-feedback 2012-08-05T23:22:00Z 2013-02-24T04:57:58Z "By default, when creating options in plugins and themes, every developer is required to create custom callback functions for rendering their option's HTML. The HTML for most options is nothing more than a standard INPUT field, a SELECT field, TEXTAREA field, etc, so there's really no reason there shouldn't be default callback options in place. For example, if I have a plugin that registers one text field option in the General settings page, it really doesn't make sense that I should be forced to create a callback function, especially not when probably 99% of all text fields are outputted in exactly the same way: {{{ The description of the field (if present) }}} With default field callbacks available, developers can do this: {{{ function pw_register_settings() { register_setting( 'general', 'pw_sample_option', 'esc_attr' ); add_settings_section( 'pw_sample_section', 'This is a Sample Section', 'pw_sample_section_cb', 'general'); add_settings_field( 'pw_sample_option', 'A Sample Setting', 'text', 'general', 'pw_sample_section', array( 'description' => 'The field description' ) ); } add_action('admin_init', 'pw_test_settings'); function pw_sample_section_cb() { // this is the section HTML (if you want it) } }}} This is much simpler than also having to write the callback function to render the HTML for the option. The patch attached adds the following default callbacks: * text * textarea * select * radio * checkbox * checkbox_group For select, radio, and checkbox groups, the options are passed as an array of ""choices"" in the last, optional $args parameter for add_settings_field(): {{{ $options = array( 'one' => 'The Choice Name', 'two' => 'The Second name', 'three' => 'The Third option' ); add_settings_field( 'pw_sample_option', 'A Sample Setting', 'select', 'general', 'pw_sample_section', array( 'choices' => $options, 'description' => 'This is a select' ) ); }}} When a user wants to create a custom callback function, this is still allowed as call_user_func() is the default in the `$field['callback']` switch statement for the do_settings_fields() function." mordauk 21485 Exclude current post from Recent Posts widget Widgets normal normal Awaiting Review enhancement new has-patch 2012-08-05T23:16:56Z 2012-08-11T21:13:08Z "Checking demo site - http://twentytwelvedemo.wordpress.com/ If you visit any recent post like this one - http://twentytwelvedemo.wordpress.com/2012/03/28/road-trips/ The recent post widget on right sidebar include this post in recent 5 post. We could just exclude present post from the loop using code like this {{{ 5, ""orderby""=>""post_date"", ""post__not_in""=>array($post->ID) ); $posts = get_posts($args); foreach($posts as $post) { setup_postdata($post); ?> }}} Most theme has it. If you are already in a post which is among recent 5, no point of showing it in the loop. " Asif2BD 21483 Theme Customizer: Use any image from media library for background image Appearance 3.4.1 normal normal Awaiting Review enhancement new 2012-08-05T22:42:31Z 2013-04-11T10:28:09Z "I suggest that users be able to use any image in the media library as a background image from the customizer. At this time, if a user changes the theme background from the customizer, he/she must upload the image. This is already available from the dashboard, under Appearance > Background - it gives the option ""Or choose an image from your media library:"" I suggest that this option available on the dashboard also be available on the customizer. A similar option should be available for header images." jjonesftw 21472 Allow supplying a custom text to status_header() General normal minor Awaiting Review enhancement new has-patch 2012-08-05T20:19:54Z 2012-08-05T20:19:54Z "Problem: I'd like to issue a HTTP 500 error, but include a text different from Internal Server Error, so that the client knows what caused the error. Currently for a known error code the {{{status_header()}}} function always uses the global array {{{$wp_header_to_desc}}} and the only way to have my own text is to set the value in the global array. The patch adds a second a argument to {{{status_header()}}}." nbachiyski 21470 Wrong menu when no menu is set Menus 3.4.1 normal normal Awaiting Review defect (bug) new 2012-08-05T13:27:13Z 2012-08-05T13:59:30Z In the case if the admin hasn't created any menu in the dashboard (and so the default menu is shown), some parameters of wp_nav_menu() don't work. I verified that 'container'=>false does not work. Other parameters may no work as well. porton 21466 Allow post password cookie expiry to be customized General 3.4.1 lowest minor Future Release enhancement new has-patch 2012-08-04T20:52:35Z 2013-04-16T11:23:29Z "It'd be nice if you could customize the expiry time for the post password cookie that is set in `wp-login.php?action=postpass`. The only solution right now is [https://gist.github.com/3259814 pretty ugly]." Viper007Bond 21460 The accesskeys in Quicktags don't work in all browsers Editor normal normal Awaiting Review defect (bug) new 2012-08-03T19:21:56Z 2012-08-03T22:01:43Z "IE (Alt+letter) works properly. Firefox (Alt+Shift+letter) only focuses the corresponding Quicktags button sometimes. Doesn't perform the action. If the button is hidden, performs the action (this shouldn't happen in Quicktags). Chrome doesn't seem to do anything. Opera works differently: Shift+Esc brings a list of all defined access keys on that page. The Quicktags access keys are not listed there. " azaozz 21455 HiDPI (retina) theme custom backgrounds Otto42 Appearance normal normal Future Release feature request assigned 2012-08-02T17:07:06Z 2012-09-15T05:22:40Z "We should support HiDPI custom backgrounds. This will be a bit easier than custom headers, #21389, as we can do a media query in _custom_background_cb(). Worth noting that we will still need to solve some aspect of retina uploads, #21038." nacin 21453 Appending hyphen before numbers when creating a create unique filename in wp_unique_filename() Filesystem 3.4.1 normal normal Awaiting Review enhancement new 2012-08-02T13:32:00Z 2012-08-02T13:32:00Z "When WordPress appends a number to a file to create a unique filename, it just adds a number to the file. ie If ""photo.jpg"" exists then ""photo1.jpg"" is created I suggest that it should include a hyphen so the file would be called ""photo-1.jpg"" The main reason is that if you upload files ending in numbers then then the new filename is less easy to read. ie If ""photo234.jpg"" exists then ""photo2341.jpg"" is created Would be nicer if it produced ""photo234-1.jpg"" It's only cosmetic but it does make it easier to search for images in the uploads folder if you need to for any reason, especially if you have uploaded a load of images from a camera DSC123.jpg, DSC124.jpg etc" husobj 21452 When uploading media wp_unique_filename() treats capitalisation as being different. Filesystem 3.4.1 normal normal Awaiting Review defect (bug) new 2012-08-02T13:24:11Z 2012-08-02T13:24:11Z "On most web servers ""Photo.jpg"" and ""photo.jpg"" can be treated as different files. The problem is when backing up a local copy (to my Mac) it will not let both these files exist at the same time - it wants to replace one with the other as it treats lowercase and uppercase as the same. I suggest that we should do the same with uploads so that if ""Photo.jpg"" exisits and you upload ""photo.jpg"" is is renamed to a unique name. I guess this would require a fix in the wp_unique_filename() function." husobj 21450 wp_insert_new_post hook Post Types normal minor Awaiting Review enhancement new dev-feedback 2012-08-02T10:42:57Z 2013-03-14T10:11:22Z "Situation is this in wp_insert_post: {{{ if ( $update ) { do_action('edit_post', $post_ID, $post); $post_after = get_post($post_ID); do_action( 'post_updated', $post_ID, $post_after, $post_before); } do_action('save_post', $post_ID, $post); do_action('wp_insert_post', $post_ID, $post); }}} As you can see we have hooks that: 1. Get executed when post is '''updated''' 2. Get executed when post is '''updated or created''' There is no hook that would be exectued only when post is '''created'''. ''wp_insert_post'' was most logical candidate for the task, however i suspect changing it might break some plugins relying on it therefore i propose new action '''wp_insert_new_post''' which should be executed '''only when new post is created''', but '''never when post is updated'''. Like so: {{{ if ( $update ) { do_action('edit_post', $post_ID, $post); $post_after = get_post($post_ID); do_action( 'post_updated', $post_ID, $post_after, $post_before); } + else + do_action('wp_insert_new_post', $post_ID, $post); do_action('save_post', $post_ID, $post); do_action('wp_insert_post', $post_ID, $post); }}} P.S. I marked ticket as having patch even tho there is just updated code snippet above. Please excuse me :)" rndbit 21448 unfiltered HTML comments from a frame js fix breaks js in windowed comments Comments 3.4.1 normal normal Awaiting Review defect (bug) new has-patch 2012-08-01T21:58:53Z 2012-08-02T17:56:36Z "Noticed this today. We have comments loading up in a jquery colorbox on a site being developed and it loads the comment form via ajax. When it's loaded, the fix in #20812 breaks javascript because the property ""name"" is null. Attaching a patch after posting this for only executing when `document.getElementById(""_wp_unfiltered_html_comment_disabled"")` != null." nerrad 21446 plugins using curl with IPV6 enabled servers HTTP 3.4.1 normal normal Awaiting Review enhancement new close 2012-08-01T21:46:28Z 2012-08-09T10:41:24Z " plugins using curl give problems on servers having both IPV4 and IPV6 network interfaces running. Basically the performance is poor because curl is timing out on the IPv6 address.. The workaround is: add line: curl_setopt( $handle, CURLOPT_IPRESOLVE, CURL_IPRESOLVE_V4); in ../wp-includes/class-http.php Why not have this set as default? " mippie32 21444 update msgid-bugs-address for plugins in makepot.php I18N normal normal WordPress.org defect (bug) new 2012-08-01T20:09:09Z 2012-08-01T20:16:12Z "The msgid-bugs-address for plugins in makepot.php is outdated. References ""/tag/"" instead of ""/support/plugin/""." convissor 21442 Themes: change allowed term taxonomy from Width to Layout and add responsive-layout term Themes normal normal Awaiting Review enhancement new has-patch 2012-08-01T17:48:53Z 2012-08-06T00:18:10Z "See #21065 and discussion with WPTRT on http://make.wordpress.org/themes/2012/07/18/id-love-your-thoughts-on-adding-two-new/. ""Width"" is not accurate since themes can have fluid, fixed, or responsive height as well as width. ""Layout"" makes this more abstract." lancewillett 21435 wp-includes/comment.php line85 causes slow query due to the non-indexed column General 3.4.1 normal minor Awaiting Review enhancement new has-patch 2012-08-01T00:31:47Z 2012-08-01T00:31:47Z "Following query is causes slow query if the wp_comment table is huge. {{{ $ok_to_comment = $wpdb->get_var(""SELECT comment_approved FROM $wpdb->comments WHERE comment_author = '$author' AND comment_author_email = '$email' and comment_approved = '1' LIMIT 1""); }}} In my case, I have 600 thousand records in the wp_comments table and the query takes over 10 minutes to complete. http://matsu.teraren.com/blog/wp-content/uploads/2012/08/a40b1291fd99413dc3057fbe0b792a93.png To fix this issue, I added index on my running wordpress and returns 0.00sec. I'll attach the patch for create table file. " matsubobo 21432 Deprecate *_blog_option() ryan General 3.4.1 normal normal Future Release defect (bug) reopened dev-feedback 2012-07-31T21:53:06Z 2012-10-24T17:44:45Z "Deprecate get_blog_option(), add_blog_option(), update_blog_option(), and delete_blog_option(). The regular *_option() functions wrapped with switch_to_blog() and restore_current_blog() should be used instead. Previous discussion: http://core.trac.wordpress.org/ticket/21270#comment:11" ryan 21428 Bad mail subject encoding on new blog notification Multisite 3.4.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-07-31T14:02:59Z 2012-08-07T11:43:45Z "Email subject is in Russian language. When trying to add new blog using page http://mysite.com/wp-admin/network/site-new.php, user gets email where subject is like - '''=??B??='''. So I was trying to find where this bug appears. And I think, I found it. Script tries to send notification using function '''wpmu_welcome_notification''' on line http://core.trac.wordpress.org/browser/tags/3.4.1/wp-includes/ms-functions.php#L1250. But '''get_option('blog_charset')''' returns empty string, so header is bad-generated and encoded..." TheSteelRat 21425 the 'edit_users' capability also allows 'promote_users' Role/Capability 3.4.1 normal major Awaiting Review defect (bug) new dev-feedback 2012-07-30T17:07:52Z 2012-09-22T10:11:33Z "Hello all, I have found an issue where I have created a Support role in order to have a user make changes to basic user information. What I noticed was that the capability 'edit_users' allows said User (role) to promote users to any role - including admin! I tried removing the cap 'promote_users' and it does nothing. add_role( 'support', 'Support', array( 'read' => true, 'edit_feedback' => true, 'edit_others_feedback' => true, 'list_users' => true, 'edit_users' => true ) );" ew_holmes 21421 Sanitize/remove admin page slug from admin menu CSS classes Administration normal normal Awaiting Review defect (bug) new 2012-07-30T11:26:15Z 2013-03-02T21:00:41Z "As I discovered when testing #21307, browsers won't parse a CSS class name with both underscores and hyphens. Instead, they handle it ''really'' badly. For example: `.toplevel_page_link-manager` will affect `body` in both Firefox and Chrome. Plugin page menu items have both an ID and class generated as such, which seems rather redundant. I propose either dropping the redundant and only partly functional CSS class or standardising the menu slug to produce a valid class name." kawauso 21417 Custom Post Type Permalink Returns 404 Error Permalinks 3.4.1 normal minor Awaiting Review defect (bug) new reporter-feedback 2012-07-30T02:11:54Z 2012-09-08T21:17:52Z "Since, I upgraded Wordpress version from 3.3.2 to 3.4.1, I discovered permalink returns 404 error on (1) Paged categories, and (2) Custom type posts. The paged categories has been fixed implementing ticket:21209, but custom type posts return 404 error when it called. I am using following code to register custom type post 'products'. {{{ function products_register() { $labels = array( 'name' => _x('Products', 'post type general name'), 'singular_name' => _x('Product', 'post type singular name'), 'add_new' => _x('Add New', 'product item'), 'add_new_item' => __('Add New Product'), 'edit_item' => __('Edit Product'), 'new_item' => __('New Product'), 'view_item' => __('View Product'), 'search_items' => __('Search Product'), 'not_found' => __('Nothing found'), 'not_found_in_trash' => __('Nothing found in Trash'), 'parent_item_colon' => '' ); $args = array( 'labels' => $labels, 'public' => true, 'publicly_queryable' => true, 'show_ui' => true, 'query_var' => true, // working perfect in 3.3.2 'rewrite' => true, // also tried this in 3.4.1 'rewrite' => array('slug' => 'products','with_front' => FALSE), 'rewrite' => array('slug' => 'products'), 'capability_type' => 'post', 'hierarchical' => false, 'can_export' => true, 'menu_position' => 5, 'taxonomies' => array('category'), 'supports' => array('title','editor','thumbnail', 'custom-fields') ); register_post_type( 'products' , $args ); } //Registering Post-Type Products for Affiliate products only add_action('init', 'products_register'); function add_default_boxes() { register_taxonomy_for_object_type('category', 'products'); } //Registering Taxonomy for Products post-type add_action('init', 'add_default_boxes'); }}}" imageac 21414 "Use the ""Keyboard Shortcuts"" checkbox in the user profile to turn on/off all custom shortcuts" Accessibility normal normal Awaiting Review enhancement new 2012-07-29T20:24:36Z 2012-10-14T11:42:23Z "Custom keyboard shortcuts can be very handy not only for better accessibility but for faster access to many actions that usually require ""mousing"". For example we could potentially add shortcuts to access the top menu items or the more commonly used toolbar items. However many of the available keystrokes (modifier [+ modifier] + letter) are already in use. Even worse, different shortcuts are in use in different browsers and different OS. It would be good to let the users decide whether to enable them. As we already have a checkbox for the comment moderation shortcuts, best would be to make it ""global"". For now that would only affect TinyMCE." azaozz 21412 Hookable dropins Cache normal normal Awaiting Review enhancement new dev-feedback 2012-07-29T03:59:34Z 2012-07-30T22:12:02Z "This ticket is the result of a discussion on the wp-hackers list where I proposed the idea in [http://lists.automattic.com/pipermail/wp-hackers/2012-July/043772.html this message]. Currently for dropins there can be only one[1] per install which means that, especially for `advanced-cache.php` where multiple plugins cannot easily: - Cache different mime types with different plugins - Provide basic functionality and leave the complexity to other plugins because hooks are not available ''(this is likely needed for a good page caching API to ever emerge from the work of plugins.)'' For caching this results in plugins like WP Super Cache and WP Total Cache that significantly violate a sancrosact WordPress philosophy of ''""[http://wordpress.org/about/philosophy/#decisions Decisions, not Options]''"". To see what I mean, just visit the settings page for either of these plugins. ''(Note: I'm not criticizing the plugins or their developers, instead saying that WordPress doesn't give them much of a choice.)'' It turns out however that fixing this is really lightweight and easy, at least for `advanced-cache.php`. I will attach the following files but here is the short list of changes to core required: - Move the hooks-related function out of `/wp-includes/plugin.php` into another file which I called `/wp-includes/hooks.php` and include `/wp-includes/hooks.php` in `/wp-settings.php` close to the top after `/wp-includes/versions.php` is included. - Include another new file `/wp-includes/dropsin.php` in `/wp-settings.php` after `/wp-includes/hooks.php` which contains a `wp_load_dropins()` function that `include()`s all `.php` files found in `/wp-includes/dropins/`. - Lastly add the following two (2) lines before `advanced-cache.php` is included: {{{ // Load any potential dropins found /wp-content/dropins/ wp_load_dropins(); // Run the hook-based page cache. do_action( 'page_cache' ); }}} With this future caching plugins can implement the page_cache hook by dropping a file into `/wp-content/cache/` instead of adding an `/wp-content/advanced-cache.php`. If this idea is blessed then we could add a deprecation notice for `/wp-content/advanced-cache.php` and also potentially replace (some of) the other dropins with `do_actions( ""{$dropin_hook}"" )`. [1] [http://www.urbandictionary.com/define.php?term=%22there%20can%20only%20be%20one%22%20 Gratuitous Highlander reference]." mikeschinkel 21411 Current Local Time for Port-au-Prince, Haiti is incorrect. patrick@… Date/Time 3.4.1 normal minor Awaiting Review defect (bug) new close 2012-07-29T00:44:29Z 2012-07-29T04:50:57Z "When the Port-au-Prince Timezone is selected via wp-admin/options-general.php the Local Time is one hour behind. Please see [http://wwp.greenwichmeantime.com/time-zone/caribbean/haiti/time-haiti/] for the correct local time. Yes, the problem occurs even when all plugins are deactivated and the default theme is activated. " pnommensen 21407 Allow filtering of upload resize dimensions Media 3.4.1 normal normal Awaiting Review enhancement new dev-feedback 2012-07-28T18:00:19Z 2012-07-29T19:29:25Z "Background: Plupload ships with a client-side upload resizer that was included with Core in 3.3 but had the action removed because of [http://core.trac.wordpress.org/ticket/19174 browser inconsistencies] so I implemented it as [http://wordpress.org/extend/plugins/enable-image-scaling-option-on-upload/ a plugin] at the time. Everything works just fine and dandy with zero problems except that the `resize_height` and `resize_width` vars are defaulted to the Large image sizes defined in media settings. It would be nice to be able to filter one or both of the dimensions outside the scope of the 'Large' size (when 'Original' becomes the same size as 'Large', you effectively lose an image size). Patch attached. You'll have to re-add this action to test: `add_action( 'post-upload-ui', 'media_upload_max_image_resize' );` Related: #19174, #19770" DrewAPicture 21403 Introduce wp_scandir, remove opendir / closedir code Filesystem 3.0 normal normal Awaiting Review enhancement new has-patch 2012-07-28T08:57:20Z 2012-07-29T18:29:23Z "There is {{{@opendir}}} code all over the place that is not standardized. On top of that, there is plenty of code that is duplicated and could be condensed into one handy function. Plus, in all of the places we are using {{{opendir()}}}, we really want to be using {{{scandir()}}}. I have created a master function in {{{load.php}}} called {{{wp_scandir()}}} that does the basics: * scans a directory for files / subdirectories * filters list by extension(s) * optionally returns ONLY files This cleans up code in many places." wonderboymusic 21402 Remove PHP4 methods, format consistently Cache normal normal Future Release enhancement new has-patch 2012-07-28T06:24:33Z 2013-05-14T13:16:42Z "While I was looking around in cache.php, I noticed the TODO to remove the destructor that does nothing and the constructor that registers it to do nothing Also, the whitespace was different for almost every function - yet the functions all have similar code, this cleans it up" wonderboymusic 21401 Load packaged object cache when advanced-cache.php and object-cache.php don't implement wp_cache_init( ) Cache 3.0 normal normal Future Release enhancement new has-patch 2012-07-28T06:00:11Z 2013-05-14T13:22:25Z "'''This ticket has 3 purposes:''' 1) introduces {{{wp_using_ext_object_cache()}}} - mimic {{{wp_suspend_cache_invalidation()}}} and disallow direct access to {{{$_wp_using_ext_object_cache}}}, cleans up importing of globals in functions and provides function to modify that global[[BR]][[BR]] 2) load the wp-packaged object cache when {{{object-cache.php}}} doesn't implement {{{wp_cache_init()}}}[[BR]][[BR]] 3) adds file_exists for advanced-cache.php {{{wp_start_object_cache()}}}, at its core, is on the hunt for {{{wp_cache_init()}}} and then sets the toggle for the external object cache. We only care about the external object cache if it has that function. Rather than throwing a fatal error if their is a missing method, load the default object cache. If someone installs Memcached properly, then nothing changes - file loads, all is good. If they install a blanks file, the default Object Cache will load. If they install an external object cache without {{{wp_cache_init()}}}, the default cache loads. IMO - there is no reason to turn off non-persistent caching or throw a fatal error if the author of a cache plugin sucks or the user made a mistake in moving the files." wonderboymusic 21398 Live preview of new post/page via XML-RPC for mobile clients. XML-RPC normal normal Future Release enhancement new 2012-07-27T10:13:47Z 2012-09-16T19:58:49Z "We'd like to have the possibilty to load the 'live preview' for a post/page you're writing on a mobile client. (New post not already ""synched"" with the server, or post edited within the mobile app). The only solution that I can see at the moment is the following: - Upload the post/page to the server with the status set to 'Draft'. - Load the permalink of the post. - Open the post in a webview by using the WP login form and the redirect_to parameter. " daniloercoli 21396 Categories widget reports categories without posts when they have custom posts Widgets 3.4.1 normal normal Awaiting Review defect (bug) new 2012-07-27T02:36:46Z 2012-07-27T04:27:26Z "This problem may be related to #14084, but this report is specific to the behaviour of the Categories Widget. - Create a custom post type eg. ""Products"" - Create a category eg. ""Photographs"" - Add some posts of type Products, assign them to category Photographs - go to the blog page and the Categories widget lists Photographs as a category - click on Photographs - the ""Nothing Found"" post is shown. There are no normal posts of category Photographs, but the widget lists a category that returns nothing. I would have expected the widget not to list a category that has no normal posts. " pkwooster 21389 Retina theme custom headers Otto42 Appearance normal normal Future Release feature request assigned 2012-07-25T19:40:56Z 2013-04-06T23:33:11Z We should support retina custom headers. Not sure how — ideas welcome. nacin 21387 Add a CodeURI field to plugin file header WordPress.org site normal trivial WordPress.org feature request new 2012-07-25T19:33:28Z 2012-07-25T19:38:48Z "I would like to make it easier for developers not associated with a plugin to contribute modified versions. The plugins SVN has grown to a size where it's no longer possible for a member of the WordPress community to create a new ticket and select a plugin from ""component"" to patch and improve software. Some plugins manage code on a site such as GitHub and commit a release into the plugins SVN. I might use [http://wordpress.org/extend/plugins/wp-super-cache/ WP Super Cache] in my WordPress installation, one of 3.5 million installs using the plugin. I modify the plugin and would like to share my changes. 1. Try creating a [http://plugins.trac.wordpress.org/newticket new ticket in Plugins Trac]. The plugin is not listed as an available component. 1. Find the Plugin URI. If not WordPress.org look around on the author's site for links to another repo. 1. Search GitHub for the developer(s) and/or project 1. Email the developer(s) if they have a contact email listed Give up? File header currently includes a [http://codex.wordpress.org/File_Header#Plugin Plugin URI] which commonly points to the WP.org plugin page for the plugin or sometimes to a webpage on the developer's site. I could overload ""Donate"" to encourage code donations instead of monetary donations but that could be confusing. I'd like to provide a explicit code URI field to encourage outside contributions of modifications in the GPL spirit." niallkennedy 21386 XML-RPC needs a user permission method XML-RPC normal normal Future Release enhancement new 2012-07-25T18:33:24Z 2012-11-23T20:42:43Z "At this moment when calling a XML-RPC method you will receive a error when the user can't do that method. What would be better if there is a way an app can retrieve the user permissions and act on that without the need to call the method." markoheijnen 21380 Impossible to modify URL of attachment Media 3.4.1 normal major Awaiting Review defect (bug) new 2012-07-25T16:16:42Z 2012-07-25T17:45:33Z "When you upload an image to a post and want to change the URL field afterwards and click ""save changes"", wordpress reloads and the URL is still the same." mkampitsch 21375 Add Filter for next_posts_link/prev_posts_link label General normal minor Awaiting Review feature request new 2012-07-25T14:56:47Z 2012-07-26T17:06:56Z "There is currently a filter 'next_posts_link_attributes' that allows plugins to add/modify classes/rel/etc to the links. However, the actual label that is displayed for the link is not accessible through this. I think that the $label variable in function get_next_posts_link should be run through a filter to allow it to be modified by plugins. For example, a plugin that adds a custom post type of Apple might want these links to say Next Apples or Previous Apples, or if a plugin changes the ordering of posts, it might want to change 'Earlier' type labels that many themes use to better reflect the new ordering system" MadtownLems 21374 Add core support for letting custom permalink structure for different post types Rewrite Rules 3.4.1 normal normal Awaiting Review enhancement new 2012-07-25T14:42:15Z 2012-09-19T09:56:07Z "By default, custom post types uses only the'' %postname%'' permalink structure (if using pretty links and not default query variables). Currently there is no native way to easily have different permastructs for different CPT. This features should be added to the '''register_post_type()''' function, letting different permalink structure be defined to each post_type being registered. I sugget adding another new key to the '''rewrite''' array that can be passed to the '''register_post_type()''' function. i.e. - {{{ register_post_type('event',array( ...... 'rewrite' => array('slug' => 'events', 'permastruct' => '%year%/%monthnum%/%event%' ), ..... )); }}} The register_post_type function should be changed, a suggestion for such a change may be that instead of this line in the function - (post.php line#1075) {{{ add_permastruct( $post_type, ""{$args->rewrite['slug']}/%$post_type%"", $args->rewrite ); }}} This example could be used - {{{ if ( $args->rewrite['permastruct'] ) { $perma_structure = $args->rewrite['permastruct']; $wp_rewrite->add_rewrite_tag(""%{$post_type}%"", '([^/]+)', ""{$post_type}=""); $wp_rewrite->add_permastruct($post_type, $archive_slug.'/'.$perma_structure, false); } else { add_permastruct( $post_type, ""{$args->rewrite['slug']}/%$post_type%"", $args->rewrite ); } }}} In order that the structure can interpret the permastruct tags, I added also this function to filter post_type_link, it is adapted from '''get_permalink''' function in ''wp-includes/link-template.php'' - {{{ add_filter('post_type_link', 'tc_permalink', 10, 3); function tc_permalink($permalink, $post_id, $leavename) { $post = get_post($post_id); $rewritecode = array( '%year%', '%monthnum%', '%day%', '%hour%', '%minute%', '%second%', $leavename? '' : '%postname%', '%post_id%', '%category%', '%author%', $leavename? '' : '%pagename%', ); if ( '' != $permalink && !in_array($post->post_status, array('draft', 'pending', 'auto-draft')) ) { $unixtime = strtotime($post->post_date); $category = ''; if ( strpos($permalink, '%category%') !== false ) { $cats = get_the_category($post->ID); if ( $cats ) { usort($cats, '_usort_terms_by_ID'); // order by ID $category = $cats[0]->slug; if ( $parent = $cats[0]->parent ) $category = get_category_parents($parent, false, '/', true) . $category; } // show default category in permalinks, without // having to assign it explicitly if ( empty($category) ) { $default_category = get_category( get_option( 'default_category' ) ); $category = is_wp_error( $default_category ) ? '' : $default_category->slug; } } $author = ''; if ( strpos($permalink, '%author%') !== false ) { $authordata = get_userdata($post->post_author); $author = $authordata->user_nicename; } $date = explode("" "",date('Y m d H i s', $unixtime)); $rewritereplace = array( $date[0], $date[1], $date[2], $date[3], $date[4], $date[5], $post->post_name, $post->ID, $category, $author, $post->post_name, ); $permalink = str_replace($rewritecode, $rewritereplace, $permalink); } else { // if they're not using the fancy permalink option } return $permalink; } }}} On a basic check this seems to be working, but ofcourse needed to be more deubgged.. I will be happy to here if you think such a feature should be added to core." maorb 21364 Pass post type to count_user_posts() General 3.0 normal normal Awaiting Review enhancement new has-patch 2012-07-24T08:22:14Z 2012-07-25T12:26:04Z Add $post_type argument to count_user_posts(). Defaults to 'post', as it is hard-coded now. Caspie 21354 "Prefix toolbar site menu title with ""Visit "" when in the admin." Toolbar normal normal Future Release enhancement new has-patch 2012-07-23T18:32:12Z 2012-11-22T03:30:28Z "2 out of the 3 users we tested had a hard time finding a link to view their site from the admin. What if we simply added the word “Visit” in front of the site title in the toolbar when you are in the admin, and to delete the single drop down option when you’re not using multi-site. The view of the menu from the site would stay the same. Something like this: [[Image(http://f.cl.ly/items/322O2i1s1z1909012e19/visit-site-link.png)]] Props to @sabreuse for the idea." lessbloat 21352 wp_lostpassword_url() on multisite Multisite 3.3 normal normal Awaiting Review defect (bug) new dev-feedback 2012-07-23T15:58:23Z 2013-04-24T18:59:15Z "The wp_lostpassword_url() function on Multisite outputs the link to the primary domain not the current domain. Although it works its not what should be expected if a user is registered to use blog ID 2 but not Blog ID 1. The lost password email generated also links back to the primary domain not the current domain. " philly max 21341 Explain Site and User count update frequency in Network Admin contextual help Help/About normal trivial Awaiting Review enhancement new has-patch 2012-07-22T01:03:00Z 2012-07-22T01:03:00Z "While adding a bunch of sites to a multisite install today, I noticed for the first time that the counts (option `blog_count`) for sites and users in the Right Now box don't update immediately. I was confused, but then saw [[ticket:15170]] which moved the count update to a twicedaily cron for scalability reasons. It may be helpful to include this information in the contextual help for others who will find themselves confused. Attached patch is an attempt at that." jeremyfelt 21330 Allow filtering of expiration in set_transient() Cache normal normal Awaiting Review enhancement new dev-feedback 2012-07-20T20:51:23Z 2012-09-17T18:32:01Z I recently needed to change an expiration of a transient and expected pre_set_site_transient_* filter to be able to do that. However, the filter only affects the value. I recommend adjusting this to affect both. wpsmith 21329 Consolidate filters and functions in wp-admin/includes/media.php Media normal normal Awaiting Review enhancement new close 2012-07-20T20:28:59Z 2013-01-28T23:50:11Z in wp-admin/media.php, there are several functions that do similar things and could be combined, simplifying how they get used. martythornley 21323 wp_delete_attachment (leaves stale image class wp-image-### in content of post). Media 3.4.1 normal trivial Awaiting Review defect (bug) new 2012-07-20T13:33:56Z 2012-07-20T13:33:56Z " Here is my Example I'm using: Running a script below (placed in the wordpress docroot) to delete all thumbnails from the database: {{{ require_once(""wp-load.php""); echo 'Working... '; ob_flush(); global $wpdb; $attachments = $wpdb->get_results(""SELECT * FROM $wpdb->postmeta WHERE meta_key = '_thumbnail_id'""); foreach($attachments as $attachment){ $wpdb->query(""DELETE FROM $wpdb->postmeta WHERE meta_id = '$attachment->meta_id' LIMIT 1""); wp_delete_attachment($attachment->meta_value, true); } echo 'done!'; }}} Now after running something like above I'm left with (inside my content of each post) a stale image class tag that no longer points anywhere. I think a simple regex replace of the post_content for wp-image-#### Inside an Image tag would remove the stale element. I haven't checked this with other attachment types to see if it also exists, but my guess is it would." eliddon 21321 Remove is_null() checks in apply_filters(), do_action(), et al. nacin Performance normal normal Future Release enhancement reopened 2012-07-20T04:55:29Z 2012-09-16T18:39:00Z "In apply_filters(), do_action(), and friends, there is a check for `! is_null( $the['function'] )`. As these functions get called collectively thousands of times per page, a tiny check like this can add up. A few months ago, I decided to track it down. They were shuffled around a bit in [4955], but they actually had roots in [1394]. The link there (http://www.kackreiz.net/wordpress.php) is dead, but I found it at http://www.kackreiz.net/wordpress/apply_filters.html#fixed, via http://wordpress.org/support/topic/bug-in-remove_filterapply_filters?replies=3. The original bug was that remove_filter() left NULL's in the $wp_filter array, rather than properly unsetting it as it was modified to do long ago. Now that we no longer leave NULL scattered about, this check is safe to remove." nacin 21319 is_textdomain_loaded() returns true even if there are no translations for the domain nbachiyski* I18N 3.0 normal normal Future Release defect (bug) accepted dev-feedback 2012-07-20T03:48:56Z 2012-11-06T23:15:36Z "#10527 introduced is_textdomain_loaded(). It returns true if load_textdomain() has been called, even if no translations were loaded for that domain. I think it should return false if no translations were loaded. As the documentation says, ""@return bool Whether there are translations"". In this case, no, there are not translations. Attached patch also does the following: * Does not store instances of NOOP_Translations inside the $l10n global. Previously, we instantiated NOOP_Translations once for each domain that was missing translations; since we are no longer storing NOOP_Translations instances inside $l10n, we need to avoid instantiating it for every call to get_translations_for_domain(). Thus, NOOP_Translations is now instantiated only once, using a static variable. * Removes by-references for get_translations_for_domain(), which are no longer needed in PHP5." nacin 21314 Add password reset key expiration Users 3.4.1 normal minor Awaiting Review enhancement new has-patch 2012-07-19T11:30:19Z 2012-07-20T09:59:31Z "Password reset using correct user_activation_key is currently possible forever. Attached is a patch which clears newly created user_activation_key after one week." skithund 21311 "The ""Paste as plain text"" feature in TinyMCE produces double-line breaks between paragraphs." Editor 3.4.1 normal minor Awaiting Review defect (bug) new close 2012-07-19T10:41:13Z 2012-07-20T08:44:55Z "Mac OSX Lion, Chrome, WordPress 3.4.1 See attached SWF for a screen-video demonstration. • In WP-Admin -> Posts -> Add new, with the editor in visual mode, click the ""Pase as plain text"" icon [[BR]][[BR]] • Paste your content into the window that pops up and click ""Insert"" [[BR]][[BR]] • Note that two paragraphs seem to be double-line breaked. [[BR]][[BR]] • Switch to HTML mode and note that there are extra "" "" spaces inserted between paragraphs. [[BR]] " uxtremist 21306 "Archived blogs should return HTTP ""404 Not Found"", not ""410 Gone""" Multisite normal normal Awaiting Review defect (bug) new has-patch 2012-07-18T19:39:51Z 2012-07-18T19:39:51Z "In a multisite network, if a site is archived, ms_site_check() currently serves up a HTTP 410 status code. Here's what the [http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html HTTP spec] has to say about 410: The requested resource is no longer available at the server and no forwarding address is known. This condition is expected to be considered permanent. Clients with link editing capabilities SHOULD delete references to the Request-URI after user approval. If the server does not know, or has no facility to determine, whether or not the condition is permanent, the status code 404 (Not Found) SHOULD be used instead. This response is cacheable unless indicated otherwise. It's acceptable to serve a 410 if the site is marked as deleted or spam, but I don't think that archiving the site is an indication that the site is permanently and irrevocably gone. Although a case can be made for changing it to 404, my contention is that a 403 is more appropriate for semantics and for bots. From the same HTTP spec: 403 Forbidden: The server understood the request, but is refusing to fulfill it. vs 404 Not Found: The server has not found anything matching the Request-URI." amattie 21304 Create unique file for rotated images Media normal normal Awaiting Review enhancement new 2012-07-18T16:31:06Z 2012-07-18T16:31:06Z When images are cropped in WordPress, the resulting file is given a unique filename, which helps in two ways — the original is preserved, and it also busts any caching. Preserving the original isn't such a major concern when we're talking about rotating the image, but caching still can be an issue. I propose that when images are rotated they're given a unique filename to bust through any caching or CDN that the image has already gone to. wpdavis 21300 Implement autoloader compatible with PSR-0 for plugins and themes General normal normal Awaiting Review feature request new 2012-07-17T21:15:45Z 2012-09-11T02:20:09Z "To provide more compatibility with other frameworks, it would be great if WordPress implemented an autoloader compatible with PSR-0. Plugins and themes could then register namespaces or prefixes with the autoloader. I believe this could be implemented without any BC breaks. Details of the PSR-0 standard: https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-0.md" dave1010 21295 Retrospectively generate new images sizes if requested Media normal normal Awaiting Review feature request new 2012-07-17T10:12:01Z 2012-12-03T17:45:36Z "At present the image variations are created at the moment the image is uploaded to the server. If a new image size is later added, or the default ones changed after an image is uploaded then the existing images are not adjusted. Whilst there are plugins that provide - regenerate thumbnail functionality it might be neater if an image size is requested that doesn't exist that the system generates it at the time it is requested. This only need happen once per image as once it is created it doesn't need to be created again." TwoThirdsWater 21294 Introduce zoom-crop in Media image handling Media normal normal Awaiting Review enhancement new 2012-07-17T10:09:23Z 2013-04-08T15:03:29Z Please could the wordpress image handling introduce support for a zoom crop of images smaller than specified file sizes. TwoThirdsWater 21293 Add bbPress as a flavor option to WordPress Showcase WordPress.org site normal normal WordPress.org defect (bug) new 2012-07-17T08:29:13Z 2012-07-17T12:02:44Z "First discussed here: http://bbpress.org/forums/topic/bbpress-content-re-organization/#post-114999 The bbPress 2 plugin is now quite mature and gaining traction. There are some outstanding sites using bbPress 2 well worth showcasing already, such as [http://devpress.com/forums/ devpress.com/forums]. It's high time the WordPress showcase site received a ""bbPress"" flavor to accommodate great looking forum sites." Sadr 21292 XML-RPC: wp_upload_bits should act like wp_handle_upload westi XML-RPC 3.0 normal normal Future Release defect (bug) assigned has-patch 2012-07-17T07:01:23Z 2013-05-07T11:37:28Z "At this moment there isn't a check for file size when uploading an image through the XML-RPC. The reason is that the method wp_upload_bits is used. This only checks it does is if the file size is to big for a network installation. The function check_upload_size() is something what you want except that it will use wp_die() if there is an error like this. The function is used as a filter: wp_handle_upload_prefilter. Which only get applied in the function wp_handle_upload. We should probably change check_upload_size() a bit so it doesn't use wp_die() but does it somewhere else. related: #6559 and #21085" markoheijnen 21287 Fix Widgets Helper position on start event - sortable Widgets 3.4.1 normal normal Awaiting Review defect (bug) new 2012-07-16T09:33:24Z 2012-12-13T12:31:33Z "the widget helper moves (jumpes) to the left, to the parent left position... in Firefox this is not a bug but in chrome it does. please take a look in the screenshot, the helper jumped to the left.... http://wpimpact.com/wp-content/uploads/2012/07/Untitled-2.png I tried to use the : {{{ ui.helper.css('left', ui.placeholder.position().left) }}} code but chrome does not set a placeholder position, I don't know why, maybe a chrome bug or in jQuery. " alexvorn2 21285 Don't ping yourself, especially on localhost Pings/Trackbacks 1.2 normal normal Awaiting Review defect (bug) new has-patch 2012-07-16T03:33:32Z 2013-01-22T22:53:19Z "This may just be a conversation starter, but I know these things to be true: 1) there is duplicated code spread between pingback( ) and do_enclose( )[[BR]] 2) If your post contains a bunch of links to your own site, and you save your post in the admin, you will ended up with memory leaks all over the place / seg faults / etc when you get hammered by HEAD requests triggered by the immediate cron that is spawned by the post being saved[[BR]] 3) you probably don't need to trackback yourself anyways I moved some dupe code into functions and added some checks so we don't ping ourself when saving" wonderboymusic 21284 Better New Plugin Filtering Plugins normal normal WordPress.org feature request new 2012-07-15T17:24:24Z 2012-07-18T15:04:03Z "Currently trying to sort through available plugins by searching is quite laborious since there is no way to filter out things you don't want - such as plugins that haven't been tested with your version, haven't been updated in 100+ days, have a really low rating, etc. I'm constantly surprised at how many plugins i have to go through before i can even find one that is compatible with at least WP two versions ago much less the current one. You should be able to filter on: Tested with current version, Rating of X+, Download at least XX, and so on to make it easier to find something you want. And then column sorting after then by date added, date updated, rating, etc." cbesett 21282 Introduce wp_header() pluggable function General 3.4.1 normal normal Awaiting Review enhancement new dev-feedback 2012-07-15T12:47:22Z 2012-09-26T15:46:20Z "I will be nice to have pluggable function wrapper for PHP `header()` function - this will allow to unit test HTTP headers sent by WordPress. Attached patch adds it, and replaces all existing calls to `header()` with it. Question: some of exiting calls had errors silenced using `@`, some not. In my code I added `@`. Should I keep it, remove it or maybe add extra param to function to conditionally silence errors?" sirzooro 21281 "RTL wysiwyg ""padding""/""indention"" action is not works as expected." azaozz TinyMCE 3.4.1 normal major Awaiting Review defect (bug) assigned 2012-07-15T08:33:06Z 2013-02-01T16:11:41Z "By clicking the padding button(for indention) the action not works - it warpped the text by ""p"" element with '''padding-left''' insted or '''padding-right''' in RTL." AlmogBaku 21276 Respect 'suppress_filters' arg in WP_Query->get_posts() Query 3.4.1 normal normal Future Release defect (bug) new has-patch 2012-07-15T01:13:50Z 2013-02-14T22:06:52Z Before trying to run filters, there's a check to see if we should suppress filters using the suppress_filters arg. Four filters run whether or not suppress_filters is set to true. This patch just adds checks against that arg for those filter calls. brandondove 21273 Automatically open help panel Help/About normal trivial Future Release enhancement new has-patch 2012-07-14T19:04:20Z 2012-10-30T17:32:36Z "The help screen is highly inaccessible. Developers are not able to link to content in the help panels if you need to point users to specific directions for your plugin. This patch is a quick stab at it to see if it's worth while. What it does it allow direct links to the help panel. Upon pageload, it'll automagically open up to the correct panel. Usage: 1. Install the patch 2. Click http://wordpress.dev/wp-admin/index.php#tab-panel-help-layout Again, this is a quick stab. The concept could definitely be improve/abstracted and DRYed up. Let me know your thoughts :-)" ptahdunbar 21271 Make admin backend unit-tests friendly Administration 3.4.1 normal normal Awaiting Review enhancement new dev-feedback 2012-07-14T14:19:20Z 2012-12-11T13:12:31Z "Recently I started writing unit tests for my plugins. Beside tests focused on functionality (where I directly call my plugin functions) I write some basic integrations tests, which should test that WordPress will call my function, pass data in expected format and recognize data returned from it. For frontend it is quite easy - theme API is well-defined, so I can write something like this: {{{ public function test_something() { // add new post $post_id = wp_insert_post( array( ... ) ); $this->assertGreaterThan( 0, $post_id ); // go to post page $this->go_to( get_permalink( $post_id ) ); // main loop $checked_post = false; while ( have_posts() ) { the_post(); if ( $post_id == get_the_ID() ) { $checked_post = true; // test that content is modified ob_start(); the_content(); $result = ob_get_clean(); $this->assertEquals( '...', $result ); } } // make sure test above was executed $this->assertTrue( $checked_post ); } }}} Unfortunately this is not true for admin backend - there most of code is written directly at file level (not in functions and classes), so I would need to either duplicate this code in my tests (bad approach, because would have to monitor original code for changes), or test using whole file (either load it directly or use Selenium) - in this case test would be more complicated. Therefore I logged this ticket, to start discussion how we can perform refactoring of admin backend to make it more tests-friendly, and how to test it more thoroughly. Most probably we would also need to modify the testing framework (e.g. introduce new `admin_go_to()` method)." sirzooro 21268 _wp_page_template is getting 'stuck' to a page General 3.4.1 normal normal Awaiting Review defect (bug) new 2012-07-13T22:21:42Z 2012-07-13T22:21:42Z "Unmodified WP 3.4.1 / Ummodified TwentyEleven theme Create a page (id=2). Manually add a postmeta entry for {{{ post_id=2, meta_key = _wp_page_template, meta_value = pagefull.php }}} The page now opens with margin: 0 7.6%; (correct!) Now try to change it back to default, either by removing the _wp_page_template postmeta record or by editing the page -> Page Attribute / Template. The page will not revert back to Default. It continually displays as Full Width, and a postmeta item telling post_id 2 to use _wp_page_template = pagefull.php is added. http://wp34.roveridx.com/?page_id=2 This behavior does not happen in 3.3.2." shawmutsteve 21267 Kill the serialization of $wp_filter in get_terms() Cache normal normal Future Release defect (bug) new has-patch 2012-07-13T21:35:11Z 2013-01-22T19:35:23Z "We use this as part of a persistent cache key: {{{ serialize($GLOBALS['wp_filter']['list_terms_exclusions']) }}} See [8225]. This is not good for two reasons. First, well, it's a not fun to reach into our internal API like that. But worse, it's broken whenever an object method is used, because spl_object_hash() will be unique to that object, thus rendering the cache invalidated on the next pageload. As an aside, we should probably have _wp_filter_build_unique_id() create a delimiter when dealing with a static class method — `$function[0].$function[1]` can conflict with a legitimate function name. I'm not sure how this should be fixed." nacin 21266 Enhancements for page numbers links API Permalinks 3.4.1 normal normal Awaiting Review enhancement new has-patch 2012-07-13T20:59:17Z 2012-07-14T21:47:23Z "Currently WordPress provides few functions to create links with page numbers embedded. Unfortunately they have some limitations:[[BR]] - `get_pagenum_link()` - works on `$_SERVER['REQUEST_URI']` only;[[BR]] - `get_comments_pagenum_link()` - works on current post only;[[BR]] - `_wp_link_page()` - works on current post only, returns HTML code and is private. Because of these limitations in the past I have reimplemented these functions in my SEO plugin. Now I decided that it will be better if WP core will provide needed functionality. Attached path introduces following changes for functions:[[BR]] - `get_pagenum_link()` - added new `$url` param, which can be used to pass any URL to function;[[BR]] - `get_comments_pagenum_link()` - added two new params: `$post` and `$add_anchor`. The former one allows to pass any post object to function, the latter one tells function if it should append `#comments` at the end of URL; - `get_post_page_link()` - new function. I moved code from `_wp_link_page()` here and modified it so it can work on any post. Additionally it calls new filter `get_post_page_link` before returning value.[[BR]] Additionally these functions passes new argument(s) to filter at the end, so it will be easier for plugins to generate different pagination URLs. I also modified `_wp_link_page()` function (now it calls `get_post_page_link()`) and removed `@access private` from `wp_link_pages()` (as I checked, it is called from themes code only)." sirzooro 21265 settings_fields() conflict with admin-ajax.php in ajax requests Plugins 3.4.1 normal normal Awaiting Review defect (bug) new 2012-07-13T19:30:32Z 2012-07-13T19:30:32Z "I created a plugin, which uses the function 'settings_fields()' to generate required fields. When I save the plugin options, I decided to use Ajax Requests to save time. Until 3.3.2 this was working well, but with 3.4.1 admin-ajax.php code update generates a errors. Because ""settings_fields()"" generate hidden field called ""action"" and before 3.4.1 admin-ajax.php used $_GET['action'] to call ajax action dynamically. '''How reproduce:''' 1. Use WP 3.4.1 2. Put this code snippet in a .php file in wp root folder: {{{ }}} In wordpress 3.4.1 field 'action' changes to 'update', because $_REQUEST['action']. In wordpress 3.3.2, field 'action' is 'mysettings_save'. I have to redo all my work with my plugin with this change in Wordpress 3.4.1. " vdvtt 21258 Autosuggest for tags suggests tag already chosen General normal normal Awaiting Review enhancement new 2012-07-13T12:38:03Z 2012-07-13T12:38:03Z "When entering tags in the meta box on a post (or page) edit screen in admin, the AJAX autosuggest will suggest tags that have already been added to the post (i.e. shown below the input field). Steps to reproduce: 1. Go to the post edit screen. 2. Add a tag (example: ""Apple"") to the current post. 3. Type ""App"" in the tag entry field and wait for autosuggest to come up. 4. ""Apple"" is listed in the suggestions dropdown. I've investigated this a little, and I don't think there's a really easy patch for this (mostly because of how suggest.js works). However, it would imho be very elegant to fix this. Perhaps autocomplete.js can be of service here (see issue #12399)?" roytanck 21256 New theme feature - add_theme_support( 'content-width', $defaults ) Themes 3.4.1 normal normal Awaiting Review feature request new dev-feedback 2012-07-13T10:08:34Z 2013-05-15T15:49:42Z "Themes use '''$content_width''' variable to set the content area width, they use: {{{ if ( ! isset( $content_width ) ) $content_width = 500; }}} This method has two flaws, it's not flexible and it does not support different sizes for different post-types. WordPress has to make the content-width to be a builtin theme feature using '''add_theme_support()''', and make it more flexible and easy to update. I want to update this value using the Theme Customizer rather editing the function.php file. The code needs to be easy to set and to support CPT, some thing like this: {{{ $defaults = array( 'post' => '500', 'page' => '500', 'attachment' => '650', 'artist' => '300', 'movie' => '400' ); add_theme_support( 'content-width', $defaults ); }}} Just an idea for 3.5." ramiy 21253 Replaces deprecated get_delete_post_link in class-wp-posts-list-table.php Post Types 3.1 normal normal Awaiting Review enhancement new has-patch 2012-07-13T04:41:31Z 2012-07-13T04:41:31Z Changing the ajax nonce actions from post-post_type_ to post_ in #21194 allows us to change deprecated get_delete_post_link() to wp_nonce_url() in class-wp-posts-list-table.php. Patch requires #21194 to work on custom post types. c3mdigital 21249 WP_List_Table::single_row_columns() needs to do an exact comparison Administration lowest trivial Future Release defect (bug) new has-patch 2012-07-13T01:20:28Z 2012-11-07T22:05:29Z "If for whatever reason you pass a column ID of `0` when dealing with a list table, !WordPress thinks it's a checkbox column because of the loose comparison, i.e. `==` instead of `===`. Since I don't see why passing a number instead of a string shouldn'r be allowed, attached is a patch." Viper007Bond 21243 move password hint text to a function General normal normal Awaiting Review enhancement new has-patch 2012-07-12T16:56:24Z 2012-07-16T02:52:21Z "The password hint text, noted below, is hard coded in four places: {{{ wp-admin/install.php wp-admin/user-edit.php wp-admin/user-new.php wp-login.php }}} {{{ Hint: The password should be at least seven characters long. To make it stronger, use upper and lower case letters, numbers and symbols like ! "" ? $ % ^ & ). }}} This approach is prone to mistakes when changes are made. In addition, plugins that want to override the text need to use the resource intensive and clumsy gettext filter. Per nacin and westi, the attached patch moves the text to a function ({{{wp_password_hint()}}}) in {{{wp-includes/user.php}}} and adds a filter ({{{password_hint}}})." convissor 21237 "Terminology for ""Front"" and ""Home""" General normal normal Awaiting Review defect (bug) new 2012-07-12T13:59:40Z 2012-08-17T19:25:29Z "The following related tickets all have discussions concerning the Terminology for ""Front Page"" and ""Home Page"" is some way. #16379 - Better UI for doing ""Page on Front"" [[BR]] (UI effected by the terminology) #10158 - Deprecate is_home() and is_single(), in favor of is_blog() and is_post() [[BR]] (Conditional Tags effected by the terminology) #18705 - home_url() and is_home() with a static front page [[BR]] (URL function effected by the terminology) Additionally, Template files are effected by the terminology (home.php and front-page.php) This ticket is intended to discuss the best options that address the above terminology concerns for the sake of consistency and usability. If a determination is made here, hopefully we can use the terminology to inform the above tickets." WraithKenny 21236 Network Admin broken link http// not http:// typo if siteadmin changes siteurl of subsite Network Admin 3.4.1 normal minor Awaiting Review defect (bug) new reporter-feedback 2012-07-12T13:03:36Z 2012-09-17T13:16:09Z "Given: * a multisite install at example.org configured for sub-domains * a subsite called ""foo"" at foo.example.org * a domain mapping foo.com -> foo.example.org * www.foo.com set as PRIMARY domain for that blog and... the siteadmin changes the siteurl for that blog via Network Admin > Settings > Site then ... when the siteadmin visits foo.com/wp-admin the the menu link for Network admin is broken. It's expected that the link looks like {{{ example.org/wp-admin/network/ }}} but instead it is changed to {{{ http//example.org/wp-admin/network/ }}} Clicking on the link resolves to a 404 page. This maybe trivial but changing the siteurl for mapped domains / subsites is important if you need to integrate with 3rd party API like google checkout which expect qualified valid full domain. I've noticed on the multisite forums that a few other users have complained about the network admin link being broken. If you need screenshots please let me know " damiensaunders 21234 Recursive directory creation & get_calendar() for custom post types General 3.4.1 normal normal Awaiting Review defect (bug) new 2012-07-12T12:31:28Z 2012-07-13T00:28:43Z "Hello! I made two patches, and sent the pull request on githab. https://github.com/WordPress/WordPress/pull/12 https://github.com/WordPress/WordPress/pull/14 And I want to join to contributers team. How can I do it? Irc chanel is Terminated :(" avaddon 21225 Dashboard Incoming Links - Google blogsearch fails when get_option( 'home') is not a TLD Feeds 2.5 normal minor Awaiting Review defect (bug) new dev-feedback 2012-07-12T02:47:09Z 2012-07-12T04:23:56Z "When WordPress gets installed and the first time a user visits the dashboard the dashboard_widget_options get set for dashboard_incoming_links. The Google blogsearch link gets set based on your settings for wp_home. If your developing on a local machine most likely wp_home is not a true TLD. Google blogsearch incorrectly returns incoming links when the site: url is not a true TLD. For example I'll use an install where wp_home is set to http://wp.patch. The link that gets formed is: http://blogsearch.google.com/blogsearch_feeds?scoring=d&ie=utf-8&num=10&output=rss&partner=wordpress&q=link:http://wp.patch/ If you visit that link you will notice that results are getting returned just using the ""patch"" keyword. If the sited gets moved to live production you will continue to get the incorrect incoming links unless the dashboard_widget_options get manually changed or deleted. Also to note is that the Google blogsearch API has been deprecated: https://developers.google.com/blog-search/ My suggestion is to remove the widget or hide it by default in screen options like we did for some of the stuff in post.php. Another option is to do a check and return WP_Error if wp_home is not a TLD before setting the dashboard widget options." c3mdigital 21221 Image title and alt attribute content should be texturized. Media 3.4.1 normal normal Awaiting Review enhancement new has-patch 2012-07-11T19:49:18Z 2012-07-11T22:11:44Z " gallery_shortcode() texturizes the caption shown underneath images in galleries. For consistency, alt and title tags content should also be texturized. This is also valuable for developers extending the gallery shortcode or output, such as with the WordPress.com (and Jetpack) [http://en.blog.wordpress.com/2011/11/08/new-photo-carousel/ Gallery Carousel feature], as it provides i18n'd texturization, for EG. See attached patch, which: * uses wptexturize() in wp_get_attachment_image() directly (/wp-includes/media.php), which makes it work with gallries, attachment pages, etc. * also uses wptexturize() in get_image_tag() (/wp-includes/media.php), for consistency. * uses wptexturize() in wp_get_attachment_link() (/wp-includespost-template.php), for consistency" stephdau 21219 get_post_type_archive_link in multisite context: struct issue Post Types normal normal Awaiting Review defect (bug) new 2012-07-11T17:48:27Z 2012-09-03T12:11:03Z "Context : multisite and a site aaa ( http://localhost/wpmu_svn_34/aaa/ ) trying to display the '''post_type_archive_link''' of cpt 'book' of the blog bbb {{{ switch_to_blog( $b ); $link = get_post_type_archive_link( 'book' ) ; /*/ http://localhost/wpmu_svn_34/bbb/book/ and not http://localhost/wpmu_svn_34/bbb/livre/ */ restore_current_blog(); }}} when name, slug and query_var of the post_type are the same: no problem because $struct to find the '/book/' is kept from the caller site BUT if in the called site, the CPT have the same type name ('book') but with different slug and query_var, the home_url is correctly changed but the $struct is not good... 'book' instead 'livre' as declared in cpt in site bob. The issue came from global $wp_rewrite; which is not this of the target after the switch_to_blog ! Instead of a non elegant filter ''post_type_archive_link'', is there a way to ""find"" the $wp_rewrite of $b ? Best regards ! " michelwppi 21212 MySQL tables should use utf8mb4 character set Database 3.4.1 normal minor Awaiting Review enhancement reopened 2012-07-11T04:26:12Z 2012-10-09T06:56:41Z "Historically, the MySQL utf8 character set has only supported the first character plane of UTF-8. With MySQL 5.5.3, it now supports the entire character plane, using the utf8mb4 character set. This character set is 100% backwards compatible, and does not require more space than utf8 for characters that fall within the utf8 set, only using an extra byte for characters outside of the utf8 set. References: http://en.wikipedia.org/wiki/Mapping_of_Unicode_character_planes [[BR]] http://dev.mysql.com/doc/refman/5.5/en/charset-unicode-utf8mb4.html" pento 21211 Alter how settings_errors are output in options.php Administration 3.4.1 normal normal Awaiting Review defect (bug) new dev-feedback 2012-07-10T23:44:37Z 2012-12-10T18:43:09Z "The `*_settings_error(s)` and `settings_error` functions are used mainly as part of the Settings API, but with the way that options.php currently handles the settings errors, it assumes that people will use this functionality exclusively with the Settings API. Notice options.php, starting at line 153: {{{ /** * Handle settings errors and return to options page */ // If no settings errors were registered add a general 'updated' message. if ( !count( get_settings_errors() ) ) add_settings_error('general', 'settings_updated', __('Settings saved.'), 'updated'); set_transient('settings_errors', get_settings_errors(), 30); }}} This simply assumes that no other outside source has registered any sort of setting error other than the current options page. TwentyEleven does this, and so if any other source has registered any notices via these functions, the ""Settings saved."" message will not be output because the first bit of logic will fail. I don't think this assumption can (nor should) be warranted, so there needs to be another way to handle this so that themes like TwentyEleven who only call `settings_errors` at the top of their options page don't get unknowingly hijacked by other sources. I always suggest registering your own errors at the end of the sanitization callback for your setting, and then output those specific errors within settings_errors to avoid any internal conflicts like this. Just looking for some ways to approach this. :-) " griffinjt 21207 Link-template pagination link for page 1 missing query string args Template 3.4 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-07-09T20:28:25Z 2012-07-16T14:38:37Z "In paginated pages, when on a page that is greater than page 1, the link for page 1 and the 'previousposts' link do not include any query arguments. This is fine if not including the first page argument, but not for other arguments in the query string. For example pages that show results for form searches. The search criteria are stored with the GET method as query strings in the URL and need to be maintained from page to page as the user pages through their results. This is in /wp-includes/link-template.php on line 1421. A probable fix is the 'if' clause from if( $pagenum > 1 ) changed to if( $pagenum > 0 ). I was wondering if you can apply this fix to future updates? Thanks" alexk45 21204 Encoding problem with errors and warnings General 3.4.1 normal normal Awaiting Review defect (bug) new 2012-07-09T16:31:04Z 2012-07-09T22:01:05Z "There are several functions for debugging and their messages are also localized. For example _deprecated_argument(), _doing_it_wrong(), etc. But when these functions are fired, encoding of the whole administration (not only error messages) is damaged (see attached screenshot). It is not very good because even if debugging is turned off, some errors can be still triggered - for example trigger_error() in ms_subdomain_constants() function, etc." pavelevap 21200 get_all_category_ids() only used by a deprecated function Taxonomy 3.4.1 normal minor Awaiting Review defect (bug) new 2012-07-09T11:35:01Z 2012-09-08T21:02:55Z "The function ""get_all_category_ids()"" (category.php) is only used by the deprecated function ""get_category_children"". I got two ideas for the future of the function: a) also deprecate it b) create a function ""get_all_taxonomy_ids($taxonomy)"". Since it seems to be a common problem for programmers to get e.g. all tag ids I would prefer this. " Latz 21195 get_avatar_url General 2.5 normal normal Awaiting Review feature request new has-patch 2012-07-08T18:51:40Z 2013-03-13T00:01:16Z "There should be a separate function to just get an avatar URL, versus getting the image wrapped in an tag. This function should pass the avatar URL through a filter before returning it. '''get_avatar''' would then call this function, rather than generating a Gravatar URL on its own. This way, a plugin can grab a user's avatar image without relying on regex to extract the image from the tag, and in a way that is compatible with plugins that replace Gravatar." pathawks 21190 Add a action in check_admin_referer() in the event the nonce auth fails Administration normal normal Awaiting Review enhancement new dev-feedback 2012-07-08T09:12:56Z 2012-07-08T09:12:56Z "Currently plugins don't have a way to perform custom handling in the event that a nonce fails in `check_admin_referer()` - Whilst in most cases this will never be needed, I'd like the ability for plugins to be able to use `check_admin_referer()` directly AND have the option of redirecting failed nonces to their own page. We currently have an action which is fired when a nonce passes: {{{ do_action('check_admin_referer', $action, $result); }}}" dd32 21189 We should improve the nonce failure page Administration normal normal Awaiting Review enhancement new 2012-07-08T09:07:17Z 2012-07-08T13:14:00Z "Currently when a admin nonce expires, in most cases we catch this condition using `check_admin_referer()` which presents expired nonces with a rather ugly uninformative error message: [[Image(http://f.cl.ly/items/26271g453h2y0K393Y1l/Screen%20Shot%202012-07-06%20at%2012.14.25%20PM.png)]] I'd like to propose that we make this page a bit nicer to end users - who although are unlikely to hit it (I hope) it'd be nice to let them know what's actually happened. My initial approach would be to change the page to - Include a !WordPress logo, and a link back to the Admin area - Change the message to something like ""The link you've followed has now expired, In order to complete the action you were performing, please return to the previous page, refresh it, and attempt to follow the link again."". - In the case where this is happening within the !WordPress admin, it would make sense to have some kind of UI on the page as well - This can currently be done by not using `check_admin_referer()` and using `wp_verify_nonce()` directly and redirecting to an error page. The current message could often cause confusion, as of course the user wants to do it (They just followed a link!) but as there's no continue button, they're left confused." dd32 21188 Fullscreen (distraction-free) editor should have a preview button Editor normal normal Awaiting Review feature request new 2012-07-08T08:36:00Z 2013-01-08T14:01:54Z "Per http://alexking.org/blog/2012/07/06/wordpress-fullscreen-preview-button I do find it annoying to have to exit fullscreen, preview, then flip back to fullscreen." markjaquith 21185 Upload/insert popup not scrollable on iPad General normal normal Awaiting Review defect (bug) new 2012-07-07T20:58:36Z 2012-07-07T20:58:36Z "When using iPad (testing with a v1 iPad) the upload/insert popup is not scrollable so if you expand an image by clicking ""show"" you cannot scroll down to the"" insert into post"" link." husobj 21182 WP_HTTP_Cookie doesn't handle the default conditions for the 'domain' and 'path' field correctly. HTTP low minor Awaiting Review defect (bug) new 2012-07-07T04:34:45Z 2012-07-07T04:34:45Z "WP_HTTP_Cookie currently handles ""simple"" cookies in exactly the same way they're received, that is, it only fills in the details that the set-cookie header contained. However, some fields are optional, and as a result of this, the [http://www.ietf.org/rfc/rfc2109.txt rfc for state management] specifies a set of default values for certain fields: {{{ 4.3.1 Interpreting Set-Cookie The user agent keeps separate track of state information that arrives via Set-Cookie response headers from each origin server (as distinguished by name or IP address and port). The user agent applies these defaults for optional attributes that are missing: VersionDefaults to ""old cookie"" behavior as originally specified by Netscape. See the HISTORICAL section. Domain Defaults to the request-host. (Note that there is no dot at the beginning of request-host.) Max-AgeThe default behavior is to discard the cookie when the user agent exits. Path Defaults to the path of the request URL that generated the Set-Cookie response, up to, but not including, the right-most /. Secure If absent, the user agent may send the cookie over an insecure channel. }}} We currently don't do anything special for Secure cookies (From what I can see), but we also need to handle the 'domain' and 'path' field defaults better, as currently they remain at the default null if nothing is passed. This can result in domains passing the WP_HTTP_Cookie::test() method to a different domain or path than they were issued on. Example cookie values (and WP_HTTP_Cookie representations) which can trigger this: {{{ PHPSESSID=ros1liponkqip23k9le0hhmp31; path=/' (length=44) test=1341632838; expires=Sat, 07-Jul-2012 04:47:18 GMT array (size=2) 0 => object(WP_Http_Cookie)[87] public 'name' => string 'PHPSESSID' (length=9) public 'value' => string 'ros1liponkqip23k9le0hhmp31' (length=26) public 'expires' => null public 'path' => string '/' (length=1) public 'domain' => null 1 => object(WP_Http_Cookie)[86] public 'name' => string 'test' (length=4) public 'value' => string '1341632838' (length=10) public 'expires' => int 1341636438 public 'path' => null public 'domain' => null }}} This is not a issue for WordPress core, but could affect plugins who do anything special with Cookies." dd32 21172 Adding the first filter/action in an earlier priority during a later priority causes the earlier priority to run (last) Plugins 3.4 normal normal Awaiting Review defect (bug) new has-patch 2012-07-05T23:30:54Z 2012-07-07T22:41:11Z "During testing of #21169, it occurred to me that [http://core.trac.wordpress.org/ticket/5338#comment:1] might present a problem with each rather than next/current, but that turns out not to be the case. Instead, this exposed a different bug: If you add a new filter at priority 9, when priority 9 did not previously have any filters, during the priority 10 execution, the priority 9 filter will run (!) after all other priorities (since the filters are not resorted after each priority). (Generally, if you add an earlier priority that did not previously have any filters during a later priority...) The attached unit test demonstrates this behavior." devesine 21171 jQuery Events for Metaboxes General normal minor Awaiting Review feature request new 2012-07-05T21:35:47Z 2012-07-06T01:14:52Z "Currently, when a plugin adds a metabox with complex objects (like TinyMCE, Maps, CodeMirror etc) care must be taken to refresh the objects when the elements are moved (including hidden/shown). After some digging, I've found that this seems to works in most cases: {{{ var context = ""#custom_meta_box_id""; $( '#adv-settings' ).on( 'click', context + '-hide, ', refresh ); $( context ).on( 'click', '.hndle, .handlediv', refresh ); $('.meta-box-sortables').bind( ""sortstop"", refresh ); }}} which isn't terrible, but seems fragile if core changes in the future, and there should just be a better way :-) Two ideas from dev chat are triggering custom events or the (coming soon) ""js actions"" which would be more robust (like php actions)." WraithKenny 21170 JavaScript actions and filters koopersmith General 3.4 normal normal Future Release feature request new dev-feedback 2012-07-05T21:34:03Z 2013-05-13T23:16:51Z "The concept of adding JavaScript actions and filters has been tossed around for some time. We've experimented with various configurations of actions in both the fullscreen and customizer APIs, and they've proven their utility enough to graduate them to a core feature in their own right. ---- I think that a good events API should satisfy these parameters: 1. '''Support jQuery-style dot namespacing''' to allow functions to be easily removed. 2. '''Should (likely) support priorities.''' While seemingly random numbers aren't fun to use, it allows plugins to cooperate without having to know of each other's existence. We can't expect plugin authors to rearrange the array of callbacks. 3. '''Should ''not'' force functions to have unique IDs.''' Anonymous functions are extremely common in JavaScript — forcing them to be named is contrary to the nature of the language. 4. '''Should be structured as a mixin.''' The global event loop should be an instance of the core Events object. Using a mixin will allow developers to easily create event loops for their own plugins (to prevent polluting the global namespace — think about large plugins, like bbPress). An events mixin will also enable developers to create more powerful abstractions, such as observable values, collections, and pretty much any structural JS object you can dream up. 5. '''Should allow the looping process to be overwritten.''' This will result in less code and added flexibility. The only difference between actions and filters is how they handle the callbacks object. There are other types of looping processes that could be beneficial in JS. One example would be returning false if any callback returns false, which could be used to stop a process, much like the native event.stopPropagation method. ---- '''Why not use custom jQuery events?''' Custom jQuery events are great when we need to trigger actions on a DOM element. Triggering plain events on the body element (or any other hidden element) is not performant — every jQuery event normalizes an DOM Event object, which we then completely ignore. '''Should we require jQuery to use the API?''' I'm not sure. jQuery.Callbacks may be a helpful solution here, provided we can properly integrate priorities and namespacing. jQuery.Callbacks also only requires jQuery.each and jQuery.extend, so writing a shim that doesn't use the rest of jQuery would not be exceptionally difficult. Either way, switching between one and the other as we develop should not be exceptionally difficult." koopersmith 21169 remove_action on a tag within do_action for that tag can cause actions to be missed Plugins normal major Future Release defect (bug) new has-patch 2012-07-05T21:08:22Z 2012-11-07T15:35:21Z "'''Problem:''' If an action (or filter) in a given priority for a given tag removes itself as part of its execution, and it was the only action/filter at that priority for that tag (or only one remaining), the next priority level is skipped. '''Reproduction:''' See the attached unit test. '''Analysis:''' This appears to possibly be a bug (or at least an undocumented feature) of PHP (tested up to 5.4.3), where next() falls over if the current array element is unset (but each() has no problem even if the /next/ array element is unset). Example non-WP code demonstrating this is included. '''Proposed solution / workaround:''' Switch all uses of next() in plugin.php to use each() instead; I've included a proposed patch. Props to smathiascrowdfavorite for bringing this bug to my attention." devesine 21168 Add ability to remove a parent theme's page templates General normal normal Awaiting Review enhancement new 2012-07-05T19:32:31Z 2012-08-05T23:54:15Z "When building a website using a child theme, I'll often want to remove page templates that the parent theme provides but aren't useful/relevant to the specific site I'm building. You can create a page template with the same name to override the parent theme's, but you can't simply remove it. This could be a use case of #13265, or we could add function that leverages #13265" billerickson 21167 Problem with custom permalinks Permalinks 3.4 normal normal Future Release enhancement reopened 2012-07-05T17:52:21Z 2012-11-06T19:46:50Z "I am currently moving my blog (http://kaffeeringe.de/) to Wordpress and I don't want to break my old URLs (Cool URLs don't change). The problem is, that these custom URLs don't work in Wordpress 3.4.1: /blog/%postname%/%post_id%.html works /blog/%postname%.%post_id%.html (which I need) doesn't work. It doesn't work with the . in between these parameters… I hope somebody is able to help me. " kaffeeringe 21165 Make categories widget work with custom taxonomies Widgets normal normal Future Release enhancement new has-patch 2012-07-05T14:15:13Z 2013-05-02T14:17:27Z "The tag cloud widget already has a taxonomy dropdown. We should add one for the categories widget as well." scribu 21164 wp_customize_support_script support for XHTML themes Validation 3.4 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-07-05T13:31:15Z 2012-11-07T08:53:41Z The script just needs wrapping in a CDATA section for XHTML themes. needle 21163 Blogger Importer Invalid Tokens Import normal normal WordPress.org defect (bug) new 2012-07-05T11:53:00Z 2012-10-13T19:30:04Z "When the users clicks on the authorise button google responds with an invalid token error. This is obviously a bit puzzling for the users. See http://wordpress.org/support/topic/plugin-blogger-importer-invalid-token The problem seems to be that the form with the authorise button is actually passing blank tokens. I can't reproduce the problem but I've reproduced their symptoms by switching the URL in get_oauth_link to a non existant one. This returns blank tokens to the form. If you then submit that form you get the invalid token error. Although this following patch is not actually a fix, we can report the error properly with a change to get_oauth_link and greet and hence it will be easier to diagnose issues. {{{ // Shows the welcome screen and the magic auth link. function greet() { $next_url = get_option('siteurl') . '/wp-admin/index.php?import=blogger&noheader=true'; $auth_url = $this->get_oauth_link(); $title = __('Import Blogger', 'blogger-importer'); $welcome = __('Howdy! This importer allows you to import posts and comments from your Blogger account into your WordPress site.', 'blogger-importer'); $prereqs = __('To use this importer, you must have a Google account and an upgraded (New, was Beta) blog hosted on blogspot.com or a custom domain (not FTP).', 'blogger-importer'); $stepone = __('The first thing you need to do is tell Blogger to let WordPress access your account. You will be sent back here after providing authorization.', 'blogger-importer'); $auth = esc_attr__('Authorize', 'blogger-importer'); $errormsg = __('Error occurred getting OAuth tokens from Google', 'blogger-importer') echo "" "" . screen_icon() . "" $title $welcome $prereqs $stepone""; if (!is_wp_error($auth_url)) { echo "" \n""; } else { echo $errormsg; echo ' '.$auth_url->get_error_message().' ' ; } } function get_oauth_link() { // Establish an Blogger_OAuth consumer $base_url = get_option('siteurl') . '/wp-admin'; $request_token_endpoint = 'https://www.google.com/accounts/OAuthGetRequestToken'; $authorize_endpoint = 'https://www.google.com/accounts/OAuthAuthorizeToken'; $test_consumer = new Blogger_OAuthConsumer('anonymous', 'anonymous', null); // anonymous is a google thing to allow non-registered apps to work //prepare to get request token $sig_method = new Blogger_OAuthSignatureMethod_HMAC_SHA1(); $parsed = parse_url($request_token_endpoint); $params = array('callback' => $base_url, 'scope' => 'http://www.blogger.com/feeds/', 'xoauth_displayname' => 'WordPress'); $req_req = Blogger_OAuthRequest::from_consumer_and_token($test_consumer, null, ""GET"", $request_token_endpoint, $params); $req_req->sign_request($sig_method, $test_consumer, null); // go get the request tokens from Google $req_response = wp_remote_get($req_req->to_url(), array('sslverify' => false)); if (is_wp_error($req_response)) { return $req_response; } $req_token = wp_remote_retrieve_body($req_response); // parse the tokens parse_str($req_token, $tokens); $oauth_token = $tokens['oauth_token']; $oauth_token_secret = $tokens['oauth_token_secret']; $callback_url = ""$base_url/index.php?import=blogger&noheader=true&token=$oauth_token&token_secret=$oauth_token_secret""; return array('url' => $authorize_endpoint, 'oauth_token' => $oauth_token, 'oauth_callback' => $callback_url); } }}} p.s. Sorry I've still not mastered DIFF!" Workshopshed 21158 different result when shortcode atribute without value Shortcodes 3.4 normal normal Awaiting Review defect (bug) new 2012-07-04T19:11:44Z 2012-07-04T19:11:44Z "imagine those two shortcodes {{{ [shortcode attribute] [shortcode attribute=value] }}} IMO they should have the same result, just the second should have some value to the attribute and the first should have NULL or false But if you do {{{ add_shortcode( 'shortcode', 'my_shortcode' ); function my_shortcode( $atts ) { print_r ($atts); } }}} the first shortcode results in {{{ array ( 0 => 'attribute', ) }}} while the second in {{{ array ( 'attribute' => 'value', ) }}} I'm not sure, maybe it is intentional, i have not found any description, what should shortcode attribute without value do. But imo it should work as i have described as it is the only way how it could clear some predefined value (the only other way is to set it to empty string, which may not always be the same as NULL or FALSE)." thomask 21157 disapearing class=anything when ctrl+c & ctrl+v in tinymce editor TinyMCE 3.4 normal normal Future Release defect (bug) new 2012-07-04T18:46:12Z 2012-12-16T22:25:03Z "type {{{ Lorem class=anything Ipsum }}} anywhere. Copy the text and paste it to the WP's WYSIWYG editor. The result is just {{{ Lorem Ipsum }}} I have tried it with tinymce demo on their site and it works normaly, so it seems that only wp editor is affected. The same wrong result is with class=""anything"", when using spaces around equal symbol (class = anything), it works normaly. Seems like some poorly written attemp to remove classes from pasted text (it does not affect id or other tag parameters i have tested) P.S.: i am using Chrome if it makes some diference" thomask 21156 Move utility functions out of wp-admin/network.php Multisite normal normal Awaiting Review enhancement new dev-feedback 2012-07-04T17:15:03Z 2012-07-04T17:15:03Z "There are several functions in wp-admin/network.php that would come in handy outside the WP Admin -> Network Setup screen: * network_domain_check() * allow_subdirectory_install() * get_clean_basedomain() etc. They could be moved to wp-admin/includes/ms.php" scribu 21153 supporting protocol-relative urls General 3.3.2 normal normal Awaiting Review enhancement new 2012-07-04T10:04:09Z 2012-07-04T11:04:29Z "changing http:// and https:// generated links to // links would easily add support for hosting a site both under http and https easily one place I've found this to be changed is in wp-includes/link-template.php around line 2006 the first if could be changed to: $url = str_replace( ""https://"", ""//"", $url) $url = str_replace( ""http://"", ""//"", $url)" nagyv 21143 Add a hook for when no blog is found (in addition to NOBLOGREDIRECT) Multisite normal normal Future Release enhancement new has-patch 2012-07-03T01:20:45Z 2012-11-07T22:18:40Z "(Related to #21142) '''Background''' On a multisite install, we allow users to change their subdomain name (or domain name). We keep a list of their previously used subdomains/domains, and if there is a HTTP request for one of their old domains, we automatically perform a 301 redirect to the new domain name. '''Problem''' In order to perform a 301 redirect from and old domain to the new domain, we currently have to use wp-content/sunrise.php. However we would like to take advantage of the logic at the top of wp-includes/ms-settings.php, rather than re-inventing that logic in our sunrise.php file. The NOBLOGREDIRECT constant can be used for this, but it does not allow us to perform a 301 redirect. '''Solution''' Adding a simple hook to ms-settings.php would allow a sunrise.php file to determine what should happen if a HTTP request on a Multisite install does not correspond to one of the existing sites/blogs. See attached patch." jamescollins 21140 """Display name publicly as"" setting not set until a change is made in the setting" nickharambee Users 3.4 normal normal Awaiting Review defect (bug) new has-patch 2012-07-02T21:29:48Z 2012-07-02T22:37:46Z "I have found this issue with several users that I have set up on my site. The default value for ""Display name publicly as"" is the first name of the user when creating a new user, or at least that is what shows in the ""Display name publicly as"" drop-down menu. However, when creating a new user, the full name, i.e. the first and last name is what displays publicly. In order to get only the first name to display publicly I need to set the ""Display name publicly as"" option to another option, save changes, and then reset it to just the first name, and save changes again. Surely, if it is the first name that shows in the drop-down menu, it should be the first name that actually displays publicly, without having to go through this rather strange process? I am using the latest version of Buddypress (1.5.6) as well as several other plugins. I have not tried disabling all of these." nickharambee 21139 Month format in Publish box I18N 3.4 normal normal Awaiting Review defect (bug) new 2012-07-02T18:47:26Z 2012-07-02T20:03:24Z "New translatable month format was introduced in r19820. Problems: 1) Month numbers are not localized. Czech does not use numbers with format 01, 02, etc. I can remove month numbers by ""not translating"" them, but it is not the best solution. 2) How should be strings ""May_May_abbreviation"" translated in the right way? I found that some languages uses for example ""Kvě_Květen_abbreviation"" translation and others only ""Kvě"". Translators are probably afraid of removing ""_May_abbreviation"" part because they do not want to broke anything even if there is preg_replace function following. I do not understand why there has to be the whole ""May_May_abbreviation"" original string? Also explanation for translators (three-letter abbreviation of the month) is not exact, because we can use 2 (better for Czech) or any other number of characters." pavelevap 21134 Registering and enqueueing on the same action can cause enqueueing to happen before registering General 3.4 normal normal Awaiting Review defect (bug) new 2012-07-02T11:00:17Z 2012-07-03T01:42:10Z "We have two plugins, plugin1 and plugin2. Plugin1 registers a script, Plugin2 wants to enqueue this script. Both of these routines are executed on the [http://wpdevel.wordpress.com/2011/12/12/use-wp_enqueue_scripts-not-wp_print_styles-to-enqueue-scripts-and-styles-for-the-frontend/ _enqueue_scripts] action. There is a chance that enqueueing in Plugin2 will happen before registering in Plugin1 and therefore fail. Possible fixes: * Every time we enqueue a script, registered in another plugin, we use a higher priority. I am not a fan of this approach, because it is opaque – we need to document each enqueue like this, because the next developer might not know why did we use higher priority. * Every time we register a script, we use a lower priority. I am not a fan of this either, because we will have to do this for almost every register, because we can't know if another plugin won't try to enqueue our scripts. * Violate core recommendation and register the script on an earlier hook. I am not a fan of approach for obvious reasons. * Add {{{_register_scripts}}} hooks and recommend plugin authors to register their scripts at this time. I would prefer if we added another set of hooks, because it both makes sense to register on a register hook (as opposed to enqueue hook) and it separates the two actions, so that we can execute them at different times. When we agree on a solution, I would be happy to write the patch. " nbachiyski 21132 "List tables' ""select all"" should let you really select all, regardless of screen options" Administration normal normal Awaiting Review enhancement new 2012-07-02T04:38:38Z 2012-07-05T15:13:48Z "The select all checkbox in list tables selects all the items in your current view. Usually what I really want is to select all the items on all the pages. As a hack, I'll often leave the screen options setting for items per page on something really high, like 1,000. Unfortunately this means the tables are often really slow for no benefit (most of the time I don't need them all). A better solution would be a way to intelligently select all items without needing to show them on the page. The best example of this that I know of is Gmail, which adds a line above the list of emails when you click the select all box that looks something like this: ""All 50 conversations on this page are selected. Select all 653 conversations in Spam"". The second sentence is a link that, as expected, selects all of your emails that fit the current view, regardless of paging. Screenshot attached." evansolomon 21128 Sort Users by Sites Users 3.4 normal major Awaiting Review feature request new 2012-07-01T18:10:12Z 2012-07-01T18:57:16Z In wp-admin/network/users.php please add the option to sort users by site name. jsaf 21126 "Different ID on ""Set featured image"" link if there is already an image set" General 3.4 normal normal Awaiting Review enhancement new has-patch 2012-06-30T22:02:55Z 2012-06-30T22:02:55Z "I ran into a situation where I wanted to target the ""Set featured image"" link text in the featured image metabox. The ""Set featured image"" link displays and has an id of ""set-post-thumbnail"". When you set the thumbnail, the link still has an ID of ""set-post-thumbnail"" though now it is wrapping around the thumbnail image rather than the ""Set featured image"" text. Then a second link is added to remove the featured image with the id of ""remove-post-thumbnail"". In my situation I wanted to target the ""Set featured image"" link (with the text) and the ""Remove featured image"" link separately, but this was tricker than it needed to be because the ""Set featured link"" keeps the same id of set-post-thumbnail when it is wrapped around the thumbnail image. Beyond my specific issue, I think it could be argued that this link deserves a specific id, since the action the link is performing is modifying the featured image more than it is setting it. So I've included a patch here that will modify the $set_thumbnail_link variable when the $thumbnail_id is present and change the link's id to modify-post-thumbnail. I'm not sure if it's the most elegant/clever way to achieve what I'm after, but I know it gets the job done." ryanimel 21119 Make WP_User_Query::prepare_query() public General normal normal Awaiting Review enhancement new has-patch 2012-06-30T07:57:47Z 2012-06-30T07:59:30Z "WP_User_Query tries to follow the pattern from WP_Query, where if you don't pass any args, it won't run the query. The problem is that you can't do anything with that instance afterwards; both prepare_query() and query() accept no parameters." scribu 21113 Previous/Next page links maintain all GET variables General 3.4 normal normal Awaiting Review enhancement new close 2012-06-29T14:57:00Z 2013-04-05T12:49:45Z "The newer/older entries pagination system takes any query string in a inbound request, and includes it in the links generated for the newer/older entries. This causes problems when you put wordpress behind a cache, because all it takes is some bot trying a joomla hack to mean all visitors suddenly have a version of that page, including the bad query string, very visible. For example: http://kirrus.co.uk/page/6/?test=true Note, in the 'Newer/Older' links at the bottom of the page, that ""test=true"" will be retained. These should only really keep query-strings that wordpress knows it'll need, if you're including them? Else, you can basically poison someone's cache with this. An example of the really bad query string poisoning a cache: /page/2/?option=com_gk3_tabs_manager&controller=..%2F..%2F..%2F..%2F..%2F..%2F..%2F..%2F..%2F..%2F..%2F..%2F..%2F..%2F..%2F..%2F..%2F..%2F..%2F..%2F..%2F..%2F..%2F..%2Fproc%2Fself%2Fenviron%0000" kirrus 21112 Add pre_wp_unique_post_slug to override post slug handling Permalinks 3.4 normal normal Awaiting Review enhancement new has-patch 2012-06-29T14:38:32Z 2012-11-08T02:00:49Z "As originally [http://core.trac.wordpress.org/ticket/20480#comment:4 proposed] in the comments of #20480 (and in fact further back in a [http://core.trac.wordpress.org/ticket/14111#comment:4 comment] for #14111), a `pre_wp_unique_post_slug` filter early in `wp_unique_post_slug()`could be useful and justified for some use cases rather than relying on the existing and late-firing `wp_unique_post_slug` filter for a couple reasons: * `wp_unique_post_slug()` (and thus this new filter) is not high use, so won't impact performance * `wp_unique_post_slug()` performs database queries (perhaps repeatedly until a unique slug is found), fires other filters, etc, all of which may be rendered moot if a hooking function's intent is to fully implement its own slug generation/handling logic. The pre slug could short-circuit that unnecessary effort. The attached patch introduces the new filter in addition to adding related phpDocs." coffee2code 21109 maybe_unserialized fails to unserialize multibyte strings (contains solution) General 3.4 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-06-29T06:09:19Z 2013-04-24T22:31:38Z "I've came across a bug trying to fetch a custom theme (http://themeforest.net/item/rebirth-the-wordpress-theme-for-churches/1167055) option (see addendum #1). The value was UTF8 value and unserialization failed. DB values were imported by the means of SQL query. I applied the following fix: instead of: {{{ function maybe_unserialize( $original ) { if ( is_serialized( $original ) ) // don't attempt to unserialize data that wasn't serialized going in return @unserialize( $original ); return $original; } }}} I had: {{{ function maybe_unserialize( $original ) { if ( is_serialized( $original ) ) { // don't attempt to unserialize data that wasn't serialized going in // fix from: http://www.php.net/manual/en/function.unserialize.php#76012 $out = preg_replace('!s:(\d+):""(.*?)"";!se', ""'s:'.strlen('$2').':\""$2\"";'"", $original ); return @unserialize( $original ); } return $original; } }}} and it worked like a charm. I also think that it may have some connection to mbstring settings in php.ini on the server. '''addendum #1''' {{{ (wp_options, option_id='rebirth' option_value='a:47:{s:18:""js_highlight_color"";s:7:""#DB2A07"";s:7:""js_logo"";s:0:"""";s:14:""js_logo_height"";s:2:""70"";s:19:""js_background_color"";s:7:""#a8a3a3"";s:19:""js_background_image"";s:64:""http://hasulam.dev/wp-content/uploads/2011/12/bg-tile-dkgray.png"";s:29:""js_background_image_alignment"";s:8:""top left"";s:26:""js_background_image_repeat"";s:6:""repeat"";s:20:""js_footer_text_style"";s:4:""dark"";s:25:""js_background_image_fixed"";s:1:""0"";s:10:""js_favicon"";s:0:"""";s:14:""js_custom_font"";s:10:""FBBeeSerif"";s:24:""js_disable_page_comments"";s:0:"""";s:24:""js_disable_post_comments"";s:0:"""";s:25:""js_disable_event_comments"";s:0:"""";s:27:""js_disable_gallery_comments"";s:0:"""";s:25:""js_disable_video_comments"";s:0:"""";s:25:""js_disable_audio_comments"";s:0:"""";s:24:""js_homepage_page_display"";s:0:"""";s:18:""js_homepage_blocks"";a:5:{s:18:""js_homepage_slider"";s:1:""0"";s:22:""js_homepage_introblock"";s:1:""0"";s:12:""widget_block"";s:1:""0"";s:18:""js_event_countdown"";s:1:""1"";s:18:""js_footer_mapblock"";s:1:""0"";}s:23:""js_homepage_block_order"";s:33:""slider,introblock,block,countdown"";s:24:""js_homepage_slider_cycle"";s:3:""yes"";s:24:""js_homepage_slider_speed"";s:4:""6000"";s:35:""js_homepage_slider_transition_speed"";s:3:""500"";s:22:""js_homepage_intro_text"";s:224:""קהילת הסולם — היא קהילה דתית עם לימוד העמוק והמדויק ביותר של חכמת הקבלה ופנימיות התורה על פי דרכו של בעל הסולם והרב""ש זצוק""ל"";s:23:""js_social_icon_facebook"";s:32:""http://www.facebook.com/hasulams"";s:22:""js_social_icon_twitter"";s:30:""https://twitter.com/#!/hasulam"";s:21:""js_social_icon_flickr"";s:42:""http://www.flickr.com/people/80922930@N07/"";s:22:""js_social_icon_youtube"";s:40:""http://www.youtube.com/user/hasulammedia"";s:20:""js_social_icon_vimeo"";s:0:"""";s:25:""js_social_icon_foursquare"";s:36:""https://foursquare.com/user/30915399"";s:14:""js_time_format"";s:3:""24h"";s:21:""js_countdown_language"";s:7:""english"";s:21:""js_contactblock_title"";s:18:""בואו לבקר!"";s:20:""js_contactblock_text"";s:295:""אנו מזמינים אתכם לבא ולבקר אותנו בבית מדרשנו ברמת גן. כאן מתפללים, לומדים שיעורי ם עם הרב ובחברותות, קורסים וסמינרים בשבת. נשמח לראותכם או לשמוע מכם דרך המשוב באתר."";s:23:""js_contactblock_address"";s:33:""128 Jabotinsky, Ramat Gan, Israel"";s:26:""js_contactblock_buttontext"";s:17:""יצירת קשר"";s:26:""js_contactblock_buttonlink"";s:15:""/about/contact/"";s:14:""js_footer_text"";s:26:""Copyright ©[year] Hasulam"";s:12:""js_gmap_zoom"";s:2:""14"";s:14:""js_hide_social"";s:1:""0"";s:22:""js_disable_breadcrumbs"";s:1:""1"";s:13:""js_audio_link"";s:1:""0"";s:13:""js_video_link"";s:1:""0"";s:18:""js_hide_contactmap"";s:1:""0"";s:21:""js_contact_form_email"";s:22:""hasulam.site@gmail.com"";s:14:""js_404_content"";s:34:""צטערת, לא מצאתי הדף"";s:19:""js_google_analytics"";s:0:"""";}') }}} " veedeezee 21107 wp_register_resource General normal normal Awaiting Review feature request new 2012-06-28T20:38:31Z 2012-06-29T09:15:34Z " Building on the concept of wp_register_script and wp_register_style I would love to see something more general for requiring resources with dependencies. Many times certain scripts require certain styles to be included and vice versa. This could also extend to other resource types as well. Let's use a basic example of some certain script creatively called Script-1. That Script-1 may have certain scripts and styles or other item on which it is dependent, let’s call them Script-1-A,Script-1-B and Style-1-A, Style-1-B. When you register the script you can of course specify other dependent scripts, but not the dependent styles, or other resource. Of course you can register the styles separately. It may seem trivial that you can then just register Script-1-A, Script-1-B and register Style-1-A, Style-1-B and then wp_enqueue_script (Script-1,array(Script-1-A, Script-1-B)) and wp_enqueue_style(Style-1-A), wp_enqueue_style(Style-1-A) separately. Now let's say you have Script-2 that depends on Script-1. When you call wp_enqueue_script(Script-2) you also have to remember to call wp_enqueue_style(Style-1-A) and wp_enqueue_style(Style-1-B). As the levels of dependency increase or if something changes it gets a lot more difficult to maintain. My example above only focused on styles and scripts but could apply to other resources such as fonts and/or images that you would like to manage using the flexibility of the WordPress queueing and actions/hooks systems. Sure you could have scripts call the styles themselves but then those styles would not be processed through wordpress and therefore might not take advantage of combining, compressing, caching systems you might have in place in addition to the ability to deregister and change certain items in child themes/skins as easily. I have a system setup to run hundreds of sites with a core theme that provides common structure, style, scripts and a host of other functionality. Then I have an array of child themes geared towards certain types of sites. Those child themes each can have an unlimited number of skins. The skins can all introduce new functionality and build on the functionalities, styles, scripts, etc of the child theme which builds upon the core theme. This is one of the many cases where being able to just call the single wp_enqueue_resource would greatly help, especially when things change. Implementation: To implement for just scripts and styles to get started you could make a new “Resources” queue in which each resource could have a list of resources and type. When you enqueue a resource it could call wp_enqueue_script and wp_enqueue_style. Now we would have to add the ability to add a placeholder or null type of item in wp_register_script and wp_register_queue. Because looking at the example I laid out above you would do something like this: Class Resource might either contain and array of generic resources or could have separate styles/scripts. There are obviously flexibility and performance implications of both methods. Here is some very rough pseudocode: {{{ wp_register_resource(‘Resource-1’, array( ‘script’=>array( ‘handle’=>‘Script-1’, ‘src’=>‘Script-1-URL’, ‘deps’=>array(’Script-1-A’,’Script-1-B’), ‘ver’=>’’) ‘style=>array( ‘handle’=>‘Style-1’, ‘src’=>‘ Style-1-URL’, ‘deps’=> array(Style-1-A’, Style -1-B’), ‘ver’=>’’, ‘media’=>’’) ) ) }}} do not call wp_register_style/ wp_register_script upon registering of the resource and wait until this resources or resource requiring this resource is enqueued. This way the style and script are not enqueued separate from the resource and therefore each other since they are dependent on each other. It would however register the resource in the resource queue. {{{ wp_enqueue_resource(‘Resource-1’) would: wp_enqueue _script(‘Resource-1’, ‘Script-1-URL’, array(’Script-1-A’,’Script-1-B’)); wp_enqueue _style(‘Resource-1’, ‘Style-1-URL’, array(Style-1-A’, Style-1-B’)); }}} 2a //wp_register_resource($handle, $resources=array(),$deps=array()) {{{ wp_register_resource(‘Resource-2’, array( ‘script’=>array( ‘handle’=>‘Script-2’, ‘src’=>‘Script-2-URL’, ‘deps’=>array(’Script-2-deps’) ‘ver’=>’’) ‘style=>array( ‘handle’=>‘Style-1’, ‘src’=>’’, ‘deps’=>array(’’)’, ‘ver’=>’’, ‘media’=>’’) ), array(‘Resource-1’) ); }}} {{{ wp_enqueue_resource(‘Resource-2’) would: wp_register_script(‘Resource-1’,’Scipt-1-URL’……) wp_register_style(‘Resource-1’,’Style-1-URL’……) wp_enqueue_script(‘Resource-2’, ‘Script-1-URL’, array(‘Resource-1’,’Script-1-A’,’Script-1-B’)) wp_enqueue_style(‘Resource-2’, ‘’, array(‘Resource-1’)) }}} `wp_deenqueue_resource(‘Resource-2’)` would take dequeue it’s scripts and dependent scripts/styles (assuming those dependent scripts and styles were not enqueued elsewhere) There are the issues to work out on whether a resource could specify multiple scripts/styles or whether it should just be zero/one of each that listed others as dependencies. Either way can work, just depends on what community thinks." gruvii 21098 Out of memory errors in XML-RPC XML-RPC 3.4 normal major Awaiting Review defect (bug) new dev-feedback 2012-06-28T13:48:53Z 2012-09-23T19:43:33Z "Since WPiOS 3.0 and WordPress 3.4 we're getting a lot of ""Out of Memory"" reports on XML-RPC. See http://ios.forums.wordpress.org/topic/couldnt-sync-posts-after-update-to-300 XML-RPC clients have no idea of the memory available, and even if they did it'd be hard to translate that to ""how many items can I request"" Some ideas: * Can we try raising the memory limit on xmlrpc.php, or at least for system.multicall? * Setting limits on the number of items returned if we can predict that they're going to need too much memory. Currently asking for the latest 100 comments can trigger an out of memory error in some hosts. * Fail more gracefully: return an XML-RPC error instead of a HTTP 500 Internal Server Error * Any hints on debugging where memory is going and if there are any leaks?" koke 21097 Reinstall Theme feature Themes normal normal Awaiting Review feature request new 2012-06-28T11:21:32Z 2012-06-28T14:18:38Z I would be interested in a feature where you can just click to reinstall a theme instead of having to deactivate it, delete it and then reinstall it. Something like with reinstalling WordPress. grapplerulrich 21096 Filter on is_front_page return value General normal normal Awaiting Review enhancement new dev-feedback 2012-06-28T10:32:03Z 2012-06-29T13:05:58Z "When you set a page (as 'placeholder' with same slug) as front page which is actually a post type archive to front page, is_front_page() will always return false on that page. The return value of the is_front_page() function is not filterable. Attached patch adds this filter in the most basic way." CoenJacobs 21091 Unable to upload media with custom permissions Media 3.4 normal normal Awaiting Review defect (bug) new close 2012-06-28T03:13:19Z 2013-03-11T10:31:24Z "on the current version of wp-admin/media-upload.php there are now several checks to ensure that the user can edit the post using current_user_can( 'edit_post', $_REQUEST['post_id'] ). it appears that there is a typo as the capability as it is written currently is 'edit_post' and it should be 'edit_posts', correct? I noticed this on a site I manage where contributors have been given the capability to upload media but are no longer able to unless media-upload.php is edited to match their built-in capability." havahula 21089 Add admin url to install notification email General 3.4 normal minor Awaiting Review enhancement new has-patch 2012-06-27T21:50:40Z 2012-06-29T23:07:34Z "I've seen a number of individuals inquiring as to the login url of their WordPress site for administration purposes. Let's give it to them by changing: Your new WordPress site has been successfully set up at: http://wordpress.url You can log in to the administrator account with the following information: Username: admin Password: The password you chose during the install. We hope you enjoy your new site. Thanks! --The WordPress Team http://wordpress.org/ to Your new WordPress site has been successfully set up at: http://wordpress.url You can log in to the administrator account with the following information: Username: admin Password: The password you chose during the install. Location: http://wordpress.url/wp-admin We hope you enjoy your new site. Thanks! --The WordPress Team http://wordpress.org/" georgestephanis 21085 Better XML-RPC media handling XML-RPC 2.3 normal normal Future Release enhancement new dev-feedback 2012-06-26T22:40:22Z 2012-10-10T16:23:23Z "In 3.4 there was a lot of improvements. For 3.5 I would like to see some major improvement in wp.uploadFile and metaWeblog.newMediaObject. At this moment you can't insert a description, alternate text or caption. ( #5461/#18684 ). Also the file can't be attached to a post ( #13917 ). The overwrite functionality also doesn't work ( #17604 ). Not sure why this exists since WordPress itself doesn't do this. Also the current way isn't how WordPress does it internally. wp_handle_upload() doesn't get used (#6559). There is also going on something wrong with mime types ( #12518 ). Also the work from 3.4 should be implemented ( #6430 ). Last thing is that WordPress normally also looks at the EXIF information. At this moment the XML-RPC also doesn't do that ( #18087 ) rarely related: #12493 - filter for wp_upload_bits" markoheijnen 21083 JS-based feature detection we can use server-side Upload normal normal Future Release enhancement new 2012-06-26T20:46:07Z 2012-10-17T22:31:00Z "In #20923 we added initial support for browser-based uploads in iOS 6, by detecting the user agent. This is a good stopgap, but we can do better. We should implement a simple API that allows for us to do JS-based detection for mobile devices. We can use this for touch support, general upload ability, drag-drop upload ability, customizer support, and anything else that we can best detect in JS but that we need in order to make decisions in PHP. We could probably model parts of it on how the user settings API works — leveraging cookies, but without the DB backend. A function could then return a value from the cookie if set, and otherwise, it'd use the default value passed to it." nacin 21082 The Gallery shortcode relies on #gallery-instance to hook the CSS, but the id sometimes isn't specific enough Gallery normal normal Awaiting Review defect (bug) new has-patch 2012-06-26T18:43:28Z 2013-01-24T09:14:02Z "The Gallery CSS selector uses the id attribute, which is of the form #gallery-{instance}. On some scenarios (like infinite scroll) a follow up gallery on a another post can have the same #gallery-x selector, thus over-writing the previous gallery style. Proposed solution: make the #id more unique by including the postid number. (Attached patch.) (It could potentially impact some themes that used #gallery-1 to style galleries, but theme's shouldn't be using that in the first place, I believe.) Furthermore, it may be good to change the whole style block to use classes instead of the id so that it's easier for themes to deal with CSS specificity—and helps them not fall back to the #id." matveb 21078 "Image Captions are inserted without caption=""..."" inside the caption tag" Template 3.4 normal normal Awaiting Review defect (bug) new close 2012-06-26T08:17:49Z 2012-06-27T01:38:46Z "Since WordPress 3.4 captions are inserted this way: {{{ [caption id=""attachment_123"" align=""aligncenter"" width=""550""] My Caption[/caption] }}} This means themes cannot display them properly. Previous versions inserted the caption like this: {{{ [caption id=""attachment_123"" align=""aligncenter"" width=""550"" caption=""My Caption""] [/caption] }}} Here's a forum thread discussing the issue: http://wordpress.org/support/topic/caption-broken-in-new-34-posts" versluis 21073 Main functions file (/wp-includes/functions.php) could use a coding standards cleanup General normal normal Awaiting Review enhancement new has-patch 2012-06-26T03:04:21Z 2012-06-26T03:04:21Z "[http://core.trac.wordpress.org/browser/trunk/wp-includes/functions.php?rev=21113 This file] is very inconsistent in its coding standards, and as a result is difficult to read. I had to find a couple things in here recently; after some frustration in reading the different styles I decided to take a pass at refreshing it." evansolomon 21072 CRON often returns ambiguous values Cron normal normal Awaiting Review enhancement new has-patch 2012-06-26T02:18:27Z 2012-06-26T06:18:34Z "Many of the cron API functions return ambiguous values. For example, `wp_cron()` [http://core.trac.wordpress.org/browser/tags/3.4/wp-includes/cron.php#L251 returns] `null` (explicitly) when cron doesn't run, but it also returns `null` (implicitly) every other time. This can make debugging harder. Whenever possible, I think it's valuable to return meaningful values. The attached patch does that." evansolomon 21070 Added a filter to the sub-menu class attribute Menus 3.4 normal normal Awaiting Review enhancement reopened dev-feedback 2012-06-25T12:47:34Z 2012-06-25T20:50:30Z "The sub-menus are hard coded with ""sub-menu"" as the only CSS class. This may cause bad performing CSS with maintainability issues, like when you're targeting the third level sub menu. I've added a filter, so CSS classes like ""sub-menu-level-$depth"" can be added." bjornjohansen 21062 Add a 'template_file' hook to load_template() Template 3.4 normal normal Awaiting Review enhancement new dev-feedback 2012-06-24T21:04:50Z 2012-12-28T01:34:51Z "Please consider adding a `'template_file'` hook in `load_template()` to enable the capture of the template filename. I have built a panel for the Debug Bar to be able to show template files loaded but I need this `'template_file'` hook to capture the template file names. This would be super useful for developers who are building sites with the complex template loading logic found in various theme frameworks et. al. With the hook added the code for `load_template()` might look like this: {{{ function load_template( $_template_file, $require_once = true ) { global $posts, $post, $wp_did_header, $wp_did_template_redirect, $wp_query, $wp_rewrite, $wpdb, $wp_version, $wp, $id, $comment, $user_ID; if ( is_array( $wp_query->query_vars ) ) extract( $wp_query->query_vars, EXTR_SKIP ); $_template_file = apply_filters( 'template_file', $_template_file, $require_once ); if ( $require_once ) require_once( $_template_file ); else require( $_template_file ); } }}} Here's a screenshot showing the Theme Template Files panel I implemented so you can see the use-case. This plugin requires the hook I'm proposing in order to work and I have attached the plugin for other's review. {{{ #!html }}} This hook could also allow the loading of the template file from other directories such as a shared directory on a server, as appropriate, but that's not the reason I found the need today. The source for `load_template()` is found in `/wp-includes/template.php`. " mikeschinkel 21061 Can't drag an opened widget to other widget area Widgets 3.4 normal normal Awaiting Review defect (bug) new dev-feedback 2012-06-24T19:43:44Z 2012-06-24T19:43:44Z "the placeholder does not appear and the option to drag the opened widget is not possible, to fix this: to auto-close the widget before drag event (sortable) or add option to accept opened widgets http://wpimpact.com/wp-content/uploads/2012/06/Untitled-5.png" alexvorn2 21059 Customizer color picker has no remove button Appearance 3.4 normal normal Awaiting Review enhancement new 2012-06-24T11:34:12Z 2013-04-11T10:23:37Z There is no remove button for color picker in the customizer. It would be great if we could remove the color or set it to the default if we don't need the color. kcssm 21055 Interface for wpdb compatibility Database normal normal Awaiting Review feature request new 2012-06-23T17:30:13Z 2012-08-24T01:40:01Z "==Summary== From the wp-includes/wp-db.php file: {{{ It is possible to replace this class with your own by setting the $wpdb global variable in wp-content/db.php file to your class. The wpdb class will still be included, so you can extend it or simply use your own. }}} When one implements a db class that does not extend wpdb, it would be safer that the new class implements an interface. This interface may be called wpdb_compat and would assure that the class has all necessary methods/properties. Of course, wpdb_compat should be supported by wpdb too. == Design Strategies == My patch adds: * wp-includes/interfaces/wpdb-compat.php Very small edits to: * wp-includes/wp-db.php * wp-includes/load.php * wp-admin/install.php At the moment, WordPress does not include any interface; this means that there is not a directory for interfaces.[[BR]] In my first draft, I put it in wp-includes/interfaces so that - if more interfaces will be added in the future - they will have a logical place. " santec 21051 Database query needs optimization - function post_exists Performance 3.4 normal normal Awaiting Review enhancement new 2012-06-23T10:42:34Z 2012-06-23T21:09:26Z "Function post_exists in /wp-admin/includes/post.php is causing full table scans and sometimes it takes upto 30 seconds when there are millions of records in wp_posts table. Sample query - {{{ # Time: 120623 2:16:28 # User@Host: test[test] @ localhost [] # Query_time: 17 Lock_time: 0 Rows_sent: 0 Rows_examined: 13952234 SELECT ID FROM wp_posts WHERE 1=1 AND post_title = 'MIO WALKBLK'AND post_content = 'Mio Walk Black MENS HEART RATE DIGITAL FACE Brand: MIO Style: HRM Size: Mens Attachement: Black Resin Band'; }}} On running EXPLAIN output generated is {{{ id select_type table type possible_keys key key_len ref rows Extra 1 SIMPLE wp_posts ALL NULL NULL NULL NULL 13952445 Using where }}} Clearly its not making use of any index on wp_posts and thus causes full table scans and slow queries. Suggestions: More parameters like 'post_type', 'post_author', and 'post_category' can be added to improve functionality of post_exists function and this might also improve performance of database queries." arpit.tambi.in 21046 "Dashboard ""Right Now"" widget hook should be right_now_end, not rightnow_end" Widgets 3.4 normal minor Awaiting Review defect (bug) new 2012-06-22T07:35:20Z 2012-06-22T07:35:20Z "In /wp-admin/includes/dashboard.php , the following callback is used: {{{ do_action( 'rightnow_end' ); }}} However, [http://codex.wordpress.org/Plugin_API/Action_Reference#Dashboard_.22Right_Now.22_Widget_Actions the documentation] and logic (for consistency with `right_now_content_table_end`, `right_now_table_end`, etc) would tell us that the hook should actually be called `right_now_end`." schreifels 21044 Add action hook to end of resetpassform reset_pass_form romaimperator Plugins 3.4 normal normal Awaiting Review feature request new has-patch 2012-06-21T20:59:55Z 2012-06-21T20:59:55Z "'''Description''' This hook will allow plugin developers to add content to the form users see when they are setting a new password for their account. '''Why do I want this feature?''' My plugin found [http://wordpress.org/extend/plugins/trustauth/ Here] replaces the need for passwords. I added a feature to allow users to completely disable password logins for their account to prevent bruteforcing. This hook will allow me to add a feature which will let them assign a new TrustAuth key (just a public key) to their account rather than forcing them to reenable password logins and set a new password. '''Current Behavior''' Currently plugins cannot add anything to the form. '''Implementation Strategy''' I have created a patch which simply runs the action hooks before outputting the submit tag. '''Work Estimate''' However long it takes to review this ticket and apply my patch. '''Commitments''' me, romaimperator, implementing the one line of code" romaimperator 21043 is_user_logged_in() returns true even if user is not logged in Users 3.4 normal normal Awaiting Review enhancement new dev-feedback 2012-06-21T20:40:13Z 2012-06-21T20:56:54Z "If you have {{{wp_set_current_user()}}}, then {{{is_user_logged_in()}}} will always return true. This goes against my understanding of the role of wp_set_current_user() especially as explained by the documentation: ""Some WordPress functionality is based on the current user and not based on the signed in user. Therefore, it opens the ability to edit and perform actions on users who aren't signed in."" But then we look at {{{is_user_logged_in()}}} and it just says - can we {{{get_current_user()}}}? Suddenly wp_set_current_user is looking like wp_switch_logged_in_user(), which I doubt is the intent of that function. " TomAuger 21038 Provide an option for creating 2x images of user content (for Retina Displays) Otto42 Media 3.4 normal normal Future Release feature request assigned 2012-06-21T13:13:13Z 2012-09-06T17:02:33Z "Providing high-res images for Retina enabled devices like iPad, iPhone or Macbook Pro is rather easy with retina.js (http://retinajs.com/). The only thing needed is a @2x version of all images. It would be nice to have an option on the image uploader to enable generation of this images. This should be rather easy to implement, it would make life much easier." twam 21036 DB Repair on Multisite looks for wp_1_.... Multisite 3.0 normal normal Awaiting Review defect (bug) new 2012-06-21T12:37:40Z 2012-12-10T00:26:59Z "Log in to your site and need to repair. WP nicely prompts you, so you click the repair button and get this: {{{ wp_1_posts: Table 'wordpress.wp_1_posts' doesn't exist wp_1_comments: Table 'wordpress.wp_1_comments' doesn't exist wp_1_links: Table 'wordpress.wp_1_links' doesn't exist wp_1_options: Table 'wordpress.wp_1_options' doesn't exist wp_1_postmeta: Table 'wordpress.wp_1_postmeta' doesn't exist wp_1_terms: Table 'wordpress.wp_1_terms' doesn't exist wp_1_term_taxonomy: Table 'wordpress.wp_1_term_taxonomy' doesn't exist wp_1_term_relationships: Table 'wordpress.wp_1_term_relationships' doesn't exist wp_1_commentmeta: Table 'wordpress.wp_1_commentmeta' doesn't exist }}} I've seen this over and over again, and generally I tell people to go into phpMyAdmin and repair there, which works. But clearly looking for wp_1_ is going to be problematic for non-WPMU upgraded sites. Which are quickly becoming the majority." Ipstenu 21035 Encoding problem on my profile page? WordPress.org site normal normal WordPress.org defect (bug) new 2012-06-21T12:30:42Z 2012-08-10T18:18:31Z "Please see my profile page: http://profiles.wordpress.org/pavelevap. I made several plugins with non-English names. And these names are broken on profile page..." pavelevap 21034 Flyout Menu on Backend doesn't Loades Untill Whole Page is Loaded Administration 3.4 normal normal Awaiting Review enhancement new 2012-06-21T09:43:55Z 2012-06-25T05:30:06Z "I have noticed this ever since the flyout menu was introduced. Menu items on flyout menus is not shows until the whole page gets loaded. For high speed connection its not a problem but it gets annoying people who connected in dial up (last week my ISP was down so i had to work with dial up for couple of days). So, we could make the flyout menu items css/js to load on header so it doesn't wait for to load the whole page and make the backend accessible to and less annoying to low speed users.. For testing it you have to log into backend with low speed connection. If you need proof i can make a video with my dial up. Just let me know. BTW: What i see on firebug that the css for flyout menu loads on header so i don't really find out what causes the menu to not showing on hover until the page loads." prionkor 21031 Orphaned comments emit debug notices in dashboard and comments lists Warnings/Notices normal normal Awaiting Review defect (bug) new has-patch 2012-06-21T04:11:54Z 2012-06-21T07:19:14Z "map_meta_cap is not prepared to handle missing or invalid post ID's. To duplicate this, delete a post from the posts table without deleting its attached comments, then visit the admin dashboard with the recent comments widget visible. The comments list table exhibits a similar issue, where the $post global is assumed to be set and valid. This isn't something that happens naturally in WordPress core, but is something plugins are able to do directly to the database, which results in orphaned comments. The attached patches only suppress debug notices PHP spits out, and does not directly address the issue of what to do with orphaned comments, should a plugin choose to do this." johnjamesjacoby 21023 Blogger Importer Draft Status not processed correctly Import 3.4 normal normal WordPress.org defect (bug) new has-patch 2012-06-20T09:48:55Z 2012-06-20T14:57:20Z "The blogger importer is loading all drafts posts as published and/or scheduled. This is caused by an incorrect schema used in blogger-importer-blogitem.php. The correct schema is as follows {{{ define('SIMPLEPIE_NAMESPACE_ATOMPUB', 'http://purl.org/atom/app#'); }}} Ref: * http://wordpress.org/support/topic/plugin-blogger-importer-blogger-draft-status-changed-to-published-in-wp * https://developers.google.com/blogger/docs/1.0/reference#DraftEntries" Workshopshed 21022 Allow bcrypt to be enabled via filter for pass hashing Security 3.4 normal normal Awaiting Review enhancement new dev-feedback 2012-06-20T01:34:26Z 2013-03-05T19:26:57Z "Hi, following recent discussions on password security and how to best prevent any hackers can leverage password table they might have got I looked into the phpass used for WordPress. While I in principle understand why WordPress uses the compatibility mode of it, I would like to see some flexibility for those who don't need the compatibility. Thus I would propose to change in wp-includes/pluggable.php all occurances of $wp_hasher = new PasswordHash(8, true); to $wp_hasher = new PasswordHash(8, apply_filters('phpass_compatibility_mode', true)); This would allow users to easily change via plugin from the ""not so secure"" compatibility mode (only salted MD5) of phpass to a more secure setting (bcrypt) in case no compatibility with other applications is required. The plugin changing the encryption methog could then as easy as function phpass_bcrypt() { return false; } add_filter('phpass_compatibility_mode', 'phpass_bcrypt');" th23 21017 Using force_feed() for simplepie in core nacin Feeds 3.4 normal minor Awaiting Review enhancement reviewing dev-feedback 2012-06-18T22:21:48Z 2012-06-27T14:32:13Z "Receiving the following error in the ""Incoming Links"" widget in the admin dashboard: [[BR]] {{{ RSS Error: A feed could not be found at http://www.google.com/search? ie=utf-8&partner=wordpress&q=link:http://mysite.com/ &tbm=blg&tbs=sbd:1&output=rss. A feed with an invalid mime type may fall victim to this error, or SimplePie was unable to auto-discover it.. Use force_feed() if you are certain this URL is a real feed. }}} [[BR]] The support forum thread which can provide more specific information can be found here: [http://wordpress.org/support/topic/incoming-links-error-message-1?replies=41] [[BR]][[BR]] It has been suggested adding '''force_feed()''' to the core might alleviate this issue in future dev. " josh401 21015 Months dropdown should not show if only posts are 'auto-draft' status Administration 3.1 normal normal Awaiting Review defect (bug) new has-patch 2012-06-18T19:16:54Z 2012-09-28T14:42:09Z "The months dropdown at the top of edit.php should only show if there are actually posts in the list. Right now, if you click 'Add new' an auto draft post will be saved. Leave the post edit screen without saving the post (so no draft will be created) and go back to the edit.php screen. There is no post in the list, but the month drop down will be shown because the auto draft is counted." CoenJacobs 21014 Add Action to Form Tags In Settings Pages General 3.4 normal normal Awaiting Review enhancement new 2012-06-18T19:04:14Z 2012-06-18T19:04:14Z "It would be nice to have additional hooks that allow adding attributes to form tags in settings pages. For example, if you would like to allow a user to upload an image in a settings page, you need to add the enctype attribute to the form tag. Having a hook would allow you to avoid doing this with JS. user-edit.php and user-new.php allow this using the 'user_edit_form_tag' and 'user_new_form_tag' hooks respectively, and it appears that edit-tag-form.php is adding this also. (http://core.trac.wordpress.org/ticket/15261)" desrosj 21010 View Post Link on edit-comments.php mordauk Comments 3.4 normal minor Awaiting Review enhancement new has-patch 2012-06-18T15:10:27Z 2012-12-23T03:47:41Z "Anytime I approve a comment, I'm always irritated by the fact that there isn't a ""View Post"" link anywhere that links to the live post on the front end. The title of the post, such as ""Hello World"", is shown, but it links to post.php. A lot of times I want to read back through the original post before I answer the comment, and I'd prefer to do that on the live site, not the admin, so I think there needs to be a ""View Post"" link next to the post title that links to the live site." mordauk 21009 "If name=""post_type"" is set in search template the archive template is loaded." Post Types 3.4 normal minor Awaiting Review defect (bug) new reporter-feedback 2012-06-18T12:46:51Z 2012-09-26T22:05:47Z "I have a hidden form field named ""post_type"", which is used in the search form. When the user searches the archive.php template is loaded and not the search.php template. I'm not sure if this is a bug, or unexpected behavior, note my fix was to use a different form field name. Bug(?) url: == http://bmxraceevents.com/?s=maryland&post_type=events == Fixed url: == http://bmxraceevents.com/?s=maryland&type=events == == http://zanematthew.com/blog/2012/06/unexpected-behavior-in-wordpress-custom-post-type-search-template/ == " ZaneMatthew 21007 Importing omits backslashes Import normal normal WordPress.org defect (bug) new has-patch 2012-06-18T08:11:16Z 2012-06-18T12:10:13Z If you try to import a previously-exported post containing backslashes, those backslashes will be omitted during the import process. SeMeKh 21004 add_image_size hard crop messes up image editor rendering Media 3.4 normal normal Awaiting Review defect (bug) new has-patch 2012-06-17T23:48:51Z 2012-12-07T13:51:58Z "When I add an image size with hard crop set to true ( ex: add_image_size('index-thumbnail', 420, 550, true); ) it makes it so that you cannot edit the full size of an image in the image editor - only a cropped version. http://i47.tinypic.com/20h2dfr.png (link to screenshot) The left image in the screenshot is the editor when I removed 'true' from my add_image_size arguments. The right image is with 'true' added back in. I also see that others had the same problem in this thread: http://wordpress.org/support/topic/help-add_image_size-and-image-cropping?replies=6 ...but it was closed without any resolution." geniepop 21002 Feature request: wp_link_pages() needs support for formatting the current page General normal normal Awaiting Review feature request reopened 2012-06-17T19:09:51Z 2013-01-18T02:27:18Z "To follow up my previous feature request #21001, it would be super to see a way to style/format the current page, because it could look different compared to links to other pages (for example "">> Page % <<""). An option called currentpagelink seems fitting." archon810 21000 custom-background still include background-image: none; when setting background color General 3.4 normal normal Awaiting Review defect (bug) new close 2012-06-17T17:38:56Z 2012-10-08T17:52:30Z "I am sorry I missed this after the last inclusion before release, but in the function _custom_background_cb() I overlooked testing logic in the callback before it was released. if background color was specified but no image, act as if image shouldn't exist The original complaint was that when you removed (both) the $background and $color that it outputted the background-image: none; However in 3.4 it's not account for $color in the function and !$background This is the change I am requesting. {{{ if ($background) { ... }}} line: 1136 - wp-includes/theme.php {{{ } else $style .= ' background-image: none;'; }}} This will make it handle the if ($color && !background) appropriately " Frumph 20988 Open a closed sidebar box and enable droppable/sortable in it when you hover a draggable available widget over it ldebrouwer Widgets 3.4 normal normal Awaiting Review enhancement new 2012-06-16T10:27:24Z 2012-06-16T11:00:29Z "At the moment you have to explicitly open a sidebar box to allow it to except available widgets. In my humble opinion this is bad UX and the sidebar box should expand automatically when being hovered over with a draggable and it should accept the draggable to it's containing droppable/sortable as well. The obstacles to overcome: - Since the draggable in most cases overlaps the sidebar box when dragging over it ( unless you move really quickly ) it's hard to register a 'mouseenter'. This could be solved by setting the 'cursorAt' option for the draggable. - Opening a sidebar box is trivial but activating the droppable/sortable only seems to kick in when the draggable has been released." ldebrouwer 20986 xmlrpc.php should return http 405 for get requests (and not 200) XML-RPC normal normal Awaiting Review defect (bug) new has-patch 2012-06-16T06:39:12Z 2012-06-19T17:01:09Z "{{{ $ curl -v http://raphaelhertzog.com/xmlrpc.php [...] > GET /xmlrpc.php HTTP/1.1 < HTTP/1.1 200 OK [...] XML-RPC server accepts POST requests only. }}} The error returned should be reflected in the HTTP return code: it should return HTTP 405 (Method not allowed) instead of 200 (OK). This has been originally reported in the Debian bug tracking system: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=598124" rhertzog 20983 Change phrasing for 'Network Activate' newly installed plugins Multisite 3.0 normal minor Awaiting Review defect (bug) new has-patch 2012-06-15T21:25:05Z 2012-06-16T02:28:39Z "Not everyone is clear what 'Network Activate' means and after installing a plugin, a lot of people just assume that activate will turn it on for one site only. Then they complain that the plugin turned it self on automagically! While it would make the link longer, I think changing it to the same wording we have in the title might actually catch their eye: ''Activate this plugin for all sites in this network'' (The other thought was to put 'Return to Plugins Page' in front of Network install, but that would annoy single site people, of whom there are a majority)" Ipstenu 20978 Upload a theme like an image Themes 3.5 normal normal Awaiting Review feature request new dev-feedback 2012-06-15T18:26:31Z 2012-12-15T16:45:15Z add option to drag zip files like images on 'theme-install' page, enable multiupload. alexvorn2 20977 Add Dynamic Comment Statuses Comments 3.4 normal normal Awaiting Review enhancement new 2012-06-15T17:12:07Z 2012-06-15T17:21:37Z It would be great to add some filters/actions that would allow plugin developers to add additional statuses to comments. supercleanse 20974 Remove obsolete locale-specific files on upgrade dd32 I18N 3.4 low normal Future Release defect (bug) assigned has-patch 2012-06-15T14:06:43Z 2012-11-07T20:20:44Z "We used to have `wp-content/languages/ru_RU.css` file in ru_RU package. Since #19603, it's no longer needed, but is still left over on upgrade. We should probably include it in `$_old_files`. I suppose the same applies to zh_CN and he_IL packages ([19825])." SergeyBiryukov 20973 date_i18n() produces invalid output for shorthand formats Date/Time 3.4 normal normal Awaiting Review defect (bug) new 2012-06-15T13:39:50Z 2013-04-04T16:36:54Z "date_i18n() function relies on parsing passed format to make adjustments. However shorthand formats are not handled and produce invalid output. Example: {{{ var_dump( date_i18n( 'Y-m-d\TH:i:sP', time() ) ); // 2012-06-15T13:34:03+03:00 << ok var_dump( date_i18n( DATE_W3C, time() ) ); // 2012-06-15T13:34:03+03:00 << ok var_dump( date_i18n( 'c', time() ) ); // 2012-06-15T13:34:03+00:00 << broken time zone! }}} Hook-level fix: {{{ add_filter( 'date_i18n', 'fix_c_time_format', 10, 3 ); function fix_c_time_format( $date, $format, $timestamp ) { if ( 'c' == $format ) $date = date_i18n( DATE_W3C, $timestamp ); return $date; } }}} See [http://wordpress.stackexchange.com/q/54700/847 Why time functions show invalid time zone when using 'c' time format?] Possibly related (can't say for sure from description) #13538" Rarst 20958 Add to the Template Hierarchy the 410 error page byteee General normal normal Awaiting Review feature request new 2012-06-14T16:32:57Z 2012-06-14T16:32:57Z "In my last project where I migrate a web from asp to wordpress, I have some pages that not longer exists. Normally, we do a 301 redirection to the home page or some other place. But digging a little in google, if we get a page that not longer exists, its better to return a 410 response code instead of 301 code (talking about SEO aspects). I did it manually following this post: [http://otroblogmas.com/retornar-410-wordpress/] I think that we can include in the Template Hierarchy the 410.php file to show it when we are getting a page that not longer exists. " byteee 20956 Navigation changes: Posts/Pages Administration 3.4 normal normal Awaiting Review enhancement new has-patch 2012-06-14T14:42:25Z 2013-01-22T03:30:06Z "1. Explaining the difference between Posts and Pages to new users is time consuming and often frustrating. We've all done it, have our best/fastest version of the talk down pat, but it still takes longer than it should to get many new users to the point of understanding the difference. 2. Back in 2.7, when we set up the left navigation we put Pages at the bottom of the content nav section because in testing 2.5/2.6 so many people complained about accidentally clicking Posts/Pages by accident because they were close together in the old UI and both started with P (blame it on capital_p). Because of this, Pages falls below the less-frequently accessed areas of Media and Links, and people don't necessarily see it right away because they expect it to be higher up. I've been testing out two changes to the left navigation aimed at reducing these two issues on my test blog for some time now, and have been using it during demos with both new and existing users to great success, so I think it's time to propose it for core. Change 1: Change the Posts label to Blog. All Posts can remain as is, or could be reduced to just Posts, since the reason we added the All in the first place was that Matt thought it looked weird to have the same word shown twice. This change reduces the amount of time it takes me to get a new user really understanding the difference between posts and pages by about 75% (very informal testing, have kept track with about 30 new users by just keeping an eye on the computer clock to see how long it is before we move on). The dynamic blog/static site difference is much easier to grasp when they see that familiar word Blog instead of Posts because ""posting"" is an action that applies even to static content, and even posts are displayed in web pages (vs Pages). Change 2: move Pages up the menu to sit below Blog, so the two most important content types are at the top. Since they wouldn't look similar (ha ha capital_p) there would be much less risk of accidental misclick based on letter shape (poor manual dexterity would not be affected, but in that case those people are already clicking the wrong things, right?) I've attached a screenshot showing what the navigation would look like with these changes. " jane 20948 Unnecessary post type check in wp_get_attachment_url Media 3.4 normal normal Awaiting Review defect (bug) new dev-feedback 2012-06-14T02:38:16Z 2012-12-16T23:21:48Z Not sure why this needs to be done. You wouldn't be calling this function on a post if it wasn't an attachment. If you are, then you must have a good reason to be doing so, like I do. jfarthing84 20947 feature request: one-click update for core, themes and plugins (all in one) Upgrade/Install normal normal Awaiting Review feature request new dev-feedback 2012-06-13T22:48:50Z 2012-06-13T22:49:28Z I'd love to have the one-click update be truly one-click so that you can click once and update core, themes and plugins all at once as opposed to having to initiate three different updates. jkudish 20946 Improve 'Right Now' in Network Admin Network Admin 3.4 normal normal Awaiting Review feature request new 2012-06-13T21:02:14Z 2012-07-11T21:50:34Z "It seems like there are a few things that could be done to make 'Right Now' in the Network Admin a little more informative and functional: 1. Add the current !WordPress version and applicable 'Update to X' and/or 'Update Network' buttons. Currently in NetAdmin the version is only displayed in the footer and (sort of) in /network/update-core. 2. List and link the site and user counts in similar fashion as the single-site 'Right Now' box 3. List and link theme and plugin counts" DrewAPicture 20944 Changing plugin filename causes Fatal error on automatic activation after update Plugins 3.3 normal normal Awaiting Review defect (bug) new has-patch 2012-06-13T19:43:38Z 2012-07-08T20:56:03Z "In a new version of a (my) plugin in the WordPress repository, I changed the filename of the main plugin file (to match the folder name). When an old version of the plugin is activated, doing an automatic update to the latest version of the plugin (with the new filename), the following error message is displayed: ""The plugin jonradio-display-kitchen-sink/jonradio-kitchen-sink.php has been deactivated due to an error: Plugin file does not exist."" An immediate manual Activation completes successfully. Observed on sites with WordPress Network turned off and on, including when the plugin was Network Activated. Plugin is jonradio Display Kitchen Sink, and update was from Version 1.0 to 1.1." adiant 20943 Paragraphs get removed in table cells when Visual editor is refreshed Formatting 3.2 normal normal Awaiting Review defect (bug) new needs-unit-tests 2012-06-13T19:06:04Z 2013-04-18T16:14:03Z "As far as I know, this issue has been around since 3.1. It's not a bug in 3.0.4. I even stopped upgrading at 3.0.4 for any sites where I knew the client would need to edit tabular data. For security reasons, it's time to upgrade these and I'd REALLY like this issue to be fixed. The problem happens when using paragraphs in a table cell. When I hit enter to create a new paragraph within a table cell, it looks fine. If I then hit Update/Publish, when the page refreshes, WordPress converts that paragraph break into a single line break. If I then click Update again, WordPress removes that linebreak entirely and the paragraphs are essentially merged. I can also reproduce this behaviour without even clicking Update. If you just switch to HTML mode and then back to Visual mode, the same issue occurs." JboyJW 20938 Adding existing category duplicates default one Administration 3.3.2 normal minor Awaiting Review defect (bug) new dev-feedback 2012-06-13T13:52:18Z 2013-01-22T03:35:53Z In the post editing page, if you add a category which already exists, Wordpress duplicates the default category (Uncategorized), instead of showing a warning or doing nothing. hvsupr 20936 Image upload - HTTP error Upload 3.3.2 normal major Awaiting Review defect (bug) new 2012-06-13T08:40:59Z 2012-06-13T21:24:05Z "Unable to upload some type of images, because crunching error. Reproducation: Try to upload attached png image (SC20120611-160917.png), to wordpress site (3.3.2). I try it all of my wp sites, and fresh installation (without plugins). The upload progress aborted (HTTP error). If you convert the png file to jpg, the upload and crunching was succeed (there is no configuration errors i think). I try some workarounds too, but doesn't help (this is not an individual problem i think): http://wordpress.org/support/topic/http-error-on-image-upload-still http://wordpress.org/support/topic/flash-uploader-logs-out-during-crunching-phase?replies=19 This error affected 3rd party tools (like android wordpress app). " voji 20935 No display in the WYSIWYG editor. General 3.4 normal normal Awaiting Review defect (bug) new 2012-06-13T05:58:51Z 2012-06-13T05:58:51Z Sometimes, nothing in the visual editor in me does not appear and you can switch to HTML view. OldShaterhan 20930 register_taxonomy show_in_menu option Taxonomy normal normal Future Release enhancement new has-patch 2012-06-12T23:07:30Z 2012-11-23T19:55:35Z "Shouldn't taxonomies have a show_in_menu option for taxonomies as well. Of course, this would be the same as custom post types affecting the registration and the $parent_file. The original attachment has the parent file logic via the filter, 'parent_file'." wpsmith 20928 Add regular-text style to textareas Administration low normal Awaiting Review enhancement new has-patch 2012-06-12T20:13:43Z 2012-06-12T20:14:38Z The `regular-text` class style is only applied to input elements. It would be nice to get this on textareas too so my textareas are the same width as my single line text inputs. johnbillion 20927 Ampersand inside HTML comment causes wp_insert_post to loop infinitely General 3.3.2 normal normal Awaiting Review defect (bug) new 2012-06-12T19:54:46Z 2012-06-14T13:09:40Z "I'm encountering an issue with wp_insert_post where, when the post_content contains an HTML comment containing an ampersand (ie, """"), wp_insert_post seems to be getting stuck in an infinite loop. As far as I can tell, it is endless escaping the & into & over and over. I've attached a small script that reproduces this error; you need to replace the HTTP_HOST and the path to wp-load.php to reflect your own machine for it to run. I've reproduced this issue on two different machines, both running Ubuntu 12.04, one on Wordpress 3.3.1 and the other on Wordpress 3.3.2. The most bizarre thing about this issue, to me, is if you move the contents of the includeFiles() function out of the function and into the main body of the script, the issue no longer occurs. Somehow, including wp-load.php from a function is causing the infinite loop." jpayette 20920 Removing all hooks too aggressive if a priority number is given Plugins 3.3.2 normal normal Future Release defect (bug) new has-patch 2012-06-12T13:01:13Z 2012-06-13T13:24:30Z "When you call `remove_all_filters()` or `remove_all_actions()` with a priority number (second parameter), all hooks get removed if none is found with the given priority. Example: {{{ #!php Thank you for updating to the latest version! But I didn't! I am just a lowly editor. My administrator probably updated the site for me. We shouldn't show this sentence if the user doesn't have the `update_core` capability." johnbillion 20905 Allow rewrite endpoints to specify a different query variable name Permalinks normal normal Awaiting Review enhancement new has-patch 2012-06-11T13:53:40Z 2012-08-24T07:02:34Z "Using `add_rewrite_endpoint()` we can add an endpoint such as `/foo/bar/` which maps to `foo=bar`. I'd like to be able to map an endpoint to a query variable of a different name. Currently the query variable name always matches the endpoint name. Example: I'd like to use `/p/{number}` as a nice short endpoint for some custom functionality, but the 'p' query variable is used by core. I'd like to be able to map `/p/3/` to `my_query_var=3`." johnbillion 20904 WP_Query instances getting entangled with $wp_query global Query normal normal Future Release defect (bug) new has-patch 2012-06-11T11:55:39Z 2013-05-14T13:25:32Z "`WP_Query::the_post()` fires `setup_postdata()`, which then uses `get_query_var()`. `get_query_var()`, in turn, calls the `get()` method on the `$wp_query` global object. In this way, WP_Query instances are not truly insulated from each other - they all are tied up with `$wp_query` in a way that seems unnecessary, and causes fatal errors in some cases. In normal use, you would never really notice the issue, because after the `'init'` action, the following offending line in `setup_postdata()` will return the 'page' query var from `$wp_query`: {{{ $page = get_query_var('page'); }}} And, since secondary `WP_Query` instances don't paginate in the same way as the primary query, the 'page' property on those instances doesn't matter much. So, while the value of `$page` is not strictly speaking correct in these cases (it comes from the wrong object), it generally fails silently. However, if you instantiate a WP_Query object before 'init', you get a fatal error, because `$wp_query->get()` is an undefined method. Here's a simple mu-plugin that will demonstrate the problem: {{{ function bbg_create_early_wp_query_object() { $q = new WP_Query( array( 'post_type' => 'post' ) ); if ( $q->have_posts() ) { while ( $q->have_posts() ) { $q->the_post(); } } } add_action( 'plugins_loaded', 'bbg_create_early_wp_query_object' ); }}} My suggested solution is to move the `setup_postdata()` logic into a method of the `WP_Query` class, and then use `$this->get( 'page' )` rather than `get_query_var( 'page' )`, to ensure that you're referring to the query vars of the correct query object. The old function `setup_postdata()` then becomes a wrapper for `$wp_query->setup_postdata()`. In addition, I modified the way that the `$more` global is set, so that it references the current object as well. This prevents `_doing_it_wrong()` errors when firing up a `WP_Query` instance before `'init'`." boonebgorges 20903 Exporter gets stuck in a loop a loop/break in the category hierarchy westi Export 3.1 normal normal Future Release defect (bug) new has-patch 2012-06-11T11:26:07Z 2012-06-12T08:13:02Z "Ideally it should be impossible for a loop/incorrect parentage in a category hierarchy to exist. But sometimes they do. If one does exist then {{{export_wp()}}} gets stuck :( It gets stuck in this code: {{{ // put categories in order with no child going before its parent while ( $cat = array_shift( $categories ) ) { if ( $cat->parent == 0 || isset( $cats[$cat->parent] ) ) $cats[$cat->term_id] = $cat; else $categories[] = $cat; } }}} Similar to #20635 but different." westi 20902 redirect_canonical() on using permalink: Not all $_GET being redirected Canonical 3.4 normal normal Awaiting Review defect (bug) new dev-feedback 2012-06-11T09:30:08Z 2012-11-01T04:54:03Z "Using permalink, I suppose that all query_var entered manually on URL or using $_GET will be redirected to proper permalink. Apparently not all being redirected at all. AFAIC: 1. /?post_format=image : should be redirected to /type/image/ 2. /?pagename=blog : should be redirected to /blog/ 3. /?author_name=admin : should be redirected to /author/admin/ Unfortunately, they are not. It can be done by filtering redirect_canonical() but it will be better if it's being done by default as we can see that /?category_name=cat will be redirected to /category/cat/" arieputranto 20901 Taxonomy descriptions should be TinyMCE editable Administration normal normal Awaiting Review enhancement new dev-feedback 2012-06-11T07:49:17Z 2013-05-16T10:16:18Z "Right now taxonomy descriptions are filtered heavily for HTML and are output as a simple textarea, making it impossible to make those into ""nice"" tinymce editors without a kind of hackish plugin. I'd be in favor of making taxonomy descriptions tinymce by default." joostdevalk 20900 Throw an error in `get_default_post_to_edit` if the specified post type is not defined. Post Types normal minor Awaiting Review defect (bug) new dev-feedback 2012-06-10T23:07:23Z 2012-06-10T23:07:23Z "Currently get_default_post_to_edit will generate a post with the specified post type, even if it doesn't exist. Let's give it a chance to do something else. If this is conceptually a good idea, also do it during wp_insert_post() and other similar functions." georgestephanis 20899 is_home() should be able to be true when is_feed() Query normal normal Future Release defect (bug) new has-patch 2012-06-10T19:28:36Z 2012-11-01T10:31:35Z "is_feed() is a special query flag that can be combined with other query flags — for example, `is_author() && is_feed()` for /author/admin/feed/. But it can't be combined with is_home(), because is_home() is the fallback that is only set to true when a lot of other things are true — including is_feed(). This appears to be incorrect — is_home() should still be able to be true despite is_feed(). I tracked this down to [1449]. What kind of breakage could occur with this?" nacin 20890 Standardize line endings of wp-config-sample.php and wp-fullscreen.css General normal trivial Awaiting Review defect (bug) new 2012-06-08T15:24:46Z 2012-06-08T15:57:59Z "Two core files seem to have invalid line endings (\r). {{{ ~/data/wp$ ack -l ""\r"" wp-includes/js/tinymce/plugins/wpfullscreen/css/wp-fullscreen.css wp-config-sample.php ~/data/wp$ cat -vT wp-config-sample.php | head Header is broken Accessibility 3.3.2 normal normal Awaiting Review defect (bug) new 2012-06-07T17:40:34Z 2012-06-08T06:27:11Z "It's impossible to use the Appearance > Header section with the keyboard because the Enter button will submit the form using the top-most submit input, which is not always the Save Changes button. How to reproduce, in Appearance > Header, using Twenty Eleven: 1. Select one of the default header images 2. Check the Show header text with your image option 3. Enter #111 for Text Color 4. Click Save Changes At this point everything looks fine, but here comes the trouble: 5. Enter #222 for Text Color and hit Enter You'll notice that #222 hasn't been set as the Text Color, instead your chosen header image (in step 1) has been removed, as if the Remove Header Image button was clicked. 6. Enter #333 for Text Color and hit Enter You'll notice that #333 hasn't been set as the Text Color, instead it's been set to #000 which is Twenty Eleven's default, as if the Restore Original Header Text button was clicked. When both Remove Header Image and Restore Original Header Text buttons are not present, the Return key submits the form using Save Changes, as expected. It's not limited to Text Color, but any other element that can submit the form using the Enter key. I've been facing the exact same problem when doing an options panel for a theme with multiple actions as submit buttons, still haven't found a good solution. Marked as 3.3.2 but I believe it's been around earlier. Thanks!" kovshenin 20875 Introduce wp_cache_get_multi() Cache normal normal Future Release enhancement new has-patch 2012-06-07T13:56:28Z 2013-04-16T17:12:29Z "Both options (see #10274) and themes (see #20103) could benefit from a cache backend that implements get_multi(). For options, this means we can use individual keys. For both themes and options, we'd be able to make fast multiple gets. Both APC and Memcached (but not Memcache) implement multiple-get. A fallback would be looping over get(). Separately, as this would be a new function we use in core, we probably need to start doing some kind of versioning for drop-ins like db.php and object-cache.php." nacin 20870 error notice when $post = NULL with gallery_shortcode Media 3.3 normal trivial Awaiting Review defect (bug) new 2012-06-07T11:05:46Z 2012-06-26T03:12:02Z "i have noticed with many relevant plugins and functions it may happen, that gallery_shortcode is called when global $post returns NULL. problem is, that gallery_shortcode function media.php containts {{{ 'id' => $post->ID, }}} (row 798 on 3.4 or 783 on 3.3.2) so when $post is NULL it returns error notice there is trivial solution - adding (!$post) check just after the $output filter (so it could be rewriten by plugin authors) - see last line: {{{ function gallery_shortcode($attr) { global $post; static $instance = 0; $instance++; // Allow plugins/themes to override the default gallery template. $output = apply_filters('post_gallery', '', $attr); if ( $output != '' ) return $output; if (!$post) return; }}} (sorry, i do not know how to change it on svn). This bug is even on 3.3.2 even on latest 3.4" thomask 20861 switch_to_blog() breaks custom post type permalinks Multisite normal normal Awaiting Review defect (bug) reopened 2012-06-06T22:30:53Z 2013-04-15T12:18:49Z "When using switch_to_blog() and custom post types, there are very strange results when calling the_permalink() or get_permalink(). For reference, we'll say the root site is blog1 and the second site containing the posts is blog2. Using this code inside the loop: {{{ switch_to_blog( $post->blog_id ); get_permalink(); }}} If the post type is not registered on the current blog, the permalink given will be sitename.com/blog2/slug - when clicking it as href, it brings you the first instance of that slug in the database. If the post type is registered on the current blog, the permalink given will be sitename.com/blog2/blog1/post-type/slug - this link will 404. Related issue: #14992" sickhippie 20859 Theme Installer: Preview should be scrollable on iPad and Kindle Fire Appearance 3.4 normal normal Future Release defect (bug) new 2012-06-06T21:51:09Z 2012-06-08T21:10:27Z "Related to #20805. We've added techniques for smoothly scrolling iframes when they're the only frame on the page, but the theme installer still uses the overlay technique. We may be able to iron this out in a similar fashion. Given that the old installer also used an overlay technique, this is not a regression." koopersmith 20854 functions.php on line 155 ? Nikolaos Raftopoulos Multisite 3.3.2 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-06-06T12:45:29Z 2012-07-31T02:42:37Z "In my network dashboard I get the following error message : Warning: number_format() expects parameter 1 to be double, string given in /home/tklighth/public_html/wp-includes/functions.php on line 155" leondari 20853 get_post_custom show directly serialized data from the post_meta arrays. General 1.5 normal minor Awaiting Review defect (bug) assigned dev-feedback 2012-06-06T05:39:23Z 2013-03-11T16:46:21Z "get_post_custom show directly serialized data from the post_meta arrays. For example: If I save a data with: {{{ update_post_meta( $post_id, 'camp', array( 'some' => $var, 'thing' => $var_2 ) ); }}} When I use get_post_meta(); : {{{ $var_get = get_post_meta($post_id, 'camp', true); echo $var_get['some']; // Fine.. Print: $var content. }}} but, when I use get_post_custom() : {{{ $var = get_post_custom($post_id); echo $var['some']; Metod, (Not work because ""Returns a multidimensional array"" with all values, and 0 is the first or the unique value). echo $var['some'][0]; /* Metod, >:( , Not work. Print: a:2:{i:some;s:4:""this"";i:thing;s:7:""content"";} */ }}} Instead of display ""array"", and can not handle sub arrays." shadowhck 20850 Duplicate term insertion allowed after insertion with case differences Taxonomy 3.3.2 normal normal Awaiting Review defect (bug) new dev-feedback 2012-06-06T00:00:33Z 2012-06-08T20:20:38Z "I've discovered a case where duplicate terms can be inserted with wp_insert_term(). Steps to reproduce: 1. Insert a term, i.e. {{{ wp_insert_term('USA', 'country'); }}} 2. Insert the same term, but with a different case, i.e. {{{ wp_insert_term('usa', 'country'); // it's ok that this succeeds, because technically it *is* different (case-wise) }}} 3. Insert the same term as in step 2. It should fail, but doesn't: {{{ wp_insert_term('usa', 'country'); // succeeds }}} This is because wp_insert_term() does the following: 1. Finds the first term in the db that matches the initial (non-unique) slug for the new term name 2. If the name of the found term doesn't match the new term name, then insert continues. In the example above, it's comparing all subsequent 'usa' term names to the first 'USA' term name and determining that it's ok to continue, when it's not because there are other 'usa' terms that it didn't look at." jazbek 20848 Header images are cropped and resized with improper permissions. Administration 3.3.2 normal normal Awaiting Review defect (bug) new has-patch 2012-06-05T17:41:45Z 2012-06-05T17:41:45Z "On some systems the cropped and resized header images become unreadable by the web server. The attached patch makes the files inherit the permissions from the parent folder. " gtenney99 20847 "Documentation references to ""digits"" should be ""characters""" Inline Docs normal trivial Awaiting Review defect (bug) new has-patch 2012-06-05T14:49:08Z 2012-08-20T21:14:53Z Some documentation references to digits should really be called characters, since they refer to parts of a hexadecimal number, and therefore not strictly 0-9 only. GaryJ 20846 Multisite: Network Users can post comments without being members of the site Multisite 3.0 normal normal Awaiting Review defect (bug) new has-patch 2012-06-05T14:35:41Z 2012-11-02T23:02:52Z "This is probably an 'ever since inception' issue and I can replicate it on 3.4 Setup: Have a user added to your network but '''not''' to a site (domain.com/test). Set up domain.com/test to only allow registered users to comment. Remember, we've not added this new user to the site, just the network. Log in as that user and go to domain.com/test Oh look! You can comment as a 'registered' user. This should be check for 'Is this a user ''and'', if multisite, is this user a member of the site?' It's that or the wording needs to be clearer that anyone registered on the network can comment." Ipstenu 20845 "wp_set_current_user( null, ""name"") does not work when $current_user is already 0" Users 3.3.2 normal normal Awaiting Review defect (bug) new 2012-06-05T13:11:53Z 2012-06-05T16:10:58Z "According to the documentation for wp_set_current_user() you can Set $id to null and specify a name if you do not know a user's ID. This does not work when the current user has already been set to anonymous ( ID = 0 ) since the following test returns true. if ( isset( $current_user ) && ( $current_user instanceof WP_User ) && ( $id == $current_user->ID ) ) { The last part of the test should be corrected to && ($id === $current_user->ID) ) which will ensure that the test fails when the $id parameter is null, which will allow the rest of the pluggable function to continue and set the current user to the specified $name. This is similar to #19769. Note: the change in 3.4 has not fixed this particular problem." bobbingwide 20844 Specify titles using General normal normal Awaiting Review feature request new 2012-06-05T09:49:51Z 2012-06-19T23:05:04Z "Hi, I'm planning to code a plugin but maybe you're going to code it into WP core, so I prefer to ask before. The idea is to modify code in order to give a title to every page, also better in SEO to have an url like www.wordpress.org/2012/my-article and www.wordpress.org/2012/my-article/conclusion/ instead of www.wordpress.org/2012/my-article/2/. Maybe is possible to modify it this way: It's different from subpages because it will be usable on every post type, not even on pages, and you will create just one post, not more. Last but not least you could have a page selector with titles not page numbers. Thanks :)" sgr33n 20842 Buttons are not on the same line when saving a post as pending (RTL) I18N 3.4 normal normal Awaiting Review defect (bug) new 2012-06-04T23:58:11Z 2012-09-08T22:55:52Z Please check attachment. rasheed 20825 User activation in multisite should happen in the main blog.. Multisite normal normal Awaiting Review defect (bug) new has-patch 2012-06-04T11:00:41Z 2012-11-02T22:52:08Z "In multisite mode ( subdomain ) , when a user activates his account, it should happen in the main blog ( or not ? ) . In ms-settings.php ( line 118 ) , we assume that the main blog is always blog=1 ( which may be wrong ) . The attached patch uses the constant BLOG_ID_CURRENT_SITE if defined instead." rahal.aboulfeth 20824 current_user_can() bug with Super Admin Users 3.3.2 normal normal Awaiting Review defect (bug) reopened 2012-06-04T10:55:53Z 2012-11-28T23:15:06Z "If the logged in user is a super admin this returns true; {{{ if (current_user_can('contributor')) echo 'current user is a contributor'; }}} Normally it should return false as it does for administrator, author, editor and subscriber account types. I spotted this while working in my localhost Multisite install then figured it doesn't work in the live standalone version! " abdessamad idrissi 20822 Switching visual/html on wp_editor used on front end not saved as new default General 3.3.2 normal minor Awaiting Review defect (bug) new 2012-06-04T06:45:12Z 2012-06-04T06:45:12Z "Using the wp_editor on the frontend it doesn't default to the last used state it defaults to the last used state on the back end. I did find that using: add_filter( 'wp_default_editor', create_function('', 'return ""tinymce"";') ); inside the function I am using to replace the front end comments with the visual editor worked around this a for me by defaulting to visual which works as well for me in this case as last used, but the default should probably change globally when a logged in user toggles between the two _or_ should get saved independently. " jb510 20816 custom-background $args enhancement Themes 3.4 normal normal Awaiting Review enhancement new has-patch 2012-06-02T04:56:46Z 2013-03-27T15:04:09Z "Looking to have added the rest of the arguments to pass through the $args to include the rest of the appearance -> background parameters including but not limited to position(x/y), repeat and attachment. `add_theme_support('custom-background', $args);` Example: {{{ array( 'default-color' => '000000', 'default-image' => get_stylesheet_directory_uri() . '/images/background-wolfbw.jpg', 'repeat' => 'no-repeat', 'position-x' => 'center', 'attachment' => 'fixed' ); }}} ie. the repeat position(x/y) and attachment parameters Main themes even child themes have looks which sometimes need to incorporate fixed or positioning that cannot be set with the current $arguments and it would benefit theme designers to allow those arguments to be passed " frumph 20813 _get_plugin_data_markup_translate fails to load plugin translations I18N 2.9 normal normal Future Release defect (bug) new dev-feedback 2012-06-01T21:22:17Z 2013-05-08T00:49:29Z "Example Plugin: {{{ Plugin Name: XYZ Text Domain: zzz Domain Path: /lang }}} For showing the translated description, _get_plugin_data_markup_translate() will be called. {{{ function _get_plugin_data_markup_translate( $plugin_file, $plugin_data, $markup = true, $translate = true ) { // Translate fields if ( $translate ) { if ( $textdomain = $plugin_data['TextDomain'] ) { if ( $plugin_data['DomainPath'] ) load_plugin_textdomain( $textdomain, false, dirname( $plugin_file ) . $plugin_data['DomainPath'] ); }}} This will call (replaced vars with values): {{{ load_plugin_textdomain( 'zzz', false, ""/full/path/to/plugin/dir/"" . ""lang"" ); }}} But load_plugin_textdomain only accepts the subdirectory ""lang"" as the third argument, leading to an incorrect path since WP_PLUGIN_DIR will be put in front. The fix is to use basename(dirname()) to only get the plugin directory instead of the full path." arnee 20810 Add disable arg or attributes arg to wp_dropdown_categories() & wp_dropdown_pages() Template normal normal Awaiting Review enhancement new 2012-06-01T19:27:07Z 2012-08-17T13:27:36Z "It would be beneficial to be able to add disabled=""disabled"" attribute to the select tag or add multiple attributes to the select tag. Related: #20156, #20167" wpsmith 20793 Illegal string offset 'public' in wpmu_create_blog() Warnings/Notices 3.0 normal normal Future Release defect (bug) new has-patch 2012-05-30T16:18:53Z 2012-05-30T16:18:53Z "If $meta is not passed and left as default empty string then: {{{ update_option( 'blog_public', (int)$meta['public'] ); }}} will throw a notice." duck_ 20791 Add tolerance: 'pointer' option to widgets Widgets 3.3.2 normal normal Awaiting Review feature request reopened dev-feedback 2012-05-30T11:26:20Z 2012-12-15T16:48:03Z "I made a conclusion that it's more easy to sort the widgets in a sidebar if is with tolerance: 'pointer' option enabled... please consider adding this to sortable function of the widgets. " alexvorn2 20790 Add widget_title filter to Links Widget Widgets 3.3.2 normal major Awaiting Review enhancement new dev-feedback 2012-05-30T09:23:29Z 2012-05-30T09:24:39Z "Currently the Links Widget is the only default widget that doesn't support the widget_title filter. This is inconsistent and creates problems when plugin or theme authors want to filter widget titles - every other widget's title get's filtered, but not the Links WIdget. Right now, displaying widget title is basically delegated to the wp_list_bookmarks function. While this works, I suggest that this should be changed to be more consistent with other widgets - displaying widget title should really be the widget class job, not wp_list_bookmarks. It should work with the existing wp_list_bookmarks function by specifying the categorize argument to be false." ragulka 20788 Add widget instance argument to widget_links_args filter Widgets 3.3.2 normal normal Awaiting Review enhancement new dev-feedback 2012-05-30T09:07:13Z 2012-09-13T09:25:07Z "Using the `widget_links_args` filter (used in the default Links Widget class) as it is right now is a bit useless because one does not have access to the widget instance that applies the filter. Widget instance may contain custom variables set by custom fields that may have been added to the widget form by plugins or themes using other filters. Being able to access widget instance from within the filter function gives developers lots of possibilities to customize the widget. My suggestion is simple: add `$instance` argument to the `widget_links_args` filter, like this (wp-includes/default-widget.php line 113): {{{ wp_list_bookmarks(apply_filters('widget_links_args', array( 'title_before' => $before_title, 'title_after' => $after_title, 'category_before' => $before_widget, 'category_after' => $after_widget, 'show_images' => $show_images, 'show_description' => $show_description, 'show_name' => $show_name, 'show_rating' => $show_rating, 'category' => $category, 'class' => 'linkcat widget' ), $instance )); }}}" ragulka 20783 Add filter to wp_unique_term_slug() Taxonomy 3.3.2 normal normal Awaiting Review enhancement new dev-feedback 2012-05-30T02:24:04Z 2012-10-26T21:36:39Z "I can't modify the result of wp_unique_term_slug(), but if using the following code: {{{ function wp_unique_term_slug($slug, $term) { global $wpdb; if ( ! term_exists( $slug ) ) return $slug; // If the taxonomy supports hierarchy and the term has a parent, make the slug unique // by incorporating parent slugs. if ( is_taxonomy_hierarchical($term->taxonomy) && !empty($term->parent) ) { $the_parent = $term->parent; while ( ! empty($the_parent) ) { $parent_term = get_term($the_parent, $term->taxonomy); if ( is_wp_error($parent_term) || empty($parent_term) ) break; $slug .= '-' . $parent_term->slug; if ( ! term_exists( $slug ) ) return $slug; if ( empty($parent_term->parent) ) break; $the_parent = $parent_term->parent; } } // If we didn't get a unique slug, try appending a number to make it unique. if ( !empty($args['term_id']) ) $query = $wpdb->prepare( ""SELECT slug FROM $wpdb->terms WHERE slug = %s AND term_id != %d"", $slug, $args['term_id'] ); else $query = $wpdb->prepare( ""SELECT slug FROM $wpdb->terms WHERE slug = %s"", $slug ); if ( $wpdb->get_var( $query ) ) { $num = 2; do { $alt_slug = $slug . ""-$num""; $num++; $slug_check = $wpdb->get_var( $wpdb->prepare( ""SELECT slug FROM $wpdb->terms WHERE slug = %s"", $alt_slug ) ); } while ( $slug_check ); $slug = $alt_slug; } return apply_filters('unique_term_slug', $slug); } }}} " bolo1988 20779 Recommend a user updates keys/salts in maint/repair.php Security normal normal Future Release enhancement new has-patch 2012-05-29T18:03:19Z 2012-06-27T20:29:33Z "In maint/repair.php, we tell a user they need to add WP_ALLOW_REPAIR. Since they are already going into wp-config.php, we should also encourage them to update their unique phrases for keys and salts, assuming they do not have a complete set of 8 unique ones already." nacin 20774 Flag an user as spam with any rol become a sub site flagged as spam (Multisite) Multisite 3.0 normal major Future Release defect (bug) new has-patch 2012-05-29T12:25:52Z 2012-11-08T21:02:31Z "Hi, Since many weeks, many WangGuard users were contacting me because they say WangGuard were flagging the sub sites as spam. Thats not a WangGuard bug, is a WordPress issue. Steps: - Create a Subsite, you can add the Super Admin like site admin. - Add a user like subscriber. - Flag that user as spam in /network/users.php That site will be flagged as spam although the owner were the Super Admin. I think WordPress has to look for the user rol and only flag the sub site as spam if the rol is Administrator. This issue is in WP 3.3.1 and 3.4" j.conti 20771 esc_url() instead of esc_html() in wp_nonce_url() SergeyBiryukov Formatting 3.4 normal normal Future Release enhancement reopened dev-feedback 2012-05-29T06:21:37Z 2013-03-18T19:44:48Z "The `wp_nonce_url()` function currently uses `esc_html()` in its output, which doesn't really seem to be the appropriate escaping function since it's generating a URL. Attached patch changes the output to use `esc_url()`" jkudish 20770 Introduce AJAX response message Widgets 3.4 normal minor Awaiting Review defect (bug) new has-patch 2012-05-29T02:34:09Z 2012-07-05T23:45:10Z "when clicking on Save button of a widget, a error should appear if the user is logged out. So after clicking the button the wpspin animated images disappears and nothing happens. This can be a problem if the current user think he is logged in and he is not, the settings just will not be saved. Sometimes the server is not working. Need to adjust the javascript code and php: in php we can use die function : die('1') or die('success'); in javascript something like this: {{{ $.post(ajaxurl, data, function(response){ if (response === 'success') {} else { alert('Fail to save'); } }); }}} http://wpimpact.com/wp-content/uploads/2012/05/Untitled-4.png " alexvorn2 20767 tax_query clobbers tag and category Query 3.1 normal major Future Release defect (bug) new has-patch 2012-05-27T21:19:55Z 2013-05-14T13:31:03Z "The main query should return a tag or category as its queried object if tax_query is applied to a tag or category archive page. It currently returns the first term derived from the WP_Query->tax_query->queries array which does not include the tag or category as a term in the request. WP_Query->tax_query->queries is a portion of the request, but not the request. Because WP_Query sets is_tag and is_category flags, they have to be captured before dealing with is_tax The result of this bug is that theme functions return the wrong data because the wrong term is returned with get_queried_object. Real world example: at eMusic, we pass regions into pre_get_posts to regionalize the content that is returned. On a tag page, if you are in the US, we pass the regions ""ALL"" and ""US"" to make sure you are looking at appropriate content. Here's what the title for the archives looks like - (spoiler: It's ""ALL"" when it should be ""Daily Download""): http://www.emusic.com/17dots/topics/daily-download/ I am attaching a patch." wonderboymusic 20748 Include CPT Posts in Author Count & Archive Page General normal normal Awaiting Review enhancement new 2012-05-25T17:59:48Z 2012-05-25T18:07:20Z "For whatever reason, the default behavior is to only count the number of 'post' that an author has published. With the advent of custom post types, they should be included as well if the CPT has the 'author' capability. Currently, the author archive can include CPTs if you manually alter the query - this should be enabled by default if authorship is allowed." iridox 20746 Accessing non-existing theme folder in Network install gives 500 error Multisite 3.3.2 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-05-25T10:28:39Z 2012-11-17T16:17:46Z Accessing non-existing theme folder in Network install gives 500 error and following error in error log: ''Request exceeded the limit of 10 internal redirects due to probable configuration error.'' arkimedia 20745 Hard-code less capability types Role/Capability 3.0 normal normal Awaiting Review defect (bug) new has-patch 2012-05-25T08:48:40Z 2012-05-25T21:33:00Z "We still hard-code some capability types thoughout the admin area. For example `edit_post` is hard-coded as the edit attachment capability in the edit attachment pages. It should be pulled from the post type object instead so that it can be modified. I've patched the ones I found." Viper007Bond 20740 strip_shortcodes Chokes On Empty Shortcodes General 3.3.2 normal minor Awaiting Review defect (bug) new 2012-05-23T22:58:56Z 2012-05-23T22:58:56Z "It appears the regex for strip_shortcodes doesn't recognize empty shortcodes. For example, a caption shortcode like this would only have the opening shortcode tag stripped: {{{ [caption id=""attachment_3360"" width=""288"" caption=""Some caption""][/caption] }}} The closing caption tag remains in the resulting string. I realize this is a fringe case (why would you have an empty caption?), but it popped up for me when working with a popular plugin that attempts to generate an excerpt by doing the following: {{{ $content = strip_tags($content); $content = strip_shortcodes($content); }}} Seems harmless--but if a caption contains only an image tag, the strip_tags removes it, and the strip_shortcodes chokes on the now-empty shortcode. Or even worse, if you have a second caption shortcode in the content, it strips EVERYTHING between the first opening caption tag and the second closing caption tag. And I have to imagine there are some custom shortcodes that may be legitimately empty for some reason. I dunno. To reproduce: {{{ $content = '[caption][/caption] Lorem ipsum dolor sit amet, consectetur adipiscing elit. [caption][/caption]'; $content = strip_shortcodes($content); echo $content; }}} " MathSmath 20739 Improve Excerpt generation for non-english locales I18N 3.4 normal normal Future Release enhancement new 2012-05-23T21:09:45Z 2012-05-30T13:58:18Z "This is a follow on from #16079 to further improve the code. While we improved it in 3.4 we can do a better job to more fully support the customisation for all different locales. For known issues see the comments on the previous ticket." westi 20738 Improve Javascript Word Counting for TinyMCE I18N 3.4 normal normal Future Release enhancement new 2012-05-23T21:07:54Z 2012-05-30T13:57:17Z "This is a follow on from #8759 to further improve the code. While we improved it in 3.4 we can do a better job to more fully support the customisation for all different locales. For know issues see the comments on the previous ticket." westi 20735 Adding tags to form element of categories. Taxonomy 3.3.2 normal normal Awaiting Review feature request new 2012-05-23T13:15:59Z 2012-05-23T13:15:59Z "Just like the post form in posts you can use the hook of ""post_edit_form_tag"" to add new tags to the form element of creating or editing new post. but there is no hook for categories form to do that I think adding new element will be helpful feature. Note: after some debugging I found that the hook can be add in: #File: your wordpress directory/wp-admin/edit-tag-form.php #Line: 33 # Find : # Relpace: > Thanks" m.ibrahim 20733 Theme customizer doesn't order sections based on order added Appearance 3.4 normal normal Future Release defect (bug) new early 2012-05-22T23:36:48Z 2013-01-21T15:16:04Z "When adding sections to the theme customizer, sections with the same priority are given seemingly random order. From the [http://core.trac.wordpress.org/ticket/19910 original customizer ticket]: > Settings and sections both contain priority parameters (you can specify these in the constructor or alter them afterwards) which serve as the primary means of sorting sections before they're rendered. The order settings/sections are added serves as a secondary sorting mechanism (tiebreaker) when multiple items share the same priority. I was under the impression that if the priority was the same, the sections would appear in the order they were added. However, if you add sections A, B, and C (in that order) it seems to display them in order B, C, A. To replicate, add this code to your theme: {{{ add_action( 'customize_register', 'theme_customize_register' ); function theme_customize_register( $wp_customize ) { // Register Section A $wp_customize->add_section( 'theme_section_a', array( 'title' => 'Section A', 'priority' => 35, ) ); $wp_customize->add_setting( 'theme_option_a', array( 'type' => 'option', ) ); $wp_customize->add_control( 'theme_option_a', array( 'section' => 'theme_section_a', 'type' => 'text', ) ); // Register Section B $wp_customize->add_section( 'theme_section_b', array( 'title' => 'Section B', 'priority' => 35, ) ); $wp_customize->add_setting( 'theme_option_b', array( 'type' => 'option', ) ); $wp_customize->add_control( 'theme_option_b', array( 'section' => 'theme_section_b', 'type' => 'text', ) ); // Register Section C $wp_customize->add_section( 'theme_section_c', array( 'title' => 'Section C', 'priority' => 35, ) ); $wp_customize->add_setting( 'theme_option_c', array( 'type' => 'option', ) ); $wp_customize->add_control( 'theme_option_c', array( 'section' => 'theme_section_c', 'type' => 'text', ) ); } }}} '''Expected result:''' Sections show up in order A, B, C '''Actual result:''' Sections show up in order B, C, A Sorry if I'm doing something stupid, or if this isn't the intended functionality. I'm running trunk without any plugins." andyadams 20730 make function wp_list_categories rewritable for templates (File: category-template.php) Template normal normal Awaiting Review feature request new 2012-05-22T17:34:02Z 2012-05-22T17:36:35Z "Inserting {{{ $list_categories_template = locate_template(array('listcategories.php')); if ( '' != $list_categories_template ) { require($list_categories_template); return; } }}} under {{{ function wp_list_categories( $args = '' ) { }}} " wpuser12584 20729 Improve Admin Colors CSS enqueuing Appearance 3.1 normal normal Future Release defect (bug) new early 2012-05-22T17:19:58Z 2012-05-22T17:20:17Z "The hacky way in which we enqueue the admin colors css means that you get different ordering of the CSS between the development version of the scripts and the script-loader sourced version of the scripts. This can cause CSS bugs which don't show when developing but do when running with the script loader - e.g. #16827 It also makes it harder to implement a custom css concatenator. We should do something like - http://core.trac.wordpress.org/attachment/ticket/16827/colors-hacked-fixed.diff To make this properly enqueue the styles. We should also make this kind of call fire a {{{_doing_it_wrong()}}} as {{{true}}} is not a url :) {{{ $styles->add( 'colors', true, array('wp-admin') ); }}} This code harks back from [7976]" westi 20725 Media library inconsistency General 3.3.2 normal normal Awaiting Review enhancement new 2012-05-22T10:26:45Z 2012-05-22T10:26:45Z "I need to put extra filters using restrict_manage_posts to Media library and i have noticed, that my filters did not appear on Media library iframe, opened when adding new media in post. It is handled with wp-admin/includes/media.php via media_upload_library_form function, which seems to be very old comparing to media library in class-wp-media-list-table e.g. it does not use $this->months_dropdown( 'attachment' ); but wrotes 25 rows of code which do the same. IMO it could be migrated to the new code also it misses the do_action( 'restrict_manage_posts' ); line, which is important for my desired functionality (when i hardcode it there, it works)" thomask 20720 attachment_fields_to_save filter is called twice after initial image upload in post Media 3.3 normal normal Awaiting Review defect (bug) new has-patch 2012-05-21T16:18:41Z 2012-05-22T00:12:20Z "I believe I found a bug in WordPress with the attachment_fields_to_save filter. For some reason attachment_fields_to_save is called twice per image, but only if you ""Save all changes"" after uploading a new image to a post. How to reproduce: 1. Add the below code to a plugin: {{{ add_filter( 'attachment_fields_to_save', 'test_attachment_fields_to_save', 10, 2 ); function test_attachment_fields_to_save( $post, $attachment ) { echo 'Hi! '; return $post; } }}} 2. Create a new post 3. Upload a single image and click ""Save all changes"" You'll see ""Hi!"" displayed twice. Now visit the Gallery tab and save the same image and you'll see ""Hi!"" is only displayed once. This only happens when you save a new image uploaded to a post. If you save an image under the Gallery tab, or via the Media Library, the filter is only called once as expected. I confirmed this is happening in 3.3.1 and trunk" williamsba1 20717 Filter For Requiring Post Password Template normal normal Awaiting Review enhancement new has-patch 2012-05-21T03:37:43Z 2012-07-26T17:24:39Z "I've had the need to conditionally disable the password on a post based on criteria that I define in a plugin. In order to do this, I added a filter in the post_password_required() function in wp-includes/post-template.php. This is helpful to allow search engines to crawl password protected pages or allow certain users to view the page without typing in the password. It would be great if this could get included in the core. Thanks for your time." BrandonGodwin 20716 Control how and when request_filesystem_credentials outputs creds form Filesystem 3.4 normal normal Awaiting Review enhancement new reporter-feedback 2012-05-21T02:02:08Z 2012-05-21T02:05:10Z "When using WP_Filesystem in a plugin or other external app, you can initialize it this way: {{{ if ( false == ( $creds = request_filesystem_credentials( $url, $method, false, false, $form_fields ) ) ) { return true; } }}} Makes sense. If the method isn't direct or we don't have the credentials we need, `request_filesystem_credentials` outputs a form and returns false. Then we check again to make sure the credentials can be verified, and it not, we continue to output the form until the credentials are good. {{{ if ( ! WP_Filesystem( $creds ) ) { request_filesystem_credentials( $url, $method, true, false, $form_fields ); return true; } }}} `request_filesystem_credentials` arbitrarily outputs the form whether you want it to or not, unless you explicitly filter the `request_filesystem_credentials` function itself. Using this in conjunction with Ajax, you have to use output buffering to catch the output and return it to the Ajax script for processing or else you get errors. This definitely isn't ideal. I'd suggest storing the form in a variable and possibly pass a parameter that determines whether or not we want to actually output the form or not. Or, if there is another (better) way, that's cool too. Just some way to help `request_filesystem_credentials` determine how we want to interact with credentials should we need them. " griffinjt 20714 Theme customizer: Impossible to preview a search results page Themes 3.4 normal normal Awaiting Review enhancement new 2012-05-20T19:20:30Z 2012-05-24T06:57:40Z "Steps to reproduce: 1. Open the theme customizer 2. Attempt to do a search in the site's search box in order to preview the search results page The form won't submit and you won't be able to preview your search results." johnbillion 20712 "Wrong data type returned from get_option for ""page_on_front"" after update_option" General 3.3.2 normal normal Awaiting Review defect (bug) new has-patch 2012-05-20T08:29:35Z 2012-10-15T10:22:59Z " {{{ echo gettype(get_option(""page_on_front"")); // return string update_option(""page_on_front"", ""123""); echo gettype(get_option(""page_on_front"")); // return integer }}} You can repeat the steps and it give consistent result, so `get_option` return the wrong data type ONLY when it is after `update_option`" tszming 20706 Adding a link without a name or web address yields no (error) feedback General normal minor Awaiting Review enhancement new dev-feedback 2012-05-19T00:42:57Z 2012-05-20T16:12:51Z "If a user successfully creates a link (on link-add.php), the user receives the message ""Link added."" However, there are no measures taken to notify the user if the link was ''not'' successfully added. Links are not added when the link name and web address fields are left blank, so I have included a little patch to let the user know when this occurs. This could be done with some JavaScript form validation that makes an alert box pop up, but half the (PHP/HTML) code was already present for this, and I think it looks better this way, personally. This is my first attempt at submitting a patch to any open source project, so I appreciate your feedback. Thanks!" AVReidy 20690 add_post_meta/update_post_meta and cache General 3.3.2 normal normal Awaiting Review defect (bug) new 2012-05-16T14:33:30Z 2012-05-16T14:33:30Z "I have a custom post type with 2 fields for price, second one has 5% discount and I want to populate it automatically by hooking to 'save_post'. I have a working logic that calls update_post_meta() (or add_post_meta() ) for the second field but it doesn't get executed even with several post updates. However, if I end my function call with a var_dump that outputs the values from the function, everything goes smooth. It looks like some caching issue to me that gets flushed per var_dump call, anyone able to reproduce?" nofearinc 20688 Forward slash in custom taxonomy rewrite causes 404s because of (unnecessary?) attachment rule Rewrite Rules 3.3.2 normal normal Awaiting Review defect (bug) new 2012-05-16T09:07:57Z 2012-05-16T11:54:34Z "I implement a custom taxonomy with a rewrite that is designed to create urls like: ""/apps/about/sometag"" {{{ $name = 'apps'; register_taxonomy($name.'-tag', $name.'-post', array( 'label' => ucfirst($name) . ' Tags', 'public' => true, 'has_archive' => true, 'hierarchical' => false, 'update_count_callback' => '_update_post_term_count', 'rewrite' => array('slug' => ""$name/about"", with_front=>true) )); }}} However I was getting a 404 (yes I was flushing the rules) unless I changed the '/' to say a '-'. Upon inspection of the rules, I found this one whose precedence was causing the problem: {{{ 'apps/[^/]+/([^/]+)/?$' => 'index.php?attachment=$matches[1]' }}} Upon removing it inside the ""rewrite_rules_array"" hook, the problem was solved. It seems odd to me that this generic rule exists and rewrites to an attachment of all things..." harikaram 20683 WP_Dependencies' constructor should accept a string/array value for $deps rather than converting a string to an empty array markjaquith General normal normal Awaiting Review enhancement reopened has-patch 2012-05-15T20:12:39Z 2013-04-23T12:42:14Z "Currently, WP_Dependencies' constructor takes any $deps value that's not an array and converts it to an empty array. I propose bringing the constructor's behavior more in line with standard WP function paramater behavior by accepting a string as a single dependency. Essentially this involves adding an is_string() check on $deps before checking if it's not an array, and creating an array with a single element in the case that it is a string. {{{ if ( !is_array($this->deps) ) $this->deps = array(); }}} becomes {{{ if ( is_string( $this->deps ) ) $this->deps = (array) $this->deps; elseif ( !is_array( $this->deps ) ) $this->deps = array(); }}} See the attached diff for a proposed patch." vhauri 20672 Mime-Type Matching Error With Certain Added Mime-Types Media 3.0 normal normal Awaiting Review defect (bug) new has-patch 2012-05-14T09:50:10Z 2012-05-14T11:11:54Z "I think I've found a bug in the handling of post_mime_types with certain legitimate file MIMEs. My suspicion is that the problem is related or similar to that reported in [http://core.trac.wordpress.org/ticket/17855 #Ticket #17855], and apparently fixed in Wordpress v3.2. The particular problem I've been experiencing only becomes apparent when adding MIME-types to the $post_mime_types array via the ''post_mime_types'' filter hook. For example, the following is a legitimate MIME-type: ''application/vnd.google-earth.kml+xml'' However, if I add the MIME to post_mime_types array with: {{{ function kml_modify_post_mime_types( $post_mime_types ) { $post_mime_types['application/vnd.google-earth.kml+xml'] = array(__('KML'), __('Manage KML'), _n_noop('KML (%s)', 'KML (%s)')); return $post_mime_types; } add_filter( 'post_mime_types', 'kml_modify_post_mime_types' ); }}} in my plugin, I don't see a filter link at the top of the Media list (like the ones for Video, Audio etc.), as I should do. I may be wrong, but I think this is because the '+' character in the attachment MIME-type is not handled correctly. To test this, I tried faking a new MIME, minus the '+'. I changed the MIME-type my plugin add to the post_mime_types array to {{{ $post_mime_types['application/vnd.google-earth.kmlxml'] = array(__('KML'), __('Manage KML'), _n_noop('KML (%s)', 'KML (%s)')); }}} then changed the value in the MIME field of a previously-uploaded KML file to the same (''application/vnd.google-earth.kmlxml''). Now I DO see the filter link, and clicking on the link reveals the KML file as the only item in the filtered list, as it should. I'm not sure if the problem manifests itself anywhere else. I've not found any evidence it does, but it may well do. From doing some multi-file searches on the WP system files, my suspicion is that the problem is with one or both of the following functions in post.php: * wp_match_mime_types() * wp_post_mime_type_where() but I'm really not sure. I'd be grateful if a more skilled coder than me could confirm if this is actually a bug. I'm afraid my regular-expression understanding is minimal, but I suspect this might be an easy fix for someone who knows their stuff. I'm more than happy to run any tests anyone might suggest to help pin down the source of the problem and/or help fix it. Thanks guys. a|x" toneburst 20663 add_image_size needs a $label Media 3.3.2 normal normal Awaiting Review enhancement new 2012-05-12T20:47:31Z 2012-05-21T00:05:59Z "add_image_size() does not have a $label parameter, this effects both localization but more importantly limits the `image_size_names_choose` filter. The is when you try to add an image to a post and you can select sizes via the radio buttons. Default sizes have labels like: `'large' => __('Large')` the `image_size_names_choose` filter is a great new filter that allows you to alter those radio buttons, but requires you to hardcore the array values for add_image_size() since it does not have a label (unless I'm missing something). Reference code: https://gist.github.com/2668630 Related: #19990" wycks 20662 private post can be sticky via quickedit XML-RPC 3.4 normal normal Awaiting Review enhancement new dev-feedback 2012-05-12T08:37:27Z 2012-06-24T22:13:17Z "While preparing translations to 3.4 I came across http://core.trac.wordpress.org/browser/trunk/wp-includes/class-wp-xmlrpc-server.php#L908 This indicates that a private post cannot be marked as sticky. - however it is quite possible to mark a private post as sticky while using quickedit. Solution proposal, remove sticky tickbox on quickedit if post is private. Or if this is only related to the XMLRPC, fix the returnmessage to a warning ""a private post will only be visible to you, so sticky might not make any sense"". I'm thinking.. ""either its possible or its not, the logic should be the same"" " maxemil 20661 Add help text for search usage in Multisite User browsing Help/About normal normal Awaiting Review enhancement new has-patch 2012-05-11T18:32:34Z 2012-05-12T04:40:21Z "Search on the Network Users page defaults to wildcards disabled by default. This may not be expected functionality by a lot of end users, so I think some notes on how to use search should help. Related: #20135" ericlewis 20660 wp_get_attachment_url() ignores filter for unrecognized IDs General 3.3.2 normal minor Awaiting Review feature request new 2012-05-11T16:49:29Z 2012-05-11T20:54:53Z "wp_get_attachment_url() fails to invoke its filters when it encounters an unrecognized post ID. It would be helpful to allow a filter to deal with the situation. The plugin NextGEN Gallery uses image IDs like ""ngg-1"", while WP's image IDs are integers. A filter could deal with the situation. wp_get_attachment_url() begins like this: {{{ $post_id = (int) $post_id; if ( !$post =& get_post( $post_id ) ) return false; }}} Obviously, a nonstandard post ID will ignore the filters. If the filters were invoked, nonstandard IDs can be dealt with as desired by themes or plugins. The filter should be given a ""false"" value instead of $url, and the original $post_id value (before forcing to (int)). If existing filters are already dealing with null or empty URLs, they can handle this situation. Suggestion: {{{ $post_id_original = $post_id; $post_id = (int) $post_id; if ( !$post =& get_post( $post_id ) ) $url = apply_filters( 'wp_get_attachment_url', false, $post_id_original ); if ( empty( $url ) ) return false; return $url; }}} " RoamFree 20659 Document available shortcodes in eg. new post page Shortcodes normal normal Awaiting Review feature request new 2012-05-11T14:40:28Z 2012-05-22T12:40:35Z "It would be useful if a plugin defining shortcodes also could describe the usecase for the shortcode and the available attributes and the usecases for those attributes in a way that could be exposed in the interface on eg. the new post page. One could take inspiration from eg. the Drupal Token module which has a token_list() hook that a Drupal module uses to describe every token it describes so that they can be presented to the user in the interface. Something like: {{{ add_shortcode_description('shortcodename') }}} That returns something like this would be nice: {{{ array( 'description' => 'This is used to do foo', 'attr' => array( 'bar' => 'A text that will be presented as bar' ), ); }}}" voxpelli 20651 Inconsistent MS API: delete_site_option action hook is only called AFTER deletion, unlike delete_option Multisite 3.3.2 normal normal Awaiting Review enhancement new dev-feedback 2012-05-10T09:54:37Z 2012-05-11T16:30:39Z "Unlike the delete_option action hook, the delete_site_option action hook is only called AFTER deletion of the row from the sitemeta table - making it difficult to capture the expiring value (for instance), unless you know its precise option key name ( and hook it using pre_delete_site_option_{$option} ). Suggest introducing a pre-deletion, non-specific action hook call named ""pre_delete_option"" for options and ""pre_delete_site_option"" for site options, for consistency." danielnashnz 20635 _pad_term_count get's stuck if there is a loop in the hierarchy westi* Taxonomy normal normal Future Release defect (bug) accepted has-patch 2012-05-08T10:31:37Z 2012-12-06T22:51:42Z "Ideally it should be impossible for a loop in a taxonomy hierarchy to exist. But sometimes they do. If one does exist then {{{_pad_term_counts()}}} gets stuck :( When one of these does exist the category widget breaks the front page of your site. We currently hook {{{wp_check_term_hierarchy_for_loops}}} on {{{wp_update_term_parent}}} and I wonder if there are other places we should be doing this check too." westi 20634 dbDelta is unforgiving about field declarations Database 1.5 normal minor Awaiting Review enhancement new has-patch 2012-05-08T03:27:05Z 2012-05-24T07:31:40Z "the variable type is case sensitive: int(22) != INT(22) the mysql type BOOL or BOOLEAN comes back from the db as tinyint(1): tinyint(1) != BOOLEAN Not a huge issue, just annoying. Makes dbDelta fire off unnecessary sql. " SidHarrell 20631 Add ability to add Contextual Help to the Theme Customizer Themes 3.4 normal normal Awaiting Review enhancement new 2012-05-07T20:11:39Z 2012-05-07T20:55:18Z While this is probably more complicated than I realize, it would be good to add the ability for contextual help in the admin side of the Theme Customizer. This would enable explanations of the various core features as well as any additional custom features by theme developers. wpsmith 20630 XML-RPC Extending documentation for methods called with a single param XML-RPC normal normal Awaiting Review defect (bug) new needs-docs 2012-05-07T18:47:46Z 2012-05-07T19:06:01Z "When an XML-RPC method is called with a single parameter, the method will receive the value directly instead of receiving an array with a single value. This seems to be intended, though unexpected, behavior. The documentation should be updated to mention this. The related code is inside IXR_Server->call()." scott.gonzalez 20620 create redirect_media_location filter in media.php Media normal normal Awaiting Review enhancement new 2012-05-06T07:54:09Z 2012-05-06T07:54:09Z Similar to the post.php redirect_post_location filter, media.php could use a redirect_media_location filter. This is useful for plugins that want to edit an attachement and redirect back to a specific place. Sjeiti 20615 Unknown error when running plugins_api() with invalid slug WordPress.org site normal normal WordPress.org defect (bug) new 2012-05-05T14:59:07Z 2012-05-05T15:40:35Z "Input: {{{ $api = plugins_api( 'plugin_information', array( 'slug' => 'doesnt-exist' ) ); var_dump( $api ); }}} Expected result: {{{ WP_Error Object ( [errors] => Array ( [invalid_slug] => Array ( [0] => Invalid plugin slug. ) ) [error_data] => Array ( [invalid_slug] => 404; ) ) }}} Actual result: {{{ WP_Error Object ( [errors] => Array ( [plugins_api_failed] => Array ( [0] => An unknown error occurred during the API request. ) ) [error_data] => Array ( [plugins_api_failed] => N; ) ) }}} PS: I have no idea what that 'N' is supposed to represent." scribu 20609 tags in Editor not working on editing with wp_editor, wenn disabling media_buttons or quicktags Editor normal normal Awaiting Review defect (bug) new 2012-05-03T16:36:01Z 2012-05-05T01:01:57Z "When disabling the media_buttons or quicktags via the third argument in wp_editor via a settings array, tags are not displayed any more, so there are no line breaks any more in the editor. Only "" "" is in the source code. The Problem also occurs, when changing 'quicktags' or 'media_buttons' in class-wp-editor.php in the core to false. wpautop is still true. " julian42 20606 orderby rand param does not work with either WP_User_Query or get_users Users 3.2.1 normal normal Awaiting Review feature request new 2012-05-02T22:12:34Z 2012-05-15T19:20:21Z "Using WordPress 3.2.1 {{{ $contributors = get_users(array('role' => 'contributor', 'orderby' => 'rand', 'number' => 3)); }}} {{{ $wp_user_search = new WP_User_Query(array('role' => 'contributor', 'orderby' => 'rand', 'number' => 3)); $contributors = $wp_user_search->get_results(); }}}" kjmeath 20602 Replace media Media 3.3.1 normal major Awaiting Review enhancement new dev-feedback 2012-05-02T13:29:45Z 2012-05-02T17:55:33Z "I have been developing themes for clients lately that require the same image across the theme in varying places. A good example is an event site where the image is a badge/sticker showing the price of the tickets. This gets output on various pages in varying locations. get_attachment_link is perfect as I can plugin a single ID and use the graphic wherever. However, the ticket prices change as the event gets closer and the graphic needs to be updated which breaks the theme in production when my client does so as a new ID is generated. This doesn't make too much sense to me. I've worked with and developed CMSs of all kinds and usually the ID is preserved. I would at least like the option, perhaps a checkbox, to indicate I want to reupload a new image. I think it's more common that an update on a media item would be to modify the same logical graphic rather than just replacing it with something entirely new. I found the following plugin but I feel this really ought to be core. http://wordpress.org/extend/plugins/enable-media-replace/ Thanks for your consideration." PorridgeBear 20601 Author archives queries should return a 404 when the user isn't a member of the blog Template normal normal Future Release defect (bug) new has-patch 2012-05-02T09:53:43Z 2012-11-18T02:05:51Z "On a multi site install, querying for the author page for a user that is not a member of that blog, still returns a valid page, instead of a 404. Example: User crazygeorge is a member of of blog1 but not a member of blog2 The url http://example.com/blog2/author/crazygeorge/ will return the author template with a no posts found message. Insead, we should ignore users that are not member of a specific blog, and return a proper 404. " yoavf 20597 Allow WP_Comment_Query::query to filter by category Comments 3.4 normal normal Awaiting Review enhancement new has-patch 2012-05-02T03:35:35Z 2012-05-02T03:45:58Z "The attached patch allows WP_Comment_Query::query to accept three additional arguments: * `cat` * `category__in` * `category__not_in` The resulting comments are then filtered by these category arguments as well as any other arguments. These arguments work the same way as their `WP_Query` counterparts. I would appreciate advice on the appropriateness of using `INNER JOIN` (as I have done here) to join in the taxonomy tables to the query." sambauers 20596 Adding more actions to a widget Widgets normal normal Awaiting Review feature request new dev-feedback 2012-05-02T00:14:28Z 2012-05-02T05:45:48Z "On the Widget UI, there is a ""Close"" button, aside with the ""Delete"" button, and I that developers should have a way to add more of those. For exemple, I would see as a good use case when you have a way of previewing the widget. Because right now the only way is by JS which is kinda of lame. Thanks," webord 20595 Collapsible Admin menu fails if items are added by code Administration 3.3.1 normal normal Awaiting Review defect (bug) new dev-feedback 2012-05-01T23:27:42Z 2012-05-02T07:48:13Z "If I add a Button to the admin meny by '''action adminmenu''' the menu wont rebuid from collapsed state due z-index issues. In my opinion creating the menue might be changed to the following: {{{ diff --git a/wp-admin/menu-header.php b/wp-admin/menu-header.php index cdd81b2..8454a3d 100644 --- a/wp-admin/menu-header.php +++ b/wp-admin/menu-header.php @@ -164,10 +164,6 @@ function _wp_menu_output( $menu, $submenu, $submenu_as_parent = true ) { } echo """"; } - - echo ''; - echo '' . esc_html__( 'Collapse menu' ) . ''; - echo ''; } ?> @@ -181,6 +177,9 @@ function _wp_menu_output( $menu, $submenu, $submenu_as_parent = true ) { _wp_menu_output( $menu, $submenu ); do_action( 'adminmenu' ); +echo ''; +echo '' . esc_html__( 'Collapse menu' ) . ''; +echo ''; ?> }}} see also: http://wordpress.org/support/topic/admin-menu-wont-dis-collapse-anymore" digitaldonkey 20592 Add hooks to New Site form in Dashboard Multisite normal normal Awaiting Review enhancement new 2012-05-01T18:53:16Z 2012-07-20T19:03:02Z "WordPress provides hooks for altering the wp-signup.php form that users use to create new sites on a MultiSite network. Using these, we developed a plugin that adds fields there for people to indicate some other information about their site. (specifically, to choose a topic) However, there are no such hooks available on the New Site form available to network admins via the dashboard for some reason. This means that I am not able to append the extra form fields here that I can on the wp-signup.php page. There should be similar (or identical) hooks used here so the New Site form can be modified in a similar way and be consistent with the wp-signup.php form." MadtownLems 20589 domain_exists should add trailing slash to path Multisite 3.0 normal minor Awaiting Review defect (bug) new has-patch 2012-05-01T16:49:18Z 2012-07-03T00:36:37Z {{{insert_blog}}} runs {{{trailingslashit}}} on the path, however, {{{domain_exists}}} uses whatever is passed in. If WP is enforcing the trailing slash on blog insertion, it really should when checking existence. It should probably also cast the site_id as an int per {{{insert_blog}}}. ejdanderson 20578 Allow users to delete a plugin without uninstalling Plugins normal normal Awaiting Review enhancement new dev-feedback 2012-05-01T01:18:35Z 2012-06-15T21:30:27Z Sometimes, a user may need to delete plugin files without deleting all the plugin data. scribu 20571 problems with slug and view in custom post types Post Types 3.3.1 normal minor Awaiting Review defect (bug) new 2012-04-29T23:27:56Z 2012-04-30T06:39:19Z "when creating custom post type, there are 2 minor problems 1. when setting rewrite to false, it is not possible to edit slug (edit button missing) - this is wrong as slug is needed e.g. for get_post queries by name 2. if the post is set '''not''' publicly_queryable, then anyway the post edit screen shows ""View [custom post name]"" and ""Preview"" button, which then points to 404 screen. " thomask 20570 Tidying Admin CSS, bringing it up to CSS Code Standards (work in progress) Administration 3.4 normal minor Awaiting Review enhancement new 2012-04-29T16:24:09Z 2012-12-24T11:27:12Z "as per http://codex.wordpress.org/CSS_Coding_Standards, this is an attempt to bring the internal admin stylesheets up to CSS Coding Standards Some of the changes being made are ... * Properly intenting top: left: right: bottom: attributes two tabs when following a position:absolute position:fixed or position:relative declaration * Alphabetizing css properties * Removing unnecessary browser prefixes * Placing browser prefixed css properties before the non-browser prefixed versions * Removing extraneous spaces * Applying a consistent ordering of browser-prefixed properties (based on length of prefix to get an aesthetically pleasing diagonal line, rather than jagged, inconsistent line endings -- yes, I know it's silly, but it's better than randomness, and alphabetical isn't as useful) * Applying a uniform method to attribute selectors and url references by wrapping double-quotes around the values (there was no prior standard and a motley assortment of usages) * Changing colors to 3-character shorthand ( 888888 becomes 888 ) * Changing colors to lower case ( EEE becomes eee ) and probably a couple others that aren't coming to mind right now." georgestephanis 20569 We need addslashes_deep() General 3.4 normal major Future Release defect (bug) new has-patch 2012-04-29T08:08:28Z 2012-09-02T03:15:55Z " I don't imagine anyone still feels that having `update_metadata()` call `stripslashes_deep()` is still the Right Thing to do, but I understand why removing it is basically impossible for backward compatibility reasons. That said, !WordPress as a platform does not currently provide a way for this data to be stored accurately as a meta value: {{{ $data = array( 'Check me out, I have backslashes \\' ); update_post_meta($post->ID, 'my_key', $data); }}} I'm not saying that this is a great deal better from a code purity standpoint: {{{ $data = array( 'Check me out, I have backslashes \\' ); update_post_meta($post->ID, 'my_key', addslashes_deep($data)); }}} but it's at least explainable. Telling people they have to do something like this: {{{ $data = array( 'Check me out, I have backslashes \\' ); $slashed_data = array(); foreach ($data as $item) { $slashed_data[] = addslashes($item); } update_post_meta($post->ID, 'my_key', $slashed_data); }}} or this: {{{ if (!function_exists('addslashes_deep')) { /** * Navigates through an array and adds slashes to the values. * * If an array is passed, the array_map() function causes a callback to pass the * value back to the function. Slashes will be added to this value. * * @since 3.4.0? (oh please, oh please, oh please) * * @param array|string $value The array or string to be slashed. * @return array|string Slashed array (or string in the callback). */ function addslashes_deep($value) { if ( is_array($value) ) { $value = array_map('addslashes_deep', $value); } elseif ( is_object($value) ) { $vars = get_object_vars( $value ); foreach ($vars as $key=>$data) { $value->{$key} = addslashes_deep( $data ); } } else { $value = addslashes($value); } return $value; } } $data = array( 'Check me out, I have backslashes \\' ); update_post_meta($post->ID, 'my_key', addslashes_deep($data)); }}} is just indefensible. FWIW, @rboren created this function as [http://core.trac.wordpress.org/attachment/ticket/12402/12402.2.diff part of a patch] a couple of years back (#12402), but it hasn't landed yet. Pretty please can we get just this bit in for 3.4?" alexkingorg 20563 Add actions between sections in User Edit form Plugins 3.4 normal normal Awaiting Review enhancement new 2012-04-27T22:20:08Z 2012-06-12T23:45:44Z "Currently there is only one hookable area in the User Edit to cleanly output additional fields: 'edit_user_profile' / 'show_user_profile' I suggest we add another set just before each of the H3 tags on this page (/wp-admin/user-edit.php). Above Personal Options: {{{ }}} Above Name: {{{ }}} Above Contact Info: {{{ }}} Above About: {{{ }}} For hooking into the save, I believe the existing action 'user_profile_update_errors' will suffice, though I'm not sure if that's the best name for having developers hook into for adding their own field and this runs after error checking.. So we could also add an action before error checking runs to allow for more extensibility to modify existing fields being saved there (letting you still use WP built-in error handling). This would be added around line 130 in /wp-admin/includes/user.php: {{{ // Allow plugins to modify user fields before error handling do_action_ref_array( 'user_profile_update', array ( &$user, $update ) ); $errors = new WP_Error(); }}}" sc0ttkclark 20560 url_to_postid() string matching is not strict enough, can lead to incorrect results Query 3.0 normal normal Future Release defect (bug) new has-patch 2012-04-27T19:01:40Z 2012-11-08T20:59:11Z "I have been working on a plugin that uses url_to_postid() to automatically translate user generated links to internal links utilizing post ID in order to protect against potential permalink changes. A bug was reported that involved a link to an external location being translated to an internal link (with post ID) by the plugin. The current site: http://www.example.com/test The attempted link: http://www.example.com/test-research Where test-research is an entirely different site on our multi-site install. Upon investigation, the source of the problem was an overly generous strpos() check in url_to_postid(), starting at line 322: {{{ if ( false !== strpos($url, home_url()) ) { // Chop off http://domain.com $url = str_replace(home_url(), '', $url); } else { // Chop off /path/to/blog $home_path = parse_url(home_url()); $home_path = isset( $home_path['path'] ) ? $home_path['path'] : '' ; $url = str_replace($home_path, '', $url); } }}} As home_url() does not append a trailing slash, the link passed that check and was incorrectly processed. The logic inside that if block resulted in -research being passed as a pagename to WP_Query, which happened to turn up a matching post ID on this particular site. I have a proposed patch, which I will attach to this ticket asap." gradyetc 20558 allow wp_localize_script data to be added to existing objects Performance 3.3 normal minor Awaiting Review enhancement new dev-feedback 2012-04-27T16:44:03Z 2012-04-30T05:50:36Z "Re: WP_Scripts::localize() located in wp-includes/class.wp-scripts.php Currently when `WP_Scripts::localize()` handles the printing of wp_localize_script data to JavaScript, it starts the string with a `var` declaration, like this: {{{ $script = ""var $object_name = "" . json_encode($l10n) . ';'; }}} Because this is printed in the global scope, it becomes a global variable regardless of whether it's preceded by `var`. As far as JavaScript is concerned the above string would be equivalent to: {{{ $script = $object_name . ' = ' . json_encode($l10n) . ';'; }}} or {{{ $script = 'this.' . $object_name . ' = ' . json_encode($l10n) . ';'; }}} or {{{ $script = 'window.' . $object_name . ' = ' . json_encode($l10n) . ';'; }}} But I suppose it's possible thru hooks to make it so that the localization data prints outside of the global scope, in which case you might want the `var` to be there (if it we're wrapped in a closure). So I think the '''overall best solution''' would to check if the `$object_name` contains a period `.` character. If it does, omit the `var`. In other words, make it so that: {{{ wp_localize_script('myplugin', 'myPluginData', $object ) }}} would print: {{{ var myPluginData = {...}; }}} but that: {{{ `wp_localize_script('myplugin', 'myPlugin.data', $object )` }}} would print: {{{ myPlugin.data = {...}; }}} By default the localization data runs before any enqueued scripts, in which case `myPlugin` would not yet be defined, but we should leave that for the JavaScript dev work out. My point is that the flexiblity should be there. Another route would be to apply a filter on that line but I don't think a filter is necessary if the above change is made." ryanve 20547 Ability to define post attachment status on insertion Media 3.4 normal normal Awaiting Review enhancement new dev-feedback 2012-04-25T20:57:48Z 2012-04-25T20:57:48Z "By default, `wp_insert_attachment` will either set a new attachment as 'inherited' or 'private' - inherited being that it simply mimics the post status of its parent. This is fine by default, but what about when wanting to run tests? For example, you have a live post that you want to add attachments to, but you want to ensure that the attachments (whatever they may be) are properly formatted before making them appear on your live post. By default, just uploading the attachment will push it live because it has inherited the published status of its parent. Is this doable? What about filtering `$object` in the `wp_parse_args` function inside `wp_insert_attachment` to allow that property (along with the others - it makes sense to be able to filter them all) to be set? Don't know how feasible it is, but if it's possible I'll work on a patch and tests." griffinjt 20545 TinyMCE - Edit/Delete Image Buttons Show For Non-editable Items TinyMCE 3.3.1 normal normal Awaiting Review defect (bug) new 2012-04-25T15:09:10Z 2012-04-25T15:09:10Z "Forgive me if this has already been reported and/or fixed in 3.4. I've yet to have a chance to try out the BETA. The wpEditImage plugin creates Edit and Delete buttons for every image on selection. There are several instances where images need to be used as content placeholders like in the instance of the tag and [gallery] shortcode. The plugin provides a special class ""mceItem"" which prevents these image editing buttons from appearing on any image with the class. However, the class apparently isn't checked in all the places it needs to be because you can make these image editing buttons appear even when they're not supposed to. These even occurs in the case of the [gallery] shortcode which has it's own Edit/Delete buttons. If you use one of these hacks, you can actually make the Edit/Delete ""Image"" buttons appear over the gallery-specific ones. Here are a few examples and attached are some screenshots: 1. '''Firefox 11''' Even if an image uses the mceItemNoResize, the resize handles will still appear on hover. If you try to drag these handles, the image doesn't resize (as it shouldn't) but the Edit/Delete image buttons do appear. ''See Firefox Screenshot Suite'' 2. '''IE 9''' Insert a [gallery] and hover your mouse just below an image until the ""text editor cursor"" appears. Simply click and the Edit/Delete image buttons will appear. You can differentiate these buttons from the Edit/Delete gallery buttons by hovering your mouse over them to read their title text. Unfortunately, I could not get a good screenshot of this. Note: I could not get this error to occur on Safari or Opera." Master Jake 20544 WordPress MultiSite/Network SiteURL error Network Admin 3.3.1 normal normal Awaiting Review defect (bug) new reporter-feedback 2012-04-25T14:24:07Z 2012-11-20T11:49:45Z "In the Network Admin -> Sites -> Edit Sites -> Info Domain is set to: swordstudios.net Path is set to: /helpdawson/ I am using Domain Mapping to mask this site with http://helpdawson.com however I wanted the admin and location of files to be http://helpdawson.com/wp-admin and /files... not http://swordstudios.net/helpdawson/wp-admin I changed the Domain to helpdawson.com and removed everything from the path and checked off ""Update siteurl and home as well."" When I hit submit the Domain field in the Info tab was correctly set to helpdawson.com but the site was redirecting to comhelpdawson. which obviously returned an error. When I went to Edit Site -> Settings I saw that the siteurul and home were set to http://comhelpdawson/ I changed everything back to the swordstudios.net/helpdawson and did the whole process over again and was able to duplicate the problem. [[Image(http://swordstudios.net/wp-content/uploads/2012/04/siteurl-bug.png)]][[Image(http://swordstudios.net/wp-content/uploads/2012/04/siteurl-bug2.png)]][[Image(http://swordstudios.net/wp-content/uploads/2012/04/siteurl-bug3.png)]][[Image(http://swordstudios.net/wp-content/uploads/2012/04/siteurl-bug4.png)]]" professor44 20542 Extend register_widget to allow passing params as second argument codearachnid Widgets 3.4 normal normal Future Release enhancement new 2012-04-25T11:56:19Z 2012-05-15T20:24:50Z "I ran into an issue recently where I needed to make multiple calls of `register_widget('my_custom_class');` on the same class and have multiple unique widgets registered. The problem I ran into is that every time the same class is called it will overwrite the last instance of the same class during the widget constructor request `parent::__construct('unique_id', 'widget title');` This does not allow for reuse of the same class to instantiate multiple widgets. I found that if I were to extend the register method in WP_Widget_Factory to pass through arguments into the extended WP_Widget constructor that I can reuse the same class for multiple widget registations. I am working out the logic to implement this directly into /wp-includes/widgets.php for future functionality improvement." codearachnid 20537 Don't spawn cron requests for suspended blogs Cron 3.3.1 normal normal Future Release defect (bug) new dev-feedback 2012-04-24T20:40:19Z 2012-09-17T06:54:10Z " {{{ }}} For multisite, spawning cron requests is wasteful and unnecessary. wp_cron()/spawn_cron()/wp-cron.php should check the blog's status and bail if the blog is suspended." ryan 20534 Featured Image (Post Thumbnail) SSL Issue Post Thumbnails 2.9 normal normal Awaiting Review defect (bug) new has-patch 2012-04-24T15:46:37Z 2013-05-17T04:41:50Z If the wp-config FORCE_SSL_ADMIN constant has been set to true then the Featured Image within the Edit Post page will still load without HTTPS. This isn't a huge deal but it breaks the SSL on the page. Patch fixes this. justindgivens 20531 Version No. removed from theme name in themes General 3.4 normal minor Awaiting Review feature request new 2012-04-24T11:12:54Z 2012-04-25T09:06:55Z "The version no. of themes is removed in 3.4 from the themes page. There was a direct display of theme version no. in 3.3 and was a great help for developers with lots of theme with different versions. But now we have to click on Details to see the version number, which is just a bit time consuming. Hope you would consider my request. Thanks Sanam" kcssm 20523 Disable autoloader when using class_exists() General 3.3.1 normal normal Awaiting Review feature request new 2012-04-23T10:08:32Z 2012-05-16T01:07:04Z "A couple of files inside the /wp-includes/pomo directory use class_exists() the wrong way, for example in /wp-includes/pomo/entry.php : {{{ if ( !class_exists( 'Translation_Entry') ): }}} It should be: {{{ if ( !class_exists( 'Translation_Entry', false) ): }}} The second parameter 'false' disables autoloading. This is important because I'm integrating some WP functions into another existing website which already comes with an Autoloader for some classes = confusion. This should be easy to fix. Thanks :) " michael.heuberger 20522 the sanitize_file_name_chars filter and ch(0) Formatting normal minor Awaiting Review enhancement new needs-unit-tests 2012-04-23T08:26:28Z 2012-04-24T00:41:12Z "the sanitize_file_name_chars filter is tricky to use due to the chr(0) ending the array : both {{{ special_chars[] = $my_char; }}} and {{{ array_push($special_chars, $mychar); }}} have no effect. so the only way to add some char to the array is to use array_unshift : {{{ array_unshift($special_chars, $mychar); }}} adding this is mostly a php issue, but it could be useful to add some notice to the WordPress documentation. " olivM 20520 Author Page Pagination Broken Rewrite Rules 3.3.1 normal normal Awaiting Review defect (bug) new 2012-04-23T04:16:03Z 2012-04-23T04:37:44Z "WP 3.3.1 Multisite Permalink setup: /author/post-name - If the request is ""domain.com/authorname"" the authors page pagination link is broken. - If the request is ""domain.com/author/authorname"" the authors page pagination link works fine." rbaccaro 20516 "Ability to remove a previously-used Header Image from the list of rotating ""random"" header images" Themes 3.4 normal normal Awaiting Review enhancement new 2012-04-22T18:12:24Z 2012-04-22T21:38:55Z "Being able to add a bunch of header images and then selecting the ""Random"" option in the Appearance > Header section is awesome! However, it is equally important to be able to remove one/some/all of those header images from the list of rotating images. The current UI does not support this. An approach that would be the least disruptive to the current UI layout would be to enable a ""remove from list"" link (I wouldn't use the word ""delete"" because it's not deleting the media resource) when the user hovers over the image. The link could appear below the thumbnail, much as the Post's Quick Edit link appear under the list of Posts/Pages." TomAuger 20513 Refactor $wp_scripts init checking code General 3.4 normal normal Awaiting Review enhancement new has-patch 2012-04-22T15:15:36Z 2012-04-24T09:56:05Z "The functions in [http://core.trac.wordpress.org/browser/trunk/wp-includes/functions.wp-scripts.php functions.wp-scripts.php] seem to contain a lot of duplicate code in terms of checking and initializing the global `$wp_scripts` in each function. Attached is rough first pass at creating a function to do this. I expect aspects of it could be done better. I've included the first argument, to avoid relying on a global so that the function might be unit tested (pass something in, see what gets returned)." GaryJ 20509 Theme idea - generic.php Themes normal normal Awaiting Review feature request new dev-feedback 2012-04-21T23:37:30Z 2013-03-18T23:48:35Z "Problem: How do plugins that introduce completely new functionality (I.E. BuddyPress/bbPress) interface with themes, without needing to move template files directly into a theme's folder? Solution: generic.php ---- generic.php would be a template file that includes skeletal layout of the theme. In place of the content and the comment logic, is an action; for the sake of discussion, let's name this action 'generic_content' A concept file is attached for twentyeleven. This type of ability would help prevent a ton of additional processing that plugins currently need to do to hi-jack the_content output and noop the comment stream, in situations where a plugin needs to output HTML into the main content area of a theme. Rather than guessing at template names, and hoping 'page.php' or 'index.php' will be close enough, a convention of having themes come with a dedicated template for plugin compatibility would be incredibly helpful. BuddyPress components have a similar convention already, with a plugin.php having only the header, footer, sidebar, and generic action in them. The use case is currently small, and there's very little (if anything) needed in WordPress core to make this work. Wanted to post the idea here to get some developer talk going, and get opinions on other possible approaches." johnjamesjacoby 20495 Update phpDoc to reflect post id or object is valid Inline Docs 3.3.1 normal trivial Future Release defect (bug) new 2012-04-20T14:48:38Z 2013-05-14T13:24:11Z "Many functions use `get_post()` and do so by simply passing along one of their own arguments (typically a post ID). Since `get_post()` accepts either a post ID or a post object, those functions therefore can (and do) also accept either type of value for the argument. The phpDoc for many of the functions simply indicate a post ID is valid. The attached patch amends the `@param` doc entry for the relevant arguments to indicate either a post ID or post object is valid. (There are places where `get_post()` is used but the int arg is otherwise used in the function as an int -- I've skipped those since they don't really accept a post object.) " coffee2code 20492 Improve submit_button() General 3.4 low normal Awaiting Review feature request new 2012-04-19T20:40:10Z 2012-04-19T21:39:51Z "The `submit_button()` function takes five arguments and calling it ends up being very messy. Example [comment:ticket:20490:3 given by Scribu]: > It makes for very unreadable code. For example, when I see this: > > {{{ > submit_button( $args['label_submit'], 'button', 'submit', false, array( 'id' => $args['id_submit'] ) ) > }}} > > I have no idea what that `false` parameter is for, without looking up the defition for submit_button(). > > Plus, it's not that much shorter than writing the HTML by hand, which is clear as day: > > {{{ > "" value="""" /> > }}} Let's change this so it accepts a `$text` parameter for the button text and an `$attributes` parameter for everything else. Patch coming up." johnbillion 20491 Introduce some JavaScript i18n functions I18N normal normal Awaiting Review enhancement new 2012-04-19T18:50:24Z 2012-04-19T21:55:22Z "There's JavaScript code dotted around core that handles i18n in JavaScript (for example, localised thousands separators in the pending comment count). We should bring this together into a wpL10n JavaScript library that can be reused by plugins. I've done some work on this and I'll get a patch up in the next day or so." johnbillion 20490 Move submit_button to wp-includes for frontend inclusion & use with comment-template.php Comments normal normal Awaiting Review enhancement new 2012-04-19T18:04:55Z 2012-04-23T14:43:09Z "It would be nice to be able to use submit_button() on the frontend as well (cf. #15064). It appears that #16066 ""fixed"" #16061, which it did, but moving the submit_button functions would enable to revert back to the use of submit_button(). Moreover, I recommend changing the comment-template.php in wp-includes ([http://core.trac.wordpress.org/changeset/16066#file2 16066#file2]) to use a filter with the submit_button to enable attributes like onClick. As it stands right now, if a user wants to track comments in their analytics they have to hide the original and add a function hooked into comment_form and redo all the args." wpsmith 20487 Comment search isn't customizable Comments 3.2.1 normal normal Future Release enhancement new has-patch 2012-04-18T23:32:07Z 2012-07-12T16:05:07Z "*cross-posted to the wp-hackers mailing list last night* I work on a large news oriented WP site and first

Heading

What about foo bar?<\/h4>"", ""other_notes"": ""

%1$s %2$s

$title