Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#10119 closed defect (bug) (fixed)

Wrong data type in edit-page-form.php

Reported by: pairg Owned by: pairg
Priority: normal Milestone: 2.8.1
Component: Warnings/Notices Version: 2.8
Severity: minor Keywords: has-patch tested
Cc:

Description

PHP Warning in "/wp-admin/page.php?action=edit&post=<number>"

Warning: in_array() [function.in-array]: Wrong datatype for second argument in /wp-admin/edit-page-form.php on line 355

Attachments (3)

edit-page-form_rev11553_patch.patch​ (617 bytes) - added by pairg 4 years ago.
/wp-admin/edit-page-form.php patch
10119.diff​ (416 bytes) - added by Denis-de-Bernardy 4 years ago.
10119.2.diff​ (416 bytes) - added by Denis-de-Bernardy 4 years ago.

Download all attachments as: .zip

Change History (17)

pairg — 4 years ago

/wp-admin/edit-page-form.php patch

comment:1   pairg — 4 years ago

  • Owner set to pairg
  • Status changed from new to assigned

comment:2   pairg — 4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:3   pairg — 4 years ago

How I can commit my changes to SVN?
Please somebody commit my patch!

comment:4   ShaneF — 4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

It must be tested first before it is committed. I am re-opening this so we can test it. Please be patient!

comment:5   Denis-de-Bernardy — 4 years ago

  • Keywords dup added

testing report 17

comment:6   Denis-de-Bernardy — 4 years ago

  • Keywords dup removed

sweet :-)

Denis-de-Bernardy — 4 years ago

comment:7   Denis-de-Bernardy — 4 years ago

Issue with the original patch is that (array) false === array(0=>false).

attached a slightly different patch, but it may have side effects

comment:8   Denis-de-Bernardy — 4 years ago

  • Priority changed from high to normal

comment:9 follow-up: ↓ 11   Denis-de-Bernardy — 4 years ago

@pairg -- how did you end up with this error in the first place? never ran into it myself.

comment:10   Denis-de-Bernardy — 4 years ago

  • Keywords reporter-feedback added

comment:11 in reply to: ↑ 9   ShaneF — 4 years ago

Replying to Denis-de-Bernardy:

@pairg -- how did you end up with this error in the first place? never ran into it myself.

Ditto.

Denis-de-Bernardy — 4 years ago

comment:12   Denis-de-Bernardy — 4 years ago

  • Keywords tested added; reporter-feedback removed

comment:13   ryan — 4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [11571]) Return empty array instead of false from get_editable_user_ids. Props Denis-de-Bernardy, pairg. fixes #10119 for trunk

comment:14   ryan — 4 years ago

(In [11572]) Return empty array instead of false from get_editable_user_ids. Props Denis-de-Bernardy, pairg. fixes #10119 for 2.8.1

Note: See TracTickets for help on using tickets.