WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 3 years ago

#10177 new enhancement

get_ version of comments_number()

Reported by: nbachiyski Owned by:
Priority: normal Milestone: Future Release
Component: Template Version: 2.8
Severity: normal Keywords: has-patch i18n early 2nd-opinion
Cc: kapeel.sable@…

Description

Currently: comments_number() accepts several arguments for the comment number labels and outputs them. get_comments_number(), however, returns only the number of comments.

Problem: there isn't a function to mimic the comments_number() functionality, but to return instead of echo.

The patch introduces get_comments_number_text(), which inherits the functionality of comments_number(), but returns. comments_number() just calls get_comments_number_text().

Attachments (2)

get-comments-number-text.diff​ (1.4 KB) - added by nbachiyski 4 years ago.
10177.diff​ (1.3 KB) - added by kapeels 3 years ago.

Download all attachments as: .zip

Change History (7)

nbachiyski — 4 years ago

comment:1 ryan — 4 years ago

  • Milestone changed from 2.9 to 3.0

comment:2 nacin — 3 years ago

  • Keywords early added
  • Milestone changed from 3.0 to 3.1
  • Type changed from defect (bug) to enhancement

comment:3 nacin — 3 years ago

  • Milestone changed from Awaiting Triage to 3.1

Instead of call_user_func_array() it would be cleaner to just pass the three arguments.

comment:4 westi — 3 years ago

  • Milestone changed from 3.1 to Future Release

Moving to Future Release as it is an enhancement.

comment:5 kapeels — 3 years ago

  • Cc kapeel.sable@… added
  • Keywords 2nd-opinion added

Would be great if you guys could give me points in gci for this bug-fix :)

kapeels — 3 years ago

Note: See TracTickets for help on using tickets.