get_pages function: number and child_of parameters conflict

[ortsaipekim]

Passing both number and child_of parameters to get_pages will produce nonsensical results.

Within the function number is used first to limit the number of results, then child_of is used to establish results within a certain hierarchical scope.

So with a structure of:

Parent 1 
Parent 2
Parent 3
   Child 1
   Child 2 
   Child 3

passing a number=2 and child_of=(parent 3 id) will not give the expected output. In this case, the result will first be limited to only include:

Parent 1 
Parent 2

so the child_of will be ignored. To produce a more logical result, child_of should be evaluated first, then number should be evaluated to limit the result set.

I meant to demonstrate the heirarchy as the following:

Parent 1
Parent 2
Parent 3

Child 1
Child 2
Child 3

the proposed patch passes the number argument to the get_children function and prevents get_pages from limit(ing) the result from the query.
works fine on one of my client's site.

A quick fix for this is to pass in the "parent={parent_id}" along with all your other arguments. Obviously not a fix for the bug but if you need this sort of functionality then it will work for now.

Bumping to Future release due to limited traction.

This also needs testing to ensure it doesn't break on complex queries involving children and offset/number

Closed #10745 as a duplicate.