Ticket #10242 (closed defect (bug): fixed)
Media menu does not handle multiple lines
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.0 |
| Component: | UI | Version: | 2.8 |
| Severity: | normal | Keywords: | has-patch tested |
| Cc: |
Description
This bug has been reported on the fr_FR forum back in Feburary, and it is still true for 2.8.
Some plugin add another item in the Media menu. While this is perfectly acceptable, some translation might already use the full width for the three default items (see first attached capture), and therefore any additional item would be pushed to a second menu line.
That should be no problem, but in effect that second menu line pushes the first one off-screen, leaving only the second one to be seen (see second attached capture).
The translation has since been reduced, but the issue remains: the menu should be able to handle numerous sub-lines, just because the use might want to use many item-adding plugins...
Attachments
Change History
-
attachment
wp28-mediamenu-fr.png
added
-
attachment
wp28-mediamenuNextgen.png
added
same fr_FR Media menu, with NetxtGEN Gallery plugin activated
- Owner changed from ryan to azaozz
- Status changed from new to assigned
- Component changed from Menus to UI
- Keywords has-patch added; needs-patch 2nd-opininon removed
Vive la France!
Here's a patch. I converted the ul#sidemenu to a normal, non-floated UL. It looks like normal but can now handle very long lines. It don't look too pretty when it breaks up to two rows but them's the breaks, eh?
Thanks Edward!
My cache doesn't seem to want to take it into account, but a quick test through FireBug shows that it's the right direction. It'd need a bit of spit'n'polish to make sure it stays preeety, but apart from that, thanks a lot :)
- Keywords tested added; needs-testing removed
Works fine: http://grab.by/45hN
You can test it with
function test_tabs ($tabs) {
$newtab = array(
'1' => ('1 Gallery'),
'2' => ('2 Gallery'),
'3' => ('3 Gallery'),
'4' => ('4 Gallery'),
'5' => ('5 Gallery'),
'6' => ('6 Gallery'),
);
return array_merge($tabs,$newtab);
}
add_filter('media_upload_tabs', 'test_tabs');
comment:8
markjaquith — 21 months ago
- Status changed from assigned to closed
- Resolution set to fixed

overlong fr_FR Media menu