Ticket #1028 (closed defect (bug): fixed)

Opened 7 years ago

Last modified 7 years ago

Comment whitelist never tested if no moderation keys

Reported by: ColdForged Owned by: ryan
Priority: normal Milestone:
Component: General Version: 1.5.1
Severity: minor Keywords:
Cc:

Description

If there are no moderation keys specified in the discussion options, the comment is approved regardless of any whitelist settings.

Attachments

comment-functions.php.patch Download (2.4 KB) - added by ColdForged 7 years ago.

Change History

comment:1   ColdForged — 7 years ago

  • Patch set to No

comment:2   matt — 7 years ago

Patch seems to include a lot of needless whitespace changes

comment:3   ColdForged — 7 years ago

There was a change of scope to place a block that previously wasn't under a conditional statement under that conditional, necessitating a change in indent. How do you propose doing that without actually indenting?

comment:4   ColdForged — 7 years ago

Which is, of course, a snippy way of saying that I don't think it's needless in this case. Long day.

comment:5   ryan — 7 years ago

  • Owner changed from anonymous to rboren
  • fixed_in_version set to 1.5.1
  • Status changed from new to closed
  • Resolution changed from 10 to 20

 http://trac.wordpress.org/changeset/2414

ColdForged — 7 years ago

Note: See TracTickets for help on using tickets.