Add parameter "separator" to "wp_tag_cloud()"

[ramiy]

When using wp_tag_cloud('format=flat') the result is a list of tags separated by whitespace.

The problem: We can't change the whitespace between the tags.

The solution: Adding the "separator" parameter will give us some control over the separator string.

using "between" would be more inline with other functions.

there is the 'format=array' options. use that to implode with the seperator char of your choice.

somewhat related: #5172

IMHO no need to re-invent the wheel here for a behavior in for some time, so I close this as wontfix. A wordaround is provided anyway.

The problem is that not every one know how to use 'format=array', this is not user friendly!

The "separator" parameter is the most elegant solution to this problem.

Can you please name some other WordPress API functions having such a functionality already? Or is this just a personal preference of yours?

First of all, this is not a personal preference.

Adding this feature will make WordPress not only developer-friendly but also user-friendly and desingner-friendly. This is not a big technological improvement, this is a tag-cloud output design.

Instead of the current obsolete whitespace between tags blogers can change it to a minus sign or a nice image. Adding a widget control will allow users to edit the separator in the widget sub-panel and will make it even simpler and easier.

Updated patch so that seperator is the only seperator and defaults to the default seperator ("\n").

Default seperator should be "\n" then. Updated the patch, credits to ramiy.

Additional note: wp_tag_cloud and wp_generate_tag_cloud share a decent amount of code (for example the default values) which does a bit fishy to me. Someone willing to clean that up?

Milestone: Future release pending patch for enhancements, Current-trunk upon patch being added for consideration, point release back-porting at commiters discretion. (Generic reply for when I change the milestone)

Patch is stale needs updating.

Refreshed patch. :)

Patch fail - removes code :-(

Replying to westi:

Patch fail - removes code :-(

Whoops. Updated patch with fix.

(In [12014]) Allow the separator in wp_tag_cloud and wp_generate_tag_cloud to be specified. Fixes #10315 props ramiy and filosofo.