Make WordPress Core

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#10378 closed defect (bug) (fixed)

The feed widget breaks UTF-8 titles

Reported by: nbachiyski's profile nbachiyski Owned by: azaozz's profile azaozz
Milestone: 2.8.2 Priority: normal
Severity: normal Version: 2.8.1
Component: Widgets Keywords: has-patch
Focuses: Cc:

Description

WP_Widget_RSS::widget() calls htmlentities() on the feed title, which by default assumes the string is in iso-8859-1 and thus encodes every byte as an entity.

In fact, we don't need to use htmlentities(), since the title is used in HTML. esc_html() is enough.

Attachments (1)

feed-widget-non-ascii-titles.diff (655 bytes) - added by nbachiyski 15 years ago.

Download all attachments as: .zip

Change History (4)

#1 @azaozz
15 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11706]) Properly escape the title in the feed widget, props nbachiyski, fixes #10378 for 2.8

#2 @azaozz
15 years ago

(In [11707]) Properly escape the title in the feed widget, props nbachiyski, fixes #10378 for trunk

#3 @azaozz
15 years ago

  • Milestone changed from Unassigned to 2.8.2
Note: See TracTickets for help on using tickets.