Ticket #10378 (closed defect (bug): fixed)

Opened 3 years ago

Last modified 3 years ago

The feed widget breaks UTF-8 titles

Reported by: nbachiyski Owned by: azaozz
Priority: normal Milestone: 2.8.2
Component: Widgets Version: 2.8.1
Severity: normal Keywords: has-patch
Cc:

Description

WP_Widget_RSS::widget() calls htmlentities() on the feed title, which by default assumes the string is in iso-8859-1 and thus encodes every byte as an entity.

In fact, we don't need to use htmlentities(), since the title is used in HTML. esc_html() is enough.

Attachments

feed-widget-non-ascii-titles.diff Download (655 bytes) - added by nbachiyski 3 years ago.

Change History

nbachiyski — 3 years ago

comment:1   azaozz — 3 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [11706]) Properly escape the title in the feed widget, props nbachiyski, fixes #10378 for 2.8

comment:2   azaozz — 3 years ago

(In [11707]) Properly escape the title in the feed widget, props nbachiyski, fixes #10378 for trunk

comment:3   azaozz — 3 years ago

  • Milestone changed from Unassigned to 2.8.2
Note: See TracTickets for help on using tickets.