Various functions using 'thumb' index to try for image metadata, 'thumbnail' would be correct

[simonwheatley]

Both get_attachment_thumb_file, wp_delete_attachment seem to access the filename for the thumbnail attachment incorrectly; the functions try to get $imagemeta[ 'thumb ], but WP stores the filename under $imagedata[ 'sizes' ][ 'thumbnail' ][ 'file' ].

Two patches: wp_get_thumbnail_file has been tested in the course of my development, wp_delete_attachment follows the same principles of correcting the indexes and _should_ work, but hasn't been tested as I'm not using this function in my app currently and am on deadline... sorry!

Corrects indexes to access thumbnail metadata in wp_get_thumbnail_file

Corrects indexes to access thumbnail metadata in wp_delete_attachment

Think you're looking at the wrong place in wp_delete_attachment(). The thumbnails are deleted right under the code block you're patching. That block seems to be for back-compat with 2.3.x. Look at lines 2616 to 2622.

However only the back-compat code exist in wp_get_attachment_thumb_file(). We need to add support for the newer version there, not replace the old.

Punting as unresolved and in beta.

If I'm right wp_get_attachment_thumb_file() is missing back compat right?

#17262 has more traction.