Opened 4 years ago
Closed 9 months ago
#10509 closed defect (bug) (duplicate)
feed-rss2.php tests for $post->post_content without applying the_content filters
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Feeds | Version: | 2.9 |
| Severity: | normal | Keywords: | has-patch |
| Cc: |
Description
feed-rss2.php contains an if statement that tests to see if $post->post_content is greater than zero before using the_content (which may be changed to the_content_rss) to populate the <content: encoded> tag.
feed-rss2..php, line 48:
<?php if ( strlen( $post->post_content ) > 0 ) : ?>
No other RSS feed does this.
The problem is that this test does not take into account the_content filters, which may populate an otherwise empty post. The ComicPress theme is a real world instance where this occurs -- posts containing comics are populated using apply_filters to the_content rather than through direct entry when a new post is created.
If the RSS 2 feed template is to behave differently than the other feeds, it should at least apply the_content filters before testing for content rather than pulling directly from $post->post_content.
Otherwise, the RSS 2 feed template should be brought in line with the other feed templates and this test should be removed.
Attachments (2)
Change History (9)
peaceablewhale — 4 years ago
comment:1
peaceablewhale — 4 years ago
- Keywords has-patch added; rss 2, rss, feed, the_content, post_content removed
- Milestone changed from Unassigned to 2.9
i dont think removing the the_excerpt_rss() case is the right way to go about it
comment:3
peaceablewhale — 4 years ago
<content:encoded> should not contain summary. The <description> element does that.
peaceablewhale — 4 years ago
comment:4
peaceablewhale — 4 years ago
The second version of the patch will check if get_the_content is empty.
comment:6
nateomedia — 3 years ago
A year has passed and this ticket hasn't been closed. Is there any chance of this being scheduled from release? I know there are bigger issues to deal with and everything, but every update I have to go and manually patch feed-rss2.php — it would be nice to see this fixed. Thank you.
comment:7
SergeyBiryukov — 9 months ago
- Milestone Future Release deleted
- Resolution set to duplicate
- Status changed from new to closed

I have uploaded a patch that removes the condition check.