Opened 4 years ago

Closed 3 years ago

#10525 closed enhancement (fixed)

post.php suppressed E_WARNING

Reported by: Mittineague Owned by:
Priority: low Milestone: 2.9
Component: Autosave Version:
Severity: minor Keywords: has-patch commit
Cc: allanh62@…

Description

Using the Error Reporting plugin I get

E_WARNING
Couldn't find constant DOING_AUTOSAVE
at ...../wp-includes/post.php (3471)

function wp_save_post_revision( $post_id ) {
	// We do autosaves manually with wp_create_post_autosave()
	if ( @constant( 'DOING_AUTOSAVE' ) )
		return;

Would it not be easy enough to do a defined() before the constant() and eliminate the need for suppression?

Attachments (1)

10525.diff​ (453 bytes) - added by Denis-de-Bernardy 3 years ago.

Download all attachments as: .zip

Change History (4)

Denis-de-Bernardy — 3 years ago

comment:1   Denis-de-Bernardy — 3 years ago

  • Keywords has-patch added
  • Milestone changed from Unassigned to 2.9
  • Type changed from defect (bug) to enhancement

comment:2   Denis-de-Bernardy — 3 years ago

  • Keywords commit added

(trivial patch)

comment:3   ryan — 3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

[12265]

Note: See TracTickets for help on using tickets.