id	summary	reporter	owner	description	type	status	priority	milestone	component	version	severity	resolution	keywords	cc
10602	if WP_CACHE is defined as false advanced-cache file will still be loaded	dandean	ryan	"Line 214 of wp-settings.php is prone to confusing people if WP_CACHE is set to FALSE (or any othe value that is not TRUE). The IF statement is only checking that WP_CACHE is set, not that it is set to TRUE:

{{{
if ( defined('WP_CACHE') )
	@include WP_CONTENT_DIR . '/advanced-cache.php';

}}}

Something like this would be much better:

{{{
if ( defined('WP_CACHE') && WP_CACHE == true )
	@include WP_CONTENT_DIR . '/advanced-cache.php';

}}}

This would be even better (pseudo-code... removing ""@"" from include statement), but I understand if it violates other more important concerns:

{{{
if ( defined('WP_CACHE') && WP_CACHE == true ) {
    try {
        include WP_CONTENT_DIR . '/advanced-cache.php';
    } catch (Exception $e) {
        die(""Advanced cache not configured. "" + $e->getMessage());
    }
}
}}}
"	defect (bug)	closed	normal	2.9	Cache	2.9	normal	fixed	has-patch tested