WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 7 years ago

#1076 closed defect (bug) (fixed)

is_seach logic in default theme which has search.php template

Reported by: MC_incubus Owned by: mdawaffe
Priority: normal Milestone: 2.1
Component: Template Version: 1.5
Severity: trivial Keywords: has-patch commit template
Cc:

Description

in the default 1.5 (kubrick) theme, in the archives.php template, there is this:

<?php /* If this is a search */ } elseif (is_search()) { ?>

<h2 class="pagetitle">Search Results</h2>

But because there is a search.php template, all is_search() true requests should go there, so this logic does nothing in archives.php

Hat tip to dmclark in #wordpress for finding this

Attachments (1)

1076.diff​ (737 bytes) - added by mdawaffe 7 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 MC_incubus — 8 years ago

  • Patch set to No

mdawaffe — 7 years ago

comment:2 mdawaffe — 7 years ago

  • Keywords has-patch commit template added
  • Milestone set to 2.1
  • Owner changed from anonymous to mdawaffe
  • Status changed from new to assigned

Patched.

comment:3 ryan — 7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4166]) Remove is_search() check that will never be reached. fixes #1076

Note: See TracTickets for help on using tickets.