file.php: PHPDoc + optimised unzip_file() — at Version 1
|Reported by:||dd32||Owned by:||dd32|
Description (last modified by dd32)
Patch contains 2 sections:
- Much improved PHPDoc coverage for filesystem-related functions in file.php
- Optimised unzip_file() function
- Reduced the number of IO operations required (mainly is_dir())
- Simplifies logic to make reading easier.
Also note, I played with extracting a file at a time from the ZIP, and writing to the filesystem directly, While it decreased the memory usage from ~12MB to 3MB for the entire unzip operation, It increased the operation time from 5s to 70s, So i've left it to consume memory in order to speed things up.