#10906 closed defect (bug) (duplicate)
incorrect logic in upgrader class
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Upgrade/Install | Version: | 2.8.4 |
| Severity: | major | Keywords: | needs-patch |
| Cc: |
Description
on sites where FTP maps the WP ABSPATH to /, the core ugprader fails.
fs_connect() ends up testing !find_folder() at one point, instead of bailing on abspath.
Patch attached.
Attachments (2)
Change History (6)
Denis-de-Bernardy — 4 years ago
Denis-de-Bernardy — 4 years ago
- Severity changed from normal to major
- Version set to 2.8.4
- Keywords needs-patch added; has-patch tested removed
mm, there should actually be a better patch, which is to cache ABSPATH over in find_folder(). it'll give a performance bonus on top.
- Milestone 2.9 deleted
- Resolution set to duplicate
- Status changed from new to closed
which is to cache ABSPATH over in find_folder(). it'll give a performance bonus on top.
That also happens at present, However, the cached values are only used for direct lookups, Not used for speeding up locating the child folders. Suggest opening a new ticket if you'd like to implement it.
Note: See
TracTickets for help on using
tickets.
patch also fixes a typo in the code