WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#10915 closed defect (bug) (fixed)

DRY: WP should use current_time() to calculate current time

Reported by: filosofo Owned by: ryan
Priority: normal Milestone: 3.0
Component: Date/Time Version:
Severity: normal Keywords: has-patch current_time
Cc: Denis-de-Bernardy

Description

Multiple places in the code calculate the current time, repeating what current_time('timestamp') already does.

Patch fixes.

Attachments (2)

use.current_time.10915.diff​ (3.2 KB) - added by filosofo 4 years ago.
10915.patch​ (3.1 KB) - added by hakre 3 years ago.

Download all attachments as: .zip

Change History (8)

filosofo — 4 years ago

comment:1 ryan — 4 years ago

  • Component changed from General to Date/Time

comment:2 ryan — 4 years ago

  • Milestone changed from 2.9 to 3.0

Related: #9588 #8662

comment:3 Denis-de-Bernardy — 3 years ago

  • Cc Denis-de-Bernardy added

hakre — 3 years ago

comment:4 hakre — 3 years ago

Patch still applied clean. Found a duplicate line in the review and therefore updated the patch.

comment:5 ryan — 3 years ago

See also #11672 and #11665.

comment:6 automattor — 3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [12590]) Use current_time() to calculate current time. Props filosofo. fixes #10915

Note: See TracTickets for help on using tickets.