Storing rewrite_rules in a transient causes issues with non-permanent object caches and plugins that add endpoints

[markjaquith]

If a WP install is using a non-permanent object cache like Memcache, its "transient"-stored rewrite_rules entry will go away without warning and WP will regenerate it. That regeneration happens before init, where many plugins use add_rewrite_endpoint(). Thus the rules will get populated without the endpoint.

e.g. ​http://wordpress.org/support/topic/313946

Recommend we revert to old option-based method of rewrite_rules storage.

switches to storing the rules in an option, like before.

[10/19/09 4:27:23 PM] Mark Jaquith: so this will just be a reversion to our behavior pre-transients.
[10/19/09 4:27:45 PM] Ryan Boren: Yeah. Sounds like the correct fix.

Sounds like a sensible idea to me.

Remove rewrite_rules from deprecated options list.

(In [12061]) Revert to old options table storage of rewrite_rules. Transient object caches would silently regenerate rewrite_rules without giving plugins a chance to readd endpoints. fixes #10981