'Show' link doesn't appear for about 10s after 'Crunching' is finished.

[caesarsgrunt]

After uploading an image, the 'Show' link doesn't appear for about 10s after 'Crunching' is finished.

Firefox 2.5.5, WP r12320 (but applies to all versions).

Sorry, Firefox 3.5.5...

'Crunching' is the time when the server makes the image sub-sizes and depends on the image size. There was an idea to make it asynchronous so the next image can be uploaded while sub-sizes are being created but the memory usage would go through the roof.

What we can improve is image_resize(). It can create all sub-sizes in one go without destroying and then loading again the 'big' image for every sub-size.

Yes, but what I meant was that after the Crunching has finished (the notice has disappeared), there is a longish delay before the "show" link appears for the image.

Don't see this here, perhaps slow/congested Internet connection?

Nope; I also get it on my local test server. I'll do some investigation at some stage, but I'm very busy at the moment.

Hmm... on my testing server, it actually appears after about 1s in tests I've just done. So I guess it is a slow internet connection as yo say (my internet connection is certainly slow, but it seems to happen at least to some extent when I use faster connections too).

Anyway - once the crunching message is gone, can't the 'show' link appear immediately? What is happening in between 'crunching' being hidden and 'show' being, er, shown?

Replying to caesarsgrunt:

What is happening in between 'crunching' being hidden and 'show' being, er, shown?

The image data is being loaded asynchronously, and the "Show" link appears once it has loaded - otherwise when you click on it the edit section would not yet be populated...

I think it would be better to leave the "Crunching..." message there until the data is loaded, to avoid that delay. Patch attached. I also noticed some variable duplication which I've remedied.