Some buttons have gone square in 2.9

[caesarsgrunt]

After upgrading some of my live sites to 2.9, I see that some of the buttons have gone square with slightly rounded corners, as opposed to the capsule buttons which 2.8 had everywhere.

The change is not global, nor is there any apparent rule as to which buttons are square and which round - see attached screenshots.

The change did not appear at any point during the 2.9 beta and RC process - yesterday's nightly didn't even have it, so far as I am aware.

The buttons are now inconsistent throughout WP, and as a result the change is highly counter-intuitive and confusing.

Dashboard (all round)

Edit Post - inconsistent

New Post - Inconsistent

Update - Inconsistent

Not even major action buttons (the blue ones) are one consistently the same shape - compare the publish buttons on QuickPress and New Post...

Seems to be caused by a conflict between

.submit input, .button, .button-primary, .button-secondary, .button-highlighted, #postcustomstuff .submit input {
    -moz-border-radius-bottomleft:11px;
    -moz-border-radius-bottomright:11px;
    -moz-border-radius-topleft:11px;
    -moz-border-radius-topright:11px;
    ...

and

textarea, input[type="text"], input[type="password"], input[type="file"], input[type="button"], input[type="submit"], input[type="reset"], select {
    -moz-border-radius-bottomleft:4px;
    -moz-border-radius-bottomright:4px;
    -moz-border-radius-topleft:4px;
    -moz-border-radius-topright:4px;
    ...

on line 379 and line 1, respectively, of admin.dev.css

Specifically, the latter snippet shouldn't apply to input[type="button"], input[type="submit"], input[type="reset"].

Introduced in changeset [12448] / [12449].

Patch fixes the bug by removing the offending selectors.

(Side note : As it happens, I prefer the square buttons... but the shape should be consistent, and should not be changed without discussion.)

Replying to caesarsgrunt:

Patch fixes the bug by removing the offending selectors.

(Side note : As it happens, I prefer the square buttons... but the shape should be consistent, and should not be changed without discussion.)

Tested the patch on Firefox 3.5 and Chrome latest.

I also like the square buttons more.

Thanks Scribu.

Also tested in Firefox 3.5 and Safari 4. Better test in Opera, I guess, since [12448] / [12449] was intended to fix a bug in Opera... Haven't go t time now but will test later.

Replying to caesarsgrunt:

Patch fixes the bug by removing the offending selectors.

(Side note : As it happens, I prefer the square buttons... but the shape should be consistent, and should not be changed without discussion.)

Indeed I believe the change was introduced by accident and we should switch this back to the rounded buttons for 2.9.1

Also now tested in Opera 10.

Replying to westi:

Replying to caesarsgrunt:

Patch fixes the bug by removing the offending selectors.

(Side note : As it happens, I prefer the square buttons... but the shape should be consistent, and should not be changed without discussion.)

Indeed I believe the change was introduced by accident and we should switch this back to the rounded buttons for 2.9.1

You shure? The finer rounded-corner buttons were introduced for 2.9 weren't they? I thought this is one of the visual changes for the release.

This was certainly introduced by[12448] / [12449], and I'm fairly sure it was unintentional since it isn't mentioned in the commit description and nor is a ticket linked to which describes the change. Also, the change is not universal; it just depends on the type of button within the html and not on what the button does.

azaozz should know and be able to clarify.

(In [12463]) Round back the buttons, see #11502

It wasn't intentional, sorry about that (some browsers really hate to update styles despite that all caches are disabled).

@caesarsgrunt removing these selectors would leave buttons without classes unstyled, better to make sure we apply the classes properly.

Can you confirm thunk looks as it should, before adding this to the 2.9 branch. Don't want to repeat the same mistake :)

Working in trunk, but you busted the cache for globa.css instead of for wp-admin.css :)

(In [12474]) Round back the buttons, fixes #11502

Still getting square buttons in 2.9.1. Yes, I've cleared my cache.

Replying to caesarsgrunt:

Still getting square buttons in 2.9.1. Yes, I've cleared my cache.

A little more details wouldn't hurt: browser, os, which admin page(s) etc.

Replying to scribu:

A little more details wouldn't hurt: browser, os, which admin page(s) etc.

Browser: Firefox 3.5, Safari 4.0, Chrome 4.0...
OS: Doesn't make any difference, but if you're interested it's OS X 10.6.2.
Which pages: See the original ticket and screenshots.

Happy? :-p

And before you ask; WP latest nightly as of 22nd Dec at 14:00 GMT.

Replying to caesarsgrunt:

Replying to scribu:

A little more details wouldn't hurt: browser, os, which admin page(s) etc.

Browser: Firefox 3.5, Safari 4.0, Chrome 4.0...
OS: Doesn't make any difference, but if you're interested it's OS X 10.6.2.
Which pages: See the original ticket and screenshots.

Happy? :-p

Yes, thanks. :P

(In [12496]) Bump wp-admin css ver. see #11502

Replying to caesarsgrunt:

Still getting square buttons in 2.9.1. Yes, I've cleared my cache.

Perhaps you're caught in the same "strange" behaviour that brought this bug. Quitting FF and deleting the cache manually would fix that.

Just tested nightly build 3.0-alpha. It's working in dashboard, edit post, upgrade and new post.

Add New button in Write new post seems to use another font. (add-new-h2 class?)

Cannot upload image, TRAC says upload is broken :(

Working in latest nightly as of 23rd Dec.