Creation of unnamed option is possible

[hakre]

I just looked into the DB on a wordpress setup and the otpion table contained an option with an empty option_name.

Not shure if this exactly is a bug but I would argue that an option should have a name otherwise it might not be possible to query it.

I agree. If the option name is empty, it should not be inserted into the table.

Just tested this:

update_option('', '');

it does create an option with an empty name.

but it's not really a bug because it can be queried by get_option() properly. so nothing critical I assume.

A patch to validate the $option_name before updating the options table.

The patch I just added will check to see if $option_name is empty or blank (whitespace) before adding it to the options table. If the $option_name is invalid, update_option() will return false.

Patch looks good, but you could loose the comentary since it's obvious what the code does.

You could update the function documentation instead.

Same patch as above, updates function documentation instead of adding commentary.

(In [13858]) Do not allow empty option names. Trim leading and trailing whitespace from option names. Partial patch props ericmann. Fixes #11506