Opened 3 years ago
Closed 3 years ago
#11511 closed defect (bug) (duplicate)
Page numbers not updated when doing a tag search
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Administration | Version: | 2.8 |
| Severity: | normal | Keywords: | has-patch 2nd-opinion |
| Cc: | garyc40@… |
Description
When you go to wp-admin/edit-tags.php and do a tag search, the pagination links are not updated to reflec that search.
Say if you have 10 pages of tags, in total. If you do a search that finds only 2 tags, you will still see links to those 10 pages.
Attachments (2)
Change History (10)
comment:1
miqrogroove — 3 years ago
- Version changed from 2.9 to 2.8
comment:2
miqrogroove — 3 years ago
See also #8632
Pagination is generated in line 193 of the named file which does not reflect for it's total the total tags returned by the search but for the taxonomy.
the search output can not reflect the pagenumber properly because there is no input ossibility for tag search page count.
(Aditionally: AJAX-Adding tags does not reflect the number of tags per page as well.)
Patch does fix the display problem. It's a cosmetic fix. The underlying problem is that searching for tags is not properly imlemented with pagination in mind (a search for a tag will ever return the number per tags per page at maximum).
- Keywords 2nd-opinion added
I'd like to see a second opinion on my patch. I tested it a bit over the last days (it actually does fix the problem which mainly is a display problem). So fix it or close it?
- Keywords needs-patch added; has-patch 2nd-opinion removed
the patch breaks pagination when multiple pages of searched terms are returned.
- Cc garyc40@… added
- Keywords has-patch 2nd-opinion added; needs-patch removed
In this patch I added an argument for wp_count_terms() so that search keywords are taken into account when counting terms.

old bug. I'll check for dupes.