Ticket #11582 (closed defect (bug): fixed)
Code editor bug in Safari
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 2.9.1 |
| Component: | Editor | Version: | 2.9 |
| Severity: | normal | Keywords: | has-patch |
| Cc: |
Description
Rollover the Update button will cause the form div to clear the right hand list. Opening the WebKit Developer window and click on or off any CSS attribute will reset it. Probably a CSS issue, or maybe JavaScript. Hard to tell from Webkit's tool, firebug is better ;)
To reproduce, mouse over the update button again. Always reproducable on Safari 4 Win and Mac on WordPress 2.9
Attachments
-
11582-theme-editor.diff
(345 bytes) -
added by nacin 2 years ago.
Change History
- Keywords has-patch needs-review added
- Milestone changed from 3.0 to 2.9.1
Got it. It's an unnecessary <br class="clear" />. To explain, this would clear the .fileedit-sub div, which doesn't need to be cleared. (Elements in the .fileedit-sub div do need to be cleared, and they are.) This troublesome piece of markup only exists in the theme editor; the plugin editor is spared.
Here's the interesting part -- I actually can't find where this piece of code was slipped in. It exists in 2.9 and trunk, but not 2.8. Couldn't find it in blame. I then looked through all changesets on this file since 2.8 and still couldn't find it. So if anyone can find when it was added, I'd love to see it.
This is definitely a 2.8 regression. Moving to 2.9.1. Please test -- with the patch, I confirm as fixed on both Chrome and Safari.
- Keywords needs-review removed
So:
This markup had been there for quite a while in both the theme and plugin editors. For #10101, the code was removed from the plugin editor in both the 2.8 branch (2.8.1 milestone) and trunk, but incidentally only removed from the plugin editor in 2.8, leaving it in trunk. For the changes to the 2.8 branch, see [11646]. Trunk: [11647].
Oops, should have said:
but incidentally only removed from the theme editor in 2.8, leaving it in trunk.
- Status changed from new to closed
- Resolution set to fixed
Confirmed in Chrome 3 and Safari 4. (I had actually click the button in Safari, though I'm running a beta build for that.)
Definitely JavaScript-related. Unable to reproduce in either browser with it disabled.
Also could not produce in 2.8.
Working to debug and patch now. Ideas appreciated. Setting to 3.0. Could go into a point release but we have to nail it first.