Ticket #11638 (closed defect (bug): fixed)

Opened 2 years ago

Last modified 2 years ago

update-core.php doesn't remove the upgrade files if the upgrade fails due to too old of a PHP or MySQL version

Reported by: nacin Owned by:
Priority: normal Milestone: 2.9.1
Component: Upgrade/Install Version: 2.9
Severity: normal Keywords: has-patch tested
Cc:

Description

Related: #11464, where this code came from.

wp-admin/includes/update-core.php, which gets copied over after download during an upgrade, has a new check in 2.9 to ensure that the MySQL and PHP versions are is required by the downloaded version.

However, I didn't account for the fact that the code should clean up after itself by deleting the downloaded package on failure, just as it does on any other failure it encounters. This should be fixed in 2.9.1.

Patch on its way.

Attachments

11638.diff Download (895 bytes) - added by nacin 2 years ago.
11638.2.diff Download (1.0 KB) - added by nacin 2 years ago.
We also need to bump the local $wp_version to 2.9.1. See also #11639.

Change History

nacin2 years ago

  • Keywords has-patch tested added

nacin2 years ago

We also need to bump the local $wp_version to 2.9.1. See also #11639.

comment:2   ryan2 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [12564]) Cleanup after bailing when php or mysql versions are not compat. Props nacin. fixes #11638 for trunk

comment:3   ryan2 years ago

(In [12565]) Cleanup after bailing when php or mysql versions are not compat. Props nacin. fixes #11638 for 2.9

Note: See TracTickets for help on using tickets.