Ticket #1166 (closed defect (bug): fixed)

Opened 7 years ago

Last modified 7 years ago

Pingbacks don't work with allow_url_fopen=Off

Reported by: anonymousbugger Owned by: matt
Priority: normal Milestone:
Component: XML-RPC Version: 1.5
Severity: major Keywords:
Cc:

Description

pingback_ping() uses @fopen($pagelinkedfrom, 'r') to check if the source URI exists. This check always fails if allow_url_fopen is Off (recommended setting), that means pingbacks don't work.

Please consider replacing this fopen call with something like the code from  http://7sheaven.pingouin.ca/forum/showthread.php?t=13

Attachments

foo.php Download (162 bytes) - added by anonymousbugger 7 years ago.

Change History

  • Patch set to No

comment:3   matt7 years ago

  • Owner changed from anonymous to matt
  • Status changed from new to closed
  • Resolution changed from 10 to 50

I can't use the code from the link if the link doesn't work.

  • Status changed from closed to assigned
  • Resolution changed from 50 to 30

Just use snoopy instead of fopen($url)

Agreed. We're bundling Snoopy with WordPress, and using it will increase compat.

comment:6   matt7 years ago

So remote fwrites work even if remote fopen is off?

comment:7   matt7 years ago

Dreamhost, which recently disabled remote fopen, is suggesting users use curl. Curl is only used in Snoopy for SSL connections.

We may also want to upgrade snoopy.

I think the CURL PHP module is the way to go.

The module is available on a lot of hosts, the 'curl' binary isn't (especially in chroot environments). So if you continue to use Snoopy, it should be modified to use the module instead of the binary.

comment:9   matt7 years ago

Possible fix checked in, please confirm

  • Status changed from assigned to closed
  • fixed_in_version set to 1.5.1
  • Resolution changed from 30 to 20

Resolving pending further feedback

Note: See TracTickets for help on using tickets.