Opened 3 years ago

Closed 3 years ago

#11664 closed enhancement (wontfix)

Constant instead of a variable should be used

Reported by: hakre Owned by: ryan
Priority: normal Milestone:
Component: Security Version: 2.9
Severity: normal Keywords:
Cc:

Description

the global variable $wp_default_secret_key is used to determine wether the has provided secret keys or not.

to not get it altered between it's definition and use, the variable should be replaced with a constant.

Change History (4)

comment:1   hakre — 3 years ago

the has = the user has.

comment:2   nacin — 3 years ago

In reviewing #12081 I noticed this ticket.

I'm not sure of the ramifications of preventing it from being changed (or allowing it to be changed), but converting it to a constant will break any plugins that override wp_salt() and utilize the variable.

comment:3   dd32 — 3 years ago

  • Milestone changed from 3.0 to Future Release
  • Type changed from defect (bug) to enhancement

comment:4   nacin — 3 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

There's a reason it's a variable. It gets changed by translators in their locale .php file. Also described in #12081 and previous commits (see svn blame).

Note: See TracTickets for help on using tickets.