Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#11757 closed enhancement (invalid)

redundant logic in max upload size checking

Reported by: Denis-de-Bernardy Owned by:
Priority: normal Milestone:
Component: Upload Version: 3.0
Severity: normal Keywords: multisite
Cc:

Description

There are two functions, upload_is_file_too_big() and check_upload_size(), which appear to be doing something very similar. They should probably be merged.

Change History (5)

comment:1   hakre — 3 years ago

+1; DRY.

comment:2   miqrogroove — 3 years ago

-1 BORED

comment:3   nacin — 3 years ago

  • Keywords multisite added

comment:4   wpmuguru — 3 years ago

  • Resolution set to invalid
  • Status changed from new to closed

Looks are deceiving. They don't serve the same function and are both used via ms hooks.

comment:5   nacin — 3 years ago

  • Milestone 3.0 deleted
Note: See TracTickets for help on using tickets.