general-template.php echo/return fixes

[ShaneF]

There are 3 functions that does have a way to 'return' data:

• get_search_form
• wp_register
• get_calendar

This patch has all the changes. Tested and working! ;-)

removed 'ob_end_clean()'

As a code tidy up this shouldn't be done in a Maintenance release.

Related: #10575. Path attached to that ticket also adds get_calendar filter.

added code from '#10575'

There is one more thing to fix - at the beginning get_calendar() checks if there is a cached version exists, and if yes it takes and displays it. You should also check $echo and use get_calendar filter there.

Copy that. Making the change...

for master rboren

[13048]

Keep in mind that there are output buffer functions in PHP and you can use echo to deal for anything in case that's not provided by the original function:

ob_start();
function_that_echos();
$ouput = ob_get_clean();

and

echo function_that_returns();

---

Related: #7352