Opened 3 years ago
Closed 3 years ago
#11937 closed defect (bug) (fixed)
ID clash in 'Link Categories/Post Tags' Page
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | low | Milestone: | 3.0 |
| Component: | Administration | Version: | 2.9 |
| Severity: | minor | Keywords: | has-patch |
| Cc: | admin@…, ShaneF |
Description
There are 2 elements each with the ID 'name', 'slug' and 'description' in wp-admin/edit-link-categories.php For this reason, the <label> for these items in the Add Link Category part do not point to the respective input boxes.
Attachments (2)
Change History (15)
comment:2
scribu
— 3 years ago
- Component changed from General to Administration
- Priority changed from normal to low
- Severity changed from normal to minor
comment:3
ShaneF
— 3 years ago
- Keywords has-patch commit added; need-patch removed
- Owner set to ShaneF
- Status changed from new to accepted
comment:5
ryan
— 3 years ago
wp_insert_term() expects description and slug. I don't see any mapping from link_description and link_slug back to description and slug.
comment:6
follow-up:
↓ 9
dd32
— 3 years ago
- Keywords needs-patch added; has-patch commit removed
The Edit tags page suffers from this same issue i think.
Its the Table column headers which are conflicting i think, Probably best to give them the id of 'column-$column' instead of modifying the form?
comment:8
ShaneF
— 3 years ago
- Cc ShaneF added
- Keywords has-patch commit added; needs-patch removed
- Summary changed from ID clash in Link Categories Page to ID clash in 'Link Categories/Post Tags' Page
comment:9
in reply to:
↑ 6
ShaneF
— 3 years ago
Replying to dd32:
The Edit tags page suffers from this same issue i think.
Its the Table column headers which are conflicting i think, Probably best to give them the id of 'column-$column' instead of modifying the form?
I looked into this before. All the javascript code would have to be changed to reflect that and it's more than just these two pages that use the same javascript.
comment:10
nacin
— 3 years ago
- Keywords commit removed
- Owner changed from ShaneF to dd32
- Status changed from accepted to assigned
comment:11
dd32
— 3 years ago
Is there a need to change the Fields Names? Its the ID's which are conflicting.
I'm not 100%, But from what i can see, its only the field Labels which are using the ID's.
I'm going to commit a change to the ID's, if people can test and report if they notice anything odd, that'd be appreciated.
comment:12
dd32
— 3 years ago
comment:13
dd32
— 3 years ago
- Resolution set to fixed
- Status changed from assigned to closed
the HTML Validator doesnt mention any issues on the affected pages, and functionality seems to be working still.
Closing as fixed, Re-open if this has caused a bug.
Leaving this at Milestone 3.0. Right now I don't want to change any compatibility with 2.9.x series.