Opened 3 years ago

Last modified 2 years ago

#12134 reviewing enhancement

Add image dimensions to smiley img element

Reported by: niallkennedy Owned by: nacin
Priority: normal Milestone: Future Release
Component: Formatting Version: 3.0
Severity: normal Keywords: dev-feedback
Cc:

Description

All smileys are 15x15. Add dimensions to the img element to avoid a double paint by web browsers during page load.

Attachments (1)

formatting.diff (468 bytes) - added by niallkennedy 3 years ago.
img width and height for smileys

Download all attachments as: .zip

Change History (8)

img width and height for smileys

  • Keywords reporter-feedback added

Why would this be useful, again?

Can't you set the width through CSS?

  • Keywords needs-patch added; has-patch removed

Since the smiley URL passes through a filter, a theme can implement their own, and those may not be 15 x 15.

By specifying image dimensions in HTML, you prevent the browser from reflowing and repainting once the images are loaded.

For reference, here's a quick write-up on it from Page Speed:
http://code.google.com/speed/page-speed/docs/rendering.html#SpecifyImageDimensions

  • Keywords reporter-feedback removed
  • Owner set to nacin
  • Status changed from new to reviewing
  • Milestone changed from Unassigned to Future Release

Future for now.

There's a filter on the smiley src URL. Can't say we will be able to do this.

  • Keywords dev-feedback added; needs-patch removed

Could we add a filter for the image dimensions?

$dims = apply_filters( 'smiley_dimensions', array( 15, 15 ) );
return " <img src='$srcurl' alt='$smiley_masked' class='wp-smiley' width='{$dims[0]}' height='{$dims[1]}' /> ";
Note: See TracTickets for help on using tickets.