Opened 3 years ago

Closed 3 years ago

#12262 closed defect (bug) (fixed)

Adding a Link without URL - Validation Feedback Fail

Reported by: ianatkins Owned by:
Priority: normal Milestone: 3.0
Component: Validation Version: 2.9.1
Severity: normal Keywords: link, validation
Cc:

Description

Submitting the add link form (wp-admin/link-add.php) with no content entered for any fields returns the 'link added' message. When infact the link was not added.

A more intuitive approach would be to validate for the form fields inline, making title and/or URL required field(s).

Change History (4)

comment:1   ianatkins — 3 years ago

  • Version set to 2.9.1

comment:2   nacin — 3 years ago

  • Milestone changed from Unassigned to 3.0

Seems like no message should be shown at all -- that's our general UI response in the admin area for submitting a blank form.

comment:3   nacin — 3 years ago

All that is required is URL. If you omit that, or return an empty form, you'll be routed back to an empty form.

Going to simply remove "Link added." for when that is the case. Validating that a URL was provided would require some heavy refactoring that I don't think is needed.

comment:4   nacin — 3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [13960]) Don't show "Link added." in link-add.php if an empty form was submitted. fixes #12262.

Note: See TracTickets for help on using tickets.