Opened 3 years ago

Closed 3 years ago

#12283 closed defect (bug) (fixed)

Tests do warnings on unset variables

Reported by: hakre Owned by: westi
Priority: normal Milestone: 3.0
Component: Warnings/Notices Version: 3.0
Severity: normal Keywords: has-patch
Cc:

Description

Just a small warning / unset variable. Experienced that in running tests.

Attachments (5)

12283.patch​ (635 bytes) - added by hakre 3 years ago.
12283.2.patch​ (1.2 KB) - added by hakre 3 years ago.
Second patch incl. some $_SERVER defaults in case those are not set (some environments do not set them)
12283.3.patch​ (1.1 KB) - added by hakre 3 years ago.
12283.4.patch​ (476 bytes) - added by hakre 3 years ago.
theme.php only
12283.testsuite.patch​ (568 bytes) - added by hakre 3 years ago.
Patch for the testuite / wp-test.php

Download all attachments as: .zip

Change History (12)

hakre — 3 years ago

hakre — 3 years ago

Second patch incl. some $_SERVER defaults in case those are not set (some environments do not set them)

comment:1   hakre — 3 years ago

  • Summary changed from get_theme_root warns to Tests do warnings on unset variables

Changed the title to better reflect the case. Related: ​My Testrun/TODO.

comment:2   nacin — 3 years ago

The wp-settings.php should be moved into wp_fix_server_vars(). Is this ready to go in, or is this a catch-all ticket?

hakre — 3 years ago

comment:3   hakre — 3 years ago

wp-settings.php moved into wp_fix_server_vars(). This is ready to go on then.

hakre — 3 years ago

theme.php only

comment:4   nacin — 3 years ago

(In [13225]) Fix potential notice. props hakre, see #12283

comment:5   hakre — 3 years ago

I put the leftover changes into wp-test.php now, so this is in here for westi.

hakre — 3 years ago

Patch for the testuite / wp-test.php

comment:7   nacin — 3 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.