WordPress.org

Make WordPress Core

Changes between Initial Version and Version 9 of Ticket #12334

Timestamp:
05/13/10 21:19:21 (3 years ago)
Author:
westi
Comment:

Fix the formatting :-)

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #12334

    • Property Status changed from new to closed
    • Property Cc me@… added
    • Property Milestone changed from Unassigned to 3.0
    • Property Owner set to nacin
    • Property Resolution changed from to fixed

  • Ticket #12334 – Description

    initial v9  
    11In wp-includes/capabilities.php around line 773: 
    2  
     2{{{ 
    33$cap_key = $wpdb->get_blog_prefix( $blog_id ); 
    44$cap_key. 'capabilities'; 
    5  
     5}}} 
    66The author probably meant .= here.   
    77 
    88In wp-admin/import/blogger.php around line 168: 
    9  
     9{{{ 
    1010} elseif ( $tag['tag'] == 'SUMMARY' ) { 
    1111        $blog['summary'] == $tag['value']; 
    12  
     12}}} 
    1313The == on the second line there should obviously be just a single = 
    1414 
    1515In wp-admin/includes/user.php around line 835: 
    16  
     16{{{ 
    1717function default_password_nag_edit_user($user_ID, $old_data) { 
    1818        global $user_ID; 
    19  
     19}}} 
    2020The author overwrites the passed in $user_ID argument with the global version right away.  This makes very little sense.  Choose one or the other. 
    2121 
    2222In wp-includes/class-simplepie.php around line 4070(!!) there are 3 lines of code that don't make sense: 
    23  
     23{{{ 
    2424(int) $seconds = array_pop($temp); 
    2525(int) $minutes = array_pop($temp); 
    2626(int) $hours = array_pop($temp); 
    27  
     27}}} 
    2828Those casts don't do anything.  The author probably meant to put the cast on the right hand side perhaps?