Custom Header Selector

[ryan]

Allow themes to register multiple pre-made headers from which to select. Also allow selecting a solid color header.

Comp

[13319] adds a selection of headers to twentyten. Thumnails for display in the admin UI are suffixed with -thumbnail. We can either have the theme specifically register headers or look for all images in a specific directory in the theme (twentyten uses headers/ but we can change that if needed).

Maybe register_default_header_images('%s/headers/foo.png', '%s/headers/bar.png') where %s is replaced with the template directory as is done with HEADER_IMAGE. Thumbnails are assumed to be the same file names with a -thumbnail.$ext suffix.

register_default_header_images( array('%s/headers/foo.png', '%s/headers/bar.png') )

To register a default color, just put #21759b, etc. in the array.

I've removed the old header from the theme's images directory, and moved the headers directory to %s/images/headers/.

Replying to iammattthomas:

I've removed the old header from the theme's images directory, and moved the headers directory to %s/images/headers/.

In [13333].

I haven't really looked into the custom header code yet, but I noticed that we can probably change/consolidate/remove some of this:

define( 'HEADER_TEXTCOLOR', '');
define( 'HEADER_IMAGE', '%s/images/header-1.jpg'); // %s is theme dir uri
define( 'HEADER_IMAGE_WIDTH', apply_filters( 'twentyten_header_image_width',  940 ) );
define( 'HEADER_IMAGE_HEIGHT', apply_filters( 'twentyten_header_image_height',	198 ) );
define( 'NO_HEADER_TEXT', true );

In particular, my testbed is using HEADER_IMAGE by default, and that image no longer exists.

I think the idea is that we'll use a solid color (no image) by default; although Matt mentioned the possibility of choosing an image based on blog URL or something like that. Depends on if someone wants to make it happen. :)

[13403] first pass.

(In [13404]) Default header selector, second pass. see #12343

Color selection isn't done yet. Needs some styling.

(In [13515]) Fix class name. see #12343

Styles the header selection table to match the mockup

This patch gets us part of the way there on style; once the color selector is in place I'll take another look.

(In [13620]) Header selector styling fixes. Props iammattthomas. see #12343

(In [13621]) Header selector styling fixes. Props iammattthomas. see #12343

As far as I could tell there was nothing for picking background colors yet - just text color.

This patch adds support for a custom background color instead of an image and works the way the original comp described. It also adds some new functions and a default custom header callback to output the new header BG without using the style="" attribute.

comments?

Fixed some problems in IE. Seems to be working pretty well now.

custom background color picker for headers

register_default_headers doesn't properly use %s in child themes. Since %s is substituted for get_template_directory_uri in register_defualt_headers and get_template_directory_uri returns the parent theme uri, child themes can't use %s for it's uri. Ideally we instead have %s substitute the uri for the folder that calls register_defualt_headers or have a paramater for register_default_headers that allows the child themes uri so that both parent and child themes can register default headers.

Allow child themes / plugins to add to the list of default headers and preserve the existing default headers

Currently the default headers are overridden the second time register_default_headers is called. Since child themes might want to keep the list of default headers available, the we should call array_merge the subsequent times it is called. the above patch allows that.

eliminates is_array() from previous diff and cast both property as arrays

(In [13928]) Child theme support for theme header registrations. Second call to register_theme_headers() should add more headers, not replace existing headers. add unregister_theme_headers(). props jorbin. see #12343

See #13231