Ticket #12357 (closed defect (bug): fixed)

Opened 2 years ago

Last modified 23 months ago

Strings we need to hard code and WP_I18N prefix

Reported by: nacin Owned by: nbachiyski
Priority: high Milestone: 3.0
Component: I18N Version:
Severity: blocker Keywords: dev-feedback multisite has-patch
Cc:

Description (last modified by nacin) (diff)

Going over some of the MS initialization I've noticed that there are numerous strings we need to provide WP_I18N prefixes to.

Additionally, we use __() in a few spots (at least one) after l10n.php is included, but before we do the locale. We need to hard-code those, and potentially consider moving down the l10n include as far down as possible in wp-settings.php unless there's something in there that we need earlier.

There's a patch at http://core.trac.wordpress.org/attachment/ticket/11644/11644.no-i18n.diff, though there's a function_exists('__') in there. This clearly won't work as we will only call this function after l10n.php is included but before the locale is loaded.

I think we also need to cut down on the support message in ms_not_installed(). Currently this is broken as don't have l10n.php included at this point but it does expect it to be.

Attachments

early-ms-i18n.diff Download (8.6 KB) - added by nbachiyski 23 months ago.

Change History

  • Description modified (diff)
  • Priority changed from normal to high
  • Severity changed from normal to blocker

Maintenance message also in #12485.

  • Keywords needs-patch multisite added

[13575] removed the calls from ms_not_installed.

  • Keywords needs-patch removed

I think I found all MS strings used before the locale is loaded and wrapped them in WP_I18N comments. I also tested with the extraction script and it all looks fine.

  • Keywords has-patch added
  • Status changed from new to closed
  • Resolution set to fixed

(In [13797]) Wrap transtable strings used in Network install in WP_I18N_SOMETHING, because translations still aren't loaded. Fixes #12357

Note: See TracTickets for help on using tickets.