Opened 3 years ago
Last modified 3 years ago
#12425 closed enhancement
Fallback theme code is not translatable / default theme in theme repo is not translatable — at Version 12
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | high | Milestone: | 3.0 |
| Component: | General | Version: | 3.0 |
| Severity: | major | Keywords: | needs-patch |
| Cc: |
Description (last modified by westi)
Should we switch them both to the I18N version of kubrick/default
Change History (13)
Denis-de-Bernardy — 3 years ago
- Keywords needs-patch 2nd-opinion added; has-patch commit removed
- Resolution fixed deleted
- Status changed from closed to reopened
re-opening, because I'm foreseeing a possibly trickier issue.
consider a user with the simplest theme possible. two files, index.php and style.css, that currently relies on get_header(), get_sidebar() and get_footer(). that user is currently relying on the default theme. making him use twentyten all of the sudden makes no sense.
in other words, we should: during the upgrade, add an option with a value of default; and during installs, add an option with a value of twentyten. and then use the option to set the define.
alternatively, we could tell these handful of users (there can't be that many) to add the appropriate define in their wp-config.php file. in this case, the existing fix works wonders.
comment:3
technosailor — 3 years ago
In an upgrade, unless the user explicityl removes the default (Kubrick) theme, it will still be there. In a 3.0 install, they would get twentyten. I don't see this being any more of an edge case and suggest we close as invalid.
- Keywords 2nd-opinion removed
- Owner set to westi
- Status changed from reopened to accepted
Working on a solution to this as well as #13009
- Resolution set to fixed
- Status changed from accepted to closed
westi, does theme-compat need to be localized or leave it as is? If yes, what's the domain for it? none?
- Resolution fixed deleted
- Status changed from closed to reopened
I think we can use the i18n version, in the kubrick/default textdomain. If it's not loaded, then we get English, that's fine too. If it doesn't exist, the theme wouldn't work anyway.
That said, wondering if we can just fall back to kubrick, and forgo theme-compat. If it doesn't exist, the theme wouldn't work anyway.
see kubrick/default: http://svn.automattic.com/wordpress-i18n/theme/trunk/
comment:10
westi — 3 years ago
I went for untranslated to hi-light it more as being a dead-end.
Also I copied the files from the WordPress Extend version of the default theme so if we are going to use the I18N one we should update that as well as otherwise when people apply the suggested fix to there theme they will lose the translation goodness.
comment:11
zeo — 3 years ago
Is there anyone still using comments-popup.php?
How about just copy from i18n repos to extend theme repos. But the Default theme in Extend is out of reach. How to submit patches? Themes trac seems dead anyway.
comment:12
westi — 3 years ago
- Description modified (diff)
- Priority changed from normal to high
- Severity changed from normal to major
- Summary changed from allow to override the fallback theme to Fallback theme code is not translatable / default theme in theme repo is not translatable
Retitling to reflect current issues.
Raising Priority.

(In [13500]) Allow WP_FALLBACK_THEME to be overridden. Props Denis-de-Bernardy. Fixes #12425