Metaboxes options ignored

[scribu]

Steps to reproduce

On any admin page with meta boxes:

1. Open Screen Options.

2. Uncheck one of the metabox titles, to hide it.

3. Refresh page.

Expected result

Box stays hidden.

Actual result

Hidden metaboxes are reset to default values.

I've traced the error to get_hidden_meta_boxes() -> get_user_option().

Add $wpdb->prefix.

The problem was that get_user_option() first looks for blog-specific options, but the AJAX calls updated the user-specific options.

12439.diff fixes this.

use update_user_option() instead of update_user_meta()

Remove $option = preg_replace('|[^{a-z0-9_]|i', , $option);}

12439.2.diff uses update_user_option(), making it compatible with get_user_option().

12439.3.diff takes a more "radical" approach and removes the $option = preg_replace('|[^a-z0-9_]|i', '', $option); filter. It has the short-term drawback that users will loose their customizations when upgrading.

scratch that, its working on the dashboard and built in edit pages, but not on custom post_type pages.

take care of custom post types

With 12439.4.diff metaboxes on editing screens other than posts should work too.

That patch seems to have fixed the custom post_types now.

(In [13551]) Fix metabox hiding. Props scribu. fixes #12439