Fix title and h1 elements for Twenty Ten theme
|Reported by:||mikeschinkel||Owned by:||iammattthomas|
There are several problems with the Twenty Ten theme related to use when a static front page is used. I have attached a patch to resolve these issues.
The issues include the display of the page title on a static home page, which should be omitted, and the <div id=site-title> in the header should instead be an <h1> element when on the front page. I made these fixes in page.php and onecolumn-page.php.
In addition when using a static home page the title element gets "<site-name> | <site-description>" for both the front page and the posts page. It should get it just for the front page and for the posts page use "<post-name> | <site-name>" instead.
Finally, I added two helper functions in the function.php file: is_root_page() and the_header_title_element().
This patch addresses use-case applicability (i.e. removing the page title from the front page) and improved semantics/optimized seo (using the <title> and <h1> elements on the front page as search engines would expect and to help search engines differentiate between front page and posts page.)
The patch may not be coded as the core devs would like and that's okay but these fixes really do need to be added one way or another. Please.
Change History (25)
comment:9 follow-up: ↓ 10 iammattthomas — 4 years ago
- Resolution set to fixed
- Status changed from assigned to closed
comment:10 in reply to: ↑ 9 mikeschinkel — 4 years ago
- Resolution fixed deleted
- Status changed from closed to reopened