Ticket #12576 (closed enhancement: fixed)

Opened 2 years ago

Last modified 23 months ago

Password Strength Meter Should Compair Both Fields

Reported by: dancole Owned by: dancole
Priority: high Milestone: 3.0
Component: Users Version: 3.0
Severity: normal Keywords: dev-feedback
Cc:

Description

The password strength meter should tell the user if the two password fields don't match. This feature is not longer just in the user profile, it's also on the install page. I think users would expect it to tell them if their password fields didn't match without submitting the page.

Attachments

js_pass_check_a.diff Download (4.1 KB) - added by dancole 2 years ago.
File from Ticket #10396

Change History

comment:1   dancole — 2 years ago

  • Keywords dev-feedback added

I'm moving this to a new ticket from #10396

Replying to dd32:

This lacks Javascript feedback on mis-matching passwords, Does someone feel like taking a stab at that?

Replying to dancole:

js_pass_check_a.diff is a development only patch for checking the second password field against the first. I tested out the code and it works perfect. Might want to check over the coding standards though. I didn't change the JavaScript files that are actually being used because I don't know how to minimize them.

Replying to dd32:

I'm not sure we should modify the password strength script, But at the same time, i'm not sure adding another one is suitable either.

What are other developers thoughts on that?

dancole — 2 years ago

File from Ticket #10396

comment:2   dd32 — 2 years ago

  • Priority changed from normal to high

Just pushing the priority higher, IMO, Some feedback should be provided. Since this is used in the installer as well, it would be best to inform them.

comment:3   dd32 — 23 months ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [13900]) Add Password Mismatch feedback to the Password Strength Meter. Props dancole. Fixes #12576

Note: See TracTickets for help on using tickets.