Detached media sorted in reverse by date

[sbressler]

Media that's unattached to any post (i.e. at this page: "/wp-admin/upload.php?detached=1" for a WP install) seems to be sorted by post_date ascending (starting with the oldest media) rather than descending. I was able to replicate this in WP 2.9.1, WP 2.9.2 MU and WP 3.0.

I couldn't quite find the correct line to fix, but line 305 of media.php does correct sorting:

$arc_query = "SELECT DISTINCT YEAR(post_date) AS yyear, MONTH(post_date) AS mmonth FROM $wpdb->posts WHERE post_type = 'attachment' ORDER BY post_date DESC";

So it must be somewhere else since that query doesn't run if loading detached media.

Depending on the situation, it's one of these queries:

// when searching for orphaned attachments (had a parent).
$orphans = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM $wpdb->posts WHERE post_type = 'attachment' AND ID IN (%s) LIMIT %d, %d", $lost, $start, $media_per_page ) );
// when searching for attachments without a parent (and never had one).
$orphans = $wpdb->get_results( $wpdb->prepare( "SELECT SQL_CALC_FOUND_ROWS * FROM $wpdb->posts WHERE post_type = 'attachment' AND post_status != 'trash' AND post_parent < 1 LIMIT %d, %d", $start, $media_per_page ) );

My first stab at a patch

Is there something else that should be done before this is considered "commitable" to core?

Assuming it works and doesn't break anything, consider it good for 3.1.

Just to report my testing, it worked excellently for me and didn't break anything. I only barely know how the automated tests are integrated in WP, but I don't think this needs one. Unattached media were properly sorted when I applied my patch above.

Looks good.

Patch no longer applies.

Items sort descending for me. It might have been fixed in scribu's table work.

Yep, just confirmed that this works now in 3.1 with scribu's work!