Opened 3 years ago

Last modified 5 months ago

#12789 new defect (bug)

Inconsistent left or right margins on admin screens

Reported by: scribu Owned by:
Priority: low Milestone: Future Release
Component: Administration Version:
Severity: minor Keywords: needs-patch
Cc: TECannon

Description

There are a couple of admin screens where the screen icon is not aligned to the left of the content.

Attachments (6)

dashboard.jpg (22.3 KB) - added by scribu 3 years ago.
settings.jpg (20.2 KB) - added by scribu 3 years ago.
12789.diff (1.3 KB) - added by scribu 3 years ago.
dashboard CSS fix
12789-new.diff (357 bytes) - added by andrewryno 2 years ago.
list-table.png (13.5 KB) - added by scribu 18 months ago.
12789.2.diff (508 bytes) - added by helenyhou 5 months ago.

Download all attachments as: .zip

Change History (16)

scribu3 years ago

scribu3 years ago

  • Keywords has-patch needs-testing added

scribu3 years ago

dashboard CSS fix

  • Milestone changed from 3.0 to Future Release
  • Priority changed from normal to low
  • Severity changed from normal to minor

Incomplete patch, and the current patch for the dashboard will need to be confirmed for all browsers. (IE doesn't support adjacent selectors until v8 I think.) Very trivial, we can handle this in a future release.

  • Cc TECannon added

Adding fix for dashboard page. Left margin inconsistency on settings page is due to padding on the table cell for the label. I think that might be addressed in #16413. Also, the icon may never exactly match up since some of the images are skinnier than the div and have extra space on either side once in a while. Don't know if left-aligning that image would be a good idea though.

This patch also doesn't rely on the adjacent selector, so it works in versions of IE as well.

Last edited 2 years ago by andrewryno (previous) (diff)

It's actually worse now, since it doesn't allign with the new header either.

Last edited 18 months ago by scribu (previous) (diff)

Nevermind that last comment, I was on 3.2.

  • Keywords needs-patch added; has-patch needs-testing removed
  • Summary changed from Inconsistent left margin on admin screens to Inconsistent left or right margins on admin screens

Notice the misalignment between:

  • the user avatar (2px)
  • the help tab (-9px)
  • the search button (-1px)
  • the pagination button (-1px)
  • the table

http://core.trac.wordpress.org/raw-attachment/ticket/12789/list-table.png

Last edited 18 months ago by scribu (previous) (diff)
  • Component changed from UI to Administration

Going through old tickets. What still remains? I only see that the screen meta stuff isn't aligned on either side. Added a patch for that, since I was looking at it already.

Note: See TracTickets for help on using tickets.