Opened 3 years ago
Closed 3 years ago
#12919 closed defect (bug) (fixed)
Show details link on plugin upgrade doesn't change when expanded
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.0 |
| Component: | Upgrade/Install | Version: | 3.0 |
| Severity: | normal | Keywords: | has-patch |
| Cc: |
Description
When bulk upgrading plugins, for each one there is a notice which reads "{{plugin}} updated successfully. See Details."
Clicking See Details shows each step of the upgrade. But the text "See Details" remains.
It should change to "Hide Details" instead.
Latest nightly as of 8th April.
Attachments (2)
Change History (10)
- Keywords has-patch added; needs-patch removed
In 12919.patch I replaced it with Show Details and Hide Details.
We probably need some hide-if-no-js support there.
I haven't had the chance to look through the UI in #11232. Probably this weekend.
nacin, good point, I have add the no-js support to the iframe and add the hide-if-no-js classes in 12919.1.patch.
the JS classes will not operate properly in this case, The Javascript runs on document load, the document doesnt load until all upgrades are complete, which leads to a mass jump at the end to close the boxes...
Or at least, thats how it worked when i wrote that skin.
Actually.. that comment was entirely wrong on many levels. However, that patch wont work as expected.
The reasoning is, that the no-js Javascript is not included on iframe pages.

Should probably be replaced with "Show Details" (and "Hide Details")