WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#13016 closed defect (bug) (fixed)

Clean up of HTML comments in comment_form()

Reported by: iandstewart Owned by:
Priority: normal Milestone: 3.0
Component: Themes Version: 3.0
Severity: normal Keywords:
Cc:

Description

The HTML comments in comment_form() need updating.

Attachments (2)

comment-template.diff​ (2.2 KB) - added by iandstewart 3 years ago.
comment-template.2.diff​ (2.1 KB) - added by iandstewart 3 years ago.
Remove HTML comments from inside comment_form()

Download all attachments as: .zip

Change History (10)

iandstewart — 3 years ago

comment:1 follow-up: nacin — 3 years ago

  • Milestone changed from Unassigned to 3.0

Is there a reason to keep those at all?

comment:2 in reply to: ↑ 1 iandstewart — 3 years ago

They're handy when looking at the page source--but not necessary, no.

comment:3 follow-up: markmcwilliams — 3 years ago

A quick 5 minute chat at the Developer Chat tonight might be appropriate to answer this question? :)

comment:4 in reply to: ↑ 3 nacin — 3 years ago

I only ask because there's rather little markup going into a comment form between the start and end tags.

iandstewart — 3 years ago

Remove HTML comments from inside comment_form()

comment:5 iandstewart — 3 years ago

Good point, nacin. I removed the comments completely in comment-template.2.diff.

comment:6 nacin — 3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [14092]) Update the html comments in comment_form(). props iandstewart, fixes #13016.

comment:7 nacin — 3 years ago

(In [14093]) Spacing/coding cleanup of comment_form(). see #13016.

comment:8 nacin — 3 years ago

  • Component changed from General to Themes

comment-template.2.diff

I did the exact same independently. Nice stuff.

This also gave me an excuse to clean up some of the crazy tabbing going on there.

A quick 5 minute chat at the Developer Chat tonight might be appropriate

We need to reserve the chats for meaningful things that require the attention of the core developers and contributors at once. This is not even close to one of those times.

Note: See TracTickets for help on using tickets.